phasegate 0.127.0 → 0.129.0

package/CHANGELOG.md

@@ -7,6 +7,33 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.129.0] - 2026-05-08
+
+### Fixed
+
+- **WI-092 — `createValidatorSystemModule()` 残 5 site の config threading 漏れを sweep** — v0.128.0 で `validate --layer L4` 経路のみ修正した DI 配線漏れの follow-up として、harness-api / pre-commit 経路でも user config (`layers.L2/L3/L4.enabled`) が validator-system composition root に渡るよう修正。
+  - **対象**: `ValidatorSystemExecutionAdapter` の `runL3Validators()` / `runAllValidators()` / `runDriftDetection()`、および `runPreCommitCli()` / `runCommitMsgCli()` の計 5 site。
+  - **共通 translator 化**: `toValidatorSystemConfig()` を `config-foundation/application/mappers/validator-system-config-mapper.ts` に移動し、`main.ts` / harness-api adapter / pre-commit CLI から共通利用。渡す値は `project.preset` と `layers.L2/L3/L4.enabled` のみに限定し、`validators` 配列は渡さない。validator catalog は validator-system の default 解決に委ねる。
+  - **fallback**: `phasegate.config.json` 不在時のみ validator-system の default config にフォールバック。不正 config は従来通り runtime error として扱う。
+  - **検証 (publish 前 local/self-host)**: PhaseGate 自身の `phasegate.config.json` (`layers.L4.enabled: false`) で `validate --layer L4` は exit 0 / PASS / validator 0 件。`phasegate:detect-drift --json` は drift detection direct 経路を維持し、既存 drift 2065 件により exit 1。
+  - **テスト**: `pnpm test` は 452 files / 3518 tests pass。対象テスト 3 files / 11 tests pass。変更ファイルの `validate-metadata` pass。
+  - **post-publish dogfood**: npm publish 後に、別ディレクトリで `npx phasegate@0.129.0` を使って `phasegate:detect-drift` / `validate --layer L4` / pre-commit 経路を確認する。
+
+## [0.128.0] - 2026-05-08
+
+### Fixed
+
+- **WI-091 finding #1 follow-up — `validate --layer L4` で `layers.L4.enabled: false` が runtime で実際に機能するよう composition root に config を thread (GitHub Issue #4)** — v0.127.0 publish 後の dogfood (`/tmp/phasegate-dogfood-wi091`, phasegate@0.127.0) で finding #1 の修正が runtime で機能していないことが判明したため緊急修正。
+  - **症状**: `phasegate.config.json` に `layers.L4.enabled: false` を設定して `phasegate validate --layer L4` を実行しても、L4-001/002 が `[PASS]` (実際には実行された) となり、L4-003 だけが `[SKIP]` (strictOnly のため)。期待挙動は L4-001/002/003 すべて `[SKIP]`。
+  - **根本原因**: `scripts/harness/main.ts:979` の `validate` case で `createValidatorSystemModule()` が config 引数なしで呼ばれており、`composition-root.ts:111-114` の `const configData = (config ?? DEFAULT_CONFIG)` で常に `DEFAULT_CONFIG` (L4.enabled=true) が使われていた。WI-091 finding #1 で `RunL4ValidatorsUseCase` に追加した gate (`if (!layerConfig.enabled) return [];`) はソースに正しく入っていたが、上流 DI で user の config が threading されていないため runtime で常に enabled=true 判定となり gate が hit せず drift / consistency / dead-code service が呼ばれていた。WI-085 retrospective (`feedback_dogfood_before_release.md`) で記録した「composition root の DI 配線漏れ」と同種の bug が再発した形。
+  - **修正**: `main.ts` に `toValidatorSystemConfig(resolvedConfig: HarnessConfigV2 | undefined)` translator を追加し、HarnessConfigV2 から validator-system が期待する shape (`{ project: { preset }, layers: { L2/L3/L4: { enabled } } }`) に変換。`validate` case で `createValidatorSystemModule(toValidatorSystemConfig(resolvedConfig))` を呼ぶように修正。`validators` field は thread しない設計判断 — preset-style の `["drift-detector"]` が validator-code-style の `L4-001/002/003` を override し全 SKIP になる症状を回避するため、`validators` の解決は composition root 側の `defaultValidators[layer]` フォールバックに委ねる。
+  - **テスト**: spawn 経由結合テスト 2 ケース (`scripts/harness/__tests__/integration/harness-api/validate-layer-config.integration.test.ts`) 新規追加:
+    - `layers.L4.enabled: false` で `validate --layer L4` 実行時、L4 全 validator が `[SKIP]` 表示 + 総合判定 PASS + exit 0
+    - `layers.L4.enabled: true` で L4 validator が enabled で実行 (回帰防止)
+  - 全 3516 テスト (前回 3514 + 新規 2) グリーン、L1 lint 違反なし。
+  - **スコープ外 (別 follow-up commit で対応)**: 同種の DI 配線漏れが `harness-api/infrastructure/adapters/validator-system-execution-adapter.ts:27/38/51` (phasegate:detect-drift / phasegate:check-ready 等の harness-api flow) と `integrations/pre-commit.ts:306/338` (Husky pre-commit) にも存在するが、別ハンドラ経路で `resolvedConfig` がスコープ外のため別途修正。
+  - **教訓 (memory 反映)**: `feedback_dogfood_before_release.md` に「`paths` config / Artifact / PhaseConfigProviderPort 改修」と並べて「composition root の `createValidatorSystemModule(config?)` 経路」を追記。`createValidatorSystemModule()` を呼ぶ全 site (現状 6 箇所) で config が threading されているか毎回 grep 確認する規律を強化する。
+
 ## [0.127.0] - 2026-05-08
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "phasegate",
-  "version": "0.127.0",
+  "version": "0.129.0",
   "packageManager": "pnpm@10.30.1",
   "description": "Phasegate — AI-agnostic quality defense toolkit. Enforces structural integrity between design intent and code.",
   "license": "MIT",

package/scripts/harness/config-foundation/application/mappers/validator-system-config-mapper.ts

@@ -0,0 +1,19 @@
+/**
+ * @layer application
+ * @unit config-foundation
+ * @work-item-id WI-092
+ */
+import type { HarnessConfigV2 } from '../../domain/harness-config.js';
+
+export function toValidatorSystemConfig(resolvedConfig: HarnessConfigV2 | undefined): object | undefined {
+  if (!resolvedConfig) return undefined;
+
+  return {
+    project: { preset: resolvedConfig.project.preset },
+    layers: {
+      L2: { enabled: resolvedConfig.layers.L2.enabled },
+      L3: { enabled: resolvedConfig.layers.L3.enabled },
+      L4: { enabled: resolvedConfig.layers.L4.enabled },
+    },
+  };
+}

package/scripts/harness/config-foundation/index.ts

@@ -4,6 +4,7 @@
 export { createConfigFoundationModule } from './composition-root.js';
 
 export { LoadResolvedConfigUseCase } from './application/usecases/load-resolved-config-use-case.js';
+export { toValidatorSystemConfig } from './application/mappers/validator-system-config-mapper.js';
 
 export type { ResolvedConfigOutput } from './application/dto/resolved-config-output.js';
 export type { FeatureToggleResult } from './application/dto/feature-toggle-result.js';

package/scripts/harness/harness-api/infrastructure/adapters/validator-system-execution-adapter.ts

@@ -1,10 +1,14 @@
+// @unit harness-api
 // @layer infrastructure
+// @work-item-id WI-092
 // validator-system-execution-adapter.ts — ValidatorSystemExecutionAdapter
 // Wave 2完了後にリアル実装へ差し替え（旧: @stub: wave2-pending）
 
 import type { ValidatorExecutionPort } from '../../domain/ports/validator-execution-port.js';
 import type { ValidatorCheckItem } from '../../domain/value-objects/ci-check-result.js';
 import type { DriftItem } from '../../domain/value-objects/drift-report-summary.js';
+import { toValidatorSystemConfig } from '../../../config-foundation/application/mappers/validator-system-config-mapper.js';
+import { ConfigNotFoundError } from '../../../config-foundation/infrastructure/repositories/file-system-config-repository.js';
 
 // Override interface preserved for testing
 export interface IValidatorSystemStub {
@@ -21,10 +25,22 @@ export class ValidatorSystemExecutionAdapter implements ValidatorExecutionPort {
   }
 
   private static createRealImpl(): IValidatorSystemStub {
+    async function loadValidatorSystemConfig(): Promise<object | undefined> {
+      const { createConfigFoundationModule } = await import('../../../config-foundation/composition-root.js');
+      const configMod = createConfigFoundationModule();
+      try {
+        const resolvedConfig = await configMod.usecases.loadResolvedConfigUseCase.execute();
+        return toValidatorSystemConfig(resolvedConfig.config);
+      } catch (err) {
+        if (err instanceof ConfigNotFoundError) return undefined;
+        throw err;
+      }
+    }
+
     return {
       async runL3Validators(): Promise<ValidatorCheckItem[]> {
         const { createValidatorSystemModule } = await import('../../../validator-system/composition-root.js');
-        const mod = createValidatorSystemModule();
+        const mod = createValidatorSystemModule(await loadValidatorSystemConfig());
         const results = await mod.runL3ValidatorsUseCase.execute({ targetPaths: [] });
         return results.map((r) => ({
           validatorId: r.validatorId,
@@ -35,7 +51,7 @@ export class ValidatorSystemExecutionAdapter implements ValidatorExecutionPort {
 
       async runAllValidators(): Promise<ValidatorCheckItem[]> {
         const { createValidatorSystemModule } = await import('../../../validator-system/composition-root.js');
-        const mod = createValidatorSystemModule();
+        const mod = createValidatorSystemModule(await loadValidatorSystemConfig());
         const report = await mod.runFullValidationUseCase.execute({ targetPaths: [], unitName: '', currentPhase: '' });
         return report.results.map((r) => ({
           validatorId: r.validatorId,
@@ -48,7 +64,7 @@ export class ValidatorSystemExecutionAdapter implements ValidatorExecutionPort {
         // ISSUE-005 P1-5: L4-001 の DriftDetectionService を直接呼び出し、
         // phasegate:detect-drift と validate --layer L4 の結果を一致させる
         const { createValidatorSystemModule } = await import('../../../validator-system/composition-root.js');
-        const mod = createValidatorSystemModule();
+        const mod = createValidatorSystemModule(await loadValidatorSystemConfig());
         const reports = await mod.driftDetectionService.detect();
         return reports.map((r) => ({
           direction: r.direction,

package/scripts/harness/integrations/pre-commit.ts

@@ -1,6 +1,7 @@
 /**
  * @unit harness-api
  * @layer presentation
+ * @work-item-id WI-092
  *
  * Pre-commit CLI entry.
  * Runs L2 validators against staged TypeScript files AND design-document
@@ -15,6 +16,9 @@
 
 import { execSync } from "node:child_process";
 import { readFile } from "node:fs/promises";
+import { createConfigFoundationModule } from "../config-foundation/composition-root.js";
+import { toValidatorSystemConfig } from "../config-foundation/application/mappers/validator-system-config-mapper.js";
+import { ConfigNotFoundError } from "../config-foundation/infrastructure/repositories/file-system-config-repository.js";
 import { createTraceabilityModelModule } from "../traceability-model/composition-root.js";
 import type { ValidateMetadataCommandOutput } from "../traceability-model/presentation/cli/validate-metadata-command-handler.js";
 import type { AggregatedValidationReport } from "../validator-system/application/dto/aggregated-validation-report.js";
@@ -34,6 +38,17 @@ const WORK_ITEM_PATH_PATTERN = /(?:^|\/)WI-\d+(?:\/|$)/;
 const WORK_ITEM_TRAILER_PATTERN = /^Work-Item:\s*WI-\d+\s*$/m;
 const TEST_FILE_SUFFIXES = Object.freeze([".test.ts", ".test.tsx", ".spec.ts", ".spec.tsx"]);
 
+async function loadValidatorSystemConfig(): Promise<object | undefined> {
+  const configMod = createConfigFoundationModule();
+  try {
+    const resolvedConfig = await configMod.usecases.loadResolvedConfigUseCase.execute();
+    return toValidatorSystemConfig(resolvedConfig.config);
+  } catch (err) {
+    if (err instanceof ConfigNotFoundError) return undefined;
+    throw err;
+  }
+}
+
 function isTestFile(path: string): boolean {
   return TEST_FILE_SUFFIXES.some((suffix) => path.endsWith(suffix));
 }
@@ -303,7 +318,7 @@ export async function runPreCommit(
 export async function runPreCommitCli(): Promise<void> {
   try {
     const stagedFiles = getStagedFiles();
-    const validatorMod = createValidatorSystemModule();
+    const validatorMod = createValidatorSystemModule(await loadValidatorSystemConfig());
     const traceabilityMod = createTraceabilityModelModule(process.cwd());
 
     const result = await runPreCommit(
@@ -335,7 +350,7 @@ export async function runCommitMsgCli(commitMessagePath: string | undefined): Pr
 
     const stagedFiles = getStagedFiles();
     const commitMessage = await readFile(commitMessagePath, "utf-8");
-    const validatorMod = createValidatorSystemModule();
+    const validatorMod = createValidatorSystemModule(await loadValidatorSystemConfig());
     const traceabilityMod = createTraceabilityModelModule(process.cwd());
 
     const result = await runPreCommit(

package/scripts/harness/main.ts

@@ -14,6 +14,7 @@ import { createAdrFoundationModule } from "./adr-foundation/composition-root.js"
 import { createBiomeAstEngineModule } from "./biome-ast-engine/composition-root.js";
 import { buildCiGovernance } from "./ci-governance/composition-root.js";
 import { toPhaseConfigSection } from "./config-foundation/application/mappers/phase-config-section-mapper.js";
+import { toValidatorSystemConfig } from "./config-foundation/application/mappers/validator-system-config-mapper.js";
 import { createConfigFoundationModule } from "./config-foundation/composition-root.js";
 import { ConfigValidationError } from "./config-foundation/domain/errors/config-validation-error.js";
 import type { HarnessConfigV2 } from "./config-foundation/domain/harness-config.js";
@@ -976,7 +977,7 @@ async function main(): Promise<void> {
 
       // ── validator-system ──
       case "validate": {
-        const mod = createValidatorSystemModule();
+        const mod = createValidatorSystemModule(toValidatorSystemConfig(resolvedConfig));
         const layer = parseFlag(args, "--layer") as "L0" | "L2" | "L3" | "L4" | "all" | undefined;
         const unit = parseFlag(args, "--unit");
         const phase = parseFlag(args, "--phase");