pgserve 1.1.7-rc.2 → 1.1.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pgserve",
-  "version": "1.1.7-rc.2",
+  "version": "1.1.8",
   "description": "Embedded PostgreSQL server with true concurrent connections - zero config, auto-provision databases",
   "main": "src/index.js",
   "type": "module",

package/src/postgres.js

@@ -965,11 +965,23 @@ export class PostgresManager {
     this.logger.info('pgvector extension files not found — downloading prebuilt binary...');
 
     try {
-      // Detect PG major version from the postgres binary
+      // Detect PG major version from the postgres binary.
+      // `postgres --version` output is `postgres (PostgreSQL) 18.2`, so the
+      // regex must tolerate the `)` that separates the product name from the
+      // version number. The previous pattern `/PostgreSQL (\d+)/` expected a
+      // digit immediately after `PostgreSQL ` and silently fell back to '17'
+      // on PG 14+, causing the wrong pgvector .deb to be downloaded and a
+      // later "incompatible library version mismatch" at CREATE EXTENSION time.
       const { execSync } = await import('node:child_process');
       const pgVersion = execSync(`${this.binaries.postgres} --version`, { encoding: 'utf-8' }).trim();
-      const majorMatch = pgVersion.match(/PostgreSQL (\d+)/);
-      const pgMajor = majorMatch ? majorMatch[1] : '17';
+      const majorMatch = pgVersion.match(/PostgreSQL\)?\s+(\d+)/);
+      if (!majorMatch) {
+        throw new Error(
+          `Could not detect PostgreSQL major version from: ${JSON.stringify(pgVersion)}`
+        );
+      }
+      const pgMajor = majorMatch[1];
+      this.logger.info({ pgMajor, pgVersion }, 'Detected PostgreSQL major version for pgvector install');
 
       // Detect architecture — fail explicitly on unsupported platforms
       const nodeArch = os.arch();

package/tests/pg-version-regex.test.js

@@ -0,0 +1,48 @@
+/**
+ * Regression test for pgvector auto-installer PG-major detection.
+ *
+ * `postgres --version` prints `postgres (PostgreSQL) 18.2`, so the regex that
+ * extracts the major version must tolerate the closing `)` between the
+ * product name and the number. An earlier pattern `/PostgreSQL (\d+)/`
+ * expected a digit immediately after `PostgreSQL ` and silently fell back to
+ * a hard-coded `'17'` default on PG14+, causing the wrong pgvector .deb to be
+ * downloaded and a later "incompatible library version mismatch" when
+ * `CREATE EXTENSION vector` was executed against a PG18 server.
+ *
+ * This test pins the corrected regex so the regression can't sneak back in.
+ */
+
+import { test, expect, describe } from 'bun:test';
+
+// Keep this in sync with `ensurePgvectorFiles()` in src/postgres.js
+const PG_VERSION_REGEX = /PostgreSQL\)?\s+(\d+)/;
+
+function detectMajor(versionString) {
+  const match = versionString.match(PG_VERSION_REGEX);
+  return match ? match[1] : null;
+}
+
+describe('PG major version detection for pgvector auto-install', () => {
+  test('parses "postgres (PostgreSQL) X.Y" format (actual postgres --version output)', () => {
+    expect(detectMajor('postgres (PostgreSQL) 18.2')).toBe('18');
+    expect(detectMajor('postgres (PostgreSQL) 17.4')).toBe('17');
+    expect(detectMajor('postgres (PostgreSQL) 16.0')).toBe('16');
+    expect(detectMajor('postgres (PostgreSQL) 14.11')).toBe('14');
+  });
+
+  test('parses pre-release labels', () => {
+    expect(detectMajor('postgres (PostgreSQL) 18.2-beta.1')).toBe('18');
+    expect(detectMajor('postgres (PostgreSQL) 18devel')).toBe('18');
+  });
+
+  test('parses bare "PostgreSQL X" format (no parentheses)', () => {
+    expect(detectMajor('PostgreSQL 18.2')).toBe('18');
+    expect(detectMajor('PostgreSQL 17')).toBe('17');
+  });
+
+  test('returns null on unparseable input so caller can fail loudly', () => {
+    expect(detectMajor('')).toBeNull();
+    expect(detectMajor('not postgres')).toBeNull();
+    expect(detectMajor('mysql 8.0')).toBeNull();
+  });
+});