pg-promise 10.5.0-beta.0 → 10.5.2

package/README.md

@@ -974,7 +974,7 @@ db.txIf({cnd}, t => {
 This library manages all database connections via the [connection pool], which internally caches them.
 
 Connections in the cache expire due to inactivity after [idleTimeoutMillis] number of milliseconds, which you
-can set when creating the [Database] object. 
+can set only when creating the [Database] object. 
 
 While there is a single open connection in the pool, the process cannot terminate by itself, only via `process.exit()`. 
 If you want the process to finish by itself, without waiting for all connections in the pool to expire, you need

package/lib/connect.js

@@ -45,7 +45,6 @@ function poolConnect(ctx, db, config) {
                         enumerable: false,
                         writable: true
                     });
-                    hidePassword(client); // See: https://github.com/brianc/node-postgres/issues/1568
                     setSchema(client, ctx);
                 }
                 setCtx(client, ctx);
@@ -78,7 +77,6 @@ function directConnect(ctx, config) {
                 });
                 reject(err);
             } else {
-                hidePassword(client); // See: https://github.com/brianc/node-postgres/issues/1568
                 setSchema(client, ctx);
                 setCtx(client, ctx);
                 const end = lockClientEnd(client);
@@ -142,16 +140,6 @@ function setCtx(client, ctx) {
     });
 }
 
-// See: https://github.com/brianc/node-postgres/issues/1568
-function hidePassword(client) {
-    hideProperty(client, `password`);
-    hideProperty(client.connectionParameters, `password`);
-}
-
-function hideProperty(obj, prop) {
-    Object.defineProperty(obj, prop, {value: obj[prop], enumerable: false});
-}
-
 function setSchema(client, ctx) {
     let s = ctx.options.schema;
     if (!s) {

package/lib/utils/index.js

@@ -80,6 +80,7 @@ function addReadProp(obj, name, value, hidden) {
 // Converts a connection string or object into its safe copy:
 // if password is present, it is masked with symbol '#'.
 function getSafeConnection(cn) {
+    const maskPassword = cs => cs.replace(/:(?![/])([^@]+)/, (_, m) => `:` + new Array(m.length + 1).join(`#`));
     if (typeof cn === `object`) {
         const copy = Object.assign({}, cn);
         if (typeof copy.password === `string`) {
@@ -93,14 +94,6 @@ function getSafeConnection(cn) {
     return maskPassword(cn);
 }
 
-///////////////////////////////////////////////////////////
-// Replaces password letters with # in a connection string.
-function maskPassword(connectionString) {
-    return connectionString.replace(/:(?![/])([^@]+)/, (_, m) => {
-        return `:` + new Array(m.length + 1).join(`#`);
-    });
-}
-
 ///////////////////////////////////////////
 // Returns a space gap for console output;
 function messageGap(level) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pg-promise",
-  "version": "10.5.0-beta.0",
+  "version": "10.5.2",
   "description": "PostgreSQL interface for Node.js",
   "main": "lib/index.js",
   "typings": "typescript/pg-promise.d.ts",
@@ -41,21 +41,21 @@
   },
   "dependencies": {
     "assert-options": "0.6.1",
-    "pg": "8.0.0",
+    "pg": "8.0.3",
     "pg-minify": "1.5.2",
     "spex": "3.0.1"
   },
   "devDependencies": {
-    "@types/node": "13.9.5",
+    "@types/node": "13.13.2",
     "JSONStream": "1.3.5",
     "bluebird": "3.7.2",
-    "coveralls": "3.0.11",
+    "coveralls": "3.0.13",
     "eslint": "6.8.0",
-    "tslint": "6.1.0",
+    "tslint": "6.1.1",
     "istanbul": "0.4.5",
     "jasmine-node": "3.0.0",
-    "jsdoc": "3.6.3",
-    "pg-query-stream": "3.0.4",
+    "jsdoc": "3.6.4",
+    "pg-query-stream": "3.0.7",
     "typescript": "3.8.3"
   }
 }

package/typescript/pg-subset.d.ts

@@ -13,7 +13,7 @@
 // Calling it 'pg-subset' to avoid a conflict in case the application also
 // includes the official 'pg' typings.
 //
-// Supported version of pg: 7.14.0 and later.
+// Supported version of pg: 8.0.0 and later.
 //
 // pg: https://github.com/brianc/node-postgres
 //////////////////////////////////////////////////////////////////////////////
@@ -212,9 +212,13 @@ declare namespace pg {
         // 0 will disable connection pooling
         max: number
 
-        // max milliseconds a client can go unused before it is removed
-        // from the pool and destroyed
-        idleTimeoutMillis: number
+        // max milliseconds a client can go unused before it is removed from the pool and destroyed;
+        //
+        // Made unavailable in v10.5.0, due to the following:
+        //  - https://github.com/brianc/node-postgres/issues/2139
+        //  - https://github.com/vitaly-t/pg-promise/issues/703
+        //
+        // idleTimeoutMillis: number
 
         client_encoding: string