pg-boss 10.0.2 → 10.0.4

package/README.md

@@ -25,6 +25,12 @@ async function readme() {
     console.log(`received job ${job.id} with data ${JSON.stringify(job.data)}`)
   })
 }
+
+readme()
+  .catch(err => {
+    console.log(err)
+    process.exit(1)
+  })
 ```
 
 pg-boss is a job queue built in Node.js on top of PostgreSQL in order to provide background processing and reliable asynchronous execution to Node.js applications.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pg-boss",
-  "version": "10.0.2",
+  "version": "10.0.4",
   "description": "Queueing jobs in Postgres from Node.js like a boss",
   "main": "./src/index.js",
   "engines": {

package/src/attorney.js

@@ -1,7 +1,13 @@
 const assert = require('assert')
 const { DEFAULT_SCHEMA } = require('./plans')
 
+const POLICY = {
+  MAX_EXPIRATION_HOURS: 24,
+  MIN_POLLING_INTERVAL_MS: 500
+}
+
 module.exports = {
+  POLICY,
   getConfig,
   checkSendArgs,
   checkQueueArgs,
@@ -12,8 +18,6 @@ module.exports = {
   assertQueueName
 }
 
-const MAX_INTERVAL_HOURS = 24
-
 const WARNINGS = {
   CLOCK_SKEW: {
     message: 'Timekeeper detected clock skew between this instance and the database server. This will not affect scheduling operations, but this warning is shown any time the skew exceeds 60 seconds.',
@@ -262,7 +266,7 @@ function applyExpirationConfig (config, defaults = {}) {
             ? config.expireInSeconds
             : null
 
-  assert(!expireIn || expireIn / 60 / 60 < MAX_INTERVAL_HOURS, `configuration assert: expiration cannot exceed ${MAX_INTERVAL_HOURS} hours`)
+  assert(!expireIn || expireIn / 60 / 60 < POLICY.MAX_EXPIRATION_HOURS, `configuration assert: expiration cannot exceed ${POLICY.MAX_EXPIRATION_HOURS} hours`)
 
   config.expireIn = expireIn
   config.expireInDefault = defaults?.expireIn
@@ -279,8 +283,8 @@ function applyRetryConfig (config, defaults) {
 }
 
 function applyPollingInterval (config, defaults) {
-  assert(!('pollingIntervalSeconds' in config) || config.pollingIntervalSeconds >= 0.5,
-    'configuration assert: pollingIntervalSeconds must be at least every 500ms')
+  assert(!('pollingIntervalSeconds' in config) || config.pollingIntervalSeconds >= POLICY.MIN_POLLING_INTERVAL_MS / 1000,
+    `configuration assert: pollingIntervalSeconds must be at least every ${POLICY.MIN_POLLING_INTERVAL_MS}ms`)
 
   config.pollingInterval = ('pollingIntervalSeconds' in config)
     ? config.pollingIntervalSeconds * 1000
@@ -300,7 +304,8 @@ function applyMaintenanceConfig (config) {
         ? config.maintenanceIntervalSeconds
         : 120
 
-  assert(config.maintenanceIntervalSeconds / 60 / 60 < MAX_INTERVAL_HOURS, `configuration assert: maintenance interval cannot exceed ${MAX_INTERVAL_HOURS} hours`)
+  assert(config.maintenanceIntervalSeconds / 60 / 60 < POLICY.MAX_EXPIRATION_HOURS,
+    `configuration assert: maintenance interval cannot exceed ${POLICY.MAX_EXPIRATION_HOURS} hours`)
 }
 
 function applyDeleteConfig (config) {
@@ -344,7 +349,8 @@ function applyMonitoringConfig (config) {
           : null
 
   if (config.monitorStateIntervalSeconds) {
-    assert(config.monitorStateIntervalSeconds / 60 / 60 < MAX_INTERVAL_HOURS, `configuration assert: state monitoring interval cannot exceed ${MAX_INTERVAL_HOURS} hours`)
+    assert(config.monitorStateIntervalSeconds / 60 / 60 < POLICY.MAX_EXPIRATION_HOURS,
+      `configuration assert: state monitoring interval cannot exceed ${POLICY.MAX_EXPIRATION_HOURS} hours`)
   }
 
   const TEN_MINUTES_IN_SECONDS = 600

package/src/plans.js

@@ -226,8 +226,10 @@ function createQueueFunction (schema) {
     $$
     DECLARE
       table_name varchar := 'j' || encode(sha224(queue_name::bytea), 'hex');
+      queue_created_on timestamptz;
     BEGIN
 
+      WITH q as (
       INSERT INTO ${schema}.queue (
         name,
         policy,
@@ -249,7 +251,15 @@ function createQueueFunction (schema) {
         (options->>'retentionMinutes')::int,
         options->>'deadLetter',
         table_name
-      );
+      )
+      ON CONFLICT DO NOTHING
+      RETURNING created_on
+      )
+      SELECT created_on into queue_created_on from q;
+
+      IF queue_created_on IS NULL THEN
+        RETURN;
+      END IF;
 
       EXECUTE format('CREATE TABLE ${schema}.%I (LIKE ${schema}.job INCLUDING DEFAULTS)', table_name);
       
@@ -499,7 +509,7 @@ function fetchNextJob (schema) {
       WHERE name = $1
         AND state < '${JOB_STATES.active}'
         AND start_after < now()
-      ORDER BY ${priority && 'priority desc, '} created_on, id
+      ORDER BY ${priority ? 'priority desc, ' : ''}created_on, id
       LIMIT $2
       FOR UPDATE SKIP LOCKED
     )

package/src/worker.js

@@ -74,7 +74,7 @@ class Worker {
 
       this.lastJobDuration = duration
 
-      if (!this.stopping && !this.beenNotified && (this.interval - duration > 500)) {
+      if (!this.stopping && !this.beenNotified && (this.interval - duration) > 100) {
         this.loopDelayPromise = delay(this.interval - duration)
         await this.loopDelayPromise
         this.loopDelayPromise = null