persyst-mcp 2.2.3 → 2.2.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "persyst-mcp",
-  "version": "2.2.3",
+  "version": "2.2.4",
   "description": "Local-first MCP memory server with hybrid keyword + semantic search for coding agents",
   "type": "module",
   "main": "index.js",

package/src/database.js

@@ -323,13 +323,13 @@ const stmts = {
   boost: db.prepare(`
     UPDATE memories
     SET access_count    = access_count + 1,
-        importance_score = MIN(importance_score + 0.1, 2.0),
+        importance_score = ROUND(MIN(importance_score + 0.1, 1.0), 4),
         last_accessed   = unixepoch()
     WHERE id = ?
   `),
   decay: db.prepare(`
     UPDATE memories
-    SET importance_score = importance_score * 0.95
+    SET importance_score = ROUND(MAX(importance_score * 0.95, 0.0), 4)
     WHERE (? - last_accessed) > 604800
   `),
 
@@ -443,7 +443,8 @@ export function insertMemory(content, importance = 1.0, provenanceInfo = null, n
   if (content && content.length > 10000) {
     throw new Error('Memory content exceeds maximum length of 10000 characters.');
   }
-  const result = stmts.insertMemory.run(content, importance, namespace || 'shared', parentId);
+  const clampedImportance = Math.max(0.0, Math.min(1.0, Math.round(importance * 10000) / 10000));
+  const result = stmts.insertMemory.run(content, clampedImportance, namespace || 'shared', parentId);
   const id = Number(result.lastInsertRowid);
 
   // Provenance Info handling
@@ -510,9 +511,10 @@ export function getAnyMemoryById(id) {
  * @returns {object|null} The memory row, or null if not found
  */
 export function getMemoryById(id, namespace = null) {
-  const memory = namespace
-    ? stmts.getByIdNs.get(id, namespace)
-    : stmts.getById.get(id);
+  const ns = namespace || 'shared';
+  const memory = ns === 'all'
+    ? stmts.getById.get(id)
+    : stmts.getByIdNs.get(id, ns);
   if (memory) {
     memory.provenance = getProvenance(id);
   }
@@ -557,12 +559,17 @@ export function deleteMemory(id) {
 /**
  * Get the N most recently created memories.
  * @param {number} limit - Max results
- * @param {string|null} namespace - Namespace filter (null = all)
+ * @param {string|null} namespace - Namespace filter (null = shared)
  */
 export function getRecentMemories(limit = 10, namespace = null) {
-  const rows = namespace
-    ? stmts.getRecentNs.all(namespace, limit)
-    : stmts.getRecent.all(limit);
+  if (typeof limit !== 'number' || isNaN(limit) || limit <= 0) {
+    throw new Error('Limit must be a positive integer.');
+  }
+  const parsedLimit = Math.floor(limit);
+  const ns = namespace || 'shared';
+  const rows = ns === 'all'
+    ? stmts.getRecent.all(parsedLimit)
+    : stmts.getRecentNs.all(ns, parsedLimit);
   rows.forEach(r => {
     r.provenance = getProvenance(r.id);
   });
@@ -572,12 +579,17 @@ export function getRecentMemories(limit = 10, namespace = null) {
 /**
  * Get the N most important memories (by importance_score).
  * @param {number} limit - Max results
- * @param {string|null} namespace - Namespace filter (null = all)
+ * @param {string|null} namespace - Namespace filter (null = shared)
  */
 export function getImportantMemories(limit = 10, namespace = null) {
-  const rows = namespace
-    ? stmts.getImportantNs.all(namespace, limit)
-    : stmts.getImportant.all(limit);
+  if (typeof limit !== 'number' || isNaN(limit) || limit <= 0) {
+    throw new Error('Limit must be a positive integer.');
+  }
+  const parsedLimit = Math.floor(limit);
+  const ns = namespace || 'shared';
+  const rows = ns === 'all'
+    ? stmts.getImportant.all(parsedLimit)
+    : stmts.getImportantNs.all(ns, parsedLimit);
   rows.forEach(r => {
     r.provenance = getProvenance(r.id);
   });
@@ -633,7 +645,11 @@ export function searchKeyword(query, limit = 10) {
  * @returns {Array<{rowid: number, distance: number}>}
  */
 export function searchVector(embedding, limit = 10) {
-  return stmts.searchVec.all(Buffer.from(embedding.buffer), limit);
+  if (typeof limit !== 'number' || isNaN(limit) || limit <= 0) {
+    throw new Error('Limit must be a positive integer.');
+  }
+  const parsedLimit = Math.floor(limit);
+  return stmts.searchVec.all(Buffer.from(embedding.buffer), parsedLimit);
 }
 
 // ============================================================

package/src/search.js

@@ -33,6 +33,12 @@ let lastDataVersion = 0;
  * @returns {Promise<Array>} Ranked search results (with .attestation property attached)
  */
 export async function searchHybrid(queryText, limit = 5, agentId = null, sessionId = null, namespace = null, skipAttestation = false) {
+  if (typeof limit !== 'number' || isNaN(limit) || limit <= 0) {
+    throw new Error('Limit must be a positive integer.');
+  }
+  const parsedLimit = Math.floor(limit);
+  const ns = namespace || 'shared';
+
   // Sync in-memory cache with external DB changes using sqlite data_version
   try {
     const currentDataVersion = db.pragma('data_version', { simple: true });
@@ -46,7 +52,7 @@ export async function searchHybrid(queryText, limit = 5, agentId = null, session
 
   // --- Check LRU cache first (Feature 1) ---
   // Include namespace in cache key to prevent cross-namespace cache hits
-  const cacheKey = LRUCache.key(`${namespace || 'all'}:${queryText}`, limit);
+  const cacheKey = LRUCache.key(`${ns}:${queryText}`, parsedLimit);
   const cached = searchCache.get(cacheKey);
   if (cached) {
     console.error(`[persyst-cache] Cache HIT for query: "${queryText.slice(0, 50)}..."`);
@@ -54,12 +60,12 @@ export async function searchHybrid(queryText, limit = 5, agentId = null, session
   }
 
   // --- Step 1: Keyword search (fast, exact matches) ---
-  const keywordHits = searchKeyword(queryText, limit * 2);
+  const keywordHits = searchKeyword(queryText, parsedLimit * 2);
   const keywordIds = new Set(keywordHits.map(r => r.id));
 
   // --- Step 2: Semantic search (meaning-based) ---
   const queryEmbedding = await generateEmbedding(queryText);
-  const vecHits = searchVector(queryEmbedding, limit * 2);
+  const vecHits = searchVector(queryEmbedding, parsedLimit * 2);
 
   const semanticResults = vecHits.map(r => ({
     id: r.rowid,
@@ -99,7 +105,7 @@ export async function searchHybrid(queryText, limit = 5, agentId = null, session
   const finalResults = combined
     .map(r => {
       // Use namespace-aware getMemoryById to filter by agent namespace
-      const memory = getMemoryById(r.id, namespace);
+      const memory = getMemoryById(r.id, ns);
       if (!memory) return null; // Memory was archived, deleted, or not in namespace
 
       // Boost memory access metrics
@@ -141,7 +147,7 @@ export async function searchHybrid(queryText, limit = 5, agentId = null, session
   finalResults.sort((a, b) => parseFloat(b.hybrid_score) - parseFloat(a.hybrid_score));
 
   // --- Step 5: Apply MMR for diverse retrieval (Feature 3) ---
-  const mmrResults = applyMMR(finalResults, limit);
+  const mmrResults = applyMMR(finalResults, parsedLimit);
 
   // Generate cryptographic attestation for audit trails (skip if called internally)
   let attestation = null;

package/src/tools.js

@@ -290,7 +290,7 @@ export function registerTools(server) {
     'Search memories using hybrid keyword + semantic search with cryptographic attestation. CRITICAL: Call this tool at the start of a session or task to retrieve relevant user preferences, coding guidelines, and past decisions.',
     {
       query: z.string().describe('What to search for'),
-      limit: z.number().default(5).describe('Max results (default: 5)'),
+      limit: z.number().int().min(1).default(5).describe('Max results (default: 5)'),
       agent_id: z.string().optional().describe('Agent ID — filters results to this agent\'s namespace + shared'),
       session_id: z.string().optional().describe('Session ID')
     },
@@ -415,7 +415,7 @@ export function registerTools(server) {
     'get_recent_memories',
     'Get the most recently created memories, newest first. Filtered by agent namespace if agent_id is provided.',
     {
-      limit: z.number().default(10).describe('How many to return (default: 10)'),
+      limit: z.number().int().min(1).default(10).describe('How many to return (default: 10)'),
       agent_id: z.string().optional().describe('Agent ID — filters to this agent\'s namespace + shared')
     },
     async ({ limit, agent_id }) => {
@@ -434,7 +434,7 @@ export function registerTools(server) {
     'get_important_memories',
     'Get memories ranked by importance score, highest first. Filtered by agent namespace if agent_id is provided.',
     {
-      limit: z.number().default(10).describe('How many to return (default: 10)'),
+      limit: z.number().int().min(1).default(10).describe('How many to return (default: 10)'),
       agent_id: z.string().optional().describe('Agent ID — filters to this agent\'s namespace + shared')
     },
     async ({ limit, agent_id }) => {