pepr 0.44.0-nightly.6 → 0.44.0-nightly.7

package/package.json

@@ -15,7 +15,7 @@
     "!src/**/*.test.ts",
     "!dist/**/*.test.d.ts*"
   ],
-  "version": "0.44.0-nightly.6",
+  "version": "0.44.0-nightly.7",
   "main": "dist/lib.js",
   "types": "dist/lib.d.ts",
   "scripts": {
@@ -80,16 +80,16 @@
     "glob": "^9.0.0"
   },
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "7.18.0",
-    "@typescript-eslint/parser": "7.18.0",
     "@types/prompts": "2.4.9",
+    "@typescript-eslint/eslint-plugin": "8.23.0",
+    "@typescript-eslint/parser": "8.23.0",
+    "commander": "13.1.0",
+    "esbuild": "0.24.2",
     "eslint": "8.57.0",
-    "commander": "12.1.0",
-    "esbuild": "0.24.0",
     "node-forge": "1.3.1",
     "prettier": "3.4.2",
     "prompts": "2.4.2",
-    "typescript": "^5.3.3",
-    "uuid": "11.0.3"
+    "typescript": "5.7.3",
+    "uuid": "11.0.5"
   }
 }

package/src/cli/build.ts

@@ -165,7 +165,7 @@ export default function (program: RootCmd): void {
         return;
       }
       // set the image version if provided
-      opts.version ? (cfg.pepr.peprVersion = opts.version) : null;
+      if (opts.version) cfg.pepr.peprVersion = opts.version;
 
       // Generate a secret for the module
       const assets = new Assets(
@@ -183,7 +183,7 @@ export default function (program: RootCmd): void {
         opts.withPullSecret === "" ? [] : [opts.withPullSecret],
       );
 
-      image !== "" ? (assets.image = image) : null;
+      if (image !== "") assets.image = image;
 
       // Ensure imagePullSecret is valid
       validImagePullSecret(opts.withPullSecret);
@@ -218,7 +218,7 @@ export async function loadModule(entryPoint = peprTS): Promise<LoadModuleReturn>
   try {
     await fs.access(cfgPath);
     await fs.access(entryPointPath);
-  } catch (e) {
+  } catch {
     console.error(
       `Could not find ${cfgPath} or ${entryPointPath} in the current directory. Please run this command from the root of your module's directory.`,
     );

package/src/cli/deploy.ts

@@ -93,6 +93,35 @@ export async function getUserConfirmation(opts: { confirm: boolean }): Promise<b
   return confirm.confirm ? true : false;
 }
 
+async function buildAndDeployModule(image: string, force: boolean): Promise<void> {
+  const builtModule = await buildModule();
+  if (!builtModule) {
+    return;
+  }
+
+  // Generate a secret for the module
+  const webhook = new Assets(
+    { ...builtModule.cfg.pepr, description: builtModule.cfg.description },
+    builtModule.path,
+    [],
+  );
+  webhook.image = image ?? webhook.image;
+
+  try {
+    await webhook.deploy(deployWebhook, force, builtModule.cfg.pepr.webhookTimeout ?? 10);
+
+    // wait for capabilities to be loaded and test names
+    validateCapabilityNames(webhook.capabilities);
+
+    // Wait for the pepr-system resources to be fully up
+    await namespaceDeploymentsReady();
+    console.info(`✅ Module deployed successfully`);
+  } catch (e) {
+    console.error(`Error deploying module:`, e);
+    process.exit(1);
+  }
+}
+
 export default function (program: RootCmd): void {
   program
     .command("deploy")
@@ -117,33 +146,10 @@ export default function (program: RootCmd): void {
         return;
       }
 
-      (await getUserConfirmation(opts)) || process.exit(0);
-
-      const builtModule = await buildModule();
-      if (!builtModule) {
-        return;
+      if (!(await getUserConfirmation(opts))) {
+        process.exit(0);
       }
 
-      // Generate a secret for the module
-      const webhook = new Assets(
-        { ...builtModule.cfg.pepr, description: builtModule.cfg.description },
-        builtModule.path,
-        [],
-      );
-      webhook.image = opts.image ?? webhook.image;
-
-      try {
-        await webhook.deploy(deployWebhook, opts.force, builtModule.cfg.pepr.webhookTimeout ?? 10);
-
-        // wait for capabilities to be loaded and test names
-        validateCapabilityNames(webhook.capabilities);
-
-        // Wait for the pepr-system resources to be fully up
-        await namespaceDeploymentsReady();
-        console.info(`✅ Module deployed successfully`);
-      } catch (e) {
-        console.error(`Error deploying module:`, e);
-        process.exit(1);
-      }
+      await buildAndDeployModule(opts.image, opts.force);
     });
 }

package/src/cli/init/index.ts

@@ -107,7 +107,7 @@ const doPostInitActions = (dirName: string): void => {
     execSync("code .", {
       stdio: "inherit",
     });
-  } catch (e) {
-    // vscode not found, do nothing
+  } catch {
+    console.warn("VSCode was not found, IDE will not automatically open.");
   }
 };

package/src/cli/init/walkthrough.ts

@@ -38,7 +38,7 @@ export async function setName(name?: string): Promise<Answers<string>> {
         await fs.access(name, fs.constants.F_OK);
 
         return "A directory with this name already exists";
-      } catch (e) {
+      } catch {
         return val.length > 2 || "The name must be at least 3 characters long";
       }
     },

package/src/lib/assets/rbac.ts

@@ -24,8 +24,7 @@ export function clusterRole(
   const rbacMap = createRBACMap(capabilities);
   // Generate scoped rules from rbacMap
   const scopedRules = Object.keys(rbacMap).map(key => {
-    let group: string;
-    key.split("/").length < 3 ? (group = "") : (group = key.split("/")[0]);
+    const group: string = key.split("/").length < 3 ? "" : key.split("/")[0];
 
     return {
       apiGroups: [group],

package/src/lib/controller/index.ts

@@ -53,7 +53,9 @@ export class Controller {
     // Initialize the Pepr store for each capability
     new StoreController(capabilities, `pepr-${config.uuid}-store`, () => {
       this.#bindEndpoints();
-      onReady && onReady();
+      if (typeof onReady === "function") {
+        onReady();
+      }
       Log.info("✅ Controller startup complete");
       // Initialize the schedule store for each capability
       new StoreController(capabilities, `pepr-${config.uuid}-schedule`, () => {
@@ -224,7 +226,9 @@ export class Controller {
         Log.debug({ ...reqMetadata, request }, "Incoming request body");
 
         // Run the before hook if it exists
-        this.#beforeHook && this.#beforeHook(request || {});
+        if (typeof this.#beforeHook === "function") {
+          this.#beforeHook(request || {});
+        }
 
         // Process the request
         const response: MutateResponse | ValidateResponse[] =
@@ -234,7 +238,9 @@ export class Controller {
 
         // Run the after hook if it exists
         [response].flat().map(res => {
-          this.#afterHook && this.#afterHook(res);
+          if (typeof this.#afterHook === "function") {
+            this.#afterHook(res);
+          }
           Log.info({ ...reqMetadata, res }, "Check response");
         });
 

package/src/lib/core/schedule.ts

@@ -91,7 +91,7 @@ export class OnSchedule implements Schedule {
       lastTimestamp: new Date(),
       name: this.name,
     };
-    this.store && this.store.setItem(this.name, JSON.stringify(schedule));
+    if (this.store) this.store.setItem(this.name, JSON.stringify(schedule));
   }
 
   /**
@@ -170,6 +170,6 @@ export class OnSchedule implements Schedule {
       clearInterval(this.intervalId);
       this.intervalId = null;
     }
-    this.store && this.store.removeItem(this.name);
+    if (this.store) this.store.removeItem(this.name);
   }
 }

package/src/lib/core/storage.ts

@@ -110,11 +110,12 @@ export class Storage implements PeprStore {
   };
 
   clear = (): void => {
-    Object.keys(this.#store).length > 0 &&
+    if (Object.keys(this.#store).length > 0) {
       this.#dispatchUpdate(
         "remove",
         Object.keys(this.#store).map(key => pointer.escape(key)),
       );
+    }
   };
 
   removeItem = (key: string): void => {

package/src/lib/processors/mutate-processor.ts

@@ -55,7 +55,7 @@ export function logMutateErrorMessage(e: Error): string {
     } else {
       throw new Error("An error occurred in the mutate action.");
     }
-  } catch (e) {
+  } catch {
     return "An error occurred with the mutate action.";
   }
 }

package/src/lib/processors/watch-processor.ts

@@ -137,9 +137,11 @@ async function runBinding(
 
       // [ true, void, undefined ] SHOULD remove finalizer
       // [ false ] should NOT remove finalizer
-      shouldRemoveFinalizer === false
-        ? Log.debug({ obj: kubernetesObject }, `Skipping removal of finalizer '${peprFinal}' from '${resource}'`)
-        : await removeFinalizer(binding, kubernetesObject);
+      if (shouldRemoveFinalizer === false) {
+        Log.debug({ obj: kubernetesObject }, `Skipping removal of finalizer '${peprFinal}' from '${resource}'`);
+      } else {
+        await removeFinalizer(binding, kubernetesObject);
+      }
     }
   };
 

package/src/sdk/heredoc.ts

@@ -14,8 +14,8 @@ export function heredoc(strings: TemplateStringsArray, ...values: string[]): str
   const asLines = zipped.join("").split(/[\r\n]+/);
 
   // strip whitespace-only first & last lines
-  asLines[0].trim().length === 0 ? asLines.shift() : null;
-  asLines.slice(-1)[0].trim().length === 0 ? asLines.pop() : null;
+  if (asLines[0].trim().length === 0) asLines.shift();
+  if (asLines.slice(-1)[0].trim().length === 0) asLines.pop();
 
   // find smallest indent
   const indent = asLines.reduce((acc, cur) => {