pepr 0.37.1 → 0.37.3

package/src/lib/filter.ts

@@ -4,6 +4,24 @@
 import { AdmissionRequest, Binding, Operation } from "./types";
 import {
   carriesIgnoredNamespace,
+  carriedName,
+  definedEvent,
+  declaredOperation,
+  definedName,
+  definedGroup,
+  declaredGroup,
+  definedVersion,
+  declaredVersion,
+  definedKind,
+  declaredKind,
+  definedNamespaces,
+  carriedNamespace,
+  definedLabels,
+  carriedLabels,
+  definedAnnotations,
+  carriedAnnotations,
+  definedNamespaceRegexes,
+  definedNameRegex,
   misboundDeleteWithDeletionTimestamp,
   mismatchedDeletionTimestamp,
   mismatchedAnnotations,
@@ -32,27 +50,94 @@ export function shouldSkipRequest(
   req: AdmissionRequest,
   capabilityNamespaces: string[],
   ignoredNamespaces?: string[],
-): boolean {
+): string {
+  const prefix = "Ignoring Admission Callback:";
   const obj = req.operation === Operation.DELETE ? req.oldObject : req.object;
 
   // prettier-ignore
   return (
-    misboundDeleteWithDeletionTimestamp(binding) ? true :
-    mismatchedDeletionTimestamp(binding, obj) ? true :
-    mismatchedEvent(binding, req) ? true :
-    mismatchedName(binding, obj) ? true :
-    mismatchedGroup(binding, req) ? true :
-    mismatchedVersion(binding, req) ? true :
-    mismatchedKind(binding, req) ? true :
-    unbindableNamespaces(capabilityNamespaces, binding) ? true :
-    uncarryableNamespace(capabilityNamespaces, obj) ? true :
-    mismatchedNamespace(binding, obj) ? true :
-    mismatchedLabels(binding, obj) ? true :
-    mismatchedAnnotations(binding, obj) ? true :
-    mismatchedNamespaceRegex(binding, obj) ? true :
-    mismatchedNameRegex(binding, obj) ? true :
-    carriesIgnoredNamespace(ignoredNamespaces, obj) ? true :
-
-    false
+    misboundDeleteWithDeletionTimestamp(binding) ? 
+      `${prefix} Cannot use deletionTimestamp filter on a DELETE operation.` :
+
+    mismatchedDeletionTimestamp(binding, obj) ?
+      `${prefix} Binding defines deletionTimestamp but Object does not carry it.` :
+
+    mismatchedEvent(binding, req) ?
+      (
+        `${prefix} Binding defines event '${definedEvent(binding)}' but ` +
+        `Request declares '${declaredOperation(req)}'.`
+      ) :
+
+    mismatchedName(binding, obj) ?
+      `${prefix} Binding defines name '${definedName(binding)}' but Object carries '${carriedName(obj)}'.` :
+
+    mismatchedGroup(binding, req) ?
+      (
+        `${prefix} Binding defines group '${definedGroup(binding)}' but ` +
+        `Request declares '${declaredGroup(req)}'.`
+      ) :
+
+    mismatchedVersion(binding, req) ?
+      (
+        `${prefix} Binding defines version '${definedVersion(binding)}' but ` +
+        `Request declares '${declaredVersion(req)}'.`
+      ) :
+
+    mismatchedKind(binding, req) ?
+      (
+        `${prefix} Binding defines kind '${definedKind(binding)}' but ` +
+        `Request declares '${declaredKind(req)}'.`
+      ) :
+
+    unbindableNamespaces(capabilityNamespaces, binding) ?
+      (
+        `${prefix} Binding defines namespaces ${JSON.stringify(definedNamespaces(binding))} ` +
+        `but namespaces allowed by Capability are '${JSON.stringify(capabilityNamespaces)}'.`
+      ) :
+
+    uncarryableNamespace(capabilityNamespaces, obj) ?
+      (
+        `${prefix} Object carries namespace '${carriedNamespace(obj)}' ` +
+        `but namespaces allowed by Capability are '${JSON.stringify(capabilityNamespaces)}'.`
+      ) :
+
+    mismatchedNamespace(binding, obj) ?
+      (
+        `${prefix} Binding defines namespaces '${JSON.stringify(definedNamespaces(binding))}' ` +
+        `but Object carries '${carriedNamespace(obj)}'.`
+      ) :
+
+    mismatchedLabels(binding, obj) ?
+      (
+        `${prefix} Binding defines labels '${JSON.stringify(definedLabels(binding))}' ` +
+        `but Object carries '${JSON.stringify(carriedLabels(obj))}'.`
+      ) :
+
+    mismatchedAnnotations(binding, obj) ?
+      (
+        `${prefix} Binding defines annotations '${JSON.stringify(definedAnnotations(binding))}' ` +
+        `but Object carries '${JSON.stringify(carriedAnnotations(obj))}'.`
+      ) :
+
+    mismatchedNamespaceRegex(binding, obj) ?
+      (
+        `${prefix} Binding defines namespace regexes ` +
+        `'${JSON.stringify(definedNamespaceRegexes(binding))}' ` +
+        `but Object carries '${carriedNamespace(obj)}'.`
+      ) :
+
+    mismatchedNameRegex(binding, obj) ?
+      (
+        `${prefix} Binding defines name regex '${definedNameRegex(binding)}' ` +
+        `but Object carries '${carriedName(obj)}'.`
+      ) :
+
+    carriesIgnoredNamespace(ignoredNamespaces, obj) ?
+      (
+        `${prefix} Object carries namespace '${carriedNamespace(obj)}' ` +
+        `but ignored namespaces include '${JSON.stringify(ignoredNamespaces)}'.`
+      ) :
+
+    ""
   );
 }

package/src/lib/mutate-processor.ts

@@ -50,7 +50,9 @@ export async function mutateProcessor(
       }
 
       // Continue to the next action without doing anything if this one should be skipped
-      if (shouldSkipRequest(action, req, namespaces, config?.alwaysIgnore?.namespaces)) {
+      const shouldSkip = shouldSkipRequest(action, req, namespaces, config?.alwaysIgnore?.namespaces);
+      if (shouldSkip !== "") {
+        Log.debug(shouldSkip);
         continue;
       }
 

package/src/lib/validate-processor.ts

@@ -44,7 +44,9 @@ export async function validateProcessor(
       };
 
       // Continue to the next action without doing anything if this one should be skipped
-      if (shouldSkipRequest(action, req, namespaces, config?.alwaysIgnore?.namespaces)) {
+      const shouldSkip = shouldSkipRequest(action, req, namespaces, config?.alwaysIgnore?.namespaces);
+      if (shouldSkip !== "") {
+        Log.debug(shouldSkip);
         continue;
       }