penguins-eggs 9.0.16 → 9.0.25

package/lib/classes/krill_install.js

@@ -1,6 +1,6 @@
 "use strict";
 /**
- * penguins-eggs: hatching.js
+ * penguins-eggs: krill_install
  *
  * author: Piero Proietti
  * mail: piero.proietti@gmail.com
@@ -87,9 +87,23 @@ class Hatching {
     async install(verbose = false) {
         this.verbose = verbose;
         await this.settings.load();
+        // partition
         let percent = 0.0;
         let message = "";
-        if (await this.partition()) {
+        let isPartitioned = false;
+        message = "Creating partitions";
+        percent = 0.00;
+        try {
+            redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+            isPartitioned = await this.partition();
+        }
+        catch (error) {
+            message += JSON.stringify(error);
+            redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+            await checkIt(message);
+        }
+        if (isPartitioned) {
+            // formatting
             message = "Formatting file system ";
             percent = 0.01;
             try {
@@ -99,32 +113,32 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
-            // mount
+            // mountFs
             message = "Mounting target file system ";
             percent = 0.03;
             try {
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
-                await this.mount();
+                await this.mountFs();
             }
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
-            // mountvfs
-            message = "Mounting target file system vfs ";
+            // mountVfs
+            message = "Mounting on target VFS ";
             percent = 0.06;
             try {
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
-                await this.mountvfs();
+                await this.mountVfs();
             }
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
             // unpackfs
             message = "Unpacking filesystem ";
             percent = 0.10;
@@ -135,23 +149,13 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
-            /*
-            message = "Syncronize filesystem "
-            percent = 0.35
-            try {
-               redraw(<Install message={message} percent={percent} spinner={true} />)
-               await this.syncfs()
-            } catch (error) {
-               message += JSON.stringify(error)
-               redraw(<Install message={message} percent={percent} />)
-            }
-            */
             /**
-             * RESTORE USERS DATA
+             * IF RESTORE USERS DATA
              */
             if (fs_1.default.existsSync(this.luksFile)) {
+                // restoring users data
                 message = "Restore private data from backup ";
                 percent = 0.37;
                 try {
@@ -161,8 +165,8 @@ class Hatching {
                 catch (error) {
                     message += JSON.stringify(error);
                     redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                    await checkIt(message);
                 }
-                // await checkIt(message)
             }
             // sources-yolk
             message = 'sources-yolk';
@@ -174,8 +178,21 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
+            }
+            // machineid
+            message = 'machineid';
+            percent = 0.41;
+            try {
+                redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent, spinner: true }));
+                await this.machineId();
             }
-            // await checkIt(message)
+            catch (error) {
+                message += JSON.stringify(error);
+                redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
+            }
+            // timezone
             message = "Setting time zone ";
             percent = 0.43;
             try {
@@ -185,8 +202,9 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // fstab
             message = "Creating fstab ";
             percent = 0.47;
             try {
@@ -196,8 +214,9 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // keyboard
             message = "settings keyboard ";
             percent = 0.48;
             try {
@@ -206,8 +225,9 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // networkcfg
             message = "networkcfg";
             percent = 0.50;
             try {
@@ -216,8 +236,9 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // hostname
             message = "Create hostname ";
             percent = 0.53;
             try {
@@ -227,8 +248,9 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // hosts
             message = "Creating hosts ";
             percent = 0.60;
             try {
@@ -238,10 +260,11 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // bootloader-config
             message = "bootloader-config ";
-            percent = 0.63;
+            percent = 0.62;
             try {
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
                 await this.execCalamaresModule('bootloader-config');
@@ -249,10 +272,23 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
-            message = "bootloader ";
+            // grubcfg
+            message = "grubcfg ";
             percent = 0.63;
+            try {
+                redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await this.grubcfg();
+            }
+            catch (error) {
+                message += JSON.stringify(error);
+                redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
+            }
+            // bootloader
+            message = "bootloader ";
+            percent = 0.64;
             try {
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
                 await this.bootloader();
@@ -260,8 +296,9 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // initramfsCfg
             message = "initramfs configure";
             percent = 0.65;
             try {
@@ -271,8 +308,9 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // initramfs
             message = "initramfs ";
             percent = 0.67;
             try {
@@ -282,8 +320,9 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // delLiveUser
             message = "Removing user live ";
             percent = 0.70;
             try {
@@ -293,14 +332,13 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
             /**
-             * IF NOT RESTORE-USERS-ACCOUNTS
-             *
-             * create user
+             * if NOT restore users data
              */
             if (!fs_1.default.existsSync(this.luksFile)) {
+                // addUser
                 message = "Adding user ";
                 percent = 0.73;
                 try {
@@ -310,20 +348,22 @@ class Hatching {
                 catch (error) {
                     message += JSON.stringify(error);
                     redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                    await checkIt(message);
+                }
+                // changePassword
+                message = "adding user password ";
+                percent = 0.77;
+                try {
+                    redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                    await this.changePassword('root', this.users.rootPassword);
+                }
+                catch (error) {
+                    message += JSON.stringify(error);
+                    redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                    await checkIt(message);
                 }
-                // await checkIt(message)
-            }
-            message = "adding user password ";
-            percent = 0.77;
-            try {
-                redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
-                await this.changePassword('root', this.users.rootPassword);
-            }
-            catch (error) {
-                message += JSON.stringify(error);
-                redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
             }
-            // await checkIt(message)
+            // autologin
             if (pacman_1.default.isInstalledGui()) {
                 try {
                     message = "autologin GUI";
@@ -334,6 +374,7 @@ class Hatching {
                 catch (error) {
                     message += JSON.stringify(error);
                     redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                    await checkIt(message);
                 }
             }
             else { // autologin CLI remove DEFAULT
@@ -346,12 +387,13 @@ class Hatching {
                 catch (error) {
                     message += JSON.stringify(error);
                     redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                    await checkIt(message);
                 }
             }
-            // eggs-cleanup forced
+            // cleanup
             await cliAutologin.msgRemove(`${this.installTarget}/etc/motd`);
             await cliAutologin.msgRemove(`${this.installTarget}/etc/issue`);
-            // await checkIt(message)
+            // removeInstaller
             message = "remove installer";
             percent = 0.87;
             try {
@@ -361,8 +403,9 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // sourcesYolkUmount
             message = "sources yolk unmount";
             percent = 0.92;
             try {
@@ -372,20 +415,33 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // umountVfs
+            message = "umount VFS";
+            percent = 0.95;
+            try {
+                redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await this.umountVfs();
+            }
+            catch (error) {
+                message += JSON.stringify(error);
+                redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
+            }
+            // umount
             message = "umount";
-            percent = 0.92;
+            percent = 0.97;
             try {
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
-                await this.umountvfs();
-                await this.umount();
+                await this.umountFs();
             }
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
-            // await checkIt(message)
+            // finished
             message = "finished";
             percent = 100.0;
             try {
@@ -395,6 +451,7 @@ class Hatching {
             catch (error) {
                 message += JSON.stringify(error);
                 redraw(react_1.default.createElement(install_1.default, { message: message, percent: percent }));
+                await checkIt(message);
             }
         }
     }
@@ -477,6 +534,7 @@ adduser ${name} \
             text += 'RESUME=UUID=' + utils_1.default.uuid(this.devices.swap.name);
         }
         utils_1.default.write(file, text);
+        //
     }
     /**
      * initramfs()
@@ -490,8 +548,34 @@ adduser ${name} \
      * fstab()
      * @param devices
      */
-    async fstab(installDevice) {
-        const file = this.installTarget + '/etc/fstab';
+    async fstab(installDevice, crypted = false) {
+        let text = '';
+        /**
+         * crypttab
+         */
+        if (this.partitions.installationMode === 'full-encrypted') {
+            const crypttab = this.installTarget + '/etc/crypttab';
+            text = ``;
+            text += `# /etc/crypttab: mappings for encrypted partitions.\n`;
+            text += `#\n`;
+            text += `# Each mapped device will be created in /dev/mapper, so your /etc/fstab\n`;
+            text += `# should use the /dev/mapper/<name> paths for encrypted devices.\n`;
+            text += `#\n`;
+            text += `# See crypttab(5) for the supported syntax.\n`;
+            text += `#\n`;
+            text += `# NOTE: You need not list your root (/) partition here, but it must be set up\n`;
+            text += `#       beforehand by the initramfs (/etc/mkinitcpio.conf). The same applies\n`;
+            text += `#       to encrypted swap, which should be set up with mkinitcpio-openswap\n`;
+            text += `#       for resume support.\n`;
+            text += `#\n`;
+            text += `# <name>               <device>                         <password> <options>\n`;
+            text += `#swap_crypted was ${this.devices.swap.cryptedFrom}\n`;
+            text += `swap_crypted UUID=${utils_1.default.uuid(this.devices.swap.cryptedFrom)} none luks,discard\n`;
+            text += `#root_crypted was ${this.devices.root.cryptedFrom}\n`;
+            text += `root_crypted UUID=${utils_1.default.uuid(this.devices.root.cryptedFrom)} none luks,swap\n`;
+            utils_1.default.write(crypttab, text);
+        }
+        const fstab = this.installTarget + '/etc/fstab';
         let mountOptsRoot = '';
         let mountOptsBoot = '';
         let mountOptsData = ``;
@@ -511,7 +595,7 @@ adduser ${name} \
             mountOptsEfi = 'defaults,noatime 0 2';
             mountOptsSwap = 'defaults,noatime 0 2';
         }
-        let text = '';
+        text = ``;
         text += `# ${this.devices.root.name} ${this.devices.root.mountPoint} ${this.devices.root.fsType} ${mountOptsRoot}\n`;
         text += `UUID=${utils_1.default.uuid(this.devices.root.name)} ${this.devices.root.mountPoint} ${this.devices.root.fsType} ${mountOptsRoot}\n`;
         if (this.devices.boot.name !== `none`) {
@@ -528,7 +612,7 @@ adduser ${name} \
         }
         text += `# ${this.devices.swap.name} ${this.devices.swap.mountPoint} ${this.devices.swap.fsType} ${mountOptsSwap}\n`;
         text += `UUID=${utils_1.default.uuid(this.devices.swap.name)} ${this.devices.swap.mountPoint} ${this.devices.swap.fsType} ${mountOptsSwap}\n`;
-        utils_1.default.write(file, text);
+        utils_1.default.write(fstab, text);
     }
     /**
      * setKeyboard
@@ -562,12 +646,15 @@ adduser ${name} \
         let content = '# created by eggs\n\n';
         content += 'auto lo\n';
         content += 'iface lo inet loopback\n\n';
-        content += 'auto ' + this.network.iface + '\n';
-        content += 'iface ' + this.network.iface + ' inet ' + this.network.addressType + '\n';
-        if (this.network.addressType !== 'dhcp') {
-            content += '    address ' + this.network.address + '\n';
-            content += '    netmask ' + this.network.netmask + '\n';
-            content += '    gateway ' + this.network.gateway + '\n';
+        // if netplan, don't create entries in /etc/network/interfaces
+        if (!pacman_1.default.packageIsInstalled('netplan.io')) {
+            content += 'auto ' + this.network.iface + '\n';
+            content += 'iface ' + this.network.iface + ' inet ' + this.network.addressType + '\n';
+            if (this.network.addressType !== 'dhcp') {
+                content += '    address ' + this.network.address + '\n';
+                content += '    netmask ' + this.network.netmask + '\n';
+                content += '    gateway ' + this.network.gateway + '\n';
+            }
         }
         utils_1.default.write(file, content);
         /**
@@ -730,7 +817,7 @@ adduser ${name} \
     /**
      * mount
      */
-    async mount() {
+    async mountFs() {
         const echo = { echo: false, ignore: false };
         if (!fs_1.default.existsSync(this.installTarget)) {
             await (0, utils_2.exec)(`mkdir ${this.installTarget}` + this.toNull, echo);
@@ -761,30 +848,30 @@ adduser ${name} \
         return true;
     }
     /**
-     * umount
+     * umountFs
      */
-    async umount() {
+    async umountFs() {
         const echo = { echo: false, ignore: false };
+        // efi
         if (this.efi) {
-            await (0, utils_2.exec)(`umount ${this.installTarget}/boot/efi` + this.toNull, echo);
-            await (0, utils_2.exec)('sleep 1', echo);
+            await this.umount(this.devices.efi.name);
         }
         // data
         if (this.devices.data.name !== `none`) {
-            await (0, utils_2.exec)(`umount ${this.devices.data.name}` + this.toNull, echo);
+            await this.umount(this.devices.data.name);
         }
-        // root
+        // boot
         if (this.devices.boot.name !== `none`) {
-            await (0, utils_2.exec)(`umount ${this.devices.boot.name}` + this.toNull, echo);
+            await this.umount(this.devices.boot.name);
         }
-        await (0, utils_2.exec)(`umount ${this.devices.root.name}` + this.toNull, echo);
-        await (0, utils_2.exec)('sleep 1', echo);
+        // root
+        await this.umount(this.devices.root.name);
         return true;
     }
     /**
     * mountvfs()
     */
-    async mountvfs() {
+    async mountVfs() {
         const echo = { echo: true, ignore: true };
         await (0, utils_2.exec)('mkdir ' + this.installTarget + '/dev' + this.toNull);
         await (0, utils_2.exec)('mkdir ' + this.installTarget + '/dev/pts' + this.toNull);
@@ -795,144 +882,239 @@ adduser ${name} \
         await (0, utils_2.exec)(`mount -o bind /dev/pts ${this.installTarget}/dev/pts` + this.toNull, echo);
         await (0, utils_2.exec)(`mount -o bind /proc ${this.installTarget}/proc` + this.toNull, echo);
         await (0, utils_2.exec)(`mount -o bind /sys ${this.installTarget}/sys` + this.toNull, echo);
-        /**
-         * I know, that's very old thread, but maybe will help for someone.
-         * Most guides suggest the same solution to mount virtual filesystems before chroot:
-         * for i in /dev /dev/pts /proc /sys /run; do sudo mount -B $i /mnt$i; done
-         * But now (maybe related to efivars/efivarfs changes) this loop skips one very special sub-mountpoint
-         * - /sys/firmware/efi/efivars and efibootmgr/grub fails.
-         *
-         * https://unix.stackexchange.com/questions/91620/efi-variables-are-not-supported-on-this-system
-         */
-        await (0, utils_2.exec)(`mount -o bind /sys/firmware/efi/efivars ${this.installTarget}/sys/firmware/efi/efivars` + this.toNull, echo);
+        if (this.efi) {
+            await (0, utils_2.exec)(`mount -o bind /sys/firmware/efi/efivars ${this.installTarget}/sys/firmware/efi/efivars` + this.toNull, echo);
+        }
         await (0, utils_2.exec)(`mount -o bind /run ${this.installTarget}/run` + this.toNull, echo);
     }
     /**
+     *
      */
-    async umountvfs() {
+    async umountVfs() {
         const echo = { echo: false, ignore: false };
-        if (utils_1.default.isMountpoint(`${this.installTarget}/dev/pts`)) {
-            await (0, utils_2.exec)(`umount ${this.installTarget}/dev/pts` + this.toNull, echo);
-            await (0, utils_2.exec)('sleep 1', echo);
-        }
-        if (utils_1.default.isMountpoint(`${this.installTarget}/dev`)) {
-            await (0, utils_2.exec)(`umount ${this.installTarget}/dev` + this.toNull, echo);
-            await (0, utils_2.exec)('sleep 1', echo);
-        }
-        if (utils_1.default.isMountpoint(`${this.installTarget}/proc`)) {
-            await (0, utils_2.exec)(`umount ${this.installTarget}/proc` + this.toNull, echo);
-            await (0, utils_2.exec)('sleep 1', echo);
-        }
-        if (utils_1.default.isMountpoint(`${this.installTarget}/run`)) {
-            await (0, utils_2.exec)(`umount ${this.installTarget}/run` + this.toNull, echo);
-            await (0, utils_2.exec)('sleep 1', echo);
-        }
-        if (utils_1.default.isMountpoint(`${this.installTarget}/sys/fs/fuse/connections`)) {
-            await (0, utils_2.exec)(`umount ${this.installTarget}/sys/fs/fuse/connections` + this.toNull, echo);
-            await (0, utils_2.exec)('sleep 1', echo);
-        }
-        if (utils_1.default.isMountpoint(`${this.installTarget}/firmware/efi/efivars`)) {
-            await (0, utils_2.exec)(`umount ${this.installTarget}/firmware/efi/efivars` + this.toNull, echo);
-            await (0, utils_2.exec)('sleep 1', echo);
+        await this.umount(`${this.installTarget}/dev/pts`);
+        await this.umount(`${this.installTarget}/dev`);
+        await this.umount(`${this.installTarget}/proc`);
+        await this.umount(`${this.installTarget}/run`);
+        if (this.efi) {
+            await this.umount(`${this.installTarget}/sys/firmware/efi/efivars`);
         }
-        if (utils_1.default.isMountpoint(`${this.installTarget}/sys`)) {
-            await (0, utils_2.exec)(`umount ${this.installTarget}/sys` + this.toNull, echo);
-            await (0, utils_2.exec)('sleep 1', echo);
+        await this.umount(`${this.installTarget}/sys`);
+    }
+    /**
+     *
+     * @param mountpoint
+     */
+    async umount(mountPoint = '') {
+        const echo = { echo: false, ignore: false };
+        let message = 'umount: ' + mountPoint;
+        if (utils_1.default.isMountpoint(mountPoint)) {
+            try {
+                await (0, utils_2.exec)(`umount ${mountPoint}` + this.toNull, echo);
+                await (0, utils_2.exec)('sleep 1', echo);
+            }
+            catch (error) {
+                message += +mountPoint + JSON.stringify(error);
+                redraw(react_1.default.createElement(install_1.default, { message: message, percent: 1 }));
+                await checkIt(message);
+            }
         }
     }
     /**
      *
-     * @param p
-     * @returns
      */
     async partition() {
-        const echo = { echo: false, ignore: false };
+        const echo = utils_1.default.setEcho(this.verbose);
+        let echoYes = utils_1.default.setEcho(true);
         let retVal = false;
-        await (0, utils_2.exec)('wipefs -a ' + this.partitions.installationDevice + this.toNull);
-        if (this.partitions.installationMode === 'standard' && !this.efi) {
+        const installDevice = this.partitions.installationDevice;
+        const installMode = this.partitions.installationMode;
+        await (0, utils_2.exec)(`wipefs -a ${installDevice} ${this.toNull}`, echo);
+        if (installMode === 'standard' && !this.efi) {
             /**
-             * formattazione standard, BIOS working
+             * ===========================================================================================
+             * BIOS: working
+             * ===========================================================================================
              */
-            await (0, utils_2.exec)('parted --script ' + this.partitions.installationDevice + ' mklabel msdos' + this.toNull, echo);
-            await (0, utils_2.exec)('parted --script --align optimal ' + this.partitions.installationDevice + ' mkpart primary 1MiB 95%' + this.toNull, echo);
-            await (0, utils_2.exec)('parted --script ' + this.partitions.installationDevice + ' set 1 boot on' + this.toNull, echo);
-            await (0, utils_2.exec)('parted --script --align optimal ' + this.partitions.installationDevice + ' mkpart primary 95% 100%' + this.toNull, echo);
-            this.devices.efi.name = `none`;
-            this.devices.boot.name = `none`;
-            this.devices.root.name = this.partitions.installationDevice + '1';
+            await (0, utils_2.exec)(`parted --script ${installDevice} mklabel msdos`, echo);
+            await (0, utils_2.exec)(`parted --script --align optimal ${installDevice} mkpart primary linux-swap    1MiB     8192MiB`, echo); //dev/sda1 swap
+            await (0, utils_2.exec)(`parted --script --align optimal ${installDevice} mkpart primary ext4       8192MiB     100%`, echo); //dev/sda2 root
+            await (0, utils_2.exec)(`parted ${installDevice} set 1 boot on`, echo);
+            await (0, utils_2.exec)(`parted ${installDevice} set 1 esp on`, echo);
+            // SWAP
+            this.devices.swap.name = `${installDevice}1`;
+            this.devices.swap.fsType = 'swap';
+            this.devices.swap.mountPoint = 'none';
+            // ROOT
+            this.devices.root.name = `${installDevice}2`;
             this.devices.root.fsType = 'ext4';
             this.devices.root.mountPoint = '/';
+            // BOOT/DATA/EFI
+            this.devices.boot.name = `none`;
             this.devices.data.name = `none`;
-            this.devices.swap.name = this.partitions.installationDevice + '2';
+            this.devices.efi.name = `none`;
+            retVal = true;
+        }
+        else if (installMode === 'full-encrypted' && !this.efi) {
+            /**
+             * ===========================================================================================
+             * BIOS: full-encrypt:
+             * ===========================================================================================
+             */
+            await (0, utils_2.exec)(`parted --script ${installDevice} mklabel msdos`, echo);
+            await (0, utils_2.exec)(`parted --script --align optimal ${installDevice} mkpart primary ext4          1MiB   512MiB`, echo); // sda1
+            await (0, utils_2.exec)(`parted --script --align optimal ${installDevice} mkpart primary linux-swap  512MiB  8704MiB`, echo); // sda2
+            await (0, utils_2.exec)(`parted --script --align optimal ${installDevice} mkpart primary ext4       8704MiB     100%`, echo); // sda3
+            await (0, utils_2.exec)(`parted --script ${installDevice} set 1 boot on`, echo); // sda1
+            await (0, utils_2.exec)(`parted --script ${installDevice} set 1 esp on`, echo); // sda1
+            // BOOT 512M
+            this.devices.boot.name = `${installDevice}1`; // 'boot' 
+            this.devices.boot.fsType = 'ext4';
+            this.devices.boot.mountPoint = '/boot';
+            // SWAP 8G
+            redraw(react_1.default.createElement(install_1.default, { message: `Formatting LUKS ${installDevice}2`, percent: 0 }));
+            let crytoSwap = await (0, utils_2.exec)(`cryptsetup -y -v luksFormat --type luks2 ${installDevice}2`, echoYes);
+            if (crytoSwap.code !== 0) {
+                utils_1.default.warning(`Error: ${crytoSwap.code} ${crytoSwap.data}`);
+                process.exit(1);
+            }
+            redraw(react_1.default.createElement(install_1.default, { message: `Opening ${installDevice}2 as swap_crypted`, percent: 0 }));
+            let crytoSwapOpen = await (0, utils_2.exec)(`cryptsetup luksOpen --type luks2 ${installDevice}2 swap_crypted`, echoYes);
+            if (crytoSwapOpen.code !== 0) {
+                utils_1.default.warning(`Error: ${crytoSwapOpen.code} ${crytoSwapOpen.data}`);
+                process.exit(1);
+            }
+            this.devices.swap.name = '/dev/mapper/swap_crypted';
+            this.devices.swap.cryptedFrom = `${installDevice}2`;
             this.devices.swap.fsType = 'swap';
             this.devices.swap.mountPoint = 'none';
+            // ROOT
+            redraw(react_1.default.createElement(install_1.default, { message: `Formatting LUKS ${installDevice}3`, percent: 0 }));
+            let crytoRoot = await (0, utils_2.exec)(`cryptsetup -y -v luksFormat --type luks2 ${installDevice}3`, echoYes);
+            if (crytoRoot.code !== 0) {
+                utils_1.default.warning(`Error: ${crytoRoot.code} ${crytoRoot.data}`);
+                process.exit(1);
+            }
+            redraw(react_1.default.createElement(install_1.default, { message: `Opening ${installDevice}3 as root_crypted`, percent: 0 }));
+            let crytoRootOpen = await (0, utils_2.exec)(`cryptsetup luksOpen --type luks2 ${installDevice}3 root_crypted`, echoYes);
+            if (crytoRootOpen.code !== 0) {
+                utils_1.default.warning(`Error: ${crytoRootOpen.code} ${crytoRootOpen.data}`);
+                process.exit(1);
+            }
+            this.devices.root.name = '/dev/mapper/root_crypted';
+            this.devices.root.cryptedFrom = `${installDevice}3`;
+            this.devices.root.fsType = 'ext4';
+            this.devices.root.mountPoint = '/';
+            // BOOT/DATA/EFI
+            this.devices.data.name = `none`;
+            this.devices.efi.name = `none`;
             retVal = true;
         }
-        else if (this.partitions.installationMode === 'standard' && this.efi) {
+        else if (installMode === 'standard' && this.efi) {
             /**
-             * formattazione standard, EFI NOT working
+             * ===========================================================================================
+             * UEFI: working
+             * ===========================================================================================
              */
-            await (0, utils_2.exec)('parted --script ' + this.partitions.installationDevice + ' mklabel gpt mkpart primary 0% 1% mkpart primary 1% 95% mkpart primary linux-swap 95% 100%' + this.toNull, echo);
-            await (0, utils_2.exec)('parted --script ' + this.partitions.installationDevice + ' set 1 boot on' + this.toNull, echo);
-            await (0, utils_2.exec)('parted --script ' + this.partitions.installationDevice + ' set 1 esp on' + this.toNull, echo);
-            this.devices.efi.name = this.partitions.installationDevice + '1';
+            await (0, utils_2.exec)(`parted --script ${installDevice} mklabel gpt`, echo);
+            await (0, utils_2.exec)(`parted --script ${installDevice} mkpart efi  fat32         34s   256MiB`, echo); // sda1 EFI
+            await (0, utils_2.exec)(`parted --script ${installDevice} mkpart swap linux-swap 768MiB  8960MiB`, echo); // sda2 swap
+            await (0, utils_2.exec)(`parted --script ${installDevice} mkpart root ext4      8960MiB     100%`, echo); // sda3 root
+            await (0, utils_2.exec)(`parted --script ${installDevice} set 1 boot on`, echo); // sda1
+            await (0, utils_2.exec)(`parted --script ${installDevice} set 1 esp on`, echo); // sda1
+            this.devices.efi.name = `${installDevice}1`;
             this.devices.efi.fsType = 'F 32 -I';
             this.devices.efi.mountPoint = '/boot/efi';
             this.devices.boot.name = `none`;
-            this.devices.root.name = this.partitions.installationDevice + '2';
+            this.devices.swap.name = `${installDevice}2`;
+            this.devices.swap.fsType = 'swap';
+            this.devices.root.name = `${installDevice}3`;
             this.devices.root.fsType = 'ext4';
             this.devices.root.mountPoint = '/';
+            // BOOT/DATA/EFI
+            this.devices.boot.name = `none`;
             this.devices.data.name = `none`;
-            this.devices.swap.name = this.partitions.installationDevice + '3';
-            this.devices.swap.fsType = 'swap';
+            // this.devices.efi.name = `none`
             retVal = true;
+        }
+        else if (installMode === 'full-encrypted' && this.efi) {
             /**
-             * formattazione full-encrypted, BIOS standard
-             * cryptsetup -y -v --type luks2 luksFormat this.partitions.installationDevice
-             * cryptsetup luksOpen /dev/sda vgeggs
-             * Enter passphrase for /dev/sda: this.partitions.luksPassphrase
-             * pv -tpreb /dev/zero | dd of=/dev/mapper/vgeggs bs=128M
-             * mkfs.ext4 /dev/mapper/vgeggs
-             * cryptsetup luksClose vgeggs
+             * ===========================================================================================
+             * UEFI, full-encrypt: working
+             * ===========================================================================================
              */
-        }
-        else if (this.partitions.installationMode === 'full-encrypted' && !this.efi) {
-            await (0, utils_2.exec)(`cryptsetup -y -v --type luks2 luksFormat ${this.partitions.installationDevice}`, echo);
-            await (0, utils_2.exec)(`cryptsetup luksOpen ${this.partitions.installationDevice} vgeggs`, echo);
-            await (0, utils_2.exec)(`pv -tpreb /dev/zero | dd of=/dev/mapper/vgeggs bs=128M`, echo);
-            this.devices.efi.name = `none`;
-            this.devices.boot.name = `none`;
-            this.devices.root.name = '/dev/mapper/vgeggs';
-            this.devices.root.fsType = this.partitions.filesystemType;
+            await (0, utils_2.exec)(`parted --script ${installDevice} mklabel gpt`, echo);
+            await (0, utils_2.exec)(`parted --script ${installDevice} mkpart efi fat32           34s   256MiB`, echo); // sda1 EFI
+            await (0, utils_2.exec)(`parted --script ${installDevice} mkpart boot ext4        256MiB   768MiB`, echo); // sda2 boot
+            await (0, utils_2.exec)(`parted --script ${installDevice} mkpart swap linux-swap  768MiB  8960MiB`, echo); // sda3 swap
+            await (0, utils_2.exec)(`parted --script ${installDevice} mkpart root ext4       8960MiB     100%`, echo); // sda4 root
+            await (0, utils_2.exec)(`parted --script ${installDevice} set 1 boot on`, echo); // sda1
+            await (0, utils_2.exec)(`parted --script ${installDevice} set 1 esp on`, echo); // sda1
+            // EFI 256M
+            this.devices.efi.name = `${installDevice}1`; // 'efi' 
+            this.devices.efi.fsType = 'F 32 -I';
+            this.devices.efi.mountPoint = '/boot/efi';
+            // BOOT 512M
+            this.devices.boot.name = `${installDevice}2`; // 'boot' 
+            this.devices.boot.fsType = 'ext4';
+            this.devices.boot.mountPoint = '/boot';
+            // SWAP 8G
+            redraw(react_1.default.createElement(install_1.default, { message: `Formatting LUKS ${installDevice}3`, percent: 0 }));
+            let crytoSwap = await (0, utils_2.exec)(`cryptsetup -y -v luksFormat --type luks2 ${installDevice}3`, echoYes);
+            if (crytoSwap.code !== 0) {
+                utils_1.default.warning(`Error: ${crytoSwap.code} ${crytoSwap.data}`);
+                process.exit(1);
+            }
+            redraw(react_1.default.createElement(install_1.default, { message: `Opening ${installDevice}3 as swap_crypted`, percent: 0 }));
+            let crytoSwapOpen = await (0, utils_2.exec)(`cryptsetup luksOpen --type luks2 ${installDevice}3 swap_crypted`, echoYes);
+            if (crytoSwapOpen.code !== 0) {
+                utils_1.default.warning(`Error: ${crytoSwapOpen.code} ${crytoSwapOpen.data}`);
+                process.exit(1);
+            }
+            this.devices.swap.name = '/dev/mapper/swap_crypted';
+            this.devices.swap.cryptedFrom = `${installDevice}3`;
+            this.devices.swap.fsType = 'swap';
+            this.devices.swap.mountPoint = 'none';
+            // ROOT
+            redraw(react_1.default.createElement(install_1.default, { message: `Formatting LUKS ${installDevice}4`, percent: 0 }));
+            let crytoRoot = await (0, utils_2.exec)(`cryptsetup -y -v luksFormat --type luks2 ${installDevice}4`, echoYes);
+            if (crytoRoot.code !== 0) {
+                utils_1.default.warning(`Error: ${crytoRoot.code} ${crytoRoot.data}`);
+                process.exit(1);
+            }
+            redraw(react_1.default.createElement(install_1.default, { message: `Opening ${installDevice}4 as root_crypted`, percent: 0 }));
+            let crytoRootOpen = await (0, utils_2.exec)(`cryptsetup luksOpen --type luks2 ${installDevice}4 root_crypted`, echoYes);
+            if (crytoRootOpen.code !== 0) {
+                utils_1.default.warning(`Error: ${crytoRootOpen.code} ${crytoRootOpen.data}`);
+                process.exit(1);
+            }
+            this.devices.root.name = '/dev/mapper/root_crypted';
+            this.devices.root.cryptedFrom = `${installDevice}4`;
+            this.devices.root.fsType = 'ext4';
             this.devices.root.mountPoint = '/';
+            // BOOT/DATA/EFI
+            // this.devices.boot.name = `none`
             this.devices.data.name = `none`;
-            this.devices.swap.name = 'none';
-            this.devices.swap.fsType = 'none';
-            this.devices.swap.mountPoint = 'none';
+            // this.devices.efi.name = `none`
             retVal = true;
         }
-        else if (this.partitions.installationMode === 'lvm2' && !this.efi) {
+        else if (installMode === 'lvm2' && !this.efi) {
             /**
-            * LVM2, non EFI PROXMOX-VE
+            * ===========================================================================================
+            * PROXMOX VE: BIOS and lvm2
+            * ===========================================================================================
             */
-            await (0, utils_2.exec)(`parted --script ${this.partitions.installationDevice} mklabel msdos`);
+            await (0, utils_2.exec)(`parted --script ${installDevice} mklabel msdos`);
             // Creo partizioni
-            await (0, utils_2.exec)(`parted --script ${this.partitions.installationDevice} mkpart primary ext2 1 512`);
-            await (0, utils_2.exec)(`parted --script --align optimal ${this.partitions.installationDevice} set 1 boot on`);
-            await (0, utils_2.exec)(`parted --script --align optimal ${this.partitions.installationDevice} mkpart primary ext2 512 100%`);
-            await (0, utils_2.exec)(`parted --script ${this.partitions.installationDevice} set 2 lvm on`);
-            // Partizione LVM
-            const lvmPartname = shx.exec(`fdisk $1 -l | grep 8e | awk '{print $1}' | cut -d "/" -f3`).stdout.trim();
-            const lvmByteSize = Number(shx.exec(`cat /proc/partitions | grep ${lvmPartname}| awk '{print $3}' | grep "[0-9]"`).stdout.trim());
-            const lvmSize = lvmByteSize / 1024;
-            // La partizione di root viene posta ad 1/4 della partizione LVM.
-            // Viene limitata fino ad un massimo di 100 GB
-            const lvmSwapSize = 4 * 1024;
-            let lvmRootSize = lvmSize / 8;
-            if (lvmRootSize < 20480) {
-                lvmRootSize = 20480;
-            }
-            const lvmDataSize = lvmSize - lvmRootSize - lvmSwapSize;
+            await (0, utils_2.exec)(`parted --script ${installDevice} mkpart primary ext2 1 512`); // sda1
+            await (0, utils_2.exec)(`parted --script --align optimal ${installDevice} mkpart primary ext2 512 100%`); // sda2
+            await (0, utils_2.exec)(`parted --script ${installDevice} set 1 boot on`, echo); // sda1
+            await (0, utils_2.exec)(`parted --script ${installDevice} set 2 lvm on`, echo); // sda2
+            const lvmPartInfo = await this.lvmPartInfo(installDevice);
+            const lvmPartname = lvmPartInfo[0];
+            const lvmSwapSize = lvmPartInfo[1];
+            const lvmRootSize = lvmPartInfo[2];
+            //const lvmDataSize = lvmPartInfo[3]
             await (0, utils_2.exec)(`pvcreate /dev/${lvmPartname}`);
             await (0, utils_2.exec)(`vgcreate pve /dev/${lvmPartname}`);
             await (0, utils_2.exec)(`vgchange -an`);
@@ -941,7 +1123,7 @@ adduser ${name} \
             await (0, utils_2.exec)(`lvcreate -l 100%FREE -ndata pve`);
             await (0, utils_2.exec)(`vgchange -a y pve`);
             this.devices.efi.name = `none`;
-            this.devices.boot.name = `${this.partitions.installationDevice}1`;
+            this.devices.boot.name = `${installDevice}1`;
             this.devices.root.fsType = 'ext2';
             this.devices.root.mountPoint = '/boot';
             this.devices.root.name = `/dev/pve/root`;
@@ -955,13 +1137,64 @@ adduser ${name} \
         }
         else if (this.partitions.installationMode === 'lvm2' && this.efi) {
             /**
-            * LVM2, EFI
+            * ===========================================================================================
+            * PROXMOX VE: lvm2 and UEFI
+            * ===========================================================================================
             */
-            console.log('LVM2 on UEFI: to be implemented!');
-            process.exit(0);
+            await (0, utils_2.exec)(`parted --script ${installDevice} mklabel gpt`, echo);
+            await (0, utils_2.exec)(`parted --script ${installDevice} mkpart efi  fat32    34s   256MiB`, echo); // sda1 EFI
+            await (0, utils_2.exec)(`parted --script ${installDevice} mkpart boot ext2  256MiB   768MiB`, echo); // sda2 boot
+            await (0, utils_2.exec)(`parted --script ${installDevice} mkpart lvm  ext4  768MiB     100%`, echo); // sda3 lmv2
+            await (0, utils_2.exec)(`parted --script ${installDevice} set 1 boot on`, echo); // sda1
+            await (0, utils_2.exec)(`parted --script ${installDevice} set 1 esp on`, echo); // sda1
+            await (0, utils_2.exec)(`parted --script ${installDevice} set 3 lvm on`); // sda3
+            const lvmPartInfo = await this.lvmPartInfo(installDevice);
+            const lvmPartname = lvmPartInfo[0];
+            const lvmSwapSize = lvmPartInfo[1];
+            const lvmRootSize = lvmPartInfo[2];
+            //const lvmDataSize = lvmPartInfo[3]
+            await (0, utils_2.exec)(`pvcreate /dev/${lvmPartname}`);
+            await (0, utils_2.exec)(`vgcreate pve /dev/${lvmPartname}`);
+            await (0, utils_2.exec)(`vgchange -an`);
+            await (0, utils_2.exec)(`lvcreate -L ${lvmSwapSize} -nswap pve`);
+            await (0, utils_2.exec)(`lvcreate -L ${lvmRootSize} -nroot pve`);
+            await (0, utils_2.exec)(`lvcreate -l 100%FREE -ndata pve`);
+            await (0, utils_2.exec)(`vgchange -a y pve`);
+            this.devices.efi.name = `${installDevice}1`;
+            this.devices.efi.fsType = 'F 32 -I';
+            this.devices.efi.mountPoint = '/boot/efi';
+            this.devices.boot.name = `${installDevice}2`;
+            this.devices.boot.fsType = 'ext4';
+            this.devices.boot.mountPoint = '/boot';
+            this.devices.root.name = `/dev/pve/root`;
+            this.devices.root.fsType = 'ext4';
+            this.devices.root.mountPoint = '/';
+            this.devices.data.name = `/dev/pve/data`;
+            this.devices.data.fsType = 'ext4';
+            this.devices.data.mountPoint = '/var/lib/vz';
+            this.devices.swap.name = `/dev/pve/swap`;
+            retVal = true;
         }
         return retVal;
     }
+    /**
+     * Return lvmPartname, lvmSwapSize, lvmRootSize
+     */
+    async lvmPartInfo(installDevice = '/dev/sda') {
+        // 
+        // Partizione LVM
+        const lvmPartname = shx.exec(`fdisk ${installDevice} -l | grep LVM | awk '{print $1}' | cut -d "/" -f3`).stdout.trim();
+        const lvmByteSize = Number(shx.exec(`cat /proc/partitions | grep ${lvmPartname}| awk '{print $3}' | grep "[0-9]"`).stdout.trim());
+        const lvmSize = lvmByteSize / 1024;
+        // La partizione di root viene posta ad 1/4 della partizione LVM, limite max 100 GB
+        const lvmSwapSize = 8192;
+        let lvmRootSize = lvmSize / 8;
+        if (lvmRootSize < 20480) {
+            lvmRootSize = 20480;
+        }
+        const lvmDataSize = lvmSize - lvmRootSize - lvmSwapSize;
+        return [lvmPartname, lvmSwapSize, lvmRootSize, lvmDataSize];
+    }
     /**
      * isRotational
      * @param device
@@ -1079,6 +1312,42 @@ adduser ${name} \
             console.log('cmd: ' + cmd + ' error: ' + error);
         }
     }
+    /**
+     * grubcfg
+     * - open /etc/default/grub
+     * - find GRUB_CMDLINE_LINUX_DEFAULT=
+     * - replace with GRUB_CMDLINE_LINUX_DEFAULT=
+     * 's/GRUB_CMDLINE_LINUX_DEFAULT=.*$/GRUB_CMDLINE_LINUX_DEFAULT=/g'
+     */
+    grubcfg() {
+        let file = `${this.installTarget}/etc/default/grub`;
+        let content = '';
+        const grubs = fs_1.default.readFileSync(file, 'utf-8').split('\n');
+        for (let i = 0; i < grubs.length; i++) {
+            if (grubs[i].includes('GRUB_CMDLINE_LINUX_DEFAULT=')) {
+                if (this.partitions.installationMode === 'full-encrypted') {
+                    grubs[i] = `GRUB_CMDLINE_LINUX_DEFAULT="resume=UUID=${utils_1.default.uuid(this.devices.swap.name)}"`;
+                }
+                else {
+                    grubs[i] = `GRUB_CMDLINE_LINUX_DEFAULT="quiet splash resume=UUID=${utils_1.default.uuid(this.devices.swap.name)}"`;
+                }
+            }
+            content += grubs[i] + '\n';
+        }
+        fs_1.default.writeFileSync(file, content, 'utf-8');
+    }
+    /**
+     * On Ubuntu
+     * /etc/machine-id must exist to be re-created
+     * https://unix.stackexchange.com/questions/402999/is-it-ok-to-change-etc-machine-id
+     */
+    async machineId() {
+        let file = `${this.installTarget}/etc/machine-id`;
+        if (fs_1.default.existsSync(file)) {
+            await (0, utils_2.exec)(`rm ${file}`);
+        }
+        await (0, utils_2.exec)(`touch ${file}`);
+    }
     /**
      * only show the result
      */
@@ -1107,5 +1376,7 @@ function redraw(elem) {
  * @param message
  */
 async function checkIt(message) {
-    await utils_1.default.customConfirm(message);
+    utils_1.default.error('Krill Installer generated an error, the installation process will end now');
+    console.log('Press a key to exit...');
+    require('child_process').spawnSync('read _ ', { shell: true, stdio: [0, 1, 2] });
 }