pending-dns 1.2.1 → 1.2.3

package/LICENSE.txt

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2020 Andris Reinman
+Copyright (c) 2020-2023 Andris Reinman
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

package/lib/dns-handler.js

@@ -341,10 +341,11 @@ const dnsHandler = async request => {
 
     await Promise.all(
         request.questions.map(question => {
-            logger.info({
+            logger.debug({
                 id: request._id,
                 msg: 'DNS query',
-                type: request.source.type,
+                action: 'dns_query',
+                proto: request.source.type,
                 port: request.source.port,
                 address: request.source.address,
                 question: question.name,
@@ -354,9 +355,10 @@ const dnsHandler = async request => {
         })
     );
 
-    logger.info({
-        msg: 'DNS response',
+    logger.debug({
         id: request._id,
+        msg: 'DNS response',
+        action: 'dns_response',
         dnsTime: Date.now() - startTime,
         questions: request.questions,
         answers: response.answers

package/lib/dns-server.js

@@ -59,7 +59,11 @@ const init = async () => {
             logger.info({ msg: 'DNS server listening', protocol: 'tcp', host: config.dns.host, port: config.dns.port });
         })
         .on('error', err => {
-            logger.error({ msg: 'DNS server error', protocol: 'tcp', err });
+            let method = 'error';
+            if (err && ['ECONNRESET'].includes(err.code)) {
+                method = 'trace';
+            }
+            logger[method]({ msg: 'DNS server error', protocol: 'tcp', err });
         });
 };
 

package/lib/dns-tcp-server.js

@@ -40,15 +40,17 @@ class DNSTcpServer extends EventEmitter {
                 try {
                     request = Packet.parse(buffer.slice(2));
                 } catch (err) {
-                    logger.error({ msg: 'Failed to parse DNS package', type: 'tcp', err, buffer, port: socket.remotePort, address: socket.remoteAddress });
+                    logger.trace({ msg: 'Failed to parse DNS package', proto: 'tcp', err, buffer, port: socket.remotePort, address: socket.remoteAddress });
                     try {
                         socket.end();
                     } catch (err) {
                         // ignore
                     }
+                    return;
                 }
+
                 request.source = {
-                    type: 'tcp',
+                    proto: 'tcp',
                     port: socket.remotePort,
                     address: socket.remoteAddress
                 };
@@ -93,10 +95,16 @@ class DNSTcpServer extends EventEmitter {
             try {
                 let len = Buffer.alloc(2);
                 len.writeUInt16BE(message.length);
-                socket.end(Buffer.concat([len, message]));
+
+                if (['open', 'writeOnly'].includes(socket.readyState)) {
+                    socket.end(Buffer.concat([len, message]));
+                } else {
+                    socket.end();
+                }
             } catch (err) {
                 // ignore
             }
+
             resolve(message);
         });
     }

package/lib/dns-udp-server.js

@@ -26,13 +26,16 @@ class DNSUdpServer extends EventEmitter {
         try {
             request = Packet.parse(buffer);
         } catch (err) {
-            logger.error({ msg: 'Failed to parse DNS package', type: 'udp', err, buffer, port: rinfo.port, address: rinfo.address });
+            logger.trace({ msg: 'Failed to parse DNS package', proto: 'udp', err, buffer, port: rinfo.port, address: rinfo.address });
+            return;
         }
+
         request.source = {
-            type: 'udp',
+            proto: 'udp',
             port: rinfo.port,
             address: rinfo.address
         };
+
         this.emit('request', request, this.send.bind(this, rinfo), rinfo);
     }
     send(rinfo, message) {

package/lib/public-server.js

@@ -263,7 +263,17 @@ const setupHttps = () =>
 
                     logger.error({ msg: 'Failed to serve redirect page', err, hostname });
 
-                    const url = new URL(req.url || req.headers[':path'], `https://${hostname}/`);
+                    let url;
+                    try {
+                        url = new URL(req.url || req.headers[':path'], `https://${hostname}/`);
+                    } catch (err) {
+                        try {
+                            url = new URL(req.headers[':path'], `https://${hostname}/`);
+                        } catch (err) {
+                            url = `https://${hostname}/`;
+                        }
+                    }
+
                     const route = url.pathname;
 
                     res.send(
@@ -332,8 +342,17 @@ const setupHttp = () =>
                 const hostname = getHostname(req).replace(/^www\./, '');
 
                 logger.error({ msg: 'Failed to serve redirect page', err, hostname });
+                let url;
+                try {
+                    url = new URL(req.url || req.headers[':path'], `https://${hostname}/`);
+                } catch (err) {
+                    try {
+                        url = new URL(req.headers[':path'], `https://${hostname}/`);
+                    } catch (err) {
+                        url = `https://${hostname}/`;
+                    }
+                }
 
-                const url = new URL(req.url || req.headers[':path'], `https://${hostname}/`);
                 const route = url.pathname;
 
                 res.send(

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "pending-dns",
-    "version": "1.2.1",
+    "version": "1.2.3",
     "description": "Lightweight API driven DNS server",
     "main": "index.js",
     "scripts": {
@@ -28,26 +28,26 @@
     },
     "homepage": "https://github.com/postalsys/pending-dns#readme",
     "devDependencies": {
-        "eslint": "8.45.0",
+        "eslint": "8.47.0",
         "eslint-config-nodemailer": "1.2.0",
-        "eslint-config-prettier": "8.8.0",
+        "eslint-config-prettier": "9.0.0",
         "grunt": "1.6.1",
         "grunt-cli": "1.4.3",
         "grunt-eslint": "24.3.0",
         "license-report": "6.4.0"
     },
     "dependencies": {
-        "@bugsnag/js": "^7.20.2",
+        "@bugsnag/js": "7.21.0",
         "@fidm/x509": "1.2.1",
         "@hapi/boom": "10.0.1",
         "@hapi/hapi": "21.3.2",
         "@hapi/inert": "7.1.0",
         "@hapi/joi": "17.1.1",
-        "@hapi/vision": "7.0.2",
+        "@hapi/vision": "7.0.3",
         "@root/acme": "3.1.0",
         "@root/csr": "0.8.1",
         "dns2": "2.1.0",
-        "handlebars": "4.7.7",
+        "handlebars": "4.7.8",
         "hapi-pino": "12.1.0",
         "hapi-swagger": "17.1.0",
         "http-proxy": "1.18.1",
@@ -57,7 +57,7 @@
         "minimist": "1.2.8",
         "node-rsa": "1.1.1",
         "pem-jwk": "2.0.0",
-        "pino": "8.14.1",
+        "pino": "8.15.0",
         "punycode": "2.3.0",
         "shortid": "2.2.16",
         "uuid": "9.0.0",
@@ -73,9 +73,10 @@
             "help.txt"
         ],
         "targets": [
-            "node16-linux-x64",
-            "node16-macos-x64",
-            "node16-win-x64"
+            "node18-linux-x64",
+            "node18-macos-x64",
+            "node18-macos-arm64",
+            "node18-win-x64"
         ],
         "outputPath": "ee-dist"
     }