peaks-loop 4.0.16 → 4.0.18

package/dist/services/slice/slice-check-service.js

@@ -10,6 +10,23 @@ import { isDirectory } from 'peaks-loop-shared/fs';
 import { verifyPipeline } from '../workflow/pipeline-verify-service.js';
 import { findMockViolations } from '../audit/enforcers/mock-placement.js';
 import { runRedLinesAudit } from '../audit/red-lines-service.js';
+/**
+ * PRD-002b slice 2 — extract timeouts + budget constants for the
+ * slice-check pipeline (typecheck / unit-tests / git diff / fixture
+ * staging thresholds). Values are bytewise-identical to the original
+ * literals.
+ */
+const TYPECHECK_TIMEOUT_MS = 180_000;
+const UNIT_TESTS_TIMEOUT_MS = 600_000;
+const GIT_DIFF_TIMEOUT_MS = 30_000;
+const BYTES_PER_KB = 1024;
+const BYTES_PER_MB = BYTES_PER_KB * BYTES_PER_KB;
+const EXEC_MAX_BUFFER_BYTES = 32 * BYTES_PER_MB;
+const TYPECHECK_TAIL_LINES = 10;
+const UNIT_TEST_TAIL_LINES = 12;
+const HEAD_LINES_IN_TAIL = 3;
+const AUDIT_MIN_RED_LINES = 60;
+const REVIEW_FILE_MIN_BYTES = 20;
 /**
  * Resolve a CLI binary to a project-local path, falling back to
  * the system `npx`. pnpm (and npm/yarn) all create
@@ -52,7 +69,7 @@ function runCommand(command, args, cwd, timeoutMs, shell = false) {
             cwd,
             stdio: ['ignore', 'pipe', 'pipe'],
             timeout: timeoutMs,
-            maxBuffer: 32 * 1024 * 1024,
+            maxBuffer: EXEC_MAX_BUFFER_BYTES,
             shell
         }).toString('utf8');
         return {
@@ -64,13 +81,17 @@ function runCommand(command, args, cwd, timeoutMs, shell = false) {
         };
     }
     catch (error) {
-        const stdout = (error?.stdout ?? '').toString('utf8');
-        const stderr = (error?.stderr ?? '').toString('utf8');
+        // execFileSync throws `Error & { stdout, stderr, status }` on
+        // non-zero exit (Node child_process typings). We narrow inline to
+        // preserve the existing optional-chain fallback for non-Error throws.
+        const e = error;
+        const stdout = (e.stdout ?? '').toString('utf8');
+        const stderr = (e.stderr ?? '').toString('utf8');
         return {
             status: 'fail',
             stdout,
             stderr,
-            exitCode: typeof error?.status === 'number' ? error.status : 1,
+            exitCode: typeof e.status === 'number' ? e.status : 1,
             durationMs: Date.now() - start
         };
     }
@@ -79,7 +100,7 @@ function tailLines(text, max) {
     const lines = text.split('\n').filter((l) => l.trim().length > 0);
     if (lines.length <= max)
         return lines.join('\n');
-    return [...lines.slice(0, 3), `... (${lines.length - max} more lines) ...`, ...lines.slice(-max + 3)].join('\n');
+    return [...lines.slice(0, HEAD_LINES_IN_TAIL), `... (${lines.length - max} more lines) ...`, ...lines.slice(-max + HEAD_LINES_IN_TAIL)].join('\n');
 }
 async function runTypecheck(projectRoot) {
     const start = Date.now();
@@ -89,7 +110,7 @@ async function runTypecheck(projectRoot) {
     // installed by pnpm at workspace-install time and avoids the
     // npx PATH-lookup issue.
     const tsc = resolveLocalBinary(projectRoot, 'tsc');
-    const result = runCommand(tsc.command, [...tsc.args, '--noEmit'], projectRoot, 180_000, tsc.shell);
+    const result = runCommand(tsc.command, [...tsc.args, '--noEmit'], projectRoot, TYPECHECK_TIMEOUT_MS, tsc.shell);
     const testFiles = result.stdout.match(/(tests?\/.*\.test\.ts)/g) ?? [];
     return {
         name: 'typecheck',
@@ -98,7 +119,7 @@ async function runTypecheck(projectRoot) {
         durationMs: result.durationMs,
         detail: result.status === 'pass'
             ? `Typecheck passed in ${result.durationMs}ms.`
-            : tailLines(result.stdout + result.stderr, 10) || `tsc exited with code ${result.exitCode}.`,
+            : tailLines(result.stdout + result.stderr, TYPECHECK_TAIL_LINES) || `tsc exited with code ${result.exitCode}.`,
         data: { exitCode: result.exitCode }
     };
 }
@@ -134,7 +155,7 @@ async function runUnitTests(projectRoot, runTests) {
     const description = runTests
         ? `${vitest.command} run (full test suite, coverage off)`
         : `${vitest.command} run --changed (tests for git-changed files only, coverage off)`;
-    const result = runCommand(vitest.command, [...vitest.args, ...vitestArgs], projectRoot, 600_000, vitest.shell);
+    const result = runCommand(vitest.command, [...vitest.args, ...vitestArgs], projectRoot, UNIT_TESTS_TIMEOUT_MS, vitest.shell);
     const summary = parseVitestSummary(result.stdout, result.durationMs);
     // Vitest doesn't always print the per-bucket counts cleanly; infer "passed"
     // as total - failed - skipped when failed/skipped buckets are present.
@@ -146,7 +167,7 @@ async function runUnitTests(projectRoot, runTests) {
         durationMs: result.durationMs,
         detail: result.status === 'pass'
             ? `All tests passed in ${result.durationMs}ms.`
-            : tailLines(result.stdout + result.stderr, 12) || `vitest exited with code ${result.exitCode}.`,
+            : tailLines(result.stdout + result.stderr, UNIT_TEST_TAIL_LINES) || `vitest exited with code ${result.exitCode}.`,
         data: {
             tests: summary.tests,
             passed,
@@ -212,7 +233,7 @@ async function runReviewFanout(projectRoot, rid, refresh) {
                 const abs = join(projectRoot, '.peaks', scope, candidate);
                 if (existsSync(abs)) {
                     const bytes = statSync(abs).size;
-                    if (bytes >= 20) {
+                    if (bytes >= REVIEW_FILE_MIN_BYTES) {
                         hit = { abs, scope, bytes };
                         break;
                     }
@@ -268,7 +289,7 @@ async function runGateVerifyPipeline(projectRoot, rid, sessionId) {
             description: 'peaks workflow verify-pipeline (RD/QA gate checks against .peaks/_runtime/change/<sessionId>/)',
             status: 'fail',
             durationMs: Date.now() - start,
-            detail: error?.message ?? 'verify-pipeline threw',
+            detail: error instanceof Error ? error.message : 'verify-pipeline threw',
             data: {}
         };
     }
@@ -372,7 +393,7 @@ async function runAuditRegression(projectRoot) {
         //   - totalRedLines >= 60 (catalog grew to 66; pins the lower bound)
         //   - enforcerFindings has no rl-audit-no-orphan-enforcer / rl-audit-no-orphan-catalog hits
         const issues = [];
-        if (result.audit.totalRedLines < 60) {
+        if (result.audit.totalRedLines < AUDIT_MIN_RED_LINES) {
             issues.push(`totalRedLines ${result.audit.totalRedLines} < 60`);
         }
         const orphanFindings = result.audit.enforcerFindings.filter((f) => f.enforcerId === 'rl-audit-no-orphan-enforcer-001' ||
@@ -403,7 +424,7 @@ async function runAuditRegression(projectRoot) {
             description: 'audit-regression: catalog integrity + runtime budget (L2.4 P2-b stage 6)',
             status: 'fail',
             durationMs: Date.now() - start,
-            detail: 'audit-regression failed: ' + (error?.message ?? String(error)),
+            detail: 'audit-regression failed: ' + (error instanceof Error ? error.message : String(error)),
         };
     }
 }
@@ -411,7 +432,7 @@ async function runMockPlacement(projectRoot) {
     const start = Date.now();
     // List changed files via git. `--name-only` produces one path per line;
     // we filter to text files in scope and read each.
-    const diffResult = runCommand('git', ['diff', '--name-only', '--diff-filter=ACMR', 'HEAD'], projectRoot, 30_000);
+    const diffResult = runCommand('git', ['diff', '--name-only', '--diff-filter=ACMR', 'HEAD'], projectRoot, GIT_DIFF_TIMEOUT_MS);
     if (diffResult.status !== 'pass') {
         return {
             name: 'mock-placement',