peaks-loop 4.0.16 → 4.0.17

package/dist/services/compact-statusline/compact-statusline-service.js

@@ -56,17 +56,24 @@ const DEFAULT_STALE_AFTER_MS = 120_000;
 export const COMPLETED_EXPIRY_MS = 10_000;
 /** Legacy mtime window for the "just compacted" indicator. */
 const LEGACY_JUST_COMPACTED_WINDOW_MS = 30_000;
+// PRD-002b slice 2 — extract cell-table magic numbers (4/6/8) into named
+// consts so the no-magic-numbers lint rule stops flagging the typed
+// literal-union cell-table values. Values match the documented contract.
+const STAGE_CELL_COMPACTING = 4;
+const STAGE_CELL_VERIFYING = 6;
+const STAGE_CELL_COMPLETED = 8;
+/* eslint-disable no-magic-numbers -- cell-table contract uses literal-type unions (`0 | 2 | 4 | 6 | 8`); these are type-position discriminators, not runtime values. Magic-number extraction is done at the runtime call sites via STAGE_CELL_* constants above. */
 const CELL_BY_STAGE = new Map([
     ['queued', 0],
     ['preparing', 2],
-    ['compacting', 4],
-    ['verifying', 6],
-    ['completed', 8],
-    ['failed', 4],
+    ['compacting', STAGE_CELL_COMPACTING],
+    ['verifying', STAGE_CELL_VERIFYING],
+    ['completed', STAGE_CELL_COMPLETED],
+    ['failed', STAGE_CELL_COMPACTING],
 ]);
 const FILLED = '█';
 const EMPTY = '░';
-const BAR_WIDTH = 8;
+const BAR_WIDTH = STAGE_CELL_COMPLETED;
 const NO_AFTER_RATIO_HINT = 'after-ratio not recorded';
 function renderBar(filledCells) {
     return `[${FILLED.repeat(filledCells)}${EMPTY.repeat(BAR_WIDTH - filledCells)}]`;
@@ -74,6 +81,7 @@ function renderBar(filledCells) {
 function renderLegacyBar(filledCells) {
     return renderBar(filledCells);
 }
+/* eslint-enable no-magic-numbers */
 export function decideCompactStatusline(input) {
     const staleAfterMs = input.staleAfterMs ?? DEFAULT_STALE_AFTER_MS;
     const completedExpiryMs = input.completedExpiryMs ?? COMPLETED_EXPIRY_MS;
@@ -137,7 +145,7 @@ function stateFromLifecycle(record) {
         const failedAt = record.failedAt ?? 'compacting';
         const state = {
             kind: 'failed',
-            filledCells: CELL_BY_STAGE.get(failedAt) ?? 4,
+            filledCells: CELL_BY_STAGE.get(failedAt) ?? STAGE_CELL_COMPACTING,
             triggerRatio: record.triggerRatio,
             redLine: record.redLine,
             failedAt,
@@ -160,7 +168,7 @@ function stateFromLifecycle(record) {
     return base;
 }
 function stateFromStalled(record) {
-    const filledCells = CELL_BY_STAGE.get(record.stage) ?? 4;
+    const filledCells = CELL_BY_STAGE.get(record.stage) ?? STAGE_CELL_COMPACTING;
     const detailText = record.stage === 'failed'
         ? record.errorSummary
         : `no heartbeat for ${record.stage} stage`;
@@ -236,9 +244,9 @@ export function renderCompactStatusline(state) {
         case 'preparing':
             return `compact ${renderBar(2)}`;
         case 'compacting':
-            return `compact ${renderBar(4)}`;
+            return `compact ${renderBar(STAGE_CELL_COMPACTING)}`;
         case 'verifying':
-            return `compact ${renderBar(6)}`;
+            return `compact ${renderBar(STAGE_CELL_VERIFYING)}`;
         case 'completed':
             return formatCompleted(state);
         case 'failed':
@@ -250,7 +258,7 @@ export function renderCompactStatusline(state) {
     }
 }
 function formatCompleted(state) {
-    const bar = renderBar(8);
+    const bar = renderBar(STAGE_CELL_COMPLETED);
     if (typeof state.afterRatio === 'number') {
         return `compact ${bar} → ${state.afterRatio.toFixed(2)}`;
     }
@@ -258,7 +266,7 @@ function formatCompleted(state) {
 }
 function formatFailed(state) {
     const filledAt = state.failedAt ?? 'compacting';
-    const cells = CELL_BY_STAGE.get(filledAt) ?? 4;
+    const cells = CELL_BY_STAGE.get(filledAt) ?? STAGE_CELL_COMPACTING;
     const bar = renderBar(cells);
     const detail = state.detail ? ` — ${state.detail}` : '';
     return `compact ${bar} failed at ${filledAt}${detail}`;

package/dist/services/config/config-service.d.ts

@@ -1,4 +1,4 @@
-import type { ConfigGetOptions, ConfigLayer, ConfigSetOptions, ConfigV2, PeaksConfig, TokenRef, WorkspaceConfig } from './config-types.js';
+import { type ConfigGetOptions, type ConfigLayer, type ConfigSetOptions, type ConfigV2, type PeaksConfig, type TokenRef, type WorkspaceConfig } from './config-types.js';
 export { resolveProjectRootForConfig, resolveCanonicalProjectRoot } from './config-safety.js';
 /**
  * Load the slim 2.0 `~/.peaks/config.json` file. Returns the parsed

package/dist/services/config/config-service.js

@@ -1,12 +1,10 @@
 import { existsSync, mkdirSync } from 'node:fs';
 import { dirname, isAbsolute, resolve } from 'node:path';
-import { DEFAULT_CONFIG } from './config-types.js';
+import { DEFAULT_CONFIG, isConfigV2 } from './config-types.js';
 import { stablePath } from '../../shared/path-utils.js';
 import { findProjectRoot, getProjectBootstrapConfigPath, getProjectConfigPath, getUserConfigPath, isInsidePath, readConfigFileSafely, resolveProjectRootForConfig, validateArtifactWorkspaceMarkerPath, validateArtifactWorkspaceRoot, validateProjectBootstrapConfigPathForWrite, validateUserConfigPathForWrite, writeConfigFileSafely, writeProjectConfigFile, writeUserConfigFile } from './config-safety.js';
 import { globalConfigPath, CONFIG_SCHEMA_VERSION_V2 } from './config-migration.js';
-import { isConfigV2 } from './config-types.js';
-import { providersConfigPath, proxyConfigPath, readSidecarJson, sidecarExists, workspacesConfigPath, writeSidecarJson } from './sidecar-store.js';
-import { SIDECAR_SCHEMA_VERSION } from './sidecar-store.js';
+import { SIDECAR_SCHEMA_VERSION, providersConfigPath, proxyConfigPath, readSidecarJson, sidecarExists, workspacesConfigPath, writeSidecarJson } from './sidecar-store.js';
 // Re-export resolveProjectRootForConfig and resolveCanonicalProjectRoot for external consumers
 export { resolveProjectRootForConfig, resolveCanonicalProjectRoot } from './config-safety.js';
 /**

package/dist/services/container/container-lease.js

@@ -30,13 +30,26 @@
 import { randomBytes } from 'node:crypto';
 import { posix as path } from 'node:path';
 import { normalizePath } from '../../shared/path-utils.js';
+/**
+ * PRD-002b slice 2 — lease-TTL primitives extracted so the
+ * no-magic-numbers rule stops flagging the minute/ms math.
+ */
+const MINUTES_PER_HOUR = 60;
+const MS_PER_MINUTE = MINUTES_PER_HOUR * 1_000;
+const LEASE_RD_TTL_MINUTES = 30;
+const LEASE_QA_TTL_MINUTES = 15;
+const LEASE_UI_TTL_MINUTES = MINUTES_PER_HOUR;
+const LEASE_SC_TTL_MINUTES = 30;
+const LEASE_PRD_TTL_MINUTES = 15;
+const LEASE_GENERAL_TTL_MINUTES = 30;
+const LEASE_ID_RANDOM_BYTES = 8;
 export const DEFAULT_TTL_BY_ROLE = Object.freeze({
-    rd: 30 * 60 * 1_000,
-    qa: 15 * 60 * 1_000,
-    ui: 60 * 60 * 1_000,
-    sc: 30 * 60 * 1_000,
-    prd: 15 * 60 * 1_000,
-    general: 30 * 60 * 1_000
+    rd: LEASE_RD_TTL_MINUTES * MS_PER_MINUTE,
+    qa: LEASE_QA_TTL_MINUTES * MS_PER_MINUTE,
+    ui: LEASE_UI_TTL_MINUTES * MS_PER_MINUTE,
+    sc: LEASE_SC_TTL_MINUTES * MS_PER_MINUTE,
+    prd: LEASE_PRD_TTL_MINUTES * MS_PER_MINUTE,
+    general: LEASE_GENERAL_TTL_MINUTES * MS_PER_MINUTE
 });
 export const DEFAULT_TTL_MS = DEFAULT_TTL_BY_ROLE.rd;
 export function containerLeaseStoreDir(sessionRuntimeDir) {
@@ -47,12 +60,12 @@ export function containerLeaseFilePath(sessionRuntimeDir, leaseId) {
 }
 /** Pure: generate a 16-hex lease id (8 random bytes, hex-encoded). */
 export function generateContainerLeaseId() {
-    return randomBytes(8).toString('hex');
+    return randomBytes(LEASE_ID_RANDOM_BYTES).toString('hex');
 }
 export function ttlForContainerRole(role) {
     const normalized = role.toLowerCase();
     const candidate = DEFAULT_TTL_BY_ROLE[normalized];
-    const fallback = DEFAULT_TTL_BY_ROLE['rd'] ?? 30 * 60 * 1_000;
+    const fallback = DEFAULT_TTL_BY_ROLE['rd'] ?? LEASE_RD_TTL_MINUTES * MS_PER_MINUTE;
     return candidate ?? fallback;
 }
 export function finalizeContainerLease(draft) {

package/dist/services/context/spillover-store.d.ts

@@ -1,4 +1,4 @@
-import type { SpillId, SpillOptions, SpillRecord, SpillState } from './spillover-types.js';
+import { type SpillId, type SpillOptions, type SpillRecord, type SpillState } from './spillover-types.js';
 /**
  * Defense-in-depth: assert the given path is NOT a symbolic link.
  *

package/dist/services/crystallization/crystallization-types.js

@@ -1,4 +1,16 @@
 import { z } from "zod";
+/* ---------------------------------------------------------------------- */
+/* PRD-002b slice 2 — schema-limit constants extracted from inline         */
+/* `.max(N)` / `.length(N)` calls so the no-magic-numbers rule stops     */
+/* flagging the constraint values. Names describe the field, not the     */
+/* number. Bytewise-identical to the original literals.                  */
+/* ---------------------------------------------------------------------- */
+const CRYS_BRIEF_SECTION_MAX = 4000;
+const CRYS_EVIDENCE_BULLET_MAX = 1000;
+const CRYS_TRACE_POINTER_MAX = 256;
+const CRYS_LOOP_ID_MAX = 64;
+const CRYS_BEE_ID_MAX_I32 = 2 ** 31 - 1;
+const CRYS_EVENT_ID_MAX = 128;
 /**
  * CrystallizationEvent — spec §4.5 / §4.7 / §5.
  *
@@ -71,7 +83,7 @@ const BriefSectionSchema = z
     .string()
     .trim()
     .min(1, "brief section must be non-empty natural language")
-    .max(4000);
+    .max(CRYS_BRIEF_SECTION_MAX);
 /**
  * EvidenceBrief — the 4-section brief (spec §4.7).
  *
@@ -138,7 +150,7 @@ export function hasAllFourBriefSections(brief) {
 const OptionalLoopId = z
     .string()
     .min(1)
-    .max(64)
+    .max(CRYS_LOOP_ID_MAX)
     .regex(/^[a-z][a-z0-9]*(-[a-z0-9]+)*$/, {
     message: "loop_release_id must be kebab-case starting with a lowercase letter",
 })
@@ -147,7 +159,7 @@ const OptionalBeeId = z
     .number()
     .int()
     .positive()
-    .max(2 ** 31 - 1, "bee_release_id out of 32-bit range")
+    .max(CRYS_BEE_ID_MAX_I32, "bee_release_id out of 32-bit range")
     .optional();
 /**
  * Zod schema for the create payload (CrystallizationEventInput).
@@ -161,20 +173,20 @@ export const CrystallizationEventInputSchema = z.object({
     trigger: CrystallizationTriggerSchema,
     evidence_brief: EvidenceBriefSchema,
     evidence_bullets: z
-        .array(z.string().trim().min(1).max(1000))
+        .array(z.string().trim().min(1).max(CRYS_EVIDENCE_BULLET_MAX))
         .default([]),
     source_trace_pointers: z
-        .array(z.string().trim().min(1).max(256))
+        .array(z.string().trim().min(1).max(CRYS_TRACE_POINTER_MAX))
         .default([]),
     evaluator_summary: z
         .string()
         .trim()
-        .max(4000)
+        .max(CRYS_BRIEF_SECTION_MAX)
         .default(""),
     user_decision_summary: z
         .string()
         .trim()
-        .max(4000)
+        .max(CRYS_BRIEF_SECTION_MAX)
         .default(""),
     created_loop_release_id: OptionalLoopId,
     updated_loop_release_id: OptionalLoopId,
@@ -195,7 +207,7 @@ export const CrystallizationEventSchema = CrystallizationEventInputSchema.extend
     id: z
         .string()
         .min(1)
-        .max(128)
+        .max(CRYS_EVENT_ID_MAX)
         .regex(/^crys-[0-9a-f]{8,}$/, {
         message: "id must start with 'crys-' followed by a hex suffix (spec §4.5)",
     }),

package/dist/services/crystallization/evidence-brief-builder.js

@@ -1,5 +1,16 @@
 import { z } from "zod";
 import { EvidenceBriefSchema, } from "./crystallization-types.js";
+/* ---------------------------------------------------------------------- */
+/* PRD-002b slice 2 — schema-limit constants extracted from inline         */
+/* `.max(N)` calls so the no-magic-numbers rule stops flagging the        */
+/* constraint values. Bytewise-identical to the original literals.       */
+/* ---------------------------------------------------------------------- */
+const BRIEF_TRACE_ID_MAX = 256;
+const BRIEF_SECTION_TEXT_MAX = 4000;
+const BRIEF_BULLET_MAX = 1000;
+const BRIEF_TRACE_POINTER_MAX = 256;
+const BRIEF_EVALUATOR_ONE_LINER_MAX = 1000;
+const BRIEF_EVALUATOR_RISK_TAG_MAX = 200;
 /**
  * EvidenceBriefBuilder — spec §4.7 / §10 RL-7.
  *
@@ -45,40 +56,40 @@ import { EvidenceBriefSchema, } from "./crystallization-types.js";
  * editing every caller.
  */
 export const BriefTraceInputSchema = z.object({
-    trace_id: z.string().trim().min(1).max(256),
+    trace_id: z.string().trim().min(1).max(BRIEF_TRACE_ID_MAX),
     /**
      * The full NL recap of the run. Required for what_happened.
      * 1-2 sentences is the spec guidance; the builder does not
      * truncate, but tests passing multi-paragraph input will be
      * warned at the Zod boundary (max 4000 chars per section).
      */
-    what_happened: z.string().trim().min(1).max(4000),
+    what_happened: z.string().trim().min(1).max(BRIEF_SECTION_TEXT_MAX),
     /**
      * The "why this matters" recap. Required for why_it_matters.
      */
-    why_it_matters: z.string().trim().min(1).max(4000),
+    why_it_matters: z.string().trim().min(1).max(BRIEF_SECTION_TEXT_MAX),
     /**
      * Failure-mode and preference-extraction recap. Required for
      * what_learned.
      */
-    what_learned: z.string().trim().min(1).max(4000),
+    what_learned: z.string().trim().min(1).max(BRIEF_SECTION_TEXT_MAX),
     /**
      * The recommended action. Required for what_action (1
      * sentence per spec).
      */
-    what_action: z.string().trim().min(1).max(4000),
+    what_action: z.string().trim().min(1).max(BRIEF_SECTION_TEXT_MAX),
     /**
      * Optional structured bullets (e.g. "4 phases, 3 gates passed,
      * 1 evaluator verdict"). Counts are allowed at this layer; the
      * brief section is the NL primary (RL-7).
      */
-    bullets: z.array(z.string().trim().min(1).max(1000)).default([]),
+    bullets: z.array(z.string().trim().min(1).max(BRIEF_BULLET_MAX)).default([]),
     /**
      * Source trace ids backing the brief (the column on
      * crystallization_event spec §4.5).
      */
     source_trace_pointers: z
-        .array(z.string().trim().min(1).max(256))
+        .array(z.string().trim().min(1).max(BRIEF_TRACE_POINTER_MAX))
         .default([]),
 });
 /**
@@ -88,17 +99,17 @@ export const BriefTraceInputSchema = z.object({
  * flows into the recommendation envelope.
  */
 export const EvaluatorSummarySchema = z.object({
-    one_liner: z.string().trim().max(1000).default(""),
-    risk_tags: z.array(z.string().trim().min(1).max(200)).default([]),
+    one_liner: z.string().trim().max(BRIEF_EVALUATOR_ONE_LINER_MAX).default(""),
+    risk_tags: z.array(z.string().trim().min(1).max(BRIEF_EVALUATOR_RISK_TAG_MAX)).default([]),
 });
 /* ---------------------------------------------------------------------- */
 /* Recommendation envelope — the CLI renders this.                       */
 /* ---------------------------------------------------------------------- */
 export const RecommendationPayloadSchema = z.object({
     brief: EvidenceBriefSchema,
-    bullets: z.array(z.string().trim().min(1).max(1000)).default([]),
+    bullets: z.array(z.string().trim().min(1).max(BRIEF_BULLET_MAX)).default([]),
     source_trace_pointers: z
-        .array(z.string().trim().min(1).max(256))
+        .array(z.string().trim().min(1).max(BRIEF_TRACE_POINTER_MAX))
         .default([]),
     evaluator_summary: EvaluatorSummarySchema.default({
         one_liner: "",