peachsim 0.1.527 → 0.1.571

package/cli/commands/inspect/core.ts

@@ -15,6 +15,7 @@ import {
   HEADLESS_TENANT_FETCH_HUNG_MARKER,
   PUBLIC_NO_NETWORK_MARKER,
   type SemanticWaitResult,
+  type WsBridgeCommand,
 } from '../../../src/bridge-contract'
 export {
   readyProbeHasContent,
@@ -33,8 +34,8 @@ import type {
   SootSimTimelineQuery,
   SootSimTimelineQueryResult,
   SootSimTimelineSummary,
-} from '@rnx/globals'
-import type { KeyboardLayoutSnapshot } from 'sootsim-engine/render-worker/native-ui-protocol'
+} from '@peach/globals'
+import type { KeyboardLayoutSnapshot } from 'peach-engine/render-worker/native-ui-protocol'
 
 // resolve a `--max-ms <n>` flag, tolerating the spellings agents and humans
 // actually type (`--maxMs`, `--maxms`, `--max_ms`). a silently-ignored
@@ -56,10 +57,7 @@ export function resolveMaxMsFlag(args: string[], fallbackMs: number): number {
 // rnx instance.
 export interface InspectBridge {
   readonly plane?: 'local' | 'cloud'
-  send(
-    cmd: { type: string; [k: string]: any },
-    opts?: { timeoutMs?: number },
-  ): Promise<any>
+  send(cmd: WsBridgeCommand, opts?: { timeoutMs?: number }): Promise<any>
 }
 
 const INSPECT_PICK_COMMANDS = new Set([
@@ -1151,13 +1149,14 @@ export async function inspectWaitSelector(
   opts: { gone?: boolean; structural?: boolean } = {},
 ): Promise<{ found: boolean; node?: SimSemanticNode; elapsed: number }> {
   const gone = opts.gone === true
+  const cleanId = testId.replace(/^#/, '')
   const result: SemanticWaitResult = await bridge.send(
     {
       type: 'waitFor',
       waitForOptions: {
         condition: {
           type: gone ? 'absent' : opts.structural === true ? 'mounted' : 'present',
-          selector: { testID: testId },
+          selector: { testID: cleanId },
         },
         timeoutMs,
       },

package/cli/commands/inspect/find.ts

@@ -23,7 +23,8 @@ export async function runFindSubcommand(opts: {
   }
   const hasFlag = (name: string): boolean => effectiveArgs.includes(name)
 
-  const testId = findFlag('--testid') || findFlag('--test-id')
+  const rawTestId = findFlag('--testid') || findFlag('--test-id')
+  const testId = rawTestId ? rawTestId.replace(/^#/, '') : null
   const role = findFlag('--role')
   const typeFlag = findFlag('--type')
   const textFlag = findFlag('--text')

package/cli/commands/inspect/resolve-target.ts

@@ -14,14 +14,16 @@ export function readTargetFlag(
   positional?: string[],
 ): { mode: 'testid' | 'text'; value: string } | null {
   const tid = args.indexOf('--testid')
-  if (tid >= 0 && args[tid + 1]) return { mode: 'testid', value: args[tid + 1] }
+  if (tid >= 0 && args[tid + 1])
+    return { mode: 'testid', value: args[tid + 1].replace(/^#/, '') }
   const alt = args.indexOf('--test-id')
-  if (alt >= 0 && args[alt + 1]) return { mode: 'testid', value: args[alt + 1] }
+  if (alt >= 0 && args[alt + 1])
+    return { mode: 'testid', value: args[alt + 1].replace(/^#/, '') }
   const text = args.indexOf('--text')
   if (text >= 0 && args[text + 1]) return { mode: 'text', value: args[text + 1] }
   const bare = positional?.[1]
   if (bare && !bare.startsWith('-') && !Number.isFinite(Number(bare))) {
-    return { mode: 'testid', value: bare }
+    return { mode: 'testid', value: bare.replace(/^#/, '') }
   }
   return null
 }

package/cli/commands/inspect/shared.ts

@@ -12,7 +12,7 @@ import {
   type WsBridge,
 } from '../../ws-bridge'
 import { getShellState, inspectWaitReady, isShellCommandUnavailable } from './core'
-import type { SootSimScreenTransitionWaitResult } from '@rnx/globals'
+import type { SootSimScreenTransitionWaitResult } from '@peach/globals'
 
 // shell-state helpers live in the transport-agnostic kernel module so the CLI
 // and the in-browser agent share one implementation. re-exported here so

package/cli/commands/inspect/wait-event.ts

@@ -26,7 +26,7 @@ import type {
   SootSimTimelineEvent,
   SootSimTimelineQuery,
   SootSimTimelineQueryResult,
-} from '@rnx/globals'
+} from '@peach/globals'
 
 interface WaitEventOptions {
   bridge: WsBridge

package/cli/commands/inspect/wait-selector.ts

@@ -16,16 +16,27 @@ export async function runWaitSelectorSubcommand(opts: {
   inspectUsage: (name: string, tail: string) => string
 }): Promise<void> {
   const { bridge, args, positional, inspectUsage } = opts
-  const testId = positional[1]
-  if (!testId) {
+  const rawTestId = positional[1]
+  if (!rawTestId) {
     console.error(
-      inspectUsage('selector', '<testid> [--max-ms 5000] [--gone] [--structural]'),
+      inspectUsage(
+        'selector',
+        '<testid> [--max-ms 5000 | --timeout 5000] [--gone] [--structural]',
+      ),
     )
     rnxExit(1)
   }
+  const testId = rawTestId.replace(/^#/, '')
+  // the wait budget. `--max-ms` names it, and `--timeout` (the global
+  // per-command budget) means the same thing for a command whose whole job is
+  // to wait — without this it parsed away and the wait silently stayed at 5s,
+  // reporting a false timeout.
   const maxMsIdx = args.indexOf('--max-ms')
+  const budgetIdx = maxMsIdx >= 0 ? maxMsIdx : args.indexOf('--timeout')
   const timeoutMs =
-    maxMsIdx >= 0 && args[maxMsIdx + 1] ? Math.max(100, Number(args[maxMsIdx + 1])) : 5000
+    budgetIdx >= 0 && args[budgetIdx + 1]
+      ? Math.max(100, Number(args[budgetIdx + 1]))
+      : 5000
   const gone = args.includes('--gone')
   const structural = args.includes('--structural')
 

package/cli/commands/inspect.ts

@@ -1,8 +1,8 @@
 // rnx inspect — dump node tree, accessibility info, query nodes
 // connects to the rnx WS bridge (no Playwright)
 
-import { getCliInspectVerbMeta } from '@rnx/skills/cli'
-import { renderCliCommandHelp, renderCliGroupHelp } from '@rnx/skills/cli/renderers'
+import { getCliInspectVerbMeta } from '@peach/skills/cli'
+import { renderCliCommandHelp, renderCliGroupHelp } from '@peach/skills/cli/renderers'
 import { DEFAULT_SOOTSIM_BRIDGE_PORT } from '../../src/bridge-constants'
 import { DEFAULT_SOOTSIM_SHELL_URL } from '../../src/cli-constants'
 import { resetGuestAppStateEval } from '../app-state-reset'
@@ -103,10 +103,11 @@ import { runWaitSelectorSubcommand } from './inspect/wait-selector'
 import { printMissingSimHint, printUnknownSimHint } from './no-bridge-hint'
 import type { PerformResult, PerformStep } from '../../src/bridge-contract'
 import type {
+  SootSimReplayTarget,
   SootSimRequestEntry,
   SootSimScreenTransitionWaitResult,
   SootSimScrollPerformanceTrace,
-} from '@rnx/globals'
+} from '@peach/globals'
 
 interface InspectOptions extends BridgeTransportOption {
   port?: number
@@ -116,7 +117,7 @@ interface InspectOptions extends BridgeTransportOption {
 }
 
 // shape of entries in the shared observability store — mirrors
-// packages/sootsim-engine/src/observability/types.ts NetworkEntry. duplicated
+// packages/peach-engine/src/observability/types.ts NetworkEntry. duplicated
 // here so this command doesn't cross-import from engine internals.
 interface NetworkEntryPayload {
   id: string
@@ -1145,7 +1146,7 @@ export async function runInspect(args: string[], opts: InspectOptions) {
     `  usage: ${inspectCommand(name)}${tail ? ` ${tail}` : ''}`
 
   if (!subcommand || args.includes('--help') || args.includes('-h')) {
-    // all help output comes from the registry in packages/rnx-skills
+    // all help output comes from the registry in packages/peach-skills
     // so `rnx do --help`, `rnx get --help`, the website docs, and
     // the Contrast skill markdown stay in lock-step. a drift check in
     // test/sootsimCliRegistry.test.ts fails CI if a verb lands without a
@@ -2615,7 +2616,7 @@ export async function runInspect(args: string[], opts: InspectOptions) {
             ? keyboardState.focusedInput.text
             : ''
         for (let i = 0; i < existingText.length; i++) {
-          await bridge.send({ type: 'keyboard', action: 'press', key: 'delete' })
+          await bridge.send({ type: 'keyboard', action: 'press', text: 'delete' })
         }
         await bridge.send({ type: 'keyboard', action: 'type', text })
         const secureTextEntry =
@@ -2742,8 +2743,12 @@ export async function runInspect(args: string[], opts: InspectOptions) {
           console.error(inspectUsage('keycode', '<code> [<code> ...]'))
           rnxExit(1)
         }
-        const keys = codes.map((code) => ({ code, key: keyCodeToVisualKey(code) }))
-        const unsupported = keys.filter((entry) => !entry.key)
+        const mapped = codes.map((code) => ({ code, key: keyCodeToVisualKey(code) }))
+        const unsupported = mapped.filter((entry) => !entry.key)
+        const keys = mapped.filter(
+          (entry): entry is { code: string; key: string } =>
+            typeof entry.key === 'string',
+        )
         if (unsupported.length > 0) {
           console.error(
             `  unsupported keycode(s): ${unsupported.map((entry) => entry.code).join(', ')}`,
@@ -2836,11 +2841,7 @@ export async function runInspect(args: string[], opts: InspectOptions) {
         let x = Number(positional[1])
         let y = Number(positional[2])
         const target = readTargetFlag(args, positional)
-        let resolvedTarget: {
-          testID?: string | null
-          text?: string | null
-          type?: string | null
-        } | null = null
+        let resolvedTarget: SootSimReplayTarget | undefined
         if (target) {
           const resolved = await resolveTargetCoords(bridge, target)
           if (!resolved) {
@@ -3896,6 +3897,7 @@ export async function runInspect(args: string[], opts: InspectOptions) {
 
   options:
     --limit <n>  maximum samples retained per layer (default 6000)
+    --press-testid <id>  trace pointer → tree → paint for one target
     --json       emit every per-frame sample on stop
 
   examples:
@@ -3915,12 +3917,15 @@ export async function runInspect(args: string[], opts: InspectOptions) {
               console.error('  error: --limit must be a number of at least 120')
               rnxExit(1)
             }
+            const pressTestID = effectiveArgs.find(
+              (_, index) => effectiveArgs[index - 1] === '--press-testid',
+            )
             const result = await bridge.send({
               type: 'evaluate',
               code: `(async () => {
                 const perf = window.SootSim?.bridges?.scrollPerf
                 if (!perf) return { error: 'scroll performance profile unavailable' }
-                await perf.start(${Math.floor(parsedLimit)})
+                await perf.start(${Math.floor(parsedLimit)}, ${JSON.stringify(pressTestID)})
                 return { started: true }
               })()`,
             })