peachsim 0.1.1619 → 0.1.1625

package/cli/drivers/playwright-sim-host.ts

@@ -1,4 +1,3 @@
-import { createBrowserPageTargetReader } from '../../../peach-engine/src/browser-page-target'
 import {
   acquireChromiumAdmission,
   readChromiumQueue,
@@ -21,6 +20,7 @@ import {
   chromeDisabledFeaturesSwitch,
   softwareChromeLaunchOptions,
 } from '../../../../scripts/lib/reap-browser'
+import { createBrowserPageTargetReader } from '../../../peach-engine/src/browser-page-target'
 import {
   readBrowserCompositeCaptureRequest,
   resolveBrowserCompositeCdpClip,
@@ -37,6 +37,7 @@ import {
   webViewAutomationHelpersSource,
 } from '../../../peach-engine/src/webview-automation-host'
 import { DISPOSABLE_BROWSER_CACHE_DIR_NAMES } from '../../src/browser-cache'
+import { listProcessChildren } from '../../src/process-group'
 
 // a person's tap on the device canvas is a trusted input, which gives the page
 // the user activation browsers require before media plays with sound, and an
@@ -113,8 +114,9 @@ const completionFile = process.env.PEACH_PW_COMPLETION_FILE || '';
 const disposableBrowserCacheDirs = new Set(${JSON.stringify(
   DISPOSABLE_BROWSER_CACHE_DIR_NAMES,
 )});
-const { existsSync, mkdtempSync, readdirSync, rmSync, unlinkSync, writeFileSync } = require('fs');
-const { execSync, spawn } = require('child_process');
+const { existsSync, mkdtempSync, readdirSync, readFileSync, rmSync, unlinkSync, writeFileSync } = require('fs');
+const { execSync, spawn, spawnSync } = require('child_process');
+const listProcessChildren = ${listProcessChildren.toString()};
 const { tmpdir } = require('os');
 const { join } = require('path');
 const createBrowserPointerDispatcher = ${createBrowserPointerDispatcher.toString()};
@@ -193,10 +195,9 @@ const assertNoUnsafeSwiftShaderFlag = () => {
 const killTree = (pid) => {
   let kids = [];
   try {
-    kids = execSync('pgrep -P ' + pid + ' || true', { stdio: ['ignore', 'pipe', 'ignore'] })
-      .toString().split('\\n').filter(Boolean);
+    kids = listProcessChildren([pid]);
   } catch {}
-  for (const k of kids) killTree(Number(k));
+  for (const k of kids) killTree(k);
   try { process.kill(pid, 'SIGKILL'); } catch {}
 };
 const reapChrome = () => { for (const pid of chromePidsByProfile()) killTree(pid); };
@@ -213,6 +214,16 @@ const removeDisposableCaches = (root) => {
     removeDisposableCaches(childPath);
   }
 };
+// chrome treats a SingletonLock whose recorded hostname differs from the
+// current one as held by another machine, and macOS renames the host with the
+// network, so a lock left by a killed host blocks every relaunch of a named
+// profile. no process runs this profile here, so its lock files are stale.
+const clearStaleSingletonLock = () => {
+  if (chromePidsByProfile().length > 0) return;
+  for (const name of ['SingletonLock', 'SingletonSocket', 'SingletonCookie']) {
+    try { rmSync(join(profileDir, name), { force: true }); } catch {}
+  }
+};
 const cleanupProfile = () => {
   try { rmSync(diskCacheDir, { recursive: true, force: true }); } catch {}
   if (ephemeralProfile) {
@@ -538,6 +549,7 @@ const cleanupProfile = () => {
     label: 'peach sim host ' + profileDir,
     readQueue: readChromiumQueue,
   });
+  clearStaleSingletonLock();
   let launchErr = null;
   let launchedChannel = null;
   for (const channel of channelsToTry) {

package/cli/maestro-accessibility.ts

@@ -0,0 +1,53 @@
+import type { PeachAccessibilityNode } from '@peach/globals'
+
+// maestro reads ios frames as integer edges (AXElement.boundsString).
+export function accessibilityBounds(node: PeachAccessibilityNode): {
+  x: number
+  y: number
+  width: number
+  height: number
+} {
+  const left = Math.trunc(node.frame.x)
+  const top = Math.trunc(node.frame.y)
+  return {
+    x: left,
+    y: top,
+    width: Math.trunc(node.frame.x + node.frame.width) - left,
+    height: Math.trunc(node.frame.y + node.frame.height) - top,
+  }
+}
+
+// upstream Filters.containsChild compares the resolved child TreeNode against
+// a candidate's immediate children by structural equality: the native
+// attribute map, the boolean flags, and the children, recursively. the native
+// hintText attribute is the placeholder (accessibilityHint is not a TreeNode
+// attribute), and engine identity (elementId/nodeId) plus the projection's own
+// metadata (type, role, isAccessibilityElement, state) are not part of that
+// native shape.
+// bounds is explicit so serialized page evaluation survives cli minification.
+export function sameNativeAccessibilityShape(
+  a: PeachAccessibilityNode,
+  b: PeachAccessibilityNode,
+  bounds: typeof accessibilityBounds,
+): boolean {
+  if (
+    (a.testID ?? '') !== (b.testID ?? '') ||
+    (a.label ?? '') !== (b.label ?? '') ||
+    (a.placeholder ?? '') !== (b.placeholder ?? '') ||
+    (a.value ?? '') !== (b.value ?? '') ||
+    a.enabled !== b.enabled ||
+    a.selected !== b.selected ||
+    a.checked !== b.checked ||
+    a.clickable !== b.clickable ||
+    (a.hasFocus ?? false) !== (b.hasFocus ?? false) ||
+    JSON.stringify(bounds(a)) !== JSON.stringify(bounds(b)) ||
+    a.children.length !== b.children.length
+  ) {
+    return false
+  }
+  for (const [index, child] of a.children.entries()) {
+    const other = b.children[index]
+    if (!other || !sameNativeAccessibilityShape(child, other, bounds)) return false
+  }
+  return true
+}

package/cli/maestro-compare.ts

@@ -455,6 +455,30 @@ export interface CompareSide {
   errors: string[]
 }
 
+// flow verdicts own status; diagnostics do not reject a pass.
+export function buildCompareSide(
+  steps: CompareStep[],
+  outcome: CompareSide['status'],
+  extraErrors: string[],
+  runFailure?: string,
+): CompareSide {
+  const failed = steps.find((step) => step.status === 'failed')
+  const executed = steps.some((step) => step.status !== 'skipped')
+  const errors = [
+    ...(failed ? [`step "${failed.label}" failed: ${failed.error ?? 'no message'}`] : []),
+    ...(runFailure ? [runFailure] : []),
+    ...extraErrors,
+    ...(!executed && outcome !== 'not run' ? ['flow executed no steps'] : []),
+  ]
+  return {
+    status:
+      outcome === 'passed' && (failed || runFailure || !executed) ? 'failed' : outcome,
+    durationMs: steps.reduce((sum, step) => sum + step.durationMs, 0),
+    steps,
+    errors,
+  }
+}
+
 export interface CompareScreen {
   name: string
   step: number

package/cli/outbound-endpoints.ts

@@ -147,7 +147,8 @@ export const OUTBOUND_ENDPOINTS: Record<string, OutboundEndpointDeclaration> = {
   },
   remote_display_server: {
     category: 'explicit-user-action',
-    destination: 'display-server WebSocket URL configured by the embedding host',
+    destination:
+      'display-server WebSocket URL, or scene recording URL, configured by the embedding host',
     preConsent: true,
     payload:
       'display protocol identity, local input events, scroll lifecycle, resync requests, and applied/painted acknowledgements',
@@ -159,13 +160,11 @@ export const OUTBOUND_ENDPOINTS: Record<string, OutboundEndpointDeclaration> = {
     payload: 'preview objects selected by the user for upload',
   },
   // its own entry, deliberately not folded into contrast_user_action. this is
-  // the only egress that sends the CONTENTS of the user's project somewhere,
-  // and to an operator-chosen host rather than a Contrast one, so it must not
-  // be readable as "the usual Contrast call".
+  // the egress that sends the contents of the user's project to a cloud host.
   peach_cloud_box: {
     category: 'explicit-user-action',
     destination:
-      'the Peach Cloud box service named by --endpoint or PEACH_BOX_ENDPOINT; no default, so this call cannot happen unless the user names a host',
+      'the deployed Peach Cloud box service by default, overridden by --endpoint or PEACH_BOX_ENDPOINT',
     preConsent: false,
     payload:
       'every file git reports for the current checkout, then shell commands and file reads and writes for as long as the box shell is open',
@@ -252,6 +251,10 @@ export interface OutboundCallDeclaration {
 // a new fetch, websocket, node HTTP request, or TCP connection has no entry and
 // fails scripts/check/outbound-endpoints.ts until its destination and consent behavior are declared.
 export const DECLARED_OUTBOUND_CALLS: Record<string, OutboundCallDeclaration> = {
+  'packages/peach-engine/src/launch-metadata.ts :: fetch :: reference': {
+    category: 'local_development',
+    count: 1,
+  },
   'packages/peach-engine/src/engine/barcode-reader.worker.ts :: fetch :: wasmUrl': {
     category: 'same_origin_runtime',
     count: 1,
@@ -275,13 +278,17 @@ export const DECLARED_OUTBOUND_CALLS: Record<string, OutboundCallDeclaration> =
   // driving a box sends each command to its own box.
   'packages/peachsim/cli/cloud-client.ts :: fetch :: `${this.session.apiOrigin}/v1/boxes/${encodeURIComponent()}/commands`':
     { category: 'peach_cloud_sim', count: 1 },
-  // stopping a box leaves it allocated, unlike the delete above.
-  'packages/peachsim/cli/cloud-client.ts :: fetch :: `${session.apiOrigin}/v1/boxes/${encodeURIComponent()}/stop`':
+  // closing a remote simulator deletes its box with the account's authority.
+  'packages/peachsim/cli/cloud-client.ts :: fetch :: `${session.apiOrigin}/v1/boxes/${encodeURIComponent()}/delete`':
     { category: 'peach_cloud_sim', count: 1 },
   // the display grant is polled until the box hands one back; the body is
   // empty, so the request carries no project or app data.
   'packages/peachsim/cli/cloud-client.ts :: fetch :: `${options.apiOrigin}/v1/boxes/${encodeURIComponent()}/display-grant`':
     { category: 'peach_cloud_sim', count: 1 },
+  // a fresh box's boot receipts are read until its page loads or reports an
+  // error; the request carries no body.
+  'packages/peachsim/cli/cloud-client.ts :: fetch :: `${options.apiOrigin}/v1/boxes/${encodeURIComponent()}/lifecycle`':
+    { category: 'peach_cloud_sim', count: 1 },
   // `peach remote` creates through the instance api and lists what it made.
   // the create carries labels and wait=true in the query; the list filters
   // by the remote label.
@@ -379,6 +386,8 @@ export const DECLARED_OUTBOUND_CALLS: Record<string, OutboundCallDeclaration> =
   'packages/peach-cloud-box/src/browser-run.ts :: fetch :: `https://browser.invalid/v1/devtools/browser/${sessionId}`':
     { category: 'peach_cloud_box', count: 2 },
   // list the account sessions a cloud box is billed against. no project content.
+  "packages/peachsim/cli/remote-simulators.ts :: fetch :: `${account.apiOrigin.replace(/\\/+$/, '')}/api/v1/rnx/sessions?${query}`":
+    { category: 'contrast_user_action', count: 1 },
   "packages/peach-cloud-box/src/client.ts :: fetch :: `${options.apiOrigin.replace(/\\/+$/, '')}/api/v1/rnx/sessions?${search}`":
     { category: 'contrast_user_action', count: 1 },
   // `peach box connect` asks the account service which box that ID or name is
@@ -525,6 +534,8 @@ export const DECLARED_OUTBOUND_CALLS: Record<string, OutboundCallDeclaration> =
   },
   'packages/peach-engine/src/mcp/ws-bridge.ts :: websocket :: resolveSootsimBridgeWebSocketUrl({ bridgePort, href: window.location.href, })':
     { category: 'local_development', count: 1 },
+  'packages/peach-engine/src/remote-stream/browser-tenant-proxy.ts :: fetch :: this.config.url':
+    { category: 'remote_display_server', count: 1 },
   'packages/peach-engine/src/remote-stream/browser-tenant-proxy.ts :: websocket :: this.config.url':
     { category: 'remote_display_server', count: 1 },
   'packages/peach-engine/src/menu/menuActions.ts :: fetch :: screenshot': {
@@ -612,6 +623,10 @@ export const DECLARED_OUTBOUND_CALLS: Record<string, OutboundCallDeclaration> =
     category: 'guest_app_network',
     count: 1,
   },
+  'packages/peach-engine/src/render-worker/map-host.ts :: fetch-alias :: request.url': {
+    category: 'guest_app_network',
+    count: 1,
+  },
   'packages/peach-engine/src/render-worker/map-host.ts :: fetch-alias :: url': {
     category: 'map_style_delivery',
     count: 1,
@@ -764,6 +779,8 @@ export const DECLARED_OUTBOUND_CALLS: Record<string, OutboundCallDeclaration> =
     category: 'local_development',
     count: 1,
   },
+  'packages/peach-engine/src/components/native-ui/ShareSheetView.tsx :: fetch-alias :: `/__fetch-proxy?url=${encodeURIComponent()}`':
+    { category: 'guest_app_network', count: 1 },
   'packages/peachsim/src/dev-bundle-resolution.ts :: fetch :: `/__fetch-proxy?url=${encodeURIComponent()}`':
     { category: 'guest_app_network', count: 1 },
   'packages/peachsim/src/dev-bundle-resolution.ts :: fetch :: targetUrl': {
@@ -1079,7 +1096,9 @@ function callKind(
   source: string,
 ): string | null {
   if (node.type === 'NewExpression' && node.callee.type === 'Identifier') {
-    if (node.callee.name === 'WebSocket') return 'websocket'
+    if (node.callee.name === 'WebSocket' || node.callee.name === 'NativeWebSocket') {
+      return 'websocket'
+    }
     if (node.callee.name === 'EventSource') return 'event-source'
     if (node.callee.name === 'XMLHttpRequest') return 'xml-http-request'
     return null

package/cli/parent-pid.ts

@@ -68,15 +68,6 @@ function buildComm(): CommLookup {
 }
 
 function build(): Lookup {
-  // on any platform, if the shell exports $PPID and it differs from the
-  // node-level process.ppid, it's the shell's own parent — one level up
-  // from where we need to be. this is the cheapest and most portable
-  // grand-ppid source since it needs no subprocess or FFI.
-  const envPpid = Number(process.env.PPID)
-  if (Number.isFinite(envPpid) && envPpid > 1 && envPpid !== process.ppid) {
-    return () => envPpid
-  }
-
   if (process.platform === 'linux') return buildLinux()
   if (process.platform === 'darwin') {
     // on Bun: libproc via FFI is ~0.8µs/call. on Node: one `ps` snapshot of

package/cli/remote-simulators.ts

@@ -0,0 +1,112 @@
+import {
+  cloudBoxConnectUrl,
+  deleteCloudBox,
+  resolveCloudBoxReference,
+} from 'peach-cloud-box/client'
+import { isRecord } from '../src/is-record'
+import { deleteRemoteSim, listRemoteSims } from './cloud-client'
+import type {
+  AccountRemoteSimulator,
+  HostedRemoteSimulator,
+  RemoteSimulatorAccount,
+} from './remoteSimulatorContract'
+
+// the account's meter is the existing index of hosted simulators. shell-only
+// boxes have no simulator session and do not belong in this list.
+async function listHostedSimulators(
+  account: RemoteSimulatorAccount,
+): Promise<HostedRemoteSimulator[]> {
+  const query = new URLSearchParams({ kind: 'sim', status: 'running' })
+  if (account.accountId) query.set('accountId', account.accountId)
+  const response = await fetch(
+    `${account.apiOrigin.replace(/\/+$/, '')}/api/v1/rnx/sessions?${query}`,
+    {
+      headers: { authorization: account.authorization },
+      signal: AbortSignal.timeout(30_000),
+    },
+  )
+  if (!response.ok) {
+    throw new Error(`hosted simulator list ${response.status}: ${await response.text()}`)
+  }
+  const parsed: unknown = await response.json()
+  if (!isRecord(parsed) || !Array.isArray(parsed.sessions)) {
+    throw new Error('hosted simulator list returned invalid JSON')
+  }
+  const sims: HostedRemoteSimulator[] = []
+  for (const session of parsed.sessions) {
+    if (!isRecord(session))
+      throw new Error('hosted simulator list returned an invalid session')
+    if (
+      session.kind !== 'sim' ||
+      session.size !== 'micro' ||
+      session.status !== 'running'
+    )
+      continue
+    if (
+      typeof session.boxId !== 'string' ||
+      !session.boxId ||
+      (session.name !== null && typeof session.name !== 'string') ||
+      (session.device !== null && typeof session.device !== 'string') ||
+      typeof session.startedAt !== 'number' ||
+      !Number.isFinite(session.startedAt) ||
+      typeof session.meteredMs !== 'number' ||
+      !Number.isFinite(session.meteredMs)
+    ) {
+      throw new Error('hosted simulator list returned an invalid simulator')
+    }
+    sims.push({
+      service: 'box',
+      simId: session.boxId,
+      name: session.name,
+      status: 'running',
+      device: session.device,
+      startedAt: session.startedAt,
+      meteredMs: session.meteredMs,
+    })
+  }
+  return sims
+}
+
+export async function listAccountRemoteSimulators(
+  account: RemoteSimulatorAccount,
+): Promise<AccountRemoteSimulator[]> {
+  const [hosted, nano] = await Promise.all([
+    listHostedSimulators(account),
+    listRemoteSims({
+      authorization: account.authorization,
+      accountId: account.accountId,
+    }),
+  ])
+  return [
+    ...hosted,
+    ...nano.map((sim): AccountRemoteSimulator => ({ ...sim, service: 'sim' })),
+  ]
+}
+
+export async function stopAccountRemoteSimulator(
+  account: RemoteSimulatorAccount,
+  simId: string,
+): Promise<{ simId: string } | null> {
+  const hosted = await listHostedSimulators(account)
+  const sim = hosted.find((candidate) => candidate.simId === simId)
+  if (!sim)
+    return deleteRemoteSim({
+      authorization: account.authorization,
+      accountId: account.accountId,
+      simId,
+    })
+
+  // resolve through the account service before addressing a host. another
+  // account's id must never turn into a provider request with this key.
+  const reference = await resolveCloudBoxReference({
+    apiOrigin: account.apiOrigin,
+    apiKey: account.authorization.replace(/^Bearer /, ''),
+    accountId: account.accountId,
+    boxId: sim.simId,
+  })
+  await deleteCloudBox({
+    connectUrl: cloudBoxConnectUrl(reference.endpoint, reference.boxId),
+    accessToken: account.authorization.replace(/^Bearer /, ''),
+  })
+  return { simId: sim.simId }
+}

package/cli/remoteSimulatorContract.ts

@@ -0,0 +1,21 @@
+import type { RnxCloudSimView } from '../src/cloud-contract'
+
+export interface HostedRemoteSimulator {
+  service: 'box'
+  simId: string
+  name: string | null
+  status: 'running'
+  device: string | null
+  startedAt: number
+  meteredMs: number
+}
+
+export type AccountRemoteSimulator =
+  | (RnxCloudSimView & { service: 'sim' })
+  | HostedRemoteSimulator
+
+export interface RemoteSimulatorAccount {
+  apiOrigin: string
+  authorization: string
+  accountId: string | null
+}

package/detox/expectations.ts

@@ -3,6 +3,7 @@
 // waitFor(element).toExist().withTimeout(ms)
 
 import { dragScrollNode } from './gestures'
+import { getSootsimNavigationDiagnostics } from './navigation-lifecycle'
 import type { SootSimElement } from './element-types'
 import type { Matcher } from './matchers'
 import type { SootSimFocusedNodeInfo, SootSimNodeInfo } from '@peach/globals'
@@ -349,7 +350,10 @@ class SootSimWaitForChain {
       const node = await this.findNode(this.matcher)
       const exists = node !== null && node !== undefined
       if (this._negated ? exists : !exists) {
-        throw new Error(`waitFor toExist failed: ${JSON.stringify(this.matcher)}`)
+        // a guest that never mounts leaves its console and page errors only here
+        throw new Error(
+          `waitFor toExist failed: ${JSON.stringify(this.matcher)}\nrecent page diagnostics:\n${JSON.stringify(getSootsimNavigationDiagnostics(this.getPage()))}`,
+        )
       }
     }
     return new SootSimWaitForAction(this.assertionFn, this.findNode, this.getPage)