pcm-shared-components 2.1.402 → 2.1.403

package/dist/components/Reservation/AnimalVehicleDetailsEditor/index.js

@@ -213,11 +213,20 @@ export const AnimalVehicleDetailsEditor = props => {
   //
   // Re-runs whenever the wrapped set itself changes (not just when `fieldConfig` changes), because
   // promoting one field to full width re-pairs its neighbors, which can occasionally make a
-  // DIFFERENT field's label newly wrap (or stop wrapping) at its new column width. Safe from an
-  // infinite loop: promotions only ever add width, never remove it, so this converges in at most a
-  // few passes, and the state setter bails out (no re-render) the moment a pass finds no change.
+  // DIFFERENT field's label newly wrap at its new column width.
+  //
+  // Promotions must be a ONE-WAY RATCHET (seed from `prev`, only ever add) rather than recomputed
+  // from scratch each pass. A field promoted to full width almost always stops wrapping there --
+  // it just got 2x the space -- so measuring fresh every time would immediately demote it again,
+  // which shrinks it back to half width, which makes it wrap again, which re-promotes it... an
+  // infinite loop that used to hang the whole editor (every field whose label happened to wrap at
+  // half width but fit at full width triggered this on mount). Only dropping keys that are no
+  // longer in `fieldConfig` at all keeps a stale promotion from leaking across an entirely
+  // different field set. The state setter still bails out (no re-render) the moment a pass finds
+  // no change, so this converges in at most `fieldConfig.length` passes.
   useLayoutEffect(() => {
-    const nextWrapped = new Set();
+    const liveKeys = new Set(fieldConfig.map(f => f.key));
+    const nextWrapped = new Set([...wrappedKeys].filter(k => liveKeys.has(k)));
     labelRefs.current.forEach((el, fieldKey) => {
       if (!el) return;
       const lineHeight = parseFloat(getComputedStyle(el).lineHeight) || 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pcm-shared-components",
-  "version": "2.1.402",
+  "version": "2.1.403",
   "private": false,
   "main": "dist/index.js",
   "babel": {