payment-kit 1.13.200 → 1.13.201

package/api/src/routes/subscriptions.ts

@@ -681,18 +681,17 @@ router.put('/:id', authPortal, async (req, res) => {
     }
 
     // handle subscription item changes
-    let invoice: Invoice;
     let connectAction = '';
-    if (subscription.isActive() === false) {
-      throw new Error('Subscription is not active');
-    }
-    if (subscription.isScheduledToCancel()) {
-      throw new Error('Subscription is scheduled to cancel');
-    }
-
     if (Array.isArray(value.items) && value.items.length > 0) {
+      if (subscription.isActive() === false) {
+        throw new Error('Updating subscription item not allowed for inactive subscriptions');
+      }
+      if (subscription.isScheduledToCancel()) {
+        throw new Error('Updating subscription item not allowed for scheduled-to-cancel subscriptions');
+      }
+
       if (paymentMethod.type === 'stripe') {
-        throw new Error('Update is not supported for subscriptions paid with stripe');
+        throw new Error('Updating subscription item not allowed for subscriptions paid with stripe');
       }
 
       // validate the request
@@ -773,7 +772,7 @@ router.put('/:id', authPortal, async (req, res) => {
             footer: lastInvoice.footer || '',
           } as Invoice,
         });
-        invoice = result.invoice;
+        const { invoice } = result;
         updates.latest_invoice_id = invoice.id;
         logger.info('subscription update invoice created', { subscription: req.params.id, invoice: invoice.id });
 
@@ -869,6 +868,13 @@ router.put('/:id', authPortal, async (req, res) => {
         }
       }
     } else if (req.body.billing_cycle_anchor === 'now') {
+      if (subscription.isActive() === false) {
+        throw new Error('Updating billing_cycle_anchor not allowed for inactive subscriptions');
+      }
+      if (subscription.isScheduledToCancel()) {
+        throw new Error('Updating billing_cycle_anchor not allowed for scheduled-to-cancel subscriptions');
+      }
+
       // FIXME: handle billing cycle anchor change without any item change
       await subscription.update(updates);
     } else {

package/blocklet.yml

@@ -14,7 +14,7 @@ repository:
   type: git
   url: git+https://github.com/blocklet/payment-kit.git
 specVersion: 1.2.8
-version: 1.13.200
+version: 1.13.201
 logo: logo.png
 files:
   - dist

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "payment-kit",
-  "version": "1.13.200",
+  "version": "1.13.201",
   "scripts": {
     "dev": "cross-env COMPONENT_STORE_URL=https://test.store.blocklet.dev blocklet dev --open",
     "eject": "vite eject",
@@ -50,7 +50,7 @@
     "@arcblock/jwt": "^1.18.113",
     "@arcblock/ux": "^2.9.57",
     "@blocklet/logger": "1.16.24",
-    "@blocklet/payment-react": "1.13.200",
+    "@blocklet/payment-react": "1.13.201",
     "@blocklet/sdk": "1.16.24",
     "@blocklet/ui-react": "^2.9.57",
     "@blocklet/uploader": "^0.0.74",
@@ -110,7 +110,7 @@
   "devDependencies": {
     "@abtnode/types": "1.16.24",
     "@arcblock/eslint-config-ts": "^0.2.4",
-    "@blocklet/payment-types": "1.13.200",
+    "@blocklet/payment-types": "1.13.201",
     "@types/cookie-parser": "^1.4.6",
     "@types/cors": "^2.8.17",
     "@types/dotenv-flow": "^3.3.3",
@@ -149,5 +149,5 @@
       "parser": "typescript"
     }
   },
-  "gitHead": "c57f8e82c4c319183c371393f1bb9891366a36f6"
+  "gitHead": "0f62c0c55a77845cece0656cc6801847b9dc9e24"
 }