payload-plugin-newsletter 0.25.8 → 0.25.9

package/CHANGELOG.md

@@ -1,3 +1,16 @@
+## [0.25.9] - 2025-08-19
+
+### Fixed
+- Fixed providerId/externalId not being saved during broadcast creation
+  - Moved provider creation from create to update operation
+  - Provider broadcast is now created on first update when subject and content are present
+  - Ensures IDs are properly persisted to the database
+  - Prevents issues with Payload's create operation not persisting afterChange modifications
+
+### Changed
+- Broadcasts are now created in Payload first, then synced to provider on first meaningful update
+- More robust approach that works with Payload's hook lifecycle
+
 ## [0.25.8] - 2025-08-19
 
 ### Fixed

package/dist/collections.cjs

@@ -2306,92 +2306,18 @@ var createBroadcastsCollection = (pluginConfig) => {
         async ({ doc, operation, req, previousDoc }) => {
           if (!hasProviders) return doc;
           if (operation === "create") {
-            try {
-              req.payload.logger.info("Broadcast afterChange CREATE hook (sync) - doc info:", {
-                docId: doc.id,
-                docIdType: typeof doc.id,
-                hasDoc: !!doc,
-                operation,
-                status: doc._status,
-                hasExternalId: !!doc.externalId,
-                hasProviderId: !!doc.providerId
-              });
-              if (doc.externalId || doc.providerId) {
-                req.payload.logger.info("Broadcast already has provider IDs, skipping creation", {
-                  externalId: doc.externalId,
-                  providerId: doc.providerId
-                });
-                return doc;
-              }
-              const providerConfig = await getBroadcastConfig(req, pluginConfig);
-              if (!providerConfig || !providerConfig.token) {
-                req.payload.logger.error("Broadcast provider not configured in Newsletter Settings or environment variables");
-                return doc;
-              }
-              const { BroadcastApiProvider: BroadcastApiProvider2 } = await Promise.resolve().then(() => (init_broadcast2(), broadcast_exports));
-              const provider = new BroadcastApiProvider2(providerConfig);
-              const subject = doc.subject || `Draft Broadcast ${(/* @__PURE__ */ new Date()).toISOString()}`;
-              const htmlContent = doc.contentSection?.content ? await convertToEmailSafeHtml(
-                await populateMediaFields(doc.contentSection.content, req.payload, pluginConfig),
-                {
-                  wrapInTemplate: pluginConfig.customizations?.broadcasts?.emailPreview?.wrapInTemplate ?? true,
-                  customWrapper: pluginConfig.customizations?.broadcasts?.emailPreview?.customWrapper,
-                  preheader: doc.contentSection?.preheader,
-                  subject,
-                  documentData: doc,
-                  customBlockConverter: pluginConfig.customizations?.broadcasts?.customBlockConverter
-                }
-              ) : "<p>Draft content - to be updated</p>";
-              const createData = {
-                name: subject,
-                // Use subject as name
-                subject,
-                preheader: doc.contentSection?.preheader || "",
-                content: htmlContent,
-                trackOpens: doc.settings?.trackOpens ?? true,
-                trackClicks: doc.settings?.trackClicks ?? true,
-                replyTo: doc.settings?.replyTo || providerConfig.replyTo,
-                audienceIds: doc.audienceIds?.map((a) => a.audienceId) || []
-              };
-              req.payload.logger.info("Creating broadcast in provider with minimal data to establish association", {
-                subject: createData.subject,
-                hasActualContent: !!doc.contentSection?.content
-              });
-              const providerBroadcast = await provider.create(createData);
-              req.payload.logger.info("Provider broadcast created:", {
-                providerBroadcastId: providerBroadcast.id,
-                providerBroadcastIdType: typeof providerBroadcast.id,
-                docId: doc.id,
-                docIdType: typeof doc.id
-              });
-              req.payload.logger.info(`Broadcast ${doc.id} created in provider with ID ${providerBroadcast.id}`);
-              return {
-                ...doc,
-                providerId: providerBroadcast.id,
-                externalId: providerBroadcast.id,
-                // Include externalId in return value
-                providerData: providerBroadcast.providerData
-              };
-            } catch (error) {
-              req.payload.logger.error("Failed to create broadcast in provider during initial creation:");
-              if (error instanceof Error) {
-                req.payload.logger.error("Error details:", {
-                  message: error.message,
-                  stack: error.stack,
-                  name: error.name
-                });
-              } else {
-                req.payload.logger.error("Raw error:", error);
-              }
-              return doc;
-            }
+            req.payload.logger.info("Broadcast created in Payload, provider sync will happen on first update with content");
+            return doc;
           }
           if (operation === "update") {
             req.payload.logger.info("Broadcast afterChange update hook triggered", {
               operation,
               hasProviderId: !!doc.providerId,
+              hasExternalId: !!doc.externalId,
               sendStatus: doc.sendStatus,
-              publishStatus: doc._status
+              publishStatus: doc._status,
+              hasSubject: !!doc.subject,
+              hasContent: !!doc.contentSection?.content
             });
             try {
               const providerConfig = await getBroadcastConfig(req, pluginConfig);
@@ -2401,8 +2327,40 @@ var createBroadcastsCollection = (pluginConfig) => {
               }
               const { BroadcastApiProvider: BroadcastApiProvider2 } = await Promise.resolve().then(() => (init_broadcast2(), broadcast_exports));
               const provider = new BroadcastApiProvider2(providerConfig);
+              if (!doc.providerId && !doc.externalId && doc.subject && doc.contentSection?.content) {
+                req.payload.logger.info("Creating broadcast in provider on first update with content");
+                const htmlContent = await convertToEmailSafeHtml(
+                  await populateMediaFields(doc.contentSection.content, req.payload, pluginConfig),
+                  {
+                    wrapInTemplate: pluginConfig.customizations?.broadcasts?.emailPreview?.wrapInTemplate ?? true,
+                    customWrapper: pluginConfig.customizations?.broadcasts?.emailPreview?.customWrapper,
+                    preheader: doc.contentSection?.preheader,
+                    subject: doc.subject,
+                    documentData: doc,
+                    customBlockConverter: pluginConfig.customizations?.broadcasts?.customBlockConverter
+                  }
+                );
+                const createData = {
+                  name: doc.subject,
+                  subject: doc.subject,
+                  preheader: doc.contentSection?.preheader || "",
+                  content: htmlContent,
+                  trackOpens: doc.settings?.trackOpens ?? true,
+                  trackClicks: doc.settings?.trackClicks ?? true,
+                  replyTo: doc.settings?.replyTo || providerConfig.replyTo,
+                  audienceIds: doc.audienceIds?.map((a) => a.audienceId) || []
+                };
+                const providerBroadcast = await provider.create(createData);
+                req.payload.logger.info(`Broadcast ${doc.id} created in provider with ID ${providerBroadcast.id}`);
+                return {
+                  ...doc,
+                  providerId: providerBroadcast.id,
+                  externalId: providerBroadcast.id,
+                  providerData: providerBroadcast.providerData
+                };
+              }
               if (!doc.providerId) {
-                req.payload.logger.warn(`Broadcast ${doc.id} has no providerId - provider sync skipped. This shouldn't happen with immediate creation.`);
+                req.payload.logger.info(`Broadcast ${doc.id} has no providerId and insufficient content for creation - skipping sync`);
                 return doc;
               }
               if (doc.providerId) {