payload-plugin-newsletter 0.25.8 → 0.25.11

package/CHANGELOG.md

@@ -1,3 +1,25 @@
+## [0.25.11] - 2025-12-11
+
+### Fixed
+- Fixed LinkFeature configuration causing URLs to disappear in the Lexical editor link drawer
+  - The custom `fields` array was replacing Payload's default fields, removing the crucial `linkType` field
+  - Now uses default LinkFeature fields which include all required fields for the drawer UI to work correctly
+- Fixed TypeScript errors with Payload logger API (pino signature requires object first, then message)
+- Fixed `relationTo` type errors where `string | string[]` was passed to `findByID`
+
+## [0.25.9] - 2025-08-19
+
+### Fixed
+- Fixed providerId/externalId not being saved during broadcast creation
+  - Moved provider creation from create to update operation
+  - Provider broadcast is now created on first update when subject and content are present
+  - Ensures IDs are properly persisted to the database
+  - Prevents issues with Payload's create operation not persisting afterChange modifications
+
+### Changed
+- Broadcasts are now created in Payload first, then synced to provider on first meaningful update
+- More robust approach that works with Payload's hook lifecycle
+
 ## [0.25.8] - 2025-08-19
 
 ### Fixed

package/dist/collections.cjs

@@ -754,25 +754,8 @@ var createEmailSafeFeatures = (additionalBlocks) => {
     (0, import_richtext_lexical.ItalicFeature)(),
     (0, import_richtext_lexical.UnderlineFeature)(),
     (0, import_richtext_lexical.StrikethroughFeature)(),
-    // Links with enhanced configuration
-    (0, import_richtext_lexical.LinkFeature)({
-      fields: [
-        {
-          name: "url",
-          type: "text",
-          required: true,
-          admin: {
-            description: "Enter the full URL (including https://)"
-          }
-        },
-        {
-          name: "newTab",
-          type: "checkbox",
-          label: "Open in new tab",
-          defaultValue: false
-        }
-      ]
-    }),
+    // Links - use default fields to ensure drawer UI works correctly
+    (0, import_richtext_lexical.LinkFeature)(),
     // Lists
     (0, import_richtext_lexical.OrderedListFeature)(),
     (0, import_richtext_lexical.UnorderedListFeature)(),
@@ -828,25 +811,8 @@ var createEmailLexicalEditor = (customBlocks = []) => {
       (0, import_richtext_lexical.ItalicFeature)(),
       (0, import_richtext_lexical.UnderlineFeature)(),
       (0, import_richtext_lexical.StrikethroughFeature)(),
-      // Links with enhanced configuration
-      (0, import_richtext_lexical.LinkFeature)({
-        fields: [
-          {
-            name: "url",
-            type: "text",
-            required: true,
-            admin: {
-              description: "Enter the full URL (including https://)"
-            }
-          },
-          {
-            name: "newTab",
-            type: "checkbox",
-            label: "Open in new tab",
-            defaultValue: false
-          }
-        ]
-      }),
+      // Links - use default fields to ensure drawer UI works correctly
+      (0, import_richtext_lexical.LinkFeature)(),
       // Lists
       (0, import_richtext_lexical.OrderedListFeature)(),
       (0, import_richtext_lexical.UnorderedListFeature)(),
@@ -1414,7 +1380,7 @@ async function getBroadcastConfig(req, pluginConfig) {
     }
     return pluginConfig.providers?.broadcast || null;
   } catch (error) {
-    req.payload.logger.error("Failed to get broadcast config from settings:", error);
+    req.payload.logger.error({ error: String(error) }, "Failed to get broadcast config from settings");
     return pluginConfig.providers?.broadcast || null;
   }
 }
@@ -1811,23 +1777,24 @@ async function populateBlockMediaFields(node, payload, config) {
       for (const field of blockConfig.fields) {
         if (field.type === "upload" && field.relationTo && node.fields[field.name]) {
           const fieldValue = node.fields[field.name];
+          const collectionName = Array.isArray(field.relationTo) ? field.relationTo[0] : field.relationTo;
           if (typeof fieldValue === "string" && fieldValue.match(/^[a-f0-9]{24}$/i)) {
             try {
               const media = await payload.findByID({
-                collection: field.relationTo,
+                collection: collectionName,
                 id: fieldValue,
                 depth: 0
               });
               if (media) {
                 node.fields[field.name] = media;
-                payload.logger?.info(`Populated ${field.name} for block ${blockType}:`, {
+                payload.logger?.info({
                   mediaId: fieldValue,
                   mediaUrl: media.url,
                   filename: media.filename
-                });
+                }, `Populated ${field.name} for block ${blockType}`);
               }
             } catch (error) {
-              payload.logger?.error(`Failed to populate ${field.name} for block ${blockType}:`, error);
+              payload.logger?.error({ error: String(error) }, `Failed to populate ${field.name} for block ${blockType}`);
             }
           }
         }
@@ -1839,23 +1806,24 @@ async function populateBlockMediaFields(node, payload, config) {
                 for (const arrayField of field.fields) {
                   if (arrayField.type === "upload" && arrayField.relationTo && arrayItem[arrayField.name]) {
                     const arrayFieldValue = arrayItem[arrayField.name];
+                    const arrayCollectionName = Array.isArray(arrayField.relationTo) ? arrayField.relationTo[0] : arrayField.relationTo;
                     if (typeof arrayFieldValue === "string" && arrayFieldValue.match(/^[a-f0-9]{24}$/i)) {
                       try {
                         const media = await payload.findByID({
-                          collection: arrayField.relationTo,
+                          collection: arrayCollectionName,
                           id: arrayFieldValue,
                           depth: 0
                         });
                         if (media) {
                           arrayItem[arrayField.name] = media;
-                          payload.logger?.info(`Populated array ${arrayField.name} for block ${blockType}:`, {
+                          payload.logger?.info({
                             mediaId: arrayFieldValue,
                             mediaUrl: media.url,
                             filename: media.filename
-                          });
+                          }, `Populated array ${arrayField.name} for block ${blockType}`);
                         }
                       } catch (error) {
-                        payload.logger?.error(`Failed to populate array ${arrayField.name} for block ${blockType}:`, error);
+                        payload.logger?.error({ error: String(error) }, `Failed to populate array ${arrayField.name} for block ${blockType}`);
                       }
                     }
                   }
@@ -1899,14 +1867,14 @@ async function populateRichTextUploads(content, payload) {
         });
         if (media) {
           node.value = media;
-          payload.logger?.info(`Populated rich text upload node:`, {
+          payload.logger?.info({
             mediaId: node.value,
             mediaUrl: media.url,
             filename: media.filename
-          });
+          }, "Populated rich text upload node");
         }
       } catch (error) {
-        payload.logger?.error(`Failed to populate rich text upload ${node.value}:`, error);
+        payload.logger?.error({ error: String(error) }, `Failed to populate rich text upload ${node.value}`);
       }
     }
     if (node.children && Array.isArray(node.children)) {
@@ -2306,93 +2274,19 @@ var createBroadcastsCollection = (pluginConfig) => {
         async ({ doc, operation, req, previousDoc }) => {
           if (!hasProviders) return doc;
           if (operation === "create") {
-            try {
-              req.payload.logger.info("Broadcast afterChange CREATE hook (sync) - doc info:", {
-                docId: doc.id,
-                docIdType: typeof doc.id,
-                hasDoc: !!doc,
-                operation,
-                status: doc._status,
-                hasExternalId: !!doc.externalId,
-                hasProviderId: !!doc.providerId
-              });
-              if (doc.externalId || doc.providerId) {
-                req.payload.logger.info("Broadcast already has provider IDs, skipping creation", {
-                  externalId: doc.externalId,
-                  providerId: doc.providerId
-                });
-                return doc;
-              }
-              const providerConfig = await getBroadcastConfig(req, pluginConfig);
-              if (!providerConfig || !providerConfig.token) {
-                req.payload.logger.error("Broadcast provider not configured in Newsletter Settings or environment variables");
-                return doc;
-              }
-              const { BroadcastApiProvider: BroadcastApiProvider2 } = await Promise.resolve().then(() => (init_broadcast2(), broadcast_exports));
-              const provider = new BroadcastApiProvider2(providerConfig);
-              const subject = doc.subject || `Draft Broadcast ${(/* @__PURE__ */ new Date()).toISOString()}`;
-              const htmlContent = doc.contentSection?.content ? await convertToEmailSafeHtml(
-                await populateMediaFields(doc.contentSection.content, req.payload, pluginConfig),
-                {
-                  wrapInTemplate: pluginConfig.customizations?.broadcasts?.emailPreview?.wrapInTemplate ?? true,
-                  customWrapper: pluginConfig.customizations?.broadcasts?.emailPreview?.customWrapper,
-                  preheader: doc.contentSection?.preheader,
-                  subject,
-                  documentData: doc,
-                  customBlockConverter: pluginConfig.customizations?.broadcasts?.customBlockConverter
-                }
-              ) : "<p>Draft content - to be updated</p>";
-              const createData = {
-                name: subject,
-                // Use subject as name
-                subject,
-                preheader: doc.contentSection?.preheader || "",
-                content: htmlContent,
-                trackOpens: doc.settings?.trackOpens ?? true,
-                trackClicks: doc.settings?.trackClicks ?? true,
-                replyTo: doc.settings?.replyTo || providerConfig.replyTo,
-                audienceIds: doc.audienceIds?.map((a) => a.audienceId) || []
-              };
-              req.payload.logger.info("Creating broadcast in provider with minimal data to establish association", {
-                subject: createData.subject,
-                hasActualContent: !!doc.contentSection?.content
-              });
-              const providerBroadcast = await provider.create(createData);
-              req.payload.logger.info("Provider broadcast created:", {
-                providerBroadcastId: providerBroadcast.id,
-                providerBroadcastIdType: typeof providerBroadcast.id,
-                docId: doc.id,
-                docIdType: typeof doc.id
-              });
-              req.payload.logger.info(`Broadcast ${doc.id} created in provider with ID ${providerBroadcast.id}`);
-              return {
-                ...doc,
-                providerId: providerBroadcast.id,
-                externalId: providerBroadcast.id,
-                // Include externalId in return value
-                providerData: providerBroadcast.providerData
-              };
-            } catch (error) {
-              req.payload.logger.error("Failed to create broadcast in provider during initial creation:");
-              if (error instanceof Error) {
-                req.payload.logger.error("Error details:", {
-                  message: error.message,
-                  stack: error.stack,
-                  name: error.name
-                });
-              } else {
-                req.payload.logger.error("Raw error:", error);
-              }
-              return doc;
-            }
+            req.payload.logger.info("Broadcast created in Payload, provider sync will happen on first update with content");
+            return doc;
           }
           if (operation === "update") {
-            req.payload.logger.info("Broadcast afterChange update hook triggered", {
+            req.payload.logger.info({
               operation,
               hasProviderId: !!doc.providerId,
+              hasExternalId: !!doc.externalId,
               sendStatus: doc.sendStatus,
-              publishStatus: doc._status
-            });
+              publishStatus: doc._status,
+              hasSubject: !!doc.subject,
+              hasContent: !!doc.contentSection?.content
+            }, "Broadcast afterChange update hook triggered");
             try {
               const providerConfig = await getBroadcastConfig(req, pluginConfig);
               if (!providerConfig || !providerConfig.token) {
@@ -2401,8 +2295,40 @@ var createBroadcastsCollection = (pluginConfig) => {
               }
               const { BroadcastApiProvider: BroadcastApiProvider2 } = await Promise.resolve().then(() => (init_broadcast2(), broadcast_exports));
               const provider = new BroadcastApiProvider2(providerConfig);
+              if (!doc.providerId && !doc.externalId && doc.subject && doc.contentSection?.content) {
+                req.payload.logger.info("Creating broadcast in provider on first update with content");
+                const htmlContent = await convertToEmailSafeHtml(
+                  await populateMediaFields(doc.contentSection.content, req.payload, pluginConfig),
+                  {
+                    wrapInTemplate: pluginConfig.customizations?.broadcasts?.emailPreview?.wrapInTemplate ?? true,
+                    customWrapper: pluginConfig.customizations?.broadcasts?.emailPreview?.customWrapper,
+                    preheader: doc.contentSection?.preheader,
+                    subject: doc.subject,
+                    documentData: doc,
+                    customBlockConverter: pluginConfig.customizations?.broadcasts?.customBlockConverter
+                  }
+                );
+                const createData = {
+                  name: doc.subject,
+                  subject: doc.subject,
+                  preheader: doc.contentSection?.preheader || "",
+                  content: htmlContent,
+                  trackOpens: doc.settings?.trackOpens ?? true,
+                  trackClicks: doc.settings?.trackClicks ?? true,
+                  replyTo: doc.settings?.replyTo || providerConfig.replyTo,
+                  audienceIds: doc.audienceIds?.map((a) => a.audienceId) || []
+                };
+                const providerBroadcast = await provider.create(createData);
+                req.payload.logger.info(`Broadcast ${doc.id} created in provider with ID ${providerBroadcast.id}`);
+                return {
+                  ...doc,
+                  providerId: providerBroadcast.id,
+                  externalId: providerBroadcast.id,
+                  providerData: providerBroadcast.providerData
+                };
+              }
               if (!doc.providerId) {
-                req.payload.logger.warn(`Broadcast ${doc.id} has no providerId - provider sync skipped. This shouldn't happen with immediate creation.`);
+                req.payload.logger.info(`Broadcast ${doc.id} has no providerId and insufficient content for creation - skipping sync`);
                 return doc;
               }
               if (doc.providerId) {
@@ -2447,10 +2373,10 @@ var createBroadcastsCollection = (pluginConfig) => {
                   if (JSON.stringify(doc.audienceIds) !== JSON.stringify(previousDoc?.audienceIds)) {
                     updates.audienceIds = doc.audienceIds?.map((a) => a.audienceId);
                   }
-                  req.payload.logger.info("Syncing broadcast updates to provider", {
+                  req.payload.logger.info({
                     providerId: doc.providerId,
                     updates
-                  });
+                  }, "Syncing broadcast updates to provider");
                   await provider.update(doc.providerId, updates);
                   req.payload.logger.info(`Broadcast ${doc.id} synced to provider successfully`);
                 } else {
@@ -2472,18 +2398,18 @@ var createBroadcastsCollection = (pluginConfig) => {
                   ...error.statusText
                 });
               } else if (typeof error === "string") {
-                req.payload.logger.error("Error is a string:", error);
+                req.payload.logger.error({ errorValue: error }, "Error is a string");
               } else if (error && typeof error === "object") {
-                req.payload.logger.error("Error is an object:", JSON.stringify(error, null, 2));
+                req.payload.logger.error({ errorValue: JSON.stringify(error, null, 2) }, "Error is an object");
               } else {
-                req.payload.logger.error("Unknown error type:", typeof error);
+                req.payload.logger.error({ errorType: typeof error }, "Unknown error type");
               }
-              req.payload.logger.error("Failed broadcast document (update operation):", {
+              req.payload.logger.error({
                 id: doc.id,
                 subject: doc.subject,
                 hasContent: !!doc.contentSection?.content,
                 contentType: doc.contentSection?.content ? typeof doc.contentSection.content : "none"
-              });
+              }, "Failed broadcast document (update operation)");
             }
           }
           return doc;
@@ -2529,7 +2455,7 @@ var createBroadcastsCollection = (pluginConfig) => {
                   ...error.details
                 });
               } else {
-                req.payload.logger.error(`Failed to send broadcast ${doc.id}:`, error);
+                req.payload.logger.error({ error: String(error) }, `Failed to send broadcast ${doc.id}`);
               }
               await req.payload.update({
                 collection: "broadcasts",
@@ -2572,7 +2498,7 @@ var createBroadcastsCollection = (pluginConfig) => {
                 ...error.details
               });
             } else {
-              req.payload.logger.error("Failed to delete broadcast from provider:", error);
+              req.payload.logger.error({ error: String(error) }, "Failed to delete broadcast from provider");
             }
           }
           return doc;