payload-plugin-newsletter 0.25.0 → 0.25.2

package/CHANGELOG.md

@@ -1,3 +1,22 @@
+## [0.25.2] - 2025-08-15
+
+### Fixed
+- Fixed issue where editing draft broadcasts created duplicate entries in the provider instead of updating the existing broadcast
+- Broadcasts now immediately sync to provider on creation with minimal data to establish the association
+
+## [0.25.1] - 2025-08-09
+
+### Fixed
+- **Removed webhook status updates**: Eliminated permission errors when processing Broadcast webhooks
+  - Webhook handler no longer attempts to update global settings
+  - Fixes "Only administrators can modify newsletter settings" errors
+  
+### Changed
+- **Webhook subscribers now start as active**: `subscriber.created` webhook events now set status as 'active' instead of 'pending'
+  - Better aligns with single opt-in workflows
+  - Matches Broadcast's confirmed subscriber status
+  - Welcome emails still prevented by `importedFromProvider` flag
+
 ## [0.25.0] - 2025-08-08
 
 ### Changed

package/dist/collections.cjs

@@ -1514,7 +1514,7 @@ var createSendBroadcastEndpoint = (config, collectionSlug) => {
   return {
     path: "/:id/send",
     method: "post",
-    handler: async (req) => {
+    handler: (async (req) => {
       try {
         const auth = await requireAdmin(req, config);
         if (!auth.authorized) {
@@ -1588,7 +1588,7 @@ var createSendBroadcastEndpoint = (config, collectionSlug) => {
           error: "Failed to send broadcast"
         }, { status: 500 });
       }
-    }
+    })
   };
 };
 
@@ -1598,7 +1598,7 @@ var createScheduleBroadcastEndpoint = (config, collectionSlug) => {
   return {
     path: "/:id/schedule",
     method: "post",
-    handler: async (req) => {
+    handler: (async (req) => {
       try {
         const auth = await requireAdmin(req, config);
         if (!auth.authorized) {
@@ -1692,7 +1692,7 @@ var createScheduleBroadcastEndpoint = (config, collectionSlug) => {
           error: "Failed to schedule broadcast"
         }, { status: 500 });
       }
-    }
+    })
   };
 };
 
@@ -1701,7 +1701,7 @@ var createTestBroadcastEndpoint = (config, collectionSlug) => {
   return {
     path: "/:id/test",
     method: "post",
-    handler: async (req) => {
+    handler: (async (req) => {
       try {
         const auth = await requireAdmin(req, config);
         if (!auth.authorized) {
@@ -1775,7 +1775,7 @@ var createTestBroadcastEndpoint = (config, collectionSlug) => {
           error: "Failed to send test email"
         }, { status: 500 });
       }
-    }
+    })
   };
 };
 
@@ -1864,7 +1864,7 @@ var createBroadcastPreviewEndpoint = (config, _collectionSlug) => {
   return {
     path: "/preview",
     method: "post",
-    handler: async (req) => {
+    handler: (async (req) => {
       try {
         const data = await (req.json?.() || Promise.resolve({}));
         const { content, preheader, subject, documentData } = data;
@@ -1904,7 +1904,7 @@ var createBroadcastPreviewEndpoint = (config, _collectionSlug) => {
           error: "Failed to generate email preview"
         }, { status: 500 });
       }
-    }
+    })
   };
 };
 
@@ -2249,10 +2249,6 @@ var createBroadcastsCollection = (pluginConfig) => {
         async ({ doc, operation, req, previousDoc }) => {
           if (!hasProviders) return doc;
           if (operation === "create") {
-            if (!doc.subject || !doc.contentSection?.content) {
-              req.payload.logger.info("Skipping provider sync - broadcast has no subject or content yet");
-              return doc;
-            }
             try {
               const providerConfig = await getBroadcastConfig(req, pluginConfig);
               if (!providerConfig || !providerConfig.token) {
@@ -2261,45 +2257,32 @@ var createBroadcastsCollection = (pluginConfig) => {
               }
               const { BroadcastApiProvider: BroadcastApiProvider2 } = await Promise.resolve().then(() => (init_broadcast2(), broadcast_exports));
               const provider = new BroadcastApiProvider2(providerConfig);
-              req.payload.logger.info("Populating media fields and converting content to HTML...");
-              const populatedContent = await populateMediaFields(doc.contentSection?.content, req.payload, pluginConfig);
-              const emailPreviewConfig = pluginConfig.customizations?.broadcasts?.emailPreview;
-              const htmlContent = await convertToEmailSafeHtml(populatedContent, {
-                wrapInTemplate: emailPreviewConfig?.wrapInTemplate ?? true,
-                customWrapper: emailPreviewConfig?.customWrapper,
-                preheader: doc.contentSection?.preheader,
-                subject: doc.subject,
-                documentData: doc,
-                // Pass entire document
-                customBlockConverter: pluginConfig.customizations?.broadcasts?.customBlockConverter
-              });
-              if (!htmlContent || htmlContent.trim() === "") {
-                req.payload.logger.info("Skipping provider sync - content is empty after conversion");
-                return doc;
-              }
+              const subject = doc.subject || `Draft Broadcast ${(/* @__PURE__ */ new Date()).toISOString()}`;
+              const htmlContent = doc.contentSection?.content ? await convertToEmailSafeHtml(
+                await populateMediaFields(doc.contentSection.content, req.payload, pluginConfig),
+                {
+                  wrapInTemplate: pluginConfig.customizations?.broadcasts?.emailPreview?.wrapInTemplate ?? true,
+                  customWrapper: pluginConfig.customizations?.broadcasts?.emailPreview?.customWrapper,
+                  preheader: doc.contentSection?.preheader,
+                  subject,
+                  documentData: doc,
+                  customBlockConverter: pluginConfig.customizations?.broadcasts?.customBlockConverter
+                }
+              ) : "<p>Draft content - to be updated</p>";
               const createData = {
-                name: doc.subject,
-                // Use subject as name since we removed the name field
-                subject: doc.subject,
-                preheader: doc.contentSection?.preheader,
+                name: subject,
+                // Use subject as name
+                subject,
+                preheader: doc.contentSection?.preheader || "",
                 content: htmlContent,
-                trackOpens: doc.settings?.trackOpens,
-                trackClicks: doc.settings?.trackClicks,
+                trackOpens: doc.settings?.trackOpens ?? true,
+                trackClicks: doc.settings?.trackClicks ?? true,
                 replyTo: doc.settings?.replyTo || providerConfig.replyTo,
-                audienceIds: doc.audienceIds?.map((a) => a.audienceId)
+                audienceIds: doc.audienceIds?.map((a) => a.audienceId) || []
               };
-              req.payload.logger.info("Creating broadcast with data:", {
-                name: createData.name,
+              req.payload.logger.info("Creating broadcast in provider with minimal data to establish association", {
                 subject: createData.subject,
-                preheader: createData.preheader || "NONE",
-                contentLength: htmlContent ? htmlContent.length : 0,
-                contentPreview: htmlContent ? htmlContent.substring(0, 100) + "..." : "EMPTY",
-                trackOpens: createData.trackOpens,
-                trackClicks: createData.trackClicks,
-                replyTo: createData.replyTo,
-                audienceIds: createData.audienceIds || [],
-                apiUrl: providerConfig.apiUrl,
-                hasToken: !!providerConfig.token
+                hasActualContent: !!doc.contentSection?.content
               });
               const providerBroadcast = await provider.create(createData);
               await req.payload.update({
@@ -2311,40 +2294,14 @@ var createBroadcastsCollection = (pluginConfig) => {
                 },
                 req
               });
+              req.payload.logger.info(`Broadcast ${doc.id} created in provider with ID ${providerBroadcast.id}`);
               return {
                 ...doc,
                 providerId: providerBroadcast.id,
                 providerData: providerBroadcast.providerData
               };
             } catch (error) {
-              req.payload.logger.error("Raw error from broadcast provider:");
-              req.payload.logger.error(error);
-              if (error instanceof Error) {
-                req.payload.logger.error("Error is instance of Error:", {
-                  message: error.message,
-                  stack: error.stack,
-                  name: error.name,
-                  // If it's a BroadcastProviderError, it might have additional details
-                  ...error.details,
-                  // Check if it's a fetch response error
-                  ...error.response,
-                  ...error.data,
-                  ...error.status,
-                  ...error.statusText
-                });
-              } else if (typeof error === "string") {
-                req.payload.logger.error("Error is a string:", error);
-              } else if (error && typeof error === "object") {
-                req.payload.logger.error("Error is an object:", JSON.stringify(error, null, 2));
-              } else {
-                req.payload.logger.error("Unknown error type:", typeof error);
-              }
-              req.payload.logger.error("Failed broadcast document:", {
-                id: doc.id,
-                subject: doc.subject,
-                hasContent: !!doc.contentSection?.content,
-                contentType: doc.contentSection?.content ? typeof doc.contentSection.content : "none"
-              });
+              req.payload.logger.error("Failed to create broadcast in provider during initial creation:", error);
               return doc;
             }
           }
@@ -2364,61 +2321,8 @@ var createBroadcastsCollection = (pluginConfig) => {
               const { BroadcastApiProvider: BroadcastApiProvider2 } = await Promise.resolve().then(() => (init_broadcast2(), broadcast_exports));
               const provider = new BroadcastApiProvider2(providerConfig);
               if (!doc.providerId) {
-                if (!doc.subject || !doc.contentSection?.content) {
-                  req.payload.logger.info("Still missing required fields for provider sync");
-                  return doc;
-                }
-                req.payload.logger.info("Creating broadcast in provider (deferred from initial create)...");
-                const populatedContent = await populateMediaFields(doc.contentSection?.content, req.payload, pluginConfig);
-                const emailPreviewConfig = pluginConfig.customizations?.broadcasts?.emailPreview;
-                const htmlContent = await convertToEmailSafeHtml(populatedContent, {
-                  wrapInTemplate: emailPreviewConfig?.wrapInTemplate ?? true,
-                  customWrapper: emailPreviewConfig?.customWrapper,
-                  preheader: doc.contentSection?.preheader,
-                  subject: doc.subject,
-                  documentData: doc,
-                  // Pass entire document
-                  customBlockConverter: pluginConfig.customizations?.broadcasts?.customBlockConverter
-                });
-                if (!htmlContent || htmlContent.trim() === "") {
-                  req.payload.logger.info("Skipping provider sync - content is empty after conversion");
-                  return doc;
-                }
-                const createData = {
-                  name: doc.subject,
-                  subject: doc.subject,
-                  preheader: doc.contentSection?.preheader,
-                  content: htmlContent,
-                  trackOpens: doc.settings?.trackOpens,
-                  trackClicks: doc.settings?.trackClicks,
-                  replyTo: doc.settings?.replyTo || providerConfig.replyTo,
-                  audienceIds: doc.audienceIds?.map((a) => a.audienceId)
-                };
-                req.payload.logger.info("Creating broadcast with data:", {
-                  name: createData.name,
-                  subject: createData.subject,
-                  preheader: createData.preheader || "NONE",
-                  contentLength: htmlContent ? htmlContent.length : 0,
-                  contentPreview: htmlContent ? htmlContent.substring(0, 100) + "..." : "EMPTY",
-                  apiUrl: providerConfig.apiUrl,
-                  hasToken: !!providerConfig.token
-                });
-                const providerBroadcast = await provider.create(createData);
-                await req.payload.update({
-                  collection: "broadcasts",
-                  id: doc.id,
-                  data: {
-                    providerId: providerBroadcast.id,
-                    providerData: providerBroadcast.providerData
-                  },
-                  req
-                });
-                req.payload.logger.info(`Broadcast ${doc.id} created in provider successfully (deferred)`);
-                return {
-                  ...doc,
-                  providerId: providerBroadcast.id,
-                  providerData: providerBroadcast.providerData
-                };
+                req.payload.logger.warn(`Broadcast ${doc.id} has no providerId - provider sync skipped. This shouldn't happen with immediate creation.`);
+                return doc;
               }
               if (doc.providerId) {
                 const capabilities = provider.getCapabilities();