patchwarden 1.5.1 → 1.6.1

package/src/test/unit/evidence-pack.test.ts

@@ -1,251 +0,0 @@
-import { describe, it, beforeEach, afterEach } from "node:test";
-import { strict as assert } from "node:assert";
-import { existsSync, mkdirSync, mkdtempSync, rmSync, writeFileSync, readFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { reloadConfig } from "../../config.js";
-import { recommendAgentForTask } from "../../tools/recommendAgentForTask.js";
-import { exportTaskEvidencePack, listEvidencePacks, readEvidencePack } from "../../tools/evidencePack.js";
-import { writeTaskLineage } from "../../tools/taskLineage.js";
-
-let tempDir: string;
-let prevConfigEnv: string | undefined;
-
-function writeConfig() {
-  const configPath = join(tempDir, "patchwarden.config.json");
-  writeFileSync(
-    configPath,
-    JSON.stringify({
-      workspaceRoot: tempDir,
-      tasksDir: ".patchwarden/tasks",
-      plansDir: ".patchwarden/plans",
-      assessmentsDir: ".patchwarden/assessments",
-      agents: {
-        codex: { command: "codex", args: [] },
-        opencode: { command: "opencode", args: [] },
-      },
-      allowedTestCommands: ["npm test", "npm run build"],
-      defaultTaskTimeoutSeconds: 30,
-      maxTaskTimeoutSeconds: 120,
-    }),
-    "utf-8"
-  );
-  prevConfigEnv = process.env.PATCHWARDEN_CONFIG;
-  process.env.PATCHWARDEN_CONFIG = configPath;
-  reloadConfig();
-}
-
-describe("v1.5 evidence packs and agent recommendations", () => {
-  beforeEach(() => {
-    tempDir = mkdtempSync(join(tmpdir(), "pw-evidence-"));
-    writeConfig();
-  });
-
-  afterEach(() => {
-    if (prevConfigEnv === undefined) delete process.env.PATCHWARDEN_CONFIG;
-    else process.env.PATCHWARDEN_CONFIG = prevConfigEnv;
-    reloadConfig();
-    rmSync(tempDir, { recursive: true, force: true });
-  });
-
-  it("recommends an agent without creating task evidence", () => {
-    const recommendation = recommendAgentForTask({
-      repo_path: ".",
-      goal: "Refactor two modules safely",
-      scope_files: ["src/a.ts", "src/b.ts"],
-    });
-
-    assert.equal(recommendation.bounded, true);
-    assert.ok(["codex", "opencode"].includes(recommendation.recommended_agent));
-    assert.ok(Array.isArray(recommendation.suggested_verify_commands));
-    const payload = JSON.stringify(recommendation);
-    assert.ok(!payload.includes("stdout"));
-    assert.ok(!payload.includes("stderr"));
-    assert.ok(!payload.includes("diff"));
-  });
-
-  it("exports bounded BOM-free evidence pack from lineage", () => {
-    writeTaskLineage({
-      lineage_id: "lineage_v15_pack",
-      goal: "Export evidence",
-      repo_path: ".",
-      created_at: "2026-07-05T12:00:00.000Z",
-      updated_at: "2026-07-05T12:01:00.000Z",
-      final_status: "accepted",
-      stop_reason: "success",
-      next_action: "accept",
-      main_task: "task-main",
-      fix_tasks: [],
-      cleanup_tasks: [],
-      direct_sessions: [{
-        session_id: "direct-one",
-        status: "passed",
-        command_count: 1,
-        passed_commands: 1,
-        failed_commands: 0,
-        timed_out_commands: 0,
-        audit_decision: "pass",
-        changed_files_total: 0,
-        next_action: "accept",
-      }],
-      rounds: [{
-        iteration: 1,
-        task_id: "task-main",
-        role: "main",
-        status: "done_by_agent",
-        terminal: true,
-        verification_status: "passed",
-        audit_verdict: "pass",
-        fail_checks: [],
-        warn_checks: [],
-        next_action: "accept",
-      }],
-      warnings: [],
-      errors: [],
-      worktree: {
-        isolation_mode: "worktree",
-        worktree_id: "wt-one",
-        worktree_path: join(tempDir, "_workspacetrees", "wt-one"),
-        branch: "pw-test",
-        cleanup: "keep",
-        status: "active",
-        next_action: "merge or discard explicitly",
-      },
-      agent_routing: {
-        requested_agent: "auto",
-        selected_agent: "codex",
-        reason: "test route",
-        fallback: false,
-      },
-    });
-
-    const pack = exportTaskEvidencePack({ lineage_id: "lineage_v15_pack" });
-    assert.equal(pack.bounded, true);
-    assert.equal(pack.lineage.worktree.worktree_id, "wt-one");
-    assert.equal(pack.lineage.agent_routing?.selected_agent, "codex");
-    const raw = readFileSync(pack.files.json);
-    assert.notEqual(raw[0], 0xef);
-    JSON.parse(raw.toString("utf-8"));
-
-    const payload = JSON.stringify(pack);
-    assert.ok(!payload.includes("stdout_tail"));
-    assert.ok(!payload.includes("stderr_tail"));
-    assert.ok(!payload.includes("diff.patch"));
-    assert.ok(!payload.includes("verification.log"));
-
-    const readBack = readEvidencePack("lineage_v15_pack");
-    assert.equal(readBack?.lineage_id, "lineage_v15_pack");
-    const listed = listEvidencePacks();
-    assert.equal(listed.total, 1);
-    assert.equal(listed.evidence_packs[0].lineage_id, "lineage_v15_pack");
-
-    // v2: all six structured artifact files should exist.
-    for (const key of ["risk", "verify", "diffstat", "lineage", "attestation", "redactions"] as const) {
-      assert.ok(existsSync(pack.files[key]), `${key} file should exist`);
-    }
-
-    // v2: attestation.json must carry the required provenance fields.
-    const attestation = JSON.parse(readFileSync(pack.files.attestation, "utf-8"));
-    assert.ok(attestation.patchwarden_version, "attestation should have patchwarden_version");
-    assert.ok(attestation.package_version, "attestation should have package_version");
-    assert.ok(attestation.commit, "attestation should have commit");
-    assert.ok(attestation.node_version, "attestation should have node_version");
-    assert.ok(attestation.os, "attestation should have os");
-    assert.ok(attestation.schema_epoch, "attestation should have schema_epoch");
-
-    // v2: redactions.json must have the audit structure even when empty.
-    const redactions = JSON.parse(readFileSync(pack.files.redactions, "utf-8"));
-    assert.ok(Array.isArray(redactions.redactions), "redactions should be an array");
-    assert.equal(typeof redactions.total_redacted, "number", "total_redacted should be a number");
-  });
-
-  it("exports v2 structured artifacts and redacts secrets in diffstat", () => {
-    const secretValue = "ghp_1234567890abcdefghijklmnop";
-    // Create a task directory with file-stats.json containing a secret in a file path.
-    const taskDir = join(tempDir, ".patchwarden", "tasks", "task-v2-secret");
-    mkdirSync(taskDir, { recursive: true });
-    writeFileSync(join(taskDir, "file-stats.json"), JSON.stringify({
-      task_id: "task-v2-secret",
-      additions: 5,
-      deletions: 2,
-      files: [{
-        path: `secrets/${secretValue}.json`,
-        status: "modified",
-        additions: 5,
-        deletions: 2,
-      }],
-    }), "utf-8");
-
-    writeTaskLineage({
-      lineage_id: "lineage_v2_secret",
-      goal: "Export v2 evidence with diffstat",
-      repo_path: ".",
-      created_at: "2026-07-09T12:00:00.000Z",
-      updated_at: "2026-07-09T12:01:00.000Z",
-      final_status: "accepted",
-      stop_reason: "success",
-      next_action: "accept",
-      main_task: "task-v2-secret",
-      fix_tasks: [],
-      cleanup_tasks: [],
-      direct_sessions: [],
-      rounds: [{
-        iteration: 1,
-        task_id: "task-v2-secret",
-        role: "main",
-        status: "done_by_agent",
-        terminal: true,
-        verification_status: "passed",
-        audit_verdict: "pass",
-        fail_checks: [],
-        warn_checks: ["minor scope drift"],
-        next_action: "accept",
-      }],
-      warnings: [],
-      errors: [],
-      worktree: {
-        isolation_mode: "current_repo",
-        cleanup: "keep",
-        status: "not_used",
-        next_action: "none",
-      },
-    });
-
-    const pack = exportTaskEvidencePack({ lineage_id: "lineage_v2_secret" });
-
-    // All six v2 files should exist.
-    for (const key of ["risk", "verify", "diffstat", "lineage", "attestation", "redactions"] as const) {
-      assert.ok(existsSync(pack.files[key]), `${key} file should exist`);
-    }
-
-    // The original secret must not appear in any v2 file.
-    for (const key of ["risk", "verify", "diffstat", "lineage", "attestation", "redactions"] as const) {
-      const content = readFileSync(pack.files[key], "utf-8");
-      assert.ok(!content.includes(secretValue), `${key} should not contain the original secret value`);
-    }
-
-    // redactions.json should have detected the secret via diffstat aggregation.
-    const redactions = JSON.parse(readFileSync(pack.files.redactions, "utf-8"));
-    assert.ok(redactions.total_redacted > 0, "redactions.json should have detected the secret");
-    assert.ok(
-      !JSON.stringify(redactions).includes(secretValue),
-      "redactions.json should not contain the original secret value"
-    );
-
-    // risk.json should carry the warn_check as a medium-severity risk.
-    const risk = JSON.parse(readFileSync(pack.files.risk, "utf-8"));
-    assert.ok(risk.count > 0, "risk.json should have at least one risk item");
-    assert.equal(risk.by_severity.medium, 1, "should have one medium-severity risk");
-
-    // verify.json should carry the round verification record.
-    const verify = JSON.parse(readFileSync(pack.files.verify, "utf-8"));
-    assert.ok(verify.count > 0, "verify.json should have at least one record");
-    assert.equal(verify.records[0].verification_status, "passed");
-
-    // lineage.json should carry the bounded summary.
-    const lineageSummary = JSON.parse(readFileSync(pack.files.lineage, "utf-8"));
-    assert.equal(lineageSummary.lineage_id, "lineage_v2_secret");
-    assert.equal(lineageSummary.iterations_count, 1);
-    assert.equal(lineageSummary.final_status, "accepted");
-  });
-});

package/src/test/unit/get-task-status.test.ts

@@ -1,203 +0,0 @@
-import { describe, it, beforeEach, afterEach } from "node:test";
-import { strict as assert } from "node:assert";
-import { mkdtempSync, rmSync, mkdirSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { reloadConfig } from "../../config.js";
-import { getTaskStatus } from "../../tools/getTaskStatus.js";
-
-let tempDir: string;
-let tasksDir: string;
-let prevConfigEnv: string | undefined;
-
-function writeConfig(): void {
-  const configPath = join(tempDir, "patchwarden.config.json");
-  writeFileSync(
-    configPath,
-    JSON.stringify({
-      workspaceRoot: tempDir,
-      tasksDir: ".patchwarden/tasks",
-      plansDir: ".patchwarden/plans",
-      assessmentsDir: ".patchwarden/assessments",
-      directSessionsDir: ".patchwarden/direct-sessions",
-      agents: { codex: { command: "codex", args: ["exec", "{prompt}"] } },
-      allowedTestCommands: ["npm test"],
-    }),
-    "utf-8"
-  );
-  prevConfigEnv = process.env.PATCHWARDEN_CONFIG;
-  process.env.PATCHWARDEN_CONFIG = configPath;
-  reloadConfig();
-}
-
-function writeTaskStatus(taskId: string, status: Record<string, unknown>): string {
-  const taskDir = join(tasksDir, taskId);
-  mkdirSync(taskDir, { recursive: true });
-  writeFileSync(join(taskDir, "status.json"), JSON.stringify(status, null, 2), "utf-8");
-  return taskDir;
-}
-
-function writeTaskRuntime(taskDir: string, runtime: Record<string, unknown>): void {
-  writeFileSync(join(taskDir, "runtime.json"), JSON.stringify(runtime, null, 2), "utf-8");
-}
-
-describe("getTaskStatus", () => {
-  beforeEach(() => {
-    tempDir = mkdtempSync(join(tmpdir(), "pw-getstatus-"));
-    tasksDir = join(tempDir, ".patchwarden", "tasks");
-    mkdirSync(tasksDir, { recursive: true });
-    writeConfig();
-  });
-
-  afterEach(() => {
-    if (prevConfigEnv === undefined) delete process.env.PATCHWARDEN_CONFIG;
-    else process.env.PATCHWARDEN_CONFIG = prevConfigEnv;
-    reloadConfig();
-    rmSync(tempDir, { recursive: true, force: true });
-  });
-
-  // ── pending ──
-  it("reads pending status task", () => {
-    writeTaskStatus("task-pending-001", {
-      task_id: "task-pending-001",
-      plan_id: "plan-001",
-      agent: "codex",
-      workspace_root: tempDir,
-      repo_path: "repo",
-      resolved_repo_path: join(tempDir, "repo"),
-      status: "pending",
-      phase: "queued",
-      created_at: "2026-07-12T10:00:00Z",
-      updated_at: "2026-07-12T10:00:01Z",
-      timeout_seconds: 900,
-      error: null,
-    });
-
-    const result = getTaskStatus("task-pending-001");
-
-    assert.equal(result.task_id, "task-pending-001");
-    assert.equal(result.status, "pending");
-    assert.equal(result.phase, "queued");
-    assert.equal(result.agent, "codex");
-    assert.equal(result.plan_id, "plan-001");
-    assert.equal(result.error, null);
-    // No watcher heartbeat → watcher missing → pending task is execution_blocked
-    assert.equal(result.execution_blocked, true);
-    assert.equal(result.watcher_status, "missing");
-    assert.equal(result.pending_reason, "queued_but_watcher_missing");
-  });
-
-  // ── running ──
-  it("reads running status task and merges runtime.json", () => {
-    const taskDir = writeTaskStatus("task-running-001", {
-      task_id: "task-running-001",
-      plan_id: "plan-001",
-      agent: "codex",
-      workspace_root: tempDir,
-      repo_path: "repo",
-      resolved_repo_path: join(tempDir, "repo"),
-      status: "running",
-      phase: "executing_agent",
-      created_at: "2026-07-12T10:00:00Z",
-      started_at: "2026-07-12T10:00:05Z",
-      updated_at: "2026-07-12T10:00:10Z",
-      timeout_seconds: 900,
-      error: null,
-    });
-    writeTaskRuntime(taskDir, {
-      phase: "executing_agent",
-      last_heartbeat_at: "2026-07-12T10:00:12Z",
-      current_command: "codex exec --prompt",
-    });
-
-    const result = getTaskStatus("task-running-001");
-
-    assert.equal(result.status, "running");
-    assert.equal(result.phase, "executing_agent");
-    assert.equal(result.current_command, "codex exec --prompt");
-    assert.equal(result.last_heartbeat_at, "2026-07-12T10:00:12Z");
-    assert.equal(result.started_at, "2026-07-12T10:00:05Z");
-    // running (not pending) → execution_blocked is false
-    assert.equal(result.execution_blocked, false);
-    assert.equal(result.pending_reason, "agent_running");
-  });
-
-  // ── done ──
-  it("reads done status task", () => {
-    writeTaskStatus("task-done-001", {
-      task_id: "task-done-001",
-      plan_id: "plan-001",
-      agent: "codex",
-      workspace_root: tempDir,
-      repo_path: "repo",
-      resolved_repo_path: join(tempDir, "repo"),
-      status: "done",
-      phase: "completed",
-      created_at: "2026-07-12T10:00:00Z",
-      started_at: "2026-07-12T10:00:05Z",
-      finished_at: "2026-07-12T10:05:00Z",
-      updated_at: "2026-07-12T10:05:00Z",
-      timeout_seconds: 900,
-      verify_status: "passed",
-      error: null,
-    });
-
-    const result = getTaskStatus("task-done-001");
-
-    assert.equal(result.status, "done");
-    assert.equal(result.phase, "completed");
-    assert.equal(result.finished_at, "2026-07-12T10:05:00Z");
-    assert.equal(result.verify_status, "passed");
-    assert.equal(result.execution_blocked, false);
-    assert.equal(result.pending_reason, null);
-  });
-
-  // ── failed ──
-  it("reads failed status task", () => {
-    writeTaskStatus("task-failed-001", {
-      task_id: "task-failed-001",
-      plan_id: "plan-001",
-      agent: "codex",
-      workspace_root: tempDir,
-      repo_path: "repo",
-      resolved_repo_path: join(tempDir, "repo"),
-      status: "failed",
-      phase: "failed",
-      created_at: "2026-07-12T10:00:00Z",
-      started_at: "2026-07-12T10:00:05Z",
-      finished_at: "2026-07-12T10:05:00Z",
-      updated_at: "2026-07-12T10:05:00Z",
-      timeout_seconds: 900,
-      error: "Agent exited with code 1",
-    });
-
-    const result = getTaskStatus("task-failed-001");
-
-    assert.equal(result.status, "failed");
-    assert.equal(result.phase, "failed");
-    assert.equal(result.error, "Agent exited with code 1");
-    assert.equal(result.finished_at, "2026-07-12T10:05:00Z");
-    assert.equal(result.execution_blocked, false);
-  });
-
-  // ── status.json missing ──
-  it("throws when status.json is missing (task not found)", () => {
-    // guardReadPath throws "File not found" before the existsSync "Task not found" check
-    assert.throws(
-      () => getTaskStatus("non-existent-task"),
-      /(File not found|Task not found)/
-    );
-  });
-
-  // ── status.json corrupt ──
-  it("throws when status.json is corrupt", () => {
-    const taskDir = join(tasksDir, "task-corrupt-001");
-    mkdirSync(taskDir, { recursive: true });
-    writeFileSync(join(taskDir, "status.json"), "{not valid json", "utf-8");
-
-    assert.throws(
-      () => getTaskStatus("task-corrupt-001"),
-      SyntaxError
-    );
-  });
-});

package/src/test/unit/get-task-summary.test.ts

@@ -1,173 +0,0 @@
-import { describe, it, beforeEach, afterEach } from "node:test";
-import { strict as assert } from "node:assert";
-import { mkdtempSync, rmSync, mkdirSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { reloadConfig } from "../../config.js";
-import { getTaskSummary } from "../../tools/getTaskSummary.js";
-
-let tempDir: string;
-let tasksDir: string;
-let prevConfigEnv: string | undefined;
-
-function writeConfig(): void {
-  const configPath = join(tempDir, "patchwarden.config.json");
-  writeFileSync(
-    configPath,
-    JSON.stringify({
-      workspaceRoot: tempDir,
-      tasksDir: ".patchwarden/tasks",
-      plansDir: ".patchwarden/plans",
-      assessmentsDir: ".patchwarden/assessments",
-      directSessionsDir: ".patchwarden/direct-sessions",
-      agents: { codex: { command: "codex", args: ["exec", "{prompt}"] } },
-      allowedTestCommands: ["npm test"],
-    }),
-    "utf-8"
-  );
-  prevConfigEnv = process.env.PATCHWARDEN_CONFIG;
-  process.env.PATCHWARDEN_CONFIG = configPath;
-  reloadConfig();
-}
-
-function writeTaskStatus(taskId: string, status: Record<string, unknown>): string {
-  const taskDir = join(tasksDir, taskId);
-  mkdirSync(taskDir, { recursive: true });
-  writeFileSync(join(taskDir, "status.json"), JSON.stringify(status, null, 2), "utf-8");
-  return taskDir;
-}
-
-function baseStatus(taskId: string, overrides: Record<string, unknown> = {}): Record<string, unknown> {
-  return {
-    task_id: taskId,
-    plan_id: "plan-001",
-    agent: "codex",
-    workspace_root: tempDir,
-    repo_path: "repo",
-    resolved_repo_path: join(tempDir, "repo"),
-    created_at: "2026-07-12T10:00:00Z",
-    started_at: "2026-07-12T10:00:05Z",
-    finished_at: "2026-07-12T10:05:00Z",
-    updated_at: "2026-07-12T10:05:00Z",
-    timeout_seconds: 900,
-    error: null,
-    ...overrides,
-  };
-}
-
-describe("getTaskSummary", () => {
-  beforeEach(() => {
-    tempDir = mkdtempSync(join(tmpdir(), "pw-getsummary-"));
-    tasksDir = join(tempDir, ".patchwarden", "tasks");
-    mkdirSync(tasksDir, { recursive: true });
-    writeConfig();
-  });
-
-  afterEach(() => {
-    if (prevConfigEnv === undefined) delete process.env.PATCHWARDEN_CONFIG;
-    else process.env.PATCHWARDEN_CONFIG = prevConfigEnv;
-    reloadConfig();
-    rmSync(tempDir, { recursive: true, force: true });
-  });
-
-  // ── compact mode ──
-  it("returns compact summary in compact mode", () => {
-    writeTaskStatus("task-compact-001", baseStatus("task-compact-001", {
-      status: "done",
-      phase: "completed",
-      verify_status: "passed",
-    }));
-
-    const result = getTaskSummary("task-compact-001", { view: "compact" });
-
-    assert.equal(result.view, "compact");
-    assert.equal(result.task_id, "task-compact-001");
-    assert.equal(result.status, "done");
-    assert.equal(result.terminal, true);
-    // compact-only fields
-    assert.equal(typeof result.changed_files_total, "number");
-    assert.equal(typeof result.release_artifacts_count, "number");
-    assert.ok(result.artifact_hygiene);
-    assert.ok("max_items" in result.artifact_hygiene);
-  });
-
-  // ── full / standard mode ──
-  it("returns full summary in standard mode", () => {
-    writeTaskStatus("task-full-001", baseStatus("task-full-001", {
-      status: "done",
-      phase: "completed",
-      verify_status: "passed",
-    }));
-
-    const result = getTaskSummary("task-full-001");
-
-    // standard mode has no `view` field
-    assert.equal((result as unknown as { view?: string }).view, undefined);
-    assert.equal(result.task_id, "task-full-001");
-    assert.equal(result.status, "done");
-    assert.equal(result.terminal, true);
-    // full-mode-only fields
-    assert.ok("log_tails" in result);
-    assert.ok("artifacts" in result);
-    assert.ok("failed_command_detail" in result);
-    assert.ok("acceptance_reviewed_at" in result);
-  });
-
-  // ── task not found ──
-  it("throws when task does not exist", () => {
-    assert.throws(
-      () => getTaskSummary("non-existent-task"),
-      /(File not found|Task not found)/
-    );
-  });
-
-  // ── terminal: done ──
-  it("returns terminal summary for done task with passed verification", () => {
-    writeTaskStatus("task-done-001", baseStatus("task-done-001", {
-      status: "done",
-      phase: "completed",
-      verify_status: "passed",
-    }));
-
-    const result = getTaskSummary("task-done-001");
-
-    assert.equal(result.terminal, true);
-    assert.equal(result.status, "done");
-    assert.equal(result.verify_status, "passed");
-    // done + verify passed → ready_for_review
-    assert.equal(result.acceptance_status, "ready_for_review");
-  });
-
-  // ── terminal: failed ──
-  it("returns terminal summary for failed task", () => {
-    writeTaskStatus("task-failed-001", baseStatus("task-failed-001", {
-      status: "failed",
-      phase: "failed",
-      error: "Agent exited with code 1",
-    }));
-
-    const result = getTaskSummary("task-failed-001");
-
-    assert.equal(result.terminal, true);
-    assert.equal(result.status, "failed");
-    assert.equal(result.acceptance_status, "failed");
-    assert.ok(result.errors.includes("Agent exited with code 1"));
-  });
-
-  // ── running (non-terminal) ──
-  it("returns non-terminal summary for running task", () => {
-    writeTaskStatus("task-running-001", baseStatus("task-running-001", {
-      status: "running",
-      phase: "executing_agent",
-      started_at: "2026-07-12T10:00:00Z",
-      finished_at: undefined,
-    }));
-
-    const result = getTaskSummary("task-running-001");
-
-    assert.equal(result.terminal, false);
-    assert.equal(result.status, "running");
-    assert.equal(result.phase, "executing_agent");
-    assert.equal(result.acceptance_status, "pending");
-  });
-});