patchwarden 1.5.0 → 1.6.1

package/src/test/unit/subgoal-sync.test.ts

@@ -1,236 +0,0 @@
-import { describe, it, beforeEach, afterEach } from "node:test";
-import { strict as assert } from "node:assert";
-import { mkdtempSync, rmSync, mkdirSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { createGoal, readGoalStatus, writeGoalStatus } from "../../goal/goalStore.js";
-import { addSubgoal, updateSubgoalStatus } from "../../goal/goalStatus.js";
-import { syncSubgoalOnTaskDone, readTaskGoalMeta } from "../../goal/subgoalSync.js";
-
-// ── Helpers ───────────────────────────────────────────────────────
-
-let tempDir: string;
-
-beforeEach(() => {
-  tempDir = mkdtempSync(join(tmpdir(), "pw-subgoalsync-"));
-});
-
-afterEach(() => {
-  rmSync(tempDir, { recursive: true, force: true });
-});
-
-/**
- * 在 tempDir 下创建 goal，添加一个 subgoal 并置为 running，写回 goal_status.json。
- * 返回 goal_id 和 subgoalId。
- */
-function setupGoalWithRunningSubgoal(
-  title = "Test Goal"
-): { goalId: string; subgoalId: string } {
-  const { goal_id } = createGoal("repo", title, "desc", tempDir);
-  let status = readGoalStatus(goal_id, tempDir);
-  const { goalStatus: withSub, subgoalId } = addSubgoal(status, "First subgoal");
-  const withRunning = updateSubgoalStatus(withSub, subgoalId, "running");
-  writeGoalStatus(goal_id, withRunning, tempDir);
-  return { goalId: goal_id, subgoalId };
-}
-
-/** 创建一个假的 task 目录，写入 status.json（可包含 goal_id/subgoal_id）。 */
-function writeTaskStatus(
-  taskId: string,
-  fields: Record<string, unknown>
-): string {
-  const taskDir = join(tempDir, ".patchwarden", "tasks", taskId);
-  mkdirSync(taskDir, { recursive: true });
-  writeFileSync(
-    join(taskDir, "status.json"),
-    JSON.stringify({ task_id: taskId, ...fields }, null, 2),
-    "utf-8"
-  );
-  return taskDir;
-}
-
-// ── Tests ─────────────────────────────────────────────────────────
-
-describe("subgoalSync", () => {
-
-  describe("syncSubgoalOnTaskDone", () => {
-    it("无 goal_id/subgoal_id 直接返回（向后兼容）", () => {
-      const { goalId, subgoalId } = setupGoalWithRunningSubgoal();
-      // 不传 goal_id / subgoal_id
-      syncSubgoalOnTaskDone("task_001", { goal_id: null, subgoal_id: null }, tempDir);
-
-      // subgoal 状态不变
-      const status = readGoalStatus(goalId, tempDir);
-      assert.equal(status.subgoals[0].status, "running");
-    });
-
-    it("仅 goal_id 缺失直接返回", () => {
-      const { subgoalId } = setupGoalWithRunningSubgoal();
-      syncSubgoalOnTaskDone("task_001", { goal_id: null, subgoal_id: subgoalId }, tempDir);
-      // 不应抛错
-    });
-
-    it("仅 subgoal_id 缺失直接返回", () => {
-      const { goalId } = setupGoalWithRunningSubgoal();
-      syncSubgoalOnTaskDone("task_001", { goal_id: goalId, subgoal_id: null }, tempDir);
-      // 不应抛错
-    });
-
-    it("subgoal 状态为 running → 更新为 done_by_agent", () => {
-      const { goalId, subgoalId } = setupGoalWithRunningSubgoal();
-      syncSubgoalOnTaskDone("task_001", { goal_id: goalId, subgoal_id: subgoalId }, tempDir);
-
-      const status = readGoalStatus(goalId, tempDir);
-      assert.equal(status.subgoals[0].status, "done_by_agent");
-    });
-
-    it("subgoal 状态非 running（如 ready）→ 不更新", () => {
-      const { goal_id } = createGoal("repo", "Ready Goal", "desc", tempDir);
-      let status = readGoalStatus(goal_id, tempDir);
-      const { goalStatus: withSub, subgoalId } = addSubgoal(status, "Ready subgoal");
-      // 不做 running 转换，保持 ready
-      writeGoalStatus(goal_id, withSub, tempDir);
-
-      syncSubgoalOnTaskDone("task_001", { goal_id: goal_id, subgoal_id: subgoalId }, tempDir);
-
-      const after = readGoalStatus(goal_id, tempDir);
-      assert.equal(after.subgoals[0].status, "ready");
-    });
-
-    it("subgoal 状态为 done_by_agent → 不重复更新", () => {
-      const { goalId, subgoalId } = setupGoalWithRunningSubgoal();
-      // 第一次同步：running → done_by_agent
-      syncSubgoalOnTaskDone("task_001", { goal_id: goalId, subgoal_id: subgoalId }, tempDir);
-      // 第二次同步：done_by_agent 不应再变（running → done_by_agent 已完成，且 done_by_agent → done_by_agent 非法）
-      syncSubgoalOnTaskDone("task_001", { goal_id: goalId, subgoal_id: subgoalId }, tempDir);
-
-      const status = readGoalStatus(goalId, tempDir);
-      assert.equal(status.subgoals[0].status, "done_by_agent");
-    });
-
-    it("goal 不存在 → 不抛错（try/catch 隔离）", () => {
-      // 不抛错即通过
-      assert.doesNotThrow(() => {
-        syncSubgoalOnTaskDone(
-          "task_001",
-          { goal_id: "goal_nonexistent", subgoal_id: "subgoal-001" },
-          tempDir
-        );
-      });
-    });
-
-    it("subgoal 不存在 → 不抛错", () => {
-      const { goalId } = setupGoalWithRunningSubgoal();
-      assert.doesNotThrow(() => {
-        syncSubgoalOnTaskDone(
-          "task_001",
-          { goal_id: goalId, subgoal_id: "subgoal-999" },
-          tempDir
-        );
-      });
-      // 原 subgoal 不受影响
-      const status = readGoalStatus(goalId, tempDir);
-      assert.equal(status.subgoals[0].status, "running");
-    });
-
-    it("不传 workspaceRoot 时不抛错（使用默认 getConfig）", () => {
-      // 此测试验证向后兼容签名；默认 getConfig().workspaceRoot 指向 cwd，
-      // goal 不存在于那里，应被 try/catch 吞掉，不抛错。
-      const { goalId, subgoalId } = setupGoalWithRunningSubgoal();
-      assert.doesNotThrow(() => {
-        syncSubgoalOnTaskDone("task_001", { goal_id: goalId, subgoal_id: subgoalId });
-      });
-    });
-  });
-
-  describe("readTaskGoalMeta", () => {
-    it("正常读取 status.json 中的 goal_id/subgoal_id", () => {
-      const taskDir = writeTaskStatus("task_001", {
-        goal_id: "goal_20260101_test",
-        subgoal_id: "subgoal-001",
-      });
-      const meta = readTaskGoalMeta(taskDir);
-      assert.equal(meta.goal_id, "goal_20260101_test");
-      assert.equal(meta.subgoal_id, "subgoal-001");
-    });
-
-    it("status.json 不存在 → 返回 { null, null }", () => {
-      const taskDir = join(tempDir, ".patchwarden", "tasks", "nonexistent");
-      const meta = readTaskGoalMeta(taskDir);
-      assert.equal(meta.goal_id, null);
-      assert.equal(meta.subgoal_id, null);
-    });
-
-    it("status.json 无 goal_id/subgoal_id 字段 → 返回 { null, null }", () => {
-      const taskDir = writeTaskStatus("task_002", { status: "pending" });
-      const meta = readTaskGoalMeta(taskDir);
-      assert.equal(meta.goal_id, null);
-      assert.equal(meta.subgoal_id, null);
-    });
-
-    it("status.json 字段为非字符串 → 返回 { null, null }", () => {
-      const taskDir = writeTaskStatus("task_003", {
-        goal_id: 123,
-        subgoal_id: null,
-      });
-      const meta = readTaskGoalMeta(taskDir);
-      assert.equal(meta.goal_id, null);
-      assert.equal(meta.subgoal_id, null);
-    });
-
-    it("status.json 为损坏 JSON → 返回 { null, null }", () => {
-      const taskDir = join(tempDir, ".patchwarden", "tasks", "task_004");
-      mkdirSync(taskDir, { recursive: true });
-      writeFileSync(join(taskDir, "status.json"), "{ not valid json", "utf-8");
-      const meta = readTaskGoalMeta(taskDir);
-      assert.equal(meta.goal_id, null);
-      assert.equal(meta.subgoal_id, null);
-    });
-
-    it("仅 goal_id 字段存在 → subgoal_id 为 null", () => {
-      const taskDir = writeTaskStatus("task_005", { goal_id: "goal_x" });
-      const meta = readTaskGoalMeta(taskDir);
-      assert.equal(meta.goal_id, "goal_x");
-      assert.equal(meta.subgoal_id, null);
-    });
-  });
-
-  describe("end-to-end: task 完成 → subgoal 同步", () => {
-    it("模拟 reconcileTasks done_by_agent 流程：task status.json 写入后同步 subgoal", () => {
-      const { goalId, subgoalId } = setupGoalWithRunningSubgoal();
-      const taskId = "task_20260101_abc123";
-
-      // 模拟 createTask 写入 task status.json（含 goal_id/subgoal_id）
-      const taskDir = writeTaskStatus(taskId, {
-        status: "pending",
-        goal_id: goalId,
-        subgoal_id: subgoalId,
-      });
-
-      // 模拟 reconcileTasks 将状态置为 done_by_agent 后调用同步
-      const meta = readTaskGoalMeta(taskDir);
-      assert.equal(meta.subgoal_id, subgoalId);
-      syncSubgoalOnTaskDone(taskId, meta, tempDir);
-
-      // 验证 subgoal 状态已同步为 done_by_agent
-      const status = readGoalStatus(goalId, tempDir);
-      assert.equal(status.subgoals[0].status, "done_by_agent");
-    });
-
-    it("无关联的 task 完成 → subgoal 状态不变", () => {
-      const { goalId, subgoalId } = setupGoalWithRunningSubgoal();
-      const taskId = "task_20260101_nogoal";
-
-      // task 没有 goal_id/subgoal_id 关联
-      const taskDir = writeTaskStatus(taskId, { status: "pending" });
-      const meta = readTaskGoalMeta(taskDir);
-      assert.equal(meta.subgoal_id, null);
-
-      // 即便误调用同步，也不会影响 subgoal
-      syncSubgoalOnTaskDone(taskId, meta, tempDir);
-
-      const status = readGoalStatus(goalId, tempDir);
-      assert.equal(status.subgoals[0].status, "running");
-    });
-  });
-});

package/src/test/unit/sync-file.test.ts

@@ -1,231 +0,0 @@
-import { describe, it, beforeEach, afterEach } from "node:test";
-import { strict as assert } from "node:assert";
-import { mkdtempSync, rmSync, mkdirSync, writeFileSync, readFileSync, existsSync } from "node:fs";
-import { join, resolve } from "node:path";
-import { tmpdir } from "node:os";
-import { syncFile } from "../../tools/syncFile.js";
-import { computeFileSha256 } from "../../direct/directPatch.js";
-import type { PatchWardenConfig } from "../../config.js";
-
-function makeConfig(workspaceRoot: string): PatchWardenConfig {
-  return {
-    workspaceRoot,
-    plansDir: ".patchwarden/plans",
-    tasksDir: ".patchwarden/tasks",
-    assessmentsDir: ".patchwarden/assessments",
-    assessmentTtlSeconds: 3600,
-    agents: { codex: { command: "codex", args: ["exec", "{prompt}"] } },
-    allowedTestCommands: ["npm test"],
-    repoAllowedTestCommands: {},
-    maxReadFileBytes: 200_000,
-    defaultTaskTimeoutSeconds: 900,
-    maxTaskTimeoutSeconds: 3600,
-    watcherStaleSeconds: 30,
-    directSessionsDir: ".patchwarden/direct-sessions",
-    directSessionTtlSeconds: 3600,
-    directMaxPatchBytes: 200_000,
-    directMaxFileBytes: 500_000,
-  };
-}
-
-describe("syncFile", () => {
-  let tempDir: string;
-  let config: PatchWardenConfig;
-  let repoPath: string;
-  let sessionsDir: string;
-  let sessionId: string;
-
-  beforeEach(() => {
-    tempDir = mkdtempSync(join(tmpdir(), "pw-syncfile-"));
-    config = makeConfig(tempDir);
-    repoPath = join(tempDir, "my-repo");
-    sessionsDir = join(tempDir, ".patchwarden", "direct-sessions");
-    sessionId = "test-session-001";
-
-    mkdirSync(repoPath, { recursive: true });
-    mkdirSync(join(sessionsDir, sessionId), { recursive: true });
-
-    writeFileSync(
-      join(sessionsDir, sessionId, "session.json"),
-      JSON.stringify({
-        session_id: sessionId,
-        repo_path: repoPath,
-        status: "active",
-        created_at: new Date().toISOString(),
-      }),
-      "utf-8"
-    );
-  });
-
-  afterEach(() => {
-    rmSync(tempDir, { recursive: true, force: true });
-  });
-
-  it("copies a file from source to target", () => {
-    const sourceContent = "console.log('hello world');";
-    mkdirSync(join(repoPath, "mobile_app"), { recursive: true });
-    writeFileSync(join(repoPath, "mobile_app", "app.js"), sourceContent, "utf-8");
-
-    const result = syncFile(sessionId, "mobile_app/app.js", "windows_app/app/app.js", undefined, config);
-
-    assert.equal(result.changed, true);
-    assert.equal(result.copied_bytes, sourceContent.length);
-    assert.equal(result.before_target_sha256, null);
-    assert.ok(result.after_target_sha256);
-
-    const targetContent = readFileSync(join(repoPath, "windows_app", "app", "app.js"), "utf-8");
-    assert.equal(targetContent, sourceContent);
-  });
-
-  it("returns changed=false when target already has same content", () => {
-    const sourceContent = "same content";
-    mkdirSync(join(repoPath, "src"), { recursive: true });
-    mkdirSync(join(repoPath, "dst"), { recursive: true });
-    writeFileSync(join(repoPath, "src", "file.ts"), sourceContent, "utf-8");
-    writeFileSync(join(repoPath, "dst", "file.ts"), sourceContent, "utf-8");
-
-    const result = syncFile(sessionId, "src/file.ts", "dst/file.ts", undefined, config);
-
-    assert.equal(result.changed, false);
-    assert.ok(result.before_target_sha256);
-    assert.equal(result.before_target_sha256, result.after_target_sha256);
-  });
-
-  it("returns changed=true when target has different content", () => {
-    mkdirSync(join(repoPath, "src"), { recursive: true });
-    mkdirSync(join(repoPath, "dst"), { recursive: true });
-    writeFileSync(join(repoPath, "src", "file.ts"), "new content", "utf-8");
-    writeFileSync(join(repoPath, "dst", "file.ts"), "old content", "utf-8");
-
-    const result = syncFile(sessionId, "src/file.ts", "dst/file.ts", undefined, config);
-
-    assert.equal(result.changed, true);
-    assert.notEqual(result.before_target_sha256, result.after_target_sha256);
-  });
-
-  it("rejects source path outside repo", () => {
-    mkdirSync(join(repoPath, "src"), { recursive: true });
-    writeFileSync(join(repoPath, "src", "file.ts"), "content", "utf-8");
-
-    assert.throws(
-      () => syncFile(sessionId, "../../../etc/passwd", "dst/file.ts", undefined, config),
-      Error
-    );
-  });
-
-  it("rejects target path outside repo", () => {
-    mkdirSync(join(repoPath, "src"), { recursive: true });
-    writeFileSync(join(repoPath, "src", "file.ts"), "content", "utf-8");
-
-    assert.throws(
-      () => syncFile(sessionId, "src/file.ts", "../../../etc/evil", undefined, config),
-      Error
-    );
-  });
-
-  it("rejects sensitive source files", () => {
-    writeFileSync(join(repoPath, ".env"), "SECRET=abc123", "utf-8");
-
-    assert.throws(
-      () => syncFile(sessionId, ".env", "dst/.env", undefined, config),
-      Error
-    );
-  });
-
-  it("rejects sensitive target files", () => {
-    mkdirSync(join(repoPath, "src"), { recursive: true });
-    writeFileSync(join(repoPath, "src", "file.ts"), "content", "utf-8");
-
-    assert.throws(
-      () => syncFile(sessionId, "src/file.ts", "config.json", undefined, config),
-      Error
-    );
-  });
-
-  it("rejects writing to node_modules", () => {
-    mkdirSync(join(repoPath, "src"), { recursive: true });
-    writeFileSync(join(repoPath, "src", "file.ts"), "content", "utf-8");
-
-    assert.throws(
-      () => syncFile(sessionId, "src/file.ts", "node_modules/evil/index.js", undefined, config),
-      Error
-    );
-  });
-
-  it("rejects writing to dist", () => {
-    mkdirSync(join(repoPath, "src"), { recursive: true });
-    writeFileSync(join(repoPath, "src", "file.ts"), "content", "utf-8");
-
-    assert.throws(
-      () => syncFile(sessionId, "src/file.ts", "dist/main.js", undefined, config),
-      Error
-    );
-  });
-
-  it("rejects non-existent session", () => {
-    mkdirSync(join(repoPath, "src"), { recursive: true });
-    writeFileSync(join(repoPath, "src", "file.ts"), "content", "utf-8");
-
-    assert.throws(
-      () => syncFile("non-existent-session", "src/file.ts", "dst/file.ts", undefined, config),
-      Error
-    );
-  });
-
-  it("rejects non-existent source file", () => {
-    assert.throws(
-      () => syncFile(sessionId, "non-existent/file.ts", "dst/file.ts", undefined, config),
-      Error
-    );
-  });
-
-  it("validates expected_source_sha256", () => {
-    mkdirSync(join(repoPath, "src"), { recursive: true });
-    writeFileSync(join(repoPath, "src", "file.ts"), "content", "utf-8");
-
-    const correctHash = computeFileSha256(join(repoPath, "src", "file.ts"));
-
-    const result = syncFile(sessionId, "src/file.ts", "dst/file.ts", {
-      expected_source_sha256: correctHash,
-    }, config);
-    assert.equal(result.source_sha256, correctHash);
-
-    assert.throws(
-      () => syncFile(sessionId, "src/file.ts", "dst2/file.ts", {
-        expected_source_sha256: "wronghash",
-      }, config),
-      Error
-    );
-  });
-
-  it("validates expected_target_sha256", () => {
-    mkdirSync(join(repoPath, "src"), { recursive: true });
-    mkdirSync(join(repoPath, "dst"), { recursive: true });
-    writeFileSync(join(repoPath, "src", "file.ts"), "new content", "utf-8");
-    writeFileSync(join(repoPath, "dst", "file.ts"), "old content", "utf-8");
-
-    const correctTargetHash = computeFileSha256(join(repoPath, "dst", "file.ts"));
-
-    const result = syncFile(sessionId, "src/file.ts", "dst/file.ts", {
-      expected_target_sha256: correctTargetHash,
-    }, config);
-    assert.equal(result.before_target_sha256, correctTargetHash);
-
-    assert.throws(
-      () => syncFile(sessionId, "src/file.ts", "dst/file.ts", {
-        expected_target_sha256: "wronghash",
-      }, config),
-      Error
-    );
-  });
-
-  it("creates target directory if it doesn't exist", () => {
-    mkdirSync(join(repoPath, "src"), { recursive: true });
-    writeFileSync(join(repoPath, "src", "file.ts"), "content", "utf-8");
-
-    const result = syncFile(sessionId, "src/file.ts", "deep/nested/path/file.ts", undefined, config);
-
-    assert.equal(result.changed, true);
-    assert.ok(existsSync(join(repoPath, "deep", "nested", "path", "file.ts")));
-  });
-});