patchright-core 1.49.2 → 1.50.0

package/ThirdPartyNotices.txt

@@ -6,7 +6,7 @@ This project incorporates components from the projects listed below. The origina
 
 -	@types/node@17.0.24 (https://github.com/DefinitelyTyped/DefinitelyTyped)
 -	@types/yauzl@2.10.0 (https://github.com/DefinitelyTyped/DefinitelyTyped)
--	agent-base@7.1.1 (https://github.com/TooTallNate/proxy-agents)
+-	agent-base@7.1.3 (https://github.com/TooTallNate/proxy-agents)
 -	balanced-match@1.0.2 (https://github.com/juliangruber/balanced-match)
 -	brace-expansion@1.1.11 (https://github.com/juliangruber/brace-expansion)
 -	buffer-crc32@0.2.13 (https://github.com/brianloveswords/buffer-crc32)
@@ -24,7 +24,7 @@ This project incorporates components from the projects listed below. The origina
 -	fd-slicer@1.1.0 (https://github.com/andrewrk/node-fd-slicer)
 -	get-stream@5.2.0 (https://github.com/sindresorhus/get-stream)
 -	graceful-fs@4.2.10 (https://github.com/isaacs/node-graceful-fs)
--	https-proxy-agent@7.0.5 (https://github.com/TooTallNate/proxy-agents)
+-	https-proxy-agent@7.0.6 (https://github.com/TooTallNate/proxy-agents)
 -	ip-address@9.0.5 (https://github.com/beaugunderson/ip-address)
 -	is-docker@2.2.1 (https://github.com/sindresorhus/is-docker)
 -	is-wsl@2.2.0 (https://github.com/sindresorhus/is-wsl)
@@ -43,7 +43,7 @@ This project incorporates components from the projects listed below. The origina
 -	retry@0.12.0 (https://github.com/tim-kos/node-retry)
 -	signal-exit@3.0.7 (https://github.com/tapjs/signal-exit)
 -	smart-buffer@4.2.0 (https://github.com/JoshGlazebrook/smart-buffer)
--	socks-proxy-agent@8.0.4 (https://github.com/TooTallNate/proxy-agents)
+-	socks-proxy-agent@8.0.5 (https://github.com/TooTallNate/proxy-agents)
 -	socks@2.8.3 (https://github.com/JoshGlazebrook/socks)
 -	sprintf-js@1.1.3 (https://github.com/alexei/sprintf.js)
 -	stack-utils@2.0.5 (https://github.com/tapjs/stack-utils)
@@ -105,7 +105,7 @@ MIT License
 =========================================
 END OF @types/yauzl@2.10.0 AND INFORMATION
 
-%% agent-base@7.1.1 NOTICES AND INFORMATION BEGIN HERE
+%% agent-base@7.1.3 NOTICES AND INFORMATION BEGIN HERE
 =========================================
 (The MIT License)
 
@@ -130,7 +130,7 @@ CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
 TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
 SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 =========================================
-END OF agent-base@7.1.1 AND INFORMATION
+END OF agent-base@7.1.3 AND INFORMATION
 
 %% balanced-match@1.0.2 NOTICES AND INFORMATION BEGIN HERE
 =========================================
@@ -542,7 +542,7 @@ IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 =========================================
 END OF graceful-fs@4.2.10 AND INFORMATION
 
-%% https-proxy-agent@7.0.5 NOTICES AND INFORMATION BEGIN HERE
+%% https-proxy-agent@7.0.6 NOTICES AND INFORMATION BEGIN HERE
 =========================================
 (The MIT License)
 
@@ -567,7 +567,7 @@ CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
 TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
 SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 =========================================
-END OF https-proxy-agent@7.0.5 AND INFORMATION
+END OF https-proxy-agent@7.0.6 AND INFORMATION
 
 %% ip-address@9.0.5 NOTICES AND INFORMATION BEGIN HERE
 =========================================
@@ -1005,7 +1005,7 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 =========================================
 END OF smart-buffer@4.2.0 AND INFORMATION
 
-%% socks-proxy-agent@8.0.4 NOTICES AND INFORMATION BEGIN HERE
+%% socks-proxy-agent@8.0.5 NOTICES AND INFORMATION BEGIN HERE
 =========================================
 (The MIT License)
 
@@ -1030,7 +1030,7 @@ CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
 TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
 SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 =========================================
-END OF socks-proxy-agent@8.0.4 AND INFORMATION
+END OF socks-proxy-agent@8.0.5 AND INFORMATION
 
 %% socks@2.8.3 NOTICES AND INFORMATION BEGIN HERE
 =========================================

package/bin/reinstall_msedge_beta_linux.sh

@@ -32,6 +32,12 @@ if ! command -v curl >/dev/null; then
   apt-get install -y curl
 fi
 
+# GnuPG is not preinstalled in slim images
+if ! command -v gpg >/dev/null; then
+  apt-get update
+  apt-get install -y gpg
+fi
+
 # 3. Add the GPG key, the apt repo, update the apt cache, and install the package
 curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /tmp/microsoft.gpg
 install -o root -g root -m 644 /tmp/microsoft.gpg /etc/apt/trusted.gpg.d/

package/bin/reinstall_msedge_dev_linux.sh

@@ -32,6 +32,12 @@ if ! command -v curl >/dev/null; then
   apt-get install -y curl
 fi
 
+# GnuPG is not preinstalled in slim images
+if ! command -v gpg >/dev/null; then
+  apt-get update
+  apt-get install -y gpg
+fi
+
 # 3. Add the GPG key, the apt repo, update the apt cache, and install the package
 curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /tmp/microsoft.gpg
 install -o root -g root -m 644 /tmp/microsoft.gpg /etc/apt/trusted.gpg.d/

package/bin/reinstall_msedge_stable_linux.sh

@@ -32,6 +32,12 @@ if ! command -v curl >/dev/null; then
   apt-get install -y curl
 fi
 
+# GnuPG is not preinstalled in slim images
+if ! command -v gpg >/dev/null; then
+  apt-get update
+  apt-get install -y gpg
+fi
+
 # 3. Add the GPG key, the apt repo, update the apt cache, and install the package
 curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /tmp/microsoft.gpg
 install -o root -g root -m 644 /tmp/microsoft.gpg /etc/apt/trusted.gpg.d/

package/browsers.json

@@ -3,39 +3,35 @@
   "browsers": [
     {
       "name": "chromium",
-      "revision": "1148",
+      "revision": "1155",
       "installByDefault": true,
-      "browserVersion": "131.0.6778.33"
-    },
-    {
-      "name": "chromium-headless-shell",
-      "revision": "1148",
-      "installByDefault": true,
-      "browserVersion": "131.0.6778.33"
+      "browserVersion": "133.0.6943.16"
     },
     {
       "name": "chromium-tip-of-tree",
-      "revision": "1277",
+      "revision": "1293",
       "installByDefault": false,
-      "browserVersion": "132.0.6834.0"
+      "browserVersion": "133.0.6943.0"
     },
     {
       "name": "firefox",
-      "revision": "1466",
+      "revision": "1471",
       "installByDefault": true,
-      "browserVersion": "132.0"
+      "browserVersion": "134.0"
     },
     {
       "name": "firefox-beta",
-      "revision": "1465",
+      "revision": "1467",
       "installByDefault": false,
-      "browserVersion": "132.0b8"
+      "browserVersion": "133.0b9"
     },
     {
       "name": "webkit",
-      "revision": "2104",
+      "revision": "2123",
       "installByDefault": true,
       "revisionOverrides": {
+        "debian11-x64": "2105",
+        "debian11-arm64": "2105",
         "mac10.14": "1446",
         "mac10.15": "1616",
         "mac11": "1816",
@@ -49,13 +45,18 @@
     },
     {
       "name": "ffmpeg",
-      "revision": "1010",
+      "revision": "1011",
       "installByDefault": true,
       "revisionOverrides": {
         "mac12": "1010",
         "mac12-arm64": "1010"
       }
     },
+    {
+      "name": "winldd",
+      "revision": "1007",
+      "installByDefault": false
+    },
     {
       "name": "android",
       "revision": "1001",

package/lib/androidServerImpl.js

@@ -39,7 +39,7 @@ class AndroidServerLauncherImpl {
     if (devices.length === 0) throw new Error('No devices found');
     if (options.deviceSerialNumber) {
       devices = devices.filter(d => d.serial === options.deviceSerialNumber);
-      if (devices.length === 0) throw new Error(`No device with serial number '${options.deviceSerialNumber}' not found`);
+      if (devices.length === 0) throw new Error(`No device with serial number '${options.deviceSerialNumber}' was found`);
     }
     if (devices.length > 1) throw new Error(`More than one device found. Please specify deviceSerialNumber`);
     const device = devices[0];

package/lib/cli/program.js

@@ -16,7 +16,6 @@ var _utilsBundle = require("../utilsBundle");
 var _driver = require("./driver");
 var _traceViewer = require("../server/trace/viewer/traceViewer");
 var playwright = _interopRequireWildcard(require("../.."));
-var _child_process = require("child_process");
 var _utils = require("../utils");
 var _server = require("../server");
 var _errors = require("../client/errors");
@@ -56,7 +55,7 @@ Examples:
 
   $ open
   $ open -b webkit https://example.com`);
-commandWithOpenOptions('codegen [url]', 'open page and generate code for user actions', [['-o, --output <file name>', 'saves the generated script to a file'], ['--target <language>', `language to generate, one of javascript, playwright-test, python, python-async, python-pytest, csharp, csharp-mstest, csharp-nunit, java, java-junit`, codegenId()], ['--save-trace <filename>', 'record a trace for the session and save it to a file'], ['--test-id-attribute <attributeName>', 'use the specified attribute to generate data test ID selectors']]).action(function (url, options) {
+commandWithOpenOptions('codegen [url]', 'open page and generate code for user actions', [['-o, --output <file name>', 'saves the generated script to a file'], ['--target <language>', `language to generate, one of javascript, playwright-test, python, python-async, python-pytest, csharp, csharp-mstest, csharp-nunit, java, java-junit`, codegenId()], ['--test-id-attribute <attributeName>', 'use the specified attribute to generate data test ID selectors']]).action(function (url, options) {
   codegen(options, url).catch(logErrorAndExit);
 }).addHelpText('afterAll', `
 Examples:
@@ -64,21 +63,6 @@ Examples:
   $ codegen
   $ codegen --target=python
   $ codegen -b webkit https://example.com`);
-_utilsBundle.program.command('debug <app> [args...]', {
-  hidden: true
-}).description('run command in debug mode: disable timeout, open inspector').allowUnknownOption(true).action(function (app, options) {
-  (0, _child_process.spawn)(app, options, {
-    env: {
-      ...process.env,
-      PWDEBUG: '1'
-    },
-    stdio: 'inherit'
-  });
-}).addHelpText('afterAll', `
-Examples:
-
-  $ debug node test.js
-  $ debug npm run test`);
 function suggestedBrowsersToInstall() {
   return _server.registry.executables().filter(e => e.installType !== 'none' && e.type !== 'tool').map(e => e.name).join(', ');
 }
@@ -105,6 +89,7 @@ function checkBrowsersToInstall(args, options) {
       handleArgument(arg);
     }
   }
+  if (process.platform === 'win32') executables.push(_server.registry.findExecutable('winldd'));
   if (faultyArguments.length) throw new Error(`Invalid installation targets: ${faultyArguments.map(name => `'${name}'`).join(', ')}. Expecting one of: ${suggestedBrowsersToInstall()}`);
   return executables;
 }
@@ -221,9 +206,7 @@ _utilsBundle.program.command('run-driver', {
 }).action(function (options) {
   (0, _driver.runDriver)();
 });
-_utilsBundle.program.command('run-server', {
-  hidden: true
-}).option('--port <port>', 'Server port').option('--host <host>', 'Server host').option('--path <path>', 'Endpoint Path', '/').option('--max-clients <maxClients>', 'Maximum clients').option('--mode <mode>', 'Server mode, either "default" or "extension"').action(function (options) {
+_utilsBundle.program.command('run-server').option('--port <port>', 'Server port').option('--host <host>', 'Server host').option('--path <path>', 'Endpoint Path', '/').option('--max-clients <maxClients>', 'Maximum clients').option('--mode <mode>', 'Server mode, either "default" or "extension"').action(function (options) {
   (0, _driver.runServer)({
     port: options.port ? +options.port : undefined,
     host: options.host,
@@ -317,13 +300,14 @@ async function launchContext(options, extraOptions) {
   // Viewport size
   if (options.viewportSize) {
     try {
-      const [width, height] = options.viewportSize.split(',').map(n => parseInt(n, 10));
+      const [width, height] = options.viewportSize.split(',').map(n => +n);
+      if (isNaN(width) || isNaN(height)) throw new Error('bad values');
       contextOptions.viewport = {
         width,
         height
       };
     } catch (e) {
-      throw new Error('Invalid viewport size format: use "width, height", for example --viewport-size=800,600');
+      throw new Error('Invalid viewport size format: use "width,height", for example --viewport-size="800,600"');
     }
   }
 
@@ -383,9 +367,6 @@ async function launchContext(options, extraOptions) {
     // a temporary page and we call closeBrowser again when that page closes.
     if (closingBrowser) return;
     closingBrowser = true;
-    if (options.saveTrace) await context.tracing.stop({
-      path: options.saveTrace
-    });
     if (options.saveStorage) await context.storageState({
       path: options.saveStorage
     }).catch(e => null);
@@ -408,10 +389,6 @@ async function launchContext(options, extraOptions) {
   const timeout = options.timeout ? parseInt(options.timeout, 10) : 0;
   context.setDefaultTimeout(timeout);
   context.setDefaultNavigationTimeout(timeout);
-  if (options.saveTrace) await context.tracing.start({
-    screenshots: true,
-    snapshots: true
-  });
 
   // Omit options that we add automatically for presentation purpose.
   delete launchOptions.headless;
@@ -486,7 +463,6 @@ async function codegen(options, url) {
     device: options.device,
     saveStorage: options.saveStorage,
     mode: 'recording',
-    codegenMode: process.env.PW_RECORDER_IS_TRACE_VIEWER ? 'trace-events' : 'actions',
     testIdAttributeName,
     outputFile: outputFile ? _path.default.resolve(outputFile) : undefined,
     handleSIGINT: false

package/lib/client/channelOwner.js

@@ -126,30 +126,21 @@ class ChannelOwner extends _eventEmitter.EventEmitter {
           if (validator) {
             return async params => {
               return await this._wrapApiCall(async apiZone => {
-                const {
-                  apiName,
-                  frames,
-                  csi,
-                  callCookie,
-                  stepId
-                } = apiZone.reported ? {
-                  apiName: undefined,
-                  csi: undefined,
-                  callCookie: undefined,
-                  frames: [],
-                  stepId: undefined
-                } : apiZone;
-                apiZone.reported = true;
-                let currentStepId = stepId;
-                if (csi && apiName) {
-                  const out = {};
-                  csi.onApiCallBegin(apiName, params, frames, callCookie, out);
-                  currentStepId = out.stepId;
-                }
-                return await this._connection.sendMessageToServer(this, prop, validator(params, '', {
+                const validatedParams = validator(params, '', {
                   tChannelImpl: tChannelImplToWire,
                   binary: this._connection.rawBuffers() ? 'buffer' : 'toBase64'
-                }), apiName, frames, currentStepId);
+                });
+                if (!apiZone.isInternal && !apiZone.reported) {
+                  // Reporting/tracing/logging this api call for the first time.
+                  apiZone.params = params;
+                  apiZone.reported = true;
+                  this._instrumentation.onApiCallBegin(apiZone);
+                  logApiCall(this._logger, `=> ${apiZone.apiName} started`);
+                  return await this._connection.sendMessageToServer(this, prop, validatedParams, apiZone.apiName, apiZone.frames, apiZone.stepId);
+                }
+                // Since this api call is either internal, or has already been reported/traced once,
+                // passing undefined apiName will avoid an extra unneeded tracing entry.
+                return await this._connection.sendMessageToServer(this, prop, validatedParams, undefined, [], undefined);
               });
             };
           }
@@ -162,45 +153,35 @@ class ChannelOwner extends _eventEmitter.EventEmitter {
   }
   async _wrapApiCall(func, isInternal) {
     const logger = this._logger;
-    const apiZone = _zones.zones.zoneData('apiZone');
-    if (apiZone) return await func(apiZone);
-    const stackTrace = (0, _stackTrace.captureLibraryStackTrace)();
-    let apiName = stackTrace.apiName;
-    const frames = stackTrace.frames;
+    const existingApiZone = _zones.zones.zoneData('apiZone');
+    if (existingApiZone) return await func(existingApiZone);
     if (isInternal === undefined) isInternal = this._isInternalType;
-    if (isInternal) apiName = undefined;
-
-    // Enclosing zone could have provided the apiName and wallTime.
-    const expectZone = _zones.zones.zoneData('expectZone');
-    const stepId = expectZone === null || expectZone === void 0 ? void 0 : expectZone.stepId;
-    if (!isInternal && expectZone) apiName = expectZone.title;
-
-    // If we are coming from the expectZone, there is no need to generate a new
-    // step for the API call, since it will be generated by the expect itself.
-    const csi = isInternal || expectZone ? undefined : this._instrumentation;
-    const callCookie = {};
+    const stackTrace = (0, _stackTrace.captureLibraryStackTrace)();
+    const apiZone = {
+      apiName: stackTrace.apiName,
+      frames: stackTrace.frames,
+      isInternal,
+      reported: false,
+      userData: undefined,
+      stepId: undefined
+    };
     try {
-      logApiCall(logger, `=> ${apiName} started`, isInternal);
-      const apiZone = {
-        apiName,
-        frames,
-        isInternal,
-        reported: false,
-        csi,
-        callCookie,
-        stepId
-      };
       const result = await _zones.zones.run('apiZone', apiZone, async () => await func(apiZone));
-      csi === null || csi === void 0 || csi.onApiCallEnd(callCookie);
-      logApiCall(logger, `<= ${apiName} succeeded`, isInternal);
+      if (!isInternal) {
+        logApiCall(logger, `<= ${apiZone.apiName} succeeded`);
+        this._instrumentation.onApiCallEnd(apiZone);
+      }
       return result;
     } catch (e) {
       const innerError = (process.env.PWDEBUGIMPL || (0, _utils.isUnderTest)()) && e.stack ? '\n<inner error>\n' + e.stack : '';
-      if (apiName && !apiName.includes('<anonymous>')) e.message = apiName + ': ' + e.message;
+      if (apiZone.apiName && !apiZone.apiName.includes('<anonymous>')) e.message = apiZone.apiName + ': ' + e.message;
       const stackFrames = '\n' + (0, _stackTrace.stringifyStackFrames)(stackTrace.frames).join('\n') + innerError;
       if (stackFrames.trim()) e.stack = e.message + stackFrames;else e.stack = '';
-      csi === null || csi === void 0 || csi.onApiCallEnd(callCookie, e);
-      logApiCall(logger, `<= ${apiName} failed`, isInternal);
+      if (!isInternal) {
+        apiZone.error = e;
+        logApiCall(logger, `<= ${apiZone.apiName} failed`);
+        this._instrumentation.onApiCallEnd(apiZone);
+      }
       throw e;
     }
   }
@@ -220,8 +201,7 @@ class ChannelOwner extends _eventEmitter.EventEmitter {
   }
 }
 exports.ChannelOwner = ChannelOwner;
-function logApiCall(logger, message, isNested) {
-  if (isNested) return;
+function logApiCall(logger, message) {
   if (logger && logger.isEnabled('api', 'info')) logger.log('api', 'info', message, [], {
     color: 'cyan'
   });

package/lib/client/clientInstrumentation.js

@@ -20,6 +20,8 @@ exports.createInstrumentation = createInstrumentation;
  * limitations under the License.
  */
 
+// Instrumentation can mutate the data, for example change apiName or stepId.
+
 function createInstrumentation() {
   const listeners = [];
   return new Proxy({}, {

package/lib/client/connection.js

@@ -76,9 +76,9 @@ class Connection extends _events.EventEmitter {
     this.toImpl = void 0;
     this._tracingCount = 0;
     this._instrumentation = void 0;
-    this._rootObject = new Root(this);
-    this._localUtils = localUtils;
     this._instrumentation = instrumentation || (0, _clientInstrumentation.createInstrumentation)();
+    this._localUtils = localUtils;
+    this._rootObject = new Root(this);
   }
   markAsRemote() {
     this._isRemote = true;
@@ -140,7 +140,7 @@ class Connection extends _events.EventEmitter {
     }).catch(() => {});
     // We need to exit zones before calling into the server, otherwise
     // when we receive events from the server, we would be in an API zone.
-    _utils.zones.exitZones(() => this.onmessage({
+    _utils.zones.empty().run(() => this.onmessage({
       ...message,
       metadata
     }));

package/lib/client/network.js

@@ -50,6 +50,7 @@ class Request extends _channelOwner.ChannelOwner {
     this._actualHeadersPromise = void 0;
     this._timing = void 0;
     this._fallbackOverrides = {};
+    this.markAsInternalType();
     this._redirectedFrom = Request.fromNullable(initializer.redirectedFrom);
     if (this._redirectedFrom) this._redirectedFrom._redirectedTo = this;
     this._provisionalHeaders = new RawHeaders(initializer.headers);
@@ -510,6 +511,7 @@ class Response extends _channelOwner.ChannelOwner {
     this._actualHeadersPromise = void 0;
     this._request = void 0;
     this._finishedPromise = new _manualPromise.ManualPromise();
+    this.markAsInternalType();
     this._provisionalHeaders = new RawHeaders(initializer.headers);
     this._request = Request.from(this._initializer.request);
     Object.assign(this._request._timing, this._initializer.timing);
@@ -659,7 +661,7 @@ class RouteHandler {
     this._times = times;
     this.url = url;
     this.handler = handler;
-    this._svedZone = _utils.zones.currentZone();
+    this._svedZone = _utils.zones.current().without('apiZone');
   }
   static prepareInterceptionPatterns(handlers) {
     const patterns = [];

package/lib/client/waiter.js

@@ -35,7 +35,7 @@ class Waiter {
     this._savedZone = void 0;
     this._waitId = (0, _utils.createGuid)();
     this._channelOwner = channelOwner;
-    this._savedZone = _utils.zones.currentZone();
+    this._savedZone = _utils.zones.current().without('apiZone');
     this._channelOwner._channel.waitForEventInfo({
       info: {
         waitId: this._waitId,