patchright-core 1.49.1 → 1.50.0

package/lib/server/bidi/bidiPage.js

@@ -41,7 +41,6 @@ class BidiPage {
     this.rawKeyboard = void 0;
     this.rawTouchscreen = void 0;
     this._page = void 0;
-    this._pagePromise = void 0;
     this._session = void 0;
     this._opener = void 0;
     this._realmToContext = void 0;
@@ -49,7 +48,6 @@ class BidiPage {
     this._browserContext = void 0;
     this._networkManager = void 0;
     this._pdf = void 0;
-    this._initializedPage = null;
     this._initScriptIds = [];
     this._session = bidiSession;
     this._opener = opener;
@@ -65,15 +63,13 @@ class BidiPage {
     this._sessionListeners = [_eventsHelper.eventsHelper.addEventListener(bidiSession, 'script.realmCreated', this._onRealmCreated.bind(this)), _eventsHelper.eventsHelper.addEventListener(bidiSession, 'script.message', this._onScriptMessage.bind(this)), _eventsHelper.eventsHelper.addEventListener(bidiSession, 'browsingContext.contextDestroyed', this._onBrowsingContextDestroyed.bind(this)), _eventsHelper.eventsHelper.addEventListener(bidiSession, 'browsingContext.navigationStarted', this._onNavigationStarted.bind(this)), _eventsHelper.eventsHelper.addEventListener(bidiSession, 'browsingContext.navigationAborted', this._onNavigationAborted.bind(this)), _eventsHelper.eventsHelper.addEventListener(bidiSession, 'browsingContext.navigationFailed', this._onNavigationFailed.bind(this)), _eventsHelper.eventsHelper.addEventListener(bidiSession, 'browsingContext.fragmentNavigated', this._onFragmentNavigated.bind(this)), _eventsHelper.eventsHelper.addEventListener(bidiSession, 'browsingContext.domContentLoaded', this._onDomContentLoaded.bind(this)), _eventsHelper.eventsHelper.addEventListener(bidiSession, 'browsingContext.load', this._onLoad.bind(this)), _eventsHelper.eventsHelper.addEventListener(bidiSession, 'browsingContext.userPromptOpened', this._onUserPromptOpened.bind(this)), _eventsHelper.eventsHelper.addEventListener(bidiSession, 'log.entryAdded', this._onLogEntryAdded.bind(this))];
 
     // Initialize main frame.
-    this._pagePromise = this._initialize().finally(async () => {
-      await this._page.initOpener(this._opener);
-    }).then(() => {
-      this._initializedPage = this._page;
-      this._page.reportAsNew();
-      return this._page;
-    }).catch(e => {
-      this._page.reportAsNew(e);
-      return e;
+    // TODO: Wait for first execution context to be created and maybe about:blank navigated.
+    this._initialize().then(() => {
+      var _this$_opener;
+      return this._page.reportAsNew((_this$_opener = this._opener) === null || _this$_opener === void 0 ? void 0 : _this$_opener._page);
+    }, error => {
+      var _this$_opener2;
+      return this._page.reportAsNew((_this$_opener2 = this._opener) === null || _this$_opener2 === void 0 ? void 0 : _this$_opener2._page, error);
     });
   }
   async _initialize() {
@@ -84,18 +80,11 @@ class BidiPage {
   async _addAllInitScripts() {
     return Promise.all(this._page.allInitScripts().map(initScript => this.addInitScript(initScript)));
   }
-  potentiallyUninitializedPage() {
-    return this._page;
-  }
   didClose() {
     this._session.dispose();
     _eventsHelper.eventsHelper.removeEventListeners(this._sessionListeners);
     this._page._didClose();
   }
-  async pageOrError() {
-    // TODO: Wait for first execution context to be created and maybe about:blank navigated.
-    return this._pagePromise;
-  }
   _onFrameAttached(frameId, parentFrameId) {
     return this._page._frameManager.frameAttached(frameId, parentFrameId);
   }
@@ -311,7 +300,7 @@ class BidiPage {
   }
   async _onScriptMessage(event) {
     if (event.channel !== kPlaywrightBindingChannel) return;
-    const pageOrError = await this.pageOrError();
+    const pageOrError = await this._page.waitForInitializedOrError();
     if (pageOrError instanceof Error) return;
     const context = this._realmToContext.get(event.source.realm);
     if (!context) return;
@@ -351,7 +340,7 @@ class BidiPage {
       context: this._session.sessionId,
       format: {
         type: `image/${format === 'png' ? 'png' : 'jpeg'}`,
-        quality: quality || 80
+        quality: quality ? quality / 100 : 0.8
       },
       origin: documentRect ? 'document' : 'viewport',
       clip: {

package/lib/server/bidi/third_party/bidiKeyboard.js

@@ -13,18 +13,18 @@ exports.getBidiKeyValue = void 0;
 
 /* eslint-disable curly */
 
-const getBidiKeyValue = key => {
-  switch (key) {
+const getBidiKeyValue = keyName => {
+  switch (keyName) {
     case '\r':
     case '\n':
-      key = 'Enter';
+      keyName = 'Enter';
       break;
   }
   // Measures the number of code points rather than UTF-16 code units.
-  if ([...key].length === 1) {
-    return key;
+  if ([...keyName].length === 1) {
+    return keyName;
   }
-  switch (key) {
+  switch (keyName) {
     case 'Cancel':
       return '\uE001';
     case 'Help':
@@ -137,6 +137,8 @@ const getBidiKeyValue = key => {
       return '\uE052';
     case 'MetaRight':
       return '\uE053';
+    case 'Space':
+      return ' ';
     case 'Digit0':
       return '0';
     case 'Digit1':
@@ -232,7 +234,7 @@ const getBidiKeyValue = key => {
     case 'Quote':
       return '"';
     default:
-      throw new Error(`Unknown key: "${key}"`);
+      throw new Error(`Unknown key: "${keyName}"`);
   }
 };
 exports.getBidiKeyValue = getBidiKeyValue;

package/lib/server/browserContext.js

@@ -102,7 +102,7 @@ class BrowserContext extends _instrumentation.SdkObject {
     this._debugger = new _debugger.Debugger(this);
 
     // When PWDEBUG=1, show inspector for each context.
-    if ((0, _utils.debugMode)() === 'inspector') await _recorder.Recorder.show('actions', this, _recorderApp.RecorderApp.factory(this), {
+    if ((0, _utils.debugMode)() === 'inspector') await _recorder.Recorder.show(this, _recorderApp.RecorderApp.factory(this), {
       pauseOnNextStatement: true
     });
 
@@ -201,6 +201,9 @@ class BrowserContext extends _instrumentation.SdkObject {
     this._closePromiseFulfill(new Error('Context closed'));
     this.emit(BrowserContext.Events.Close);
   }
+  pages() {
+    return this.possiblyUninitializedPages().filter(page => page.initializedOrUndefined());
+  }
 
   // BrowserContext methods.
 
@@ -227,6 +230,9 @@ class BrowserContext extends _instrumentation.SdkObject {
   setHTTPCredentials(httpCredentials) {
     return this.doSetHTTPCredentials(httpCredentials);
   }
+  hasBinding(name) {
+    return this._pageBindings.has(name);
+  }
   async exposeBinding(name, needsHandle, playwrightBinding) {
     if (this._pageBindings.has(name)) throw new Error(`Function "${name}" has been already registered`);
     for (const page of this.pages()) {
@@ -265,27 +271,29 @@ class BrowserContext extends _instrumentation.SdkObject {
     this._timeoutSettings.setDefaultTimeout(timeout);
   }
   async _loadDefaultContextAsIs(progress) {
-    if (!this.pages().length) {
+    if (!this.possiblyUninitializedPages().length) {
       const waitForEvent = _helper.helper.waitForEvent(progress, this, BrowserContext.Events.Page);
       progress.cleanupWhenAborted(() => waitForEvent.dispose);
-      const page = await waitForEvent.promise;
-      if (page._pageIsError) throw page._pageIsError;
+      // Race against BrowserContext.close
+      await Promise.race([waitForEvent.promise, this._closePromise]);
     }
-    const pages = this.pages();
-    if (pages[0]._pageIsError) throw pages[0]._pageIsError;
-    await pages[0].mainFrame()._waitForLoadState(progress, 'load');
-    return pages;
+    const page = this.possiblyUninitializedPages()[0];
+    if (!page) return;
+    const pageOrError = await page.waitForInitializedOrError();
+    if (pageOrError instanceof Error) throw pageOrError;
+    await page.mainFrame()._waitForLoadState(progress, 'load');
+    return page;
   }
   async _loadDefaultContext(progress) {
-    const pages = await this._loadDefaultContextAsIs(progress);
+    const defaultPage = await this._loadDefaultContextAsIs(progress);
+    if (!defaultPage) return;
     const browserName = this._browser.options.name;
     if (this._options.isMobile && browserName === 'chromium' || this._options.locale && browserName === 'webkit') {
       // Workaround for:
       // - chromium fails to change isMobile for existing page;
       // - webkit fails to change locale for existing page.
-      const oldPage = pages[0];
       await this.newPage(progress.metadata);
-      await oldPage.close(progress.metadata);
+      await defaultPage.close(progress.metadata);
     }
   }
   _authenticateProxyViaHeader() {
@@ -318,8 +326,8 @@ class BrowserContext extends _instrumentation.SdkObject {
       password: password || ''
     };
   }
-  async addInitScript(source) {
-    const initScript = new _page6.InitScript(source);
+  async addInitScript(source, name) {
+    const initScript = new _page6.InitScript(source, false /* internal */, name);
     this.initScripts.push(initScript);
     await this.doAddInitScript(initScript);
   }
@@ -379,9 +387,9 @@ class BrowserContext extends _instrumentation.SdkObject {
     await this._closePromise;
   }
   async newPage(metadata) {
-    const pageDelegate = await this.newPageDelegate();
-    if (metadata.isServerSide) pageDelegate.potentiallyUninitializedPage().markAsServerSideOnly();
-    const pageOrError = await pageDelegate.pageOrError();
+    const page = await this.doCreateNewPage();
+    if (metadata.isServerSide) page.markAsServerSideOnly();
+    const pageOrError = await page.waitForInitializedOrError();
     if (pageOrError instanceof _page6.Page) {
       if (pageOrError.isClosed()) throw new Error('Page has been closed.');
       return pageOrError;

package/lib/server/chromium/crBrowser.js

@@ -134,7 +134,7 @@ class CRBrowser extends _browser.Browser {
     return this.options.name === 'clank';
   }
   async _waitForAllPagesToBeInitialized() {
-    await Promise.all([...this._crPages.values()].map(page => page.pageOrError()));
+    await Promise.all([...this._crPages.values()].map(crPage => crPage._page.waitForInitializedOrError()));
   }
   _onAttachedToTarget({
     targetInfo,
@@ -239,9 +239,9 @@ class CRBrowser extends _browser.Browser {
       return;
     }
     page.willBeginDownload();
-    let originPage = page._initializedPage;
+    let originPage = page._page.initializedOrUndefined();
     // If it's a new window download, report it on the opener page.
-    if (!originPage && page._opener) originPage = page._opener._initializedPage;
+    if (!originPage && page._opener) originPage = page._opener._page.initializedOrUndefined();
     if (!originPage) return;
     this._downloadCreated(originPage, payload.guid, payload.url, payload.suggestedFilename);
   }
@@ -312,10 +312,10 @@ class CRBrowserContext extends _browserContext.BrowserContext {
   _crPages() {
     return [...this._browser._crPages.values()].filter(crPage => crPage._browserContext === this);
   }
-  pages() {
-    return this._crPages().map(crPage => crPage._initializedPage).filter(Boolean);
+  possiblyUninitializedPages() {
+    return this._crPages().map(crPage => crPage._page);
   }
-  async newPageDelegate() {
+  async doCreateNewPage() {
     (0, _browserContext.assertBrowserContextIsNotOwned)(this);
     const oldKeys = this._browser.isClank() ? new Set(this._browser._crPages.keys()) : undefined;
     let {
@@ -338,7 +338,7 @@ class CRBrowserContext extends _browserContext.BrowserContext {
       (0, _utils.assert)(newKeys.size === 1);
       [targetId] = [...newKeys];
     }
-    return this._browser._crPages.get(targetId);
+    return this._browser._crPages.get(targetId)._page;
   }
   async doGetCookies(urls) {
     const {
@@ -372,7 +372,7 @@ class CRBrowserContext extends _browserContext.BrowserContext {
     });
   }
   async doGrantPermissions(origin, permissions) {
-    const webPermissionToProtocol = new Map([['geolocation', 'geolocation'], ['midi', 'midi'], ['notifications', 'notifications'], ['camera', 'videoCapture'], ['microphone', 'audioCapture'], ['background-sync', 'backgroundSync'], ['ambient-light-sensor', 'sensors'], ['accelerometer', 'sensors'], ['gyroscope', 'sensors'], ['magnetometer', 'sensors'], ['accessibility-events', 'accessibilityEvents'], ['clipboard-read', 'clipboardReadWrite'], ['clipboard-write', 'clipboardSanitizedWrite'], ['payment-handler', 'paymentHandler'],
+    const webPermissionToProtocol = new Map([['geolocation', 'geolocation'], ['midi', 'midi'], ['notifications', 'notifications'], ['camera', 'videoCapture'], ['microphone', 'audioCapture'], ['background-sync', 'backgroundSync'], ['ambient-light-sensor', 'sensors'], ['accelerometer', 'sensors'], ['gyroscope', 'sensors'], ['magnetometer', 'sensors'], ['clipboard-read', 'clipboardReadWrite'], ['clipboard-write', 'clipboardSanitizedWrite'], ['payment-handler', 'paymentHandler'],
     // chrome-specific permissions we have.
     ['midi-sysex', 'midiSysex'], ['storage-access', 'storageAccess']]);
     const filtered = permissions.map(permission => {
@@ -463,7 +463,7 @@ class CRBrowserContext extends _browserContext.BrowserContext {
     // When persistent context is closed, we do not necessary get Target.detachedFromTarget
     // for all the background pages.
     for (const [targetId, backgroundPage] of this._browser._backgroundPages.entries()) {
-      if (backgroundPage._browserContext === this && backgroundPage._initializedPage) {
+      if (backgroundPage._browserContext === this && backgroundPage._page.initializedOrUndefined()) {
         backgroundPage.didClose();
         this._browser._backgroundPages.delete(targetId);
       }
@@ -484,7 +484,7 @@ class CRBrowserContext extends _browserContext.BrowserContext {
   backgroundPages() {
     const result = [];
     for (const backgroundPage of this._browser._backgroundPages.values()) {
-      if (backgroundPage._browserContext === this && backgroundPage._initializedPage) result.push(backgroundPage._initializedPage);
+      if (backgroundPage._browserContext === this && backgroundPage._page.initializedOrUndefined()) result.push(backgroundPage._page);
     }
     return result;
   }

package/lib/server/chromium/crExecutionContext.js

@@ -100,11 +100,7 @@ class CRExecutionContext {
 }
 exports.CRExecutionContext = CRExecutionContext;
 function rewriteError(error) {
-  if (error.message.includes('Object reference chain is too long')) return {
-    result: {
-      type: 'undefined'
-    }
-  };
+  if (error.message.includes('Object reference chain is too long')) throw new Error('Cannot serialize result: object reference chain is too long.');
   if (error.message.includes('Object couldn\'t be returned by value')) return {
     result: {
       type: 'undefined'

package/lib/server/chromium/crInput.js

@@ -48,13 +48,19 @@ class RawKeyboardImpl {
     // remove the trailing : to match the Chromium command names.
     return commands.map(c => c.substring(0, c.length - 1));
   }
-  async keydown(modifiers, code, keyCode, keyCodeWithoutLocation, key, location, autoRepeat, text) {
+  async keydown(modifiers, keyName, description, autoRepeat) {
+    const {
+      code,
+      key,
+      location,
+      text
+    } = description;
     if (code === 'Escape' && (await this._dragManger.cancelDrag())) return;
     const commands = this._commandsForCode(code, modifiers);
     await this._client.send('Input.dispatchKeyEvent', {
       type: text ? 'keyDown' : 'rawKeyDown',
       modifiers: (0, _crProtocolHelper.toModifiersMask)(modifiers),
-      windowsVirtualKeyCode: keyCodeWithoutLocation,
+      windowsVirtualKeyCode: description.keyCodeWithoutLocation,
       code,
       commands,
       key,
@@ -65,12 +71,17 @@ class RawKeyboardImpl {
       isKeypad: location === input.keypadLocation
     });
   }
-  async keyup(modifiers, code, keyCode, keyCodeWithoutLocation, key, location) {
+  async keyup(modifiers, keyName, description) {
+    const {
+      code,
+      key,
+      location
+    } = description;
     await this._client.send('Input.dispatchKeyEvent', {
       type: 'keyUp',
       modifiers: (0, _crProtocolHelper.toModifiersMask)(modifiers),
       key,
-      windowsVirtualKeyCode: keyCodeWithoutLocation,
+      windowsVirtualKeyCode: description.keyCodeWithoutLocation,
       code,
       location
     });

package/lib/server/chromium/crPage.js

@@ -71,8 +71,6 @@ class CRPage {
     this._pdf = void 0;
     this._coverage = void 0;
     this._browserContext = void 0;
-    this._pagePromise = void 0;
-    this._initializedPage = null;
     this._isBackgroundPage = void 0;
     // Holds window features for the next popup being opened via window.open,
     // until the popup target arrives. This could be racy if two oopifs
@@ -109,29 +107,15 @@ class CRPage {
         screen: viewportSize
       };
     }
-    // Note: it is important to call |reportAsNew| before resolving pageOrError promise,
-    // so that anyone who awaits pageOrError got a ready and reported page.
-    this._pagePromise = this._mainFrameSession._initialize(bits.hasUIWindow).then(async r => {
-      await this._page.initOpener(this._opener);
-      return r;
-    }).catch(async e => {
-      await this._page.initOpener(this._opener);
-      throw e;
-    }).then(() => {
-      this._initializedPage = this._page;
-      this._reportAsNew();
-      return this._page;
-    }).catch(e => {
-      this._reportAsNew(e);
-      return e;
+    const createdEvent = this._isBackgroundPage ? _crBrowser.CRBrowserContext.CREvents.BackgroundPage : _browserContext.BrowserContext.Events.Page;
+    this._mainFrameSession._initialize(bits.hasUIWindow).then(() => {
+      var _this$_opener;
+      return this._page.reportAsNew((_this$_opener = this._opener) === null || _this$_opener === void 0 ? void 0 : _this$_opener._page, undefined, createdEvent);
+    }, error => {
+      var _this$_opener2;
+      return this._page.reportAsNew((_this$_opener2 = this._opener) === null || _this$_opener2 === void 0 ? void 0 : _this$_opener2._page, error, createdEvent);
     });
   }
-  potentiallyUninitializedPage() {
-    return this._page;
-  }
-  _reportAsNew(error) {
-    this._page.reportAsNew(error, this._isBackgroundPage ? _crBrowser.CRBrowserContext.CREvents.BackgroundPage : _browserContext.BrowserContext.Events.Page);
-  }
   async _forAllFrameSessions(cb) {
     const frameSessions = Array.from(this._sessions.values());
     await Promise.all(frameSessions.map(frameSession => {
@@ -159,9 +143,6 @@ class CRPage {
   willBeginDownload() {
     this._mainFrameSession._willBeginDownload();
   }
-  async pageOrError() {
-    return this._pagePromise;
-  }
   didClose() {
     for (const session of this._sessions.values()) session.dispose();
     this._page._didClose();
@@ -398,6 +379,9 @@ class FrameSession {
       this._firstNonInitialNavigationCommittedFulfill = f;
       this._firstNonInitialNavigationCommittedReject = r;
     });
+    // The Promise is not always awaited (e.g. FrameSession._initialize can throw)
+    // so we catch errors here to prevent unhandled promise rejection.
+    this._firstNonInitialNavigationCommittedPromise.catch(() => {});
   }
   _isMainFrame() {
     return this._targetId === this._crPage._targetId;
@@ -429,7 +413,7 @@ class FrameSession {
       // Note: it is important to start video recorder before sending Page.startScreencast,
       // and it is equally important to send Page.startScreencast before sending Runtime.runIfWaitingForDebugger.
       await this._createVideoRecorder(screencastId, screencastOptions);
-      this._crPage.pageOrError().then(p => {
+      this._crPage._page.waitForInitializedOrError().then(p => {
         if (p instanceof Error) this._stopVideoRecording().catch(() => {});
       });
     }
@@ -671,6 +655,9 @@ class FrameSession {
       const frame = this._page._frameManager.frame(targetId);
       if (!frame) return; // Subtree may be already gone due to renderer/browser race.
       this._page._frameManager.removeChildFramesRecursively(frame);
+      for (const [contextId, context] of this._contextIdToContext) {
+        if (context.frame === frame) this._onExecutionContextDestroyed(contextId);
+      }
       const frameSession = new FrameSession(this._crPage, session, targetId, this);
       this._crPage._sessions.set(targetId, frameSession);
       frameSession._initialize(false).catch(e => e);
@@ -773,7 +760,7 @@ class FrameSession {
     this._page._addConsoleMessage(event.type, values, (0, _crProtocolHelper.toConsoleMessageLocation)(event.stackTrace));
   }
   async _onBindingCalled(event) {
-    const pageOrError = await this._crPage.pageOrError();
+    const pageOrError = await this._crPage._page.waitForInitializedOrError();
     if (!(pageOrError instanceof Error)) {
       const context = this._contextIdToContext.get(event.executionContextId);
       if (context) await this._page._onBindingCalled(event.payload, context);else await this._page._onBindingCalled(event.payload, await this._page.mainFrame()._mainContext()); // This might be a bit sketchy but it works for now
@@ -782,6 +769,8 @@ class FrameSession {
   _onDialog(event) {
     if (!this._page._frameManager.frame(this._targetId)) return; // Our frame/subtree may be gone already.
     this._page.emitOnContext(_browserContext.BrowserContext.Events.Dialog, new dialog.Dialog(this._page, event.type, event.message, async (accept, promptText) => {
+      // TODO: this should actually be a CDP event that notifies about a cancelled navigation attempt.
+      if (this._isMainFrame() && event.type === 'beforeunload' && !accept) this._page._frameManager.frameAbortedNavigation(this._page.mainFrame()._id, 'navigation cancelled by beforeunload dialog');
       await this._client.send('Page.handleJavaScriptDialog', {
         accept,
         promptText
@@ -829,8 +818,7 @@ class FrameSession {
     await this._page._onFileChooserOpened(handle);
   }
   _willBeginDownload() {
-    const originPage = this._crPage._initializedPage;
-    if (!originPage) {
+    if (!this._crPage._page.initializedOrUndefined()) {
       // Resume the page creation with an error. The page will automatically close right
       // after the download begins.
       this._firstNonInitialNavigationCommittedReject(new Error('Starting new page download'));
@@ -869,7 +857,7 @@ class FrameSession {
     });
     // Wait for the first frame before reporting video to the client.
     gotFirstFrame.then(() => {
-      this._crPage._browserContext._browser._videoStarted(this._crPage._browserContext, screencastId, options.outputFile, this._crPage.pageOrError());
+      this._crPage._browserContext._browser._videoStarted(this._crPage._browserContext, screencastId, options.outputFile, this._crPage._page.waitForInitializedOrError());
     });
   }
   async _stopVideoRecording() {

package/lib/server/codegen/csharp.js

@@ -151,7 +151,12 @@ class CSharpLanguageGenerator {
       using var playwright = await Playwright.CreateAsync();
       await using var browser = await playwright.${toPascal(options.browserName)}.LaunchAsync(${formatObject(options.launchOptions, '    ', 'BrowserTypeLaunchOptions')});
       var context = await browser.NewContextAsync(${formatContextOptions(options.contextOptions, options.deviceName)});`);
-    if (options.contextOptions.recordHar) formatter.add(`      await context.RouteFromHARAsync(${quote(options.contextOptions.recordHar.path)});`);
+    if (options.contextOptions.recordHar) {
+      const url = options.contextOptions.recordHar.urlFilter;
+      formatter.add(`      await context.RouteFromHARAsync(${quote(options.contextOptions.recordHar.path)}${url ? `, ${formatObject({
+        url
+      }, '    ', 'BrowserContextRouteFromHAROptions')}` : ''});`);
+    }
     formatter.newLine();
     return formatter.format();
   }
@@ -176,7 +181,12 @@ class CSharpLanguageGenerator {
     formatter.add(`    [${this._mode === 'nunit' ? 'Test' : 'TestMethod'}]
     public async Task MyTest()
     {`);
-    if (options.contextOptions.recordHar) formatter.add(`    await context.RouteFromHARAsync(${quote(options.contextOptions.recordHar.path)});`);
+    if (options.contextOptions.recordHar) {
+      const url = options.contextOptions.recordHar.urlFilter;
+      formatter.add(`    await Context.RouteFromHARAsync(${quote(options.contextOptions.recordHar.path)}${url ? `, ${formatObject({
+        url
+      }, '    ', 'BrowserContextRouteFromHAROptions')}` : ''});`);
+    }
     return formatter.format();
   }
   generateFooter(saveStorage) {

package/lib/server/codegen/java.js

@@ -135,27 +135,38 @@ class JavaLanguageGenerator {
       import com.microsoft.playwright.Page;
       import com.microsoft.playwright.options.*;
 
-      import org.junit.jupiter.api.*;
+      ${options.contextOptions.recordHar ? `import java.nio.file.Paths;\n` : ''}import org.junit.jupiter.api.*;
       import static com.microsoft.playwright.assertions.PlaywrightAssertions.*;
 
       @UsePlaywright
       public class TestExample {
         @Test
         void test(Page page) {`);
+      if (options.contextOptions.recordHar) {
+        const url = options.contextOptions.recordHar.urlFilter;
+        const recordHarOptions = typeof url === 'string' ? `, new Page.RouteFromHAROptions()
+            .setUrl(${quote(url)})` : '';
+        formatter.add(`          page.routeFromHAR(Paths.get(${quote(options.contextOptions.recordHar.path)})${recordHarOptions});`);
+      }
       return formatter.format();
     }
     formatter.add(`
     import com.microsoft.playwright.*;
     import com.microsoft.playwright.options.*;
     import static com.microsoft.playwright.assertions.PlaywrightAssertions.assertThat;
-    import java.util.*;
+    ${options.contextOptions.recordHar ? `import java.nio.file.Paths;\n` : ''}import java.util.*;
 
     public class Example {
       public static void main(String[] args) {
         try (Playwright playwright = Playwright.create()) {
           Browser browser = playwright.${options.browserName}().launch(${formatLaunchOptions(options.launchOptions)});
           BrowserContext context = browser.newContext(${formatContextOptions(options.contextOptions, options.deviceName)});`);
-    if (options.contextOptions.recordHar) formatter.add(`          context.routeFromHAR(${quote(options.contextOptions.recordHar.path)});`);
+    if (options.contextOptions.recordHar) {
+      const url = options.contextOptions.recordHar.urlFilter;
+      const recordHarOptions = typeof url === 'string' ? `, new BrowserContext.RouteFromHAROptions()
+          .setUrl(${quote(url)})` : '';
+      formatter.add(`          context.routeFromHAR(Paths.get(${quote(options.contextOptions.recordHar.path)})${recordHarOptions});`);
+    }
     return formatter.format();
   }
   generateFooter(saveStorage) {

package/lib/server/codegen/javascript.js

@@ -106,7 +106,10 @@ class JavaScriptLanguageGenerator {
           return `${this._isTest ? '' : '// '}await expect(${subject}.${this._asLocator(action.selector)}).${assertion};`;
         }
       case 'assertSnapshot':
-        return `${this._isTest ? '' : '// '}await expect(${subject}.${this._asLocator(action.selector)}).toMatchAriaSnapshot(${quoteMultiline(action.snapshot)});`;
+        {
+          const commentIfNeeded = this._isTest ? '' : '// ';
+          return `${commentIfNeeded}await expect(${subject}.${this._asLocator(action.selector)}).toMatchAriaSnapshot(${quoteMultiline(action.snapshot, `${commentIfNeeded}  `)});`;
+        }
     }
   }
   _asLocator(selector) {
@@ -127,7 +130,12 @@ class JavaScriptLanguageGenerator {
       import { test, expect${options.deviceName ? ', devices' : ''} } from '@playwright/test';
 ${useText ? '\ntest.use(' + useText + ');\n' : ''}
       test('test', async ({ page }) => {`);
-    if (options.contextOptions.recordHar) formatter.add(`  await page.routeFromHAR(${quote(options.contextOptions.recordHar.path)});`);
+    if (options.contextOptions.recordHar) {
+      const url = options.contextOptions.recordHar.urlFilter;
+      formatter.add(`  await page.routeFromHAR(${quote(options.contextOptions.recordHar.path)}${url ? `, ${formatOptions({
+        url
+      }, false)}` : ''});`);
+    }
     return formatter.format();
   }
   generateTestFooter(saveStorage) {

package/lib/server/codegen/jsonl.js

@@ -32,7 +32,7 @@ class JsonlLanguageGenerator {
     const locator = actionInContext.action.selector ? JSON.parse((0, _utils.asLocator)('jsonl', actionInContext.action.selector)) : undefined;
     const entry = {
       ...actionInContext.action,
-      pageAlias: actionInContext.frame.pageAlias,
+      ...actionInContext.frame,
       locator
     };
     return JSON.stringify(entry);

package/lib/server/codegen/python.js

@@ -123,6 +123,7 @@ class PythonLanguageGenerator {
   }
   generateHeader(options) {
     const formatter = new PythonFormatter();
+    const recordHar = options.contextOptions.recordHar;
     if (this._isPyTest) {
       const contextOptions = formatContextOptions(options.contextOptions, options.deviceName, true /* asDict */);
       const fixture = contextOptions ? `
@@ -132,12 +133,12 @@ def browser_context_args(browser_context_args, playwright) {
     return {${contextOptions}}
 }
 ` : '';
-      formatter.add(`${options.deviceName ? 'import pytest\n' : ''}import re
+      formatter.add(`${options.deviceName || contextOptions ? 'import pytest\n' : ''}import re
 from playwright.sync_api import Page, expect
 ${fixture}
 
 def test_example(page: Page) -> None {`);
-      if (options.contextOptions.recordHar) formatter.add(`    page.route_from_har(${quote(options.contextOptions.recordHar.path)})`);
+      if (recordHar) formatter.add(`    page.route_from_har(${quote(recordHar.path)}${typeof recordHar.urlFilter === 'string' ? `, url=${quote(recordHar.urlFilter)}` : ''})`);
     } else if (this._isAsync) {
       formatter.add(`
 import asyncio
@@ -148,7 +149,7 @@ from playwright.async_api import Playwright, async_playwright, expect
 async def run(playwright: Playwright) -> None {
     browser = await playwright.${options.browserName}.launch(${formatOptions(options.launchOptions, false)})
     context = await browser.new_context(${formatContextOptions(options.contextOptions, options.deviceName)})`);
-      if (options.contextOptions.recordHar) formatter.add(`    await page.route_from_har(${quote(options.contextOptions.recordHar.path)})`);
+      if (recordHar) formatter.add(`    await context.route_from_har(${quote(recordHar.path)}${typeof recordHar.urlFilter === 'string' ? `, url=${quote(recordHar.urlFilter)}` : ''})`);
     } else {
       formatter.add(`
 import re
@@ -158,7 +159,7 @@ from playwright.sync_api import Playwright, sync_playwright, expect
 def run(playwright: Playwright) -> None {
     browser = playwright.${options.browserName}.launch(${formatOptions(options.launchOptions, false)})
     context = browser.new_context(${formatContextOptions(options.contextOptions, options.deviceName)})`);
-      if (options.contextOptions.recordHar) formatter.add(`    context.route_from_har(${quote(options.contextOptions.recordHar.path)})`);
+      if (recordHar) formatter.add(`    context.route_from_har(${quote(recordHar.path)}${typeof recordHar.urlFilter === 'string' ? `, url=${quote(recordHar.urlFilter)}` : ''})`);
     }
     return formatter.format();
   }