patchcord 0.6.38 → 0.6.40

package/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "patchcord",
   "description": "Cross-machine agent messaging. Messages from other agents land in the inbox and wake the agent to reply.",
-  "version": "0.6.38",
+  "version": "0.6.40",
   "author": {
     "name": "ppravdin"
   },

package/bin/patchcord.mjs

@@ -789,8 +789,23 @@ if (cmd === "whoami") {
     // provisioned". Say explicitly that identity is fine.
     console.log(`self-description: (not set — optional; your identity ${json.agent}@${json.namespace} is fully provisioned. Set one with: patchcord whoami --propose "<text>")`);
   }
-  console.log();
-  console.log(`tip: \`patchcord agents\` returns whoami for all peers.`);
+  // TTY-ONLY, AND THAT IS THE WHOLE POINT.
+  //
+  // This tip is addressed to a human reading a terminal. It was printed
+  // unconditionally, which meant it also landed in the stdout an AGENT captures
+  // from a tool call — and to a model, a suggestion in a tool result is
+  // indistinguishable from an instruction. An agy session's own record shows the
+  // consequence exactly: 6 `patchcord whoami` calls, 6 `patchcord agents` calls,
+  // paired one-to-one, each `agents` immediately following the tip in the
+  // previous command's output. Nothing in any skill or config asked for it. We
+  // did, in our own stdout, every single time.
+  //
+  // A tip is help. An unrequested command is work. The difference is entirely in
+  // who is reading, and `isTTY` is the one place that difference is knowable.
+  if (process.stdout.isTTY) {
+    console.log();
+    console.log(`tip: \`patchcord agents\` returns whoami for all peers.`);
+  }
   for (const w of warnings) {
     // stderr, matching the global-scope warning above. The line is addressed
     // to the AGENT and says to relay it, because the human has no reason to
@@ -1432,10 +1447,38 @@ if (cmd === "login" || cmd === "orchestrator" || cmd === "teamlead" || cmd === "
       // Antigravity CLI: PROJECT-scoped config at .agents/mcp_config.json (one
       // project = one namespace = one agent). Remote HTTP uses `serverUrl`.
       const adir = join(dir, ".agents"); mkdirSync(adir, { recursive: true });
-      return writeJson(join(adir, "mcp_config.json"), (o) => {
+      const agWritten = writeJson(join(adir, "mcp_config.json"), (o) => {
         o.mcpServers = o.mcpServers || {};
         o.mcpServers.patchcord = { serverUrl: `${baseUrl}/mcp`, headers: hdr };
       });
+      // THE SKILL IS A GUARD, NOT DOCUMENTATION, AND IT WAS MISSING HERE.
+      //
+      // The interactive installer copies these; this path did not, so every seat
+      // provisioned by `patchcord provision --tool agy` — which is how a
+      // mux-deployed Team is built — got the credential and none of the rules.
+      // Three live agy seats were checked: one had only patchcord-wait, two had
+      // no skills at all.
+      //
+      // What goes missing is specifically the line "Do not run the `patchcord`
+      // CLI (whoami, inbox, recall, HTTP calls)". Without it, a seat whose MCP
+      // has not loaded reaches for the CLI instead — and one that did wrote its
+      // own send_patchcord.js and ran it eight times. The skill exists, is
+      // correctly worded, and was installed by one provisioning path out of two,
+      // which is the same as not having it for anyone who arrives by the other.
+      //
+      // Copied the same way hermes is above, which is why the pattern was
+      // already here to notice.
+      try {
+        const agSkills = join(pluginRoot, "per-project-skills", "antigravity");
+        for (const [src, dest] of [["inbox", "patchcord"], ["wait", "patchcord-wait"]]) {
+          const from = join(agSkills, src, "SKILL.md");
+          if (!existsSync(from)) continue;
+          const to = join(adir, "skills", dest);
+          mkdirSync(to, { recursive: true });
+          cpSync(from, join(to, "SKILL.md"));
+        }
+      } catch {}
+      return agWritten;
     }
     if (tool === "hermes") {
       // Hermes reads MCP servers ONLY from its GLOBAL ~/.hermes/config.yaml

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "patchcord",
-  "version": "0.6.38",
+  "version": "0.6.40",
   "description": "Cross-machine agent messaging for Claude Code and Codex",
   "scripts": {
     "version": "node scripts/sync-plugin-version.mjs && git add .claude-plugin/plugin.json"

package/scripts/check-inbox.sh

@@ -11,7 +11,7 @@ if [ -f "$HOOK_DIR/lib/inbox-guard.sh" ]; then
 else
   # Degrade to the pre-guard behaviour rather than dying: a partial install
   # must still nudge, just without the identity hint or the loop breaker.
-  pc_inbox_reason() { printf '%s patchcord message(s) waiting. Call inbox() and reply to all immediately.' "$1"; }
+  pc_inbox_reason() { printf '%s patchcord message(s) waiting — call inbox() and reply.' "$1"; }
   pc_streak_ok() { return 0; }
   pc_state_path() { printf ''; }
   pc_streak_n() { printf '1'; }

package/scripts/codex-stop-hook.sh

@@ -17,7 +17,7 @@ elif [ -f "$HOOK_DIR/patchcord-inbox-guard.sh" ]; then
   # shellcheck source=lib/inbox-guard.sh
   . "$HOOK_DIR/patchcord-inbox-guard.sh"
 else
-  pc_inbox_reason() { printf '%s patchcord message(s) waiting. Call inbox() and reply to all.' "$1"; }
+  pc_inbox_reason() { printf '%s patchcord message(s) waiting — call inbox() and reply.' "$1"; }
   pc_streak_ok() { return 0; }
   pc_state_path() { printf ''; }
   pc_streak_n() { printf '1'; }

package/scripts/cursor-stop-hook.sh

@@ -147,10 +147,15 @@ echo "$NOW $(( STREAK + 1 ))" > "$STATE_FILE"
 NAMESPACE=$(echo "$RESPONSE" | jq -r '.namespace_id // empty' 2>/dev/null || true)
 AGENT_ID=$(echo "$RESPONSE" | jq -r '.agent_id // empty' 2>/dev/null || true)
 
+# The identity belongs in the FIRST sentence, not appended after it. Tacked on
+# the end it reads as an afterthought and the reader has already moved on.
+WHO=""
+[ -n "$NAMESPACE" ] && [ -n "$AGENT_ID" ] && WHO=" for ${AGENT_ID}@${NAMESPACE}"
+
 if [ "$COUNT" -eq 1 ]; then
-  MSG="Patchcord: 1 pending message. Call the patchcord inbox tool now, do the work it asks for, then reply with what you did."
+  MSG="Patchcord: 1 pending message${WHO} — call the patchcord inbox tool, do what it asks, then reply with what you did."
 else
-  MSG="Patchcord: ${COUNT} pending messages. Call the patchcord inbox tool now, do the work each one asks for, then reply to each with what you did."
+  MSG="Patchcord: ${COUNT} pending messages${WHO} — call the patchcord inbox tool, do what each asks, then reply to each with what you did."
 fi
 
 # Name the identity the count belongs to. This hook reads the token from
@@ -160,7 +165,8 @@ fi
 # the old one — a contradiction neither side can see alone. See
 # lib/inbox-guard.sh.
 if [ -n "$NAMESPACE" ] && [ -n "$AGENT_ID" ]; then
-  MSG="${MSG} These are addressed to ${AGENT_ID}@${NAMESPACE}. If the inbox tool reports a different identity, or reports 0 pending, this session is authenticated as another agent — the token on disk was replaced after it started. Do not keep retrying: say so and ask the user to restart the session."
+  MSG="${MSG}
+If the inbox tool shows a different agent or 0 pending: the token on disk changed after this session started, so this session is signed in as someone else. Do not retry — tell the user and ask them to restart the session."
 fi
 
 jq -n --arg msg "$MSG" '{followup_message: $msg}'

package/scripts/lib/inbox-guard.sh

@@ -25,6 +25,11 @@
 # The nudge text. Names the identity so a session authenticated as a different
 # agent can recognise the mismatch.
 #
+# BOTH BRANCHES ARE READ BY A HUMAN. They are printed in the transcript, so
+# every word is read by a person as well as by an agent: lead with the action,
+# keep the diagnosis to one sentence, and never emit "message(s)" — singular and
+# plural are already computed one line below.
+#
 # THE STALE-IDENTITY EXPLANATION IS ONLY EMITTED ONCE THE SYMPTOM HAS ACTUALLY
 # OCCURRED. It used to be appended to EVERY nudge, fleet-wide, which was wrong
 # for three reasons:
@@ -53,28 +58,31 @@
 pc_inbox_reason() {
   local count="$1" ns="$2" agent="$3" call="${4:-inbox()}" hint="${5:-restart this session}"
   local streak="${6:-1}"
-  local noun="message(s)"
+  local noun="messages"
   [ "$count" = "1" ] && noun="message"
   case "$streak" in ''|*[!0-9]*) streak=1 ;; esac
 
   if [ -z "$ns" ] || [ -z "$agent" ]; then
-    printf '%s patchcord %s waiting. Call %s and reply to all immediately.' \
+    printf '%s patchcord %s waiting — call %s and reply.' \
       "$count" "$noun" "$call"
     return
   fi
 
   if [ "$streak" -lt 2 ]; then
-    printf '%s patchcord %s waiting for %s@%s. Call %s and reply to all immediately.' \
+    printf '%s patchcord %s for %s@%s — call %s and reply.' \
       "$count" "$noun" "$agent" "$ns" "$call"
     return
   fi
 
-  printf 'STILL %s patchcord %s waiting for %s@%s after a previous nudge — %s did not clear it. Call %s once more. If it reports a different identity than %s@%s, or reports 0 pending, then this session is authenticated as another agent: the token on disk was replaced after the session started. In that case do NOT keep calling %s — say so and ask the user to %s so it reloads the config.' \
+  # Second consecutive identical block: the nudge did NOT clear, which is the
+  # actual evidence of the stale-token condition. Even here the action comes
+  # first and the diagnosis is one sentence on its own line — a repeat is a
+  # worse moment to make someone parse a paragraph, not a better one.
+  printf 'Still %s patchcord %s for %s@%s — %s did not clear it. Call %s once more.
+If it shows a different agent or 0 pending: the token on disk changed after this session started, so this session is signed in as someone else. Do not retry — tell the user and ask them to %s.' \
     "$count" "$noun" "$agent" "$ns" \
-    "$call" \
-    "$call" \
-    "$agent" "$ns" \
-    "$call" "$hint"
+    "$call" "$call" \
+    "$hint"
 }
 
 # pc_streak_n <state_file>