pasika 0.10.91 → 0.10.92

package/dist/eslint/pasika/index.js

@@ -6418,13 +6418,17 @@ function canGroupSource(source) {
 function isGroupedUsageSource(source) {
   return source.type === "Identifier" || source.type === "ThisExpression";
 }
+function supportsSinglePropertySource(source) {
+  if (isGroupedUsageSource(source) || source.type === "CallExpression") return true;
+  return source.type === "MemberExpression" && !source.computed && !source.optional && source.property.type === "Identifier" && supportsSinglePropertySource(source.object);
+}
 function rootIdentifierName(node) {
   if (node.type === "Identifier") return node.name;
   if (node.type !== "MemberExpression" || node.object.type === "Super") return void 0;
   return rootIdentifierName(node.object);
 }
 function isCompliantLocalName(propertyName5) {
-  return !propertyName5.includes("_");
+  return !propertyName5.includes("_") || /^[A-Z][A-Z0-9]*(?:_[A-Z0-9]+)*$/u.test(propertyName5);
 }
 function propertyNameOf(node) {
   if (node.type !== "Property" || node.computed) return void 0;
@@ -6667,8 +6671,8 @@ function groupedDestructuringSelections(context, first, isEnumValue) {
 function declarationTerminator(context, declaration) {
   return context.sourceCode.getText(declaration).trimEnd().endsWith(";") ? ";" : "";
 }
-function singleMessage(binding) {
-  return `"${binding.localName}" is derived directly from "${binding.sourceText}.${binding.propertyName}". Use object destructuring. ${DOC5}`;
+function singlePropertyMessage(binding) {
+  return `"${binding.propertyName}" is the only property bound from "${binding.sourceText}". Read "${binding.sourceText}.${binding.propertyName}" directly instead of creating a local binding. ${DOC5}`;
 }
 function groupMessage(bindings) {
   const firstBinding = bindings[0];
@@ -6688,7 +6692,7 @@ var preferObjectDestructuringRule = {
     type: "problem",
     fixable: "code",
     docs: {
-      description: "Require related object-property reads to use one object destructuring declaration."
+      description: "Prefer direct access for one property and shared destructuring for related property reads."
     }
   },
   create(context) {
@@ -6698,7 +6702,7 @@ var preferObjectDestructuringRule = {
     const usageScopes = [];
     const currentUsageScope = () => usageScopes.at(-1);
     const enterUsageScope = (node) => {
-      usageScopes.push({ node, objects: /* @__PURE__ */ new Map() });
+      usageScopes.push({ node, objects: /* @__PURE__ */ new Map(), singleProperties: [] });
     };
     const enterUsageBarrier = () => {
       usageScopes.push(void 0);
@@ -6745,6 +6749,31 @@ ${indentation}`;
           }
         });
       }
+      for (const binding of scope.singleProperties) {
+        const fromSameSource = scope.singleProperties.filter(({ sourceText }) => sourceText === binding.sourceText);
+        if (fromSameSource[0] !== binding) continue;
+        const usage = scope.objects.get(binding.sourceText);
+        const usedProperties = usage?.propertyNames;
+        if (usedProperties && usedProperties.size > 1 && usage.directMembers.length > 0) {
+          if (scope.singleProperties.some(
+            (item) => item.node.type === "ObjectPattern" && item.sourceText === binding.sourceText
+          )) {
+            continue;
+          }
+        }
+        if (usedProperties && usedProperties.size > 1) {
+          context.report({ node: binding.node, message: scopeUsageMessage(binding.sourceText, usedProperties) });
+          continue;
+        }
+        if (fromSameSource.length > 1) {
+          const names = new Set(fromSameSource.map(({ propertyName: propertyName5 }) => propertyName5));
+          if (names.size > 1) {
+            context.report({ node: binding.node, message: scopeUsageMessage(binding.sourceText, names) });
+            continue;
+          }
+        }
+        context.report({ node: binding.node, message: singlePropertyMessage(binding) });
+      }
     };
     return {
       Program: enterUsageScope,
@@ -6774,7 +6803,20 @@ ${indentation}`;
         const selection = destructuringSelection(context, node, isEnumValue);
         if (selection) {
           const group = groupedDestructuringSelections(context, selection, isEnumValue);
-          if (group.length <= 1) return;
+          if (group.length <= 1) {
+            if (node.kind === "const" && selection.propertyNames.length === 1 && supportsSinglePropertySource(selection.source)) {
+              const declarator = node.declarations[0];
+              const propertyName5 = selection.propertyNames[0];
+              if (declarator && propertyName5) {
+                currentUsageScope()?.singleProperties.push({
+                  node: declarator.id,
+                  sourceText: selection.sourceText,
+                  propertyName: propertyName5
+                });
+              }
+            }
+            return;
+          }
           for (const item of group.slice(1)) grouped.add(item.declaration);
           const lastDeclaration = group.at(-1)?.declaration;
           if (!lastDeclaration) return;
@@ -6841,13 +6883,11 @@ ${indentation}`;
           }
         }
         for (const binding of bindings) {
-          if (!canGroupSource(binding.source)) continue;
-          context.report({
+          if (node.kind !== "const" || !supportsSinglePropertySource(binding.source)) continue;
+          currentUsageScope()?.singleProperties.push({
             node: binding.declarator,
-            message: singleMessage(binding),
-            fix(fixer) {
-              return fixer.replaceText(binding.declarator, `{ ${binding.bindingText} } = ${binding.sourceText}`);
-            }
+            sourceText: binding.sourceText,
+            propertyName: binding.propertyName
           });
         }
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pasika",
-  "version": "0.10.91",
+  "version": "0.10.92",
   "description": "Reusable agent setup package",
   "repository": {
     "type": "git",