pasika 0.10.77 → 0.10.79

package/dist/eslint/pasika/index.js

@@ -6153,11 +6153,8 @@ function directPropertyBinding(context, declarator) {
 function canGroupSource(source) {
   return source.type === "Identifier" || source.type === "ThisExpression";
 }
-function isStableObjectSource(source) {
-  if (source.type === "Identifier" || source.type === "ThisExpression") return true;
-  if (source.type !== "MemberExpression") return false;
-  if (source.computed || source.optional || source.property.type !== "Identifier") return false;
-  return isStableObjectSource(source.object);
+function isGroupedUsageSource(source) {
+  return source.type === "Identifier" || source.type === "ThisExpression";
 }
 function rootIdentifierName(node) {
   if (node.type === "Identifier") return node.name;
@@ -6231,7 +6228,7 @@ function memberIsDirectVariableInitializer(context, member) {
 function recordMemberUsage(context, scope, ownershipResolver, member) {
   if (!scope || member.computed || member.optional || member.property.type !== "Identifier") return;
   if (!memberCanBeDestructured(context, ownershipResolver, member)) return;
-  if (!isStableObjectSource(member.object) || !memberIsRead(context, member)) return;
+  if (!isGroupedUsageSource(member.object) || !memberIsRead(context, member)) return;
   const sourceText = context.sourceCode.getText(member.object);
   const usage = objectUsage(scope, sourceText);
   const propertyName5 = member.property.name;
@@ -6243,10 +6240,11 @@ function recordMemberUsage(context, scope, ownershipResolver, member) {
 function recordDestructuringUsage(context, scope, declaration) {
   if (!scope) return;
   for (const declarator of declaration.declarations) {
-    if (declarator.id.type !== "ObjectPattern" || !declarator.init || !isStableObjectSource(declarator.init)) continue;
+    if (declarator.id.type !== "ObjectPattern" || !declarator.init || !isGroupedUsageSource(declarator.init)) continue;
     if (rootIdentifierName(declarator.init) === "locales") continue;
     const sourceText = context.sourceCode.getText(declarator.init);
     const usage = objectUsage(scope, sourceText);
+    if (usage.directMembers.length > 0) continue;
     const propertyNames = /* @__PURE__ */ new Set();
     for (const property of declarator.id.properties) {
       if (property.type !== "Property" || property.computed || property.key.type !== "Identifier") continue;
@@ -6264,6 +6262,10 @@ function scopeUsageMessage(sourceText, propertyNames) {
 function hasBinding(context, node, name) {
   const initialScope = context.sourceCode.getScope(node);
   if (initialScope.variables.some((variable) => variable.name === name)) return true;
+  const descendantHasBinding = (scope) => scope.childScopes.some(
+    (childScope) => childScope.variables.some((variable) => variable.name === name) || descendantHasBinding(childScope)
+  );
+  if (descendantHasBinding(initialScope)) return true;
   for (let scope = initialScope.upper; scope !== null; scope = scope.upper) {
     if (scope.variables.some((variable) => variable.name === name)) return true;
   }
@@ -6404,6 +6406,9 @@ var preferObjectDestructuringRule = {
     const enterUsageScope = (node) => {
       usageScopes.push({ node, objects: /* @__PURE__ */ new Map() });
     };
+    const enterUsageBarrier = () => {
+      usageScopes.push(void 0);
+    };
     const exitUsageScope = () => {
       const scope = usageScopes.pop();
       if (!scope) return;
@@ -6412,17 +6417,17 @@ var preferObjectDestructuringRule = {
         const firstDirectUsage = usage.directMembers[0];
         if (!firstDirectUsage) continue;
         const { member: firstDirectMember } = firstDirectUsage;
+        const propertyNames = [...usage.propertyNames];
+        const missingPropertyNames = propertyNames.filter(
+          (propertyName5) => !usage.destructuring?.propertyNames.has(propertyName5)
+        );
+        if (missingPropertyNames.some((propertyName5) => hasBinding(context, firstDirectMember, propertyName5))) {
+          continue;
+        }
         context.report({
           node: firstDirectMember,
           message: scopeUsageMessage(sourceText, usage.propertyNames),
           fix(fixer) {
-            const propertyNames = [...usage.propertyNames];
-            const missingPropertyNames = propertyNames.filter(
-              (propertyName5) => !usage.destructuring?.propertyNames.has(propertyName5)
-            );
-            if (missingPropertyNames.some((propertyName5) => hasBinding(context, firstDirectMember, propertyName5))) {
-              return null;
-            }
             const memberFixes = usage.directMembers.map(
               ({ member, propertyName: propertyName5 }) => fixer.replaceText(member, propertyName5)
             );
@@ -6452,11 +6457,11 @@ ${indentation}`;
       "Program:exit": exitUsageScope,
       BlockStatement: enterUsageScope,
       "BlockStatement:exit": exitUsageScope,
-      FunctionDeclaration: enterUsageScope,
+      FunctionDeclaration: enterUsageBarrier,
       "FunctionDeclaration:exit": exitUsageScope,
-      FunctionExpression: enterUsageScope,
+      FunctionExpression: enterUsageBarrier,
       "FunctionExpression:exit": exitUsageScope,
-      ArrowFunctionExpression: enterUsageScope,
+      ArrowFunctionExpression: enterUsageBarrier,
       "ArrowFunctionExpression:exit": exitUsageScope,
       MemberExpression(node) {
         recordMemberUsage(context, currentUsageScope(), ownershipResolver, node);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pasika",
-  "version": "0.10.77",
+  "version": "0.10.79",
   "description": "Reusable agent setup package",
   "repository": {
     "type": "git",