pasika 0.10.75 → 0.10.77

package/dist/eslint/pasika/index.js

@@ -5096,6 +5096,15 @@ var ContractOwnershipIndex = class {
     if (typeDeclarations.length === 0) return { kind: "missing", ownership: "unknown" };
     return this.endpointFromDeclarations(typeDeclarations);
   }
+  sourceBinding(node, name) {
+    if (!ts7.isVariableDeclaration(node) || !node.initializer) {
+      return { kind: "missing", ownership: "unknown" };
+    }
+    const sourceType = this.checker.getTypeAtLocation(node.initializer);
+    const declarations = this.propertyDeclarations(sourceType, name);
+    if (declarations.length === 0) return { kind: "missing", ownership: "unknown" };
+    return this.endpointFromDeclarations(declarations);
+  }
   targetProperty(node, name) {
     if (!ts7.isPropertyAssignment(node) && !ts7.isShorthandPropertyAssignment(node)) {
       return { kind: "missing", ownership: "unknown" };
@@ -5314,6 +5323,10 @@ function contractOwnershipResolver(context) {
       const tsNode = nodeMap.get(node);
       return tsNode ? index.sourceMember(tsNode) : { kind: "missing", ownership: "unknown" };
     },
+    sourceBinding(node, name) {
+      const tsNode = nodeMap.get(node);
+      return tsNode ? index.sourceBinding(tsNode, name) : { kind: "missing", ownership: "unknown" };
+    },
     targetProperty(node, name) {
       const tsNode = nodeMap.get(node);
       return tsNode ? index.targetProperty(tsNode, name) : { kind: "missing", ownership: "unknown" };
@@ -5398,6 +5411,48 @@ function semanticMappingMessage(propertyName5, sourcePropertyName) {
 function unknownContractOwnershipMessage(propertyName5, sourcePropertyName) {
   return `Cannot determine contract ownership for mapping "${propertyName5}" from "${sourcePropertyName}". Define or propagate a concrete contract, make the boundary schema explicit, or connect a mirrored external schema to its defineApiContract. ${DOC4}`;
 }
+function destructuredBindingSource(context, identifier) {
+  const initialScope = context.sourceCode.getScope(identifier);
+  for (let scope = initialScope; scope !== null; scope = scope.upper) {
+    const variable = scope.variables.find(({ name }) => name === identifier.name);
+    if (!variable) continue;
+    for (const definition of variable.defs) {
+      if (definition.type !== "Variable") continue;
+      const declarator = definition.node;
+      if (declarator.id.type !== "ObjectPattern") continue;
+      for (const property of declarator.id.properties) {
+        if (property.type !== "Property" || property.computed || property.key.type !== "Identifier") continue;
+        let binding;
+        if (property.value.type === "Identifier") binding = property.value;
+        if (property.value.type === "AssignmentPattern" && property.value.left.type === "Identifier") {
+          binding = property.value.left;
+        }
+        if (binding?.name === identifier.name) {
+          return { declarator, propertyName: property.key.name };
+        }
+      }
+    }
+    return void 0;
+  }
+  return void 0;
+}
+function contractMappingViolation(propertyName5, sourcePropertyName, sourceResolution, targetResolution) {
+  if (sourceResolution.kind === "non-contract" || targetResolution.kind === "non-contract") return void 0;
+  if ((sourceResolution.ownership === "third-party" || sourceResolution.ownership === "platform") && targetResolution.kind !== "missing") {
+    return void 0;
+  }
+  if ((targetResolution.ownership === "third-party" || targetResolution.ownership === "platform") && sourceResolution.kind !== "missing") {
+    return void 0;
+  }
+  const hasDataContract = sourceResolution.kind === "data-contract" || targetResolution.kind === "data-contract";
+  if (!hasDataContract) return void 0;
+  if (sourceResolution.kind === "missing" || targetResolution.kind === "missing" || sourceResolution.ownership === "unknown" || targetResolution.ownership === "unknown") {
+    return unknownContractOwnershipMessage(propertyName5, sourcePropertyName);
+  }
+  if (sourceResolution.kind !== "data-contract") return void 0;
+  if (sourceResolution.ownership !== "first-party" || targetResolution.ownership !== "first-party") return void 0;
+  return semanticMappingMessage(propertyName5, sourcePropertyName);
+}
 var noRedundantAliasRule = {
   meta: {
     schema: [],
@@ -5464,12 +5519,28 @@ var noRedundantAliasRule = {
         if (node.value.type === "Identifier") {
           if (node.shorthand) return;
           const source = node.value.name;
+          if (propertyName5 === source) {
+            context.report({
+              node,
+              message: objectPropertyMessage(propertyName5, source),
+              fix(fixer) {
+                return fixer.replaceText(node, propertyName5);
+              }
+            });
+            return;
+          }
+          const bindingSource = destructuredBindingSource(context, node.value);
+          if (!bindingSource || !ownershipResolver) return;
+          const sourcePropertyName2 = bindingSource.propertyName;
+          if (normalizePropertyName(propertyName5) === normalizePropertyName(sourcePropertyName2)) return;
+          if (FRAMEWORK_MAPPING_KEYS.has(propertyName5) || isNamedMemberValue(sourcePropertyName2)) return;
+          const sourceResolution2 = ownershipResolver.sourceBinding(bindingSource.declarator, sourcePropertyName2);
+          const targetResolution2 = ownershipResolver.targetProperty(node, propertyName5);
+          const hasDataContract = sourceResolution2.kind === "data-contract" || targetResolution2.kind === "data-contract";
+          if (!hasDataContract) return;
           context.report({
             node,
-            message: objectPropertyMessage(propertyName5, source),
-            fix(fixer) {
-              return propertyName5 === source ? fixer.replaceText(node, propertyName5) : null;
-            }
+            message: contractMappingViolation(propertyName5, sourcePropertyName2, sourceResolution2, targetResolution2) ?? objectPropertyMessage(propertyName5, source)
           });
           return;
         }
@@ -5482,27 +5553,16 @@ var noRedundantAliasRule = {
         if (!ownershipResolver) return;
         const sourceResolution = ownershipResolver.sourceMember(node.value);
         const targetResolution = ownershipResolver.targetProperty(node, propertyName5);
-        if (sourceResolution.kind === "non-contract" || targetResolution.kind === "non-contract") return;
-        if ((sourceResolution.ownership === "third-party" || sourceResolution.ownership === "platform") && targetResolution.kind !== "missing") {
-          return;
-        }
-        if ((targetResolution.ownership === "third-party" || targetResolution.ownership === "platform") && sourceResolution.kind !== "missing") {
-          return;
-        }
-        const hasDataContract = sourceResolution.kind === "data-contract" || targetResolution.kind === "data-contract";
-        if (!hasDataContract) return;
-        if (sourceResolution.kind === "missing" || targetResolution.kind === "missing" || sourceResolution.ownership === "unknown" || targetResolution.ownership === "unknown") {
-          context.report({
-            node,
-            message: unknownContractOwnershipMessage(propertyName5, sourcePropertyName)
-          });
-          return;
-        }
-        if (sourceResolution.kind !== "data-contract") return;
-        if (sourceResolution.ownership !== "first-party" || targetResolution.ownership !== "first-party") return;
+        const violation = contractMappingViolation(
+          propertyName5,
+          sourcePropertyName,
+          sourceResolution,
+          targetResolution
+        );
+        if (!violation) return;
         context.report({
           node,
-          message: semanticMappingMessage(propertyName5, sourcePropertyName)
+          message: violation
         });
       },
       TSTypeAliasDeclaration(node) {
@@ -6073,6 +6133,7 @@ function directPropertyBinding(context, declarator) {
   if (declarator.init?.type !== "MemberExpression") return void 0;
   const member = declarator.init;
   if (member.computed || member.optional || member.property.type !== "Identifier") return void 0;
+  if (!memberCanBecomeLocal(member)) return void 0;
   if (context.sourceCode.getCommentsInside(declarator).length > 0) return void 0;
   const propertyName5 = member.property.name;
   const localName = declarator.id.name;
@@ -6098,10 +6159,56 @@ function isStableObjectSource(source) {
   if (source.computed || source.optional || source.property.type !== "Identifier") return false;
   return isStableObjectSource(source.object);
 }
+function rootIdentifierName(node) {
+  if (node.type === "Identifier") return node.name;
+  if (node.type !== "MemberExpression" || node.object.type === "Super") return void 0;
+  return rootIdentifierName(node.object);
+}
+function isCompliantLocalName(propertyName5) {
+  return !propertyName5.includes("_");
+}
+function propertyNameOf(node) {
+  if (node.type !== "Property" || node.computed) return void 0;
+  if (node.key.type === "Identifier") return node.key.name;
+  if (node.key.type === "Literal" && typeof node.key.value === "string") return node.key.value;
+  return void 0;
+}
+function renamedDirectMapping(context, member) {
+  let current = member;
+  const ancestors = context.sourceCode.getAncestors(member);
+  for (let index = ancestors.length - 1; index >= 0; index -= 1) {
+    const parent = ancestors[index];
+    if (!parent) break;
+    if (parent.type === "MemberExpression" && parent.object === current) {
+      current = parent;
+      continue;
+    }
+    if (parent.type !== "Property" || parent.value !== current) return void 0;
+    const targetName = propertyNameOf(parent);
+    const sourceName = !current.computed && current.property.type === "Identifier" ? current.property.name : void 0;
+    if (targetName === void 0 || sourceName === void 0 || targetName === sourceName) return void 0;
+    return { property: parent, sourceMember: current, targetName };
+  }
+  return void 0;
+}
+function memberCanBecomeLocal(member) {
+  if (rootIdentifierName(member) === "locales") return false;
+  return member.property.type === "Identifier" && isCompliantLocalName(member.property.name);
+}
+function directMappingRequiresQualifiedAccess(context, ownershipResolver, member) {
+  const mapping = renamedDirectMapping(context, member);
+  if (!mapping || !ownershipResolver) return false;
+  const sourceResolution = ownershipResolver.sourceMember(mapping.sourceMember);
+  const targetResolution = ownershipResolver.targetProperty(mapping.property, mapping.targetName);
+  return sourceResolution.kind === "data-contract" || targetResolution.kind === "data-contract";
+}
+function memberCanBeDestructured(context, ownershipResolver, member) {
+  return memberCanBecomeLocal(member) && !directMappingRequiresQualifiedAccess(context, ownershipResolver, member);
+}
 function objectUsage(scope, sourceText) {
   let usage = scope.objects.get(sourceText);
   if (!usage) {
-    usage = { propertyNames: /* @__PURE__ */ new Set(), directMembers: /* @__PURE__ */ new Map() };
+    usage = { propertyNames: /* @__PURE__ */ new Set(), directMembers: [] };
     scope.objects.set(sourceText, usage);
   }
   return usage;
@@ -6121,33 +6228,60 @@ function memberIsDirectVariableInitializer(context, member) {
   const parent = context.sourceCode.getAncestors(member).at(-1);
   return parent?.type === "VariableDeclarator" && parent.init === member;
 }
-function recordMemberUsage(context, scope, member) {
+function recordMemberUsage(context, scope, ownershipResolver, member) {
   if (!scope || member.computed || member.optional || member.property.type !== "Identifier") return;
+  if (!memberCanBeDestructured(context, ownershipResolver, member)) return;
   if (!isStableObjectSource(member.object) || !memberIsRead(context, member)) return;
   const sourceText = context.sourceCode.getText(member.object);
   const usage = objectUsage(scope, sourceText);
   const propertyName5 = member.property.name;
   usage.propertyNames.add(propertyName5);
-  if (!memberIsDirectVariableInitializer(context, member) && !usage.directMembers.has(propertyName5)) {
-    usage.directMembers.set(propertyName5, member);
+  if (!memberIsDirectVariableInitializer(context, member)) {
+    usage.directMembers.push({ member, propertyName: propertyName5 });
   }
 }
 function recordDestructuringUsage(context, scope, declaration) {
   if (!scope) return;
   for (const declarator of declaration.declarations) {
     if (declarator.id.type !== "ObjectPattern" || !declarator.init || !isStableObjectSource(declarator.init)) continue;
+    if (rootIdentifierName(declarator.init) === "locales") continue;
     const sourceText = context.sourceCode.getText(declarator.init);
     const usage = objectUsage(scope, sourceText);
+    const propertyNames = /* @__PURE__ */ new Set();
     for (const property of declarator.id.properties) {
       if (property.type !== "Property" || property.computed || property.key.type !== "Identifier") continue;
+      if (!isCompliantLocalName(property.key.name)) continue;
+      propertyNames.add(property.key.name);
       usage.propertyNames.add(property.key.name);
     }
+    usage.destructuring ??= { pattern: declarator.id, propertyNames };
   }
 }
 function scopeUsageMessage(sourceText, propertyNames) {
   const names = [...propertyNames].map((name) => `"${name}"`).join(", ");
   return `${names} are read from "${sourceText}" in the same block. Destructure them together in one declaration. ${DOC5}`;
 }
+function hasBinding(context, node, name) {
+  const initialScope = context.sourceCode.getScope(node);
+  if (initialScope.variables.some((variable) => variable.name === name)) return true;
+  for (let scope = initialScope.upper; scope !== null; scope = scope.upper) {
+    if (scope.variables.some((variable) => variable.name === name)) return true;
+  }
+  return false;
+}
+function containingStatement(context, scopeNode, node) {
+  if (scopeNode.type !== "Program" && scopeNode.type !== "BlockStatement") return void 0;
+  const [nodeStart, nodeEnd] = context.sourceCode.getRange(node);
+  return scopeNode.body.find((statement) => {
+    const [statementStart, statementEnd] = context.sourceCode.getRange(statement);
+    return statementStart <= nodeStart && statementEnd >= nodeEnd;
+  });
+}
+function statementIndentation(context, statement) {
+  const [start] = context.sourceCode.getRange(statement);
+  const lineStart = context.sourceCode.text.lastIndexOf("\n", start - 1) + 1;
+  return context.sourceCode.text.slice(lineStart, start);
+}
 function whitespaceKeepsStatementsAdjacent(text) {
   if (text.trim() !== "") return false;
   return (text.match(/\n/gu) ?? []).length <= 1;
@@ -6188,12 +6322,13 @@ function destructuringSelection(context, declaration) {
   if (declaration.declarations.length !== 1) return void 0;
   const declarator = declaration.declarations[0];
   if (declarator?.id.type !== "ObjectPattern" || !declarator.init) return void 0;
+  if (rootIdentifierName(declarator.init) === "locales") return void 0;
   if (context.sourceCode.getCommentsInside(declarator).length > 0) return void 0;
   const bindingTexts = [];
   const localNames = [];
   const propertyNames = [];
   for (const property of declarator.id.properties) {
-    if (property.type !== "Property" || property.computed || property.key.type !== "Identifier" || property.value.type !== "Identifier" || property.key.name !== property.value.name) {
+    if (property.type !== "Property" || property.computed || property.key.type !== "Identifier" || !isCompliantLocalName(property.key.name) || property.value.type !== "Identifier" || property.key.name !== property.value.name) {
       return void 0;
     }
     bindingTexts.push(context.sourceCode.getText(property));
@@ -6262,22 +6397,53 @@ var preferObjectDestructuringRule = {
     }
   },
   create(context) {
+    const ownershipResolver = contractOwnershipResolver(context);
     const grouped = /* @__PURE__ */ new Set();
     const usageScopes = [];
     const currentUsageScope = () => usageScopes.at(-1);
-    const enterUsageScope = () => {
-      usageScopes.push({ objects: /* @__PURE__ */ new Map() });
+    const enterUsageScope = (node) => {
+      usageScopes.push({ node, objects: /* @__PURE__ */ new Map() });
     };
     const exitUsageScope = () => {
       const scope = usageScopes.pop();
       if (!scope) return;
       for (const [sourceText, usage] of scope.objects) {
-        if (usage.propertyNames.size < 2 || usage.directMembers.size === 0) continue;
-        const firstDirectMember = usage.directMembers.values().next().value;
-        if (!firstDirectMember) continue;
+        if (usage.propertyNames.size < 2 || usage.directMembers.length === 0) continue;
+        const firstDirectUsage = usage.directMembers[0];
+        if (!firstDirectUsage) continue;
+        const { member: firstDirectMember } = firstDirectUsage;
         context.report({
           node: firstDirectMember,
-          message: scopeUsageMessage(sourceText, usage.propertyNames)
+          message: scopeUsageMessage(sourceText, usage.propertyNames),
+          fix(fixer) {
+            const propertyNames = [...usage.propertyNames];
+            const missingPropertyNames = propertyNames.filter(
+              (propertyName5) => !usage.destructuring?.propertyNames.has(propertyName5)
+            );
+            if (missingPropertyNames.some((propertyName5) => hasBinding(context, firstDirectMember, propertyName5))) {
+              return null;
+            }
+            const memberFixes = usage.directMembers.map(
+              ({ member, propertyName: propertyName5 }) => fixer.replaceText(member, propertyName5)
+            );
+            if (usage.destructuring) {
+              if (missingPropertyNames.length === 0) return memberFixes;
+              const patternText = context.sourceCode.getText(usage.destructuring.pattern);
+              const closeIndex = patternText.lastIndexOf("}");
+              const beforeClose = patternText.slice(0, closeIndex);
+              const contentEnd = beforeClose.trimEnd().length;
+              const trailingWhitespace = beforeClose.slice(contentEnd);
+              const separator = usage.destructuring.propertyNames.size > 0 ? ", " : "";
+              const replacement = `${beforeClose.slice(0, contentEnd)}${separator}${missingPropertyNames.join(", ")}${trailingWhitespace}${patternText.slice(closeIndex)}`;
+              return [fixer.replaceText(usage.destructuring.pattern, replacement), ...memberFixes];
+            }
+            const statement = containingStatement(context, scope.node, firstDirectMember);
+            if (!statement) return null;
+            const indentation = statementIndentation(context, statement);
+            const declaration = `const { ${propertyNames.join(", ")} } = ${sourceText};
+${indentation}`;
+            return [fixer.insertTextBefore(statement, declaration), ...memberFixes];
+          }
         });
       }
     };
@@ -6293,7 +6459,7 @@ var preferObjectDestructuringRule = {
       ArrowFunctionExpression: enterUsageScope,
       "ArrowFunctionExpression:exit": exitUsageScope,
       MemberExpression(node) {
-        recordMemberUsage(context, currentUsageScope(), node);
+        recordMemberUsage(context, currentUsageScope(), ownershipResolver, node);
       },
       VariableDeclaration(node) {
         recordDestructuringUsage(context, currentUsageScope(), node);
@@ -7057,7 +7223,7 @@ import path49 from "path";
 function isCamelCase(name) {
   return /^[a-z][a-zA-Z0-9]*$/.test(name);
 }
-function rootIdentifierName(node) {
+function rootIdentifierName2(node) {
   let current = node;
   for (; ; ) {
     if (current.type === "Identifier") return current.name;
@@ -7102,7 +7268,7 @@ var schemaCasingRule = {
         const container = declaration.parent;
         const isModuleLevel = container.type === "Program" || container.type === "ExportNamedDeclaration" && container.parent.type === "Program";
         if (!isModuleLevel) return;
-        if (!node.init || rootIdentifierName(node.init) !== zodLocalName) return;
+        if (!node.init || rootIdentifierName2(node.init) !== zodLocalName) return;
         const { name } = node.id;
         if (isCamelCase(name)) return;
         context.report({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pasika",
-  "version": "0.10.75",
+  "version": "0.10.77",
   "description": "Reusable agent setup package",
   "repository": {
     "type": "git",