pasika 0.10.68 → 0.10.70

package/dist/eslint/pasika/index.js

@@ -5006,54 +5006,6 @@ var noMixedConcernsRule = {
 import path39 from "path";
 var DOC4 = "See docs/next-codebase-guide/rules/redundant-aliases-rule.md";
 var VALUE_SENTINELS = /* @__PURE__ */ new Set(["undefined", "NaN", "Infinity"]);
-var RESERVED_LOCAL_NAMES = /* @__PURE__ */ new Set([
-  "await",
-  "break",
-  "case",
-  "catch",
-  "class",
-  "const",
-  "continue",
-  "debugger",
-  "default",
-  "delete",
-  "do",
-  "else",
-  "enum",
-  "export",
-  "extends",
-  "false",
-  "finally",
-  "for",
-  "function",
-  "if",
-  "implements",
-  "import",
-  "in",
-  "instanceof",
-  "interface",
-  "let",
-  "new",
-  "null",
-  "package",
-  "private",
-  "protected",
-  "public",
-  "return",
-  "static",
-  "super",
-  "switch",
-  "this",
-  "throw",
-  "true",
-  "try",
-  "typeof",
-  "var",
-  "void",
-  "while",
-  "with",
-  "yield"
-]);
 var HTTP_METHODS = /* @__PURE__ */ new Set(["GET", "POST", "PUT", "PATCH", "DELETE", "HEAD", "OPTIONS"]);
 var PRIMITIVE_TYPE_NAMES = {
   TSBigIntKeyword: "bigint",
@@ -5086,61 +5038,12 @@ function aliasMessage(alias, source) {
   const sourceName = source ?? "the original symbol";
   return `"${aliasName}" only renames "${sourceName}". Use "${sourceName}" directly or rename the original symbol and its consumers. ${DOC4}`;
 }
-function objectPropertyMessage(propertyName4, source, identifierValue) {
-  if (!identifierValue) {
-    return `"${propertyName4}" maps "${source}" inline. Bind it as "${propertyName4}" before this object and use property shorthand. ${DOC4}`;
-  }
-  if (source === propertyName4) return `Use property shorthand for "${propertyName4}". ${DOC4}`;
-  return `"${propertyName4}" maps the local "${source}" inline. Rename the producer to "${propertyName4}" and use property shorthand. ${DOC4}`;
-}
-function findVariable(context, node) {
-  let scope = context.sourceCode.getScope(node);
-  while (scope) {
-    const variable = scope.set.get(node.name);
-    if (variable) return variable;
-    scope = scope.upper;
-  }
-  return void 0;
+function bindingAliasMessage(alias, source) {
+  return `"${alias}" renames "${source}" while creating a binding. Keep the original name and map it only at the object boundary. ${DOC4}`;
 }
-function isExportedVariable2(context, variable) {
-  return variable.defs.some(
-    (definition) => definition.type === "Variable" && context.sourceCode.getAncestors(definition.parent).at(-1)?.type === "ExportNamedDeclaration"
-  );
-}
-function canUsePropertyNameAsLocal(name) {
-  return /^[a-z][A-Za-z0-9]*$/u.test(name) && !RESERVED_LOCAL_NAMES.has(name);
-}
-function visibleVariable(context, node, name) {
-  let scope = context.sourceCode.getScope(node);
-  while (scope) {
-    const variable = scope.set.get(name);
-    if (variable) return variable;
-    scope = scope.upper;
-  }
-  return void 0;
-}
-function canRenameIdentifierProducer(context, node, targetName) {
-  const variable = findVariable(context, node);
-  if (!variable || isExportedVariable2(context, variable)) return false;
-  const targetVariable = visibleVariable(context, node, targetName);
-  if (targetVariable && targetVariable !== variable) return false;
-  const definition = variable.defs[0];
-  if (!definition || variable.defs.length !== 1) return false;
-  if (definition.type !== "Variable" || definition.parent.kind !== "const") return false;
-  return variable.references.filter((reference) => reference.isRead()).length === 1;
-}
-function memberRootIdentifier(node) {
-  let current = node;
-  while (current.type === "MemberExpression") current = current.object;
-  return current.type === "Identifier" ? current : void 0;
-}
-function canBindMemberExpression(context, node, targetName) {
-  if (visibleVariable(context, node, targetName)) return false;
-  const root = memberRootIdentifier(node);
-  if (!root) return true;
-  if (/^[A-Z]/u.test(root.name)) return false;
-  const variable = findVariable(context, root);
-  return !variable?.defs.some((definition) => definition.type === "ImportBinding");
+function objectPropertyMessage(propertyName4, source) {
+  if (source === propertyName4) return `Use property shorthand for "${propertyName4}". ${DOC4}`;
+  return `"${propertyName4}" maps the local "${source}". Keep the local name or map directly from its source object instead. ${DOC4}`;
 }
 var noRedundantAliasRule = {
   meta: {
@@ -5148,41 +5051,68 @@ var noRedundantAliasRule = {
     type: "problem",
     fixable: "code",
     docs: {
-      description: "Disallow redundant aliases and inline identifier/member-expression object mappings."
+      description: "Disallow renamed bindings while allowing explicit cross-object property mappings."
     }
   },
   create(context) {
     return {
       VariableDeclarator(node) {
-        if (node.id.type !== "Identifier" || node.init?.type !== "Identifier") return;
+        if (node.id.type !== "Identifier" || !node.init) return;
         const declaration = node.parent;
         if (declaration.type !== "VariableDeclaration" || declaration.kind !== "const") return;
-        const exported = declaration.parent.type === "ExportNamedDeclaration";
-        const frameworkRouteAlias = path39.basename(context.filename) === "route.ts" && exported && HTTP_METHODS.has(node.id.name);
-        if (frameworkRouteAlias || VALUE_SENTINELS.has(node.init.name)) return;
+        if (node.init.type === "Identifier") {
+          const exported = declaration.parent.type === "ExportNamedDeclaration";
+          const frameworkRouteAlias = path39.basename(context.filename) === "route.ts" && exported && HTTP_METHODS.has(node.id.name);
+          if (frameworkRouteAlias || VALUE_SENTINELS.has(node.init.name)) return;
+          context.report({
+            node,
+            message: aliasMessage(node.id.name, node.init.name)
+          });
+          return;
+        }
+        if (node.init.type !== "MemberExpression") return;
+        let propertyName4;
+        if (!node.init.computed && node.init.property.type === "Identifier") {
+          propertyName4 = node.init.property.name;
+        }
+        if (node.init.computed && node.init.property.type === "Literal" && typeof node.init.property.value === "string") {
+          propertyName4 = node.init.property.value;
+        }
+        if (propertyName4 === void 0 || propertyName4 === node.id.name) return;
         context.report({
           node,
-          message: aliasMessage(node.id.name, node.init.name)
+          message: bindingAliasMessage(node.id.name, context.sourceCode.getText(node.init))
         });
       },
       Property(node) {
-        if (node.parent.type !== "ObjectExpression" || node.computed || node.key.type !== "Identifier") return;
-        if (node.value.type !== "Identifier" && node.value.type !== "MemberExpression") return;
-        const propertyName4 = node.key.name;
-        if (!canUsePropertyNameAsLocal(propertyName4)) return;
-        const propertyValue = node.value;
-        const source = context.sourceCode.getText(propertyValue);
-        if (propertyValue.type === "Identifier") {
-          if (node.shorthand) return;
-          if (source !== propertyName4 && !canRenameIdentifierProducer(context, propertyValue, propertyName4)) return;
-        } else if (!canBindMemberExpression(context, propertyValue, propertyName4)) {
+        if (node.computed) return;
+        let propertyName4;
+        if (node.key.type === "Identifier") propertyName4 = node.key.name;
+        if (node.key.type === "Literal" && typeof node.key.value === "string") {
+          propertyName4 = node.key.value;
+        }
+        if (propertyName4 === void 0) return;
+        if (node.parent.type === "ObjectPattern") {
+          let binding;
+          if (node.value.type === "Identifier") binding = node.value;
+          if (node.value.type === "AssignmentPattern" && node.value.left.type === "Identifier") {
+            binding = node.value.left;
+          }
+          if (!binding || binding.name === propertyName4) return;
+          context.report({
+            node,
+            message: bindingAliasMessage(binding.name, propertyName4)
+          });
           return;
         }
+        if (node.parent.type !== "ObjectExpression" || node.value.type !== "Identifier") return;
+        if (node.shorthand) return;
+        const source = node.value.name;
         context.report({
           node,
-          message: objectPropertyMessage(propertyName4, source, propertyValue.type === "Identifier"),
+          message: objectPropertyMessage(propertyName4, source),
           fix(fixer) {
-            return propertyValue.type === "Identifier" && propertyValue.name === propertyName4 ? fixer.replaceText(node, propertyName4) : null;
+            return propertyName4 === source ? fixer.replaceText(node, propertyName4) : null;
           }
         });
       },
@@ -5197,6 +5127,13 @@ var noRedundantAliasRule = {
           message: aliasMessage(node.id?.name, source)
         });
       },
+      ImportSpecifier(node) {
+        if (node.imported.type !== "Identifier" || node.imported.name === node.local.name) return;
+        context.report({
+          node,
+          message: bindingAliasMessage(node.local.name, node.imported.name)
+        });
+      },
       ExportNamedDeclaration(node) {
         for (const specifier of node.specifiers) {
           if (specifier.local.type !== "Identifier" || specifier.exported.type !== "Identifier") continue;
@@ -5747,10 +5684,10 @@ function directPropertyBinding(context, declarator) {
   if (declarator.init?.type !== "MemberExpression") return void 0;
   const member = declarator.init;
   if (member.computed || member.optional || member.property.type !== "Identifier") return void 0;
-  if (!canGroupSource(member.object)) return void 0;
   if (context.sourceCode.getCommentsInside(declarator).length > 0) return void 0;
   const propertyName4 = member.property.name;
   const localName = declarator.id.name;
+  if (propertyName4 !== localName) return void 0;
   const source = member.object;
   const sourceText = context.sourceCode.getText(source);
   return {
@@ -5760,7 +5697,7 @@ function directPropertyBinding(context, declarator) {
     localName,
     source,
     sourceText,
-    bindingText: propertyName4 === localName ? propertyName4 : `${propertyName4}: ${localName}`
+    bindingText: propertyName4
   };
 }
 function canGroupSource(source) {
@@ -5771,7 +5708,7 @@ function whitespaceKeepsStatementsAdjacent(text) {
   return (text.match(/\n/gu) ?? []).length <= 1;
 }
 function groupedDeclarations(context, declaration, firstBinding) {
-  if (declaration.declarations.length !== 1 || !canGroupSource(firstBinding.source)) {
+  if (declaration.declarations.length !== 1) {
     return [{ declaration, binding: firstBinding }];
   }
   const parent = context.sourceCode.getAncestors(declaration).at(-1);
@@ -5792,7 +5729,7 @@ function groupedDeclarations(context, declaration, firstBinding) {
     if (!nextDeclarator) break;
     const nextBinding = directPropertyBinding(context, nextDeclarator);
     if (nextBinding?.sourceText !== firstBinding.sourceText) break;
-    if (!canGroupSource(nextBinding.source) || seenProperties.has(nextBinding.propertyName)) break;
+    if (seenProperties.has(nextBinding.propertyName)) break;
     const [, previousEnd] = context.sourceCode.getRange(previous);
     const [nextStart] = context.sourceCode.getRange(nextNode);
     const gap = context.sourceCode.text.slice(previousEnd, nextStart);
@@ -5802,6 +5739,56 @@ function groupedDeclarations(context, declaration, firstBinding) {
   }
   return group;
 }
+function destructuringSelection(context, declaration) {
+  if (declaration.declarations.length !== 1) return void 0;
+  const declarator = declaration.declarations[0];
+  if (declarator?.id.type !== "ObjectPattern" || !declarator.init) return void 0;
+  if (context.sourceCode.getCommentsInside(declarator).length > 0) return void 0;
+  const bindingTexts = [];
+  const localNames = [];
+  const propertyNames = [];
+  for (const property of declarator.id.properties) {
+    if (property.type !== "Property" || property.computed || property.key.type !== "Identifier" || property.value.type !== "Identifier" || property.key.name !== property.value.name) {
+      return void 0;
+    }
+    bindingTexts.push(context.sourceCode.getText(property));
+    localNames.push(property.value.name);
+    propertyNames.push(property.key.name);
+  }
+  if (bindingTexts.length === 0) return void 0;
+  return {
+    declaration,
+    source: declarator.init,
+    sourceText: context.sourceCode.getText(declarator.init),
+    bindingTexts,
+    localNames,
+    propertyNames
+  };
+}
+function groupedDestructuringSelections(context, first) {
+  const parent = context.sourceCode.getAncestors(first.declaration).at(-1);
+  if (parent?.type !== "Program" && parent?.type !== "BlockStatement") return [first];
+  const body = parent.body;
+  const startIndex = body.indexOf(first.declaration);
+  if (startIndex < 0) return [first];
+  const group = [first];
+  const seenProperties = new Set(first.propertyNames);
+  for (let index = startIndex + 1; index < body.length; index += 1) {
+    const nextNode = body[index];
+    const previous = group.at(-1)?.declaration;
+    if (!previous || nextNode?.type !== "VariableDeclaration" || nextNode.kind !== first.declaration.kind) break;
+    const next = destructuringSelection(context, nextNode);
+    if (next?.sourceText !== first.sourceText) break;
+    if (next.propertyNames.some((propertyName4) => seenProperties.has(propertyName4))) break;
+    const [, previousEnd] = context.sourceCode.getRange(previous);
+    const [nextStart] = context.sourceCode.getRange(nextNode);
+    const gap = context.sourceCode.text.slice(previousEnd, nextStart);
+    if (!whitespaceKeepsStatementsAdjacent(gap)) break;
+    group.push(next);
+    for (const propertyName4 of next.propertyNames) seenProperties.add(propertyName4);
+  }
+  return group;
+}
 function declarationTerminator(context, declaration) {
   return context.sourceCode.getText(declaration).trimEnd().endsWith(";") ? ";" : "";
 }
@@ -5810,9 +5797,15 @@ function singleMessage(binding) {
 }
 function groupMessage(bindings) {
   const firstBinding = bindings[0];
-  if (!firstBinding) return `Use object destructuring. ${DOC5}`;
+  if (!firstBinding) return `Use one object destructuring declaration. ${DOC5}`;
   const names = bindings.map(({ localName }) => `"${localName}"`).join(", ");
-  return `${names} are derived directly from properties of "${firstBinding.sourceText}". Use object destructuring. ${DOC5}`;
+  return `${names} are derived directly from properties of "${firstBinding.sourceText}". Use one object destructuring declaration. ${DOC5}`;
+}
+function repeatedDestructuringMessage(group) {
+  const first = group[0];
+  if (!first) return `Combine repeated destructuring into one declaration. ${DOC5}`;
+  const names = group.flatMap(({ localNames }) => localNames).map((name) => `"${name}"`).join(", ");
+  return `${names} destructure the same source "${first.sourceText}" repeatedly. Combine them into one object destructuring declaration. ${DOC5}`;
 }
 var preferObjectDestructuringRule = {
   meta: {
@@ -5828,10 +5821,50 @@ var preferObjectDestructuringRule = {
     return {
       VariableDeclaration(node) {
         if (grouped.has(node)) return;
+        const selection = destructuringSelection(context, node);
+        if (selection) {
+          const group = groupedDestructuringSelections(context, selection);
+          if (group.length <= 1) return;
+          for (const item of group.slice(1)) grouped.add(item.declaration);
+          const lastDeclaration = group.at(-1)?.declaration;
+          if (!lastDeclaration) return;
+          context.report({
+            node,
+            message: repeatedDestructuringMessage(group),
+            fix(fixer) {
+              if (!canGroupSource(selection.source)) return null;
+              const [start] = context.sourceCode.getRange(node);
+              const [, end] = context.sourceCode.getRange(lastDeclaration);
+              const terminator = declarationTerminator(context, lastDeclaration);
+              const pattern = group.flatMap(({ bindingTexts }) => bindingTexts).join(", ");
+              return fixer.replaceTextRange(
+                [start, end],
+                `${node.kind} { ${pattern} } = ${selection.sourceText}${terminator}`
+              );
+            }
+          });
+          return;
+        }
         const bindings = node.declarations.map((declarator) => directPropertyBinding(context, declarator)).filter((binding) => binding !== void 0);
         if (bindings.length === 0) return;
         const firstBinding = bindings[0];
         if (!firstBinding) return;
+        const sameSourceBindings = bindings.length > 1 && bindings.length === node.declarations.length && bindings.every(({ sourceText }) => sourceText === firstBinding.sourceText) && new Set(bindings.map(({ propertyName: propertyName4 }) => propertyName4)).size === bindings.length;
+        if (sameSourceBindings) {
+          context.report({
+            node,
+            message: groupMessage(bindings),
+            fix(fixer) {
+              if (!canGroupSource(firstBinding.source) || context.sourceCode.getCommentsInside(node).length > 0) {
+                return null;
+              }
+              const terminator = declarationTerminator(context, node);
+              const pattern = bindings.map(({ bindingText }) => bindingText).join(", ");
+              return fixer.replaceText(node, `${node.kind} { ${pattern} } = ${firstBinding.sourceText}${terminator}`);
+            }
+          });
+          return;
+        }
         if (node.declarations.length === 1 && bindings.length === 1) {
           const group = groupedDeclarations(context, node, firstBinding);
           if (group.length > 1) {
@@ -5843,6 +5876,7 @@ var preferObjectDestructuringRule = {
               node,
               message: groupMessage(groupBindings),
               fix(fixer) {
+                if (!canGroupSource(firstBinding.source)) return null;
                 const [start] = context.sourceCode.getRange(node);
                 const [, end] = context.sourceCode.getRange(lastDeclaration);
                 const terminator = declarationTerminator(context, lastDeclaration);
@@ -5857,6 +5891,7 @@ var preferObjectDestructuringRule = {
           }
         }
         for (const binding of bindings) {
+          if (!canGroupSource(binding.source)) continue;
           context.report({
             node: binding.declarator,
             message: singleMessage(binding),
@@ -7819,7 +7854,7 @@ var typeExtractionRule = {
     schema: [],
     type: "problem",
     docs: {
-      description: "Require a type or schema imported without its defining code to be extracted."
+      description: "Require unused type and schema exports to stay local, and independently consumed ones to be extracted."
     }
   },
   create(context) {
@@ -7837,7 +7872,13 @@ var typeExtractionRule = {
     for (const exp of module.exports) {
       if (exp.kind !== "type" && exp.kind !== "schema") continue;
       const consumers = [...index.symbolConsumers.get(symbolKey(file, exp.name)) ?? []];
-      if (consumers.length === 0) continue;
+      if (consumers.length === 0) {
+        findings.push({
+          line: exp.line,
+          message: `${exp.kind} "${exp.name}" has no external consumers; remove its export and keep it local. See docs/next-codebase-guide/rules/types-and-schemas-rule.md`
+        });
+        continue;
+      }
       if (componentExport) {
         const componentConsumers = index.symbolConsumers.get(symbolKey(file, componentExport.name)) ?? /* @__PURE__ */ new Set();
         const independent2 = consumers.filter((consumer) => !componentConsumers.has(consumer));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pasika",
-  "version": "0.10.68",
+  "version": "0.10.70",
   "description": "Reusable agent setup package",
   "repository": {
     "type": "git",