pasika 0.10.37 → 0.10.39

package/README.md

@@ -105,7 +105,7 @@ The guides ship in this repository and are adopted into a project through `vulyk
 npm run lint         # eslint, including the framework's own docs rules
 npm run typecheck
 npm run test:unit
-npm run coverage     # every requirement still has recorded enforcement
+npm run test:requirements # every requirement still has recorded enforcement
 npm run build
 npm run dogfood -- ../some/repo   # lint a sibling repo with the built presets
 ```

package/dist/eslint/pasika/index.js

@@ -605,25 +605,55 @@ var noMixedConcernsRule = {
 };
 
 // eslint/rules/no-arbitrary-tailwind.ts
-var ARBITRARY_VALUE_RE = /(?:^|(?<=\s))(?:[a-z]+(?:-[a-z]+)*)-\[[^\]]+\](?![-\w]*:)/g;
+var ARBITRARY_VALUE_RE = /\[[^\]]+\]/;
+var CUSTOM_PROPERTY_VALUE_RE = /\((?:[a-z][a-z0-9-]*:)?--[^)]+\)/;
+function baseUtility(className) {
+  let squareDepth = 0;
+  let roundDepth = 0;
+  let lastVariantSeparator = -1;
+  for (let index = 0; index < className.length; index += 1) {
+    const character = className[index];
+    if (character === "[") squareDepth += 1;
+    else if (character === "]") squareDepth = Math.max(0, squareDepth - 1);
+    else if (character === "(") roundDepth += 1;
+    else if (character === ")") roundDepth = Math.max(0, roundDepth - 1);
+    else if (character === ":" && squareDepth === 0 && roundDepth === 0) lastVariantSeparator = index;
+  }
+  return className.slice(lastVariantSeparator + 1);
+}
+function rawValueUtility(className) {
+  const utility = baseUtility(className);
+  if (ARBITRARY_VALUE_RE.test(utility) || CUSTOM_PROPERTY_VALUE_RE.test(utility)) {
+    return utility;
+  }
+  return void 0;
+}
 var CLASS_HELPERS = /* @__PURE__ */ new Set(["cn", "clsx", "twMerge", "twJoin"]);
+function isClassProperty(property) {
+  const { key } = property;
+  if (key.type === "Identifier") return key.name === "className" || key.name === "class";
+  if (key.type !== "Literal" || typeof key.value !== "string") return false;
+  return key.value === "className" || key.value === "class";
+}
 var noArbitraryTailwindRule = {
   meta: {
     schema: [],
     type: "problem",
     docs: {
-      description: "Disallow Tailwind arbitrary-value classes like rounded-[13px]."
+      description: "Disallow raw Tailwind arbitrary and custom-property value classes in components."
     }
   },
   create(context) {
     function reportClassString(node, value) {
-      ARBITRARY_VALUE_RE.lastIndex = 0;
-      const match = ARBITRARY_VALUE_RE.exec(value);
-      if (!match) return;
-      context.report({
-        node,
-        message: `Tailwind arbitrary-value class "${match[0]}" is not allowed. Use a named token or custom utility. See docs/next-tailwind-guide/rules/arbitrary-value-rule.md`
-      });
+      for (const className of value.split(/\s+/)) {
+        if (!className) continue;
+        const utility = rawValueUtility(className);
+        if (!utility) continue;
+        context.report({
+          node,
+          message: `Tailwind raw-value class "${utility}" is not allowed. Define and use a named utility instead. See docs/next-tailwind-guide/rules/arbitrary-value-rule.md`
+        });
+      }
     }
     function checkExpression(node, expression) {
       if (!expression) return;
@@ -645,6 +675,10 @@ var noArbitraryTailwindRule = {
         checkExpression(node, expression.alternate);
         return;
       }
+      if (expression.type === "AssignmentPattern") {
+        checkExpression(node, expression.right);
+        return;
+      }
       if (expression.type === "ArrayExpression") {
         for (const element of expression.elements) checkExpression(node, element);
         return;
@@ -655,6 +689,34 @@ var noArbitraryTailwindRule = {
         }
       }
     }
+    function checkCvaExpression(node, expression) {
+      if (!expression) return;
+      if (expression.type === "ObjectExpression") {
+        for (const property of expression.properties) {
+          if (property.type === "Property") {
+            if (!isClassProperty(property)) checkCvaExpression(node, property.value);
+          } else {
+            checkCvaExpression(node, property.argument);
+          }
+        }
+        return;
+      }
+      if (expression.type === "ArrayExpression") {
+        for (const element of expression.elements) checkCvaExpression(node, element);
+        return;
+      }
+      if (expression.type === "LogicalExpression") {
+        checkCvaExpression(node, expression.left);
+        checkCvaExpression(node, expression.right);
+        return;
+      }
+      if (expression.type === "ConditionalExpression") {
+        checkCvaExpression(node, expression.consequent);
+        checkCvaExpression(node, expression.alternate);
+        return;
+      }
+      checkExpression(node, expression);
+    }
     return {
       JSXAttribute(node) {
         const attributeName = node.name?.name;
@@ -663,10 +725,22 @@ var noArbitraryTailwindRule = {
         if (!value) return;
         checkExpression(node, value.type === "JSXExpressionContainer" ? value.expression : value);
       },
+      Property(node) {
+        if (!isClassProperty(node)) return;
+        checkExpression(node, node.value);
+      },
       CallExpression(node) {
-        if (node.callee.type !== "Identifier" || !CLASS_HELPERS.has(node.callee.name)) return;
-        for (const argument of node.arguments) {
-          checkExpression(node, argument);
+        if (node.callee.type !== "Identifier") return;
+        if (CLASS_HELPERS.has(node.callee.name)) {
+          for (const argument of node.arguments) {
+            checkExpression(node, argument);
+          }
+          return;
+        }
+        if (node.callee.name === "cva") {
+          for (const argument of node.arguments) {
+            checkCvaExpression(node, argument);
+          }
         }
       }
     };
@@ -2844,6 +2918,7 @@ function tagName(node) {
 function isInteractive(node) {
   const name = tagName(node);
   if (name === void 0 || !INTERACTIVE_TAGS.has(name)) return false;
+  if (name === "button") return true;
   const attributes = node.openingElement?.attributes;
   if (!attributes) return false;
   return attributes.some(
@@ -2953,7 +3028,10 @@ var interactiveComponentRule = {
       JSXElement(node) {
         if (!isInteractive(node)) return;
         if (isComponentElement(node.parent)) {
-          return;
+          const name2 = tagName(node);
+          if (name2 !== "button" || isComponentRoot(node.parent)) {
+            return;
+          }
         }
         if (isInteractive(node.parent)) {
           return;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pasika",
-  "version": "0.10.37",
+  "version": "0.10.39",
   "description": "Reusable agent setup package",
   "repository": {
     "type": "git",
@@ -43,7 +43,6 @@
   ],
   "scripts": {
     "build": "tsup",
-    "coverage": "tsx scripts/coverage.ts",
     "dogfood": "tsx scripts/dogfood.ts",
     "fix": "eslint . --fix",
     "format": "prettier --check . --ignore-unknown",
@@ -52,6 +51,7 @@
     "lint:staged": "eslint --fix",
     "prepack": "npm run build",
     "prepare": "husky",
+    "test:requirements": "tsx scripts/coverage.ts",
     "test:unit": "vitest run",
     "test:unit:coverage": "vitest run --coverage",
     "test:unit:staged": "vitest related --run",