pasika 0.10.32 → 0.10.34

package/dist/eslint/pasika/index.d.ts

@@ -142,7 +142,7 @@ declare const vulykRules: {
  * One plugin object every preset block references. ESLint only permits a
  * plugin name to be redefined across configs when the value is the same
  * object reference, and several blocks share file scopes (`src/**`, the
- * manifest, `globals.css`), so a per-block plugin object would collide when
+ * manifest, `src/app/styles/globals.css`), so a per-block plugin object would collide when
  * the blocks merge.
  */
 declare const pasikaPlugin: {
@@ -214,7 +214,7 @@ declare const pasikaPlugin: {
         "component-placement": eslint.Rule.RuleModule;
         "component-casing": eslint.Rule.RuleModule;
         "application-structure": eslint.Rule.RuleModule;
-        "data-testid-case": eslint.Rule.RuleModule;
+        "data-component-case": eslint.Rule.RuleModule;
         "jsx-hygiene": eslint.Rule.RuleModule;
         "interactive-component": eslint.Rule.RuleModule;
         "ui-state": eslint.Rule.RuleModule;

package/dist/eslint/pasika/index.js

@@ -219,85 +219,40 @@ function findJsxReturningDeclarations(text, filename) {
   }
   return results;
 }
-function jsxTagName(element) {
-  const tagName2 = ts.isJsxElement(element) ? element.openingElement.tagName : element.tagName;
-  return ts.isIdentifier(tagName2) ? tagName2.text : void 0;
-}
-function rootFromExpression(expression) {
-  let unwrapped = expression;
-  while (ts.isParenthesizedExpression(unwrapped)) unwrapped = unwrapped.expression;
-  if (ts.isJsxSelfClosingElement(unwrapped)) {
-    const tagName2 = jsxTagName(unwrapped);
-    if (!tagName2?.startsWith(tagName2[0]?.toLowerCase() ?? "")) return void 0;
-    return { tagName: tagName2, attributes: [...unwrapped.attributes.properties] };
-  }
-  if (ts.isJsxElement(unwrapped)) {
-    const tagName2 = jsxTagName(unwrapped);
-    if (!tagName2?.startsWith(tagName2[0]?.toLowerCase() ?? "")) return void 0;
-    return { tagName: tagName2, attributes: [...unwrapped.openingElement.attributes.properties] };
-  }
-  return void 0;
-}
-function findSimpleRoot(component, _text, _filename) {
-  const declaration = component.declaration;
-  let body;
-  if (ts.isFunctionDeclaration(declaration)) body = declaration.body;
-  else if (declaration.initializer && ts.isArrowFunction(declaration.initializer)) body = declaration.initializer.body;
-  else if (declaration.initializer && ts.isFunctionExpression(declaration.initializer)) {
-    body = declaration.initializer.body;
-  }
-  if (!body) return void 0;
-  if (!ts.isBlock(body)) return rootFromExpression(body);
-  const returns = [];
-  const visit = (node) => {
-    if (node !== body && (ts.isFunctionLike(node) || ts.isClassLike(node))) return;
-    if (ts.isReturnStatement(node)) returns.push(node);
-    ts.forEachChild(node, visit);
-  };
-  visit(body);
-  const rendered = returns.filter((statement) => statement.expression?.kind !== ts.SyntaxKind.NullKeyword);
-  const roots = rendered.map(
-    (statement) => statement.expression && ts.isExpression(statement.expression) ? rootFromExpression(statement.expression) : void 0
-  ).filter((root) => root !== void 0);
-  if (roots.length !== rendered.length || roots.length === 0) return void 0;
-  const firstTag = roots[0]?.tagName;
-  if (roots.some((root) => root.tagName !== firstTag)) return void 0;
-  return roots[0];
-}
-function literalTestIds(attributes) {
+function componentMarkers(attributes) {
   return attributes.flatMap((candidate) => {
-    if (!ts.isJsxAttribute(candidate) || !ts.isIdentifier(candidate.name) || candidate.name.text !== "data-testid") {
+    if (!ts.isJsxAttribute(candidate) || !ts.isIdentifier(candidate.name) || candidate.name.text !== "data-component") {
       return [];
     }
-    return candidate.initializer && ts.isStringLiteral(candidate.initializer) ? [candidate.initializer.text] : [];
+    return candidate.initializer && ts.isStringLiteral(candidate.initializer) ? [candidate.initializer.text] : ["<dynamic>"];
   });
 }
-function combineTestIdPaths(left, right) {
+function combineComponentMarkerPaths(left, right) {
   return left.flatMap((leftPath) => right.map((rightPath) => [...leftPath, ...rightPath]));
 }
-function renderedTestIdPathsFromExpression(expression) {
+function renderedComponentMarkerPathsFromExpression(expression) {
   let unwrapped = expression;
   while (ts.isParenthesizedExpression(unwrapped)) unwrapped = unwrapped.expression;
   if (ts.isConditionalExpression(unwrapped)) {
     return [
-      ...renderedTestIdPathsFromExpression(unwrapped.whenTrue),
-      ...renderedTestIdPathsFromExpression(unwrapped.whenFalse)
+      ...renderedComponentMarkerPathsFromExpression(unwrapped.whenTrue),
+      ...renderedComponentMarkerPathsFromExpression(unwrapped.whenFalse)
     ];
   }
   if (ts.isJsxSelfClosingElement(unwrapped)) {
-    return [literalTestIds(unwrapped.attributes.properties)];
+    return [componentMarkers(unwrapped.attributes.properties)];
   }
   if (ts.isJsxElement(unwrapped)) {
-    let paths = [literalTestIds(unwrapped.openingElement.attributes.properties)];
+    let paths = [componentMarkers(unwrapped.openingElement.attributes.properties)];
     for (const child of unwrapped.children) {
       if (ts.isJsxElement(child) || ts.isJsxSelfClosingElement(child) || ts.isJsxFragment(child)) {
-        paths = combineTestIdPaths(paths, renderedTestIdPathsFromExpression(child));
+        paths = combineComponentMarkerPaths(paths, renderedComponentMarkerPathsFromExpression(child));
         continue;
       }
       if (ts.isJsxExpression(child) && child.expression) {
         const childExpression = child.expression;
         if (ts.isConditionalExpression(childExpression) || ts.isJsxElement(childExpression) || ts.isJsxSelfClosingElement(childExpression) || ts.isJsxFragment(childExpression) || ts.isParenthesizedExpression(childExpression)) {
-          paths = combineTestIdPaths(paths, renderedTestIdPathsFromExpression(childExpression));
+          paths = combineComponentMarkerPaths(paths, renderedComponentMarkerPathsFromExpression(childExpression));
         }
       }
     }
@@ -307,13 +262,13 @@ function renderedTestIdPathsFromExpression(expression) {
     let paths = [[]];
     for (const child of unwrapped.children) {
       if (ts.isJsxElement(child) || ts.isJsxSelfClosingElement(child) || ts.isJsxFragment(child)) {
-        paths = combineTestIdPaths(paths, renderedTestIdPathsFromExpression(child));
+        paths = combineComponentMarkerPaths(paths, renderedComponentMarkerPathsFromExpression(child));
         continue;
       }
       if (ts.isJsxExpression(child) && child.expression) {
         const childExpression = child.expression;
         if (ts.isConditionalExpression(childExpression) || ts.isJsxElement(childExpression) || ts.isJsxSelfClosingElement(childExpression) || ts.isJsxFragment(childExpression) || ts.isParenthesizedExpression(childExpression)) {
-          paths = combineTestIdPaths(paths, renderedTestIdPathsFromExpression(childExpression));
+          paths = combineComponentMarkerPaths(paths, renderedComponentMarkerPathsFromExpression(childExpression));
         }
       }
     }
@@ -321,7 +276,7 @@ function renderedTestIdPathsFromExpression(expression) {
   }
   return [[]];
 }
-function findRenderedTestIdPaths(component) {
+function findRenderedComponentMarkerPaths(component) {
   const declaration = component.declaration;
   let body;
   if (ts.isFunctionDeclaration(declaration)) body = declaration.body;
@@ -330,7 +285,7 @@ function findRenderedTestIdPaths(component) {
     body = declaration.initializer.body;
   }
   if (!body) return [];
-  if (!ts.isBlock(body)) return renderedTestIdPathsFromExpression(body);
+  if (!ts.isBlock(body)) return renderedComponentMarkerPathsFromExpression(body);
   const returns = [];
   const visit = (node) => {
     if (node !== body && (ts.isFunctionLike(node) || ts.isClassLike(node))) return;
@@ -341,18 +296,9 @@ function findRenderedTestIdPaths(component) {
   return returns.flatMap((statement) => {
     const expression = statement.expression;
     if (!expression || expression.kind === ts.SyntaxKind.NullKeyword) return [];
-    return renderedTestIdPathsFromExpression(expression);
+    return renderedComponentMarkerPathsFromExpression(expression);
   });
 }
-function getTestId(root) {
-  const attribute = root.attributes.find(
-    (candidate) => ts.isJsxAttribute(candidate) && ts.isIdentifier(candidate.name) && candidate.name.text === "data-testid"
-  );
-  if (!attribute) return {};
-  const value = attribute.initializer;
-  if (!value || !ts.isStringLiteral(value)) return { attribute };
-  return { value: value.text, attribute };
-}
 
 // eslint/rules/filename-case.ts
 var NEXT_ROUTING_FILES = /* @__PURE__ */ new Set([
@@ -2393,7 +2339,7 @@ var namedExportsRule = {
   }
 };
 
-// eslint/rules/data-testid-case.ts
+// eslint/rules/data-component-case.ts
 import path15 from "path";
 var NEXT_ROUTING_FILES2 = /* @__PURE__ */ new Set([
   "default",
@@ -2416,13 +2362,12 @@ var NEXT_ROUTING_FILES2 = /* @__PURE__ */ new Set([
   "sitemap",
   "twitter-image"
 ]);
-var isKebabCase3 = (value) => /^[a-z][a-z0-9]*(?:-[a-z0-9]+)*$/.test(value);
-var dataTestIdCaseRule = {
+var dataComponentCaseRule = {
   meta: {
     schema: [],
     type: "problem",
     docs: {
-      description: "Enforce data-testid casing for smart and dumb components with a single intrinsic root."
+      description: "Enforce stable data-component markers for React component surfaces."
     }
   },
   create(context) {
@@ -2430,41 +2375,29 @@ var dataTestIdCaseRule = {
     if (!filename.endsWith(".tsx")) return {};
     const base = path15.basename(filename, path15.extname(filename));
     if (NEXT_ROUTING_FILES2.has(base)) return {};
-    const text = context.sourceCode.text;
-    const components = parseComponentInfo(text, filename);
+    const components = parseComponentInfo(context.sourceCode.text, filename);
     return {
       Program(node) {
         for (const component of components) {
+          const expected = component.smart ? component.name : toKebabCase(component.name);
+          const renderedPaths = findRenderedComponentMarkerPaths(component);
+          const hasNoMarker = renderedPaths.every((values) => values.length === 0);
+          const hasStableMarker = renderedPaths.length > 0 && renderedPaths.every((values) => values.length === 1 && values[0] === expected);
           if (component.smart) {
-            const expected2 = component.name;
-            const renderedPaths = findRenderedTestIdPaths(component);
-            const hasStableAnchor = renderedPaths.length > 0 && renderedPaths.every((values) => values.filter((value2) => value2 === expected2).length === 1);
-            if (hasStableAnchor) continue;
-            const hasSingleWrongCasedAnchor = renderedPaths.length > 0 && renderedPaths.every((values) => values.length === 1 && values[0] !== expected2) && new Set(renderedPaths.map((values) => values[0])).size === 1;
-            if (hasSingleWrongCasedAnchor) {
-              context.report({
-                node,
-                message: `data-testid for smart component "${component.name}" must be PascalCase: expected "${expected2}".`
-              });
-              continue;
-            }
+            if (hasStableMarker) continue;
+            const hasSingleWrongMarker2 = renderedPaths.length > 0 && renderedPaths.every((values) => values.length === 1 && values[0] !== expected) && new Set(renderedPaths.map((values) => values[0])).size === 1;
             context.report({
               node,
-              message: `Smart component "${component.name}" must expose exactly one stable data-testid="${expected2}" anchor for itself in every rendered result. Place it on the existing DOM surface or on a child component that forwards data-testid instead of adding an artificial wrapper. See docs/next-codebase-guide/rules/smart-vs-dumb-component-rule.md`
+              message: hasSingleWrongMarker2 ? `data-component for smart component "${component.name}" must match the component name: expected "${expected}".` : `Smart component "${component.name}" must expose exactly one stable data-component="${expected}" marker in every rendered result. Place it on the existing meaningful DOM surface or forward it to the child component that renders that surface. See docs/next-codebase-guide/rules/smart-vs-dumb-component-rule.md`
             });
             continue;
           }
-          const root = findSimpleRoot(component, text, filename);
-          if (!root) continue;
-          const { value } = getTestId(root);
-          const expected = toKebabCase(component.name);
-          if (value === void 0 || value === expected) continue;
-          if (!isKebabCase3(value)) {
-            context.report({
-              node,
-              message: `data-testid for dumb component "${component.name}" must be kebab-case: expected "${expected}".`
-            });
-          }
+          if (hasNoMarker || hasStableMarker) continue;
+          const hasSingleWrongMarker = renderedPaths.length > 0 && renderedPaths.every((values) => values.length === 1 && values[0] !== expected) && new Set(renderedPaths.map((values) => values[0])).size === 1;
+          context.report({
+            node,
+            message: hasSingleWrongMarker ? `data-component for dumb component "${component.name}" must be kebab-case: expected "${expected}".` : `Dumb component "${component.name}" may omit data-component, but when present it must expose exactly one stable data-component="${expected}" marker on its meaningful surface.`
+          });
         }
       }
     };
@@ -7197,12 +7130,14 @@ function buildStylesheetGraph(options) {
 }
 
 // eslint/rules/tailwind/css-entry-point.ts
+var APP_STYLES_DIR = path54.join("app", "styles");
+var GLOBAL_STYLESHEET_PATH = path54.join(APP_STYLES_DIR, "globals.css");
 var cssEntryPointRule = {
   meta: {
     schema: [],
     type: "problem",
     docs: {
-      description: "Require one global entry point; project CSS only in a stylesheet it imports directly."
+      description: "Require the app/styles CSS root, one global entry point, and direct project-CSS imports."
     }
   },
   create(context) {
@@ -7223,6 +7158,7 @@ var cssEntryPointRule = {
       "StyleSheet:exit"(node) {
         if (globals.length === 0) return;
         const current = path54.normalize(path54.resolve(context.filename));
+        const relative = path54.relative(sourceRoot, current);
         if (globals.includes(current)) {
           if (globals.length > 1) {
             context.report({
@@ -7231,6 +7167,13 @@ var cssEntryPointRule = {
             });
             return;
           }
+          if (relative !== GLOBAL_STYLESHEET_PATH) {
+            context.report({
+              node,
+              message: "The global stylesheet entry point must be src/app/styles/globals.css."
+            });
+            return;
+          }
           const basename = path54.basename(current);
           const importCount = moduleFiles.filter((modulePath) => moduleImports(textOf(modulePath), basename)).length;
           if (importCount !== 1) {
@@ -7241,6 +7184,14 @@ var cssEntryPointRule = {
           }
           return;
         }
+        const isInAppStyles = relative === APP_STYLES_DIR || relative.startsWith(`${APP_STYLES_DIR}${path54.sep}`);
+        if (!isInAppStyles) {
+          context.report({
+            node,
+            message: "Project stylesheets must live under src/app/styles/."
+          });
+          return;
+        }
         const hasProjectCss = node.children.some((child) => {
           if (child.type === "Atrule" && child.name === "import") return false;
           if (child.type === "Comment") return false;
@@ -7968,7 +7919,7 @@ var pasikaNextjsAppRules = {
   "component-placement": componentPlacementRule,
   "component-casing": componentCasingRule,
   "application-structure": applicationStructureRule,
-  "data-testid-case": dataTestIdCaseRule,
+  "data-component-case": dataComponentCaseRule,
   "jsx-hygiene": jsxHygieneRule,
   "interactive-component": interactiveComponentRule,
   "ui-state": uiStateRule,
@@ -8049,7 +8000,7 @@ var pasikaNextjsAppConfig = {
   rules: Object.fromEntries(pasikaNextjsAppRuleIds.map((id) => [id, "error"]))
 };
 var tailwindStructureRules = {
-  files: ["src/**/globals.css"],
+  files: ["src/app/styles/globals.css"],
   plugins: {
     css,
     pasika: pasikaPlugin

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pasika",
-  "version": "0.10.32",
+  "version": "0.10.34",
   "description": "Reusable agent setup package",
   "repository": {
     "type": "git",