partforge 0.146.3 → 0.146.4

package/docs/AUTHORING-PARTS.md

@@ -1248,7 +1248,12 @@ export function tilePicker(host) {
 `update({reason, disabled})` is called when your key changes from outside the widget
 (`reason: "sync"` — a preset, undo, `setParams`), when `derived` changes
 (`"derived"`), and once after `host.state` was restored on mount (`"restore"`). It is
-**not** called for your own `set`. `dispose()` runs on teardown.
+**not** called for your own `set`, and a `"derived"` update is **held while a gesture is
+in flight** — a `set` with `commit: false`, or a `host.controls` sub-control being
+edited — and delivered once `host.commit()` ends it (`host.derived` is current
+throughout). That is what lets the pattern above rebuild its sub-panel on every
+`update` without pulling the slider or number box out from under the user: every
+build the drag itself triggers ends in a derived update. `dispose()` runs on teardown.
 
 **Rules that keep it working.**
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "partforge",
-  "version": "0.146.3",
+  "version": "0.146.4",
   "description": "Turn a declarative part definition into a parametric-CAD web app (three.js + Manifold/Replicad). Requires a Vite-based consumer.",
   "type": "module",
   "license": "MIT",

package/src/framework/panel/widgets/custom.js

@@ -69,6 +69,10 @@ export function makeCustom(node, params, { onChange, onCommit, info, custom = {}
   let instance = null;
   let retired = false;
   let lastDerived = "{}";
+  // A derived update that arrived while a deferred gesture was in flight
+  // (`pending` non-empty): held, delivered once the gesture commits. See
+  // `update` below.
+  let heldUpdate = false;
 
   const report = (phase, message) => onError?.({ key: node.key, label, phase, message });
 
@@ -131,6 +135,9 @@ export function makeCustom(node, params, { onChange, onCommit, info, custom = {}
       if (!changed.length) return;
       for (const k of changed) pending.delete(k);
       onCommit?.(changed);
+      // The gesture is over: deliver the derived update it held back (once,
+      // for the latest derived — host.derived already carries it).
+      if (heldUpdate && pending.size === 0) { heldUpdate = false; update("derived"); }
     },
 
     setState(patch) { if (retired) return; Object.assign(host.state, patch); },
@@ -210,7 +217,21 @@ export function makeCustom(node, params, { onChange, onCommit, info, custom = {}
     instance = r && typeof r === "object" ? r : null;
   });
 
-  const update = (reason) => guarded("update", () => instance?.update?.({ reason, disabled: host.disabled }));
+  // A derived update is HELD while a deferred gesture is in flight — a
+  // `host.set(…, {commit: false})` or a host.controls sub-control edit that
+  // has not committed yet. Every build the gesture itself triggers (a slider
+  // drag's live preview, each keystroke in a number box) ends in a derived
+  // refresh, and the documented widget pattern answers update() by rebuilding
+  // its sub-panel — which tore the input being edited out of the DOM before
+  // its `change` could fire. Chromium dispatches `change` on detach; WebKit
+  // does not, so on Safari the edit reached the viewer and was never
+  // committed (partforge-cloud feedback #172). host.derived is still updated
+  // at once; only the call is deferred, to the commit that ends the gesture.
+  // `sync` is never held: an outside write supersedes the gesture.
+  const update = (reason) => {
+    if (reason === "derived" && pending.size > 0) { heldUpdate = true; return; }
+    guarded("update", () => instance?.update?.({ reason, disabled: host.disabled }));
+  };
 
   // Restoring panel state is not part of creation: a throw here is a bad
   // `update`, not a bad `create` — the widget did construct successfully.

package/src/framework/panel/widgets/numeric.js

@@ -67,6 +67,10 @@ export function makeNumeric(node, params, { onChange, onCommit, info }) {
   // the log mapping don't, so be explicit).
   const thumbFor = (v) => log ? toPosSafe(v) : Math.max(node.min, Math.min(node.max, v));
 
+  // Edited (an `input`) since the last `change`. A widget torn down mid-edit
+  // commits what it holds (dispose below): the DOM fires no `change` for a
+  // detached input on WebKit, and the value is already in params either way.
+  let dirty = false;
   let slider = null;
   if (!numeric) {
     slider = document.createElement("input");
@@ -78,9 +82,10 @@ export function makeNumeric(node, params, { onChange, onCommit, info }) {
       params[node.key] = v;
       box.value = numStr(v);
       paintWarn();
+      dirty = true;
       onChange?.();
     });
-    slider.addEventListener("change", () => onCommit?.());
+    slider.addEventListener("change", () => { dirty = false; onCommit?.(); });
     wrap.append(slider);
   }
 
@@ -131,6 +136,7 @@ export function makeNumeric(node, params, { onChange, onCommit, info }) {
     params[node.key] = v;
     if (slider) slider.value = thumbFor(v);
     paintWarn();
+    dirty = true;
     onChange?.();
   });
   box.addEventListener("change", () => {
@@ -140,6 +146,7 @@ export function makeNumeric(node, params, { onChange, onCommit, info }) {
     box.value = numStr(v);
     if (slider) slider.value = thumbFor(v);
     paintWarn();
+    dirty = false;
     onChange?.();
     onCommit?.();
   });
@@ -150,5 +157,8 @@ export function makeNumeric(node, params, { onChange, onCommit, info }) {
     paintWarn();
   };
   paintWarn();
-  return { el: wrap, sync };
+  // Torn down with an edit still uncommitted (a sub-panel rebuilt under the
+  // pointer, a remount): commit it, since no `change` is coming.
+  const dispose = () => { if (dirty) { dirty = false; onCommit?.(); } };
+  return { el: wrap, sync, dispose };
 }