partforge 0.138.2 → 0.139.0

package/docs/AUTHORING-PARTS.md

@@ -3013,8 +3013,9 @@ instead of (or in addition to) the built-in `#part` bar:
   Resolves `null` on failure rather than throwing (a build error, a part with no sub-parts
   in that view, a disposed runtime). The render happens in a throwaway scene, so it takes
   no colour from the viewer's light/dark theme. The default `style` is `"thumbnail"`, the
-  product shot: a fixed light background, soft lights, lighter edges, a contact shadow and
-  fit framing — a thumbnail is captured once and then displayed under host chrome
+  product shot: a fixed light background, soft lights, lighter edges, a contact shadow,
+  4:3 framing (`size` is the width: 640 → 640×480, the shape of the cards it is shown in;
+  `cad` stays square) and fit framing — a thumbnail is captured once and then displayed under host chrome
   partforge cannot see. `style: "cad"` gives the agent-render look instead. `style.view` is
   only a default angle; an explicit `angle` wins. Pass `background` (any
   `THREE.Color`-compatible value) to override the style's, or `background: null` for no

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "partforge",
-  "version": "0.138.2",
+  "version": "0.139.0",
   "description": "Turn a declarative part definition into a parametric-CAD web app (three.js + Manifold/Replicad). Requires a Vite-based consumer.",
   "type": "module",
   "license": "MIT",

package/src/framework/renderStyles.js

@@ -45,7 +45,11 @@ const STYLES = {
     view: null,
   },
   thumbnail: {
-    camera: { projection: "perspective", fov: 45, framing: "fit", fill: 0.88 },
+    // aspect (width / height) is the shape of the card the product shot is
+    // shown in: 4:3 across the cloud's dashboard and library, so the shape-fitted
+    // framing fills the card exactly instead of being cropped by object-cover.
+    // A style without one (cad) is square.
+    camera: { projection: "perspective", fov: 45, framing: "fit", fill: 0.88, aspect: 4 / 3 },
     lights: {
       hemisphere: { ...CAD_LIGHTS.hemisphere, intensity: 1.65 },
       key: { ...CAD_LIGHTS.key, intensity: 1.25 },
@@ -71,6 +75,7 @@ export function validateRenderStyle(s) {
   check(inRange(s.camera.fov, 1, 120), "camera.fov");
   check(s.camera.framing === "canonical" || s.camera.framing === "fit", "camera.framing");
   if (s.camera.framing === "fit") check(inRange(s.camera.fill, 0.05, 1), "camera.fill");
+  if (s.camera.aspect !== undefined) check(inRange(s.camera.aspect, 0.25, 4), "camera.aspect");
   const h = s.lights?.hemisphere;
   check(isHex(h?.sky) && isHex(h?.ground) && inRange(h?.intensity, 0, 20), "lights.hemisphere");
   for (const k of ["key", "fill"]) {

package/src/framework/viewer.js

@@ -2228,7 +2228,11 @@ export function createViewer(container, part) {
     const worldPositions = payloads.map((p) => modelToWorld(p.positions));
     const points = new Float32Array(worldPositions.reduce((n, a) => n + a.length, 0));
     worldPositions.reduce((o, a) => { points.set(a, o); return o + a.length; }, 0);
-    const { pose, fov, sceneBounds } = stylePose(st, angle, box, { aspect: 1, points });
+    // `size` is the long (width) edge; the style's aspect (the thumbnail's 4:3
+    // card shape) sets the height, and the fit frames for that same aspect.
+    const width = size;
+    const height = Math.max(1, Math.round(size / (st.camera.aspect ?? 1)));
+    const { pose, fov, sceneBounds } = stylePose(st, angle, box, { aspect: width / height, points });
 
     // Light the throwaway scene ourselves: renderOffscreen's own key/fill (and the
     // persistent hemisphere) live in the LIVE scene, which is never rendered here — so
@@ -2272,7 +2276,7 @@ export function createViewer(container, part) {
         pose,
         // The throwaway scene holds these meshes and nothing else — no grid, no
         // gizmo — so its own bounds are the whole of what the planes must hold.
-        { width: size, height: size, fov, quality, sceneBounds },
+        { width, height, fov, quality, sceneBounds },
         tmpScene,
       );
     } finally {

package/src/testing/render.js

@@ -50,11 +50,15 @@ export function renderAngle(name) {
 // part still occludes what is behind it (real transparency needs a depth sort
 // this renderer does not do; stills only need to read as faded).
 export async function renderViewImages(kernel, part, view = Object.keys(part.views)[0], {
-  views = ["iso", "front", "top"], size = [800, 600], edges = true, params = {}, opacity = {},
+  views = ["iso", "front", "top"], size, edges = true, params = {}, opacity = {},
   style = "cad", supersample = 2,
 } = {}) {
   const { PNG } = await import("pngjs");
-  getRenderStyle(style); // a bad style fails here, before the kernel build
+  const resolved = getRenderStyle(style); // a bad style fails here, before the kernel build
+  // No size given: a style with its own aspect (the thumbnail's 4:3) sets the
+  // shape — 640 wide, the viewer's thumbnail size — else the 800×600 default.
+  // An explicit size is the caller's choice and is honoured as given.
+  if (!size) size = resolved.camera.aspect ? [640, Math.round(640 / resolved.camera.aspect)] : [800, 600];
   for (const angle of views) {
     if (!renderAngle(angle)) throw new Error(`unknown angle "${angle}" (use: ${RENDER_VIEWS.join(", ")}, or a view-cube orientation such as top-front-left)`);
   }

package/types/index.d.ts

@@ -420,7 +420,7 @@ export interface CaptureCurrentOptions {
 }
 
 export interface CaptureViewOptions {
-  /** Square render resolution in px. Default 640. */
+  /** Render width in px (the long edge). The style's aspect sets the height: `"thumbnail"` is 4:3 (640 → 640×480), `"cad"` is square. Default 640. */
   size?: number;
   /** JPEG quality, 0..1. Default 0.8. */
   quality?: number;

package/types/testing.d.ts

@@ -678,6 +678,7 @@ export function renderViews(
   opts?: {
     views?: string[];
     out?: string;
+    /** [width, height] px. Default: 800×600, or 640 wide at the style's aspect when it has one (thumbnail → 640×480). */
     size?: [number, number];
     edges?: boolean;
     params?: ResolvedParams;
@@ -708,6 +709,7 @@ export function renderViewImages(
   view?: string,
   opts?: {
     views?: string[];
+    /** [width, height] px. Default: 800×600, or 640 wide at the style's aspect when it has one (thumbnail → 640×480). */
     size?: [number, number];
     edges?: boolean;
     params?: ResolvedParams;