partforge 0.129.0 → 0.130.0

package/docs/AUTHORING-PARTS.md

@@ -353,7 +353,10 @@ meta: { title: "…", units: "mm", environment: "studio" },
 colour, flattened so dark materials stay readable. **Realistic** mode — the
 viewer's toggle — shows the full material under environment lighting, with a
 ground and soft shadow and no feature lines. The part never moves when the
-mode changes.
+mode changes. The ground is placed under the part when a view is shown and
+after each edit; while an animation plays or is scrubbed it stays where it is
+(dropping lower only if the part would otherwise sink into it), so a motion
+that changes the part's footprint never slides the floor around under it.
 
 **3D-print layer lines** (`pla-print`, `petg-print`) run perpendicular to the
 **export** pose's +Z — the way the part will be printed, not the way it is

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "partforge",
-  "version": "0.129.0",
+  "version": "0.130.0",
   "description": "Turn a declarative part definition into a parametric-CAD web app (three.js + Manifold/Replicad). Requires a Vite-based consumer.",
   "type": "module",
   "license": "MIT",

package/src/framework/animation-controls.js

@@ -504,6 +504,12 @@ export function attachAnimationControls(viewer, part, {
       // write params, or it would dirty the regen loop for a display-only fade.
       // First write for this run also remembers what the user's params were, so
       // Reset can put them back.
+      // Anything the animation moves holds the realistic floor where it is (see
+      // viewer.js placeGround): a track that rebuilds geometry re-shows the
+      // assembly every delivery, and the floor must not chase each frame's
+      // bounds. Released by a user edit, reset/stop, or a view switch — NOT by
+      // reaching the end, which would just move the jump to the last frame.
+      if (Object.keys(r.values).length || Object.keys(r.opacity ?? {}).length) viewer.holdGround?.(true);
       if (Object.keys(r.values).length) {
         if (snapshot == null) snapshot = getParamValues(current.trackedKeys);
         applyValues(r.values);
@@ -539,6 +545,9 @@ export function attachAnimationControls(viewer, part, {
   }
 
   function doReset() {
+    // Before the snapshot is re-applied: the rebuild that restores the user's
+    // params is an ordinary placement, so the floor comes back to the part.
+    viewer.holdGround?.(false);
     playback?.reset();
     viewer.cancelCameraTween();
     viewer.clearSubPartOpacities?.();
@@ -814,6 +823,7 @@ export function attachAnimationControls(viewer, part, {
     // pause playback rather than fight over them.
     notifyUserEdit() {
       disarmAutoplay();
+      viewer.holdGround?.(false); // a user edit places the floor again, as without animation
       viewer.cancelCameraTween();
       playback?.userEdited();
       syncUi();
@@ -854,6 +864,7 @@ export function attachAnimationControls(viewer, part, {
       if (status !== "playing" && status !== "intro") guarded(() => playback.play());
     },
     detach() {
+      viewer.holdGround?.(false);
       offFrame();
       offOrbit();
       viewer.clearSubPartOpacities?.();

package/src/framework/viewer.js

@@ -794,15 +794,28 @@ export function createViewer(container, part) {
   // The ground comes to the part: it sits at the bottom of what is visible and
   // is sized from it. Only on showAssembly (and on entering the mode) — an
   // animated pose change moves the shadow, never the floor.
+  //
+  // An animation that REBUILDS geometry re-shows the assembly on every
+  // delivery, though, and re-deriving the floor from each frame's bounds slides
+  // it under the part as the bounds shift (feedback #138: a lid swinging open
+  // dragged the floor back with it). So while the animation driver holds the
+  // ground, a placement reuses the last one and may only LOWER it — never slide
+  // it sideways or resize it, and never lift it into the part. The hold is
+  // viewer-wide rather than per rig, so an environment switch mid-playback
+  // lands its floor in the same place.
+  let groundHeld = false;
+  let lastGround = null;
+  function holdGround(on) { groundHeld = !!on; }
   function placeGround({ force = false } = {}) {
     if (!realisticRig) return;
     const b = getVisibleWorldBounds(); // shared Box3: read it out before anything else runs
     if (b.isEmpty()) return;
     const center = b.getCenter(new THREE.Vector3());
     const size = b.getSize(new THREE.Vector3());
-    realisticRig.setGround({
-      y: b.min.y, centerX: center.x, centerZ: center.z, radius: size.length() / 2, footprintMm: Math.max(size.x, size.z),
-    });
+    lastGround = groundHeld && lastGround
+      ? { ...lastGround, y: Math.min(lastGround.y, b.min.y) }
+      : { y: b.min.y, centerX: center.x, centerZ: center.z, radius: size.length() / 2, footprintMm: Math.max(size.x, size.z) };
+    realisticRig.setGround(lastGround);
     shadowMovedAt = null; // this render is the full-resolution one
     renderShadow(undefined, { force });
   }
@@ -2658,6 +2671,7 @@ export function createViewer(container, part) {
     onFrame,
     onAssemblyChange: (cb) => { assemblyListeners.add(cb); return () => assemblyListeners.delete(cb); },
     tweenCameraTo,
+    holdGround,
     cancelCameraTween,
     orbitBy,
     onCameraStart,