partforge 0.105.0 → 0.105.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "partforge",
-  "version": "0.105.0",
+  "version": "0.105.2",
   "description": "Turn a declarative part definition into a parametric-CAD web app (three.js + Manifold/Replicad). Requires a Vite-based consumer.",
   "type": "module",
   "license": "MIT",

package/src/framework/animation-controls.js

@@ -12,6 +12,7 @@
 // active — getView() is the driver's only window onto it.
 import { viewAnimations, createPlayback, stepIndexAt } from "./animation.js";
 import { createInfoPopover, attachInfo } from "./controls.js";
+import { stageClearFor } from "./stage-clear.js";
 
 function el(tag, className, text) {
   const node = document.createElement(tag);
@@ -675,13 +676,14 @@ export function attachAnimationControls(viewer, part, {
     const barRect = bar.getBoundingClientRect();
     // Publish the bar's vertical claim on the stage as --pf-anim-clear: the
     // distance from the stage's bottom edge to the bar's top, 0px when the bar
-    // is hidden (a view with no animations). Hosts that float their own chrome
-    // at the stage's bottom-centre (partforge-cloud's status/forging stack)
-    // read it to sit above the bar instead of under it; with no bar mounted
-    // the property is never set and a var() fallback of 0px applies.
-    const clear = bar.style.display === "none"
-      ? 0
-      : Math.max(0, Math.round(stageRect.bottom - barRect.top));
+    // is hidden — by us (a view with no animations, sketch mode: the inline
+    // display) OR by a host stylesheet, which leaves our inline display alone
+    // and empties the bar's box, the case stageClearFor tests. Hosts that
+    // float their own chrome at the stage's bottom-centre (partforge-cloud's
+    // status/forging stack) read it to sit above the bar instead of under it;
+    // with no bar mounted the property is never set and a var() fallback of
+    // 0px applies.
+    const clear = bar.style.display === "none" ? 0 : stageClearFor(stageRect, barRect);
     container.style.setProperty("--pf-anim-clear", `${clear}px`);
     const cubeEl = container.querySelector(cubeSelector);
     const viewbarRect = viewbarEl?.getBoundingClientRect() ?? null;
@@ -702,8 +704,8 @@ export function attachAnimationControls(viewer, part, {
   // back in here.
   function isCrowded({ stageRect, barRect, viewbarRect, cubeRect, cubeEl }) {
     // A bar that is not on screen cannot be crowded by anything — the same
-    // condition the --pf-anim-clear calculation above uses.
-    if (bar.style.display === "none") return false;
+    // two conditions the --pf-anim-clear calculation above uses.
+    if (bar.style.display === "none" || barRect.height === 0) return false;
     const nominal = nominalClusterRect(viewbarRect, cubeRect, publishedSize(cubeEl));
     // Same vertical-band test the placement path applies, against the nominal
     // rect: bands that do not intersect cannot collide, so there is nothing to

package/src/framework/chrome.css

@@ -481,12 +481,25 @@
 .pf-shell[data-pf-rail-layout="dock"] { padding-bottom: var(--pf-rail-inset, 0px); }
 @media (max-width: 719px) {
   /* pane=rail on a phone: stage above, rail docked in the sheet region. The
-     three rules below override the narrow block's one-pane hiding. */
-  .pf-shell[data-pf-rail-layout="dock"][data-pf-pane="rail"] { padding-bottom: 0; }
+     two rules below override the narrow block's one-pane hiding.
+
+     The shell keeps its --pf-rail-inset padding in this pane too — the stage
+     is the same height whichever pane shows — and the rail is positioned
+     absolutely INTO that padding, filling the sheet region's bottom
+     --pf-rail-dock-h px. The difference between the two lengths is the strip
+     the host draws across the top of the sheet region, and it must stay
+     empty: an earlier version zeroed the padding and stacked the rail
+     straight under the stage in flow, which sent the stage's bottom
+     --pf-rail-inset − --pf-rail-dock-h px (the strip's height) UNDER the
+     host's opaque strip — with the viewbar, the view cube and the transport
+     bar behind it, unreachable, on every rail-pane sheet position. */
   .pf-shell[data-pf-rail-layout="dock"][data-pf-pane="rail"] .pf-stage { display: block; }
   .pf-shell[data-pf-rail-layout="dock"][data-pf-pane="rail"] .pf-rail {
     display: flex;
-    flex: none;
+    position: absolute;
+    left: 0;
+    right: 0;
+    bottom: 0;
     height: var(--pf-rail-dock-h, 0px);
     width: auto;
     border-left: 0;

package/src/framework/mount.js

@@ -33,6 +33,7 @@ import { createAnnotateMode } from "./annotate/annotate-mode.js";
 import { attachAnnotateControls } from "./annotate/annotate-controls.js";
 import { attachSketchToolbar } from "./annotate/sketch-toolbar.js";
 import { attachViewcubeControls } from "./viewcube/viewcube-controls.js";
+import { stageClearFor } from "./stage-clear.js";
 
 // The mount handle, factored out so its shape is unit-testable without booting
 // the full mount() pipeline (WASM + workers + DOM).
@@ -599,16 +600,14 @@ export function mount(part, { createWorker, elements = {}, onBuild, onPick, onDo
     }
     // Publish the viewbar's vertical claim so chrome.css can stack the cube on
     // top of it without hardcoding a height that cutaway/measure/annotate
-    // action rows can change.
+    // action rows can change. A hidden bar (ours or a host stylesheet's)
+    // claims 0 — stage-clear.js has the why; the observer fires on the hide
+    // itself, since the bar's box goes to zero.
     const viewbarEl = els.viewer.querySelector("#viewbar");
     if (viewbarEl && typeof ResizeObserver === "function") {
       const publishViewbarClear = () => {
-        const stageRect = els.viewer.getBoundingClientRect();
-        const barRect = viewbarEl.getBoundingClientRect();
-        els.viewer.style.setProperty(
-          "--pf-viewbar-clear",
-          `${Math.max(0, Math.round(stageRect.bottom - barRect.top))}px`,
-        );
+        const clear = stageClearFor(els.viewer.getBoundingClientRect(), viewbarEl.getBoundingClientRect());
+        els.viewer.style.setProperty("--pf-viewbar-clear", `${clear}px`);
       };
       const viewbarObserver = new ResizeObserver(publishViewbarClear);
       viewbarObserver.observe(viewbarEl);

package/src/framework/stage-clear.js

@@ -0,0 +1,18 @@
+// The one arithmetic behind the stage's two "clearance" custom properties —
+// --pf-viewbar-clear (mount.js) and --pf-anim-clear (animation-controls.js):
+// how far up from the stage's bottom edge a floating bar reaches, so chrome
+// that stacks above it (the view cube, a host's status pills) can sit clear.
+//
+// A bar with NO BOX claims nothing. `getBoundingClientRect()` on a
+// `display: none` element is all zeros, and `stageRect.bottom - 0` is the
+// stage's bottom edge in viewport pixels — the whole stage height, or more.
+// Publishing that would fling everything stacked on the bar off the top of
+// the stage. The inline-style check the anim bar used to make
+// (`bar.style.display === "none"`) only saw its own hide; a host hiding the
+// bar from a stylesheet (partforge-cloud's part-open sheet does exactly that
+// to #viewbar and .pf-anim-bar) left the publishers measuring the zero rect.
+// The rect itself is the test: hidden by anyone, for any reason, it is empty.
+export function stageClearFor(stageRect, barRect) {
+  if (!barRect || barRect.height === 0) return 0;
+  return Math.max(0, Math.round(stageRect.bottom - barRect.top));
+}