paperclip-github-plugin 0.9.5 → 0.9.7

package/README.md

@@ -94,6 +94,8 @@ If a Paperclip issue was created locally or by an agent workflow before GitHub S
 
 Manual GitHub issue links are added to the same import registry and issue-link entity used by normal sync, so future syncs update the Paperclip issue from the GitHub issue. Manual pull request links are added to the PR-link entity used by the project Pull Requests page, so future syncs monitor PR status even when there is no closing GitHub issue.
 
+When a Paperclip issue is linked to a GitHub issue and also has older direct pull request links, the GitHub issue remains the status source of truth. Direct pull request links only drive status for PR-only Paperclip issues, which prevents stale merged PR metadata from closing work while the GitHub issue and its current linked PR are still open.
+
 Operators can unlink a linked Paperclip issue from the GitHub detail surface when they intentionally want GitHub Sync to stop updating it. Agent-facing tools and native agent API routes can create durable issue and pull request links, but they do not expose an unlink operation; internal sync repair may still tombstone a link when GitHub transfers an issue to an unmapped repository.
 
 ### Agent workflows built in

package/dist/manifest.js

@@ -642,7 +642,7 @@ var PULL_REQUEST_ASSET_API_ROUTE_URL_PATH = `/api/plugins/${GITHUB_SYNC_PLUGIN_I
 var require2 = createRequire(import.meta.url);
 var packageJson = require2("../package.json");
 var SCHEDULE_TICK_CRON = "* * * * *";
-var MANIFEST_VERSION = "0.9.5"?.trim() || typeof packageJson.version === "string" && packageJson.version.trim() || process.env.npm_package_version?.trim() || "0.0.0-dev";
+var MANIFEST_VERSION = "0.9.7"?.trim() || typeof packageJson.version === "string" && packageJson.version.trim() || process.env.npm_package_version?.trim() || "0.0.0-dev";
 var manifest = {
   id: GITHUB_SYNC_PLUGIN_ID,
   apiVersion: 1,

package/dist/worker.js

@@ -5669,7 +5669,16 @@ function resolveSyncTransitionAssignee(params) {
 }
 function isHealthyMaintainerWaitTransition(params) {
   const { currentStatus, nextStatus, syncContext } = params;
-  return nextStatus === "in_review" && (currentStatus === "done" || currentStatus === "in_review") && syncContext.executionState === null && syncContext.executionPolicy !== null;
+  return nextStatus === "in_review" && (currentStatus === "done" || currentStatus === "in_review") && isClearableMaintainerWaitExecutionState(syncContext.executionState);
+}
+function isClearableMaintainerWaitExecutionState(executionState) {
+  if (executionState === null) {
+    return true;
+  }
+  if (executionState.currentParticipant !== null || executionState.returnAssignee !== null || executionState.currentStageId !== null || executionState.currentStageIndex !== null || executionState.currentStageType !== null || executionState.completedStageIds.length > 0 || executionState.lastDecisionId || executionState.lastDecisionOutcome) {
+    return false;
+  }
+  return !executionState.status || executionState.status === "idle" || executionState.status === "completed";
 }
 function shouldClearCompletedSyncExecutionPolicy(params) {
   return (params.nextStatus === "done" || params.nextStatus === "cancelled") && (params.syncContext.executionPolicy !== null || params.syncContext.executionState !== null);
@@ -7338,6 +7347,23 @@ async function listGitHubPullRequestIssueLinksForMapping(ctx, mapping, target) {
   }
   return [...recordsByKey.values()];
 }
+async function listGitHubIssueLinkedPaperclipIssueIdsForMapping(ctx, mapping, importedIssueRecords, target) {
+  const issueIds = new Set(
+    importedIssueRecords.map((record) => record.paperclipIssueId).filter(Boolean)
+  );
+  if (target?.kind === "issue" && target.issueId && target.githubIssueNumber) {
+    issueIds.add(target.issueId);
+  }
+  const issueLinks = await listGitHubIssueLinkRecords(ctx, {
+    ...target?.kind === "issue" && target.issueId ? { paperclipIssueId: target.issueId } : {}
+  });
+  for (const record of issueLinks) {
+    if (doesGitHubIssueLinkRecordMatchMapping(record, mapping) && doesGitHubIssueLinkRecordMatchTarget(record, target)) {
+      issueIds.add(record.paperclipIssueId);
+    }
+  }
+  return issueIds;
+}
 function doesGitHubIssueLinkRecordMatchMapping(record, mapping) {
   if (record.data.repositoryUrl !== getNormalizedMappingRepositoryUrl(mapping)) {
     return false;
@@ -7375,6 +7401,7 @@ async function listExternalGitHubLinkSyncWork(ctx, mappings, target) {
   const syncableMappings = getSyncableMappingsForTarget(mappings, target);
   const issueLinksByKey = /* @__PURE__ */ new Map();
   const pullRequestLinksByKey = /* @__PURE__ */ new Map();
+  const issueLinkedPaperclipIssueIds = /* @__PURE__ */ new Set();
   const [issueLinks, pullRequestLinks] = await Promise.all([
     listGitHubIssueLinkRecords(ctx, {
       ...target?.kind === "issue" && target.issueId ? { paperclipIssueId: target.issueId } : {}
@@ -7384,7 +7411,11 @@ async function listExternalGitHubLinkSyncWork(ctx, mappings, target) {
     })
   ]);
   for (const record of issueLinks) {
-    if (!doesGitHubIssueLinkRecordMatchTarget(record, target) || isGitHubIssueLinkCoveredByMappings(record, syncableMappings)) {
+    if (!doesGitHubIssueLinkRecordMatchTarget(record, target)) {
+      continue;
+    }
+    issueLinkedPaperclipIssueIds.add(record.paperclipIssueId);
+    if (isGitHubIssueLinkCoveredByMappings(record, syncableMappings)) {
       continue;
     }
     issueLinksByKey.set(
@@ -7393,7 +7424,7 @@ async function listExternalGitHubLinkSyncWork(ctx, mappings, target) {
     );
   }
   for (const record of pullRequestLinks) {
-    if (!doesGitHubPullRequestLinkRecordMatchTarget(record, target) || isGitHubPullRequestLinkCoveredByMappings(record, syncableMappings)) {
+    if (!doesGitHubPullRequestLinkRecordMatchTarget(record, target) || issueLinkedPaperclipIssueIds.has(record.paperclipIssueId) || isGitHubPullRequestLinkCoveredByMappings(record, syncableMappings)) {
       continue;
     }
     pullRequestLinksByKey.set(
@@ -8973,6 +9004,24 @@ async function updatePaperclipIssueState(ctx, params) {
       });
       if (!payloadResult.failure) {
         issueUpdated = true;
+        if (issuePatch.executionState === null && ctx.issues && typeof ctx.issues.update === "function") {
+          try {
+            await ctx.issues.update(
+              issueId,
+              { executionState: null },
+              companyId
+            );
+          } catch (error) {
+            issueUpdated = false;
+            ctx.logger.warn("GitHub sync could not clear Paperclip issue execution state after the local API update. Falling back to direct issue mutation.", {
+              companyId,
+              issueId,
+              paperclipApiBaseUrl,
+              nextStatus,
+              error: getErrorMessage(error)
+            });
+          }
+        }
       }
       if (payloadResult.failure && (payloadResult.failure.status ?? response.status) !== 404 && (payloadResult.failure.status ?? response.status) !== 405) {
         logPaperclipIssueStatusUpdateFailure(ctx, {
@@ -14115,7 +14164,13 @@ async function performSync(ctx, trigger, options = {}) {
         const importRegistryByIssueId = new Map(
           importedIssueRecords.map((entry) => [entry.githubIssueId, entry])
         );
-        const pullRequestLinks = await listGitHubPullRequestIssueLinksForMapping(ctx, mapping, options.target);
+        const githubIssueLinkedPaperclipIssueIds = await listGitHubIssueLinkedPaperclipIssueIdsForMapping(
+          ctx,
+          mapping,
+          importedIssueRecords,
+          options.target
+        );
+        const pullRequestLinks = (await listGitHubPullRequestIssueLinksForMapping(ctx, mapping, options.target)).filter((record) => !githubIssueLinkedPaperclipIssueIds.has(record.paperclipIssueId));
         const ensuredPaperclipIssueIds = /* @__PURE__ */ new Map();
         const trackedIssueIds = /* @__PURE__ */ new Set([
           ...issues.map((issue) => issue.id),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "paperclip-github-plugin",
-  "version": "0.9.5",
+  "version": "0.9.7",
   "description": "Paperclip plugin for synchronizing GitHub issues into Paperclip projects.",
   "license": "Apache-2.0",
   "type": "module",