paperclip-github-plugin 0.8.3 → 0.8.5

package/README.md

@@ -159,8 +159,8 @@ When the local Paperclip API is available, the plugin also syncs labels by name,
 | Open issue with no linked pull request, created by a repository maintainer | `todo` on first import |
 | Open issue with no linked pull request | Configured default status, which defaults to `backlog` |
 | Open issue with a linked pull request and unfinished CI | `in_progress` |
-| Open issue with failing CI, a non-mergeable linked pull request, requested changes, or unresolved review threads | `todo`, or `in_progress` when GitHub Sync can hand the work back to an executor |
-| Open issue with green CI, a merge-ready linked pull request, no requested changes, and all review threads resolved | `in_review` |
+| Open issue with failing CI, a non-mergeable linked pull request, or unresolved review threads | `todo`, or `in_progress` when GitHub Sync can hand the work back to an executor |
+| Open issue with green CI, a merge-ready linked pull request, and all review threads resolved | `in_review` |
 | Closed issue completed as finished work | `done` |
 | Closed issue closed as `not_planned` or `duplicate` | `cancelled` |
 
@@ -170,7 +170,8 @@ Additional behavior:
 - If the Paperclip host initially creates that imported maintainer issue in `backlog`, GitHub Sync promotes it to `todo` without replacing the configured default assignee with the executor handoff assignee, so triage ownership stays intact.
 - When Paperclip board access is connected for a company, the advanced assignee dropdowns list both company agents and `Me` for the connected board user.
 - Newly imported issues that finish sync in `todo` and are assigned to an agent enqueue an assignee wakeup so the agent can pick them up promptly.
-- For linked pull requests, GitHub Sync treats merge-conflict, behind-branch, blocked, draft, unstable merge states, and requested-changes review decisions as executor work, while merge-ready states such as `CLEAN` and `HAS_HOOKS` can move work into `in_review` when CI is green and there are no requested changes or unresolved review threads.
+- For linked pull requests, GitHub Sync treats merge-conflict, behind-branch, blocked, draft, unstable merge states, and unresolved review threads as executor work, while merge-ready states such as `CLEAN` and `HAS_HOOKS` can move work into `in_review` when CI is green and review threads are resolved. A stale aggregate `CHANGES_REQUESTED` review decision alone does not move that maintainer wait back to active execution. Transient `UNKNOWN` mergeability also does not move an already `in_review` maintainer wait back to active execution when CI is green and review threads are resolved.
+- Imported issues that are already `blocked` stay `blocked` while any first-class `blockedBy` issue is still non-terminal, even if the linked GitHub pull request is otherwise green and review-ready.
 - When sync moves work into `in_review`, GitHub Sync first follows the Paperclip issue execution policy's current reviewer or approver when that stage is visible on the issue. If Paperclip exposes an internal review or approval stage but not yet the participant, the plugin falls back to the configured reviewer or approver handoff assignee. If the transition is only a healthy linked-PR wait with no visible internal review or approval stage, GitHub Sync leaves the issue unassigned so it can wait on normal maintainer review without waking an internal owner.
 - When sync moves work back into active execution, GitHub Sync first follows the Paperclip issue execution policy `returnAssignee` when it is available. Otherwise it falls back to the configured executor handoff assignee and then to the default imported assignee.
 - Sync-driven handoffs to agent assignees best-effort enqueue an explicit wakeup so the next reviewer, approver, or executor can pick the issue up even when their agent is not running heartbeats.

package/dist/manifest.js

@@ -535,7 +535,7 @@ var COMPANY_METRIC_API_ROUTE_URL_PATH = `/api/plugins/${GITHUB_SYNC_PLUGIN_ID}/a
 var require2 = createRequire(import.meta.url);
 var packageJson = require2("../package.json");
 var SCHEDULE_TICK_CRON = "* * * * *";
-var MANIFEST_VERSION = "0.8.3"?.trim() || typeof packageJson.version === "string" && packageJson.version.trim() || process.env.npm_package_version?.trim() || "0.0.0-dev";
+var MANIFEST_VERSION = "0.8.5"?.trim() || typeof packageJson.version === "string" && packageJson.version.trim() || process.env.npm_package_version?.trim() || "0.0.0-dev";
 var manifest = {
   id: GITHUB_SYNC_PLUGIN_ID,
   apiVersion: 1,
@@ -559,6 +559,7 @@ var manifest = {
     "issues.create",
     "issues.update",
     "issues.wakeup",
+    "issue.relations.read",
     "issue.comments.read",
     "issue.comments.create",
     "agents.read",

package/dist/worker.js

@@ -1447,7 +1447,16 @@ function formatGitHubIssueCountLabel(count) {
   return `${normalizedCount} GitHub ${normalizedCount === 1 ? "issue" : "issues"}`;
 }
 function getErrorMessage(error) {
-  return error instanceof Error ? error.message : String(error);
+  if (error instanceof Error) {
+    return error.message;
+  }
+  if (error && typeof error === "object" && "message" in error) {
+    const message = error.message;
+    if (typeof message === "string") {
+      return message;
+    }
+  }
+  return String(error);
 }
 function isPaperclipLabelSyncError(error) {
   return error instanceof PaperclipLabelSyncError;
@@ -4889,7 +4898,9 @@ function resolvePaperclipStatusFromLinkedPullRequests(linkedPullRequests, option
   )) {
     return options?.preferInProgress ? "in_progress" : "todo";
   }
-  if (linkedPullRequests.length > 0 && linkedPullRequests.every((pullRequest) => isGitHubPullRequestReviewReadyForSync(pullRequest))) {
+  if (linkedPullRequests.length > 0 && linkedPullRequests.every(
+    (pullRequest) => isGitHubPullRequestReviewReadyForSync(pullRequest) || options?.preserveTransientUnknownMergeabilityWait === true && isGitHubPullRequestTransientUnknownMergeabilityWait(pullRequest)
+  )) {
     return "in_review";
   }
   return "in_progress";
@@ -5021,6 +5032,40 @@ function getPaperclipIssueSyncContext(issue) {
     executionState: normalizePaperclipIssueExecutionState(record.executionState)
   };
 }
+function hasUnresolvedPaperclipIssueBlockerSummary(blockers) {
+  if (!Array.isArray(blockers)) {
+    return false;
+  }
+  return blockers.some((blocker) => {
+    if (!blocker || typeof blocker !== "object") {
+      return true;
+    }
+    const status = blocker.status;
+    return status !== "done" && status !== "cancelled";
+  });
+}
+function isMissingIssueRelationsReadCapabilityError(error) {
+  const message = getErrorMessage(error);
+  return /missing required capability/i.test(message) && /issue\.relations\.read/i.test(message) && /issues\.relations\.get/i.test(message);
+}
+async function hasUnresolvedPaperclipIssueBlocker(ctx, issue, companyId) {
+  const record = issue;
+  if (hasUnresolvedPaperclipIssueBlockerSummary(record.blockedBy)) {
+    return true;
+  }
+  if (typeof ctx.issues.relations?.get !== "function") {
+    return false;
+  }
+  try {
+    const relations = await ctx.issues.relations.get(issue.id, companyId);
+    return hasUnresolvedPaperclipIssueBlockerSummary(relations.blockedBy);
+  } catch (error) {
+    if (isMissingIssueRelationsReadCapabilityError(error)) {
+      return false;
+    }
+    throw error;
+  }
+}
 function isSamePaperclipIssueAssigneePrincipal(left, right) {
   if (!left || !right) {
     return !left && !right;
@@ -5392,7 +5437,8 @@ function resolvePaperclipIssueStatus(params) {
   }
   if (snapshot.linkedPullRequests.length > 0) {
     return resolvePaperclipStatusFromLinkedPullRequests(snapshot.linkedPullRequests, {
-      preferInProgress: hasExecutorHandoffTarget
+      preferInProgress: hasExecutorHandoffTarget,
+      preserveTransientUnknownMergeabilityWait: currentStatus === "done" || currentStatus === "in_review"
     });
   }
   if (wasImportedThisRun) {
@@ -5409,7 +5455,8 @@ function resolvePaperclipPullRequestIssueStatus(params) {
     return currentStatus;
   }
   return resolvePaperclipStatusFromLinkedPullRequests([pullRequest], {
-    preferInProgress: hasExecutorHandoffTarget
+    preferInProgress: hasExecutorHandoffTarget,
+    preserveTransientUnknownMergeabilityWait: currentStatus === "in_review"
   });
 }
 async function listLinkedPullRequestsForIssue(octokit, repository, issueNumber) {
@@ -5556,10 +5603,13 @@ function normalizeGitHubPullRequestReviewDecision(value) {
   }
 }
 function isGitHubPullRequestActionRequiredForSync(pullRequest) {
-  return pullRequest.reviewDecision === "changes_requested" || pullRequest.mergeability === "conflicting" || ACTION_REQUIRED_GITHUB_PULL_REQUEST_MERGE_STATE_STATUSES.has(pullRequest.mergeStateStatus);
+  return pullRequest.mergeability === "conflicting" || ACTION_REQUIRED_GITHUB_PULL_REQUEST_MERGE_STATE_STATUSES.has(pullRequest.mergeStateStatus);
+}
+function isGitHubPullRequestTransientUnknownMergeabilityWait(pullRequest) {
+  return pullRequest.ciState === "green" && !pullRequest.hasUnresolvedReviewThreads && pullRequest.mergeability !== "conflicting" && pullRequest.mergeStateStatus === "unknown";
 }
 function isGitHubPullRequestReviewReadyForSync(pullRequest) {
-  if (pullRequest.ciState !== "green" || pullRequest.hasUnresolvedReviewThreads || pullRequest.reviewDecision === "changes_requested") {
+  if (pullRequest.ciState !== "green" || pullRequest.hasUnresolvedReviewThreads) {
     return false;
   }
   return REVIEW_READY_GITHUB_PULL_REQUEST_MERGE_STATE_STATUSES.has(pullRequest.mergeStateStatus);
@@ -5592,9 +5642,6 @@ function listGitHubPullRequestSyncBlockingConditions(pullRequest) {
   if (pullRequest.hasUnresolvedReviewThreads) {
     conditions.push("unresolved review threads");
   }
-  if (pullRequest.reviewDecision === "changes_requested") {
-    conditions.push("requested changes");
-  }
   return conditions;
 }
 function tryBuildGitHubPullRequestStatusSnapshotFromBatchNode(node, repository) {
@@ -9025,7 +9072,7 @@ async function synchronizePaperclipIssueStatuses(ctx, octokit, repository, mappi
         paperclipIssueSyncContext,
         advancedSettings
       );
-      const nextStatus = resolvePaperclipIssueStatus({
+      let nextStatus = resolvePaperclipIssueStatus({
         currentStatus: paperclipIssue.status,
         snapshot,
         hasTrustedNewComment,
@@ -9034,6 +9081,9 @@ async function synchronizePaperclipIssueStatuses(ctx, octokit, repository, mappi
         maintainerAuthoredImportedIssue,
         hasExecutorHandoffTarget: Boolean(executorTransitionAssignee)
       });
+      if (paperclipIssue.status === "blocked" && nextStatus !== "blocked" && await hasUnresolvedPaperclipIssueBlocker(ctx, paperclipIssue, mapping.companyId)) {
+        nextStatus = "blocked";
+      }
       const shouldPreserveMaintainerWaitRouting = isHealthyMaintainerWaitTransition({
         currentStatus: paperclipIssue.status,
         nextStatus,
@@ -9236,11 +9286,14 @@ async function synchronizePaperclipPullRequestIssueStatuses(ctx, octokit, mappin
         paperclipIssueSyncContext,
         advancedSettings
       );
-      const nextStatus = resolvePaperclipPullRequestIssueStatus({
+      let nextStatus = resolvePaperclipPullRequestIssueStatus({
         currentStatus: paperclipIssue.status,
         pullRequest,
         hasExecutorHandoffTarget: Boolean(executorTransitionAssignee)
       });
+      if (paperclipIssue.status === "blocked" && nextStatus !== "blocked" && await hasUnresolvedPaperclipIssueBlocker(ctx, paperclipIssue, mapping.companyId)) {
+        nextStatus = "blocked";
+      }
       const shouldPreserveMaintainerWaitRouting = isHealthyMaintainerWaitTransition({
         currentStatus: paperclipIssue.status,
         nextStatus,
@@ -14327,6 +14380,7 @@ function shouldStartWorkerHost(moduleUrl, entry = process.argv[1]) {
 }
 var __testing = {
   buildSyncFallbackExecutionStatePatch,
+  hasUnresolvedPaperclipIssueBlocker,
   isHealthyMaintainerWaitTransition,
   resolveSyncTransitionAssignee
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "paperclip-github-plugin",
-  "version": "0.8.3",
+  "version": "0.8.5",
   "description": "Paperclip plugin for synchronizing GitHub issues into Paperclip projects.",
   "license": "Apache-2.0",
   "type": "module",