paperclip-github-plugin 0.8.0 → 0.8.1

package/README.md

@@ -62,7 +62,7 @@ If a company already has a Paperclip project bound to a GitHub repository worksp
 
 ### Status sync with delivery context
 
-The plugin does more than mirror issue text. It looks at linked pull requests, mergeability, CI, review threads, and trusted new GitHub comments so imported Paperclip issues can reflect where the work actually is. When GitHub links an issue to a pull request in another repository, GitHub Sync now follows that pull request's actual repository for status checks, review-thread state, and deep links instead of assuming the issue repository. When sync closes an imported issue as `done` or `cancelled`, it also clears any pending Paperclip review or approval execution state so the host accepts the terminal transition cleanly.
+The plugin does more than mirror issue text. It looks at linked pull requests, mergeability, CI, review decisions, review threads, and trusted new GitHub comments so imported Paperclip issues can reflect where the work actually is. When GitHub links an issue to a pull request in another repository, GitHub Sync now follows that pull request's actual repository for status checks, review state, and deep links instead of assuming the issue repository. When sync closes an imported issue as `done` or `cancelled`, it also clears any pending Paperclip review or approval execution state so the host accepts the terminal transition cleanly.
 
 ### Company KPI dashboard
 
@@ -78,7 +78,7 @@ Each mapped project can expose a **Pull Requests** entry in the sidebar that ope
 
 Paperclip issue linkage on the queue prefers the GitHub issue that the pull request closes, so imported GitHub issues and delivery work stay connected in the same project view. If a pull request has no closing-issue-backed link yet, the queue falls back to the Paperclip issue created directly from that pull request and updates the table immediately when that create action returns.
 
-Those pull-request-created Paperclip issues also stay in the scheduled/manual sync loop even when the pull request does not close a GitHub issue. GitHub Sync checks their CI, merge state, and review threads so new failures or unresolved feedback move the Paperclip issue back into active work. The same durable PR link is written when an agent creates a PR through the plugin tool with `paperclipIssueId`, when an authenticated agent records a `gh`-created PR through the agent API route with `paperclipIssueId`, or when an operator manually links an unlinked issue from the issue page.
+Those pull-request-created Paperclip issues also stay in the scheduled/manual sync loop even when the pull request does not close a GitHub issue. GitHub Sync checks their CI, merge state, review decision, and review threads so new failures or requested feedback move the Paperclip issue back into active work. The same durable PR link is written when an agent creates a PR through the plugin tool with `paperclipIssueId`, when an authenticated agent records a `gh`-created PR through the agent API route with `paperclipIssueId`, or when an operator manually links an unlinked issue from the issue page.
 
 The issue detail panel and sync-created comment annotations also preserve cross-repository linked pull requests, showing those PRs with their real repository path so operators land in the right place on GitHub.
 
@@ -155,8 +155,8 @@ When the local Paperclip API is available, the plugin also syncs labels by name,
 | Open issue with no linked pull request, created by a repository maintainer | `todo` on first import |
 | Open issue with no linked pull request | Configured default status, which defaults to `backlog` |
 | Open issue with a linked pull request and unfinished CI | `in_progress` |
-| Open issue with failing CI, a non-mergeable linked pull request, or unresolved review threads | `todo`, or `in_progress` when GitHub Sync can hand the work back to an executor |
-| Open issue with green CI, a merge-ready linked pull request, and all review threads resolved | `in_review` |
+| Open issue with failing CI, a non-mergeable linked pull request, requested changes, or unresolved review threads | `todo`, or `in_progress` when GitHub Sync can hand the work back to an executor |
+| Open issue with green CI, a merge-ready linked pull request, no requested changes, and all review threads resolved | `in_review` |
 | Closed issue completed as finished work | `done` |
 | Closed issue closed as `not_planned` or `duplicate` | `cancelled` |
 
@@ -165,7 +165,7 @@ Additional behavior:
 - Open issues with no linked pull request that are created by a verified repository maintainer/admin bypass the default imported status and start in `todo`.
 - When Paperclip board access is connected for a company, the advanced assignee dropdowns list both company agents and `Me` for the connected board user.
 - Newly imported issues that finish sync in `todo` and are assigned to an agent enqueue an assignee wakeup so the agent can pick them up promptly.
-- For linked pull requests, GitHub Sync treats merge-conflict, behind-branch, blocked, draft, and unstable merge states as executor work, while merge-ready states such as `CLEAN` and `HAS_HOOKS` can move work into `in_review` when CI and review threads are also clear.
+- For linked pull requests, GitHub Sync treats merge-conflict, behind-branch, blocked, draft, unstable merge states, and requested-changes review decisions as executor work, while merge-ready states such as `CLEAN` and `HAS_HOOKS` can move work into `in_review` when CI is green and there are no requested changes or unresolved review threads.
 - When sync moves work into `in_review`, GitHub Sync first follows the Paperclip issue execution policy's current reviewer or approver when that stage is visible on the issue. If Paperclip exposes an internal review or approval stage but not yet the participant, the plugin falls back to the configured reviewer or approver handoff assignee. If the transition is only a healthy linked-PR wait with no visible internal review or approval stage, GitHub Sync leaves the issue unassigned so it can wait on normal maintainer review without waking an internal owner.
 - When sync moves work back into active execution, GitHub Sync first follows the Paperclip issue execution policy `returnAssignee` when it is available. Otherwise it falls back to the configured executor handoff assignee and then to the default imported assignee.
 - Sync-driven handoffs to agent assignees best-effort enqueue an explicit wakeup so the next reviewer, approver, or executor can pick the issue up even when their agent is not running heartbeats.

package/dist/manifest.js

@@ -535,7 +535,7 @@ var COMPANY_METRIC_API_ROUTE_URL_PATH = `/api/plugins/${GITHUB_SYNC_PLUGIN_ID}/a
 var require2 = createRequire(import.meta.url);
 var packageJson = require2("../package.json");
 var SCHEDULE_TICK_CRON = "* * * * *";
-var MANIFEST_VERSION = "0.8.0"?.trim() || typeof packageJson.version === "string" && packageJson.version.trim() || process.env.npm_package_version?.trim() || "0.0.0-dev";
+var MANIFEST_VERSION = "0.8.1"?.trim() || typeof packageJson.version === "string" && packageJson.version.trim() || process.env.npm_package_version?.trim() || "0.0.0-dev";
 var manifest = {
   id: GITHUB_SYNC_PLUGIN_ID,
   apiVersion: 1,

package/dist/worker.js

@@ -812,6 +812,7 @@ var GITHUB_PULL_REQUEST_CI_CONTEXTS_QUERY = `
       pullRequest(number: $pullRequestNumber) {
         mergeable
         mergeStateStatus
+        reviewDecision
         statusCheckRollup {
           contexts(first: 100, after: $after) {
             pageInfo {
@@ -877,6 +878,7 @@ var GITHUB_REPOSITORY_OPEN_PULL_REQUEST_STATUSES_QUERY = `
           number
           mergeable
           mergeStateStatus
+          reviewDecision
           reviewThreads(first: 100) {
             pageInfo {
               hasNextPage
@@ -917,6 +919,7 @@ var GITHUB_PROJECT_PULL_REQUEST_BASE_FIELDS = `
           state
           mergeable
           mergeStateStatus
+          reviewDecision
           createdAt
           updatedAt
           baseRefName
@@ -1003,6 +1006,7 @@ var GITHUB_PROJECT_PULL_REQUEST_METRICS_FIELDS = `
           number
           mergeable
           mergeStateStatus
+          reviewDecision
           baseRefName
           reviews(first: 100) {
             pageInfo {
@@ -5535,11 +5539,23 @@ function normalizeGitHubPullRequestMergeStateStatus(value) {
       return "unknown";
   }
 }
+function normalizeGitHubPullRequestReviewDecision(value) {
+  switch (typeof value === "string" ? value.trim().toLowerCase() : "") {
+    case "approved":
+      return "approved";
+    case "changes_requested":
+      return "changes_requested";
+    case "review_required":
+      return "review_required";
+    default:
+      return "unknown";
+  }
+}
 function isGitHubPullRequestActionRequiredForSync(pullRequest) {
-  return pullRequest.mergeability === "conflicting" || ACTION_REQUIRED_GITHUB_PULL_REQUEST_MERGE_STATE_STATUSES.has(pullRequest.mergeStateStatus);
+  return pullRequest.reviewDecision === "changes_requested" || pullRequest.mergeability === "conflicting" || ACTION_REQUIRED_GITHUB_PULL_REQUEST_MERGE_STATE_STATUSES.has(pullRequest.mergeStateStatus);
 }
 function isGitHubPullRequestReviewReadyForSync(pullRequest) {
-  if (pullRequest.ciState !== "green" || pullRequest.hasUnresolvedReviewThreads) {
+  if (pullRequest.ciState !== "green" || pullRequest.hasUnresolvedReviewThreads || pullRequest.reviewDecision === "changes_requested") {
     return false;
   }
   return REVIEW_READY_GITHUB_PULL_REQUEST_MERGE_STATE_STATUSES.has(pullRequest.mergeStateStatus);
@@ -5572,6 +5588,9 @@ function listGitHubPullRequestSyncBlockingConditions(pullRequest) {
   if (pullRequest.hasUnresolvedReviewThreads) {
     conditions.push("unresolved review threads");
   }
+  if (pullRequest.reviewDecision === "changes_requested") {
+    conditions.push("requested changes");
+  }
   return conditions;
 }
 function tryBuildGitHubPullRequestStatusSnapshotFromBatchNode(node, repository) {
@@ -5589,7 +5608,8 @@ function tryBuildGitHubPullRequestStatusSnapshotFromBatchNode(node, repository)
     hasUnresolvedReviewThreads: reviewThreadSummary.unresolvedReviewThreads > 0,
     ciState,
     mergeability: normalizeGitHubPullRequestMergeability(node.mergeable),
-    mergeStateStatus: normalizeGitHubPullRequestMergeStateStatus(node.mergeStateStatus)
+    mergeStateStatus: normalizeGitHubPullRequestMergeStateStatus(node.mergeStateStatus),
+    reviewDecision: normalizeGitHubPullRequestReviewDecision(node.reviewDecision)
   };
 }
 function tryBuildGitHubPullRequestCiStateFromBatchNode(node) {
@@ -5646,6 +5666,7 @@ async function getGitHubPullRequestCiSnapshot(octokit, repository, pullRequestNu
   const contexts = [];
   let mergeability = "unknown";
   let mergeStateStatus = "unknown";
+  let reviewDecision = "unknown";
   let after;
   do {
     const response = await octokit.graphql(GITHUB_PULL_REQUEST_CI_CONTEXTS_QUERY, {
@@ -5656,6 +5677,7 @@ async function getGitHubPullRequestCiSnapshot(octokit, repository, pullRequestNu
     });
     mergeability = normalizeGitHubPullRequestMergeability(response.repository?.pullRequest?.mergeable);
     mergeStateStatus = normalizeGitHubPullRequestMergeStateStatus(response.repository?.pullRequest?.mergeStateStatus);
+    reviewDecision = normalizeGitHubPullRequestReviewDecision(response.repository?.pullRequest?.reviewDecision);
     const connection = response.repository?.pullRequest?.statusCheckRollup?.contexts;
     const nodes = connection?.nodes ?? [];
     for (const node of nodes) {
@@ -5682,7 +5704,8 @@ async function getGitHubPullRequestCiSnapshot(octokit, repository, pullRequestNu
   return {
     ciState: classifyGitHubPullRequestCiState(contexts),
     mergeability,
-    mergeStateStatus
+    mergeStateStatus,
+    reviewDecision
   };
 }
 async function getGitHubPullRequestStatusSnapshot(octokit, repository, pullRequestNumber, pullRequestStatusCache, options) {
@@ -5696,14 +5719,15 @@ async function getGitHubPullRequestStatusSnapshot(octokit, repository, pullReque
     setCachedGitHubPullRequestStatusSnapshot(pullRequestStatusCache, cachedSnapshot);
     return cachedSnapshot;
   }
-  if (options?.reviewThreadSummary && options.ciState && options.mergeability !== void 0 && options.mergeStateStatus !== void 0) {
+  if (options?.reviewThreadSummary && options.ciState && options.mergeability !== void 0 && options.mergeStateStatus !== void 0 && options.reviewDecision !== void 0) {
     const snapshot = cacheGitHubPullRequestStatusSnapshot(repository, {
       number: pullRequestNumber,
       repositoryUrl: repository.url,
       hasUnresolvedReviewThreads: options.reviewThreadSummary.unresolvedReviewThreads > 0,
       ciState: options.ciState,
       mergeability: options.mergeability,
-      mergeStateStatus: options.mergeStateStatus
+      mergeStateStatus: options.mergeStateStatus,
+      reviewDecision: options.reviewDecision
     });
     setCachedGitHubPullRequestStatusSnapshot(pullRequestStatusCache, snapshot);
     return snapshot;
@@ -5717,10 +5741,11 @@ async function getGitHubPullRequestStatusSnapshot(octokit, repository, pullReque
   const loadSnapshotPromise = (async () => {
     const [reviewThreadSummary, ciSnapshot] = await Promise.all([
       options?.reviewThreadSummary ?? getOrLoadCachedGitHubPullRequestReviewThreadSummary(octokit, repository, pullRequestNumber),
-      options?.ciState && options.mergeability !== void 0 && options.mergeStateStatus !== void 0 ? {
+      options?.ciState && options.mergeability !== void 0 && options.mergeStateStatus !== void 0 && options.reviewDecision !== void 0 ? {
         ciState: options.ciState,
         mergeability: options.mergeability,
-        mergeStateStatus: options.mergeStateStatus
+        mergeStateStatus: options.mergeStateStatus,
+        reviewDecision: options.reviewDecision
       } : getGitHubPullRequestCiSnapshot(octokit, repository, pullRequestNumber)
     ]);
     return cacheGitHubPullRequestStatusSnapshot(repository, {
@@ -5729,7 +5754,8 @@ async function getGitHubPullRequestStatusSnapshot(octokit, repository, pullReque
       hasUnresolvedReviewThreads: reviewThreadSummary.unresolvedReviewThreads > 0,
       ciState: ciSnapshot.ciState,
       mergeability: ciSnapshot.mergeability,
-      mergeStateStatus: ciSnapshot.mergeStateStatus
+      mergeStateStatus: ciSnapshot.mergeStateStatus,
+      reviewDecision: ciSnapshot.reviewDecision
     });
   })();
   activeGitHubPullRequestStatusSnapshotPromiseCache.set(cacheKey, loadSnapshotPromise);
@@ -10398,6 +10424,7 @@ async function buildProjectPullRequestSummaryRecord(octokit, repository, node, i
   });
   const inlineMergeability = normalizeGitHubPullRequestMergeability(node.mergeable);
   const inlineMergeStateStatus = normalizeGitHubPullRequestMergeStateStatus(node.mergeStateStatus);
+  const inlineReviewDecision = normalizeGitHubPullRequestReviewDecision(node.reviewDecision);
   const [reviewThreadSummary, reviewSummary, statusSnapshot, behindBy] = await Promise.all([
     getOrLoadCachedGitHubPullRequestReviewThreadSummary(
       octokit,
@@ -10415,7 +10442,8 @@ async function buildProjectPullRequestSummaryRecord(octokit, repository, node, i
       reviewThreadSummary: inlineReviewThreadSummary,
       ciState: inlineCiState,
       mergeability: inlineMergeability,
-      mergeStateStatus: inlineMergeStateStatus
+      mergeStateStatus: inlineMergeStateStatus,
+      reviewDecision: inlineReviewDecision
     }),
     getGitHubPullRequestBehindCount(octokit, repository, {
       baseBranch: node.baseRefName,
@@ -10555,6 +10583,7 @@ async function buildProjectPullRequestMetricCounts(octokit, repository, node, pu
   });
   const inlineMergeability = normalizeGitHubPullRequestMergeability(node.mergeable);
   const inlineMergeStateStatus = normalizeGitHubPullRequestMergeStateStatus(node.mergeStateStatus);
+  const inlineReviewDecision = normalizeGitHubPullRequestReviewDecision(node.reviewDecision);
   const [reviewThreadSummary, reviewSummary, statusSnapshot] = await Promise.all([
     getOrLoadCachedGitHubPullRequestReviewThreadSummary(
       octokit,
@@ -10572,7 +10601,8 @@ async function buildProjectPullRequestMetricCounts(octokit, repository, node, pu
       reviewThreadSummary: inlineReviewThreadSummary,
       ciState: inlineCiState,
       mergeability: inlineMergeability,
-      mergeStateStatus: inlineMergeStateStatus
+      mergeStateStatus: inlineMergeStateStatus,
+      reviewDecision: inlineReviewDecision
     })
   ]);
   const checksStatus = statusSnapshot.ciState === "green" ? "passed" : statusSnapshot.ciState === "red" ? "failed" : "pending";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "paperclip-github-plugin",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "Paperclip plugin for synchronizing GitHub issues into Paperclip projects.",
   "license": "Apache-2.0",
   "type": "module",