pantheon-opencode 1.3.3 → 1.3.5-beta.52.c75b04d

package/src/pantheon/delegation-compaction.ts

@@ -1,11 +1,24 @@
 /**
- * Delegation Compaction Context (Phase 4) — build the context blocks injected
- * by the `experimental.session.compacting` hook so a compacted session does
- * not lose track of its in-flight background delegations.
+ * Compaction Context (Phase 4 + release-134 Phase 2) — build the context
+ * blocks injected by the `experimental.session.compacting` hook so a
+ * compacted session does not lose its working state: in-flight background
+ * delegations, active goals and pending todos.
  *
- * Returns a string[] (empty when there is nothing to preserve):
- *   - "Background Delegations (running):" — every running job launched by the
- *     session (active work is never capped): alias, agent, started ISO,
+ * Returns a Promise<string[]> (empty when there is nothing to preserve).
+ * Section order is stable:
+ *   - "<pantheon-context directive>" — preservation directive (prefix,
+ *     PANTHEON_COMPACTION_DIRECTIVE). Emitted whenever at least one other
+ *     section follows; a totally-empty state returns [] (an orphan
+ *     directive is noise).
+ *   - "<mission_context>" — active (non-done) goals from `opts.goals`:
+ *     "  [id] objective — status". Omitted when the goal source is absent,
+ *     disabled, unscoped (no sessionID), fails, or has no active goals.
+ *   - "<todo_context>" — pending (not completed/cancelled) todos from
+ *     `opts.todos`: "  [id] description — status". Omitted when the todo
+ *     source is absent, disabled, unscoped (no sessionID), fails, or has
+ *     no pending todos.
+ *   - "Background Delegations (running):" — every running job launched by
+ *     the session (active work is never capped): alias, agent, started ISO,
  *     truncated prompt.
  *   - "Background Delegations (finished, unread):" — terminal-unreconciled
  *     jobs, newest first, capped at `maxItems` (default 10, matching
@@ -21,14 +34,52 @@
  */
 
 import type { BackgroundJobBoard, BackgroundJobRecord } from './background-job-board.ts'
+import type { Goal } from './goal-store.ts'
+import { createPantheonLogger } from './logger.ts'
+import type { TodoLike } from './todo-enforcer.ts'
+
+// Silence-by-default TUI policy (pantheon-hooks L42-58): the default warn
+// fallback logs to .pantheon/logs/hooks.log; console echo is opt-in via
+// PANTHEON_HOOKS_LOG=1. `deps.logger` injection stays for tests.
+const log = createPantheonLogger({ module: 'pantheon-compaction' })
+
+// ─── Constants ─────────────────────────────────────────────────────────
+
+/**
+ * Preservation directive (release-134 Phase 2): the native compaction
+ * prompt keeps every pushed section, so this prefix asks the model to keep
+ * the pantheon sections verbatim — not paraphrased, merged, or dropped.
+ */
+export const PANTHEON_COMPACTION_DIRECTIVE =
+  'preserve these sections verbatim in the summarized context'
 
 // ─── Types ─────────────────────────────────────────────────────────────
 
+/** Source for the <mission_context> section (active goals). */
+export interface CompactionGoalSource {
+  /** True when the goal loop is enabled; false/undefined → section omitted. */
+  enabled: boolean
+  /** List the session's goals (any status; the builder keeps non-done). */
+  list(sessionID: string): Promise<Goal[]>
+}
+
+/** Source for the <todo_context> section (pending todos). */
+export interface CompactionTodoSource {
+  /** True when the todo enforcer is enabled; false/undefined → section omitted. */
+  enabled: boolean
+  /** List the session's todos (any status; the builder keeps pending). */
+  list(sessionID: string): Promise<TodoLike[]>
+}
+
 export interface CompactionContextOptions {
   /** Scope to jobs launched by this session; omit for all jobs. */
   sessionID?: string
   /** Cap on unread terminal jobs kept (default 10). */
   maxItems?: number
+  /** Goal source for <mission_context> (optional — omitted when absent). */
+  goals?: CompactionGoalSource
+  /** Todo source for <todo_context> (optional — omitted when absent). */
+  todos?: CompactionTodoSource
 }
 
 /** Prompt truncation length for a context line. */
@@ -71,17 +122,69 @@ function unreadTerminalLine(job: BackgroundJobRecord): string {
   )
 }
 
-// ─── Build ─────────────────────────────────────────────────────────────
+// ─── Sections ──────────────────────────────────────────────────────────
 
 /**
- * Build the compaction context blocks for a session's background delegations.
- * Returns an empty array when there is nothing to preserve (caller skips the
- * hook injection entirely).
+ * `<mission_context>` — active (non-done) goals for the session.
+ * Returns undefined when the section must be omitted: no goal source, the
+ * goal loop is disabled, no sessionID (per-session data cannot be scoped),
+ * the source throws (logged, fail-open), or no active goals remain.
  */
-export function buildCompactionContext(
-  board: BackgroundJobBoard,
-  opts: CompactionContextOptions = {},
-): string[] {
+async function missionContextBlock(opts: CompactionContextOptions): Promise<string | undefined> {
+  const source = opts.goals
+  if (opts.sessionID === undefined || source === undefined || !source.enabled) return undefined
+
+  let goals: Goal[]
+  try {
+    goals = await source.list(opts.sessionID)
+  } catch (err: unknown) {
+    const reason = err instanceof Error ? err.message : String(err)
+    log.warn(`compaction goal context failed for session ${opts.sessionID}: ${reason}`)
+    return undefined
+  }
+
+  const active = goals.filter((goal) => goal.status !== 'done')
+  if (active.length === 0) return undefined
+
+  const lines = active.map((goal) => `  [${goal.id}] ${goal.objective} — ${goal.status}`)
+  return `<mission_context>\n${lines.join('\n')}`
+}
+
+/**
+ * `<todo_context>` — pending (not completed/cancelled) todos for the
+ * session. Returns undefined when the section must be omitted: no todo
+ * source, the enforcer is disabled, no sessionID, the source throws
+ * (logged, fail-open), or no pending todos remain.
+ */
+async function todoContextBlock(opts: CompactionContextOptions): Promise<string | undefined> {
+  const source = opts.todos
+  if (opts.sessionID === undefined || source === undefined || !source.enabled) return undefined
+
+  let todos: TodoLike[]
+  try {
+    todos = await source.list(opts.sessionID)
+  } catch (err: unknown) {
+    const reason = err instanceof Error ? err.message : String(err)
+    log.warn(`compaction todo context failed for session ${opts.sessionID}: ${reason}`)
+    return undefined
+  }
+
+  const pending = todos.filter((todo) => todo.status !== 'completed' && todo.status !== 'cancelled')
+  if (pending.length === 0) return undefined
+
+  const lines = pending.map((todo) => {
+    const label = todo.content?.trim() || todo.id || '(no description)'
+    const id = todo.id !== undefined && todo.id !== '' ? `[${todo.id}] ` : ''
+    return `  ${id}${label} — ${todo.status}`
+  })
+  return `<todo_context>\n${lines.join('\n')}`
+}
+
+/**
+ * `<delegation_context>` — the existing delegation blocks, byte-for-byte
+ * unchanged from Phase 4 (running, then unread terminal ≤ maxItems).
+ */
+function delegationBlocks(board: BackgroundJobBoard, opts: CompactionContextOptions): string[] {
   const maxItems = opts.maxItems ?? 10
   const jobs = opts.sessionID !== undefined ? board.list(opts.sessionID) : board.list()
 
@@ -93,8 +196,6 @@ export function buildCompactionContext(
     .sort((a, b) => b.updatedAt - a.updatedAt)
     .slice(0, maxItems)
 
-  if (running.length === 0 && unreadTerminal.length === 0) return []
-
   const blocks: string[] = []
   if (running.length > 0) {
     blocks.push(`Background Delegations (running):\n${running.map(runningLine).join('\n')}`)
@@ -108,3 +209,29 @@ export function buildCompactionContext(
   }
   return blocks
 }
+
+// ─── Build ─────────────────────────────────────────────────────────────
+
+/**
+ * Build the compaction context blocks for a session: preservation
+ * directive, active goals, pending todos, and in-flight background
+ * delegations. Returns an empty array when there is nothing to preserve
+ * (caller skips the hook injection entirely).
+ */
+export async function buildCompactionContext(
+  board: BackgroundJobBoard,
+  opts: CompactionContextOptions = {},
+): Promise<string[]> {
+  const [mission, todo] = await Promise.all([missionContextBlock(opts), todoContextBlock(opts)])
+  const delegation = delegationBlocks(board, opts)
+
+  // Totally-empty state → nothing to preserve; a lone directive is noise.
+  if (mission === undefined && todo === undefined && delegation.length === 0) return []
+
+  const blocks: string[] = []
+  blocks.push(`<pantheon-context directive>\n${PANTHEON_COMPACTION_DIRECTIVE}`)
+  if (mission !== undefined) blocks.push(mission)
+  if (todo !== undefined) blocks.push(todo)
+  blocks.push(...delegation)
+  return blocks
+}

package/src/pantheon/delegation-finalize.ts

@@ -26,7 +26,14 @@ import type { BackgroundJobBoard, BackgroundJobRecord } from './background-job-b
 /** A minimal structural view of one message bundle from session.messages(). */
 export interface DelegationMessageBundle {
   info?: { role?: string; finish?: string; error?: unknown }
-  parts?: Array<{ type?: string; text?: string }>
+  parts?: Array<{
+    type?: string
+    text?: string
+    /** Tool name on `tool` parts — used by the activity sampler. */
+    tool?: string
+    /** Tool input on `tool` parts (opencode SDK ToolPart.metadata). */
+    metadata?: { input?: unknown }
+  }>
 }
 
 /** Minimal structural view of the opencode SDK session client we use. */

package/src/pantheon/delegation-notify.ts

@@ -1,26 +1,25 @@
 /**
- * Delegation Notify (Phase 3) — completion notifications for background jobs.
+ * Delegation event wiring — observe background-job lifecycle events and
+ * route them to finalize. This module is the `event`-hook complement of the
+ * board: `session.idle`/`session.error` on a child session that is a board
+ * job → `finalizeDelegation` (Phase 2), which transitions the board and
+ * fires `onTerminal`.
  *
- * The spike refuted `promptAsync({noReply:true})` as a push mechanism — nothing
- * is delivered to the parent session. The working channel is a QUEUE + flush:
- *
- *   1. When a board job reaches a terminal state (`board.onTerminal`), the
- *      plugin calls `notifyParent(job)` → a `<task-notification>` block is
- *      queued in-memory for `job.parentSessionID` (FIFO, bounded per parent).
- *   2. The next `chat.message` hook fire for that parent session calls
- *      `flushQueue(parentSessionID, output)`, which prepends the pending
- *      notifications onto the first text part of the parent's user message —
- *      the same graceful-degradation channel pantheon-hooks uses for its
- *      <system-reminder> fallback buffer (TUI toasts are broken on 1.18.13).
- *
- * If the parent never sends another message the notification stays queued —
- * the graceful-degradation path. There is deliberately NO client push.
+ * NOT a notification channel. The user policy is ZERO delegation
+ * notifications in the chat transcript — no `<task-notification>` block is
+ * ever injected into a `chat.message` output, and no queued delivery path
+ * exists. Completion visibility lives in the legitimate channels only:
+ * the board `[unread]` marker (`pantheon_delegation_list`),
+ * `pantheon_delegation_read`, TUI toasts (pantheon-hooks, PANTHEON_TOASTS
+ * gate), and compaction carry-forward. The plugin's `onTerminal` listener
+ * writes a file-only log line for the on-disk audit trail.
  *
  * `handleDelegationEvent` wires the `event` hook: `session.idle`/`session.error`
  * on a child session that is a board job → `finalizeDelegation` (Phase 2),
- * which transitions the board and fires `onTerminal` → notify. That makes the
- * onTerminal listener the SINGLE notification point — finalize never notifies
- * directly, so there is no double-notify. Unknown sessions are ignored.
+ * which transitions the board and fires `onTerminal`. Finalize never notifies
+ * directly, and `markReconciled` does not re-fire onTerminal (reconcile is an
+ * acknowledgment, not a completion), so every job gets exactly ONE terminal
+ * transition — never a reconciled echo. Unknown sessions are ignored.
  *
  * Pure TypeScript — zero runtime dependencies beyond the board types.
  *
@@ -41,12 +40,6 @@ export type { FinalizeInput } from './delegation-finalize.ts'
 
 // ─── Types ─────────────────────────────────────────────────────────────
 
-/** One queued notification: text + enqueue timestamp. */
-export interface QueuedNotification {
-  text: string
-  at: number
-}
-
 /** Structural view of the event payload the `event` hook receives. */
 export interface DelegationEventLike {
   type?: string
@@ -61,137 +54,6 @@ export interface DelegationEventDeps {
   finalize: (childSessionID: string, opts: FinalizeInput) => Promise<unknown>
 }
 
-// ─── Notification text ─────────────────────────────────────────────────
-
-/** Cap for description/summary text embedded in a notification. */
-const NOTIFICATION_TEXT_MAX = 120
-
-function truncate(text: string, max: number): string {
-  const trimmed = text.trim()
-  return trimmed.length > max ? `${trimmed.slice(0, max)}…` : trimmed
-}
-
-/**
- * Build the self-contained `<task-notification>` block for a terminal job.
- * Carries the task ID, alias, agent, state, timeout flag, description and
- * result summary so the parent model can act on the completion without extra
- * tool calls.
- */
-export function buildTaskNotification(job: BackgroundJobRecord): string {
-  const stateLabel =
-    job.state === 'completed' ? 'completed' : job.state === 'error' ? 'failed' : job.state
-  const timeout = job.timedOut ? ' (timed out)' : ''
-  // The `Result:` marker makes the child output origin explicit in the parent
-  // context — the summary text came from the CHILD's output, not the parent's
-  // own context (Themis mitigation, Phase 5).
-  const summary = job.resultSummary
-    ? ` — Result: ${truncate(job.resultSummary, NOTIFICATION_TEXT_MAX)}`
-    : ''
-  return [
-    '<task-notification>',
-    `<task id="${job.taskID}" alias="${job.alias}" agent="${job.agent}" state="${job.state}">`,
-    `<summary>Delegation [${job.alias}] (${job.agent}) ${stateLabel}${timeout}: ${truncate(job.description, NOTIFICATION_TEXT_MAX)}${summary}</summary>`,
-    `<read>Read the full report with pantheon_delegation_read({ id: "${job.alias}" }).</read>`,
-    '</task>',
-    '</task-notification>',
-  ].join('\n')
-}
-
-// ─── Notifier (queue + flush) ──────────────────────────────────────────
-
-/** Per-parent queue bound — a full queue drops new entries, never grows unbounded. */
-const MAX_PER_PARENT = 10
-
-function isTextPartLike(value: unknown): value is { type: 'text'; text: string } {
-  if (!value || typeof value !== 'object') return false
-  const part = value as { type?: unknown; text?: unknown }
-  return part.type === 'text' && typeof part.text === 'string'
-}
-
-/**
- * In-memory completion notification queue, keyed by parent session ID.
- * FIFO per parent, bounded (MAX_PER_PARENT — anti-spam philosophy, matching
- * pantheon-hooks' CHAT_REMINDER_MAX). Delivered by `flushQueue` into the
- * parent's next chat.message; delivered notifications are marked sent.
- */
-export class DelegationNotifier {
-  private readonly queue = new Map<string, QueuedNotification[]>()
-  private readonly sent = new Map<string, number>()
-  private readonly warn: (message: string) => void
-
-  /**
-   * @param logger Optional injected logger (testable). Defaults to
-   *   `console.warn` with the `[pantheon-delegation]` prefix, matching the
-   *   plugin's structured-log style.
-   */
-  constructor(logger?: { warn: (message: string) => void }) {
-    this.warn =
-      logger?.warn ?? ((message: string) => console.warn(`[pantheon-delegation] ${message}`))
-  }
-
-  /** Notifications awaiting delivery for a parent session. */
-  pendingCount(parentSessionID: string): number {
-    return this.queue.get(parentSessionID)?.length ?? 0
-  }
-
-  /** Whether any notifications await delivery for a parent session. */
-  hasPending(parentSessionID: string): boolean {
-    return this.pendingCount(parentSessionID) > 0
-  }
-
-  /** Notifications already injected into a parent's chat.message output. */
-  sentCount(parentSessionID: string): number {
-    return this.sent.get(parentSessionID) ?? 0
-  }
-
-  /**
-   * Queue a completion notification for a parent session. The channel: there
-   * is NO client push — the notification is delivered by the next
-   * `flushQueue` for that parent. Returns false when the queue is full.
-   */
-  queueNotification(parentSessionID: string, text: string): boolean {
-    const entries = this.queue.get(parentSessionID) ?? []
-    if (entries.length >= MAX_PER_PARENT) {
-      this.warn(
-        `notification dropped for parent session ${parentSessionID}: ` +
-          `queue full (${MAX_PER_PARENT} pending)`,
-      )
-      return false
-    }
-    entries.push({ text, at: Date.now() })
-    this.queue.set(parentSessionID, entries)
-    return true
-  }
-
-  /** Build + queue the notification for a terminal job. False when full. */
-  notifyParent(job: BackgroundJobRecord): boolean {
-    return this.queueNotification(job.parentSessionID, buildTaskNotification(job))
-  }
-
-  /**
-   * Inject all pending notifications for a parent into a `chat.message` output
-   * (prepend onto the first text part — matching the pantheon-hooks reminder
-   * injection pattern; with no text part the block is unshifted as a new one).
-   * Delivered entries are marked sent. Returns how many were delivered (0 when
-   * nothing was pending).
-   */
-  flushQueue(parentSessionID: string, output: { parts: unknown[] }): number {
-    const entries = this.queue.get(parentSessionID)
-    if (entries === undefined || entries.length === 0) return 0
-    this.queue.delete(parentSessionID)
-
-    const block = entries.map((entry) => entry.text).join('\n')
-    const firstText = output.parts.find(isTextPartLike)
-    if (firstText !== undefined) {
-      firstText.text = `${block}\n\n${firstText.text}`
-    } else {
-      output.parts.unshift({ type: 'text', text: block })
-    }
-    this.sent.set(parentSessionID, (this.sent.get(parentSessionID) ?? 0) + entries.length)
-    return entries.length
-  }
-}
-
 // ─── Event → finalize wiring ───────────────────────────────────────────
 
 function extractErrorMessage(error: unknown): string {
@@ -209,8 +71,8 @@ function extractErrorMessage(error: unknown): string {
  *  - `session.error` on a board job → finalize as error (message extracted);
  *  - any other event, a missing session ID, or an unknown session → no-op.
  *
- * Finalize transitions the board, which fires `onTerminal` — the single point
- * that queues the completion notification (no double-notify). The board's
+ * Finalize transitions the board, which fires `onTerminal` (the plugin's
+ * file-only audit log — no chat delivery; see module header). The board's
  * same-terminal idempotency makes repeated idles harmless (finalize rewrites
  * the report but never transitions a terminal job to a different state).
  *