pantheon-opencode 1.2.0 → 1.2.1

package/src/pantheon/presets.d.mts

@@ -0,0 +1,108 @@
+/**
+ * Type declarations for presets.mjs (model routing presets).
+ * Consumed by src/plugin.ts via `import ... from './pantheon/presets.mjs'`.
+ */
+
+export type Effort = 'low' | 'medium' | 'high'
+
+export declare const EFFORT_RANK: Record<Effort, number>
+
+export interface CapabilityEntry {
+  prefix: string
+  maxEffort: Effort | null
+  stripEffort: boolean
+  vision: boolean
+}
+
+export declare const CAPABILITY_TABLE: CapabilityEntry[]
+
+export interface PresetAgentSpec {
+  model: string
+  reasoning_effort?: Effort
+  fallback_models?: string[]
+  [key: string]: unknown
+}
+
+export interface PresetProviderDef {
+  baseURL: string
+  apiKeyEnv: string
+  [key: string]: unknown
+}
+
+export interface PresetDef {
+  description?: string
+  providers?: Record<string, PresetProviderDef>
+  agents?: Record<string, PresetAgentSpec>
+  [key: string]: unknown
+}
+
+export interface ResolvedPreset {
+  name: string
+  source: 'env' | 'file'
+  agents: Record<string, PresetAgentSpec>
+  providers: Record<string, PresetProviderDef>
+  overrides: unknown
+  vision: { model: string; reasoning_effort?: string } | null
+}
+
+export interface PresetFileOverrides {
+  agents?: Record<string, PresetAgentSpec & { variant?: Effort }>
+  providers?: Record<string, PresetProviderDef>
+}
+
+export interface ActivePresetFile {
+  version: number
+  preset: string
+  source: string
+  updated_at: string
+  overrides?: PresetFileOverrides
+}
+
+export interface ResolveOptions {
+  env?: Record<string, string | undefined>
+  candidates?: Array<string | null | undefined>
+  routingPath?: string
+  logger?: {
+    warn?: (msg: string) => void
+    log?: (msg: string) => void
+    error?: (msg: string) => void
+  }
+}
+
+export declare function capabilityEntry(model: string): CapabilityEntry
+
+export declare function normalizeCapability(
+  model: string,
+  requestedEffort?: Effort | null,
+): { variant: Effort | null; clamped: boolean }
+
+export declare function hasVision(model: string): boolean
+
+export declare const GATEWAY_BROKEN_VISION_MODELS: Set<string>
+
+export declare function visionBrokenOnGateway(model: string, providerID: string): boolean
+
+export declare function loadPresetDefs(routingPath?: string): Record<string, PresetDef>
+
+export declare function resolveActivePreset(options?: ResolveOptions): ResolvedPreset | null
+
+export declare function applyActivePresetToConfig<C extends object>(
+  config: C,
+  options?: ResolveOptions & { env?: Record<string, string | undefined> },
+): ResolvedPreset | null
+
+export interface MissingApiKeyError extends Error {
+  code: 'PANTHEON_MISSING_API_KEY'
+  envVar: string
+}
+
+export declare function applyPreset<C extends object>(
+  config: C,
+  resolved: ResolvedPreset | null,
+  options?: { env?: Record<string, string | undefined> },
+): C
+
+export declare function validatePresetDefs(
+  presets: Record<string, PresetDef>,
+  options?: { agents?: string[] },
+): { ok: boolean; errors: string[]; warnings: string[] }

package/src/pantheon/presets.mjs

@@ -0,0 +1,554 @@
+#!/usr/bin/env node
+/**
+ * presets.mjs — model routing presets for Pantheon OpenCode
+ *
+ * Pure resolver/validator module (NO writes). Provides:
+ *  - capability table + normalizeCapability()  (model → variant/clamp)
+ *  - hasVision()                               (model → image-input support)
+ *  - loadPresetDefs()                           (routing.yml presets: block)
+ *  - resolveActivePreset()                      (env PANTHEON_MODEL_PRESET > file)
+ *  - applyPreset()                              (mutate opencode config)
+ *  - validatePresetDefs()                       (schema checks for CI)
+ *
+ * The active-preset.json file format (version 1):
+ *   {
+ *     "version": 1,
+ *     "preset": "go-deepseek",
+ *     "source": "cli",
+ *     "updated_at": "2026-08-02T12:00:00.000Z",
+ *     "overrides": {
+ *       "agents":    { "hermes": { "model": "...", "variant": "high" } },
+ *       "providers": { "deepseek": { "baseURL": "...", "apiKeyEnv": "..." } }
+ *     }
+ *   }
+ * Override agent `variant` is mapped to `reasoning_effort` during merge.
+ */
+import { readFileSync } from 'node:fs'
+import { join } from 'node:path'
+import { fileURLToPath } from 'node:url'
+import yaml from 'js-yaml'
+
+export const EFFORT_RANK = { low: 0, medium: 1, high: 2 }
+
+/**
+ * Capability table: reasoning-effort ceiling + image-input (vision) support.
+ *
+ * `vision` flags mark models that accept image input. Verified against
+ * models.dev api.json on 2026-08-02 (council decision): qwen3.7-max,
+ * minimax-m2.5 and minimax-m2.7 and glm-5.1/glm-5.2 are TEXT-ONLY (vision:
+ * false); mimo-v2.5 / mimo-v2.5-free / qwen3.7-plus / minimax-m3 and the
+ * o-series (o1/o3/o4) are multimodal (models.dev input: text+image).
+ * claude-* and gpt-5.6-* carry native image support.
+ */
+export const CAPABILITY_TABLE = [
+  { prefix: 'deepseek/deepseek-v4-pro', maxEffort: 'high', stripEffort: false, vision: false },
+  // prefix also covers -free suffix (e.g. deepseek/deepseek-v4-flash-free)
+  { prefix: 'deepseek/deepseek-v4-flash', maxEffort: 'medium', stripEffort: false, vision: false },
+  { prefix: 'claude', maxEffort: null, stripEffort: true, vision: true },
+  // gpt-5.6 family: longest-prefix match picks luna-fast over generic gpt-5.6
+  { prefix: 'gpt-5.6-sol', maxEffort: 'high', stripEffort: false, vision: true },
+  { prefix: 'gpt-5.6-terra', maxEffort: 'medium', stripEffort: false, vision: true },
+  { prefix: 'gpt-5.6-luna-fast', maxEffort: 'low', stripEffort: false, vision: true },
+  { prefix: 'gpt-5.6-luna', maxEffort: 'low', stripEffort: false, vision: true },
+  { prefix: 'gpt-5.6', maxEffort: 'medium', stripEffort: false, vision: true },
+  // o-series are multimodal (models.dev input: text+image+pdf)
+  { prefix: 'o1', maxEffort: 'high', stripEffort: false, vision: true },
+  { prefix: 'o3', maxEffort: 'high', stripEffort: false, vision: true },
+  { prefix: 'o4', maxEffort: 'high', stripEffort: false, vision: true },
+  { prefix: 'mimo/', maxEffort: 'low', stripEffort: false, vision: true },
+  // opencode/mimo-v2.5 fallback (OpenCode Zen): bare segment — the 'mimo/'
+  // entry above matches 'mimo/v2.5' (full-string) but NOT 'mimo-v2.5'
+  // (segment 'mimo-v2.5' has no slash, so 'mimo/' prefix cannot match).
+  { prefix: 'mimo-v2.5', maxEffort: 'low', stripEffort: false, vision: true },
+  // mimo-v2.5-pro is text-only per models.dev api.json (2026-08-02).
+  // Explicit entry needed: the 'mimo-v2.5' prefix substring-matches
+  // 'mimo-v2.5-pro' (longest-prefix wins), which would wrongly report
+  // vision: true for a text-only model.
+  { prefix: 'mimo-v2.5-pro', maxEffort: 'low', stripEffort: false, vision: false },
+  // opencode-go (OpenCode Go subscription) — bare segment prefixes so
+  // opencode-go/<model> IDs match; the provider-scoped deepseek/ entries
+  // above still win by length for deepseek/ models. glm-5.1/glm-5.2 are
+  // text-only per models.dev api.json (2026-08-02).
+  { prefix: 'glm-5.2', maxEffort: 'medium', stripEffort: false, vision: false },
+  { prefix: 'glm-5.1', maxEffort: 'medium', stripEffort: false, vision: false },
+  { prefix: 'kimi-k2.6', maxEffort: 'high', stripEffort: false, vision: true },
+  // qwen3.7-max is text-only per models.dev api.json (2026-08-02); the
+  // multimodal variant is qwen3.7-plus.
+  { prefix: 'qwen3.7-max', maxEffort: 'high', stripEffort: false, vision: false },
+  // qwen3.7-plus IS multimodal (models.dev input: text+image) but image
+  // turns through the OpenCode Go gateway return HTTP 500 (opencode#33942
+  // + #29956). Flag stays true per models.dev; presets must NOT use it as a
+  // vision fallback — minimax-m3 is the confirmed opencode-go fallback.
+  { prefix: 'qwen3.7-plus', maxEffort: 'medium', stripEffort: false, vision: true },
+  // minimax-m2.7 / minimax-m2.5 are text-only per models.dev api.json
+  // (2026-08-02). minimax-m3 is the vision-capable MiniMax on opencode-go
+  // (confirmed multimodal via the Go gateway, opencode#29956).
+  { prefix: 'minimax-m2.7', maxEffort: 'medium', stripEffort: false, vision: false },
+  { prefix: 'minimax-m2.5', maxEffort: 'medium', stripEffort: false, vision: false },
+  { prefix: 'minimax-m3', maxEffort: 'high', stripEffort: false, vision: true },
+  // BARE prefix — needed for opencode-go/deepseek-v4-flash (segment match);
+  // provider-scoped deepseek/deepseek-v4-flash entry still wins by length
+  // for deepseek/ models. Covers -free suffix too.
+  { prefix: 'deepseek-v4-flash', maxEffort: 'medium', stripEffort: false, vision: false },
+  // BARE prefix — needed for opencode-go/deepseek-v4-pro (segment match);
+  // provider-scoped deepseek/deepseek-v4-pro entry still wins by length.
+  { prefix: 'deepseek-v4-pro', maxEffort: 'high', stripEffort: false, vision: false },
+  // opencode (Zen free tier) — bare segment prefixes for opencode/<model>.
+  // big-pickle / nemotron-3-ultra-free / north-mini-code-free verified
+  // text-only via models.dev (2026-08-02).
+  { prefix: 'big-pickle', maxEffort: 'medium', stripEffort: false, vision: false },
+  { prefix: 'nemotron-3-ultra-free', maxEffort: 'high', stripEffort: false, vision: false },
+  { prefix: 'north-mini-code-free', maxEffort: 'high', stripEffort: false, vision: false },
+]
+
+/**
+ * Find the capability entry for a model ID.
+ * Matches when the model starts with the prefix OR the segment after the
+ * last '/' starts with the prefix. Longest matching prefix wins.
+ *
+ * @param {string} model model ID (e.g. "deepseek/deepseek-v4-flash")
+ * @returns {{prefix: string, maxEffort: 'low'|'medium'|'high'|null, stripEffort: boolean, vision: boolean}}
+ */
+export function capabilityEntry(model) {
+  const matches = CAPABILITY_TABLE.filter((entry) => {
+    if (model.startsWith(entry.prefix)) return true
+    const segment = model.slice(model.lastIndexOf('/') + 1)
+    return segment.startsWith(entry.prefix)
+  })
+  if (matches.length === 0) {
+    throw new Error(`presets: no capability entry for model ${model}`)
+  }
+  matches.sort((a, b) => b.prefix.length - a.prefix.length)
+  return matches[0]
+}
+
+/**
+ * Normalize a requested reasoning effort to a model variant, clamping to the
+ * model's capability ceiling.
+ *
+ * - stripEffort models (claude) → variant null (no variant key).
+ * - undefined/null requested → entry maxEffort (or null when stripping).
+ * - rank(requested) > rank(maxEffort) → clamp to maxEffort.
+ *
+ * @param {string} model
+ * @param {'low'|'medium'|'high'|null|undefined} [requestedEffort]
+ * @returns {{variant: 'low'|'medium'|'high'|null, clamped: boolean}}
+ */
+export function normalizeCapability(model, requestedEffort) {
+  const entry = capabilityEntry(model)
+  if (entry.stripEffort) {
+    return { variant: null, clamped: requestedEffort != null }
+  }
+  const maxEffort = entry.maxEffort
+  if (requestedEffort === undefined || requestedEffort === null) {
+    return { variant: maxEffort, clamped: false }
+  }
+  if (EFFORT_RANK[requestedEffort] > EFFORT_RANK[maxEffort]) {
+    return { variant: maxEffort, clamped: true }
+  }
+  return { variant: requestedEffort, clamped: false }
+}
+
+/**
+ * Whether a model accepts image input (vision) per CAPABILITY_TABLE.
+ * Throws on models with no capability entry (same as normalizeCapability).
+ *
+ * @param {string} model
+ * @returns {boolean}
+ */
+export function hasVision(model) {
+  return capabilityEntry(model).vision
+}
+
+/**
+ * Models that ARE vision-capable per models.dev but whose image turns FAIL
+ * on the OpenCode Go gateway (HTTP 500 — opencode#33942 + opencode#29956).
+ * Runtime image routing treats them as TEXT-ONLY so image turns are
+ * intercepted and routed to the confirmed multimodal fallback (minimax-m3)
+ * instead of being sent directly to the gateway. Keyed by the model segment
+ * (after the last '/') so bare and provider-qualified IDs both match.
+ */
+export const GATEWAY_BROKEN_VISION_MODELS = new Set(['qwen3.7-plus'])
+
+/**
+ * Whether a model's image input is BROKEN on the given provider's runtime
+ * gateway — vision per models.dev, but image turns fail. Provider-scoped:
+ * only the OpenCode Go gateway (opencode-go) has a documented breakage; the
+ * same model elsewhere (Zen free `opencode`, anthropic, openai) keeps its
+ * native bypass.
+ *
+ * @param {string} model model ID (e.g. "opencode-go/qwen3.7-plus")
+ * @param {string} providerID provider the model runs on
+ * @returns {boolean}
+ */
+export function visionBrokenOnGateway(model, providerID) {
+  if (!/^opencode-go$/.test(providerID ?? '')) return false
+  const segment = model.slice(model.lastIndexOf('/') + 1)
+  return GATEWAY_BROKEN_VISION_MODELS.has(segment)
+}
+
+/**
+ * Load preset definitions from routing.yml (top-level `presets:` key).
+ *
+ * @param {string} [routingPath] defaults to src/routing.yml
+ * @returns {Record<string, object>} preset name → definition ({} when absent)
+ */
+export function loadPresetDefs(routingPath) {
+  const path = routingPath ?? fileURLToPath(new URL('../routing.yml', import.meta.url))
+  let raw
+  try {
+    raw = readFileSync(path, 'utf8')
+  } catch (err) {
+    throw new Error(`presets: failed to load routing.yml: ${path} — ${err.message}`)
+  }
+  let routing
+  try {
+    routing = yaml.load(raw)
+  } catch (err) {
+    throw new Error(`presets: failed to load routing.yml: ${err.message}`)
+  }
+  return (routing && typeof routing === 'object' && routing.presets) || {}
+}
+
+/**
+ * Resolve the active preset: env PANTHEON_MODEL_PRESET > first existing
+ * candidate file > null. "none" disables. Unknown names warn and return null
+ * WITHOUT falling through to lower-priority sources.
+ *
+ * @param {object} [opts]
+ * @param {Record<string, string|undefined>} [opts.env]
+ * @param {string[]} [opts.candidates]
+ * @param {string} [opts.routingPath]
+ * @param {{warn?: Function, log?: Function, error?: Function}} [opts.logger]
+ * @returns {{name: string, source: 'env'|'file', agents: object, providers: object, overrides: object|null, vision: {model: string, reasoning_effort?: 'low'|'medium'|'high'}|null}}
+ */
+export function resolveActivePreset({
+  env = process.env,
+  candidates = [join(process.cwd(), '.pantheon', 'active-preset.json')],
+  routingPath,
+  logger = console,
+} = {}) {
+  const defs = loadPresetDefs(routingPath)
+
+  const envName = env.PANTHEON_MODEL_PRESET
+  if (envName !== undefined && envName !== '') {
+    if (envName === 'none') return null
+    const def = defs[envName]
+    if (!def) {
+      logger.warn?.(
+        `presets: unknown preset "${envName}" (PANTHEON_MODEL_PRESET). Available: ${Object.keys(defs).join(', ') || 'none'}`,
+      )
+      return null
+    }
+    return buildResolved(defs, envName, 'env', null)
+  }
+
+  for (const candidate of candidates) {
+    if (!candidate) continue
+    let exists
+    try {
+      exists = readFileSync(candidate)
+    } catch {
+      continue // candidate does not exist
+    }
+    let raw
+    try {
+      raw = JSON.parse(exists.toString('utf8'))
+    } catch {
+      logger.warn?.(`presets: malformed active preset file: ${candidate}`)
+      return null
+    }
+    const name = raw && typeof raw === 'object' ? raw.preset : undefined
+    if (!name || name === 'none') return null
+    const def = defs[name]
+    if (!def) {
+      logger.warn?.(
+        `presets: unknown preset "${name}" in ${candidate}. Available: ${Object.keys(defs).join(', ') || 'none'}`,
+      )
+      return null
+    }
+    return buildResolved(defs, name, 'file', raw)
+  }
+
+  return null
+}
+
+/**
+ * Build the resolved preset by merging preset defs with file overrides.
+ * Overrides win per-agent / per-provider; override `variant` → reasoning_effort.
+ * `vision` comes from the preset def, overridable via `overrides.vision`
+ * (an explicit null in the file clears the fallback).
+ *
+ * @param {Record<string, object>} defs
+ * @param {string} name
+ * @param {'env'|'file'} source
+ * @param {object|null} rawFile
+ */
+function buildResolved(defs, name, source, rawFile) {
+  const def = defs[name] || {}
+  const overrides = rawFile && typeof rawFile === 'object' ? rawFile.overrides : null
+  const agentOverrides = overrides?.agents ?? {}
+  const providerOverrides = overrides?.providers ?? {}
+  // Vision override shallow-merges with the preset def (a partial
+  // `{model}` keeps the preset's reasoning_effort) — mirrors how agent
+  // overrides merge. An explicit `overrides.vision: null` clears the
+  // fallback; a truthy non-object override is ignored like agents do.
+  let vision = def.vision ?? null
+  if (overrides && Object.hasOwn(overrides, 'vision')) {
+    const override = overrides.vision
+    if (override === null) {
+      vision = null
+    } else if (override && typeof override === 'object') {
+      vision = { ...(def.vision ?? {}), ...override }
+    }
+  }
+
+  const agents = {}
+  for (const [agent, spec] of Object.entries(def.agents ?? {})) {
+    let merged = { ...spec }
+    const override = agentOverrides[agent]
+    if (override && typeof override === 'object') {
+      merged = { ...merged, ...override }
+      if (override.variant !== undefined) {
+        merged.reasoning_effort = override.variant
+      }
+    }
+    agents[agent] = merged
+  }
+
+  const providers = { ...(def.providers ?? {}) }
+  for (const [id, provider] of Object.entries(providerOverrides)) {
+    if (provider && typeof provider === 'object') {
+      providers[id] = { ...(providers[id] ?? {}), ...provider }
+    }
+  }
+
+  return { name, source, agents, providers, overrides, vision }
+}
+
+/**
+ * Apply a resolved preset to an opencode config object (mutates `config`).
+ * - Providers: config.provider[id].options.baseURL + apiKey (env-gated).
+ * - Agents:    config.agent[agent].model / .variant / .fallback_models.
+ * Only agents listed in the preset are touched (partial semantics).
+ *
+ * @throws {Error} code=PANTHEON_MISSING_API_KEY, envVar set, when a provider
+ *   key env var is unset/empty.
+ */
+export function applyPreset(config, resolved, { env = process.env } = {}) {
+  if (!resolved) return config
+
+  for (const [id, provider] of Object.entries(resolved.providers ?? {})) {
+    const apiKey = env[provider.apiKeyEnv]
+    if (!apiKey) {
+      const err = new Error(`presets: provider "${id}" requires env var ${provider.apiKeyEnv}`)
+      err.code = 'PANTHEON_MISSING_API_KEY'
+      err.envVar = provider.apiKeyEnv
+      throw err
+    }
+    config.provider ??= {}
+    config.provider[id] ??= {}
+    config.provider[id].options ??= {}
+    config.provider[id].options.baseURL = provider.baseURL
+    config.provider[id].options.apiKey = apiKey
+  }
+
+  for (const [agent, spec] of Object.entries(resolved.agents ?? {})) {
+    config.agent ??= {}
+    config.agent[agent] ??= {}
+    config.agent[agent].model = spec.model
+    const { variant } = normalizeCapability(spec.model, spec.reasoning_effort)
+    if (variant === null) {
+      delete config.agent[agent].variant
+    } else {
+      config.agent[agent].variant = variant
+    }
+    if (spec.fallback_models !== undefined) {
+      config.agent[agent].fallback_models = [...spec.fallback_models]
+    }
+  }
+
+  return config
+}
+
+/**
+ * Resolve the active preset and apply it to an opencode config in ONE call —
+ * the entry point used by the plugin `config` hook (P1-1) and CLI flows.
+ *
+ * Fail-safe: without an active preset (env unset, no candidate file,
+ * "none") the config is returned UNMUTATED and null is returned. When a
+ * preset resolves but its provider key env var is missing, `applyPreset`
+ * throws PANTHEON_MISSING_API_KEY — the hook catches and skips.
+ *
+ * Default candidates mirror the plugin hook (project .pantheon file); the
+ * plugin passes the full project/XDG/HOME list via `activePresetCandidates`
+ * (vision.ts) for exact agreement with the native vision model resolution.
+ *
+ * @param {object} config opencode config object (mutated on success)
+ * @param {object} [opts]
+ * @param {Record<string, string|undefined>} [opts.env]
+ * @param {Array<string|null|undefined>} [opts.candidates]
+ * @param {string} [opts.routingPath]
+ * @param {{warn?: Function, log?: Function, error?: Function}} [opts.logger]
+ * @returns {ResolvedPreset|null}
+ */
+export function applyActivePresetToConfig(
+  config,
+  { env = process.env, candidates, routingPath, logger } = {},
+) {
+  const resolved = resolveActivePreset({
+    env,
+    candidates: candidates ?? [join(process.cwd(), '.pantheon', 'active-preset.json')],
+    routingPath,
+    logger,
+  })
+  if (!resolved) return null
+  applyPreset(config, resolved, { env })
+  return resolved
+}
+
+const MODEL_RE = /^[A-Za-z0-9][A-Za-z0-9._-]*\/.+$/
+
+/**
+ * Validate preset definitions against the schema.
+ *
+ * @param {Record<string, object>} presets
+ * @param {{agents?: string[]}} [opts] known agent names (routing minus legacy)
+ * @returns {{ok: boolean, errors: string[], warnings: string[]}}
+ */
+export function validatePresetDefs(presets, { agents } = {}) {
+  const errors = []
+  const warnings = []
+  const knownAgents = agents ? new Set(agents) : null
+
+  for (const [name, def] of Object.entries(presets)) {
+    if (name === 'none') {
+      errors.push(`preset "${name}": name "none" is reserved`)
+      continue
+    }
+    if (!def || typeof def !== 'object' || Array.isArray(def)) {
+      errors.push(`preset "${name}": definition must be a plain object`)
+      continue
+    }
+
+    if (typeof def.description === 'string' && !/\b(19|20)\d{2}\b/.test(def.description)) {
+      warnings.push(`preset "${name}": description missing a 4-digit year`)
+    }
+
+    for (const [id, provider] of Object.entries(def.providers ?? {})) {
+      if (!provider || typeof provider !== 'object' || Array.isArray(provider)) {
+        errors.push(`preset "${name}": provider "${id}" must be an object`)
+        continue
+      }
+      if (!provider.baseURL) {
+        errors.push(`preset "${name}": provider "${id}" missing baseURL`)
+      } else if (!/^https?:\/\//.test(provider.baseURL)) {
+        errors.push(`preset "${name}": provider "${id}" baseURL must start with http(s)://`)
+      }
+      if (typeof provider.apiKeyEnv !== 'string' || provider.apiKeyEnv.length === 0) {
+        errors.push(`preset "${name}": provider "${id}" apiKeyEnv must be a non-empty string`)
+      } else if (!provider.apiKeyEnv.startsWith('PANTHEON_')) {
+        warnings.push(`preset "${name}": provider "${id}" apiKeyEnv should start with PANTHEON_`)
+      }
+    }
+
+    for (const [agent, spec] of Object.entries(def.agents ?? {})) {
+      if (knownAgents && !knownAgents.has(agent)) {
+        errors.push(`preset "${name}": unknown agent "${agent}"`)
+      }
+      if (!spec || typeof spec !== 'object' || Array.isArray(spec)) {
+        errors.push(`preset "${name}": agent "${agent}" spec must be an object`)
+        continue
+      }
+      if (typeof spec.model !== 'string' || !MODEL_RE.test(spec.model)) {
+        errors.push(
+          `preset "${name}": agent "${agent}" model must match provider/model (got "${spec.model}")`,
+        )
+      } else {
+        try {
+          capabilityEntry(spec.model)
+        } catch (err) {
+          errors.push(`preset "${name}": agent "${agent}" ${err.message}`)
+        }
+      }
+      if (
+        spec.reasoning_effort !== undefined &&
+        !Object.hasOwn(EFFORT_RANK, spec.reasoning_effort)
+      ) {
+        errors.push(
+          `preset "${name}": agent "${agent}" reasoning_effort must be one of low, medium, high`,
+        )
+      }
+      if (spec.fallback_models !== undefined) {
+        if (
+          !Array.isArray(spec.fallback_models) ||
+          spec.fallback_models.some((m) => typeof m !== 'string')
+        ) {
+          errors.push(
+            `preset "${name}": agent "${agent}" fallback_models must be an array of strings`,
+          )
+        }
+      }
+    }
+
+    // Optional top-level vision fallback (routes image turns to a
+    // vision-capable model when the agent models are text-only).
+    if (def.vision !== undefined) {
+      const v = def.vision
+      if (!v || typeof v !== 'object' || Array.isArray(v)) {
+        errors.push(
+          `preset "${name}": vision must be an object with model (+ optional reasoning_effort)`,
+        )
+      } else {
+        if (typeof v.model !== 'string' || !MODEL_RE.test(v.model)) {
+          errors.push(`preset "${name}": vision.model must match provider/model (got "${v.model}")`)
+        } else {
+          try {
+            const entry = capabilityEntry(v.model)
+            if (!entry.vision) {
+              errors.push(`preset "${name}": vision model "${v.model}" is not vision-capable`)
+            }
+          } catch (err) {
+            errors.push(`preset "${name}": vision ${err.message}`)
+          }
+          // The vision model's provider (segment before the first '/') MUST
+          // be declared in the preset's providers block (council 2026-08-02):
+          // a vision fallback is unusable if applyPreset never injects the
+          // provider config for it.
+          const provider = v.model.slice(0, v.model.indexOf('/'))
+          const declared = Object.keys(def.providers ?? {})
+          if (!declared.includes(provider)) {
+            errors.push(
+              `preset "${name}": vision model ${v.model} uses provider ${provider} not declared in providers`,
+            )
+          }
+        }
+        if (v.reasoning_effort !== undefined && !Object.hasOwn(EFFORT_RANK, v.reasoning_effort)) {
+          errors.push(`preset "${name}": vision reasoning_effort must be one of low, medium, high`)
+        }
+      }
+    } else {
+      // No vision fallback declared: warn when every primary agent model is
+      // text-only — image turns would have no vision-capable route.
+      const agentModels = Object.values(def.agents ?? {})
+        .map((s) => (s && typeof s === 'object' ? s.model : undefined))
+        .filter((m) => typeof m === 'string')
+      if (
+        agentModels.length > 0 &&
+        agentModels.every((m) => {
+          try {
+            return !hasVision(m)
+          } catch {
+            return true
+          }
+        })
+      ) {
+        warnings.push(
+          `preset "${name}": all primary agent models are text-only — consider adding a vision fallback`,
+        )
+      }
+    }
+  }
+
+  return { ok: errors.length === 0, errors, warnings }
+}