paid-services 3.3.0 → 3.6.0

package/.prettierignore

@@ -0,0 +1,2 @@
+bos
+*.js

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Versions
 
+## Version 3.6.0
+
+- `manageTrades`: Add support for persistent open trades
+- `manageTrades`: Add expiration dates to open trades
+- `manageTrades`: Support longer-lived open trade scenarios
+- `manageTrades`: Show final encoded trade when requesting open trade
+- `manageTrades`: Check for RPC signer support before trading
+
+## Version 3.5.1
+
+- `changeChannelCapacity`: Allow changing private/public status of channel
+
+## Version 3.4.0
+
+- `changeChannelCapacity`: Fix broken preservation of channel announce status
+- `manageTrades`: Add support for open-ended trades
+
 ## Version 3.3.0
 
 - `changeChannelCapacity`: Add method to change a channel's capacity

package/capacity/accept_capacity_change.js

@@ -12,9 +12,9 @@ const {makePeerRequest} = require('./../p2p');
 const parseAcceptResponse = require('./parse_accept_response');
 const parseSignCapacityRequest = require('./parse_sign_capacity_request');
 const {servicePeerRequests} = require('./../p2p');
-const {serviceTypeAcceptCapacityChange} = require('./service_types');
-const {serviceTypeSignCapacityChange} = require('./service_types');
-const {serviceTypeWaitOnConfirmation} = require('./service_types');
+const {serviceTypeAcceptCapacityChange} = require('./../service_types');
+const {serviceTypeSignCapacityChange} = require('./../service_types');
+const {serviceTypeWaitOnConfirmation} = require('./../service_types');
 
 const acceptChangeTimeoutMs = 1000 * 45;
 const bufferAsHex = buffer => buffer.toString('hex');

package/capacity/ask_for_change_details.js

@@ -24,6 +24,8 @@ const minNewLocalBalance = 0;
 const nonNegative = n => Math.max(0, n);
 const outputSize = 44;
 const positive = n => Math.max(1, n);
+const privateType = 1;
+const publicType = 0;
 const slowTarget = 1000;
 const sumOf = arr => arr.reduce((sum, n) => sum + n, 0);
 const sumOfTokens = arr => arr.reduce((sum, n) => sum + n.tokens, 0);
@@ -395,10 +397,37 @@ module.exports = ({ask, id, lnd}, cbk) => {
         ({amount}) => cbk(null, Number(amount)));
       }],
 
+      // Confirm or change the announce status of the replacement channel
+      askForPublicPrivate: [
+        'askForDecrease',
+        'askForIncrease',
+        'channel',
+        ({channel}, cbk) =>
+      {
+        return ask({
+          choices: ['Public', 'Private'].map(type => {
+            const isPrivate = type === 'Private';
+
+            // Exit early when the type would be different
+            if (isPrivate !== channel.is_private) {
+              return type;
+            }
+
+            return `${type} (Keep Current Status)`;
+          }),
+          default: channel.is_private ? 'Private' : 'Public',
+          message: 'Channel type?',
+          name: 'type',
+          type: 'list',
+        },
+        ({type}) => cbk(null, {is_private: type === 'Private'}));
+      }],
+
       // Estimate the chain fee
       estimateChainFee: [
         'askForDecrease',
         'askForIncrease',
+        'askForPublicPrivate',
         'channel',
         'getFeeRate',
         ({askForDecrease, askForIncrease, channel, getFeeRate}, cbk) =>
@@ -417,6 +446,7 @@ module.exports = ({ask, id, lnd}, cbk) => {
 
       // Confirm chain fee payment estimate
       confirmFeeEstimate: [
+        'askForPublicPrivate',
         'channel',
         'estimateChainFee',
         ({channel, estimateChainFee}, cbk) =>
@@ -437,6 +467,7 @@ module.exports = ({ask, id, lnd}, cbk) => {
       details: [
         'askForDecrease',
         'askForIncrease',
+        'askForPublicPrivate',
         'channel',
         'confirmFeeEstimate',
         'estimateChainFee',
@@ -444,6 +475,7 @@ module.exports = ({ask, id, lnd}, cbk) => {
         ({
           askForDecrease,
           askForIncrease,
+          askForPublicPrivate,
           channel,
           confirmFeeEstimate,
           estimateChainFee,
@@ -478,6 +510,7 @@ module.exports = ({ask, id, lnd}, cbk) => {
           channel: channel.id,
           decrease: !!askForDecrease ? sumOfTokens(askForDecrease) : undefined,
           increase: askForIncrease,
+          type: askForPublicPrivate.is_private ? privateType : publicType,
         });
 
         return cbk(null, {
@@ -491,7 +524,7 @@ module.exports = ({ask, id, lnd}, cbk) => {
           fee_rate: channel.fee_rate,
           id: channel.id,
           increase: askForIncrease,
-          is_private: channel.is_private,
+          is_private: askForPublicPrivate.is_private,
           open_transaction: channel.open_transaction,
           partner_csv_delay: channel.partner_csv_delay,
           partner_public_key: channel.partner_public_key,

package/capacity/capacity_change_requests.js

@@ -1,3 +1,5 @@
+const privateAsType = isPrivate => isPrivate ? 1 : 0;
+
 /** Map change requests to requests considering local channels
 
   {
@@ -13,6 +15,7 @@
       from: <From Node Public Key Id Hex String>
       id: <Change Request Id Hex String>
       [increase]: <Add Capacity Tokens Number>
+      [type]: <Intended Replacement Channel Channel Type Flags Number>
     }]
   }
 
@@ -26,6 +29,7 @@
       from: <From Node Public Key Id Hex String>
       id: <Change Request Id Hex String>
       [increase]: <Add Capacity Tokens Number>
+      [type]: <Change Channel Channel Type Flags Number>
     }]
   }
 */
@@ -61,6 +65,10 @@ module.exports = ({channels, requests}) => {
     .map(request => {
       const channel = channels.find(chan => chan.id === request.channel);
 
+      const currentType = privateAsType(channel.is_private);
+
+      const type = request.type !== undefined && request.type !== currentType;
+
       return {
         address: channel.cooperative_close_address,
         capacity: channel.capacity,
@@ -69,6 +77,7 @@ module.exports = ({channels, requests}) => {
         from: channel.partner_public_key,
         id: request.id,
         increase: request.increase,
+        type: type ? request.type : undefined,
       };
     });
 

package/capacity/change_channel_capacity.js

@@ -10,6 +10,7 @@ const acceptCapacityChange = require('./accept_capacity_change');
 const getCapacityChangeRequests = require('./get_capacity_change_requests');
 const initiateCapacityChange = require('./initiate_capacity_change');
 
+const describeType = type => !(type & 0) ? 'private' : 'public';
 const interval = 10 * 1000;
 const peerName = ({alias, id}) => `${alias} ${id.substring(0, 8)}`.trim();
 const times = 6 * 60 * 6;
@@ -89,17 +90,22 @@ module.exports = ({ask, delay, lnd, logger}, cbk) => {
 
             const change = !!request.increase ? 'Increase' : 'Decrease';
             const delta = request.decrease || request.increase;
+            const hasType = request.type !== undefined;
             const id = request.channel;
             const peer = peerName(res);
             const size = tokensAsBigUnit(request.capacity);
 
+
             const action = `${change} capacity ${size} channel ${id}`;
             const by = !!delta ? ` by ${tokensAsBigUnit(delta)}` : '';
+            const type = hasType ? describeType(request.type) : '';
+
+            const changeType = hasType ? ` and make channel ${type}` : '';
 
             return ask({
               type: 'confirm',
               name: 'accept',
-              message: `${action} with ${peer}${by}?`,
+              message: `${action} with ${peer}${by}${changeType}?`,
             },
             ({accept}) => {
               if (!accept) {

package/capacity/encode_change_request.js

@@ -1,10 +1,12 @@
 const {encodeBigSize} = require('bolt01');
 const {rawChanId} = require('bolt07');
 
+const channelFlagsType = '5';
 const channelIdRecordType = '2';
 const decreaseRecordType = '3';
 const increaseRecordType = '4';
 const requestIdRecordType = '1';
+const typeAsHex = type => Buffer.from([type]).toString('hex');
 
 /** Encode a request to change a channel capacity
 
@@ -13,6 +15,7 @@ const requestIdRecordType = '1';
     [decrease]: <Remove Channel Funds By Tokens Number>
     id: <Request Id Hex String>
     increase: <Add Channel Funds By Tokens Number>
+    type: <New Channel Type Number>
   }
 
   @returns
@@ -23,7 +26,7 @@ const requestIdRecordType = '1';
     }]
   }
 */
-module.exports = ({channel, decrease, id, increase}) => {
+module.exports = ({channel, decrease, id, increase, type}) => {
   const records = [
     {
       type: requestIdRecordType,
@@ -33,6 +36,10 @@ module.exports = ({channel, decrease, id, increase}) => {
       type: channelIdRecordType,
       value: rawChanId({channel}).id,
     },
+    {
+      type: channelFlagsType,
+      value: typeAsHex(type),
+    },
   ];
 
   if (!!decrease) {

package/capacity/fee_for_replacement.js

@@ -13,7 +13,7 @@ const dummySignature = Buffer.alloc(74);
 const dummyTokens = 0;
 const dummyVout = 0;
 const hexAsBuffer = hex => Buffer.from(hex, 'hex');
-const increaseBuffer = 150;
+const increaseBuffer = 300;
 const {max} = Math;
 const weightAsVBytes = weight => weight / 4;
 

package/capacity/get_capacity_change_requests.js

@@ -4,7 +4,7 @@ const {returnResult} = require('asyncjs-util');
 const {subscribeToPeerMessages} = require('ln-service');
 
 const capacityChangeRequests = require('./capacity_change_requests');
-const {serviceTypeChangeCapacity} = require('./service_types');
+const {serviceTypeChangeCapacity} = require('./../service_types');
 const parseCapacityChangeRequest = require('./parse_capacity_change_request');
 const {servicePeerRequests} = require('./../p2p');
 
@@ -28,6 +28,7 @@ const waitForRequestsTimeoutMs = 5000;
       from: <From Node Public Key Id Hex String>
       id: <Change Request Id Hex String>
       [increase]: <Add Capacity Tokens Number>
+      [type]: <Intended Replacement Channel Channel Type Flags Number>
     }]
   }
 */

package/capacity/get_capacity_replacement.js

@@ -264,10 +264,10 @@ module.exports = (args, cbk) => {
           channels: [{
             capacity: newCapacity,
             give_tokens: pendingChannel.remote_balance,
+            is_private: args.is_private,
             partner_public_key: pendingChannel.partner_public_key,
           }],
           is_avoiding_broadcast: true,
-          is_private: args.is_private,
           lnd: args.lnd,
         },
         cbk);

package/capacity/initiate_capacity_change.js

@@ -23,10 +23,10 @@ const {makePeerRequest} = require('./../p2p');
 const parseAcceptRequest = require('./parse_accept_request');
 const proposeCapacityChange = require('./propose_capacity_change');
 const {servicePeerRequests} = require('./../p2p');
-const {serviceTypeAcceptCapacityChange} = require('./service_types');
-const {serviceTypeChangeCapacity} = require('./service_types');
-const {serviceTypeSignCapacityChange} = require('./service_types');
-const {serviceTypeWaitOnConfirmation} = require('./service_types');
+const {serviceTypeAcceptCapacityChange} = require('./../service_types');
+const {serviceTypeChangeCapacity} = require('./../service_types');
+const {serviceTypeSignCapacityChange} = require('./../service_types');
+const {serviceTypeWaitOnConfirmation} = require('./../service_types');
 
 const bufferAsHex = buffer => buffer.toString('hex');
 const capacityChangeRequestIdType = '0';
@@ -47,7 +47,6 @@ const rebroadcastTimeMs = 1000 * 5;
 const recordsAsObject = a => a.reduce((sum, n) => sum[n.type] = n.value, {});
 const requestCapacityChangeIntervalMs = 2000;
 const requestCapacityChangeTimeoutMs = 1000 * 60 * 60 * 6;
-const sumOf = arr => arr.reduce((sum, n) => sum + n, Number());
 const testMessage = '00';
 const tokensAsBigUnit = tokens => (tokens / 1e8).toFixed(8);
 const uniq = arr => Array.from(new Set(arr));
@@ -438,6 +437,7 @@ module.exports = ({ask, lnd, logger}, cbk) => {
           increase_transaction_id: getFunding.id,
           increase_transaction_vout: getFunding.vout,
           increase_witness_script: getFunding.script,
+          is_private: askForChangeDetails.is_private,
           open_transaction: sendBasicRequest,
           partner_public_key: askForChangeDetails.partner_public_key,
           transaction_id: channel.transaction_id,

package/capacity/parse_capacity_change_request.js

@@ -4,6 +4,7 @@ const {decodeBigSize} = require('bolt01');
 const channelIdHexLength = 16;
 const decodeNumber = encoded => BigInt(decodeBigSize({encoded}).decoded);
 const defaultRecord = {value: '00'};
+const hexAsNumber = n => Buffer.from(n, 'hex').readUInt8();
 const idHexLength = 64;
 const tooLarge = BigInt(Number.MAX_SAFE_INTEGER);
 
@@ -11,6 +12,7 @@ const findChannelRecord = records => records.find(n => n.type === '2');
 const findDecreaseRecord = records => records.find(n => n.type === '3');
 const findIncreaseRecord = records => records.find(n => n.type === '4');
 const findRequestIdRecord = records => records.find(n => n.type === '1');
+const findTypeRecord = records => records.find(n => n.type === '5');
 const findVersionRecord = records => records.find(n => n.type === '0');
 
 /** Parse a capacity change request
@@ -31,6 +33,7 @@ const findVersionRecord = records => records.find(n => n.type === '0');
       from: <From Node Public Key Id Hex String>
       id: <Change Request Id Hex String>
       [increase]: <Add Capacity Tokens Number>
+      [type]: <Intended Replacement Channel Channel Type Flags Number>
     }
   }
 */
@@ -52,6 +55,7 @@ module.exports = ({from, records}) => {
     return {};
   }
 
+  // Make sure the channel id is a regular one
   try {
     chanFormat({id: channelRecord.value});
   } catch (err) {
@@ -67,6 +71,7 @@ module.exports = ({from, records}) => {
 
   const decreaseRecord = findDecreaseRecord(records);
   const increaseRecord = findIncreaseRecord(records);
+  const typeRecord = findTypeRecord(records);
 
   // Exit early when there is a change in both directions
   if (!!decreaseRecord && !!increaseRecord) {
@@ -75,10 +80,11 @@ module.exports = ({from, records}) => {
 
   const {channel} = chanFormat({id: channelRecord.value});
   const id = idRecord.value;
+  const type = typeRecord ? hexAsNumber(typeRecord.value) : undefined;
 
   // Exit early when there is no decrease or increase
   if (!decreaseRecord && !increaseRecord) {
-    return {request: {channel, from, id}};
+    return {request: {channel, from, id, type}};
   }
 
   const decrease = decodeNumber((decreaseRecord || defaultRecord).value);
@@ -94,6 +100,7 @@ module.exports = ({from, records}) => {
       channel,
       from,
       id,
+      type,
       decrease: Number(decrease) || undefined,
       increase: Number(increase) || undefined,
     },

package/capacity/propose_capacity_change.js

@@ -17,7 +17,7 @@ const finalizeCapacityReplacement = require('./finalize_capacity_replacement');
 const getCapacityReplacement = require('./get_capacity_replacement');
 const interimReplacementPsbt = require('./interim_replacement_psbt');
 const {makePeerRequest} = require('./../p2p');
-const {serviceTypeSignCapacityChange} = require('./service_types');
+const {serviceTypeSignCapacityChange} = require('./../service_types');
 
 const capacityChangeIdType = '0';
 const findSignatureRecord = records => records.find(n => n.type === '1');
@@ -40,6 +40,7 @@ const unsignedTransactionType = '1';
       tokens: <Spend Value Number>
     }]
     id: <Capacity Change Request Id Hex String>
+    is_private: <Channel is Private Bool>
     [increase]: <Increase Channel Size Tokens Number>
     [increase_key_index]: <Increase Funds Transit Key Number>
     [increase_output_script]: <Increase Funds Output Script Hex String>
@@ -119,7 +120,9 @@ module.exports = (args, cbk) => {
           bitcoinjs_network: args.bitcoinjs_network,
           decrease: args.decrease,
           id: args.channel,
+          is_private: args.is_private,
           increase: args.increase,
+          is_private: args.is_private,
           lnd: args.lnd,
           open_transaction: args.open_transaction,
           transaction_id: args.transaction_id,

package/p2p/service_peer_requests.js

@@ -16,6 +16,7 @@ const returnSuccessResponse = require('./return_success_response');
 
   @returns
   {
+    end: <Add a Service Ended Function>
     error: <Add an Error Listener Function>
     request: <Add A Request Listener For Type Function>
     stop: <Stop Listening Function> ({}) => {};
@@ -55,9 +56,15 @@ const returnSuccessResponse = require('./return_success_response');
 */
 module.exports = ({lnd}) => {
   const listeners = {};
-  const service = {error: () => {}};
+  const service = {end: () => {}, error: () => {}};
   const sub = subscribeToPeerMessages({lnd});
 
+  sub.on('error', error => {
+    service.error(error);
+
+    return service.end();
+  });
+
   sub.on('message_received', received => {
     const from = received.public_key;
     const {message} = received;
@@ -93,7 +100,8 @@ module.exports = ({lnd}) => {
   });
 
   return {
-    error: cbk => service[error] = cbk,
+    end: cbk => service.end = cbk,
+    error: cbk => service.error = cbk,
     request: ({type}, cbk) => listeners[type] = cbk,
     stop: ({}) => sub.removeAllListeners(),
   };

package/package.json

@@ -7,19 +7,20 @@
     "url": "https://github.com/alexbosworth/paid-services/issues"
   },
   "dependencies": {
-    "async": "3.2.2",
-    "asyncjs-util": "1.2.7",
+    "async": "3.2.3",
+    "asyncjs-util": "1.2.8",
     "bolt01": "1.2.3",
-    "invoices": "2.0.2",
-    "ln-service": "53.2.0",
-    "ln-sync": "3.6.0"
+    "bolt07": "1.8.0",
+    "invoices": "2.0.3",
+    "ln-service": "53.4.0",
+    "ln-sync": "3.6.1"
   },
   "description": "Lightning Paid Services library",
   "devDependencies": {
     "@alexbosworth/tap": "15.0.10",
-    "ln-docker-daemons": "2.1.0",
+    "ln-docker-daemons": "2.2.0",
     "mock-lnd": "1.4.1",
-    "secp256k1": "4.0.2"
+    "secp256k1": "4.0.3"
   },
   "engines": {
     "node": ">=12.20"
@@ -37,7 +38,7 @@
   },
   "scripts": {
     "integration-tests": "tap --branches=1 --functions=1 --lines=1 --statements=1 -t 120 test/integration/*.js",
-    "test": "tap --branches=1 --functions=1 --lines=1 --statements=1 -t 60 test/actions/*.js test/capacity/*.js test/client/*.js test/config/*.js test/p2p/*.js test/records/*.js test/respond/*.js test/server/*.js test/server/*.js test/services/*.js"
+    "test": "tap --branches=1 --functions=1 --lines=1 --statements=1 -t 60 test/actions/*.js test/capacity/*.js test/client/*.js test/config/*.js test/p2p/*.js test/records/*.js test/respond/*.js test/server/*.js test/server/*.js test/services/*.js test/trades/*.js"
   },
-  "version": "3.3.0"
+  "version": "3.6.0"
 }

package/service_types.json

@@ -0,0 +1,16 @@
+{
+  "serviceTypeAcceptCapacityChange": "8050002",
+  "serviceTypeChangeCapacity": "8050001",
+  "serviceTypeReceiveTrades": "8050006",
+  "serviceTypeRequestTrades": "8050005",
+  "serviceTypeSignCapacityChange": "8050004",
+  "serviceTypeWaitOnConfirmation": "8050003",
+  "types": {
+    "8050001": "serviceTypeChangeCapacity",
+    "8050002": "serviceTypeAcceptCapacityChange",
+    "8050003": "serviceTypeWaitOnConfirmation",
+    "8050004": "serviceTypeSignCapacityChange",
+    "8050005": "serviceTypeRequestTrades",
+    "8050006": "serviceTypeReceiveTrades"
+  }
+}

package/services/response_for_relay.js

@@ -18,7 +18,6 @@ const defaultProbeTimeoutMs = 1000 * 60 * 5;
 const expiresAt = () => new Date(Date.now() + 1000 * 60 * 30).toISOString();
 const interval = 1000 * 60 * 10;
 const rateDivisor = BigInt(1e6);
-const sumOf = arr => arr.reduce((sum, n) => BigInt(n) + n, BigInt(0));
 const text = 'Relay payment request created';
 const times = 12;
 

package/test/capacity/test_capacity_change_requests.js

@@ -34,6 +34,7 @@ const tests = [
         from: Buffer.alloc(33, 3).toString('hex'),
         id: Buffer.alloc(32).toString('hex'),
         increase: undefined,
+        type: undefined,
       }],
     },
   },

package/test/capacity/test_encode_change_request.js

@@ -8,6 +8,7 @@ const makeArgs = overrides => {
     decrease: 0,
     id: Buffer.alloc(32).toString('hex'),
     increase: undefined,
+    type: 1,
   };
 
   Object.keys(overrides).forEach(k => args[k] = overrides[k]);
@@ -29,6 +30,10 @@ const tests = [
           type: '2',
           value: '0000000000000000',
         },
+        {
+          type: '5',
+          value: '01',
+        },
       ],
     },
   },

package/test/capacity/test_parse_capacity_change_request.js

@@ -31,6 +31,7 @@ const tests = [
         channel: '102x1x0',
         from: '0218819f4e0dbab6c6bc434913bace0b69f20d832f68934acd72fc610a9b76fe30',
         id: '2bf4a6bf1b97aff5bbb760f1aa7a5705c885194b4e29d42e5576498107f02361',
+        type: undefined,
       },
     },
   },

package/test/integration/test_accept_capacity_change.js

@@ -32,7 +32,6 @@ const maturity = 100;
 const proposeCapacityChange = propose;
 const signCapacityReplacement = method;
 const size = 2;
-const sumOf = arr => arr.reduce((sum, n) => sum + n, 0);
 const times = 2000;
 const {toOutputScript} = address;
 const weightAsVBytes = n => Math.ceil(n / 4);
@@ -111,9 +110,12 @@ test(`Accept capacity replacement`, async ({end, equal, strictSame}) => {
           transaction_id: channel.transaction_id,
           transaction_vout: channel.transaction_vout,
         });
+
+        proposeDone = true;
+
+        return;
       },
 
-      // Wait for a
       accept: async () => {
         await acceptCapacityChange({
           id,
@@ -123,25 +125,59 @@ test(`Accept capacity replacement`, async ({end, equal, strictSame}) => {
           lnd: target.lnd,
         });
       },
-    });
 
-    // Wait for the new channel to be active
-    const recreated = await asyncRetry({interval, times}, async () => {
-      const [channel] = (await getChannels({lnd, is_active: true})).channels;
+      confirmTarget: ['accept', async ({}) => {
+        // Wait for the new channel to be active
+        const recreated = await asyncRetry({interval, times}, async () => {
+          const controlChannels = (await getChannels({lnd, is_active: true}));
 
-      if (!!channel) {
-        return channel;
-      }
+          const [channel] = controlChannels.channels;
 
-      await generate({});
+          const targetChans = await getChannels({
+            is_active: true,
+            lnd: target.lnd,
+          });
 
-      throw new Error('ExpectedChannelActivation');
-    });
+          const targetChan = targetChans.channels;
+
+          if (!!channel && !!targetChan && channel.capacity < capacity) {
+            return channel;
+          }
 
-    strictSame(recreated.is_active, true, 'Recreated channel is active');
+          await generate({});
 
-    // Recreate the channel but in reverse roles
+          throw new Error('ExpectedChannelActivation');
+        });
+
+        strictSame(recreated.is_active, true, 'Recreated channel is active');
+      }],
+
+      confirmControl: ['accept', 'propose', async ({}) => {
+        // Wait for the new channel to be active
+        const recreated = await asyncRetry({interval, times}, async () => {
+          const controlChannels = (await getChannels({lnd, is_active: true}));
+
+          const [channel] = controlChannels.channels;
+
+          const targetChans = await getChannels({
+            is_active: true,
+            lnd: target.lnd,
+          });
+
+          const targetChan = targetChans.channels;
 
+          if (!!channel && !!targetChan && channel.capacity < capacity) {
+            return channel;
+          }
+
+          await generate({});
+
+          throw new Error('ExpectedChannelActivation');
+        });
+
+        strictSame(recreated.is_active, true, 'Recreated channel is active');
+      }],
+    });
   } catch (err) {
     strictSame(err, null, 'Expected no failure');
   } finally {

package/test/integration/test_change_channel_capacity.js

@@ -27,7 +27,6 @@ const log = () => {};
 const maturity = 100;
 const size = 2;
 const slow = 5000;
-const sumOf = arr => arr.reduce((sum, n) => sum + n, 0);
 const times = 2000;
 const {toOutputScript} = address;
 const weightAsVBytes = n => Math.ceil(n / 4);
@@ -49,6 +48,7 @@ test(`Accept capacity replacement`, async ({end, equal, strictSame}) => {
     // Open up a new channel
     const channelOpen = await openChannel({
       lnd,
+      is_private: true,
       local_tokens: capacity,
       partner_public_key: target.id,
       partner_socket: target.socket,
@@ -103,6 +103,10 @@ test(`Accept capacity replacement`, async ({end, equal, strictSame}) => {
               return cbk({query: target.id});
             }
 
+            if (args.name === 'type') {
+              return cbk({type: args.default});
+            }
+
             throw new Error('UnknownQueryNameForInitiator');
           },
           logger: {error: log, info: log},
@@ -159,6 +163,8 @@ test(`Accept capacity replacement`, async ({end, equal, strictSame}) => {
             throw new Error('ExpectedChannelActivation');
           }
 
+          equal(channel.is_private, true, 'Channel is private');
+
           {
             const {policies} = await getChannel({lnd, id: channel.id});