pagean 8.0.2 → 8.0.4

package/README.md

@@ -118,7 +118,8 @@ The broken link test checks for broken links on the page. It checks any `<a>` ta
 
 - For links within the page, this test checks for existence of the element on the page, passing if the element exists and failing otherwise (and passing for cases that are always valid, e.g. `#` or `#top` for the current page). It does not check the visibility of the element. Failing tests return a response of "#element Not Found" (where `#element` identifies the specific element).
 - For links to other pages, the test tries to most efficiently confirm whether the target link is valid. It first makes a `HEAD` request for that URL and checks the response. If an erroneous response is returned (>= 400 with no execution error) and not code 429 (Too Many Requests), the request is retried with a `GET` request. The test passes for HTTP responses < 400 and fails otherwise (if HTTP response is >= 400 or another error occurs).
-  - This can result in false failure indications, specifically for `file://` links (`404` or `ECONNREFUSED`) or where the browser passes a domain identity with the request (page loads when tested, but `401` response for links to that page). For these cases, or other false failures, the test configuration allows a boolean `checkWithBrowser` option that will instead check links by loading the target in the browser (via `puppeteer`). Note this can increase test execution time, in some cases substantially, due to the time to open a new browser tab and plus load the page and all assets.
+  - This can result in false failure indications, specifically for `file:` links (`404` or `ECONNREFUSED`) or where the browser passes a domain identity with the request (page loads when tested, but `401` response for links to that page). For these cases, or other false failures, the test configuration allows a boolean `checkWithBrowser` option that will instead check links by loading the target in the browser (via `puppeteer`). Note this can increase test execution time, in some cases substantially, due to the time to open a new browser tab and plus load the page and all assets.
+  - Note that `file:` links can only be tested with the `checkWithBrowser` option.
   - If the link to another page includes a hash it is removed prior to checking. The test in this case is confirming a valid link, not that the element exists, which is only done for the current page.
   - The test configuration allows an `ignoredLinks` array listing link URLs to ignore for this test. Note this only applies to links to other pages, not links within the page, which are always checked.
 - To optimize performance, link test results are cached and those links are not re-tested for the entire test run (across all tested URLs). The test configuration allows a boolean `ignoreDuplicates` option that can be set to `false` to bypass this behavior and re-test all links. The results for any failed links are included in the reports in any case.

package/lib/external-file-utils.js

@@ -21,9 +21,13 @@ const externalFilePath = 'pagean-external-scripts';
  * @static
  */
 const shouldSaveFile = (script, page) => {
+    const validProtocols = ['http:', 'https:'];
     const scriptUrl = new URL(script);
     const pageUrl = new URL(page);
-    return scriptUrl.host !== pageUrl.host;
+    return (
+        scriptUrl.host !== pageUrl.host &&
+        validProtocols.includes(scriptUrl.protocol)
+    );
 };
 
 /**

package/lib/link-utils.js

@@ -9,6 +9,7 @@
 const https = require('https');
 const axios = require('axios');
 const normalizeUrl = require('normalize-url');
+const cssesc = require('cssesc');
 
 const msPerSec = 1000;
 const timeoutSeconds = 120;
@@ -94,7 +95,11 @@ const checkSamePageLink = async (page, link) => {
         return httpResponse.ok;
     }
 
-    const element = await page.$(selector);
+    const escapedSelector = `#${cssesc(selector.slice(1), {
+        isIdentifier: true
+    })}`;
+    const element = await page.$(escapedSelector);
+    // const element = await page.$(selector);
     return element ? httpResponse.ok : `${selector} Not Found`;
 };
 
@@ -135,6 +140,10 @@ const checkExternalPageLinkBrowser = async (page, link) => {
  */
 // eslint-disable-next-line sonarjs/cognitive-complexity -- Allow less than 10
 const checkExternalPageLink = async (page, link, useGet = false) => {
+    if (link.startsWith('file:')) {
+        return 'Cannot check "file:" URLs';
+    }
+
     // Get user-agent from page so axios uses the same value for requesting links
     const userAgent = await page.evaluate('navigator.userAgent');
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pagean",
-  "version": "8.0.2",
+  "version": "8.0.4",
   "description": "Pagean is a web page analysis tool designed to automate tests requiring web pages to be loaded in a browser window (e.g. horizontal scrollbar, console errors)",
   "bin": {
     "pagean": "./bin/pagean.js",
@@ -18,12 +18,12 @@
     "prettier-fix": "prettier --write .",
     "start": "node ./bin/pagean.js",
     "start-lint": "node ./bin/pageanrc-lint.js",
-    "start-lint-all": "npm run start-lint && npm run start-lint -c static-server.pageanrc.json && npm run start-lint -c ./lib/default-config.json",
+    "start-lint-all": "npm run start-lint && npm run start-lint static-server.pageanrc.json && npm run start-lint ./lib/default-config.json",
     "test": "jest --ci --config jest.config.json"
   },
   "repository": {
     "type": "git",
-    "url": "git+https://gitlab.com/gitlab-ci-utils/pagean.git"
+    "url": "https://gitlab.com/gitlab-ci-utils/pagean.git"
   },
   "keywords": [
     "analysis",
@@ -51,28 +51,29 @@
   },
   "homepage": "https://gitlab.com/gitlab-ci-utils/pagean",
   "devDependencies": {
-    "@aarongoldenthal/eslint-config-standard": "^19.0.2",
-    "@aarongoldenthal/stylelint-config-standard": "^12.0.1",
-    "bin-tester": "^3.0.0",
-    "eslint": "^8.32.0",
-    "jest": "^29.3.1",
+    "@aarongoldenthal/eslint-config-standard": "^20.0.0",
+    "@aarongoldenthal/stylelint-config-standard": "^13.0.1",
+    "bin-tester": "^3.0.1",
+    "eslint": "^8.34.0",
+    "jest": "^29.4.3",
     "jest-junit": "^15.0.0",
     "markdownlint-cli": "^0.33.0",
-    "prettier": "^2.8.3",
+    "prettier": "^2.8.4",
     "strip-ansi": "^6.0.1",
-    "stylelint": "^14.16.1"
+    "stylelint": "^15.2.0"
   },
   "dependencies": {
     "ajv": "^8.12.0",
     "ajv-errors": "^3.0.0",
-    "axios": "^1.2.2",
-    "ci-logger": "^5.1.0",
+    "axios": "^1.3.3",
+    "ci-logger": "^5.1.1",
     "commander": "^10.0.0",
+    "cssesc": "^3.0.0",
     "handlebars": "^4.7.7",
     "htmlhint": "^1.1.4",
     "kleur": "^4.1.5",
     "normalize-url": "^6.1.0",
     "protocolify": "^3.0.0",
-    "puppeteer": "^19.5.2"
+    "puppeteer": "^19.7.1"
   }
 }