pagean 6.0.9 → 7.0.0

package/README.md

@@ -44,13 +44,11 @@ The console output test fails if any output is written to the browser console. A
 ```json
 [
   {
-    "_args": [],
-    "_location": {
-      "lineNumber": undefined,
+    "type": "error",
+    "text": "Failed to load resource: net::ERR_NAME_NOT_RESOLVED",
+    "location": {
       "url": "https://this.url.does.not.exist/file.js"
-    },
-    "_text": "Failed to load resource: net::ERR_NAME_NOT_RESOLVED",
-    "_type": "error"
+    }
   }
 ]
 ```

package/bin/pagean.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 'use strict';
 
-const { log, levels } = require('ci-logger');
+const { log, Levels } = require('ci-logger');
 const program = require('commander');
 const pagean = require('../index');
 const getConfig = require('../lib/config');
@@ -25,7 +25,7 @@ try {
 } catch (error) {
     log({
         message: `Error executing pagean tests\n${error.message}`,
-        level: levels.error,
+        level: Levels.Error,
         exitOnError: true,
         errorCode: 1
     });

package/bin/pageanrc-lint.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 'use strict';
 
-const { log, levels } = require('ci-logger');
+const { log, Levels } = require('ci-logger');
 const program = require('commander');
 const { green, underline } = require('kleur');
 const { lintConfigFile } = require('../lib/config');
@@ -19,7 +19,7 @@ program
 const options = program.opts();
 
 const logError = (message, exitOnError = true) => {
-    log({ message, level: levels.error, exitOnError, errorCode: 1 });
+    log({ message, level: Levels.Error, exitOnError, errorCode: 1 });
 };
 
 const outputJsonResults = (configFileName, lintResults) => {

package/index.js

@@ -29,15 +29,11 @@ const executeAllTests = async (config) => {
 
         const consoleLog = [];
         const page = await browser.newPage();
-        // Object property names defined by puppeteer API
         page.on('console', (message) =>
             consoleLog.push({
-                // eslint-disable-next-line no-underscore-dangle
-                _type: message._type,
-                // eslint-disable-next-line no-underscore-dangle
-                _text: message._text,
-                // eslint-disable-next-line no-underscore-dangle
-                _stackTraceLocations: message._stackTraceLocations
+                type: message.type(),
+                text: message.text(),
+                location: message.location()
             })
         );
         await page.goto(testUrl.url, { waitUntil: 'load' });

package/lib/link-utils.js

@@ -31,10 +31,10 @@ const httpResponse = Object.freeze({
 
 const noRetryResponses = new Set([httpResponse.tooManyRequests]);
 
-// eslint-disable-next-line jsdoc/require-description-complete-sentence
+/* eslint-disable jsdoc/require-description-complete-sentence */
 /**
- * Normalizes a URL with https://www.npmjs.com/package/normalize-url
- * using defaults plus the following overrides:
+ * Normalizes a URL (with https://www.npmjs.com/package/normalize-url).
+ * Uses defaults plus the following overrides.
  *  1. Set default protocol to https if protocol-relative
  *  2. Do not remove any querystring parameters
  *  3. Strip hash from URL
@@ -42,8 +42,8 @@ const noRetryResponses = new Set([httpResponse.tooManyRequests]);
  *
  * @public
  * @static
- * @param {string} url  The URL to normalize.
- * @returns {string}    The normalized URL.
+ * @param   {string} url  The URL to normalize.
+ * @returns {string}      The normalized URL.
  */
 const normalizeLink = (url) =>
     normalizeUrl(url, {
@@ -52,6 +52,7 @@ const normalizeLink = (url) =>
         stripHash: true,
         stripWWW: false
     });
+/* eslint-enable jsdoc/require-description-complete-sentence */
 
 /**
  * Checks settings to determine if the provided link should be ignored.

package/lib/tests.js

@@ -80,9 +80,7 @@ const consoleErrorTest = (context) => {
         // eslint-disable-next-line no-shadow -- less intuitive
         (context) => {
             const browserErrorLog = context.consoleLog.filter(
-                // Object property names defined by puppeteer API
-                // eslint-disable-next-line no-underscore-dangle
-                (log) => log._type === 'error'
+                (log) => log.type === 'error'
             );
             const testResult = {
                 result:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pagean",
-  "version": "6.0.9",
+  "version": "7.0.0",
   "description": "Pagean is a web page analysis tool designed to automate tests requiring web pages to be loaded in a browser window (e.g. horizontal scrollbar, console errors)",
   "bin": {
     "pagean": "./bin/pagean.js",
@@ -37,7 +37,7 @@
   "author": "Aaron Goldenthal <npm@aarongoldenthal.com>",
   "license": "MIT",
   "engines": {
-    "node": "^12.20.0 || ^14.15.0 || >=16.0.0"
+    "node": "^14.15.0 || ^16.13.0 || >=18.0.0"
   },
   "files": [
     "index.js",
@@ -51,28 +51,28 @@
   },
   "homepage": "https://gitlab.com/gitlab-ci-utils/pagean",
   "devDependencies": {
-    "@aarongoldenthal/eslint-config-standard": "^14.0.0",
-    "@aarongoldenthal/stylelint-config-standard": "^8.0.0",
+    "@aarongoldenthal/eslint-config-standard": "^15.0.0",
+    "@aarongoldenthal/stylelint-config-standard": "^9.0.0",
     "bin-tester": "^2.0.1",
-    "eslint": "^8.14.0",
-    "jest": "^28.0.2",
+    "eslint": "^8.17.0",
+    "jest": "^28.1.1",
     "jest-junit": "^13.2.0",
     "markdownlint-cli": "^0.31.1",
-    "prettier": "^2.6.2",
+    "prettier": "^2.7.0",
     "strip-ansi": "^6.0.1",
-    "stylelint": "^14.8.0"
+    "stylelint": "^14.9.1"
   },
   "dependencies": {
     "ajv": "^8.11.0",
     "ajv-errors": "^3.0.0",
     "axios": "^0.27.2",
-    "ci-logger": "^4.0.2",
-    "commander": "^9.2.0",
+    "ci-logger": "^5.0.0",
+    "commander": "^9.3.0",
     "handlebars": "^4.7.7",
     "htmlhint": "^1.1.4",
     "kleur": "^4.1.4",
     "normalize-url": "^6.1.0",
     "protocolify": "^3.0.0",
-    "puppeteer": "^13.6.0"
+    "puppeteer": "^14.4.0"
   }
 }