pagean 16.1.1 → 16.2.0

package/bin/pageanrc-lint.js

@@ -19,6 +19,7 @@ program
     .parse(process.argv);
 const options = program.opts();
 
+// eslint-disable-next-line unicorn/consistent-boolean-name -- follow package convention
 const logError = (message, exitOnError = true) => {
     log({ errorCode: 1, exitOnError, level: Levels.Error, message });
 };

package/index.js

@@ -87,6 +87,7 @@ const executeAllTests = async (config) => {
         const consoleLog = [];
         const page = await browser.newPage();
         page.on('console', (message) =>
+            // eslint-disable-next-line unicorn/no-return-array-push -- unused
             consoleLog.push({
                 location: message.location(),
                 text: message.text(),

package/lib/config.js

@@ -43,8 +43,8 @@ const processAllTestSettings = (settings) => {
         return;
     }
     const processedSettings = {};
-    for (const key of Object.keys(settings)) {
-        processedSettings[key] = processTestSetting(settings[key]);
+    for (const [key, value] of Object.entries(settings)) {
+        processedSettings[key] = processTestSetting(value);
     }
     /* eslint-disable-next-line consistent-return -- return undefined
        if no settings */
@@ -59,9 +59,9 @@ const consolidateTestSettings = (
     const sanitizedGlobalSettings = globalSettings || {};
     const sanitizedUrlSettings = urlSettings || {};
     const processedSettings = {};
-    for (const key of Object.keys(defaultSettings)) {
+    for (const [key, value] of Object.entries(defaultSettings)) {
         processedSettings[key] = {
-            ...defaultSettings[key],
+            ...value,
             ...sanitizedGlobalSettings[key],
             ...sanitizedUrlSettings[key]
         };
@@ -126,7 +126,8 @@ const validateConfigSchema = (config) => {
         // All values hardcoded.
         // nosemgrep: eslint.detect-non-literal-fs-filename
         fs.readFileSync(
-            path.join(__dirname, '..', 'schemas', 'pageanrc.schema.json')
+            path.join(__dirname, '..', 'schemas', 'pageanrc.schema.json'),
+            'utf8'
         )
     );
     // Allow allErrors to lint the entire config file, although users could

package/lib/link-utilities.js

@@ -126,18 +126,18 @@ const checkExternalPageLinkBrowser = async (page, link) => {
 };
 
 /**
- * Checks the provided link for validity by requesting with fetch. If useGet is false,
- * a HEAD request is made for efficiency. If useGet is true, a full GET request is made.
+ * Checks the provided link for validity by requesting with fetch. If shouldUseGet is false,
+ * a HEAD request is made for efficiency. If shouldUseGet is true, a full GET request is made.
  *
- * @param   {Page}                     page     A Puppeteer page object.
- * @param   {string}                   link     The link to check.
- * @param   {boolean}                  [useGet] Used to identify the request method to use (HEAD or GET).
- * @returns {Promise<(string|number)>}          The link status (HTTP response code or error).
+ * @param   {Page}                     page           A Puppeteer page object.
+ * @param   {string}                   link           The link to check.
+ * @param   {boolean}                  [shouldUseGet] Used to identify the request method to use (HEAD or GET).
+ * @returns {Promise<(string|number)>}                The link status (HTTP response code or error).
  * @static
  * @private
  */
 // eslint-disable-next-line complexity -- Allow low limit
-const checkExternalPageLink = async (page, link, useGet = false) => {
+const checkExternalPageLink = async (page, link, shouldUseGet = false) => {
     if (link.startsWith('file:')) {
         return 'Cannot check "file:" URLs';
     }
@@ -148,7 +148,7 @@ const checkExternalPageLink = async (page, link, useGet = false) => {
     try {
         const fetchOptions = {
             headers: { 'User-Agent': userAgent },
-            method: useGet ? 'GET' : 'HEAD',
+            method: shouldUseGet ? 'GET' : 'HEAD',
             signal: AbortSignal.timeout(timeoutSeconds * msPerSec)
         };
         // Using internal browser property since not exposed
@@ -165,7 +165,7 @@ const checkExternalPageLink = async (page, link, useGet = false) => {
         // that should skip a retry (e.g. 429), and the request was head then retry
         // with get.
         if (!response.ok) {
-            if (!noRetryResponses.has(response.status) && !useGet) {
+            if (!noRetryResponses.has(response.status) && !shouldUseGet) {
                 return checkExternalPageLink(page, link, true);
             }
             return response.status;

package/lib/logger.js

@@ -28,7 +28,7 @@ const nullFunction = () => {};
  * @static
  */
 // eslint-disable-next-line max-lines-per-function -- factory function with state
-const factory = (config) => {
+export default function factory(config) {
     const cliReporter = {
         // If cli reporter is enabled, set console log function, otherwise null function
         log: config.reporters.includes(reporterTypes.cli)
@@ -95,17 +95,19 @@ const factory = (config) => {
      * @param {object} testResult The test results object.
      */
     const logTestResults = (testResult) => {
-        if (testResult) {
-            currentUrlTests.tests.push(testResult);
-            testResults.summary.tests++;
-            testResults.summary[testResult.result]++;
-
-            cliReporter.log({
-                isResult: true,
-                message: `${testResult.name} (${testResult.result})`,
-                resultPrefix: testResultSymbols[testResult.result]
-            });
+        if (!testResult) {
+            return;
         }
+
+        currentUrlTests.tests.push(testResult);
+        testResults.summary.tests++;
+        testResults.summary[testResult.result]++;
+
+        cliReporter.log({
+            isResult: true,
+            message: `${testResult.name} (${testResult.result})`,
+            resultPrefix: testResultSymbols[testResult.result]
+        });
     };
 
     const outputTestSummary = () => {
@@ -132,6 +134,4 @@ const factory = (config) => {
         logTestResults,
         startUrlTests
     };
-};
-
-export default factory;
+}

package/lib/reporter.js

@@ -15,6 +15,7 @@ const htmlReportTemplateName = 'report-template.handlebars';
 const htmlReportFileName = './pagean-results.html';
 const jsonReportFileName = './pagean-results.json';
 
+// eslint-disable-next-line unicorn/no-top-level-side-effects -- package limitation
 handlebars.registerHelper('json', (context) =>
     // eslint-disable-next-line no-magic-numbers -- no-magic-numbers - count
     JSON.stringify(context, undefined, 2)

package/lib/sitemap.js

@@ -86,7 +86,7 @@ const replaceUrlStrings = (urls, find, replace) => {
     if (!find || !replace) {
         return urls;
     }
-    return urls.map((url) => url.replace(find, replace));
+    return urls.map((url) => url.replace(find, () => replace));
 };
 
 /**

package/lib/tests.js

@@ -156,7 +156,7 @@ const pageLoadTimeTest = async (context) => {
             const performanceTiming = JSON.parse(
                 await context.page.evaluate(() =>
                     /* v8 ignore next: executed in browser */
-                    JSON.stringify(globalThis.performance)
+                    JSON.stringify(performance)
                 )
             );
             const loadTimeSec =

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pagean",
-  "version": "16.1.1",
+  "version": "16.2.0",
   "description": "Pagean is a web page analysis tool designed to automate tests requiring web pages to be loaded in a browser window (e.g. horizontal scrollbar, console errors)",
   "bin": {
     "pagean": "bin/pagean.js",
@@ -56,17 +56,17 @@
   },
   "homepage": "https://gitlab.com/gitlab-ci-utils/pagean",
   "devDependencies": {
-    "@aarongoldenthal/eslint-config-standard": "46.0.3",
+    "@aarongoldenthal/eslint-config-standard": "47.0.0",
     "@aarongoldenthal/stylelint-config-standard": "24.0.0",
     "@vitest/coverage-v8": "4.1.9",
     "bin-tester": "8.0.0",
     "c8": "11.0.0",
-    "eslint": "10.5.0",
-    "globals": "17.6.0",
-    "markdownlint-cli2": "0.22.1",
+    "eslint": "10.6.0",
+    "globals": "17.7.0",
+    "markdownlint-cli2": "0.23.0",
     "nyc": "18.0.0",
-    "prettier": "3.8.4",
-    "stylelint": "17.13.0",
+    "prettier": "3.9.4",
+    "stylelint": "17.14.0",
     "vitest": "4.1.9"
   },
   "dependencies": {
@@ -79,7 +79,7 @@
     "htmlhint": "1.9.2",
     "normalize-url": "9.0.1",
     "protocolify": "4.0.0",
-    "puppeteer": "25.1.0",
+    "puppeteer": "25.3.0",
     "undici": "8.5.0",
     "xml2js": "0.6.2"
   }