page-foundry 3.2.1 → 3.4.0

package/skills/page-foundry/tests/run_audit_test.sh

@@ -21,6 +21,17 @@ assert_exit() {  # name expected dir extra...
   fi
 }
 
+assert_grep() {  # name mode(has|no) pattern dir
+  local name="$1" mode="$2" pattern="$3" dir="$4"
+  local out
+  out="$(python3 "$AUDIT" --mode build --archetype oss-project "$dir" 2>&1)"
+  if echo "$out" | grep -q "$pattern"; then
+    if [ "$mode" = has ]; then echo "  ok   $name"; else echo "  FAIL $name (unexpected match)"; fails=$((fails+1)); fi
+  else
+    if [ "$mode" = no ]; then echo "  ok   $name"; else echo "  FAIL $name (pattern not found)"; fails=$((fails+1)); fi
+  fi
+}
+
 bash "$BUILD" "$TMP/clean" "$AUDIT" >/dev/null
 assert_exit "A: complete valid run passes" 0 "$TMP/clean/.agents/foundry/demo"
 
@@ -87,6 +98,192 @@ open(p, "w").write(t)
 PY
 assert_exit "J: impeccable overridden -> DESIGN.md absence is advisory" 0 "$TMP/impoverride/.agents/foundry/demo"
 
+# K: the clean fixture declares both taste inputs -> no taste WARN (#41).
+assert_grep "K: complete taste inputs -> no taste warning" no "taste input missing" "$TMP/clean/.agents/foundry/demo"
+
+# L: voice default + design-reference none, no override -> both taste WARNs, still exit 0 (honest PARTIAL).
+cp -r "$TMP/clean" "$TMP/notaste"
+D="$TMP/notaste/.agents/foundry/demo"
+python3 - "$D/preflight.md" <<'PY'
+import sys
+p = sys.argv[1]; t = open(p).read()
+t = t.replace("voice: configured", "voice: default")
+t = t.replace("design-reference: supplied: a real terminal instrument panel the owner named",
+              "design-reference: none")
+open(p, "w").write(t)
+PY
+assert_exit "L: missing taste inputs is PARTIAL, not a hard fail" 0 "$D"
+assert_grep "L: missing voice input warns" has "voice taste input missing" "$D"
+assert_grep "L: missing design reference warns" has "design reference missing" "$D"
+
+# M: same absence but named on the override line -> waived, no taste WARN.
+cp -r "$TMP/notaste" "$TMP/tasteoverride"
+D="$TMP/tasteoverride/.agents/foundry/demo"
+python3 - "$D/preflight.md" <<'PY'
+import sys
+p = sys.argv[1]; t = open(p).read()
+open(p, "w").write(t.replace("override: none", "override: voice, design-reference"))
+PY
+assert_grep "M: overridden taste inputs -> no warning" no "taste input missing" "$D"
+assert_grep "M: overridden design reference -> no warning" no "design reference missing" "$D"
+
+# N: humanizer.md present but diff-less (backfill prose) -> FAIL (#42 tier 2).
+cp -r "$TMP/clean" "$TMP/nodiff"
+D="$TMP/nodiff/.agents/foundry/demo"
+printf '# Humanizer pass\nThe humanizer pass ran over the approved draft in full.\nThe copy reads clean and human throughout the page.\nNothing stood out as an AI tell on this read.\nNo further notes; it looks good and is ready to ship.\n' > "$D/copy/humanizer.md"
+assert_exit "N: diff-less humanizer.md fails (proves it ran)" 1 "$D"
+assert_grep "N: diff-less humanizer names the reason" has "before/after diffs" "$D"
+
+# O: red-team.md missing -> FAIL; present but no walks -> FAIL (#42 tier 2).
+cp -r "$TMP/clean" "$TMP/nort"
+rm "$TMP/nort/.agents/foundry/demo/red-team.md"
+assert_exit "O: missing red-team.md fails" 1 "$TMP/nort/.agents/foundry/demo"
+cp -r "$TMP/clean" "$TMP/thinrt"
+D="$TMP/thinrt/.agents/foundry/demo"
+printf '# Red team\nThe page was reviewed against a few readers and it holds up well overall here.\n' > "$D/red-team.md"
+assert_exit "O: walk-less red-team.md fails" 1 "$D"
+
+# P: detect-scan.json missing (impeccable core) -> FAIL; overridden -> advisory.
+cp -r "$TMP/clean" "$TMP/noscan"
+rm "$TMP/noscan/.impeccable/detect-scan.json"
+assert_exit "P: missing detect-scan.json (impeccable core) fails" 1 "$TMP/noscan/.agents/foundry/demo"
+assert_grep "P: missing detect scan names Gate 5 persistence" has "detect.mjs --json output" "$TMP/noscan/.agents/foundry/demo"
+cp -r "$TMP/noscan" "$TMP/scanoverride"
+python3 - "$TMP/scanoverride/.agents/foundry/demo/preflight.md" <<'PY'
+import sys
+p = sys.argv[1]; t = open(p).read()
+t = t.replace("| impeccable | core | present | npx impeccable |",
+              "| impeccable | core | missing | — |")
+t = t.replace("override: none", "override: impeccable")
+open(p, "w").write(t)
+PY
+rm -f "$TMP/scanoverride/DESIGN.md"
+assert_exit "P: impeccable overridden -> detect-scan absence advisory" 0 "$TMP/scanoverride/.agents/foundry/demo"
+
+# Q: the un-fakeable teeth -- shipped copy carries a banned word -> fresh re-run FAILs (#42 tier 1).
+cp -r "$TMP/clean" "$TMP/badvoice"
+D="$TMP/badvoice/.agents/foundry/demo"
+python3 - "$D/copy/copy-approved.md" <<'PY'
+import sys
+p = sys.argv[1]; t = open(p).read()
+open(p, "w").write(t.replace("nobody can tell what it does.",
+                             "nobody can tell what this robust platform does."))
+PY
+assert_exit "Q: copy that fails a fresh voice scan fails Gate 0" 1 "$D"
+assert_grep "Q: voice re-run names the failure" has "fresh voice scan" "$D"
+
+# R: detect-scan.json present but malformed JSON -> FAIL (#42 tier 1 shape check).
+cp -r "$TMP/clean" "$TMP/badscan"
+printf 'not json at all {[' > "$TMP/badscan/.impeccable/detect-scan.json"
+assert_exit "R: malformed detect-scan.json fails" 1 "$TMP/badscan/.agents/foundry/demo"
+
+# S: taste-judge.md missing -> FAIL (#44, required in build/explore).
+cp -r "$TMP/clean" "$TMP/notaste_judge"
+rm "$TMP/notaste_judge/.agents/foundry/demo/taste-judge.md"
+assert_exit "S: missing taste-judge.md fails" 1 "$TMP/notaste_judge/.agents/foundry/demo"
+
+# T: taste-judge.md with neither a verdict+tells nor the honest no-judge clause -> FAIL;
+# the honest "no independent judge available" clause -> PASS (do not fake independence).
+cp -r "$TMP/clean" "$TMP/emptyjudge"
+D="$TMP/emptyjudge/.agents/foundry/demo"
+printf '# Taste judge\nThe page was looked over and it seems fine and pretty good overall to me.\nNothing much else to add here on the design.\nLooks acceptable.\n' > "$D/taste-judge.md"
+assert_exit "T: taste-judge without verdict+tells fails" 1 "$D"
+cp -r "$TMP/clean" "$TMP/nojudge"
+D="$TMP/nojudge/.agents/foundry/demo"
+printf '# Taste judge\nNo cross-family judge was available this run and no human review either.\nIndependence was not possible; recorded honestly rather than faked.\nRe-run with a codex/GPT judge or a human when one is reachable.\n' > "$D/taste-judge.md"
+assert_exit "T: honest no-judge clause passes (independence not faked)" 0 "$D"
+
+# U: mechanics-heavy copy -> soft WARN, still exit 0 (#45); mechanics-as-value:yes silences it.
+cp -r "$TMP/clean" "$TMP/mech"
+D="$TMP/mech/.agents/foundry/demo"
+python3 - "$D/copy/copy-approved.md" <<'PY'
+import sys
+p = sys.argv[1]; t = open(p).read()
+t += "\nEvery page clears the gates before it leaves the shop.\n"
+t += "The pipeline runs every phase and the spec comes first.\n"
+open(p, "w").write(t)
+PY
+assert_exit "U: mechanics-heavy copy is a soft WARN, not a fail" 0 "$D"
+assert_grep "U: mechanics framing warns" has "process/mechanics references" "$D"
+cp -r "$TMP/mech" "$TMP/mechvalue"
+D="$TMP/mechvalue/.agents/foundry/demo"
+printf '# Design strategy\nmechanics-as-value: yes\nThis product IS its mechanics (a gated pipeline); selling the gates is correct here.\n' > "$D/design-strategy.md"
+assert_grep "U: mechanics-as-value:yes silences the warn" no "process/mechanics references" "$D"
+
+# V: design-strategy.md missing -> FAIL (#46, default-on); declined on the override line -> advisory.
+cp -r "$TMP/clean" "$TMP/nostrat"
+rm "$TMP/nostrat/.agents/foundry/demo/design-strategy.md"
+assert_exit "V: missing design-strategy.md fails" 1 "$TMP/nostrat/.agents/foundry/demo"
+cp -r "$TMP/nostrat" "$TMP/stratoverride"
+python3 - "$TMP/stratoverride/.agents/foundry/demo/preflight.md" <<'PY'
+import sys
+p = sys.argv[1]; t = open(p).read()
+open(p, "w").write(t.replace("override: none", "override: design-strategy"))
+PY
+assert_exit "V: design-strategy declined at preflight -> advisory" 0 "$TMP/stratoverride/.agents/foundry/demo"
+
+# W: design-strategy.md that skips the mechanics decision / grounding / kill-list -> FAIL (#46).
+cp -r "$TMP/clean" "$TMP/thinstrat"
+D="$TMP/thinstrat/.agents/foundry/demo"
+printf '# Design strategy\nWe will make it look modern and clean and nice.\nSome ideas about fonts and colors go here.\nWe think it will be good and appropriate for the product.\nIt should feel premium and trustworthy to visitors overall.\n' > "$D/design-strategy.md"
+assert_exit "W: design-strategy without decision/grounding/kill-list fails" 1 "$D"
+assert_grep "W: names the missing mechanics decision" has "mechanics-as-value" "$D"
+
+# X: taste judge verdict FLAT on an axis, no accept -> blocking FAIL (#48).
+cp -r "$TMP/clean" "$TMP/flatjudge"
+D="$TMP/flatjudge/.agents/foundry/demo"
+python3 - "$D/taste-judge.md" <<'PY'
+import sys
+p=sys.argv[1]; t=open(p).read()
+open(p,"w").write(t.replace("visual-engagement: engaged","visual-engagement: flat"))
+PY
+assert_exit "X: taste judge flat verdict is a blocking fail" 1 "$D"
+assert_grep "X: names the blocking axis" has "blocking Gate 5 failure" "$D"
+# X2: same flat verdict, operator accepted in chat -> waived, passes.
+cp -r "$TMP/flatjudge" "$TMP/flataccepted"
+D="$TMP/flataccepted/.agents/foundry/demo"
+printf '\naccepted: operator shipping the flat draft knowingly for a first cut\n' >> "$D/taste-judge.md"
+assert_exit "X2: accepted flat verdict passes" 0 "$D"
+# CC: copy-craft.md missing -> FAIL; present but weak (only 1 dimension) -> FAIL (#51).
+cp -r "$TMP/clean" "$TMP/nocc"
+rm "$TMP/nocc/.agents/foundry/demo/copy-craft.md"
+assert_exit "CC: missing copy-craft.md fails" 1 "$TMP/nocc/.agents/foundry/demo"
+cp -r "$TMP/clean" "$TMP/weakcc"
+D="$TMP/weakcc/.agents/foundry/demo"
+printf '# Copy craft\nThe copy is clean and reads fine and is fairly good overall on the page.\nNothing much else to note here about it.\nIt seems acceptable to ship.\n' > "$D/copy-craft.md"
+assert_exit "CC: copy-craft with <3 dimensions fails" 1 "$D"
+assert_grep "CC: names voice-compelling gap" has "voice-compelling" "$D"
+
+# Z: conversion audit with no reading-experience assessment -> FAIL (#50).
+cp -r "$TMP/clean" "$TMP/noread"
+D="$TMP/noread/.agents/foundry/demo"
+python3 - "$D/conversion-audit.md" <<'PY'
+import sys
+p=sys.argv[1]; t=open(p).read()
+# strip the reading-experience paragraph
+t="\n".join(l for l in t.splitlines() if "Reading experience" not in l and "Scannability" not in l and "scans the rendered" not in l and "reading friction" not in l)
+open(p,"w").write(t)
+PY
+assert_exit "Z: conversion audit without reading-experience fails" 1 "$D"
+assert_grep "Z: names the reading-experience gap" has "reading-experience assessment" "$D"
+
+# Y: imagery-plan declares image-light with no engagement mechanism -> FAIL (#49 loophole).
+cp -r "$TMP/clean" "$TMP/flatimg"
+D="$TMP/flatimg/.agents/foundry/demo"
+printf '# Imagery plan\nConsistency: cool grade, 16:9.\n- hero: real product screenshot.\n- everything else: no image by choice, text-only throughout the page.\nNo product screenshot is a mockup.\n' > "$D/imagery-plan.md"
+assert_exit "Y: image-light with no engagement mechanism fails" 1 "$D"
+assert_grep "Y: names the loophole" has "not a free pass" "$D"
+
+# X3: missing an axis verdict line -> FAIL (not judged on that axis).
+cp -r "$TMP/clean" "$TMP/noaxis"
+D="$TMP/noaxis/.agents/foundry/demo"
+python3 - "$D/taste-judge.md" <<'PY'
+import sys
+p=sys.argv[1]; t=open(p).read()
+open(p,"w").write(t.replace("property-specificity: specific","(property axis omitted)"))
+PY
+assert_exit "X3: missing property-specificity axis fails" 1 "$D"
+
 echo ""
 if [ "$fails" -eq 0 ]; then echo "run_audit calibration: all fixtures pass"; else echo "run_audit calibration: $fails FAILED"; fi
 exit $fails