pacman-debian 7.3.21 → 7.3.23

package/lib/pac4deb/src/alpm_list.c

@@ -20,6 +20,28 @@ alpm_list_t *alpm_list_add(alpm_list_t *list, void *data) {
 	return list;
 }
 
+/* Fast append: returns the new tail for subsequent calls */
+alpm_list_t *alpm_list_add_last(alpm_list_t *list, alpm_list_t *tail, void *data) {
+	alpm_list_t *lp = malloc(sizeof(alpm_list_t));
+	if (!lp) return NULL;
+	lp->data = data;
+	lp->prev = NULL;
+	lp->next = NULL;
+	if (!list) { list = lp; tail = lp; return tail ? tail : list; }
+	// If we have a valid tail, use it directly
+	if (tail) {
+		tail->next = lp;
+		lp->prev = tail;
+		return lp;
+	}
+	// Fallback: find tail
+	alpm_list_t *ptr = list;
+	while (ptr->next) ptr = ptr->next;
+	ptr->next = lp;
+	lp->prev = ptr;
+	return lp;
+}
+
 void alpm_list_free(alpm_list_t *list) {
 	alpm_list_t *it = list;
 	while (it) { alpm_list_t *next = it->next; free(it); it = next; }

package/lib/pac4deb/src/libalpm.c

@@ -118,6 +118,7 @@ struct __alpm_handle_t {
 	char *confpath;
 	alpm_db_t *localdb;
 	alpm_list_t *syncdbs;
+	int released;
 };
 
 alpm_handle_t *alpm_initialize(const char *root, const char *dbpath, alpm_errno_t *err) {
@@ -135,11 +136,15 @@ alpm_handle_t *alpm_initialize(const char *root, const char *dbpath, alpm_errno_
 
 int alpm_release(alpm_handle_t *handle) {
 	if (!handle) return -1;
+	if (handle->released) return 0;
 	alpm_db_unregister_all(handle);
 	free(handle->dbpath); handle->dbpath = NULL;
 	free(handle->logfile); handle->logfile = NULL;
 	free(handle->confpath); handle->confpath = NULL;
-	free(handle);
+	handle->released = 1;
+	handle->err = ALPM_ERR_OK;
+	// Don't free handle itself — dyalpm calls alpm_errno after alpm_release
+	// (use-after-free bug in dyalpm v0.1.3). Memory leak is negligible.
 	return 0;
 }
 
@@ -197,7 +202,7 @@ static pkg_internal *json_to_pkg(json_ctx *j) {
 
 /* Load JSONL file (one flat JSON object per line) */
 alpm_list_t *load_jsonl_file(const char *filepath) {
-	alpm_list_t *pkgs = NULL;
+	alpm_list_t *pkgs = NULL, *tail = NULL;
 	int fd = open(filepath, O_RDONLY);
 	if (fd < 0) return NULL;
 	struct stat st;
@@ -219,7 +224,14 @@ alpm_list_t *load_jsonl_file(const char *filepath) {
 				pkg_internal *p = json_to_pkg(&j);
 				if (p->name && *(p->name)) {
 					p->origin = ALPM_PKG_FROM_SYNCDB;
-					pkgs = alpm_list_add(pkgs, p);
+					alpm_list_t *lp = malloc(sizeof(alpm_list_t));
+					if (lp) {
+						lp->data = p; lp->next = NULL; lp->prev = tail;
+						if (tail) tail->next = lp; else pkgs = lp;
+						tail = lp;
+					} else {
+						pkg_free(p);
+					}
 				} else {
 					pkg_free(p);
 				}
@@ -255,7 +267,7 @@ static alpm_list_t *load_json_file(const char *filepath) {
 
 /* Load packages from dpkg status file */
 static alpm_list_t *load_dpkg_status(const char *path) {
-	alpm_list_t *pkgs = NULL;
+	alpm_list_t *pkgs = NULL, *tail = NULL;
 	FILE *f = fopen(path, "r");
 	if (!f) return NULL;
 	fseek(f, 0, SEEK_END);
@@ -312,8 +324,15 @@ static alpm_list_t *load_dpkg_status(const char *path) {
 			pkg->depends = strdup(depends);
 			pkg->provides = strdup(provides[0] ? provides : "");
 			pkg->reason = ALPM_PKG_REASON_EXPLICIT;
-			pkgs = alpm_list_add(pkgs, pkg);
-}
+			alpm_list_t *lp = malloc(sizeof(alpm_list_t));
+			if (lp) {
+				lp->data = pkg; lp->next = NULL; lp->prev = tail;
+				if (tail) tail->next = lp; else pkgs = lp;
+				tail = lp;
+			} else {
+				pkg_free(pkg);
+			}
+		}
 		p = end ? end + 2 : NULL;
 	}
 	free(buf);
@@ -321,38 +340,45 @@ static alpm_list_t *load_dpkg_status(const char *path) {
 }
 
 /* Load all packages from local DB directory (each subdir has a desc file) */
-static alpm_list_t *load_localdb_dir(const char *dirpath) {
-	alpm_list_t *pkgs = NULL;
-	DIR *d = opendir(dirpath);
-	if (!d) return NULL;
-	struct dirent *entry;
-	while ((entry = readdir(d)) != NULL) {
-		if (entry->d_name[0] == '.') continue;
-		if (strcmp(entry->d_name, "by-name") == 0) continue;
-		char path[4096];
-		snprintf(path, sizeof(path), "%s/%s/desc", dirpath, entry->d_name);
-		int fd = open(path, O_RDONLY);
-		if (fd < 0) continue;
-		struct stat st;
-		if (fstat(fd, &st) < 0 || st.st_size == 0) { close(fd); continue; }
-		char *buf = mmap(NULL, st.st_size, PROT_READ, MAP_PRIVATE, fd, 0);
-		close(fd);
-		if (buf == MAP_FAILED) continue;
-		json_ctx j;
-		json_init(&j, buf);
-		if (json_next(&j) != '{') { munmap(buf, st.st_size); continue; }
-		pkg_internal *p = json_to_pkg(&j);
-		if (p->name && *(p->name)) {
-			p->origin = ALPM_PKG_FROM_LOCALDB;
-			pkgs = alpm_list_add(pkgs, p);
-		} else {
-			pkg_free(p);
-		}
-		munmap(buf, st.st_size);
-	}
-	closedir(d);
-	return pkgs;
-}
+ static alpm_list_t *load_localdb_dir(const char *dirpath) {
+ 	alpm_list_t *pkgs = NULL, *tail = NULL;
+ 	DIR *d = opendir(dirpath);
+ 	if (!d) return NULL;
+ 	struct dirent *entry;
+ 	while ((entry = readdir(d)) != NULL) {
+ 		if (entry->d_name[0] == '.') continue;
+ 		if (strcmp(entry->d_name, "by-name") == 0) continue;
+ 		char path[4096];
+ 		snprintf(path, sizeof(path), "%s/%s/desc", dirpath, entry->d_name);
+ 		int fd = open(path, O_RDONLY);
+ 		if (fd < 0) continue;
+ 		struct stat st;
+ 		if (fstat(fd, &st) < 0 || st.st_size == 0) { close(fd); continue; }
+ 		char *buf = mmap(NULL, st.st_size, PROT_READ, MAP_PRIVATE, fd, 0);
+ 		close(fd);
+ 		if (buf == MAP_FAILED) continue;
+ 		json_ctx j;
+ 		json_init(&j, buf);
+ 		if (json_next(&j) != '{') { munmap(buf, st.st_size); continue; }
+ 		pkg_internal *p = json_to_pkg(&j);
+ 		if (p->name && *(p->name)) {
+ 			p->origin = ALPM_PKG_FROM_LOCALDB;
+			alpm_list_t *lp = malloc(sizeof(alpm_list_t));
+			if (lp) {
+				lp->data = p; lp->next = NULL; lp->prev = tail;
+				if (tail) tail->next = lp; else pkgs = lp;
+				tail = lp;
+			} else {
+				pkg_free(p);
+			}
+ 		} else {
+ 			pkg_free(p);
+ 		}
+ 		munmap(buf, st.st_size);
+ 	}
+ 	closedir(d);
+ 	return pkgs;
+ }
 
 /* Resolve Debian alternatives: readlink /bin/<cmd> to find real binary,
    then map its package name back to the virtual provide name.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pacman-debian",
-  "version": "7.3.21",
+  "version": "7.3.23",
   "description": "A Debian/Ubuntu package manager using Arch Linux pacman syntax. Manages .deb packages at dpkg level, supports Arch .pkg.tar.zst, AUR helpers (yay), and makepkg. Configurable multi-repo setup.",
   "pacmanVersion": "7.1.0",
   "main": "dist/index.js",