package-build-stats 7.3.8 → 8.0.0-beta.3

package/src/getPackageExportSizes.ts

@@ -3,7 +3,11 @@ import { performance } from 'perf_hooks'
 
 const debug = require('debug')('bp:worker')
 
-import { getExternals, parsePackageString } from './utils/common.utils'
+import {
+  getExternals,
+  parsePackageString,
+  updateProjectEntries,
+} from './utils/common.utils'
 import { getAllExports } from './utils/exports.utils'
 import InstallationUtils from './utils/installation.utils'
 import BuildUtils from './utils/build.utils'
@@ -50,6 +54,11 @@ export async function getAllPackageExports(
   }
 }
 
+export async function getExportSize(
+  packageString: string,
+  exportName: string
+) {}
+
 export async function getPackageExportSizes(
   packageString: string,
   options: GetPackageStatsOptions = {
@@ -60,6 +69,10 @@ export async function getPackageExportSizes(
   const { name: packageName, normalPath } = parsePackageString(packageString)
   const installPath = await InstallationUtils.preparePath(packageName)
 
+  if (options.debug) {
+    console.log('Install path:', installPath)
+  }
+
   try {
     await installPackage(packageString, installPath, options)
 
@@ -70,28 +83,34 @@ export async function getPackageExportSizes(
     )
 
     const exports = Object.keys(exportMap).filter(exp => !(exp === 'default'))
-    debug('Got %d exports for %s', exports.length, packageString)
+    debug('Got %d  exports for %s', exports.length, packageString)
 
     const externals = getExternals(packageName, installPath)
 
-    const builtDetails = await BuildUtils.buildPackageIgnoringMissingDeps({
-      name: packageName,
-      installPath,
-      externals,
-      options: {
-        customImports: exports,
-        splitCustomImports: true,
-        includeDependencySizes: false,
-        minifier: options.minifier || 'terser',
+    await updateProjectEntries(installPath, exportMap)
+
+    const builtDetails = await BuildUtils.buildPackageIgnoringMissingDeps(
+      {
+        name: packageName,
+        installPath,
+        externals,
+        options: {
+          customImports: exports,
+          splitCustomImports: true,
+          includeDependencySizes: false,
+          minifier: options.minifier || 'terser',
+        },
       },
-    })
+      0
+    )
 
     Telemetry.packageExportsSizes(packageString, startTime, true, options)
     return {
       ...builtDetails,
-      assets: builtDetails.assets.map(asset => ({
+      buildVersion: require('../package.json').version,
+      assets: builtDetails?.assets?.map(asset => ({
         ...asset,
-        path: exportMap[asset.name],
+        path: exportMap[asset?.name],
       })),
     }
   } catch (err) {

package/src/getPackageStats.ts

@@ -3,12 +3,13 @@
  * @see https://github.com/wix/import-cost/blob/master/packages/import-cost/src/webpack.js
  */
 
+const log = require('debug')('bp:package-stats')
 import { promises as fs } from 'fs'
 import path from 'path'
 import { getExternals, parsePackageString } from './utils/common.utils'
 import InstallationUtils from './utils/installation.utils'
 import BuildUtils from './utils/build.utils'
-import { UnexpectedBuildError } from './errors/CustomError'
+import { BuildError, UnexpectedBuildError } from './errors/CustomError'
 import { GetPackageStatsOptions } from './common.types'
 import Telemetry from './utils/telemetry.utils'
 import { performance } from 'perf_hooks'
@@ -31,6 +32,12 @@ function getPackageJSONDetails(packageName: string, installPath: string) {
           'dependencies' in parsedJSON
             ? Object.keys(parsedJSON.dependencies).length
             : 0,
+        mainFields: [
+          parsedJSON['module'] && 'module',
+          parsedJSON['jsnext:main'] && 'jsnext:main',
+          parsedJSON['main'] && 'main',
+          parsedJSON['style'] && 'style',
+        ].filter(Boolean),
         hasJSNext: parsedJSON['jsnext:main'] || false,
         hasJSModule: parsedJSON['module'] || false,
         isModuleType: parsedJSON['type'] === 'module',
@@ -76,25 +83,56 @@ export default async function getPackageStats(
     })
 
     const externals = getExternals(packageName, installPath)
-    const [pacakgeJSONDetails, builtDetails] = await Promise.all([
+    const [packageJSONDetails, builtDetails] = await Promise.all([
       getPackageJSONDetails(packageName, installPath),
-      BuildUtils.buildPackageIgnoringMissingDeps({
-        name: packageName,
-        installPath,
-        externals,
-        options: {
-          debug: options.debug,
-          customImports: options.customImports,
-          minifier: options.minifier,
-          includeDependencySizes: true,
+      BuildUtils.buildPackageIgnoringMissingDeps(
+        {
+          name: packageName,
+          installPath,
+          externals,
+          options: {
+            debug: options.debug,
+            customImports: options.customImports,
+            minifier: options.minifier,
+            includeDependencySizes: true,
+          },
         },
-      }),
+        0
+      ),
     ])
 
-    const hasCSSAsset = builtDetails.assets.some(asset => asset.type === 'css')
-    const mainAsset = builtDetails.assets.find(
+    if (!packageJSONDetails) {
+      throw new UnexpectedBuildError(
+        `Could not get package.json details for ${packageName}`
+      )
+    }
+
+    if (!builtDetails) {
+      throw new BuildError(`Could not get built details for ${packageName}`)
+    }
+
+    const isStylePackageOnly =
+      packageJSONDetails.mainFields.length === 1 &&
+      packageJSONDetails.mainFields[0] === 'style'
+    if (isStylePackageOnly) {
+      builtDetails.assets = builtDetails.assets?.filter(
+        asset => asset?.type !== 'js'
+      )
+    }
+
+    log(
+      'builtDetails are %o %o',
+      builtDetails.assets,
+      // @ts-ignore
+      builtDetails.dependencySizes
+    )
+    const hasCSSAsset = builtDetails.assets?.some(
+      asset => asset?.type === 'css'
+    )
+
+    const mainAsset = builtDetails.assets?.find(
       asset =>
-        asset.name === 'main' && asset.type === (hasCSSAsset ? 'css' : 'js')
+        asset?.name === 'index' && asset?.type === (hasCSSAsset ? 'css' : 'js')
     )
 
     if (!mainAsset) {
@@ -110,8 +148,9 @@ export default async function getPackageStats(
       options
     )
     return {
-      ...pacakgeJSONDetails,
+      ...packageJSONDetails,
       ...builtDetails,
+      buildVersion: require('../package.json').version,
       size: mainAsset.size,
       gzip: mainAsset.gzip,
       parse: mainAsset.parse,

package/src/typings/is-valid-npm-name.d.ts

@@ -0,0 +1,3 @@
+declare module 'is-valid-npm-name' {
+  export default function (str: string): boolean
+}