pacc 4.37.2 → 4.37.4

package/README.md

@@ -48,6 +48,7 @@ const result = getAttribute({ a: [0,{ b: 4 }]}, "a[1].b");
 *   [email\_attribute](#email_attribute)
 *   [version\_attribute\_writable](#version_attribute_writable)
 *   [description\_attribute](#description_attribute)
+*   [boolean\_attribute](#boolean_attribute)
 *   [boolean\_attribute\_writable](#boolean_attribute_writable)
 *   [boolean\_attribute\_writable\_true](#boolean_attribute_writable_true)
 *   [boolean\_attribute\_writable\_true](#boolean_attribute_writable_true-1)
@@ -71,11 +72,11 @@ const result = getAttribute({ a: [0,{ b: 4 }]}, "a[1].b");
 *   [integer\_attribute\_writable](#integer_attribute_writable)
 *   [object\_attribute](#object_attribute)
 *   [url\_attribute](#url_attribute)
-*   [url\_attribute\_writble](#url_attribute_writble)
+*   [url\_attribute\_writable](#url_attribute_writable)
 *   [hostname\_attribute](#hostname_attribute)
 *   [port\_attribute](#port_attribute)
 *   [id\_attribute](#id_attribute)
-*   [title\_attribute](#title_attribute)
+*   [title\_attribute\_writable](#title_attribute_writable)
 *   [priority\_attribute](#priority_attribute)
 *   [timeout\_attribute](#timeout_attribute)
 *   [language\_attribute](#language_attribute)
@@ -174,7 +175,7 @@ Type: [Object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Globa
 
 ### Properties
 
-*   `type` **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 
+*   `type` **[object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Object)** 
 *   `isKey` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)** 
 *   `writable` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)** 
 *   `mandatory` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)** 
@@ -249,6 +250,10 @@ The description of the object content.
 
 Type: [AttributeDefinition](#attributedefinition)
 
+## boolean\_attribute
+
+Type: [AttributeDefinition](#attributedefinition)
+
 ## boolean\_attribute\_writable
 
 Type: [AttributeDefinition](#attributedefinition)
@@ -341,7 +346,7 @@ Type: [AttributeDefinition](#attributedefinition)
 
 Type: [AttributeDefinition](#attributedefinition)
 
-## url\_attribute\_writble
+## url\_attribute\_writable
 
 Type: [AttributeDefinition](#attributedefinition)
 
@@ -359,7 +364,7 @@ Unique id within.
 
 Type: [AttributeDefinition](#attributedefinition)
 
-## title\_attribute
+## title\_attribute\_writable
 
 The one line description.
 
@@ -448,6 +453,7 @@ Retrive attribute values from an object.
 
 *   `object` **[Object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Object)** attribute value source
 *   `definitions` **[Object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Object)** 
+*   `filter` **[Object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Object)** 
 
 Returns **[Object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Object)** values
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pacc",
-  "version": "4.37.2",
+  "version": "4.37.4",
   "publishConfig": {
     "access": "public",
     "provenance": true

package/src/attributes.mjs

@@ -55,7 +55,7 @@ export function* attributeIterator(definition, filter, path = []) {
   if (definition) {
     for (const [name, def] of Object.entries(definition)) {
       const path2 = [...path, name];
-      if (!filter || filter(name, def)) {
+      if (typeof filter !== 'function' || filter(name, def)) {
         yield [path2, def];
       }
 

package/src/properties.mjs

@@ -2,6 +2,15 @@ import { attributeIterator } from "./attributes.mjs";
 import { getAttribute, setAttribute } from "./settergetter.mjs";
 import { prepareValue } from "./attributes.mjs";
 
+function findPropertyDescriptor(obj, name) {
+  let descriptor;
+  do {
+    (descriptor = Object.getOwnPropertyDescriptor(obj, name)) ||
+      (obj = Object.getPrototypeOf(obj));
+  } while (!descriptor && obj);
+  return descriptor;
+}
+
 export function definePropertiesFromAttributes(
   object,
   attributes,
@@ -21,19 +30,19 @@ export function definePropertiesFromAttributes(
 
     if (value !== undefined) {
       if (path.length === 1) {
-        const op = Object.getOwnPropertyDescriptor(
-          object.constructor.prototype,
-          name
-        );
-
         value = prepareValue(value, attribute);
 
         const property = properties[name];
 
-        if (op?.set || property?.set) {
+        if (property?.set) {
           applyLater[name] = value;
         } else {
-          properties[name] = Object.assign({ ...attribute, value }, property);
+          const op = findPropertyDescriptor(object, name);
+          if (op?.set) {
+            applyLater[name] = value;
+          } else {
+            properties[name] = Object.assign({ ...attribute, value }, property);
+          }
         }
       } else {
         setAttribute(object, name, value, attribute);