pacc 4.37.0 → 4.37.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pacc",
-  "version": "4.37.0",
+  "version": "4.37.2",
   "publishConfig": {
     "access": "public",
     "provenance": true

package/src/common-attributes.mjs

@@ -115,7 +115,7 @@ export { default_attribute as type_attribute };
 /**
  * @type {AttributeDefinition}
  */
-export { default_attribute_writable as state_attribute };
+export { default_attribute_writable as state_attribute_writable };
 
 /**
  * @type {AttributeDefinition}
@@ -312,13 +312,13 @@ export const id_attribute = {
  * The body text.
  * @type {AttributeDefinition}
  */
-export { default_attribute_writable as body_attribute };
+export { default_attribute_writable as body_attribute_writable };
 
 /**
  * The one line description.
  * @type {AttributeDefinition}
  */
-export const title_attribute = {
+export const title_attribute_writable = {
   ...default_attribute,
   description: "human readable title",
   writable: true

package/src/types.mjs

@@ -1,3 +1,5 @@
+import { attributeIterator } from "./attributes.mjs";
+
 export const types = {
   string: { name: "string", primitive: true },
   number: {
@@ -28,40 +30,61 @@ export const types = {
   object: { name: "object", extends: "base" }
 };
 
+function error(message) {
+  throw new Error(message);
+}
+
 export function addType(type) {
+  if (types[type.name]) {
+    return Object.assign(types[type.name], type);
+  }
+
   types[type.name] = type;
+
+  for (const [path, attribute] of attributeIterator(type.attributes)) {
+    if (typeof attribute.type === "string") {
+      attribute.type = oneOfType(attribute.type);
+    }
+    if(attribute.isKey && !type.key) {
+      type.key = path.join('.');
+    }
+  }
+
   return type;
 }
 
 export function oneOfType(definition) {
-  const aggregate = list =>
-    list.reduce(
-      (a, c) => a.union(c?.members ?? new Set([types[c] ?? c])),
-      new Set()
-    );
+  const aggregate = (name, list) => {
+    const def = {
+      name,
+      members: list.reduce((all, type) => {
+        if (typeof type === "string") {
+          const t = types[type] || addType({ name: type });
+          if (!t) {
+            error(`Unknown type ${type} in '${definition}'`);
+          }
+          type = t;
+        }
+        return all.union(type.members ?? new Set([type]));
+      }, new Set())
+    };
 
-  if (Array.isArray(definition)) {
-    const name = definition
-      .map(t => t.name ?? t)
-      .sort()
-      .join("|");
+    if (def.members.size < 2) {
+      delete def.members;
+    }
+    return types[name] || addType(def);
+  };
 
-    return (
-      types[name] ||
-      addType({
-        name,
-        members: aggregate(definition)
-      })
+  if (Array.isArray(definition)) {
+    return aggregate(
+      definition
+        .map(t => t.name ?? t)
+        .sort()
+        .join("|"),
+      definition
     );
   } else {
     const parts = definition.split("|").sort();
-    const name = parts.join("|");
-    return (
-      types[name] ||
-      addType({
-        name,
-        members: aggregate(parts.map(t => types[t]))
-      })
-    );
+    return aggregate(parts.join("|"), parts);
   }
 }

package/types/common-attributes.d.mts

@@ -157,7 +157,7 @@ export const id_attribute: AttributeDefinition;
  * The one line description.
  * @type {AttributeDefinition}
  */
-export const title_attribute: AttributeDefinition;
+export const title_attribute_writable: AttributeDefinition;
 /**
  * In case there are several providers able to support a given source which one sould be used ?
  * this defines the order.
@@ -220,4 +220,4 @@ export type AttributeDefinition = {
      */
     additionalValues?: object;
 };
-export { default_attribute as string_attribute, default_attribute_writable as string_attribute_writable, default_attribute as type_attribute, default_attribute_writable as state_attribute, boolean_attribute_writable_true as active_attribute, secret_attribute as username_attribute, secret_attribute as password_attribute, secret_attribute as token_attribute, secret_attribute as certificate_attribute, integer_attribute as count_attribute, integer_attribute as size_attribute, default_attribute_writable as body_attribute, number_attribute as duration_attribute };
+export { default_attribute as string_attribute, default_attribute_writable as string_attribute_writable, default_attribute as type_attribute, default_attribute_writable as state_attribute_writable, boolean_attribute_writable_true as active_attribute, secret_attribute as username_attribute, secret_attribute as password_attribute, secret_attribute as token_attribute, secret_attribute as certificate_attribute, integer_attribute as count_attribute, integer_attribute as size_attribute, default_attribute_writable as body_attribute_writable, number_attribute as duration_attribute };