pabal-store-api-mcp 1.3.8 → 1.3.9

package/README.md

@@ -2,7 +2,7 @@
 
 [![Install MCP Server](https://cursor.com/deeplink/mcp-install-dark.svg)](https://cursor.com/en/install-mcp?name=pabal-store-api-mcp&config=eyJjb21tYW5kIjoibnB4IiwiYXJncyI6WyIteSIsInBhYmFsLW1jcCJdfQ%3D%3D)
 
-[![Pabal Web MCP (English)](https://img.shields.io/badge/Pabal%20Web%20MCP-English-blue)](https://pabal.quartz.best/docs/en-US/pabal-resource-mcp/README) [![Pabal Web MCP (한국어)](https://img.shields.io/badge/Pabal%20Web%20MCP-한국어-green)](https://pabal.quartz.best/docs/ko-KR/pabal-resource-mcp/README)
+[![Pabal Store API MCP (English)](https://img.shields.io/badge/Pabal%20Store%20API%20MCP-English-blue)](https://pabal.quartz.best/en-US/docs/pabal-store-api-mcp/README) [![Pabal Store API MCP (한국어)](https://img.shields.io/badge/Pabal%20Store%20API%20MCP-한국어-green)](https://pabal.quartz.best/ko-KR/docs/pabal-store-api-mcp/README)
 
 # MCP server for App Store Connect & Play Console API
 
@@ -58,8 +58,8 @@ chmod 700 ~/.config/pabal-mcp
 
 ## Documentation
 
-📖 **[Pabal Web MCP Documentation (English)](https://pabal.quartz.best/docs/en-US/pabal-resource-mcp/README)**
-📖 **[Pabal Web MCP 문서 (한국어)](https://pabal.quartz.best/docs/ko-KR/pabal-resource-mcp/README)**
+📖 **[Pabal Store API MCP Documentation (English)](https://pabal.quartz.best/en-US/docs/pabal-store-api-mcp/README)**
+📖 **[Pabal Store API MCP 문서 (한국어)](https://pabal.quartz.best/ko-KR/docs/pabal-store-api-mcp/README)**
 
 <br>
 

package/dist/src/core/services/app-store-service.js

@@ -280,6 +280,9 @@ export class AppStoreService {
                             locale,
                             screenshots: screenshotsToUpload,
                         });
+                        if (uploadResult.failed > 0) {
+                            throw new Error(`Screenshot upload reported ${uploadResult.failed} failed files`);
+                        }
                         console.error(`[AppStore]   ✅ Screenshots for ${locale}: ${uploadResult.uploaded} uploaded, ${uploadResult.deleted} deleted, ${uploadResult.failed} failed`);
                         uploadedLocales.push(locale);
                     }
@@ -297,6 +300,7 @@ export class AppStoreService {
                 }
                 if (failedLocales.length > 0) {
                     console.error(`[AppStore]     ❌ Failed: ${failedLocales.join(", ")}`);
+                    throw new Error(`Screenshot upload failed for locales: ${failedLocales.join(", ")}`);
                 }
             }
             try {

package/dist/src/packages/stores/app-store/client.d.ts

@@ -107,6 +107,10 @@ export declare class AppStoreClient {
      * Delete all screenshots in a screenshot set
      */
     private deleteAllScreenshotsInSet;
+    private sanitizePathSegment;
+    private getScreenshotLockPath;
+    private acquireScreenshotUploadLock;
+    private preflightScreenshotBatch;
     /**
      * Upload multiple screenshots for a locale, replacing existing ones
      * 1. Find or create screenshot sets for each display type

package/dist/src/packages/stores/app-store/client.js

@@ -4,9 +4,12 @@
  * Authentication: API Key (Issuer ID, Key ID, Private Key) required
  * API Documentation: https://developer.apple.com/documentation/appstoreconnectapi
  */
+import { closeSync, existsSync, mkdirSync, openSync, readFileSync, statSync, unlinkSync, } from "node:fs";
+import { basename, dirname, join } from "node:path";
 import { AppStoreConnectAPI } from "appstore-connect-sdk";
 import { AppsApi, AppInfosApi, AppInfoLocalizationsApi, AppScreenshotSetsApi, AppScreenshotsApi, AppStoreVersionLocalizationsApi, AppStoreVersionsApi, ResponseError, } from "appstore-connect-sdk/openapi";
 import { DEFAULT_LOCALE } from "../../../packages/configs/aso-config/constants.js";
+import { getAsoDir } from "../../../packages/configs/aso-config/utils.js";
 import { convertToAsoData, convertToMultilingualAsoData, convertToReleaseNote, fetchScreenshotsForLocalization, mapLocalizationsByLocale, selectEnglishAppName, sortReleaseNotes, sortVersions, } from "./api-converters.js";
 import { APP_STORE_API_BASE_URL, APP_STORE_PLATFORM, DEFAULT_APP_LIST_LIMIT, DEFAULT_VERSIONS_FETCH_LIMIT, } from "./constants.js";
 export class AppStoreClient {
@@ -575,8 +578,6 @@ export class AppStoreClient {
      */
     async uploadScreenshot(options) {
         const { imagePath, screenshotDisplayType, locale } = options;
-        const { readFileSync, statSync } = await import("node:fs");
-        const { basename } = await import("node:path");
         try {
             // Get app and version info
             const appId = await this.findAppId();
@@ -775,15 +776,75 @@ export class AppStoreClient {
         const screenshots = screenshotsResponse.data || [];
         let deletedCount = 0;
         for (const screenshot of screenshots) {
+            await this.deleteScreenshot(screenshot.id);
+            deletedCount++;
+        }
+        return deletedCount;
+    }
+    sanitizePathSegment(value) {
+        return value.replace(/[^a-zA-Z0-9._-]/g, "_");
+    }
+    getScreenshotLockPath(locale, displayType) {
+        const appIdSegment = this.sanitizePathSegment(this.bundleId);
+        const localeSegment = this.sanitizePathSegment(locale);
+        const displayTypeSegment = this.sanitizePathSegment(displayType);
+        return join(getAsoDir(), "locks", "screenshots", "app-store", appIdSegment, localeSegment, `${displayTypeSegment}.lock`);
+    }
+    acquireScreenshotUploadLock(lockPath) {
+        mkdirSync(dirname(lockPath), { recursive: true });
+        let descriptor;
+        try {
+            descriptor = openSync(lockPath, "wx");
+        }
+        catch (error) {
+            const code = error.code;
+            if (code === "EEXIST") {
+                throw new Error(`Screenshot upload lock is already held (${lockPath}). Another upload is running for this locale/display type.`);
+            }
+            throw error;
+        }
+        closeSync(descriptor);
+        return () => {
             try {
-                await this.deleteScreenshot(screenshot.id);
-                deletedCount++;
+                unlinkSync(lockPath);
             }
-            catch (error) {
-                console.error(`[AppStore] Warning: Failed to delete screenshot ${screenshot.id}: ${error instanceof Error ? error.message : String(error)}`);
+            catch {
+                // Ignore lock cleanup failures.
+            }
+        };
+    }
+    preflightScreenshotBatch(locale, byDisplayType) {
+        for (const [displayType, screenshotList] of byDisplayType) {
+            if (screenshotList.length === 0) {
+                throw new Error(`Preflight failed for ${locale}/${displayType}: empty screenshot list`);
+            }
+            const seenPaths = new Set();
+            const seenFileNames = new Set();
+            for (const screenshot of screenshotList) {
+                if (!existsSync(screenshot.path)) {
+                    throw new Error(`Preflight failed for ${locale}/${displayType}: file not found (${screenshot.path})`);
+                }
+                const fileStat = statSync(screenshot.path);
+                if (!fileStat.isFile()) {
+                    throw new Error(`Preflight failed for ${locale}/${displayType}: not a file (${screenshot.path})`);
+                }
+                if (fileStat.size <= 0) {
+                    throw new Error(`Preflight failed for ${locale}/${displayType}: empty file (${screenshot.path})`);
+                }
+                if (!screenshot.filename.trim()) {
+                    throw new Error(`Preflight failed for ${locale}/${displayType}: empty filename (${screenshot.path})`);
+                }
+                if (seenPaths.has(screenshot.path)) {
+                    throw new Error(`Preflight failed for ${locale}/${displayType}: duplicate file path (${screenshot.path})`);
+                }
+                seenPaths.add(screenshot.path);
+                const normalizedFileName = screenshot.filename.trim().toLowerCase();
+                if (seenFileNames.has(normalizedFileName)) {
+                    throw new Error(`Preflight failed for ${locale}/${displayType}: duplicate filename (${screenshot.filename})`);
+                }
+                seenFileNames.add(normalizedFileName);
             }
         }
-        return deletedCount;
     }
     /**
      * Upload multiple screenshots for a locale, replacing existing ones
@@ -793,8 +854,6 @@ export class AppStoreClient {
      */
     async uploadScreenshotsForLocale(options) {
         const { locale, screenshots } = options;
-        const { readFileSync, statSync, existsSync } = await import("node:fs");
-        const { basename } = await import("node:path");
         const result = { uploaded: 0, deleted: 0, failed: 0 };
         if (screenshots.length === 0) {
             return result;
@@ -830,45 +889,50 @@ export class AppStoreClient {
                     filename: screenshot.filename,
                 });
             }
+            this.preflightScreenshotBatch(locale, byDisplayType);
             // Process each display type
             for (const [displayType, screenshotList] of byDisplayType) {
-                console.error(`[AppStore]     Processing ${displayType} (${screenshotList.length} screenshots)...`);
-                // Find or create screenshot set
-                const screenshotSetId = await this.findOrCreateScreenshotSet(localizationId, displayType);
-                // Delete existing screenshots in this set
-                const deletedCount = await this.deleteAllScreenshotsInSet(screenshotSetId);
-                if (deletedCount > 0) {
-                    console.error(`[AppStore]       🗑️  Deleted ${deletedCount} existing screenshots`);
-                    result.deleted += deletedCount;
-                }
-                // Upload new screenshots in order
-                for (const screenshot of screenshotList) {
-                    if (!existsSync(screenshot.path)) {
-                        console.error(`[AppStore]       ⚠️  File not found: ${screenshot.filename}`);
-                        result.failed++;
-                        continue;
+                const releaseLock = this.acquireScreenshotUploadLock(this.getScreenshotLockPath(locale, displayType));
+                try {
+                    console.error(`[AppStore]     Processing ${displayType} (${screenshotList.length} screenshots)...`);
+                    // Find or create screenshot set
+                    const screenshotSetId = await this.findOrCreateScreenshotSet(localizationId, displayType);
+                    // Delete existing screenshots in this set
+                    const deletedCount = await this.deleteAllScreenshotsInSet(screenshotSetId);
+                    if (deletedCount > 0) {
+                        console.error(`[AppStore]       Deleted ${deletedCount} existing screenshots`);
+                        result.deleted += deletedCount;
                     }
-                    try {
-                        const fileBuffer = readFileSync(screenshot.path);
-                        const fileSize = statSync(screenshot.path).size;
-                        // Create screenshot with upload operation
-                        const screenshotData = await this.createAppScreenshot(screenshotSetId, screenshot.filename, fileSize);
-                        // Upload file
-                        if (screenshotData.uploadOperations &&
-                            screenshotData.uploadOperations.length > 0) {
-                            const uploadOp = screenshotData.uploadOperations[0];
-                            await this.uploadFileToUrl(uploadOp.url, fileBuffer, uploadOp.method);
+                    // Upload new screenshots in order
+                    for (const screenshot of screenshotList) {
+                        try {
+                            const fileBuffer = readFileSync(screenshot.path);
+                            const fileSize = statSync(screenshot.path).size;
+                            // Create screenshot with upload operation
+                            const screenshotData = await this.createAppScreenshot(screenshotSetId, screenshot.filename, fileSize);
+                            // Upload file
+                            if (screenshotData.uploadOperations &&
+                                screenshotData.uploadOperations.length > 0) {
+                                const uploadOp = screenshotData.uploadOperations[0];
+                                await this.uploadFileToUrl(uploadOp.url, fileBuffer, uploadOp.method);
+                            }
+                            // Commit screenshot
+                            await this.commitAppScreenshot(screenshotData.id);
+                            console.error(`[AppStore]       ✅ ${screenshot.filename}`);
+                            result.uploaded++;
+                        }
+                        catch (error) {
+                            result.failed++;
+                            throw new Error(`[${displayType}] ${screenshot.filename}: ${error instanceof Error ? error.message : String(error)}`);
                         }
-                        // Commit screenshot
-                        await this.commitAppScreenshot(screenshotData.id);
-                        console.error(`[AppStore]       ✅ ${screenshot.filename}`);
-                        result.uploaded++;
-                    }
-                    catch (error) {
-                        console.error(`[AppStore]       ❌ ${screenshot.filename}: ${error instanceof Error ? error.message : String(error)}`);
-                        result.failed++;
                     }
                 }
+                finally {
+                    releaseLock();
+                }
+            }
+            if (result.failed > 0) {
+                throw new Error(`Screenshot upload completed with ${result.failed} failed files`);
             }
             return result;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pabal-store-api-mcp",
-  "version": "1.3.8",
+  "version": "1.3.9",
   "description": "MCP server for App Store / Play Store ASO workflows",
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",