pabal-store-api-mcp 1.3.0 → 1.3.2

package/dist/src/core/services/app-store-service.js

@@ -1,8 +1,10 @@
 import { AppError } from "../../packages/common/errors/app-error.js";
 import { ERROR_CODES } from "../../packages/common/errors/error-codes.js";
 import { HTTP_STATUS } from "../../packages/common/errors/status-codes.js";
+import { getAsoPushDir } from "../../packages/configs/aso-config/utils.js";
 import { verifyAppStoreAuth } from "../../packages/stores/app-store/verify-auth.js";
 import { createAppStoreClient } from "../../core/clients/app-store-factory.js";
+import { parseAppStoreScreenshots, hasScreenshots, APP_STORE_DEVICE_TYPES, } from "../../core/helpers/screenshot-helpers.js";
 import { checkPushPrerequisites, serviceFailure, toServiceResult, updateRegisteredLocales, } from "./service-helpers.js";
 /**
  * App Store-facing service layer that wraps client creation and common operations.
@@ -197,32 +199,87 @@ export class AppStoreService {
             // Upload screenshots if enabled
             if (uploadImages && slug) {
                 console.error(`[AppStore]   📤 Uploading screenshots...`);
-                const { getAsoPushDir } = await import("../../packages/configs/aso-config/utils.js");
-                const { parseAppStoreScreenshots, hasScreenshots } = await import("../../core/helpers/screenshot-helpers.js");
                 const pushDataDir = getAsoPushDir();
-                const screenshotsBaseDir = `${pushDataDir}/products/${slug}/store/app-store/screenshots`;
+                const screenshotsBaseDir = `${pushDataDir}/products/${slug}/store`;
+                const uploadedLocales = [];
+                const skippedLocales = [];
+                const failedLocales = [];
                 for (const locale of localesToPush) {
-                    if (!hasScreenshots(screenshotsBaseDir, locale)) {
-                        console.error(`[AppStore]   ⏭️  Skipping ${locale} - no screenshots directory`);
-                        continue;
-                    }
-                    console.error(`[AppStore]   📤 Uploading screenshots for ${locale}...`);
-                    const result = parseAppStoreScreenshots(screenshotsBaseDir, locale);
-                    // Report parsing issues
-                    if (result.invalid.length > 0) {
-                        console.error(`[AppStore]     ⚠️  Invalid filenames: ${result.invalid.join(", ")}`);
-                    }
-                    if (result.unknown.length > 0) {
-                        console.error(`[AppStore]     ⚠️  Unknown device types: ${result.unknown.join(", ")}`);
-                    }
-                    // Upload screenshots for each device type
-                    for (const [displayType, screenshots] of Object.entries(result.valid)) {
-                        console.error(`[AppStore]     📱 Uploading ${screenshots.length} screenshots for ${displayType}...`);
-                        for (const screenshot of screenshots) {
+                    try {
+                        const localeData = appStoreData.locales[locale];
+                        // Check if screenshots are defined in aso-data.json
+                        const hasScreenshotsInJson = localeData?.screenshots &&
+                            ((localeData.screenshots.iphone65 &&
+                                localeData.screenshots.iphone65.length > 0) ||
+                                (localeData.screenshots.ipadPro129 &&
+                                    localeData.screenshots.ipadPro129.length > 0));
+                        let screenshotsToUpload = [];
+                        if (hasScreenshotsInJson) {
+                            // Use screenshots from aso-data.json (relative paths)
+                            console.error(`[AppStore]   📋 Using screenshots from aso-data.json for ${locale}`);
+                            const relativePaths = localeData.screenshots;
+                            // Map iphone65 screenshots
+                            if (relativePaths.iphone65 && relativePaths.iphone65.length > 0) {
+                                for (const relPath of relativePaths.iphone65) {
+                                    screenshotsToUpload.push({
+                                        path: `${screenshotsBaseDir}/${relPath}`,
+                                        displayType: APP_STORE_DEVICE_TYPES.iphone65,
+                                        filename: relPath.split("/").pop() || relPath,
+                                    });
+                                }
+                            }
+                            // Map ipadPro129 screenshots
+                            if (relativePaths.ipadPro129 &&
+                                relativePaths.ipadPro129.length > 0) {
+                                for (const relPath of relativePaths.ipadPro129) {
+                                    screenshotsToUpload.push({
+                                        path: `${screenshotsBaseDir}/${relPath}`,
+                                        displayType: APP_STORE_DEVICE_TYPES.ipadPro129,
+                                        filename: relPath.split("/").pop() || relPath,
+                                    });
+                                }
+                            }
+                        }
+                        else {
+                            // Fallback: Parse from file system (backward compatibility)
+                            const screenshotsFsDir = `${screenshotsBaseDir}/app-store/screenshots`;
+                            if (!hasScreenshots(screenshotsFsDir, locale)) {
+                                console.error(`[AppStore]   ⏭️  Skipping ${locale} - no screenshots in aso-data.json or file system`);
+                                skippedLocales.push(locale);
+                                continue;
+                            }
+                            console.error(`[AppStore]   📂 Parsing screenshots from file system for ${locale}`);
+                            const result = parseAppStoreScreenshots(screenshotsFsDir, locale);
+                            // Report parsing issues
+                            if (result.invalid.length > 0) {
+                                console.error(`[AppStore]     ⚠️  Invalid filenames: ${result.invalid.join(", ")}`);
+                            }
+                            if (result.unknown.length > 0) {
+                                console.error(`[AppStore]     ⚠️  Unknown device types: ${result.unknown.join(", ")}`);
+                            }
+                            // Convert parsed screenshots to upload format
+                            for (const [displayType, screenshots] of Object.entries(result.valid)) {
+                                for (const screenshot of screenshots) {
+                                    screenshotsToUpload.push({
+                                        path: screenshot.path,
+                                        displayType,
+                                        filename: screenshot.filename,
+                                    });
+                                }
+                            }
+                        }
+                        if (screenshotsToUpload.length === 0) {
+                            console.error(`[AppStore]   ⚠️  Skipping ${locale} - no valid screenshots found`);
+                            skippedLocales.push(locale);
+                            continue;
+                        }
+                        console.error(`[AppStore]   📤 Uploading screenshots for ${locale}...`);
+                        // Upload screenshots
+                        for (const screenshot of screenshotsToUpload) {
                             try {
                                 await client.uploadScreenshot({
                                     imagePath: screenshot.path,
-                                    screenshotDisplayType: displayType,
+                                    screenshotDisplayType: screenshot.displayType,
                                     locale,
                                 });
                                 console.error(`[AppStore]       ✅ ${screenshot.filename}`);
@@ -234,8 +291,23 @@ export class AppStoreService {
                                 console.error(`[AppStore]       ❌ ${screenshot.filename}: ${msg}`);
                             }
                         }
+                        uploadedLocales.push(locale);
+                        console.error(`[AppStore]   ✅ Screenshots uploaded for ${locale}`);
                     }
-                    console.error(`[AppStore]   ✅ Screenshots uploaded for ${locale}`);
+                    catch (error) {
+                        console.error(`[AppStore]   ❌ Failed to upload screenshots for ${locale}: ${error instanceof Error ? error.message : String(error)}`);
+                        failedLocales.push(locale);
+                    }
+                }
+                console.error(`[AppStore]   📊 Screenshot upload summary: ${uploadedLocales.length} succeeded, ${skippedLocales.length} skipped, ${failedLocales.length} failed`);
+                if (uploadedLocales.length > 0) {
+                    console.error(`[AppStore]     ✅ Uploaded: ${uploadedLocales.join(", ")}`);
+                }
+                if (skippedLocales.length > 0) {
+                    console.error(`[AppStore]     ⏭️  Skipped: ${skippedLocales.join(", ")}`);
+                }
+                if (failedLocales.length > 0) {
+                    console.error(`[AppStore]     ❌ Failed: ${failedLocales.join(", ")}`);
                 }
             }
             try {

package/dist/src/core/services/google-play-service.js

@@ -1,8 +1,10 @@
 import { AppError } from "../../packages/common/errors/app-error.js";
 import { ERROR_CODES } from "../../packages/common/errors/error-codes.js";
 import { HTTP_STATUS } from "../../packages/common/errors/status-codes.js";
+import { getAsoPushDir } from "../../packages/configs/aso-config/utils.js";
 import { verifyPlayStoreAuth } from "../../packages/stores/play-store/verify-auth.js";
 import { createGooglePlayClient } from "../../core/clients/google-play-factory.js";
+import { parseGooglePlayScreenshots, hasScreenshots, } from "../../core/helpers/screenshot-helpers.js";
 import { checkPushPrerequisites, serviceFailure, toServiceResult, updateRegisteredLocales, } from "./service-helpers.js";
 /**
  * Google Play-facing service layer that wraps client creation and common operations.
@@ -177,57 +179,114 @@ export class GooglePlayService {
                 });
                 console.error(`[GooglePlay]   ✅ App details uploaded successfully`);
             }
+            // Note: YouTube URL is pushed as part of listing data for each locale
             // Upload screenshots if enabled
             if (uploadImages && slug) {
                 console.error(`[GooglePlay]   📤 Uploading screenshots...`);
-                const { getAsoPushDir } = await import("../../packages/configs/aso-config/utils.js");
-                const { parseGooglePlayScreenshots, hasScreenshots } = await import("../../core/helpers/screenshot-helpers.js");
                 const pushDataDir = getAsoPushDir();
-                const screenshotsBaseDir = `${pushDataDir}/products/${slug}/store/google-play/screenshots`;
+                const screenshotsBaseDir = `${pushDataDir}/products/${slug}/store`;
+                const uploadedLocales = [];
+                const skippedLocales = [];
+                const failedLocales = [];
                 for (const locale of localesToPush) {
-                    if (!hasScreenshots(screenshotsBaseDir, locale)) {
-                        console.error(`[GooglePlay]   ⏭️  Skipping ${locale} - no screenshots directory`);
-                        continue;
+                    try {
+                        const localeData = googlePlayData.locales[locale];
+                        // Check if screenshots are defined in aso-data.json
+                        const hasScreenshotsInJson = localeData?.screenshots &&
+                            ((localeData.screenshots.phone &&
+                                localeData.screenshots.phone.length > 0) ||
+                                (localeData.screenshots.tablet7 &&
+                                    localeData.screenshots.tablet7.length > 0) ||
+                                (localeData.screenshots.tablet10 &&
+                                    localeData.screenshots.tablet10.length > 0));
+                        let screenshots;
+                        if (hasScreenshotsInJson) {
+                            // Use screenshots from aso-data.json (relative paths)
+                            console.error(`[GooglePlay]   📋 Using screenshots from aso-data.json for ${locale}`);
+                            const relativePaths = localeData.screenshots;
+                            screenshots = {
+                                phone: (relativePaths.phone || []).map((p) => `${screenshotsBaseDir}/${p}`),
+                                tablet7: (relativePaths.tablet7 || []).map((p) => `${screenshotsBaseDir}/${p}`),
+                                tablet10: (relativePaths.tablet10 || []).map((p) => `${screenshotsBaseDir}/${p}`),
+                                featureGraphic: localeData.featureGraphic
+                                    ? `${screenshotsBaseDir}/${localeData.featureGraphic}`
+                                    : null,
+                            };
+                        }
+                        else {
+                            // Fallback: Parse from file system (backward compatibility)
+                            const screenshotsFsDir = `${screenshotsBaseDir}/google-play/screenshots`;
+                            if (!hasScreenshots(screenshotsFsDir, locale)) {
+                                console.error(`[GooglePlay]   ⏭️  Skipping ${locale} - no screenshots in aso-data.json or file system`);
+                                skippedLocales.push(locale);
+                                continue;
+                            }
+                            console.error(`[GooglePlay]   📂 Parsing screenshots from file system for ${locale}`);
+                            screenshots = parseGooglePlayScreenshots(screenshotsFsDir, locale);
+                        }
+                        // Google Play requires minimum 2 phone screenshots
+                        const phoneCount = screenshots.phone.length + screenshots.tablet7.length;
+                        if (phoneCount < 2) {
+                            console.error(`[GooglePlay]   ⚠️  Skipping ${locale} - needs at least 2 phone/tablet7 screenshots (found ${phoneCount})`);
+                            skippedLocales.push(locale);
+                            continue;
+                        }
+                        console.error(`[GooglePlay]   📤 Uploading screenshots for ${locale}...`);
+                        // Upload phone screenshots (phone-*.png)
+                        for (const imagePath of screenshots.phone) {
+                            await client.uploadScreenshot({
+                                imagePath,
+                                imageType: "phoneScreenshots",
+                                language: locale,
+                            });
+                            console.error(`[GooglePlay]     ✅ ${imagePath.split("/").pop()}`);
+                        }
+                        // Upload 7-inch tablet screenshots as phone
+                        for (const imagePath of screenshots.tablet7) {
+                            await client.uploadScreenshot({
+                                imagePath,
+                                imageType: "phoneScreenshots",
+                                language: locale,
+                            });
+                            console.error(`[GooglePlay]     ✅ ${imagePath.split("/").pop()} (as phone)`);
+                        }
+                        // Upload 10-inch tablet screenshots as tablet (optional)
+                        if (screenshots.tablet10.length > 0) {
+                            for (const imagePath of screenshots.tablet10) {
+                                await client.uploadScreenshot({
+                                    imagePath,
+                                    imageType: "tenInchScreenshots",
+                                    language: locale,
+                                });
+                                console.error(`[GooglePlay]     ✅ ${imagePath.split("/").pop()} (as tablet)`);
+                            }
+                        }
+                        // Upload feature graphic (optional)
+                        if (screenshots.featureGraphic) {
+                            await client.uploadScreenshot({
+                                imagePath: screenshots.featureGraphic,
+                                imageType: "featureGraphic",
+                                language: locale,
+                            });
+                            console.error(`[GooglePlay]     ✅ feature-graphic.png`);
+                        }
+                        uploadedLocales.push(locale);
+                        console.error(`[GooglePlay]   ✅ Screenshots uploaded for ${locale}`);
                     }
-                    console.error(`[GooglePlay]   📤 Uploading screenshots for ${locale}...`);
-                    const screenshots = parseGooglePlayScreenshots(screenshotsBaseDir, locale);
-                    // Upload phone screenshots (phone-*.png)
-                    for (const imagePath of screenshots.phone) {
-                        await client.uploadScreenshot({
-                            imagePath,
-                            imageType: "phoneScreenshots",
-                            language: locale,
-                        });
-                        console.error(`[GooglePlay]     ✅ ${imagePath.split("/").pop()}`);
+                    catch (error) {
+                        console.error(`[GooglePlay]   ❌ Failed to upload screenshots for ${locale}: ${error instanceof Error ? error.message : String(error)}`);
+                        failedLocales.push(locale);
                     }
-                    // Upload 7-inch tablet screenshots as phone
-                    for (const imagePath of screenshots.tablet7) {
-                        await client.uploadScreenshot({
-                            imagePath,
-                            imageType: "phoneScreenshots",
-                            language: locale,
-                        });
-                        console.error(`[GooglePlay]     ✅ ${imagePath.split("/").pop()} (as phone)`);
-                    }
-                    // Upload 10-inch tablet screenshots as tablet
-                    for (const imagePath of screenshots.tablet10) {
-                        await client.uploadScreenshot({
-                            imagePath,
-                            imageType: "tenInchScreenshots",
-                            language: locale,
-                        });
-                        console.error(`[GooglePlay]     ✅ ${imagePath.split("/").pop()} (as tablet)`);
-                    }
-                    // Upload feature graphic
-                    if (screenshots.featureGraphic) {
-                        await client.uploadScreenshot({
-                            imagePath: screenshots.featureGraphic,
-                            imageType: "featureGraphic",
-                            language: locale,
-                        });
-                        console.error(`[GooglePlay]     ✅ feature-graphic.png`);
-                    }
-                    console.error(`[GooglePlay]   ✅ Screenshots uploaded for ${locale}`);
+                }
+                console.error(`[GooglePlay]   📊 Screenshot upload summary: ${uploadedLocales.length} succeeded, ${skippedLocales.length} skipped, ${failedLocales.length} failed`);
+                if (uploadedLocales.length > 0) {
+                    console.error(`[GooglePlay]     ✅ Uploaded: ${uploadedLocales.join(", ")}`);
+                }
+                if (skippedLocales.length > 0) {
+                    console.error(`[GooglePlay]     ⏭️  Skipped: ${skippedLocales.join(", ")}`);
+                }
+                if (failedLocales.length > 0) {
+                    console.error(`[GooglePlay]     ❌ Failed: ${failedLocales.join(", ")}`);
                 }
             }
             try {

package/dist/src/packages/configs/aso-config/types.d.ts

@@ -17,6 +17,7 @@ export interface GooglePlayAsoData {
     screenshots: GooglePlayScreenshots;
     featureGraphic?: string;
     promoGraphic?: string;
+    video?: string;
     category?: string;
     contentRating?: string;
     keywords?: string[];
@@ -31,6 +32,7 @@ export interface GooglePlayMultilingualAsoData {
     defaultLocale?: string;
     contactEmail?: string;
     contactWebsite?: string;
+    youtubeUrl?: string;
 }
 export interface GooglePlayReleaseNote {
     versionCode: number;

package/dist/src/packages/configs/aso-config/utils.js

@@ -72,12 +72,18 @@ export function prepareAsoDataForPush(slug, configData, options) {
         const locales = isGooglePlayMultilingual(googlePlayData)
             ? googlePlayData.locales
             : { [googlePlayData.defaultLanguage || DEFAULT_LOCALE]: googlePlayData };
+        // Get app-level youtubeUrl if available
+        const appLevelYoutubeUrl = isGooglePlayMultilingual(googlePlayData)
+            ? googlePlayData.youtubeUrl
+            : undefined;
         const cleanedLocales = {};
         for (const [locale, localeData] of Object.entries(locales)) {
             const { screenshots, featureGraphic, ...rest } = localeData;
             cleanedLocales[locale] = {
                 ...rest,
                 contactWebsite: detailPageUrl,
+                // Apply app-level youtubeUrl to all locales if not already set
+                video: rest.video || appLevelYoutubeUrl,
             };
         }
         const gpDefaultLocale = isGooglePlayMultilingual(googlePlayData)
@@ -86,6 +92,11 @@ export function prepareAsoDataForPush(slug, configData, options) {
         storeData.googlePlay = {
             locales: cleanedLocales,
             defaultLocale: gpDefaultLocale || DEFAULT_LOCALE,
+            contactEmail: isGooglePlayMultilingual(googlePlayData)
+                ? googlePlayData.contactEmail
+                : undefined,
+            contactWebsite: detailPageUrl,
+            youtubeUrl: appLevelYoutubeUrl,
         };
     }
     if (configData.appStore) {

package/dist/src/packages/stores/play-store/api-converters.d.ts

@@ -31,6 +31,7 @@ export declare function buildListingRequestBody(data: {
     title?: string;
     shortDescription?: string;
     fullDescription?: string;
+    video?: string;
 }): ListingUpdateAttributes;
 /**
  * Build request body for app details update (only defined values)

package/dist/src/packages/stores/play-store/api-converters.js

@@ -121,6 +121,8 @@ export function buildListingRequestBody(data) {
         body.shortDescription = data.shortDescription;
     if (data.fullDescription)
         body.fullDescription = data.fullDescription;
+    if (data.video)
+        body.video = data.video;
     return body;
 }
 /**

package/dist/src/packages/stores/play-store/client.js

@@ -138,11 +138,15 @@ export class GooglePlayClient {
         };
         try {
             const language = data.defaultLanguage || DEFAULT_LANGUAGE;
-            if (data.title || data.shortDescription || data.fullDescription) {
+            if (data.title ||
+                data.shortDescription ||
+                data.fullDescription ||
+                data.video) {
                 const listingBody = buildListingRequestBody({
                     title: data.title,
                     shortDescription: data.shortDescription,
                     fullDescription: data.fullDescription,
+                    video: data.video,
                 });
                 console.error(`[GooglePlayClient] Updating listing for ${language}:`, JSON.stringify(listingBody, null, 2));
                 try {
@@ -216,11 +220,13 @@ export class GooglePlayClient {
             for (const [language, localeData] of Object.entries(data.locales)) {
                 if (localeData.title ||
                     localeData.shortDescription ||
-                    localeData.fullDescription) {
+                    localeData.fullDescription ||
+                    localeData.video) {
                     const listingBody = buildListingRequestBody({
                         title: localeData.title,
                         shortDescription: localeData.shortDescription,
                         fullDescription: localeData.fullDescription,
+                        video: localeData.video,
                     });
                     console.error(`[GooglePlayClient] Updating listing for ${language}...`);
                     try {
@@ -295,6 +301,8 @@ export class GooglePlayClient {
             console.error(`[GooglePlayClient] No app details to update, skipping`);
             return;
         }
+        // Note: youtubeUrl is not part of AppDetails API
+        // YouTube URLs are managed at listing level (see pushMultilingualAsoData)
         const authClient = await this.auth.getClient();
         const editResponse = await this.createEdit(authClient, this.packageName);
         const editId = editResponse.data.id;

package/dist/src/packages/stores/play-store/types.d.ts

@@ -120,6 +120,7 @@ export interface UpdateReleaseNotesOptions {
  * App Details Data
  * Internal type for app details update operations
  * Based on AppDetails but with optional fields for partial updates
+ * Note: YouTube URLs are managed at listing level, not app details level
  */
 export interface AppDetailsData {
     contactEmail?: NonNullable<AppDetails["contactEmail"]>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pabal-store-api-mcp",
-  "version": "1.3.0",
+  "version": "1.3.2",
   "description": "MCP server for App Store / Play Store ASO workflows",
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",