oxlint-plugin-react-doctor 0.9.2-dev.201106e → 0.9.2-dev.2992a03
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/index.d.ts +1 -1
- package/dist/index.js +2266 -224
- package/package.json +2 -2
package/dist/index.js
CHANGED
|
@@ -388,7 +388,7 @@ const SOURCE_FILE_PATTERN = /\.(?:[cm]?[jt]sx?)$/i;
|
|
|
388
388
|
const SCRIPT_SOURCE_FILE_PATTERN = /\.(?:[cm]?[jt]sx?|py|php)$/i;
|
|
389
389
|
const DATABASE_SOURCE_FILE_PATTERN = /\.(?:[cm]?[jt]sx?|py)$/i;
|
|
390
390
|
const SERVER_CONTEXT_PATTERN = /(?:^|\/)(?:api|backend|server|servers|middleware|route|routes|functions|lambdas|workers)(?:\/|$)|(?:^|\/)[^/]+\.server\.[cm]?[jt]sx?$/i;
|
|
391
|
-
const TEST_CONTEXT_PATTERN = /(?:^|\/)(?:__fixtures__|__mocks__|__tests__|__integration__|fixtures|mocks|test|tests|testdata|test-data|e2e|playwright|cypress|specs?)(?:\/|$)
|
|
391
|
+
const TEST_CONTEXT_PATTERN = /(?:^|\/)(?:__fixtures__|__mocks__|__tests__|__integration__|fixtures|mocks|test|tests|testdata|test-data|e2e|playwright|cypress|specs?)(?:\/|$)|^(?:test|spec)-[^/]+\.[cm]?[jt]sx?$|\.(?:test|spec|e2e|e2e-spec|integration-test|fixture|fixtures|stories|story)\.[cm]?[jt]sx?$|(?:^|\/)(?:playwright|cypress|vitest|jest|karma)[^/]*\.conf(?:ig)?\.[cm]?[jt]s$|(?:^|\/)(?:test_[^/]+|[^/]+_test|conftest)\.py$|\.env\.[^/]*(?:test|e2e)[^/]*$/i;
|
|
392
392
|
const BUILD_CONFIG_FILE_PATTERN = /(?:^|\/)(?:vite|next|nuxt|astro|remix|webpack|rollup|rspack|rsbuild|esbuild|tsup|metro|expo|babel|tailwind|postcss|svelte|farm|parcel|snowpack)[^/]*\.config\.[cm]?[jt]sx?$/i;
|
|
393
393
|
const BUILD_SCRIPT_CONTEXT_PATTERN = /(?:^|\/)scripts(?:\/|$)/i;
|
|
394
394
|
const DEMO_CONTEXT_PATTERN = /(?:^|\/)(?:examples?|tutorials?|demos?|samples?|playgrounds?)(?:\/|$)/i;
|
|
@@ -665,19 +665,6 @@ const TRIVIAL_INITIALIZER_NAMES = new Set([
|
|
|
665
665
|
"parseInt",
|
|
666
666
|
"parseFloat"
|
|
667
667
|
]);
|
|
668
|
-
const TRIVIAL_CONSTRUCTOR_NAMES = new Set([
|
|
669
|
-
"Date",
|
|
670
|
-
"Map",
|
|
671
|
-
"Set",
|
|
672
|
-
"WeakMap",
|
|
673
|
-
"WeakSet",
|
|
674
|
-
"WeakRef",
|
|
675
|
-
"RegExp",
|
|
676
|
-
"Error",
|
|
677
|
-
"URL",
|
|
678
|
-
"URLSearchParams",
|
|
679
|
-
"AbortController"
|
|
680
|
-
]);
|
|
681
668
|
const SETTER_PATTERN = /^set[A-Z]/;
|
|
682
669
|
const RENDER_FUNCTION_PATTERN = /^render[A-Z]/;
|
|
683
670
|
const UPPERCASE_PATTERN = /^[A-Z]/;
|
|
@@ -5887,6 +5874,7 @@ const isInlineFunctionExpression = (node) => Boolean(node && (isNodeOfType(node,
|
|
|
5887
5874
|
//#endregion
|
|
5888
5875
|
//#region src/plugin/rules/js-performance/async-await-in-loop.ts
|
|
5889
5876
|
const LOOP_STATEMENT_TYPES$1 = new Set(LOOP_TYPES);
|
|
5877
|
+
const ORDERED_OUTPUT_INSERTION_METHOD_NAMES = new Set(["push", "unshift"]);
|
|
5890
5878
|
const findFirstAwaitOutsideNestedFunctions = (block, skipNestedLoops = false) => {
|
|
5891
5879
|
let firstAwait = null;
|
|
5892
5880
|
walkAst(block, (child) => {
|
|
@@ -5953,7 +5941,151 @@ const isAwaitingManualPromiseWait = (awaitNode) => {
|
|
|
5953
5941
|
});
|
|
5954
5942
|
return isWaitLike;
|
|
5955
5943
|
};
|
|
5956
|
-
const
|
|
5944
|
+
const getRootObjectIdentifierName = (node) => {
|
|
5945
|
+
let current = node;
|
|
5946
|
+
while (isNodeOfType(current, "MemberExpression")) current = current.object;
|
|
5947
|
+
return isNodeOfType(current, "Identifier") ? current.name : null;
|
|
5948
|
+
};
|
|
5949
|
+
const isScopeWithinFunction = (candidateScope, functionScope) => {
|
|
5950
|
+
let currentScope = candidateScope;
|
|
5951
|
+
while (currentScope) {
|
|
5952
|
+
if (currentScope === functionScope) return true;
|
|
5953
|
+
currentScope = currentScope.parent;
|
|
5954
|
+
}
|
|
5955
|
+
return false;
|
|
5956
|
+
};
|
|
5957
|
+
const isSymbolDirectlyReturned = (symbol, callerFunction) => Boolean(callerFunction) && symbol.references.some((reference) => {
|
|
5958
|
+
const expressionRoot = findTransparentExpressionRoot(reference.identifier);
|
|
5959
|
+
const parent = expressionRoot.parent;
|
|
5960
|
+
return isNodeOfType(parent, "ReturnStatement") && parent.argument === expressionRoot && findEnclosingFunction$1(parent) === callerFunction;
|
|
5961
|
+
});
|
|
5962
|
+
const collectPatternBindingSymbolIds = (pattern, scopes, target) => {
|
|
5963
|
+
if (isNodeOfType(pattern, "Identifier")) {
|
|
5964
|
+
const symbol = scopes.symbolFor(pattern);
|
|
5965
|
+
if (symbol) target.add(symbol.id);
|
|
5966
|
+
return;
|
|
5967
|
+
}
|
|
5968
|
+
if (isNodeOfType(pattern, "ObjectPattern")) {
|
|
5969
|
+
for (const property of pattern.properties ?? []) if (isNodeOfType(property, "Property") && property.value) collectPatternBindingSymbolIds(property.value, scopes, target);
|
|
5970
|
+
else if (isNodeOfType(property, "RestElement") && property.argument) collectPatternBindingSymbolIds(property.argument, scopes, target);
|
|
5971
|
+
return;
|
|
5972
|
+
}
|
|
5973
|
+
if (isNodeOfType(pattern, "ArrayPattern")) {
|
|
5974
|
+
for (const element of pattern.elements ?? []) if (element) collectPatternBindingSymbolIds(element, scopes, target);
|
|
5975
|
+
return;
|
|
5976
|
+
}
|
|
5977
|
+
if (isNodeOfType(pattern, "AssignmentPattern") && pattern.left) collectPatternBindingSymbolIds(pattern.left, scopes, target);
|
|
5978
|
+
};
|
|
5979
|
+
const collectReferencedSymbolIds = (expression, scopes) => {
|
|
5980
|
+
const referencedSymbolIds = /* @__PURE__ */ new Set();
|
|
5981
|
+
walkAst(expression, (child) => {
|
|
5982
|
+
if (child !== expression && isFunctionLike$1(child)) return false;
|
|
5983
|
+
if (!isNodeOfType(child, "Identifier")) return;
|
|
5984
|
+
const symbol = scopes.symbolFor(child);
|
|
5985
|
+
if (symbol) referencedSymbolIds.add(symbol.id);
|
|
5986
|
+
});
|
|
5987
|
+
return referencedSymbolIds;
|
|
5988
|
+
};
|
|
5989
|
+
const collectAwaitDerivedSymbolIds = (block, scopes) => {
|
|
5990
|
+
const awaitDerivedSymbolIds = /* @__PURE__ */ new Set();
|
|
5991
|
+
const bindingDependencies = [];
|
|
5992
|
+
walkAst(block, (child) => {
|
|
5993
|
+
if (child !== block && isFunctionLike$1(child)) return false;
|
|
5994
|
+
if (isNodeOfType(child, "VariableDeclarator") && child.id && child.init) {
|
|
5995
|
+
const declaredSymbolIds = /* @__PURE__ */ new Set();
|
|
5996
|
+
collectPatternBindingSymbolIds(child.id, scopes, declaredSymbolIds);
|
|
5997
|
+
if (containsDirectAwait(child.init)) for (const symbolId of declaredSymbolIds) awaitDerivedSymbolIds.add(symbolId);
|
|
5998
|
+
const referencedSymbolIds = collectReferencedSymbolIds(child.init, scopes);
|
|
5999
|
+
for (const declaredSymbolId of declaredSymbolIds) bindingDependencies.push({
|
|
6000
|
+
declaredSymbolId,
|
|
6001
|
+
referencedSymbolIds
|
|
6002
|
+
});
|
|
6003
|
+
return;
|
|
6004
|
+
}
|
|
6005
|
+
if (isNodeOfType(child, "AssignmentExpression") && child.left) {
|
|
6006
|
+
const assignedSymbolIds = /* @__PURE__ */ new Set();
|
|
6007
|
+
collectPatternBindingSymbolIds(child.left, scopes, assignedSymbolIds);
|
|
6008
|
+
if (containsDirectAwait(child.right)) for (const symbolId of assignedSymbolIds) awaitDerivedSymbolIds.add(symbolId);
|
|
6009
|
+
const referencedSymbolIds = collectReferencedSymbolIds(child.right, scopes);
|
|
6010
|
+
for (const assignedSymbolId of assignedSymbolIds) bindingDependencies.push({
|
|
6011
|
+
declaredSymbolId: assignedSymbolId,
|
|
6012
|
+
referencedSymbolIds
|
|
6013
|
+
});
|
|
6014
|
+
}
|
|
6015
|
+
});
|
|
6016
|
+
let didGrow = true;
|
|
6017
|
+
while (didGrow) {
|
|
6018
|
+
didGrow = false;
|
|
6019
|
+
for (const { declaredSymbolId, referencedSymbolIds } of bindingDependencies) {
|
|
6020
|
+
if (awaitDerivedSymbolIds.has(declaredSymbolId)) continue;
|
|
6021
|
+
for (const referencedSymbolId of referencedSymbolIds) {
|
|
6022
|
+
if (!awaitDerivedSymbolIds.has(referencedSymbolId)) continue;
|
|
6023
|
+
awaitDerivedSymbolIds.add(declaredSymbolId);
|
|
6024
|
+
didGrow = true;
|
|
6025
|
+
break;
|
|
6026
|
+
}
|
|
6027
|
+
}
|
|
6028
|
+
}
|
|
6029
|
+
return awaitDerivedSymbolIds;
|
|
6030
|
+
};
|
|
6031
|
+
const getSimpleParameterIdentifier = (parameter) => {
|
|
6032
|
+
if (isNodeOfType(parameter, "Identifier")) return parameter;
|
|
6033
|
+
if (isNodeOfType(parameter, "AssignmentPattern") && isNodeOfType(parameter.left, "Identifier")) return parameter.left;
|
|
6034
|
+
return null;
|
|
6035
|
+
};
|
|
6036
|
+
const doesAwaitedLocalCallInsertAwaitDerivedOutput = (awaitNode, context) => {
|
|
6037
|
+
if (!isNodeOfType(awaitNode, "AwaitExpression")) return false;
|
|
6038
|
+
const callExpression = awaitNode.argument;
|
|
6039
|
+
if (!isNodeOfType(callExpression, "CallExpression")) return false;
|
|
6040
|
+
const localFunction = resolveStaticLocalCallFunction(callExpression, context.scopes);
|
|
6041
|
+
if (!isFunctionLike$1(localFunction)) return false;
|
|
6042
|
+
const callerFunction = findEnclosingFunction$1(callExpression);
|
|
6043
|
+
const functionScope = context.scopes.ownScopeFor(localFunction);
|
|
6044
|
+
if (!functionScope) return false;
|
|
6045
|
+
const awaitDerivedSymbolIds = collectAwaitDerivedSymbolIds(localFunction.body, context.scopes);
|
|
6046
|
+
const externallyReachableParameterSymbolIds = /* @__PURE__ */ new Set();
|
|
6047
|
+
for (const [parameterIndex, parameter] of localFunction.params.entries()) {
|
|
6048
|
+
const parameterIdentifier = getSimpleParameterIdentifier(parameter);
|
|
6049
|
+
if (!parameterIdentifier) continue;
|
|
6050
|
+
const argument = callExpression.arguments[parameterIndex];
|
|
6051
|
+
if (!isNodeOfType(argument, "Identifier")) continue;
|
|
6052
|
+
const parameterSymbol = context.scopes.symbolFor(parameterIdentifier);
|
|
6053
|
+
const argumentSymbol = context.scopes.symbolFor(argument);
|
|
6054
|
+
if (parameterSymbol && argumentSymbol && (isSymbolDirectlyReturned(argumentSymbol, callerFunction) || argumentSymbol.id === parameterSymbol.id)) externallyReachableParameterSymbolIds.add(parameterSymbol.id);
|
|
6055
|
+
}
|
|
6056
|
+
let doesInsertAwaitDerivedOutput = false;
|
|
6057
|
+
walkAst(localFunction.body, (child) => {
|
|
6058
|
+
if (doesInsertAwaitDerivedOutput) return false;
|
|
6059
|
+
if (child !== localFunction.body && isFunctionLike$1(child)) return false;
|
|
6060
|
+
if (!isNodeOfType(child, "CallExpression")) return;
|
|
6061
|
+
const callee = child.callee;
|
|
6062
|
+
if (!isNodeOfType(callee, "MemberExpression") || callee.computed || !isNodeOfType(callee.property, "Identifier") || !ORDERED_OUTPUT_INSERTION_METHOD_NAMES.has(callee.property.name)) return;
|
|
6063
|
+
let doesMutationConsumeAwaitedValue = false;
|
|
6064
|
+
for (const mutationArgument of child.arguments ?? []) {
|
|
6065
|
+
if (containsDirectAwait(mutationArgument)) {
|
|
6066
|
+
doesMutationConsumeAwaitedValue = true;
|
|
6067
|
+
break;
|
|
6068
|
+
}
|
|
6069
|
+
const referencedSymbolIds = collectReferencedSymbolIds(mutationArgument, context.scopes);
|
|
6070
|
+
for (const referencedSymbolId of referencedSymbolIds) if (awaitDerivedSymbolIds.has(referencedSymbolId)) {
|
|
6071
|
+
doesMutationConsumeAwaitedValue = true;
|
|
6072
|
+
break;
|
|
6073
|
+
}
|
|
6074
|
+
if (doesMutationConsumeAwaitedValue) break;
|
|
6075
|
+
}
|
|
6076
|
+
if (!doesMutationConsumeAwaitedValue) return;
|
|
6077
|
+
let receiverIdentifier = callee.object;
|
|
6078
|
+
while (isNodeOfType(receiverIdentifier, "MemberExpression")) receiverIdentifier = receiverIdentifier.object;
|
|
6079
|
+
if (!isNodeOfType(receiverIdentifier, "Identifier")) return;
|
|
6080
|
+
const receiverSymbol = context.scopes.symbolFor(receiverIdentifier);
|
|
6081
|
+
if (receiverSymbol && (externallyReachableParameterSymbolIds.has(receiverSymbol.id) || !isScopeWithinFunction(receiverSymbol.scope, functionScope) && isSymbolDirectlyReturned(receiverSymbol, callerFunction))) {
|
|
6082
|
+
doesInsertAwaitDerivedOutput = true;
|
|
6083
|
+
return false;
|
|
6084
|
+
}
|
|
6085
|
+
});
|
|
6086
|
+
return doesInsertAwaitDerivedOutput;
|
|
6087
|
+
};
|
|
6088
|
+
const isIntentionallySequentialAwait = (awaitNode, context) => isAwaitingPossiblyMutatedMemberCall(awaitNode, context) || isAwaitingSleepLikeCall(awaitNode, context) || isAwaitingPromiseConcurrencyCall(awaitNode) || isAwaitingManualPromiseWait(awaitNode) || doesAwaitedLocalCallInsertAwaitDerivedOutput(awaitNode, context);
|
|
5957
6089
|
const collectPatternIdentifiers = (pattern, target) => {
|
|
5958
6090
|
if (isNodeOfType(pattern, "Identifier")) target.add(pattern.name);
|
|
5959
6091
|
else if (isNodeOfType(pattern, "ObjectPattern")) {
|
|
@@ -6099,11 +6231,6 @@ const loopBodyHasAwaitDependentEarlyExit = (block, loopLabelName) => {
|
|
|
6099
6231
|
});
|
|
6100
6232
|
return hasAwaitDependentExit;
|
|
6101
6233
|
};
|
|
6102
|
-
const getRootObjectIdentifierName = (node) => {
|
|
6103
|
-
let current = node;
|
|
6104
|
-
while (isNodeOfType(current, "MemberExpression")) current = current.object;
|
|
6105
|
-
return isNodeOfType(current, "Identifier") ? current.name : null;
|
|
6106
|
-
};
|
|
6107
6234
|
const MUTATING_ARRAY_METHOD_NAMES$2 = new Set([
|
|
6108
6235
|
...ARRAY_MUTATION_METHOD_NAMES,
|
|
6109
6236
|
"pop",
|
|
@@ -8675,7 +8802,7 @@ const resolveStableOptionsObject = (expression, observedPropertyNames, scopes, r
|
|
|
8675
8802
|
//#endregion
|
|
8676
8803
|
//#region src/plugin/rules/state-and-effects/class-component-missing-component-will-unmount-teardown.ts
|
|
8677
8804
|
const MESSAGE$89 = "This class registers a listener or timer during mount without a matching teardown on every unmount path, so it can keep firing after the component unmounts; release it in `componentWillUnmount`.";
|
|
8678
|
-
const GLOBAL_OBJECT_NAMES$
|
|
8805
|
+
const GLOBAL_OBJECT_NAMES$4 = new Set([
|
|
8679
8806
|
"window",
|
|
8680
8807
|
"globalThis",
|
|
8681
8808
|
"global",
|
|
@@ -8834,14 +8961,14 @@ const getTimerIdentifierAliasName = (identifier, scopes, visitedSymbolIds = /* @
|
|
|
8834
8961
|
const property = symbol.bindingIdentifier.parent;
|
|
8835
8962
|
const objectPattern = property?.parent;
|
|
8836
8963
|
const source = declaration.init ? stripParenExpression(declaration.init) : null;
|
|
8837
|
-
if (isNodeOfType(property, "Property") && isNodeOfType(objectPattern, "ObjectPattern") && isNodeOfType(source, "Identifier") && GLOBAL_OBJECT_NAMES$
|
|
8964
|
+
if (isNodeOfType(property, "Property") && isNodeOfType(objectPattern, "ObjectPattern") && isNodeOfType(source, "Identifier") && GLOBAL_OBJECT_NAMES$4.has(source.name) && scopes.isGlobalReference(source)) return getStaticPropertyKeyName(property, { allowComputedString: true });
|
|
8838
8965
|
return null;
|
|
8839
8966
|
}
|
|
8840
8967
|
const initializer = symbol.initializer ? stripParenExpression(symbol.initializer) : null;
|
|
8841
8968
|
if (isNodeOfType(initializer, "Identifier")) return getTimerIdentifierAliasName(initializer, scopes, visitedSymbolIds);
|
|
8842
8969
|
if (!isNodeOfType(initializer, "MemberExpression")) return null;
|
|
8843
8970
|
const receiver = stripParenExpression(initializer.object);
|
|
8844
|
-
return isNodeOfType(receiver, "Identifier") && GLOBAL_OBJECT_NAMES$
|
|
8971
|
+
return isNodeOfType(receiver, "Identifier") && GLOBAL_OBJECT_NAMES$4.has(receiver.name) && scopes.isGlobalReference(receiver) ? getStaticPropertyName(initializer) : null;
|
|
8845
8972
|
};
|
|
8846
8973
|
const getTimerCalleeName = (node, scopes) => {
|
|
8847
8974
|
if (!isNodeOfType(node, "CallExpression")) return null;
|
|
@@ -8849,7 +8976,7 @@ const getTimerCalleeName = (node, scopes) => {
|
|
|
8849
8976
|
if (getBareCalleeName(node) && isNodeOfType(callee, "Identifier")) return getTimerIdentifierAliasName(callee, scopes);
|
|
8850
8977
|
if (!isNodeOfType(callee, "MemberExpression")) return null;
|
|
8851
8978
|
const receiver = stripParenExpression(callee.object);
|
|
8852
|
-
if (!isNodeOfType(receiver, "Identifier") || !GLOBAL_OBJECT_NAMES$
|
|
8979
|
+
if (!isNodeOfType(receiver, "Identifier") || !GLOBAL_OBJECT_NAMES$4.has(receiver.name) || findVariableInitializer(receiver, receiver.name)) return null;
|
|
8853
8980
|
return getStaticPropertyName(callee);
|
|
8854
8981
|
};
|
|
8855
8982
|
const getClassMemberName$1 = (member) => {
|
|
@@ -10045,6 +10172,12 @@ const FOCUS_FORWARDING_METHOD_NAMES = new Set([
|
|
|
10045
10172
|
"preventDefault",
|
|
10046
10173
|
"stopImmediatePropagation"
|
|
10047
10174
|
]);
|
|
10175
|
+
const DOM_QUERY_METHOD_NAMES = new Set(["getElementById", "querySelector"]);
|
|
10176
|
+
const GLOBAL_OBJECT_NAMES$3 = new Set([
|
|
10177
|
+
"global",
|
|
10178
|
+
"globalThis",
|
|
10179
|
+
"window"
|
|
10180
|
+
]);
|
|
10048
10181
|
const isFocusForwardingCall = (node) => {
|
|
10049
10182
|
if (!node) return false;
|
|
10050
10183
|
const inner = isNodeOfType(node, "ChainExpression") ? node.expression : node;
|
|
@@ -10054,6 +10187,12 @@ const isFocusForwardingCall = (node) => {
|
|
|
10054
10187
|
if (!isNodeOfType(callee.property, "Identifier")) return false;
|
|
10055
10188
|
return FOCUS_FORWARDING_METHOD_NAMES.has(callee.property.name);
|
|
10056
10189
|
};
|
|
10190
|
+
const isGlobalDocumentExpression = (expression, scopes) => {
|
|
10191
|
+
const candidate = stripParenExpression(expression);
|
|
10192
|
+
if (isNodeOfType(candidate, "Identifier")) return candidate.name === "document" && scopes.isGlobalReference(candidate);
|
|
10193
|
+
if (!isNodeOfType(candidate, "MemberExpression") || !isNodeOfType(candidate.object, "Identifier") || !isNodeOfType(candidate.property, "Identifier") || candidate.property.name !== "document") return false;
|
|
10194
|
+
return GLOBAL_OBJECT_NAMES$3.has(candidate.object.name) && scopes.isGlobalReference(candidate.object);
|
|
10195
|
+
};
|
|
10057
10196
|
const isFocusForwardingFunctionBody = (body) => {
|
|
10058
10197
|
if (!body) return false;
|
|
10059
10198
|
if (isFocusForwardingCall(body)) return true;
|
|
@@ -10073,19 +10212,70 @@ const resolveHandlerFunction$2 = (attribute) => {
|
|
|
10073
10212
|
return resolveHandlerFunctionExpression(attribute.value.expression);
|
|
10074
10213
|
};
|
|
10075
10214
|
const resolveHandlerFunctionExpression = (handlerExpression) => {
|
|
10076
|
-
let expression = handlerExpression;
|
|
10215
|
+
let expression = stripParenExpression(handlerExpression);
|
|
10077
10216
|
if (isNodeOfType(expression, "Identifier")) {
|
|
10078
10217
|
const binding = findVariableInitializer(expression, expression.name);
|
|
10079
10218
|
if (!binding?.initializer) return null;
|
|
10080
|
-
expression = binding.initializer;
|
|
10219
|
+
expression = stripParenExpression(binding.initializer);
|
|
10081
10220
|
}
|
|
10082
10221
|
if (isNodeOfType(expression, "ArrowFunctionExpression") || isNodeOfType(expression, "FunctionExpression") || isNodeOfType(expression, "FunctionDeclaration")) return expression;
|
|
10083
10222
|
return null;
|
|
10084
10223
|
};
|
|
10085
|
-
const
|
|
10224
|
+
const isEmptyReturn = (statement) => isNodeOfType(statement, "ReturnStatement") && statement.argument === null;
|
|
10225
|
+
const isClosestEarlyReturn = (statement) => {
|
|
10226
|
+
if (!isNodeOfType(statement, "IfStatement") || statement.alternate) return false;
|
|
10227
|
+
const consequent = statement.consequent;
|
|
10228
|
+
if (!(isNodeOfType(consequent, "BlockStatement") ? consequent.body.length === 1 && isEmptyReturn(consequent.body[0]) : isEmptyReturn(consequent))) return false;
|
|
10229
|
+
const test = stripParenExpression(statement.test);
|
|
10230
|
+
const call = isNodeOfType(test, "ChainExpression") ? test.expression : test;
|
|
10231
|
+
if (!isNodeOfType(call, "CallExpression") || call.arguments.length !== 1) return false;
|
|
10232
|
+
const callee = stripParenExpression(call.callee);
|
|
10233
|
+
const receiver = isNodeOfType(callee, "MemberExpression") ? stripParenExpression(callee.object) : null;
|
|
10234
|
+
return isNodeOfType(callee, "MemberExpression") && isNodeOfType(callee.property, "Identifier") && callee.property.name === "closest" && isNodeOfType(receiver, "MemberExpression") && isNodeOfType(receiver.object, "Identifier") && isNodeOfType(receiver.property, "Identifier") && receiver.property.name === "target" && isNodeOfType(call.arguments[0], "Literal") && typeof call.arguments[0].value === "string";
|
|
10235
|
+
};
|
|
10236
|
+
const isStaticSelectorExpression = (expression) => {
|
|
10237
|
+
const candidate = stripParenExpression(expression);
|
|
10238
|
+
if (isNodeOfType(candidate, "Identifier") || isNodeOfType(candidate, "Literal")) return true;
|
|
10239
|
+
return isNodeOfType(candidate, "TemplateLiteral") && candidate.expressions.every((innerExpression) => isStaticSelectorExpression(innerExpression));
|
|
10240
|
+
};
|
|
10241
|
+
const getDomQueryVariableName = (statement, scopes) => {
|
|
10242
|
+
if (!isNodeOfType(statement, "VariableDeclaration") || statement.kind !== "const" || statement.declarations.length !== 1) return null;
|
|
10243
|
+
const declaration = statement.declarations[0];
|
|
10244
|
+
if (!declaration || !isNodeOfType(declaration.id, "Identifier") || !declaration.init) return null;
|
|
10245
|
+
const initializer = stripParenExpression(declaration.init);
|
|
10246
|
+
if (!isNodeOfType(initializer, "CallExpression") || initializer.arguments.length !== 1 || isNodeOfType(initializer.arguments[0], "SpreadElement") || !isStaticSelectorExpression(initializer.arguments[0])) return null;
|
|
10247
|
+
const callee = stripParenExpression(initializer.callee);
|
|
10248
|
+
if (!isNodeOfType(callee, "MemberExpression") || !isNodeOfType(callee.property, "Identifier") || !DOM_QUERY_METHOD_NAMES.has(callee.property.name) || !isGlobalDocumentExpression(callee.object, scopes)) return null;
|
|
10249
|
+
return declaration.id.name;
|
|
10250
|
+
};
|
|
10251
|
+
const isFocusCallOnVariable = (statement, variableName) => {
|
|
10252
|
+
if (!isNodeOfType(statement, "ExpressionStatement")) return false;
|
|
10253
|
+
const expression = stripParenExpression(statement.expression);
|
|
10254
|
+
if (!isNodeOfType(expression, "CallExpression")) return false;
|
|
10255
|
+
const callee = stripParenExpression(expression.callee);
|
|
10256
|
+
if (!isNodeOfType(callee, "MemberExpression")) return false;
|
|
10257
|
+
const receiver = stripParenExpression(callee.object);
|
|
10258
|
+
return isNodeOfType(receiver, "Identifier") && receiver.name === variableName && isNodeOfType(callee.property, "Identifier") && callee.property.name === "focus" && expression.arguments.length === 0;
|
|
10259
|
+
};
|
|
10260
|
+
const isConditionalFocusForwardingHandler = (attribute, scopes) => {
|
|
10261
|
+
if (!attribute.value || !isNodeOfType(attribute.value, "JSXExpressionContainer")) return false;
|
|
10262
|
+
const expression = stripParenExpression(attribute.value.expression);
|
|
10263
|
+
if (!isNodeOfType(expression, "ConditionalExpression")) return false;
|
|
10264
|
+
const consequent = stripParenExpression(expression.consequent);
|
|
10265
|
+
const alternate = stripParenExpression(expression.alternate);
|
|
10266
|
+
const nullishBranch = isNullishExpression$2(consequent) ? consequent : alternate;
|
|
10267
|
+
if (!isNullishExpression$2(nullishBranch) || isNodeOfType(nullishBranch, "Identifier") && !scopes.isGlobalReference(nullishBranch)) return false;
|
|
10268
|
+
const handlerFunction = resolveHandlerFunctionExpression(nullishBranch === consequent ? alternate : consequent);
|
|
10269
|
+
if (!handlerFunction || !isNodeOfType(handlerFunction.body, "BlockStatement")) return false;
|
|
10270
|
+
const [guard, query, focus, ...rest] = handlerFunction.body.body;
|
|
10271
|
+
if (!guard || !query || !focus || rest.length > 0 || !isClosestEarlyReturn(guard)) return false;
|
|
10272
|
+
const queryVariableName = getDomQueryVariableName(query, scopes);
|
|
10273
|
+
return Boolean(queryVariableName && isFocusCallOnVariable(focus, queryVariableName));
|
|
10274
|
+
};
|
|
10275
|
+
const isFocusForwardingHandler = (attribute, scopes) => {
|
|
10276
|
+
if (isConditionalFocusForwardingHandler(attribute, scopes)) return true;
|
|
10086
10277
|
const handlerFunction = resolveHandlerFunction$2(attribute);
|
|
10087
|
-
|
|
10088
|
-
return isFocusForwardingFunctionBody(handlerFunction.body ?? null);
|
|
10278
|
+
return Boolean(handlerFunction && isFocusForwardingFunctionBody(handlerFunction.body ?? null));
|
|
10089
10279
|
};
|
|
10090
10280
|
const COMPOSITE_ITEM_ROLES$1 = new Set([
|
|
10091
10281
|
"option",
|
|
@@ -10155,7 +10345,7 @@ const clickEventsHaveKeyEvents = defineRule({
|
|
|
10155
10345
|
const spreadOnClickExpression = CLICK_HANDLERS.map((name) => spreadEventValues.get(name.toLowerCase())).find((expression) => expression !== void 0);
|
|
10156
10346
|
if (!onClick && !spreadOnClickExpression) return;
|
|
10157
10347
|
if (onClick && isPureEventBlockerHandler(onClick)) return;
|
|
10158
|
-
if (onClick && isFocusForwardingHandler(onClick)) return;
|
|
10348
|
+
if (onClick && isFocusForwardingHandler(onClick, context.scopes)) return;
|
|
10159
10349
|
const spreadHandlerFunction = spreadOnClickExpression ? resolveHandlerFunctionExpression(spreadOnClickExpression) : null;
|
|
10160
10350
|
if (spreadHandlerFunction && (isFocusForwardingFunctionBody(spreadHandlerFunction.body ?? null) || containsBackdropDismissComparison(spreadHandlerFunction.body ?? null))) return;
|
|
10161
10351
|
if (hasCompositeItemRole(node)) return;
|
|
@@ -17809,6 +17999,14 @@ const findRenderPhaseComponentOrHook = (node, scopes) => {
|
|
|
17809
17999
|
//#region src/plugin/utils/is-event-handler-attribute.ts
|
|
17810
18000
|
const isEventHandlerAttribute = (node) => isNodeOfType(node, "JSXAttribute") && isNodeOfType(node.name, "JSXIdentifier") && /^on[A-Z]/.test(node.name.name);
|
|
17811
18001
|
//#endregion
|
|
18002
|
+
//#region src/plugin/utils/is-early-exit-statement.ts
|
|
18003
|
+
const isEarlyExitStatement$1 = (statement) => {
|
|
18004
|
+
if (!statement) return false;
|
|
18005
|
+
if (statementAlwaysExits$1(statement)) return true;
|
|
18006
|
+
if (isNodeOfType(statement, "BlockStatement")) return isEarlyExitStatement$1(statement.body.at(-1));
|
|
18007
|
+
return isNodeOfType(statement, "ContinueStatement") || isNodeOfType(statement, "BreakStatement");
|
|
18008
|
+
};
|
|
18009
|
+
//#endregion
|
|
17812
18010
|
//#region src/plugin/utils/is-ast-descendant.ts
|
|
17813
18011
|
/**
|
|
17814
18012
|
* True when `inner` is `outer` itself or any descendant in the AST
|
|
@@ -18027,13 +18225,15 @@ const isSynchronousIteratorCall = (callNode, callbackArgument, scopes) => {
|
|
|
18027
18225
|
}
|
|
18028
18226
|
return Boolean(methodName && EAGER_ITERATOR_METHOD_NAMES.has(methodName) && callNode.arguments[0] === callbackArgument && !isProvablyEmptyEagerCollection(callee.object, scopes) && (methodName === "forEach" ? isProvablyEagerForEachCollection(callee.object, scopes) : isProvablyEagerCollection(callee.object, scopes)));
|
|
18029
18227
|
};
|
|
18030
|
-
const
|
|
18031
|
-
const callNode = functionNode.parent;
|
|
18032
|
-
if (!isNodeOfType(callNode, "CallExpression")) return false;
|
|
18228
|
+
const isSynchronousIteratorCallbackCall = (callNode, callbackArgument) => {
|
|
18033
18229
|
const callee = stripParenExpression(callNode.callee);
|
|
18034
18230
|
if (!isNodeOfType(callee, "MemberExpression") || callee.computed || !isNodeOfType(callee.property, "Identifier")) return false;
|
|
18035
|
-
if (isNodeOfType(callee.object, "Identifier") && callee.object.name === "Array" && callee.property.name === "from") return callNode.arguments[1] ===
|
|
18036
|
-
return SYNCHRONOUS_ITERATOR_METHOD_NAMES$2.has(callee.property.name) && callNode.arguments[0] ===
|
|
18231
|
+
if (isNodeOfType(callee.object, "Identifier") && callee.object.name === "Array" && callee.property.name === "from") return callNode.arguments[1] === callbackArgument;
|
|
18232
|
+
return SYNCHRONOUS_ITERATOR_METHOD_NAMES$2.has(callee.property.name) && callNode.arguments[0] === callbackArgument;
|
|
18233
|
+
};
|
|
18234
|
+
const isSynchronousIteratorCallback = (functionNode) => {
|
|
18235
|
+
const callNode = functionNode.parent;
|
|
18236
|
+
return Boolean(isNodeOfType(callNode, "CallExpression") && isSynchronousIteratorCallbackCall(callNode, functionNode));
|
|
18037
18237
|
};
|
|
18038
18238
|
//#endregion
|
|
18039
18239
|
//#region src/plugin/utils/is-within-assignment-target.ts
|
|
@@ -18153,11 +18353,35 @@ const resolveEventListenerCaptureValueIdentityKey = (expression, context) => {
|
|
|
18153
18353
|
const rightIdentityKey = resolveEventListenerCaptureValueIdentityKey(unwrappedExpression.right, context);
|
|
18154
18354
|
return leftIdentityKey && rightIdentityKey ? `${unwrappedExpression.type}:${unwrappedExpression.operator}:${leftIdentityKey}:${rightIdentityKey}` : null;
|
|
18155
18355
|
};
|
|
18356
|
+
const resolveReadOnlyEventListenerOptions = (optionsNode, context) => {
|
|
18357
|
+
const unwrappedOptions = stripParenExpression(optionsNode);
|
|
18358
|
+
if (!isNodeOfType(unwrappedOptions, "Identifier")) return resolveStableValue(unwrappedOptions, context);
|
|
18359
|
+
const optionsSymbol = context.scopes.symbolFor(unwrappedOptions);
|
|
18360
|
+
const initializer = optionsSymbol?.initializer ? stripParenExpression(optionsSymbol.initializer) : null;
|
|
18361
|
+
if (!optionsSymbol || !initializer) return resolveStableValue(unwrappedOptions, context);
|
|
18362
|
+
if (!isNodeOfType(initializer, "ObjectExpression")) {
|
|
18363
|
+
if (isNodeOfType(initializer, "Identifier") || isNodeOfType(initializer, "MemberExpression")) return null;
|
|
18364
|
+
return resolveStableValue(unwrappedOptions, context);
|
|
18365
|
+
}
|
|
18366
|
+
if (optionsSymbol.kind !== "const") return null;
|
|
18367
|
+
return optionsSymbol.references.every((reference) => {
|
|
18368
|
+
if (reference.flag !== "read" || isWithinAssignmentTarget(reference.identifier)) return false;
|
|
18369
|
+
const referenceRoot = findTransparentExpressionRoot(reference.identifier);
|
|
18370
|
+
const callNode = referenceRoot.parent;
|
|
18371
|
+
if (!isNodeOfType(callNode, "CallExpression") || callNode.arguments[2] !== referenceRoot) return false;
|
|
18372
|
+
const callee = stripParenExpression(callNode.callee);
|
|
18373
|
+
if (!isNodeOfType(callee, "MemberExpression")) return false;
|
|
18374
|
+
const methodName = getStaticPropertyKeyName(callee);
|
|
18375
|
+
return methodName === "addEventListener" || methodName === "removeEventListener";
|
|
18376
|
+
}) ? initializer : null;
|
|
18377
|
+
};
|
|
18156
18378
|
const resolveEventListenerCaptureIdentityKey = (optionsNode, context, allowOpaqueOptionsIdentity) => {
|
|
18157
|
-
const
|
|
18379
|
+
const stableOptionsNode = optionsNode ? resolveReadOnlyEventListenerOptions(optionsNode, context) : null;
|
|
18380
|
+
if (optionsNode && !stableOptionsNode) return null;
|
|
18381
|
+
const capture = resolveEventListenerCapture(stableOptionsNode, { allowIndeterminateEntries: true });
|
|
18158
18382
|
if (capture !== null) return `capture:${String(capture)}`;
|
|
18159
|
-
if (!
|
|
18160
|
-
const unwrappedOptions = stripParenExpression(
|
|
18383
|
+
if (!stableOptionsNode) return null;
|
|
18384
|
+
const unwrappedOptions = stripParenExpression(stableOptionsNode);
|
|
18161
18385
|
if (!isNodeOfType(unwrappedOptions, "ObjectExpression")) {
|
|
18162
18386
|
const optionsKey = allowOpaqueOptionsIdentity ? resolveEventListenerCaptureValueIdentityKey(unwrappedOptions, context) : null;
|
|
18163
18387
|
return optionsKey ? `options:${optionsKey}` : null;
|
|
@@ -18204,12 +18428,8 @@ const doEventListenerCapturesMatch = (registrationOptions, releaseOptions, conte
|
|
|
18204
18428
|
return registrationCaptureKey !== null && registrationCaptureKey === resolveEventListenerCaptureIdentityKey(releaseOptions, context, allowOpaqueOptionsIdentity);
|
|
18205
18429
|
};
|
|
18206
18430
|
const findAssignedResourceKey = (resourceNode, context) => {
|
|
18207
|
-
|
|
18208
|
-
|
|
18209
|
-
while (isNodeOfType(parentNode, "ChainExpression")) {
|
|
18210
|
-
currentNode = parentNode;
|
|
18211
|
-
parentNode = currentNode.parent;
|
|
18212
|
-
}
|
|
18431
|
+
const currentNode = findTransparentExpressionRoot(resourceNode);
|
|
18432
|
+
const parentNode = currentNode.parent;
|
|
18213
18433
|
if (isNodeOfType(parentNode, "VariableDeclarator") && parentNode.init === currentNode) return resolveExpressionKey(parentNode.id, context);
|
|
18214
18434
|
if (isNodeOfType(parentNode, "AssignmentExpression") && parentNode.right === currentNode) return resolveExpressionKey(parentNode.left, context);
|
|
18215
18435
|
return null;
|
|
@@ -18480,6 +18700,18 @@ const resolveIteratorCollectionKey = (expression, context) => {
|
|
|
18480
18700
|
}
|
|
18481
18701
|
return null;
|
|
18482
18702
|
};
|
|
18703
|
+
const resolveReceiverIteratorCollectionKey = (expression, context) => {
|
|
18704
|
+
if (!expression) return null;
|
|
18705
|
+
const unwrappedExpression = stripParenExpression(expression);
|
|
18706
|
+
if (!isNodeOfType(unwrappedExpression, "Identifier")) return null;
|
|
18707
|
+
const collectionExpression = findForOfStatementForIteratorExpression(unwrappedExpression, context)?.right;
|
|
18708
|
+
if (!collectionExpression) return null;
|
|
18709
|
+
const collectionIdentifier = stripParenExpression(collectionExpression);
|
|
18710
|
+
if (!isNodeOfType(collectionIdentifier, "Identifier") || !isPrivatePlainConstIdentifier(collectionIdentifier, context)) return null;
|
|
18711
|
+
const collectionSymbol = context.scopes.symbolFor(collectionIdentifier);
|
|
18712
|
+
const initializer = collectionSymbol?.initializer ? stripParenExpression(collectionSymbol.initializer) : null;
|
|
18713
|
+
return collectionSymbol && isNodeOfType(initializer, "ArrayExpression") && hasOnlyReplayableCollectionReferences(collectionIdentifier, context, /* @__PURE__ */ new Set()) ? `symbol:${collectionSymbol.id}` : null;
|
|
18714
|
+
};
|
|
18483
18715
|
const isStableLoopReceiver = (expression, context) => {
|
|
18484
18716
|
if (!expression) return false;
|
|
18485
18717
|
const unwrappedExpression = stripParenExpression(expression);
|
|
@@ -19250,6 +19482,28 @@ const isFunctionReturnedFromReactHook = (functionNode, context, requireRefProper
|
|
|
19250
19482
|
});
|
|
19251
19483
|
};
|
|
19252
19484
|
const isFunctionUsedAsReactRef = (functionNode, context) => isFunctionForwardedToReactRef(functionNode, context) || isFunctionReturnedFromReactHook(functionNode, context, true);
|
|
19485
|
+
const findCallbackRefReplacementReleaseGuard = (releaseCall, ownerFunction, releaseReceiverKey, registrationReceiverKey, context) => {
|
|
19486
|
+
let descendant = releaseCall;
|
|
19487
|
+
let ancestor = descendant.parent;
|
|
19488
|
+
while (ancestor && ancestor !== ownerFunction) {
|
|
19489
|
+
if (isNodeOfType(ancestor, "IfStatement") && ancestor.consequent === descendant && ancestor.alternate === null) {
|
|
19490
|
+
const test = stripParenExpression(ancestor.test);
|
|
19491
|
+
if (!isNodeOfType(test, "LogicalExpression") || test.operator !== "&&") return null;
|
|
19492
|
+
const operands = [stripParenExpression(test.left), stripParenExpression(test.right)];
|
|
19493
|
+
const hasLiveReceiverTest = operands.some((operand) => doesTestRequireLiveExpressionKey(operand, releaseReceiverKey, context));
|
|
19494
|
+
const hasDifferentReceiverTest = operands.some((operand) => {
|
|
19495
|
+
if (!isNodeOfType(operand, "BinaryExpression") || operand.operator !== "!==" && operand.operator !== "!=") return false;
|
|
19496
|
+
const leftKey = resolveExpressionKey(operand.left, context);
|
|
19497
|
+
const rightKey = resolveExpressionKey(operand.right, context);
|
|
19498
|
+
return leftKey === releaseReceiverKey && rightKey === registrationReceiverKey || rightKey === releaseReceiverKey && leftKey === registrationReceiverKey;
|
|
19499
|
+
});
|
|
19500
|
+
return hasLiveReceiverTest && hasDifferentReceiverTest ? ancestor : null;
|
|
19501
|
+
}
|
|
19502
|
+
descendant = ancestor;
|
|
19503
|
+
ancestor = descendant.parent;
|
|
19504
|
+
}
|
|
19505
|
+
return null;
|
|
19506
|
+
};
|
|
19253
19507
|
const isReactRefListenerReplacementRelease = (releaseCall, usage, context) => {
|
|
19254
19508
|
if (!isNodeOfType(usage.node, "CallExpression")) return false;
|
|
19255
19509
|
const usageFunction = findEnclosingFunction$1(usage.node);
|
|
@@ -19270,7 +19524,7 @@ const isReactRefListenerReplacementRelease = (releaseCall, usage, context) => {
|
|
|
19270
19524
|
if (child !== usageFunctionBody && isFunctionLike$1(child)) return false;
|
|
19271
19525
|
if (isNodeOfType(child, "AssignmentExpression") && child.operator === "=" && resolveReactRefSymbol(stripParenExpression(child.left), context.scopes)?.id === releaseRefSymbol.id && resolveExpressionKey(child.right, context) === registrationReceiverKey && releaseStart !== null && (getRangeStart(child) ?? -1) > releaseStart) matchingOwnershipAssignments.push(child);
|
|
19272
19526
|
});
|
|
19273
|
-
const releaseAnchor = findLiveExpressionGuardForRelease(releaseCall, usageFunction, releaseReceiverKey, context) ?? releaseCall;
|
|
19527
|
+
const releaseAnchor = findLiveExpressionGuardForRelease(releaseCall, usageFunction, releaseReceiverKey, context) ?? findCallbackRefReplacementReleaseGuard(releaseCall, usageFunction, releaseReceiverKey, registrationReceiverKey, context) ?? releaseCall;
|
|
19274
19528
|
const safeOwnershipAssignments = matchingOwnershipAssignments.filter((assignment) => doMatchingNodesCoverEveryPathBeforeUsage(assignment, [releaseAnchor], usageFunction, context));
|
|
19275
19529
|
return doNodesCoverEveryPathFromFunctionEntry(usageFunction, [releaseAnchor], context) && doMatchingNodesCoverEveryPathBeforeUsage(usage.node, safeOwnershipAssignments, usageFunction, context);
|
|
19276
19530
|
};
|
|
@@ -19420,14 +19674,21 @@ const doesReleaseCallMatchUsage = (node, usage, context) => {
|
|
|
19420
19674
|
if (usage.kind === "socket") return usage.handleKey !== null && releaseReceiverKey === usage.handleKey && (SOCKET_RELEASE_VERB_NAMES.has(releaseVerbName) || UNIVERSAL_RELEASE_VERB_NAMES.has(releaseVerbName));
|
|
19421
19675
|
if (usage.handleKey !== null && releaseReceiverKey === usage.handleKey && (releaseVerbName === "unsubscribe" || releaseVerbName === "unsub" || releaseVerbName === "close" || releaseVerbName === "unwatch" || releaseVerbName === "unlisten" || BOUND_RESOURCE_RELEASE_METHOD_NAMES.has(releaseVerbName))) return true;
|
|
19422
19676
|
if (releaseVerbName === "abort" && releaseReceiverKey === getListenerAbortControllerKey(usage, context)) return true;
|
|
19423
|
-
if (usage.registrationVerbName === "addListener" && isNodeOfType(usage.node, "CallExpression") && usage.node.arguments?.length === 1) return isProvenLegacyMediaQueryListMethodCall(usage.node, "addListener", context) && releaseVerbName === "removeListener" && isProvenLegacyMediaQueryListMethodCall(callNode, "removeListener", context) && usage.receiverKey !== null && resolveStableMediaQueryListenerIdentityKey(callee.object, context) === usage.receiverKey && usage.handlerKey !== null && resolveStableMediaQueryListenerIdentityKey(callNode.arguments?.[0], context) === usage.handlerKey;
|
|
19424
19677
|
if (releaseVerbName === "abort" && isRetainedAbortControllerRefRelease(callee.object, usage, context)) return true;
|
|
19678
|
+
if (usage.registrationVerbName === "addListener" && releaseVerbName === "removeListener" && isNodeOfType(usage.node, "CallExpression") && usage.node.arguments?.length === 1) {
|
|
19679
|
+
if (callNode.arguments?.length !== 1) return false;
|
|
19680
|
+
const registrationHandler = resolveStableValue(usage.node.arguments[0], context);
|
|
19681
|
+
if (!isProvenLegacyMediaQueryListMethodCall(usage.node, "addListener", context) && !isFunctionLike$1(registrationHandler)) return false;
|
|
19682
|
+
}
|
|
19425
19683
|
if (usage.registrationVerbName === "addEventListener" && releaseVerbName === "removeEventListener" && isNodeOfType(usage.node, "CallExpression")) {
|
|
19426
19684
|
if (!isNodeOfType(stripParenExpression(usage.node.callee), "MemberExpression")) return false;
|
|
19427
19685
|
if (!doEventListenerCapturesMatch(usage.node.arguments?.[2], callNode.arguments?.[2], context, true)) return false;
|
|
19428
19686
|
}
|
|
19429
19687
|
if (isNodeOfType(usage.node, "CallExpression") && !hasSafeForEachProjectionCleanup(usage.node, callNode, context)) return false;
|
|
19430
|
-
|
|
19688
|
+
const registrationCallee = isNodeOfType(usage.node, "CallExpression") ? stripParenExpression(usage.node.callee) : null;
|
|
19689
|
+
const registrationReceiverCollectionKey = isNodeOfType(registrationCallee, "MemberExpression") ? resolveReceiverIteratorCollectionKey(registrationCallee.object, context) : null;
|
|
19690
|
+
const releaseReceiverCollectionKeyForPair = resolveReceiverIteratorCollectionKey(callee.object, context);
|
|
19691
|
+
if (!(registrationReceiverCollectionKey !== null && registrationReceiverCollectionKey === releaseReceiverCollectionKeyForPair) && (usage.receiverKey === null || releaseReceiverKey !== usage.receiverKey)) return false;
|
|
19431
19692
|
if (usage.registrationVerbName === "subscribe" && (releaseVerbName === "unsubscribe" || releaseVerbName === "unsub") && usage.handleKey !== null && resolveExpressionKey(callNode.arguments?.[0], context) === usage.handleKey) return true;
|
|
19432
19693
|
const pairedVerbNames = usage.registrationVerbName ? PAIRED_RELEASE_VERB_NAMES_BY_REGISTRATION_VERB.get(usage.registrationVerbName) : null;
|
|
19433
19694
|
if (!pairedVerbNames || !matchesPairedReleaseVerb(releaseVerbName, pairedVerbNames)) return false;
|
|
@@ -19464,7 +19725,7 @@ const doesReleaseCallMatchUsage = (node, usage, context) => {
|
|
|
19464
19725
|
const usesUnaryListenerSignatureForCalls = isNodeOfType(usage.node, "CallExpression") && usesUnaryListenerSignature(usage.node, callNode);
|
|
19465
19726
|
const releaseHandler = usesUnaryListenerSignatureForCalls ? callNode.arguments?.[0] : callNode.arguments?.[1];
|
|
19466
19727
|
if (!releaseHandler) return releaseVerbName === "off";
|
|
19467
|
-
const expectedHandlerKey = usesUnaryListenerSignatureForCalls ? usage.eventKey : usage.handlerKey;
|
|
19728
|
+
const expectedHandlerKey = usesUnaryListenerSignatureForCalls ? usage.handlerKey ?? usage.eventKey : usage.handlerKey;
|
|
19468
19729
|
const registrationHandler = isNodeOfType(usage.node, "CallExpression") ? usage.node.arguments?.[usesUnaryListenerSignatureForCalls ? 0 : 1] : null;
|
|
19469
19730
|
return expectedHandlerKey !== null && resolveResourceIdentityKey(releaseHandler, context) === expectedHandlerKey || registrationHandler !== null && resolveStableValue(releaseHandler, context) === resolveStableValue(registrationHandler, context);
|
|
19470
19731
|
}
|
|
@@ -19938,6 +20199,7 @@ const findRetainedFunctionLeak = (retainedFunction, context, options) => {
|
|
|
19938
20199
|
walkAst(body, (child) => {
|
|
19939
20200
|
if (leak !== null) return false;
|
|
19940
20201
|
if (isFunctionLike$1(child)) return false;
|
|
20202
|
+
if (!isNodeReachableWithinFunction(child, context)) return false;
|
|
19941
20203
|
if (isSocketConstruction(child) && !doesResourceResultEscape(child, allowReturnedSocketEscape, false, context)) {
|
|
19942
20204
|
const socketUsage = {
|
|
19943
20205
|
kind: "socket",
|
|
@@ -20190,6 +20452,164 @@ const isInlineRetainedHandlerFunction = (functionNode, context) => {
|
|
|
20190
20452
|
const objectParent = objectExpression.parent;
|
|
20191
20453
|
return (isNodeOfType(objectParent, "CallExpression") && objectParent.arguments.some((argument) => argument === objectExpression) || isNodeOfType(objectParent, "JSXExpressionContainer")) && findRenderPhaseComponentOrHook(parentNode, context.scopes) !== null;
|
|
20192
20454
|
};
|
|
20455
|
+
const readInvocationArgumentValue = (expression, context) => {
|
|
20456
|
+
if (!expression) return {
|
|
20457
|
+
isDefinitelyUndefined: true,
|
|
20458
|
+
truthiness: "falsy"
|
|
20459
|
+
};
|
|
20460
|
+
const target = stripParenExpression(expression);
|
|
20461
|
+
if (isNodeOfType(target, "Literal")) return {
|
|
20462
|
+
isDefinitelyUndefined: false,
|
|
20463
|
+
truthiness: target.value ? "truthy" : "falsy"
|
|
20464
|
+
};
|
|
20465
|
+
if (isNodeOfType(target, "Identifier") && target.name === "undefined" && context.scopes.isGlobalReference(target)) return {
|
|
20466
|
+
isDefinitelyUndefined: true,
|
|
20467
|
+
truthiness: "falsy"
|
|
20468
|
+
};
|
|
20469
|
+
if (isNodeOfType(target, "UnaryExpression") && target.operator === "void") return {
|
|
20470
|
+
isDefinitelyUndefined: true,
|
|
20471
|
+
truthiness: "falsy"
|
|
20472
|
+
};
|
|
20473
|
+
if (isNodeOfType(target, "ArrayExpression") || isNodeOfType(target, "ArrowFunctionExpression") || isNodeOfType(target, "ClassExpression") || isNodeOfType(target, "FunctionExpression") || isNodeOfType(target, "NewExpression") || isNodeOfType(target, "ObjectExpression")) return {
|
|
20474
|
+
isDefinitelyUndefined: false,
|
|
20475
|
+
truthiness: "truthy"
|
|
20476
|
+
};
|
|
20477
|
+
return {
|
|
20478
|
+
isDefinitelyUndefined: false,
|
|
20479
|
+
truthiness: "unknown"
|
|
20480
|
+
};
|
|
20481
|
+
};
|
|
20482
|
+
const readInvocationConditionTruthiness = (expression, parameterValues, context) => {
|
|
20483
|
+
const target = stripParenExpression(expression);
|
|
20484
|
+
const atomicValue = readInvocationArgumentValue(target, context);
|
|
20485
|
+
if (atomicValue.truthiness !== "unknown") return atomicValue.truthiness;
|
|
20486
|
+
if (isNodeOfType(target, "Identifier")) {
|
|
20487
|
+
const symbol = context.scopes.symbolFor(target);
|
|
20488
|
+
return symbol ? parameterValues.get(symbol.id)?.truthiness ?? "unknown" : "unknown";
|
|
20489
|
+
}
|
|
20490
|
+
if (isNodeOfType(target, "UnaryExpression") && target.operator === "!") {
|
|
20491
|
+
const argumentTruthiness = readInvocationConditionTruthiness(target.argument, parameterValues, context);
|
|
20492
|
+
return argumentTruthiness === "truthy" ? "falsy" : argumentTruthiness === "falsy" ? "truthy" : "unknown";
|
|
20493
|
+
}
|
|
20494
|
+
if (isNodeOfType(target, "LogicalExpression")) {
|
|
20495
|
+
const leftTruthiness = readInvocationConditionTruthiness(target.left, parameterValues, context);
|
|
20496
|
+
const rightTruthiness = readInvocationConditionTruthiness(target.right, parameterValues, context);
|
|
20497
|
+
if (target.operator === "&&") {
|
|
20498
|
+
if (leftTruthiness === "falsy" || rightTruthiness === "falsy") return "falsy";
|
|
20499
|
+
return leftTruthiness === "truthy" && rightTruthiness === "truthy" ? "truthy" : "unknown";
|
|
20500
|
+
}
|
|
20501
|
+
if (target.operator === "||") {
|
|
20502
|
+
if (leftTruthiness === "truthy" || rightTruthiness === "truthy") return "truthy";
|
|
20503
|
+
return leftTruthiness === "falsy" && rightTruthiness === "falsy" ? "falsy" : "unknown";
|
|
20504
|
+
}
|
|
20505
|
+
return "unknown";
|
|
20506
|
+
}
|
|
20507
|
+
if (isNodeOfType(target, "ConditionalExpression")) {
|
|
20508
|
+
const testTruthiness = readInvocationConditionTruthiness(target.test, parameterValues, context);
|
|
20509
|
+
if (testTruthiness === "truthy") return readInvocationConditionTruthiness(target.consequent, parameterValues, context);
|
|
20510
|
+
if (testTruthiness === "falsy") return readInvocationConditionTruthiness(target.alternate, parameterValues, context);
|
|
20511
|
+
const consequentTruthiness = readInvocationConditionTruthiness(target.consequent, parameterValues, context);
|
|
20512
|
+
return consequentTruthiness === readInvocationConditionTruthiness(target.alternate, parameterValues, context) ? consequentTruthiness : "unknown";
|
|
20513
|
+
}
|
|
20514
|
+
if (isNodeOfType(target, "CallExpression") && isNodeOfType(target.callee, "Identifier") && target.callee.name === "Boolean" && context.scopes.isGlobalReference(target.callee) && target.arguments[0] && isAstNode(target.arguments[0])) return readInvocationConditionTruthiness(target.arguments[0], parameterValues, context);
|
|
20515
|
+
return "unknown";
|
|
20516
|
+
};
|
|
20517
|
+
const getInvocationParameterValues = (retainedFunction, invocation, leakNode, context) => {
|
|
20518
|
+
const parameterValues = /* @__PURE__ */ new Map();
|
|
20519
|
+
if (!isFunctionLike$1(retainedFunction) || !invocation.isDirect) return parameterValues;
|
|
20520
|
+
for (const [parameterIndex, parameter] of retainedFunction.params.entries()) {
|
|
20521
|
+
const argument = invocation.call.arguments[parameterIndex];
|
|
20522
|
+
const argumentExpression = argument && isAstNode(argument) ? argument : null;
|
|
20523
|
+
let parameterIdentifier = null;
|
|
20524
|
+
let parameterValue = readInvocationArgumentValue(argumentExpression, context);
|
|
20525
|
+
if (isNodeOfType(parameter, "Identifier")) parameterIdentifier = parameter;
|
|
20526
|
+
else if (isNodeOfType(parameter, "AssignmentPattern") && isNodeOfType(parameter.left, "Identifier")) {
|
|
20527
|
+
parameterIdentifier = parameter.left;
|
|
20528
|
+
if (parameterValue.isDefinitelyUndefined) parameterValue = readInvocationArgumentValue(parameter.right, context);
|
|
20529
|
+
} else if (isNodeOfType(parameter, "RestElement") && isNodeOfType(parameter.argument, "Identifier")) {
|
|
20530
|
+
parameterIdentifier = parameter.argument;
|
|
20531
|
+
parameterValue = {
|
|
20532
|
+
isDefinitelyUndefined: false,
|
|
20533
|
+
truthiness: "truthy"
|
|
20534
|
+
};
|
|
20535
|
+
}
|
|
20536
|
+
if (!parameterIdentifier) continue;
|
|
20537
|
+
const parameterSymbol = context.scopes.symbolFor(parameterIdentifier);
|
|
20538
|
+
if (!parameterSymbol) continue;
|
|
20539
|
+
const isWrittenBeforeLeak = parameterSymbol.references.some((reference) => reference.flag !== "read" && reference.identifier.range[0] < leakNode.range[0]);
|
|
20540
|
+
parameterValues.set(parameterSymbol.id, isWrittenBeforeLeak ? {
|
|
20541
|
+
isDefinitelyUndefined: false,
|
|
20542
|
+
truthiness: "unknown"
|
|
20543
|
+
} : parameterValue);
|
|
20544
|
+
}
|
|
20545
|
+
return parameterValues;
|
|
20546
|
+
};
|
|
20547
|
+
const isLeakPathDisabledForInvocation = (retainedFunction, leakNode, invocation, context) => {
|
|
20548
|
+
if (!invocation.isDirect) return false;
|
|
20549
|
+
const parameterValues = getInvocationParameterValues(retainedFunction, invocation, leakNode, context);
|
|
20550
|
+
let child = leakNode;
|
|
20551
|
+
let ancestor = leakNode.parent ?? null;
|
|
20552
|
+
while (ancestor && ancestor !== retainedFunction) {
|
|
20553
|
+
if (isNodeOfType(ancestor, "BlockStatement")) {
|
|
20554
|
+
const childIndex = ancestor.body.findIndex((statement) => statement === child);
|
|
20555
|
+
for (const precedingStatement of ancestor.body.slice(0, childIndex)) {
|
|
20556
|
+
if (!isNodeOfType(precedingStatement, "IfStatement") || precedingStatement.alternate || !isEarlyExitStatement$1(precedingStatement.consequent)) continue;
|
|
20557
|
+
if (readInvocationConditionTruthiness(precedingStatement.test, parameterValues, context) === "truthy") return true;
|
|
20558
|
+
}
|
|
20559
|
+
}
|
|
20560
|
+
let requiredTruthiness = null;
|
|
20561
|
+
let condition = null;
|
|
20562
|
+
if (isNodeOfType(ancestor, "IfStatement")) {
|
|
20563
|
+
condition = ancestor.test;
|
|
20564
|
+
requiredTruthiness = ancestor.consequent === child ? "truthy" : "falsy";
|
|
20565
|
+
} else if (isNodeOfType(ancestor, "ConditionalExpression")) {
|
|
20566
|
+
condition = ancestor.test;
|
|
20567
|
+
requiredTruthiness = ancestor.consequent === child ? "truthy" : "falsy";
|
|
20568
|
+
} else if (isNodeOfType(ancestor, "LogicalExpression") && ancestor.right === child && ancestor.operator !== "??") {
|
|
20569
|
+
condition = ancestor.left;
|
|
20570
|
+
requiredTruthiness = ancestor.operator === "&&" ? "truthy" : "falsy";
|
|
20571
|
+
} else if ((isNodeOfType(ancestor, "WhileStatement") || isNodeOfType(ancestor, "DoWhileStatement")) && ancestor.body === child) {
|
|
20572
|
+
condition = ancestor.test;
|
|
20573
|
+
requiredTruthiness = "truthy";
|
|
20574
|
+
} else if (isNodeOfType(ancestor, "ForStatement") && ancestor.body === child && ancestor.test) {
|
|
20575
|
+
condition = ancestor.test;
|
|
20576
|
+
requiredTruthiness = "truthy";
|
|
20577
|
+
}
|
|
20578
|
+
if (condition && requiredTruthiness) {
|
|
20579
|
+
const conditionTruthiness = readInvocationConditionTruthiness(condition, parameterValues, context);
|
|
20580
|
+
if (conditionTruthiness !== "unknown" && conditionTruthiness !== requiredTruthiness) return true;
|
|
20581
|
+
}
|
|
20582
|
+
child = ancestor;
|
|
20583
|
+
ancestor = ancestor.parent ?? null;
|
|
20584
|
+
}
|
|
20585
|
+
return false;
|
|
20586
|
+
};
|
|
20587
|
+
const getEffectRetainedInvocations = (retainedFunction, context) => {
|
|
20588
|
+
if (!isFunctionLike$1(retainedFunction)) return [];
|
|
20589
|
+
const componentFunction = findEnclosingFunction$1(retainedFunction);
|
|
20590
|
+
if (!componentFunction || !isFunctionLike$1(componentFunction)) return [];
|
|
20591
|
+
const invocations = [];
|
|
20592
|
+
walkAst(componentFunction.body, (child) => {
|
|
20593
|
+
if (!isNodeOfType(child, "CallExpression") || findEnclosingFunction$1(child) !== componentFunction || !isReactHookCall(child, CLEANUP_EFFECT_HOOK_NAMES, context.scopes)) return;
|
|
20594
|
+
const effectCallback = getEffectCallback(child);
|
|
20595
|
+
if (!effectCallback || !isFunctionLike$1(effectCallback)) return;
|
|
20596
|
+
walkAst(effectCallback.body, (effectChild) => {
|
|
20597
|
+
if (effectChild !== effectCallback.body && isFunctionLike$1(effectChild)) return false;
|
|
20598
|
+
if (!isNodeOfType(effectChild, "CallExpression") || !isNodeReachableWithinFunction(effectChild, context)) return;
|
|
20599
|
+
const isDirectInvocation = resolveRefOwnedCleanupFunction(effectChild.callee, context) === retainedFunction;
|
|
20600
|
+
const isSynchronousIteratorInvocation = effectChild.arguments.some((argument) => isAstNode(argument) && resolveRefOwnedCleanupFunction(argument, context) === retainedFunction && isSynchronousIteratorCallbackCall(effectChild, argument));
|
|
20601
|
+
if (isDirectInvocation) invocations.push({
|
|
20602
|
+
call: effectChild,
|
|
20603
|
+
isDirect: true
|
|
20604
|
+
});
|
|
20605
|
+
if (isSynchronousIteratorInvocation) invocations.push({
|
|
20606
|
+
call: effectChild,
|
|
20607
|
+
isDirect: false
|
|
20608
|
+
});
|
|
20609
|
+
});
|
|
20610
|
+
});
|
|
20611
|
+
return invocations;
|
|
20612
|
+
};
|
|
20193
20613
|
const effectNeedsCleanup = defineRule({
|
|
20194
20614
|
id: "effect-needs-cleanup",
|
|
20195
20615
|
title: "Effect subscription or timer never cleaned up",
|
|
@@ -20200,13 +20620,19 @@ const effectNeedsCleanup = defineRule({
|
|
|
20200
20620
|
const reportRetainedLeak = (retainedFunction) => {
|
|
20201
20621
|
const refEffectUsage = getReactRefEffectUsage(retainedFunction, context);
|
|
20202
20622
|
if (!refEffectUsage && !isPotentiallyReachableFunction(retainedFunction, context)) return;
|
|
20623
|
+
const effectInvocations = getEffectRetainedInvocations(retainedFunction, context);
|
|
20624
|
+
const isEffectInvoked = effectInvocations.length > 0;
|
|
20203
20625
|
const leak = findRetainedFunctionLeak(retainedFunction, context, refEffectUsage ? {
|
|
20204
20626
|
allowReturnedResourceEscape: refEffectUsage.doesEffectOwnEveryResult,
|
|
20205
20627
|
allowReturnedTimerEscape: false,
|
|
20206
20628
|
includeOneShotTimers: true,
|
|
20207
20629
|
requireCallableReturnedResource: true
|
|
20630
|
+
} : isEffectInvoked ? {
|
|
20631
|
+
allowReturnedTimerEscape: false,
|
|
20632
|
+
includeOneShotTimers: true
|
|
20208
20633
|
} : void 0);
|
|
20209
20634
|
if (!leak) return;
|
|
20635
|
+
if (isEffectInvoked && leak.resourceName === "setTimeout" && (!isNodeReachableWithinFunction(leak.node, context) || isFunctionLike$1(retainedFunction) && retainedFunction.params.length > 0 && !context.cfg.isUnconditionalFromEntry(leak.node) && effectInvocations.every((invocation) => isLeakPathDisabledForInvocation(retainedFunction, leak.node, invocation, context)))) return;
|
|
20210
20636
|
const resourceNoun = RESOURCE_NOUN_BY_KIND[leak.kind];
|
|
20211
20637
|
context.report({
|
|
20212
20638
|
node: leak.node,
|
|
@@ -24626,14 +25052,14 @@ const getFirstLegendChild = (children, targetNode) => {
|
|
|
24626
25052
|
if (isNodeOfType(child, "JSXExpressionContainer")) {
|
|
24627
25053
|
const potentialLegends = [];
|
|
24628
25054
|
collectPotentialLegends(child.expression, potentialLegends);
|
|
24629
|
-
const containingLegend = potentialLegends.find((legend) => isDescendantOf(targetNode, legend));
|
|
25055
|
+
const containingLegend = potentialLegends.find((legend) => isDescendantOf$1(targetNode, legend));
|
|
24630
25056
|
if (containingLegend) return containingLegend;
|
|
24631
25057
|
if (potentialLegends[0]) return potentialLegends[0];
|
|
24632
25058
|
}
|
|
24633
25059
|
}
|
|
24634
25060
|
return null;
|
|
24635
25061
|
};
|
|
24636
|
-
const isDescendantOf = (node, ancestor) => {
|
|
25062
|
+
const isDescendantOf$1 = (node, ancestor) => {
|
|
24637
25063
|
let current = node.parent;
|
|
24638
25064
|
while (current) {
|
|
24639
25065
|
if (current === ancestor) return true;
|
|
@@ -24658,7 +25084,7 @@ const isDisabledByFieldsetAncestor = (node, context) => {
|
|
|
24658
25084
|
while (ancestor) {
|
|
24659
25085
|
if (isNodeOfType(ancestor, "JSXElement") && resolveJsxElementType(ancestor.openingElement) === "fieldset" && openingElementMayBeDisabled(ancestor.openingElement, context)) {
|
|
24660
25086
|
const firstLegend = getFirstLegendChild(ancestor.children, node);
|
|
24661
|
-
if (!firstLegend || !isDescendantOf(node, firstLegend)) return true;
|
|
25087
|
+
if (!firstLegend || !isDescendantOf$1(node, firstLegend)) return true;
|
|
24662
25088
|
}
|
|
24663
25089
|
ancestor = ancestor.parent;
|
|
24664
25090
|
}
|
|
@@ -30471,7 +30897,8 @@ const STRING_TYPED_PROPERTY_NAMES = new Set([
|
|
|
30471
30897
|
"code",
|
|
30472
30898
|
"label",
|
|
30473
30899
|
"slug",
|
|
30474
|
-
"prefix"
|
|
30900
|
+
"prefix",
|
|
30901
|
+
"__html"
|
|
30475
30902
|
]);
|
|
30476
30903
|
const STRING_TYPED_IDENTIFIER_SUFFIXES = [
|
|
30477
30904
|
"Text",
|
|
@@ -30589,13 +31016,25 @@ const STRING_TYPED_IDENTIFIER_NAMES = new Set([
|
|
|
30589
31016
|
"title"
|
|
30590
31017
|
]);
|
|
30591
31018
|
const STRING_RETURNING_CALLEE_PREFIX_PATTERN = /^(?:normalize|format|stringify|serialize)/;
|
|
31019
|
+
const FRESH_ARRAY_METHOD_NAMES$2 = new Set([
|
|
31020
|
+
"concat",
|
|
31021
|
+
"filter",
|
|
31022
|
+
"flat",
|
|
31023
|
+
"flatMap",
|
|
31024
|
+
"map",
|
|
31025
|
+
"slice",
|
|
31026
|
+
"split"
|
|
31027
|
+
]);
|
|
30592
31028
|
const isLikelyStringReceiver = (receiver) => {
|
|
30593
31029
|
if (!receiver) return false;
|
|
31030
|
+
const unwrappedReceiver = stripParenExpression(receiver);
|
|
31031
|
+
if (unwrappedReceiver !== receiver) return isLikelyStringReceiver(unwrappedReceiver);
|
|
30594
31032
|
if (isNodeOfType(receiver, "Literal") && typeof receiver.value === "string") return true;
|
|
30595
31033
|
if (isNodeOfType(receiver, "TemplateLiteral")) return true;
|
|
30596
31034
|
if (isNodeOfType(receiver, "CallExpression") && isNodeOfType(receiver.callee, "Identifier") && receiver.callee.name === "String") return true;
|
|
30597
31035
|
if (isNodeOfType(receiver, "CallExpression") && isNodeOfType(receiver.callee, "MemberExpression") && isNodeOfType(receiver.callee.property, "Identifier") && STRING_RETURNING_METHODS.has(receiver.callee.property.name)) return true;
|
|
30598
31036
|
if (isNodeOfType(receiver, "CallExpression") && isNodeOfType(receiver.callee, "Identifier") && STRING_RETURNING_CALLEE_PREFIX_PATTERN.test(receiver.callee.name)) return true;
|
|
31037
|
+
if (isNodeOfType(receiver, "CallExpression") && isNodeOfType(receiver.callee, "MemberExpression") && isNodeOfType(receiver.callee.property, "Identifier") && (receiver.callee.property.name === "concat" || receiver.callee.property.name === "slice") && isLikelyStringReceiver(receiver.callee.object)) return true;
|
|
30599
31038
|
if (isNodeOfType(receiver, "MemberExpression") && isNodeOfType(receiver.property, "Identifier")) {
|
|
30600
31039
|
if (STRING_TYPED_PROPERTY_NAMES.has(receiver.property.name)) return true;
|
|
30601
31040
|
}
|
|
@@ -30613,8 +31052,46 @@ const isLikelyStringReceiver = (receiver) => {
|
|
|
30613
31052
|
}
|
|
30614
31053
|
if (isNodeOfType(receiver, "BinaryExpression") && receiver.operator === "+") return isLikelyStringReceiver(receiver.left) || isLikelyStringReceiver(receiver.right);
|
|
30615
31054
|
if (isNodeOfType(receiver, "ConditionalExpression")) return isLikelyStringReceiver(receiver.consequent) && isLikelyStringReceiver(receiver.alternate);
|
|
31055
|
+
if (isNodeOfType(receiver, "LogicalExpression")) return isLikelyStringReceiver(receiver.left) && isLikelyStringReceiver(receiver.right);
|
|
30616
31056
|
return false;
|
|
30617
31057
|
};
|
|
31058
|
+
const isFreshArrayReceiver = (receiver) => {
|
|
31059
|
+
const unwrappedReceiver = stripParenExpression(receiver);
|
|
31060
|
+
if (unwrappedReceiver !== receiver) return isFreshArrayReceiver(unwrappedReceiver);
|
|
31061
|
+
if (!isNodeOfType(receiver, "CallExpression") || !isNodeOfType(receiver.callee, "MemberExpression") || !isNodeOfType(receiver.callee.property, "Identifier")) return false;
|
|
31062
|
+
if (!FRESH_ARRAY_METHOD_NAMES$2.has(receiver.callee.property.name)) return false;
|
|
31063
|
+
if (receiver.callee.property.name === "split") return isLikelyStringReceiver(receiver.callee.object);
|
|
31064
|
+
const sourceReceiver = stripParenExpression(receiver.callee.object);
|
|
31065
|
+
return isKnownNativeArrayReceiver(sourceReceiver) || isFreshArrayReceiver(sourceReceiver);
|
|
31066
|
+
};
|
|
31067
|
+
const isSmallRestHelperOmissionList = (node) => {
|
|
31068
|
+
if (!node) return false;
|
|
31069
|
+
const candidate = stripParenExpression(node);
|
|
31070
|
+
if (!isNodeOfType(candidate, "ArrayExpression")) return false;
|
|
31071
|
+
const elements = candidate.elements ?? [];
|
|
31072
|
+
return elements.length <= 8 && elements.every((element) => element === null || !isNodeOfType(element, "SpreadElement"));
|
|
31073
|
+
};
|
|
31074
|
+
const isTypeScriptRestHelperLookup = (lookupCall, receiver, scopes) => {
|
|
31075
|
+
if (!isNodeOfType(receiver, "Identifier")) return false;
|
|
31076
|
+
const enclosingFunction = findEnclosingFunction$1(lookupCall);
|
|
31077
|
+
if (!isNodeOfType(enclosingFunction, "FunctionExpression") || !isNodeOfType(enclosingFunction.params?.[1], "Identifier") || enclosingFunction.params[1].name !== receiver.name) return false;
|
|
31078
|
+
let bindingIdentifier = null;
|
|
31079
|
+
let ancestor = enclosingFunction.parent;
|
|
31080
|
+
while (ancestor && !isFunctionLike$1(ancestor)) {
|
|
31081
|
+
if (isNodeOfType(ancestor, "VariableDeclarator") && isNodeOfType(ancestor.id, "Identifier") && ancestor.id.name === "__rest") {
|
|
31082
|
+
bindingIdentifier = ancestor.id;
|
|
31083
|
+
break;
|
|
31084
|
+
}
|
|
31085
|
+
ancestor = ancestor.parent;
|
|
31086
|
+
}
|
|
31087
|
+
if (!bindingIdentifier) return false;
|
|
31088
|
+
const helperSymbol = scopes.symbolFor(bindingIdentifier);
|
|
31089
|
+
if (!helperSymbol || helperSymbol.references.length === 0) return false;
|
|
31090
|
+
return helperSymbol.references.every((reference) => {
|
|
31091
|
+
const callExpression = reference.identifier.parent;
|
|
31092
|
+
return isNodeOfType(callExpression, "CallExpression") && callExpression.callee === reference.identifier && isSmallRestHelperOmissionList(callExpression.arguments?.[1]);
|
|
31093
|
+
});
|
|
31094
|
+
};
|
|
30618
31095
|
const INDEX_LIKE_IDENTIFIER_NAMES = new Set([
|
|
30619
31096
|
"i",
|
|
30620
31097
|
"j",
|
|
@@ -31211,6 +31688,8 @@ const jsSetMapLookups = defineRule({
|
|
|
31211
31688
|
const query = node.arguments[0];
|
|
31212
31689
|
if (methodName === "indexOf" && !isKnownSafeIndexOfQuery(query) && (isKnownUnsafeIndexOfQuery(query, receiver) || isKnownUnsafeIndexOfReceiver(receiver))) return;
|
|
31213
31690
|
if (isLikelyStringReceiver(receiver)) return;
|
|
31691
|
+
if (isFreshArrayReceiver(receiver)) return;
|
|
31692
|
+
if (isTypeScriptRestHelperLookup(node, receiver, context.scopes)) return;
|
|
31214
31693
|
if (isSmallInlineLiteralArray(receiver)) return;
|
|
31215
31694
|
if (isScreamingSnakeCaseConstantReceiver(receiver)) return;
|
|
31216
31695
|
if (isSmallFixedListMember(receiver)) return;
|
|
@@ -45124,14 +45603,6 @@ const noAriaInvalidWithoutDescription = defineRule({
|
|
|
45124
45603
|
} })
|
|
45125
45604
|
});
|
|
45126
45605
|
//#endregion
|
|
45127
|
-
//#region src/plugin/utils/is-early-exit-statement.ts
|
|
45128
|
-
const isEarlyExitStatement$1 = (statement) => {
|
|
45129
|
-
if (!statement) return false;
|
|
45130
|
-
if (statementAlwaysExits$1(statement)) return true;
|
|
45131
|
-
if (isNodeOfType(statement, "BlockStatement")) return isEarlyExitStatement$1(statement.body.at(-1));
|
|
45132
|
-
return isNodeOfType(statement, "ContinueStatement") || isNodeOfType(statement, "BreakStatement");
|
|
45133
|
-
};
|
|
45134
|
-
//#endregion
|
|
45135
45606
|
//#region src/plugin/utils/unwrap-negative-guard-form.ts
|
|
45136
45607
|
const unwrapNegativeGuardForm = (test) => {
|
|
45137
45608
|
const expression = stripParenExpression(test);
|
|
@@ -46652,6 +47123,101 @@ const isLoopCounterDeclarator = (declarator, referenceNode, indexName) => {
|
|
|
46652
47123
|
}
|
|
46653
47124
|
return isBindingReassignedOrMutated(referenceNode, indexName);
|
|
46654
47125
|
};
|
|
47126
|
+
const findEnclosingWhileLoop = (node) => {
|
|
47127
|
+
let current = node.parent;
|
|
47128
|
+
while (current) {
|
|
47129
|
+
if (isNodeOfType(current, "WhileStatement") || isNodeOfType(current, "DoWhileStatement")) return current;
|
|
47130
|
+
if (isFunctionLike$1(current) || isNodeOfType(current, "Program")) return null;
|
|
47131
|
+
current = current.parent;
|
|
47132
|
+
}
|
|
47133
|
+
return null;
|
|
47134
|
+
};
|
|
47135
|
+
const isStaticMemberChain = (expression) => {
|
|
47136
|
+
const candidate = stripParenExpression(expression);
|
|
47137
|
+
if (isNodeOfType(candidate, "Identifier") || isNodeOfType(candidate, "ThisExpression")) return true;
|
|
47138
|
+
return Boolean(isNodeOfType(candidate, "MemberExpression") && !candidate.computed && isNodeOfType(candidate.property, "Identifier") && isStaticMemberChain(candidate.object));
|
|
47139
|
+
};
|
|
47140
|
+
const findLengthBoundCollections = (expression) => {
|
|
47141
|
+
const collections = [];
|
|
47142
|
+
walkAst(expression, (child) => {
|
|
47143
|
+
if (isNodeOfType(child, "MemberExpression") && !child.computed && isStaticMemberChain(child.object) && isNodeOfType(child.property, "Identifier") && child.property.name === "length") collections.push(child.object);
|
|
47144
|
+
});
|
|
47145
|
+
return collections;
|
|
47146
|
+
};
|
|
47147
|
+
const areSameBoundStaticMemberChains = (first, second) => isStaticMemberChain(first) && isStaticMemberChain(second) && areExpressionsStructurallyEqual(first, second, { areIdentifiersEqual: (firstIdentifier, secondIdentifier) => {
|
|
47148
|
+
if (!isNodeOfType(firstIdentifier, "Identifier") || !isNodeOfType(secondIdentifier, "Identifier") || firstIdentifier.name !== secondIdentifier.name) return false;
|
|
47149
|
+
const firstBinding = findVariableInitializer(firstIdentifier, firstIdentifier.name);
|
|
47150
|
+
const secondBinding = findVariableInitializer(secondIdentifier, secondIdentifier.name);
|
|
47151
|
+
return firstBinding?.bindingIdentifier === secondBinding?.bindingIdentifier;
|
|
47152
|
+
} });
|
|
47153
|
+
const RELATIONAL_BOUND_OPERATORS = new Set([
|
|
47154
|
+
"<",
|
|
47155
|
+
"<=",
|
|
47156
|
+
">",
|
|
47157
|
+
">="
|
|
47158
|
+
]);
|
|
47159
|
+
const loopTestBoundsCounterByLength = (expression, indexName, bindingIdentifier) => {
|
|
47160
|
+
const readsCounter = (candidate) => {
|
|
47161
|
+
let didReadCounter = false;
|
|
47162
|
+
walkAst(candidate, (child) => {
|
|
47163
|
+
if (didReadCounter) return false;
|
|
47164
|
+
if (isNodeOfType(child, "Identifier") && child.name === indexName && findVariableInitializer(child, indexName)?.bindingIdentifier === bindingIdentifier) {
|
|
47165
|
+
didReadCounter = true;
|
|
47166
|
+
return false;
|
|
47167
|
+
}
|
|
47168
|
+
});
|
|
47169
|
+
return didReadCounter;
|
|
47170
|
+
};
|
|
47171
|
+
const readsLength = (candidate) => {
|
|
47172
|
+
let didReadLength = false;
|
|
47173
|
+
walkAst(candidate, (child) => {
|
|
47174
|
+
if (didReadLength) return false;
|
|
47175
|
+
if (isNodeOfType(child, "MemberExpression") && !child.computed && isNodeOfType(child.property, "Identifier") && child.property.name === "length") {
|
|
47176
|
+
didReadLength = true;
|
|
47177
|
+
return false;
|
|
47178
|
+
}
|
|
47179
|
+
});
|
|
47180
|
+
return didReadLength;
|
|
47181
|
+
};
|
|
47182
|
+
let didFindLengthBound = false;
|
|
47183
|
+
walkAst(expression, (child) => {
|
|
47184
|
+
if (didFindLengthBound) return false;
|
|
47185
|
+
if (!isNodeOfType(child, "BinaryExpression") || !RELATIONAL_BOUND_OPERATORS.has(child.operator)) return;
|
|
47186
|
+
if (readsCounter(child.left) && readsLength(child.right) || readsCounter(child.right) && readsLength(child.left)) {
|
|
47187
|
+
didFindLengthBound = true;
|
|
47188
|
+
return false;
|
|
47189
|
+
}
|
|
47190
|
+
});
|
|
47191
|
+
return didFindLengthBound;
|
|
47192
|
+
};
|
|
47193
|
+
const isDataIndexedWhileLoopCounter = (referenceNode, bindingIdentifier, indexName) => {
|
|
47194
|
+
if (!INDEX_PARAMETER_NAMES.has(indexName)) return false;
|
|
47195
|
+
const loop = findEnclosingWhileLoop(referenceNode);
|
|
47196
|
+
if (!loop) return false;
|
|
47197
|
+
let doesTestReadCounter = false;
|
|
47198
|
+
walkAst(loop.test, (child) => {
|
|
47199
|
+
if (doesTestReadCounter) return false;
|
|
47200
|
+
if (!isNodeOfType(child, "Identifier") || child.name !== indexName) return;
|
|
47201
|
+
if (findVariableInitializer(child, indexName)?.bindingIdentifier === bindingIdentifier) {
|
|
47202
|
+
doesTestReadCounter = true;
|
|
47203
|
+
return false;
|
|
47204
|
+
}
|
|
47205
|
+
});
|
|
47206
|
+
if (!doesTestReadCounter) return false;
|
|
47207
|
+
const lengthBoundCollections = findLengthBoundCollections(loop.test);
|
|
47208
|
+
if (lengthBoundCollections.length === 0) return false;
|
|
47209
|
+
let didFindIndexedCollectionRead = false;
|
|
47210
|
+
walkAst(loop.body, (child) => {
|
|
47211
|
+
if (didFindIndexedCollectionRead) return false;
|
|
47212
|
+
if (isFunctionLike$1(child)) return false;
|
|
47213
|
+
if (!isNodeOfType(child, "MemberExpression") || !child.computed || !isNodeOfType(child.property, "Identifier") || child.property.name !== indexName) return;
|
|
47214
|
+
if (findVariableInitializer(child.property, indexName)?.bindingIdentifier === bindingIdentifier && lengthBoundCollections.some((collection) => areSameBoundStaticMemberChains(collection, child.object))) {
|
|
47215
|
+
didFindIndexedCollectionRead = true;
|
|
47216
|
+
return false;
|
|
47217
|
+
}
|
|
47218
|
+
});
|
|
47219
|
+
return didFindIndexedCollectionRead;
|
|
47220
|
+
};
|
|
46655
47221
|
/**
|
|
46656
47222
|
* Resolves whether an identifier is PROVABLY the positional array
|
|
46657
47223
|
* index, by classifying its binding. Per the official rule prompt,
|
|
@@ -46702,6 +47268,12 @@ const resolvePositionalIndexBinding = (identifierNode, depth) => {
|
|
|
46702
47268
|
}
|
|
46703
47269
|
const declarator = binding.bindingIdentifier.parent;
|
|
46704
47270
|
if (declarator && isNodeOfType(declarator, "VariableDeclarator") && declarator.id === binding.bindingIdentifier && declarator.init) {
|
|
47271
|
+
if (isDataIndexedWhileLoopCounter(identifierNode, binding.bindingIdentifier, identifierNode.name)) return {
|
|
47272
|
+
iteratorCall: null,
|
|
47273
|
+
bindingFunction: null,
|
|
47274
|
+
indexParameterPosition: null,
|
|
47275
|
+
isDataIndexedLoopCounter: true
|
|
47276
|
+
};
|
|
46705
47277
|
const initializer = stripParenExpression(declarator.init);
|
|
46706
47278
|
if (isNodeOfType(initializer, "Literal") && typeof initializer.value === "number") {
|
|
46707
47279
|
if (!INDEX_PARAMETER_NAMES.has(identifierNode.name)) return null;
|
|
@@ -46736,6 +47308,101 @@ const iteratorCallExemptsIndexKey = (iteratorCall) => {
|
|
|
46736
47308
|
const receiver = iteratorCall.callee.object;
|
|
46737
47309
|
return isStaticPlaceholderReceiver(receiver) || isFixedMemoReceiver(receiver) || isStaticDefaultLiteralReceiver(receiver) || isStringDerivedReceiver(receiver);
|
|
46738
47310
|
};
|
|
47311
|
+
const isReactNamespaceIdentifier = (node) => {
|
|
47312
|
+
if (!isNodeOfType(node, "Identifier")) return false;
|
|
47313
|
+
const importBinding = getImportBindingForName(node, node.name);
|
|
47314
|
+
const visibleBinding = findVariableInitializer(node, node.name);
|
|
47315
|
+
if (!importBinding) return node.name === "React" && !visibleBinding;
|
|
47316
|
+
return visibleBinding?.initializer?.type.startsWith("Import") === true && importBinding.source === "react" && (importBinding.isNamespace || importBinding.exportedName === "default");
|
|
47317
|
+
};
|
|
47318
|
+
const isReactChildrenObject = (node) => {
|
|
47319
|
+
const candidate = stripParenExpression(node);
|
|
47320
|
+
if (isNodeOfType(candidate, "Identifier")) {
|
|
47321
|
+
const importBinding = getImportBindingForName(candidate, candidate.name);
|
|
47322
|
+
const visibleBinding = findVariableInitializer(candidate, candidate.name);
|
|
47323
|
+
return Boolean(visibleBinding?.initializer?.type === "ImportSpecifier" && importBinding?.source === "react" && importBinding.exportedName === "Children");
|
|
47324
|
+
}
|
|
47325
|
+
return Boolean(isNodeOfType(candidate, "MemberExpression") && !candidate.computed && isReactNamespaceIdentifier(candidate.object) && isNodeOfType(candidate.property, "Identifier") && candidate.property.name === "Children");
|
|
47326
|
+
};
|
|
47327
|
+
const isReactChildrenToArrayCall = (node) => {
|
|
47328
|
+
const candidate = stripParenExpression(node);
|
|
47329
|
+
if (!isNodeOfType(candidate, "CallExpression") || !isNodeOfType(candidate.callee, "MemberExpression") || candidate.callee.computed || !isReactChildrenObject(candidate.callee.object) || !isNodeOfType(candidate.callee.property, "Identifier") || candidate.callee.property.name !== "toArray") return false;
|
|
47330
|
+
const normalizedValueNode = candidate.arguments?.[0];
|
|
47331
|
+
const normalizedValue = normalizedValueNode ? stripParenExpression(normalizedValueNode) : null;
|
|
47332
|
+
if (!normalizedValue || !isNodeOfType(normalizedValue, "Identifier") || normalizedValue.name !== "children") return false;
|
|
47333
|
+
const normalizedBinding = findVariableInitializer(normalizedValue, normalizedValue.name);
|
|
47334
|
+
return Boolean(normalizedBinding && findEnclosingParameter(normalizedBinding.bindingIdentifier));
|
|
47335
|
+
};
|
|
47336
|
+
const isSameIdentifier = (first, second) => {
|
|
47337
|
+
const firstIdentifier = stripParenExpression(first);
|
|
47338
|
+
const secondIdentifier = stripParenExpression(second);
|
|
47339
|
+
if (!isNodeOfType(firstIdentifier, "Identifier") || !isNodeOfType(secondIdentifier, "Identifier") || firstIdentifier.name !== secondIdentifier.name) return false;
|
|
47340
|
+
const firstBinding = findVariableInitializer(firstIdentifier, firstIdentifier.name);
|
|
47341
|
+
const secondBinding = findVariableInitializer(secondIdentifier, secondIdentifier.name);
|
|
47342
|
+
return firstBinding?.bindingIdentifier === secondBinding?.bindingIdentifier;
|
|
47343
|
+
};
|
|
47344
|
+
const isReactChildrenArrayNormalization = (node) => {
|
|
47345
|
+
const candidate = stripParenExpression(node);
|
|
47346
|
+
if (!isNodeOfType(candidate, "ConditionalExpression")) return false;
|
|
47347
|
+
const test = stripParenExpression(candidate.test);
|
|
47348
|
+
if (!isNodeOfType(test, "CallExpression") || !isNodeOfType(test.callee, "MemberExpression") || test.callee.computed || !isNodeOfType(test.callee.object, "Identifier") || test.callee.object.name !== "Array" || findVariableInitializer(test.callee.object, "Array") || !isNodeOfType(test.callee.property, "Identifier") || test.callee.property.name !== "isArray") return false;
|
|
47349
|
+
const testedValueNode = test.arguments?.[0];
|
|
47350
|
+
if (!testedValueNode) return false;
|
|
47351
|
+
const testedValue = stripParenExpression(testedValueNode);
|
|
47352
|
+
if (!isNodeOfType(testedValue, "Identifier")) return false;
|
|
47353
|
+
const testedBinding = findVariableInitializer(testedValue, testedValue.name);
|
|
47354
|
+
if (testedValue.name !== "children" || !testedBinding || !findEnclosingParameter(testedBinding.bindingIdentifier)) return false;
|
|
47355
|
+
const branchWrapsTestedValue = (branch) => {
|
|
47356
|
+
const unwrappedBranch = stripParenExpression(branch);
|
|
47357
|
+
return isNodeOfType(unwrappedBranch, "ArrayExpression") && unwrappedBranch.elements?.length === 1 && Boolean(unwrappedBranch.elements[0] && isSameIdentifier(unwrappedBranch.elements[0], testedValue));
|
|
47358
|
+
};
|
|
47359
|
+
return isSameIdentifier(candidate.consequent, testedValue) && branchWrapsTestedValue(candidate.alternate) || isSameIdentifier(candidate.alternate, testedValue) && branchWrapsTestedValue(candidate.consequent);
|
|
47360
|
+
};
|
|
47361
|
+
const isMutatedEmptyArrayBinding = (identifierNode, depth) => {
|
|
47362
|
+
const binding = findVariableInitializer(identifierNode, identifierNode.name);
|
|
47363
|
+
const initializer = binding?.initializer ? stripParenExpression(binding.initializer) : null;
|
|
47364
|
+
if (!binding || !initializer || !isNodeOfType(initializer, "ArrayExpression") || initializer.elements?.length !== 0) return false;
|
|
47365
|
+
const program = findProgramRoot(identifierNode);
|
|
47366
|
+
if (!program) return false;
|
|
47367
|
+
let didFindReactChildPush = false;
|
|
47368
|
+
walkAst(program, (child) => {
|
|
47369
|
+
if (didFindReactChildPush) return false;
|
|
47370
|
+
if (!isNodeOfType(child, "CallExpression") || !isNodeOfType(child.callee, "MemberExpression") || child.callee.computed || !isNodeOfType(child.callee.object, "Identifier") || child.callee.object.name !== identifierNode.name || !isNodeOfType(child.callee.property, "Identifier") || child.callee.property.name !== "push") return;
|
|
47371
|
+
if (findVariableInitializer(child.callee.object, identifierNode.name)?.bindingIdentifier === binding.bindingIdentifier && (child.arguments ?? []).some((argument) => {
|
|
47372
|
+
const candidate = stripParenExpression(argument);
|
|
47373
|
+
if (!(isNodeOfType(candidate, "Identifier") || isNodeOfType(candidate, "JSXElement") || isNodeOfType(candidate, "JSXFragment"))) return false;
|
|
47374
|
+
let doesCarryReactChild = false;
|
|
47375
|
+
walkAst(candidate, (argumentChild) => {
|
|
47376
|
+
if (doesCarryReactChild) return false;
|
|
47377
|
+
if (!isNodeOfType(argumentChild, "Identifier")) return;
|
|
47378
|
+
const declarator = findVariableInitializer(argumentChild, argumentChild.name)?.bindingIdentifier.parent;
|
|
47379
|
+
const declaration = declarator?.parent;
|
|
47380
|
+
const forOfStatement = declaration?.parent;
|
|
47381
|
+
if (declarator && isNodeOfType(declarator, "VariableDeclarator") && declaration && isNodeOfType(declaration, "VariableDeclaration") && forOfStatement && isNodeOfType(forOfStatement, "ForOfStatement") && forOfStatement.left === declaration && isDynamicReactChildrenExpression(forOfStatement.right, depth + 1)) {
|
|
47382
|
+
doesCarryReactChild = true;
|
|
47383
|
+
return false;
|
|
47384
|
+
}
|
|
47385
|
+
});
|
|
47386
|
+
return doesCarryReactChild;
|
|
47387
|
+
})) {
|
|
47388
|
+
didFindReactChildPush = true;
|
|
47389
|
+
return false;
|
|
47390
|
+
}
|
|
47391
|
+
});
|
|
47392
|
+
return didFindReactChildPush;
|
|
47393
|
+
};
|
|
47394
|
+
const isDynamicReactChildrenExpression = (expression, depth) => {
|
|
47395
|
+
if (depth > TYPE_RESOLUTION_DEPTH_LIMIT$2) return false;
|
|
47396
|
+
const candidate = stripParenExpression(expression);
|
|
47397
|
+
if (isReactChildrenToArrayCall(candidate) || isReactChildrenArrayNormalization(candidate)) return true;
|
|
47398
|
+
if (isNodeOfType(candidate, "Identifier")) {
|
|
47399
|
+
if (isMutatedEmptyArrayBinding(candidate, depth)) return true;
|
|
47400
|
+
const binding = findVariableInitializer(candidate, candidate.name);
|
|
47401
|
+
return Boolean(binding?.initializer && isDynamicReactChildrenExpression(binding.initializer, depth + 1));
|
|
47402
|
+
}
|
|
47403
|
+
if (isNodeOfType(candidate, "CallExpression") && isNodeOfType(candidate.callee, "MemberExpression") && !candidate.callee.computed && isNodeOfType(candidate.callee.property, "Identifier") && candidate.callee.property.name === "filter") return isDynamicReactChildrenExpression(candidate.callee.object, depth + 1);
|
|
47404
|
+
return false;
|
|
47405
|
+
};
|
|
46739
47406
|
const resolveKeyTemplateLiteral = (expression) => {
|
|
46740
47407
|
const node = stripParenExpression(expression);
|
|
46741
47408
|
if (isNodeOfType(node, "TemplateLiteral")) return node;
|
|
@@ -46788,28 +47455,19 @@ const findBareItemNamesReferencedByTemplate = (template, itemNames) => {
|
|
|
46788
47455
|
}
|
|
46789
47456
|
return referencedItemNames;
|
|
46790
47457
|
};
|
|
46791
|
-
const
|
|
46792
|
-
let didFindLengthRead = false;
|
|
46793
|
-
walkAst(test, (child) => {
|
|
46794
|
-
if (didFindLengthRead) return false;
|
|
46795
|
-
if (isNodeOfType(child, "MemberExpression") && isNodeOfType(child.property, "Identifier") && child.property.name === "length") {
|
|
46796
|
-
didFindLengthRead = true;
|
|
46797
|
-
return false;
|
|
46798
|
-
}
|
|
46799
|
-
});
|
|
46800
|
-
return didFindLengthRead;
|
|
46801
|
-
};
|
|
46802
|
-
const isNumericForLoopCounter = (attributeNode, indexName) => {
|
|
47458
|
+
const isNumericPlaceholderLoopCounter = (attributeNode, indexName) => {
|
|
46803
47459
|
const binding = findVariableInitializer(attributeNode, indexName);
|
|
46804
47460
|
if (!binding) return false;
|
|
46805
47461
|
const declarator = binding.bindingIdentifier.parent;
|
|
46806
47462
|
if (!declarator || !isNodeOfType(declarator, "VariableDeclarator")) return false;
|
|
46807
47463
|
const declaration = declarator.parent;
|
|
46808
47464
|
if (!declaration || !isNodeOfType(declaration, "VariableDeclaration")) return false;
|
|
47465
|
+
if (!declarator.init || !isNodeOfType(declarator.init, "Literal") || typeof declarator.init.value !== "number") return false;
|
|
46809
47466
|
const forStatement = declaration.parent;
|
|
46810
|
-
if (
|
|
46811
|
-
|
|
46812
|
-
return
|
|
47467
|
+
if (forStatement && isNodeOfType(forStatement, "ForStatement") && forStatement.init === declaration) return !(forStatement.test && loopTestBoundsCounterByLength(forStatement.test, indexName, binding.bindingIdentifier));
|
|
47468
|
+
const whileLoop = findEnclosingWhileLoop(attributeNode);
|
|
47469
|
+
if (!whileLoop) return false;
|
|
47470
|
+
return !loopTestBoundsCounterByLength(whileLoop.test, indexName, binding.bindingIdentifier);
|
|
46813
47471
|
};
|
|
46814
47472
|
const EMPTY_NAME_SET$1 = /* @__PURE__ */ new Set();
|
|
46815
47473
|
const findIteratorItemNamesOfBinding = (binding) => {
|
|
@@ -46843,11 +47501,11 @@ const collectDerivedRowContentNames = (bindingFunction, itemNames) => {
|
|
|
46843
47501
|
* observable harm; anything stateful — form controls, media, custom
|
|
46844
47502
|
* components, unknown calls — keeps the diagnostic.
|
|
46845
47503
|
*/
|
|
46846
|
-
const fragmentHasStatefulChildren = (openingElement, itemNames, derivedNames) => {
|
|
47504
|
+
const fragmentHasStatefulChildren = (openingElement, itemNames, derivedNames, areBareItemsDynamicReactChildren) => {
|
|
46847
47505
|
const jsxElement = openingElement.parent;
|
|
46848
47506
|
if (!jsxElement || !isNodeOfType(jsxElement, "JSXElement")) return false;
|
|
46849
47507
|
const children = jsxElement.children ?? [];
|
|
46850
|
-
const bareIdentifierNames = children.some((child) => isNodeOfType(child, "JSXElement")) ? derivedNames : new Set([...derivedNames, ...itemNames]);
|
|
47508
|
+
const bareIdentifierNames = children.some((child) => isNodeOfType(child, "JSXElement")) ? derivedNames : areBareItemsDynamicReactChildren ? derivedNames : new Set([...derivedNames, ...itemNames]);
|
|
46851
47509
|
return children.some((child) => containsStatefulDescendant(child, {
|
|
46852
47510
|
memberRootNames: itemNames,
|
|
46853
47511
|
allowAnyMemberRead: true,
|
|
@@ -46855,6 +47513,15 @@ const fragmentHasStatefulChildren = (openingElement, itemNames, derivedNames) =>
|
|
|
46855
47513
|
callCalleeRootNames: itemNames
|
|
46856
47514
|
}));
|
|
46857
47515
|
};
|
|
47516
|
+
const elementHasDirectItemChild = (openingElement, itemNames) => {
|
|
47517
|
+
const jsxElement = openingElement.parent;
|
|
47518
|
+
if (!jsxElement || !isNodeOfType(jsxElement, "JSXElement")) return false;
|
|
47519
|
+
return (jsxElement.children ?? []).some((child) => {
|
|
47520
|
+
if (!isNodeOfType(child, "JSXExpressionContainer")) return false;
|
|
47521
|
+
const expression = stripParenExpression(child.expression);
|
|
47522
|
+
return isNodeOfType(expression, "Identifier") && itemNames.has(expression.name);
|
|
47523
|
+
});
|
|
47524
|
+
};
|
|
46858
47525
|
const callbackFiltersRows = (bindingFunction) => {
|
|
46859
47526
|
if (!bindingFunction) return false;
|
|
46860
47527
|
let didFindNullReturn = false;
|
|
@@ -46906,19 +47573,21 @@ const noArrayIndexAsKey = defineRule({
|
|
|
46906
47573
|
const indexUse = findPositionalIndexUse(node.value.expression, 0);
|
|
46907
47574
|
if (!indexUse) return;
|
|
46908
47575
|
const indexName = indexUse.identifier.name;
|
|
46909
|
-
if (
|
|
47576
|
+
if (isNumericPlaceholderLoopCounter(node, indexName)) return;
|
|
46910
47577
|
if (indexUse.binding.iteratorCall && iteratorCallExemptsIndexKey(indexUse.binding.iteratorCall)) return;
|
|
46911
47578
|
const keyTemplate = resolveKeyTemplateLiteral(node.value.expression);
|
|
46912
47579
|
if (keyTemplate && templateHasOuterMemberIdentity(keyTemplate, indexUse.binding.bindingFunction)) return;
|
|
46913
|
-
if (hasAriaHiddenAncestor(node)) return;
|
|
47580
|
+
if (hasAriaHiddenAncestor(node) && !indexUse.binding.isDataIndexedLoopCounter) return;
|
|
46914
47581
|
const itemNames = findIteratorItemNamesOfBinding(indexUse.binding);
|
|
46915
47582
|
const derivedNames = collectDerivedRowContentNames(indexUse.binding.bindingFunction, itemNames);
|
|
47583
|
+
const iteratorCallee = indexUse.binding.iteratorCall?.callee;
|
|
47584
|
+
const hasDynamicReactChildren = Boolean(iteratorCallee && isNodeOfType(iteratorCallee, "MemberExpression") && isDynamicReactChildrenExpression(iteratorCallee.object, 0));
|
|
46916
47585
|
const openingElement = node.parent;
|
|
46917
47586
|
if (openingElement && isNodeOfType(openingElement, "JSXOpeningElement")) {
|
|
46918
47587
|
const elementName = openingElement.name;
|
|
46919
47588
|
if (isNodeOfType(elementName, "JSXIdentifier")) {
|
|
46920
47589
|
if (elementName.name === "Fragment") {
|
|
46921
|
-
if (!fragmentHasStatefulChildren(openingElement, itemNames, derivedNames)) return;
|
|
47590
|
+
if (!fragmentHasStatefulChildren(openingElement, itemNames, derivedNames, hasDynamicReactChildren)) return;
|
|
46922
47591
|
} else if (PURE_SVG_PRIMITIVE_TAGS.has(elementName.name)) {
|
|
46923
47592
|
if (!callbackFiltersRows(indexUse.binding.bindingFunction)) return;
|
|
46924
47593
|
} else if (STATELESS_HTML_LEAF_TAGS.has(elementName.name)) {
|
|
@@ -46926,14 +47595,14 @@ const noArrayIndexAsKey = defineRule({
|
|
|
46926
47595
|
if (jsxElement && isNodeOfType(jsxElement, "JSXElement")) {
|
|
46927
47596
|
const isInlineTextRun = INLINE_TEXT_LEAF_TAGS.has(elementName.name);
|
|
46928
47597
|
const primitiveItemNames = keyTemplate ? findBareItemNamesReferencedByTemplate(keyTemplate, itemNames) : EMPTY_NAME_SET$1;
|
|
46929
|
-
if (!containsStatefulDescendant(jsxElement, {
|
|
47598
|
+
if (!(hasDynamicReactChildren && elementHasDirectItemChild(openingElement, itemNames) || containsStatefulDescendant(jsxElement, {
|
|
46930
47599
|
memberRootNames: isInlineTextRun ? itemNames : EMPTY_NAME_SET$1,
|
|
46931
47600
|
bareIdentifierNames: primitiveItemNames.size > 0 ? new Set([...derivedNames, ...primitiveItemNames]) : derivedNames
|
|
46932
|
-
})) return;
|
|
47601
|
+
}))) return;
|
|
46933
47602
|
}
|
|
46934
47603
|
}
|
|
46935
47604
|
}
|
|
46936
|
-
if (isNodeOfType(elementName, "JSXMemberExpression") && isNodeOfType(elementName.object, "JSXIdentifier") && isNodeOfType(elementName.property, "JSXIdentifier") && elementName.object.name === "React" && elementName.property.name === "Fragment" && !fragmentHasStatefulChildren(openingElement, itemNames, derivedNames)) return;
|
|
47605
|
+
if (isNodeOfType(elementName, "JSXMemberExpression") && isNodeOfType(elementName.object, "JSXIdentifier") && isNodeOfType(elementName.property, "JSXIdentifier") && elementName.object.name === "React" && elementName.property.name === "Fragment" && !fragmentHasStatefulChildren(openingElement, itemNames, derivedNames, hasDynamicReactChildren)) return;
|
|
46937
47606
|
}
|
|
46938
47607
|
context.report({
|
|
46939
47608
|
node,
|
|
@@ -55421,6 +56090,9 @@ const isInitialOnlyPropName = (propName) => {
|
|
|
55421
56090
|
return /^initial[A-Z]/.test(propName) || /^default[A-Z]/.test(propName) || /^seed[A-Z]/.test(propName) || /^starting[A-Z]/.test(propName) || /^baseline[A-Z]/.test(propName) || /^preset[A-Z]/.test(propName);
|
|
55422
56091
|
};
|
|
55423
56092
|
//#endregion
|
|
56093
|
+
//#region src/plugin/utils/nextjs-page-data-export-names.ts
|
|
56094
|
+
const NEXTJS_PAGE_DATA_EXPORT_NAMES = new Set(["getServerSideProps", "getStaticProps"]);
|
|
56095
|
+
//#endregion
|
|
55424
56096
|
//#region src/plugin/rules/state-and-effects/no-derived-use-state.ts
|
|
55425
56097
|
const isInitialOnlySeedName = (propName) => isInitialOnlyPropName(propName) || propName === "initial" || propName === "autoFocus" || propName === "autoPlay" || propName === "startOpen" || /^initially[A-Z]/.test(propName) || /Initial([A-Z]|$)/.test(propName);
|
|
55426
56098
|
const SNAPSHOT_STATE_NAME_PATTERN = /^(initial|previous|prev|preserved|saved|original|cached|snapshot|prior|debounced|deferred)([A-Z_]|$)/;
|
|
@@ -55577,7 +56249,6 @@ const isDraftCommittedToParent = (componentFunction, stateValueName, isPropName)
|
|
|
55577
56249
|
});
|
|
55578
56250
|
return isCommitted;
|
|
55579
56251
|
};
|
|
55580
|
-
const NEXTJS_PAGE_DATA_EXPORT_NAMES = new Set(["getServerSideProps", "getStaticProps"]);
|
|
55581
56252
|
const isNextjsDataFetchingPage = (node) => {
|
|
55582
56253
|
const program = findProgramRoot(node);
|
|
55583
56254
|
if (!program) return false;
|
|
@@ -63829,6 +64500,106 @@ const isGatedByFalsyInitialState = (node, scopes) => {
|
|
|
63829
64500
|
};
|
|
63830
64501
|
//#endregion
|
|
63831
64502
|
//#region src/plugin/rules/performance/no-hydration-branch-on-browser-global.ts
|
|
64503
|
+
const findGuardingIfStatements = (node, functionBoundary) => {
|
|
64504
|
+
const guardingIfStatements = [];
|
|
64505
|
+
let currentNode = node.parent;
|
|
64506
|
+
while (currentNode && currentNode !== functionBoundary) {
|
|
64507
|
+
if (isNodeOfType(currentNode, "IfStatement")) guardingIfStatements.push(currentNode);
|
|
64508
|
+
currentNode = currentNode.parent;
|
|
64509
|
+
}
|
|
64510
|
+
return guardingIfStatements;
|
|
64511
|
+
};
|
|
64512
|
+
const doesNodeReadSymbol = (node, symbol) => {
|
|
64513
|
+
let doesReadSymbol = false;
|
|
64514
|
+
walkAst(node, (childNode) => {
|
|
64515
|
+
if (isNodeOfType(childNode, "Identifier") && symbol.references.some((reference) => reference.identifier === childNode && reference.flag !== "write")) {
|
|
64516
|
+
doesReadSymbol = true;
|
|
64517
|
+
return false;
|
|
64518
|
+
}
|
|
64519
|
+
});
|
|
64520
|
+
return doesReadSymbol;
|
|
64521
|
+
};
|
|
64522
|
+
const collectWrittenSymbols = (node, scopes) => {
|
|
64523
|
+
const writtenSymbols = /* @__PURE__ */ new Set();
|
|
64524
|
+
walkAst(node, (childNode) => {
|
|
64525
|
+
if (childNode !== node && isFunctionLike$1(childNode)) return false;
|
|
64526
|
+
if (!isNodeOfType(childNode, "Identifier")) return;
|
|
64527
|
+
const reference = scopes.referenceFor(childNode);
|
|
64528
|
+
if (!reference || reference.flag === "read" || !reference.resolvedSymbol) return;
|
|
64529
|
+
writtenSymbols.add(reference.resolvedSymbol);
|
|
64530
|
+
});
|
|
64531
|
+
return writtenSymbols;
|
|
64532
|
+
};
|
|
64533
|
+
const isDescendantOf = (node, ancestorNode) => {
|
|
64534
|
+
let currentNode = node.parent;
|
|
64535
|
+
while (currentNode) {
|
|
64536
|
+
if (currentNode === ancestorNode) return true;
|
|
64537
|
+
currentNode = currentNode.parent;
|
|
64538
|
+
}
|
|
64539
|
+
return false;
|
|
64540
|
+
};
|
|
64541
|
+
const getAssignedValue = (identifier) => {
|
|
64542
|
+
const assignmentExpression = identifier.parent;
|
|
64543
|
+
return isNodeOfType(assignmentExpression, "AssignmentExpression") && assignmentExpression.operator === "=" && assignmentExpression.left === identifier ? assignmentExpression.right : null;
|
|
64544
|
+
};
|
|
64545
|
+
const doesGuardPreserveInitialSymbolValue = (symbol, guardingIfStatement, scopes) => {
|
|
64546
|
+
const initialValue = symbol.initializer;
|
|
64547
|
+
if (!initialValue) return false;
|
|
64548
|
+
const guardedWrites = symbol.references.filter((reference) => reference.flag !== "read" && isDescendantOf(reference.identifier, guardingIfStatement));
|
|
64549
|
+
return guardedWrites.length > 0 && guardedWrites.every((reference) => {
|
|
64550
|
+
const assignedValue = getAssignedValue(reference.identifier);
|
|
64551
|
+
return Boolean(assignedValue && areExpressionsStructurallyEqual(initialValue, assignedValue) && doEquivalentExpressionBindingsMatch(initialValue, assignedValue, scopes));
|
|
64552
|
+
});
|
|
64553
|
+
};
|
|
64554
|
+
const isWriteOverwrittenBefore = (symbol, writeIdentifier, guardingIfStatement, readIdentifier, context) => symbol.references.some((reference) => reference.flag !== "read" && reference.identifier !== writeIdentifier && !isDescendantOf(reference.identifier, guardingIfStatement) && isNodeReachableWithinFunction(reference.identifier, context) && isUnconditionalOrStaticallySelected(reference.identifier, context) && getNodeStartIndex(reference.identifier) > getNodeStartIndex(writeIdentifier) && getNodeStartIndex(reference.identifier) < getNodeStartIndex(readIdentifier));
|
|
64555
|
+
const isUnconditionalOrStaticallySelected = (node, context) => {
|
|
64556
|
+
if (context.cfg.isUnconditionalFromEntry(node)) return true;
|
|
64557
|
+
let currentNode = node;
|
|
64558
|
+
let outermostStaticIfStatement = null;
|
|
64559
|
+
let parentNode = currentNode.parent;
|
|
64560
|
+
while (parentNode) {
|
|
64561
|
+
if (isFunctionLike$1(parentNode)) break;
|
|
64562
|
+
if (isNodeOfType(parentNode, "IfStatement")) {
|
|
64563
|
+
const staticResult = readInitialStateBoolean(parentNode.test, context.scopes);
|
|
64564
|
+
let selectedBranch = null;
|
|
64565
|
+
if (staticResult === true) selectedBranch = parentNode.consequent;
|
|
64566
|
+
if (staticResult === false) selectedBranch = parentNode.alternate;
|
|
64567
|
+
if (!selectedBranch || currentNode !== selectedBranch && !isDescendantOf(currentNode, selectedBranch)) return false;
|
|
64568
|
+
outermostStaticIfStatement = parentNode;
|
|
64569
|
+
}
|
|
64570
|
+
currentNode = parentNode;
|
|
64571
|
+
parentNode = currentNode.parent;
|
|
64572
|
+
}
|
|
64573
|
+
return Boolean(outermostStaticIfStatement && context.cfg.isUnconditionalFromEntry(outermostStaticIfStatement));
|
|
64574
|
+
};
|
|
64575
|
+
const containsExplicitReactRuntimeReference = (node, scopes) => {
|
|
64576
|
+
let hasRuntimeReference = false;
|
|
64577
|
+
walkAst(node, (childNode) => {
|
|
64578
|
+
if (isNodeOfType(childNode, "ImportDeclaration") && typeof childNode.source.value === "string" && REACT_RUNTIME_MODULE_SOURCES.has(childNode.source.value)) {
|
|
64579
|
+
hasRuntimeReference = true;
|
|
64580
|
+
return false;
|
|
64581
|
+
}
|
|
64582
|
+
if (!isNodeOfType(childNode, "CallExpression")) return;
|
|
64583
|
+
const sourceArgument = (childNode.arguments ?? [])[0];
|
|
64584
|
+
if (!isNodeOfType(childNode.callee, "Identifier") || childNode.callee.name !== "require" || !scopes.isGlobalReference(childNode.callee) || !isNodeOfType(sourceArgument, "Literal") || typeof sourceArgument.value !== "string" || !REACT_RUNTIME_MODULE_SOURCES.has(sourceArgument.value)) return;
|
|
64585
|
+
hasRuntimeReference = true;
|
|
64586
|
+
return false;
|
|
64587
|
+
});
|
|
64588
|
+
return hasRuntimeReference;
|
|
64589
|
+
};
|
|
64590
|
+
const findComponentRenderingLocalFunctionResult = (functionNode, scopes) => {
|
|
64591
|
+
const bindingIdentifier = getDirectFunctionBindingIdentifier(functionNode);
|
|
64592
|
+
if (!isNodeOfType(bindingIdentifier, "Identifier")) return null;
|
|
64593
|
+
const functionSymbol = scopes.symbolFor(bindingIdentifier);
|
|
64594
|
+
if (!functionSymbol) return null;
|
|
64595
|
+
for (const reference of functionSymbol.references) {
|
|
64596
|
+
const callExpression = reference.identifier.parent;
|
|
64597
|
+
if (!isNodeOfType(callExpression, "CallExpression") || callExpression.callee !== reference.identifier) continue;
|
|
64598
|
+
const componentOrHookNode = findRenderPhaseComponentOrHook(callExpression, scopes);
|
|
64599
|
+
if (componentOrHookNode && isInRenderedOutput(callExpression, componentOrHookNode, scopes)) return componentOrHookNode;
|
|
64600
|
+
}
|
|
64601
|
+
return null;
|
|
64602
|
+
};
|
|
63832
64603
|
const evaluateEquality$1 = (operator, left, right) => {
|
|
63833
64604
|
if (operator === "===" || operator === "==") return left === right;
|
|
63834
64605
|
if (operator === "!==" || operator === "!=") return left !== right;
|
|
@@ -63879,6 +64650,107 @@ const readLogicalConditionResult = (operator, leftResult, rightResult) => {
|
|
|
63879
64650
|
if (leftResult === false && rightResult === false) return false;
|
|
63880
64651
|
return null;
|
|
63881
64652
|
};
|
|
64653
|
+
const areLooselyEqualPrimitiveResults = (left, right) => {
|
|
64654
|
+
if (left.kind === right.kind) return left.value === right.value;
|
|
64655
|
+
if (left.kind === "null" && right.kind === "undefined" || left.kind === "undefined" && right.kind === "null") return true;
|
|
64656
|
+
if (left.kind === "boolean") return areLooselyEqualPrimitiveResults({
|
|
64657
|
+
kind: "number",
|
|
64658
|
+
value: left.value ? 1 : 0
|
|
64659
|
+
}, right);
|
|
64660
|
+
if (right.kind === "boolean") return areLooselyEqualPrimitiveResults(left, {
|
|
64661
|
+
kind: "number",
|
|
64662
|
+
value: right.value ? 1 : 0
|
|
64663
|
+
});
|
|
64664
|
+
if (left.kind === "number" && right.kind === "string") return left.value === Number(right.value);
|
|
64665
|
+
if (left.kind === "string" && right.kind === "number") return Number(left.value) === right.value;
|
|
64666
|
+
return false;
|
|
64667
|
+
};
|
|
64668
|
+
const readHydrationPrimitiveResult = (expression, context, runtime, state) => {
|
|
64669
|
+
const unwrappedExpression = stripParenExpression(expression);
|
|
64670
|
+
const predicateMatch = matchBrowserPredicate(unwrappedExpression, context);
|
|
64671
|
+
if (predicateMatch) return {
|
|
64672
|
+
kind: "boolean",
|
|
64673
|
+
value: predicateMatch[`${runtime}Result`]
|
|
64674
|
+
};
|
|
64675
|
+
if (isNodeOfType(unwrappedExpression, "Literal")) {
|
|
64676
|
+
const value = unwrappedExpression.value;
|
|
64677
|
+
if (value === null) return {
|
|
64678
|
+
kind: "null",
|
|
64679
|
+
value
|
|
64680
|
+
};
|
|
64681
|
+
if (typeof value === "boolean") return {
|
|
64682
|
+
kind: "boolean",
|
|
64683
|
+
value
|
|
64684
|
+
};
|
|
64685
|
+
if (typeof value === "number") return {
|
|
64686
|
+
kind: "number",
|
|
64687
|
+
value
|
|
64688
|
+
};
|
|
64689
|
+
if (typeof value === "string") return {
|
|
64690
|
+
kind: "string",
|
|
64691
|
+
value
|
|
64692
|
+
};
|
|
64693
|
+
return null;
|
|
64694
|
+
}
|
|
64695
|
+
if (isNodeOfType(unwrappedExpression, "Identifier") && unwrappedExpression.name === "undefined" && context.scopes.isGlobalReference(unwrappedExpression)) return {
|
|
64696
|
+
kind: "undefined",
|
|
64697
|
+
value: void 0
|
|
64698
|
+
};
|
|
64699
|
+
if (isNodeOfType(unwrappedExpression, "Identifier")) {
|
|
64700
|
+
const symbol = context.scopes.symbolFor(unwrappedExpression);
|
|
64701
|
+
const parameterValue = symbol ? state.parameterValuesBySymbolId.get(symbol.id) : null;
|
|
64702
|
+
if (symbol && parameterValue && !state.visitedSymbolIds.has(symbol.id)) {
|
|
64703
|
+
state.visitedSymbolIds.add(symbol.id);
|
|
64704
|
+
const result = readHydrationPrimitiveResult(parameterValue, context, runtime, state);
|
|
64705
|
+
state.visitedSymbolIds.delete(symbol.id);
|
|
64706
|
+
return result;
|
|
64707
|
+
}
|
|
64708
|
+
if (symbol && symbol.kind === "const" && symbol.initializer && symbol.references.every((reference) => reference.flag === "read") && !state.visitedSymbolIds.has(symbol.id)) {
|
|
64709
|
+
state.visitedSymbolIds.add(symbol.id);
|
|
64710
|
+
const result = readHydrationPrimitiveResult(symbol.initializer, context, runtime, state);
|
|
64711
|
+
state.visitedSymbolIds.delete(symbol.id);
|
|
64712
|
+
return result;
|
|
64713
|
+
}
|
|
64714
|
+
}
|
|
64715
|
+
if (isNodeOfType(unwrappedExpression, "UnaryExpression") && unwrappedExpression.operator === "!") {
|
|
64716
|
+
const argumentResult = readHydrationConditionResult(unwrappedExpression.argument, context, runtime, state);
|
|
64717
|
+
return argumentResult === null ? null : {
|
|
64718
|
+
kind: "boolean",
|
|
64719
|
+
value: !argumentResult
|
|
64720
|
+
};
|
|
64721
|
+
}
|
|
64722
|
+
if (isNodeOfType(unwrappedExpression, "BinaryExpression")) {
|
|
64723
|
+
const leftResult = readHydrationPrimitiveResult(unwrappedExpression.left, context, runtime, state);
|
|
64724
|
+
const rightResult = readHydrationPrimitiveResult(unwrappedExpression.right, context, runtime, state);
|
|
64725
|
+
if (!leftResult || !rightResult) return null;
|
|
64726
|
+
if (unwrappedExpression.operator === "===" || unwrappedExpression.operator === "!==") {
|
|
64727
|
+
const areEqual = leftResult.kind === rightResult.kind && leftResult.value === rightResult.value;
|
|
64728
|
+
return {
|
|
64729
|
+
kind: "boolean",
|
|
64730
|
+
value: unwrappedExpression.operator === "===" ? areEqual : !areEqual
|
|
64731
|
+
};
|
|
64732
|
+
}
|
|
64733
|
+
if (unwrappedExpression.operator === "==" || unwrappedExpression.operator === "!=") {
|
|
64734
|
+
const areEqual = areLooselyEqualPrimitiveResults(leftResult, rightResult);
|
|
64735
|
+
return {
|
|
64736
|
+
kind: "boolean",
|
|
64737
|
+
value: unwrappedExpression.operator === "==" ? areEqual : !areEqual
|
|
64738
|
+
};
|
|
64739
|
+
}
|
|
64740
|
+
}
|
|
64741
|
+
if (isNodeOfType(unwrappedExpression, "CallExpression")) {
|
|
64742
|
+
const callArguments = unwrappedExpression.arguments ?? [];
|
|
64743
|
+
const callee = stripParenExpression(unwrappedExpression.callee);
|
|
64744
|
+
if (isNodeOfType(callee, "Identifier") && callee.name === "Boolean" && context.scopes.isGlobalReference(callee) && callArguments.length === 1 && !isNodeOfType(callArguments[0], "SpreadElement")) {
|
|
64745
|
+
const argumentResult = readHydrationConditionResult(callArguments[0], context, runtime, state);
|
|
64746
|
+
return argumentResult === null ? null : {
|
|
64747
|
+
kind: "boolean",
|
|
64748
|
+
value: argumentResult
|
|
64749
|
+
};
|
|
64750
|
+
}
|
|
64751
|
+
}
|
|
64752
|
+
return null;
|
|
64753
|
+
};
|
|
63882
64754
|
const readHydrationConditionResult = (expression, context, runtime, state) => {
|
|
63883
64755
|
const unwrappedExpression = stripParenExpression(expression);
|
|
63884
64756
|
const predicateMatch = matchBrowserPredicate(unwrappedExpression, context);
|
|
@@ -63927,6 +64799,10 @@ const readHydrationConditionResult = (expression, context, runtime, state) => {
|
|
|
63927
64799
|
parameterValuesBySymbolId
|
|
63928
64800
|
});
|
|
63929
64801
|
}
|
|
64802
|
+
if (isNodeOfType(unwrappedExpression, "BinaryExpression")) {
|
|
64803
|
+
const result = readHydrationPrimitiveResult(unwrappedExpression, context, runtime, state);
|
|
64804
|
+
return result?.kind === "boolean" && typeof result.value === "boolean" ? result.value : null;
|
|
64805
|
+
}
|
|
63930
64806
|
if (isNodeOfType(unwrappedExpression, "UnaryExpression") && unwrappedExpression.operator === "!") {
|
|
63931
64807
|
const argumentResult = readHydrationConditionResult(unwrappedExpression.argument, context, runtime, state);
|
|
63932
64808
|
return argumentResult === null ? null : !argumentResult;
|
|
@@ -63987,13 +64863,19 @@ const doEquivalentExpressionBindingsMatch = (leftExpression, rightExpression, sc
|
|
|
63987
64863
|
const rightSymbol = scopes.symbolFor(right);
|
|
63988
64864
|
return leftSymbol || rightSymbol ? leftSymbol?.id === rightSymbol?.id : true;
|
|
63989
64865
|
}
|
|
63990
|
-
|
|
63991
|
-
|
|
63992
|
-
|
|
63993
|
-
|
|
63994
|
-
|
|
63995
|
-
|
|
63996
|
-
|
|
64866
|
+
const rightEntries = new Map(Object.entries(right));
|
|
64867
|
+
for (const [key, leftValue] of Object.entries(left)) {
|
|
64868
|
+
if (key === "parent") continue;
|
|
64869
|
+
const rightValue = rightEntries.get(key);
|
|
64870
|
+
if (isAstNode(leftValue)) {
|
|
64871
|
+
if (!isAstNode(rightValue) || !doEquivalentExpressionBindingsMatch(leftValue, rightValue, scopes)) return false;
|
|
64872
|
+
continue;
|
|
64873
|
+
}
|
|
64874
|
+
if (!Array.isArray(leftValue)) continue;
|
|
64875
|
+
if (!Array.isArray(rightValue)) return false;
|
|
64876
|
+
const leftNodes = leftValue.filter(isAstNode);
|
|
64877
|
+
const rightNodes = rightValue.filter(isAstNode);
|
|
64878
|
+
if (leftNodes.length !== rightNodes.length || leftNodes.some((leftNode, index) => !rightNodes[index] || !doEquivalentExpressionBindingsMatch(leftNode, rightNodes[index], scopes))) return false;
|
|
63997
64879
|
}
|
|
63998
64880
|
return true;
|
|
63999
64881
|
};
|
|
@@ -64007,6 +64889,57 @@ const doHelperReturnValuesDiffer = (leftValues, rightValues, context) => {
|
|
|
64007
64889
|
const everyValueHasEquivalent = (values, candidateValues) => values.every((value) => candidateValues.some((candidateValue) => areHelperReturnValuesEquivalent(value, candidateValue, context)));
|
|
64008
64890
|
return !everyValueHasEquivalent(leftValues, rightValues) || !everyValueHasEquivalent(rightValues, leftValues);
|
|
64009
64891
|
};
|
|
64892
|
+
const isExpressionProvablyReflexive = (expression, context, visitedSymbolIds = /* @__PURE__ */ new Set()) => {
|
|
64893
|
+
const unwrappedExpression = stripParenExpression(expression);
|
|
64894
|
+
if (matchBrowserPredicate(unwrappedExpression, context)) return true;
|
|
64895
|
+
if (isNodeOfType(unwrappedExpression, "Literal")) return typeof unwrappedExpression.value !== "number" || !Number.isNaN(unwrappedExpression.value);
|
|
64896
|
+
if (isNodeOfType(unwrappedExpression, "Identifier") && unwrappedExpression.name === "undefined" && context.scopes.isGlobalReference(unwrappedExpression)) return true;
|
|
64897
|
+
if (isNodeOfType(unwrappedExpression, "Identifier")) {
|
|
64898
|
+
const symbol = context.scopes.symbolFor(unwrappedExpression);
|
|
64899
|
+
if (!symbol || visitedSymbolIds.has(symbol.id) || !symbol.initializer) return false;
|
|
64900
|
+
visitedSymbolIds.add(symbol.id);
|
|
64901
|
+
const assignedValues = symbol.references.filter((reference) => reference.flag !== "read").map((reference) => getAssignedValue(reference.identifier));
|
|
64902
|
+
const isReflexive = isExpressionProvablyReflexive(symbol.initializer, context, visitedSymbolIds) && assignedValues.every((assignedValue) => Boolean(assignedValue && isExpressionProvablyReflexive(assignedValue, context, visitedSymbolIds)));
|
|
64903
|
+
visitedSymbolIds.delete(symbol.id);
|
|
64904
|
+
return isReflexive;
|
|
64905
|
+
}
|
|
64906
|
+
if (isNodeOfType(unwrappedExpression, "ConditionalExpression")) return isExpressionProvablyReflexive(unwrappedExpression.consequent, context, visitedSymbolIds) && isExpressionProvablyReflexive(unwrappedExpression.alternate, context, visitedSymbolIds);
|
|
64907
|
+
if (isNodeOfType(unwrappedExpression, "UnaryExpression") && (unwrappedExpression.operator === "!" || unwrappedExpression.operator === "typeof" || unwrappedExpression.operator === "void")) return true;
|
|
64908
|
+
if (isNodeOfType(unwrappedExpression, "BinaryExpression")) return unwrappedExpression.operator === "===" || unwrappedExpression.operator === "!==" || unwrappedExpression.operator === "==" || unwrappedExpression.operator === "!=";
|
|
64909
|
+
if (isNodeOfType(unwrappedExpression, "ArrayExpression") || isNodeOfType(unwrappedExpression, "ObjectExpression") || isNodeOfType(unwrappedExpression, "FunctionExpression") || isNodeOfType(unwrappedExpression, "ArrowFunctionExpression") || isNodeOfType(unwrappedExpression, "TemplateLiteral")) return true;
|
|
64910
|
+
if (!isNodeOfType(unwrappedExpression, "CallExpression")) return false;
|
|
64911
|
+
const callee = stripParenExpression(unwrappedExpression.callee);
|
|
64912
|
+
return isNodeOfType(callee, "Identifier") && callee.name === "Boolean" && context.scopes.isGlobalReference(callee);
|
|
64913
|
+
};
|
|
64914
|
+
const getReturnedObjectPropertyValues = (node, propertyName, scopes) => {
|
|
64915
|
+
if (isNodeOfType(node, "ReturnStatement")) return node.argument ? getReturnedObjectPropertyValues(node.argument, propertyName, scopes) : [];
|
|
64916
|
+
if (isNodeOfType(node, "ObjectExpression")) return node.properties.flatMap((property) => isNodeOfType(property, "Property") && property.kind === "init" && getResolvedStaticPropertyName(property, scopes) === propertyName ? [property.value] : []);
|
|
64917
|
+
if (isNodeOfType(node, "IfStatement")) return [...getReturnedObjectPropertyValues(node.consequent, propertyName, scopes), ...node.alternate ? getReturnedObjectPropertyValues(node.alternate, propertyName, scopes) : []];
|
|
64918
|
+
if (isNodeOfType(node, "TryStatement")) return [
|
|
64919
|
+
...getReturnedObjectPropertyValues(node.block, propertyName, scopes),
|
|
64920
|
+
...node.handler ? getReturnedObjectPropertyValues(node.handler.body, propertyName, scopes) : [],
|
|
64921
|
+
...node.finalizer ? getReturnedObjectPropertyValues(node.finalizer, propertyName, scopes) : []
|
|
64922
|
+
];
|
|
64923
|
+
if (!isNodeOfType(node, "BlockStatement")) return [];
|
|
64924
|
+
const propertyValues = [];
|
|
64925
|
+
for (const childStatement of node.body) {
|
|
64926
|
+
propertyValues.push(...getReturnedObjectPropertyValues(childStatement, propertyName, scopes));
|
|
64927
|
+
if (statementAlwaysExits$1(childStatement)) break;
|
|
64928
|
+
}
|
|
64929
|
+
return propertyValues;
|
|
64930
|
+
};
|
|
64931
|
+
const matchHydrationFunctionPropertyResult = (functionNode, propertyName, context, state) => {
|
|
64932
|
+
if (!isFunctionLike$1(functionNode) || state.visitedFunctionNodes.has(functionNode)) return null;
|
|
64933
|
+
state.visitedFunctionNodes.add(functionNode);
|
|
64934
|
+
const propertyValues = getReturnedObjectPropertyValues(functionNode.body, propertyName, context.scopes);
|
|
64935
|
+
let match = null;
|
|
64936
|
+
for (const propertyValue of propertyValues) {
|
|
64937
|
+
match = matchHydrationConditionInternal(propertyValue, context, state);
|
|
64938
|
+
if (match) break;
|
|
64939
|
+
}
|
|
64940
|
+
state.visitedFunctionNodes.delete(functionNode);
|
|
64941
|
+
return match;
|
|
64942
|
+
};
|
|
64010
64943
|
const matchHydrationConditionInternal = (expression, context, state) => {
|
|
64011
64944
|
const unwrappedExpression = stripParenExpression(expression);
|
|
64012
64945
|
const predicateMatch = matchBrowserPredicate(unwrappedExpression, context);
|
|
@@ -64023,14 +64956,90 @@ const matchHydrationConditionInternal = (expression, context, state) => {
|
|
|
64023
64956
|
state.visitedSymbolIds.delete(symbol.id);
|
|
64024
64957
|
return match;
|
|
64025
64958
|
}
|
|
64959
|
+
if (symbol && (symbol.kind === "let" || symbol.kind === "var") && !state.visitedSymbolIds.has(symbol.id)) {
|
|
64960
|
+
state.visitedSymbolIds.add(symbol.id);
|
|
64961
|
+
if (symbol.initializer && symbol.references.every((reference) => reference.flag === "read")) {
|
|
64962
|
+
const match = matchHydrationConditionInternal(symbol.initializer, context, state);
|
|
64963
|
+
state.visitedSymbolIds.delete(symbol.id);
|
|
64964
|
+
return match;
|
|
64965
|
+
}
|
|
64966
|
+
for (const reference of symbol.references) {
|
|
64967
|
+
if (reference.flag === "read") continue;
|
|
64968
|
+
if (!isNodeReachableWithinFunction(reference.identifier, context)) continue;
|
|
64969
|
+
const enclosingFunction = findEnclosingFunction$1(reference.identifier);
|
|
64970
|
+
if (!enclosingFunction) continue;
|
|
64971
|
+
for (const guardingIfStatement of findGuardingIfStatements(reference.identifier, enclosingFunction)) {
|
|
64972
|
+
if (doesGuardPreserveInitialSymbolValue(symbol, guardingIfStatement, context.scopes) || isWriteOverwrittenBefore(symbol, reference.identifier, guardingIfStatement, unwrappedExpression, context)) continue;
|
|
64973
|
+
const match = matchHydrationConditionInternal(guardingIfStatement.test, context, state);
|
|
64974
|
+
if (match) {
|
|
64975
|
+
state.visitedSymbolIds.delete(symbol.id);
|
|
64976
|
+
return match;
|
|
64977
|
+
}
|
|
64978
|
+
}
|
|
64979
|
+
}
|
|
64980
|
+
const readingFunction = findEnclosingFunction$1(unwrappedExpression);
|
|
64981
|
+
for (const reference of symbol.references) {
|
|
64982
|
+
if (reference.flag === "read") continue;
|
|
64983
|
+
const writingFunction = findEnclosingFunction$1(reference.identifier);
|
|
64984
|
+
if (!readingFunction || !isFunctionLike$1(writingFunction) || writingFunction === readingFunction || writingFunction.async || writingFunction.params.length > 0 || isNodeOfType(writingFunction, "FunctionDeclaration") && writingFunction.generator || isNodeOfType(writingFunction, "FunctionExpression") && writingFunction.generator) continue;
|
|
64985
|
+
const assignedValue = getAssignedValue(reference.identifier);
|
|
64986
|
+
if (symbol.initializer && assignedValue && areExpressionsStructurallyEqual(symbol.initializer, assignedValue) && doEquivalentExpressionBindingsMatch(symbol.initializer, assignedValue, context.scopes)) continue;
|
|
64987
|
+
const functionBinding = getDirectFunctionBindingIdentifier(writingFunction);
|
|
64988
|
+
if (!isNodeOfType(functionBinding, "Identifier")) continue;
|
|
64989
|
+
const functionSymbol = context.scopes.symbolFor(functionBinding);
|
|
64990
|
+
if (!functionSymbol) continue;
|
|
64991
|
+
for (const functionReference of functionSymbol.references) {
|
|
64992
|
+
const callExpression = functionReference.identifier.parent;
|
|
64993
|
+
if (!isNodeOfType(callExpression, "CallExpression") || callExpression.callee !== functionReference.identifier || (callExpression.arguments ?? []).length > 0 || findEnclosingFunction$1(callExpression) !== readingFunction || !isNodeReachableWithinFunction(callExpression, context) || getNodeStartIndex(callExpression) >= getNodeStartIndex(unwrappedExpression)) continue;
|
|
64994
|
+
for (const guardingIfStatement of findGuardingIfStatements(callExpression, readingFunction)) {
|
|
64995
|
+
if (isWriteOverwrittenBefore(symbol, callExpression, guardingIfStatement, unwrappedExpression, context)) continue;
|
|
64996
|
+
const match = matchHydrationConditionInternal(guardingIfStatement.test, context, state);
|
|
64997
|
+
if (match) {
|
|
64998
|
+
state.visitedSymbolIds.delete(symbol.id);
|
|
64999
|
+
return match;
|
|
65000
|
+
}
|
|
65001
|
+
}
|
|
65002
|
+
}
|
|
65003
|
+
}
|
|
65004
|
+
state.visitedSymbolIds.delete(symbol.id);
|
|
65005
|
+
}
|
|
64026
65006
|
if (!symbol || symbol.kind !== "const" || !symbol.initializer || symbol.references.some((reference) => reference.flag !== "read") || state.visitedSymbolIds.has(symbol.id)) return null;
|
|
64027
65007
|
state.visitedSymbolIds.add(symbol.id);
|
|
64028
65008
|
const match = matchHydrationConditionInternal(symbol.initializer, context, state);
|
|
64029
65009
|
state.visitedSymbolIds.delete(symbol.id);
|
|
64030
65010
|
return match;
|
|
64031
65011
|
}
|
|
65012
|
+
if (isNodeOfType(unwrappedExpression, "MemberExpression")) {
|
|
65013
|
+
const propertyName = getResolvedStaticPropertyName(unwrappedExpression, context.scopes, {
|
|
65014
|
+
allowConstNumericLiteral: true,
|
|
65015
|
+
stringifyNonStringLiterals: true
|
|
65016
|
+
});
|
|
65017
|
+
const object = stripParenExpression(unwrappedExpression.object);
|
|
65018
|
+
if (propertyName === null || !isNodeOfType(object, "CallExpression")) return null;
|
|
65019
|
+
const callArguments = object.arguments ?? [];
|
|
65020
|
+
if (isReactApiCall(object, "useMemo", context.scopes, {
|
|
65021
|
+
allowGlobalReactNamespace: true,
|
|
65022
|
+
resolveNamedAliases: true
|
|
65023
|
+
})) {
|
|
65024
|
+
const callbackArgument = callArguments[0];
|
|
65025
|
+
if (!callbackArgument || isNodeOfType(callbackArgument, "SpreadElement")) return null;
|
|
65026
|
+
const callbackFunction = resolveExactLocalFunction(callbackArgument, context.scopes);
|
|
65027
|
+
return isFunctionLike$1(callbackFunction) && callbackFunction.params.length === 0 ? matchHydrationFunctionPropertyResult(callbackFunction, propertyName, context, state) : null;
|
|
65028
|
+
}
|
|
65029
|
+
const helperFunction = resolveExactLocalFunction(object.callee, context.scopes);
|
|
65030
|
+
return isFunctionLike$1(helperFunction) && helperFunction.params.length === 0 && callArguments.length === 0 ? matchHydrationFunctionPropertyResult(helperFunction, propertyName, context, state) : null;
|
|
65031
|
+
}
|
|
64032
65032
|
if (isNodeOfType(unwrappedExpression, "CallExpression")) {
|
|
64033
65033
|
const callArguments = unwrappedExpression.arguments ?? [];
|
|
65034
|
+
if (isReactApiCall(unwrappedExpression, "useState", context.scopes, {
|
|
65035
|
+
allowGlobalReactNamespace: true,
|
|
65036
|
+
resolveNamedAliases: true
|
|
65037
|
+
})) {
|
|
65038
|
+
const initialState = callArguments[0];
|
|
65039
|
+
if (!initialState || isNodeOfType(initialState, "SpreadElement")) return null;
|
|
65040
|
+
const lazyInitializer = resolveExactLocalFunction(initialState, context.scopes);
|
|
65041
|
+
return isFunctionLike$1(lazyInitializer) && lazyInitializer.params.length === 0 ? matchHydrationFunctionResult(lazyInitializer, context, state) : matchHydrationConditionInternal(initialState, context, state);
|
|
65042
|
+
}
|
|
64034
65043
|
if (isReactApiCall(unwrappedExpression, "useMemo", context.scopes, {
|
|
64035
65044
|
allowGlobalReactNamespace: true,
|
|
64036
65045
|
resolveNamedAliases: true
|
|
@@ -64058,6 +65067,22 @@ const matchHydrationConditionInternal = (expression, context, state) => {
|
|
|
64058
65067
|
});
|
|
64059
65068
|
}
|
|
64060
65069
|
if (isNodeOfType(unwrappedExpression, "UnaryExpression") && unwrappedExpression.operator === "!") return matchHydrationConditionInternal(unwrappedExpression.argument, context, state);
|
|
65070
|
+
if (isNodeOfType(unwrappedExpression, "ConditionalExpression")) {
|
|
65071
|
+
const staticTestResult = readInitialStateBoolean(unwrappedExpression.test, context.scopes);
|
|
65072
|
+
if (staticTestResult !== null) return matchHydrationConditionInternal(staticTestResult ? unwrappedExpression.consequent : unwrappedExpression.alternate, context, state);
|
|
65073
|
+
return matchHydrationConditionInternal(unwrappedExpression.test, context, state) ?? matchHydrationConditionInternal(unwrappedExpression.consequent, context, state) ?? matchHydrationConditionInternal(unwrappedExpression.alternate, context, state);
|
|
65074
|
+
}
|
|
65075
|
+
if (isNodeOfType(unwrappedExpression, "BinaryExpression")) {
|
|
65076
|
+
if (unwrappedExpression.operator !== "===" && unwrappedExpression.operator !== "!==" && unwrappedExpression.operator !== "==" && unwrappedExpression.operator !== "!=") return null;
|
|
65077
|
+
const leftMatch = matchHydrationConditionInternal(unwrappedExpression.left, context, state);
|
|
65078
|
+
const rightMatch = matchHydrationConditionInternal(unwrappedExpression.right, context, state);
|
|
65079
|
+
const nestedMatch = leftMatch ?? rightMatch;
|
|
65080
|
+
if (!nestedMatch) return null;
|
|
65081
|
+
const clientResult = readHydrationConditionResult(unwrappedExpression, context, "client", state);
|
|
65082
|
+
const serverResult = readHydrationConditionResult(unwrappedExpression, context, "server", state);
|
|
65083
|
+
if (clientResult !== null && serverResult !== null) return clientResult !== serverResult ? nestedMatch : null;
|
|
65084
|
+
return leftMatch && rightMatch && areExpressionsStructurallyEqual(unwrappedExpression.left, unwrappedExpression.right) && doEquivalentExpressionBindingsMatch(unwrappedExpression.left, unwrappedExpression.right, context.scopes) && isExpressionProvablyReflexive(unwrappedExpression.left, context) ? null : nestedMatch;
|
|
65085
|
+
}
|
|
64061
65086
|
if (!isNodeOfType(unwrappedExpression, "LogicalExpression") || unwrappedExpression.operator !== "&&" && unwrappedExpression.operator !== "||") return null;
|
|
64062
65087
|
const leftMatch = matchHydrationConditionInternal(unwrappedExpression.left, context, state);
|
|
64063
65088
|
const rightMatch = matchHydrationConditionInternal(unwrappedExpression.right, context, state);
|
|
@@ -64074,8 +65099,13 @@ const matchHydrationReturningStatement = (statement, context, state) => {
|
|
|
64074
65099
|
const consequentValues = getReturnedValues(statement.consequent);
|
|
64075
65100
|
const alternateValues = statement.alternate ? getReturnedValues(statement.alternate) : findFollowingReturnedValues(statement);
|
|
64076
65101
|
if (conditionMatch && consequentValues.length > 0 && alternateValues.length > 0 && doHelperReturnValuesDiffer(consequentValues, alternateValues, context)) return conditionMatch;
|
|
65102
|
+
if (conditionMatch) {
|
|
65103
|
+
const followingReturnedValues = findFollowingReturnedValues(statement);
|
|
65104
|
+
if ([...new Set([...collectWrittenSymbols(statement.consequent, context.scopes), ...statement.alternate ? collectWrittenSymbols(statement.alternate, context.scopes) : []])].some((symbol) => !doesGuardPreserveInitialSymbolValue(symbol, statement, context.scopes) && followingReturnedValues.some((value) => doesNodeReadSymbol(value, symbol)))) return conditionMatch;
|
|
65105
|
+
}
|
|
64077
65106
|
return matchHydrationReturningStatement(statement.consequent, context, state) ?? (statement.alternate ? matchHydrationReturningStatement(statement.alternate, context, state) : null);
|
|
64078
65107
|
}
|
|
65108
|
+
if (isNodeOfType(statement, "TryStatement")) return matchHydrationReturningStatement(statement.block, context, state) ?? (statement.handler ? matchHydrationReturningStatement(statement.handler.body, context, state) : null) ?? (statement.finalizer ? matchHydrationReturningStatement(statement.finalizer, context, state) : null);
|
|
64079
65109
|
if (!isNodeOfType(statement, "BlockStatement")) return null;
|
|
64080
65110
|
for (const childStatement of statement.body) {
|
|
64081
65111
|
const match = matchHydrationReturningStatement(childStatement, context, state);
|
|
@@ -64096,47 +65126,62 @@ const matchHydrationCondition = (expression, context) => matchHydrationCondition
|
|
|
64096
65126
|
visitedFunctionNodes: /* @__PURE__ */ new Set(),
|
|
64097
65127
|
visitedSymbolIds: /* @__PURE__ */ new Set()
|
|
64098
65128
|
});
|
|
64099
|
-
const areNodeArraysEquivalent = (leftNodes, rightNodes) => leftNodes.length === rightNodes.length && leftNodes.every((leftNode, index) => areRenderedBranchesEquivalent(leftNode, rightNodes[index]));
|
|
64100
|
-
const areRenderedBranchesEquivalent = (leftNode, rightNode) => {
|
|
65129
|
+
const areNodeArraysEquivalent = (leftNodes, rightNodes, scopes) => leftNodes.length === rightNodes.length && leftNodes.every((leftNode, index) => areRenderedBranchesEquivalent(leftNode, rightNodes[index], scopes));
|
|
65130
|
+
const areRenderedBranchesEquivalent = (leftNode, rightNode, scopes) => {
|
|
64101
65131
|
if (!leftNode || !rightNode) return leftNode === rightNode;
|
|
64102
65132
|
const left = stripParenExpression(leftNode);
|
|
64103
65133
|
const right = stripParenExpression(rightNode);
|
|
64104
|
-
if (areExpressionsStructurallyEqual(left, right)) return
|
|
65134
|
+
if (areExpressionsStructurallyEqual(left, right)) return doEquivalentExpressionBindingsMatch(left, right, scopes);
|
|
64105
65135
|
if (left.type !== right.type) return false;
|
|
64106
65136
|
if (isNodeOfType(left, "JSXText") && isNodeOfType(right, "JSXText")) return left.value === right.value;
|
|
64107
65137
|
if (isNodeOfType(left, "JSXExpressionContainer") && isNodeOfType(right, "JSXExpressionContainer")) {
|
|
64108
65138
|
if (!isAstNode(left.expression) || !isAstNode(right.expression)) return left.expression.type === right.expression.type;
|
|
64109
|
-
return areRenderedBranchesEquivalent(left.expression, right.expression);
|
|
65139
|
+
return areRenderedBranchesEquivalent(left.expression, right.expression, scopes);
|
|
64110
65140
|
}
|
|
64111
65141
|
if (isNodeOfType(left, "JSXElement") && isNodeOfType(right, "JSXElement")) {
|
|
64112
65142
|
if (flattenJsxName$1(left.openingElement.name) !== flattenJsxName$1(right.openingElement.name)) return false;
|
|
64113
|
-
if (!areNodeArraysEquivalent(left.openingElement.attributes, right.openingElement.attributes)) return false;
|
|
64114
|
-
return areNodeArraysEquivalent(left.children, right.children);
|
|
65143
|
+
if (!areNodeArraysEquivalent(left.openingElement.attributes, right.openingElement.attributes, scopes)) return false;
|
|
65144
|
+
return areNodeArraysEquivalent(left.children, right.children, scopes);
|
|
64115
65145
|
}
|
|
64116
|
-
if (isNodeOfType(left, "JSXFragment") && isNodeOfType(right, "JSXFragment")) return areNodeArraysEquivalent(left.children, right.children);
|
|
65146
|
+
if (isNodeOfType(left, "JSXFragment") && isNodeOfType(right, "JSXFragment")) return areNodeArraysEquivalent(left.children, right.children, scopes);
|
|
64117
65147
|
if (isNodeOfType(left, "JSXAttribute") && isNodeOfType(right, "JSXAttribute")) {
|
|
64118
65148
|
if (flattenJsxName$1(left.name) !== flattenJsxName$1(right.name)) return false;
|
|
64119
|
-
return areRenderedBranchesEquivalent(left.value, right.value);
|
|
65149
|
+
return areRenderedBranchesEquivalent(left.value, right.value, scopes);
|
|
64120
65150
|
}
|
|
64121
|
-
if (isNodeOfType(left, "JSXSpreadAttribute") && isNodeOfType(right, "JSXSpreadAttribute")) return areRenderedBranchesEquivalent(left.argument, right.argument);
|
|
65151
|
+
if (isNodeOfType(left, "JSXSpreadAttribute") && isNodeOfType(right, "JSXSpreadAttribute")) return areRenderedBranchesEquivalent(left.argument, right.argument, scopes);
|
|
64122
65152
|
if (isNodeOfType(left, "TemplateLiteral") && isNodeOfType(right, "TemplateLiteral")) {
|
|
64123
65153
|
if (left.quasis.length !== right.quasis.length) return false;
|
|
64124
65154
|
if (!left.quasis.every((quasi, index) => quasi.value.cooked === right.quasis[index]?.value.cooked && quasi.value.raw === right.quasis[index]?.value.raw)) return false;
|
|
64125
|
-
return areNodeArraysEquivalent(left.expressions, right.expressions);
|
|
65155
|
+
return areNodeArraysEquivalent(left.expressions, right.expressions, scopes);
|
|
64126
65156
|
}
|
|
64127
65157
|
return false;
|
|
64128
65158
|
};
|
|
64129
|
-
const
|
|
65159
|
+
const isProvenReactCreateElementCall = (node, scopes) => {
|
|
65160
|
+
if (isReactApiCall(node, "createElement", scopes, {
|
|
65161
|
+
allowGlobalReactNamespace: true,
|
|
65162
|
+
resolveNamedAliases: true
|
|
65163
|
+
})) return true;
|
|
65164
|
+
if (!isNodeOfType(node, "CallExpression")) return false;
|
|
65165
|
+
const callee = stripParenExpression(node.callee);
|
|
65166
|
+
if (!isNodeOfType(callee, "MemberExpression") || callee.computed || !isNodeOfType(callee.property, "Identifier") || callee.property.name !== "createElement") return false;
|
|
65167
|
+
const receiver = stripParenExpression(callee.object);
|
|
65168
|
+
const namespaceIdentifier = isNodeOfType(receiver, "MemberExpression") && !receiver.computed && isNodeOfType(receiver.property, "Identifier") && receiver.property.name === "default" ? stripParenExpression(receiver.object) : receiver;
|
|
65169
|
+
if (!isNodeOfType(namespaceIdentifier, "Identifier")) return false;
|
|
65170
|
+
const namespaceSymbol = scopes.symbolFor(namespaceIdentifier);
|
|
65171
|
+
return Boolean(namespaceSymbol?.initializer && namespaceSymbol.references.every((reference) => reference.flag === "read") && containsExplicitReactRuntimeReference(namespaceSymbol.initializer, scopes));
|
|
65172
|
+
};
|
|
65173
|
+
const isRenderedValue = (node, scopes) => {
|
|
64130
65174
|
const unwrappedNode = stripParenExpression(node);
|
|
64131
65175
|
if (isNodeOfType(unwrappedNode, "Literal")) return unwrappedNode.value !== null && unwrappedNode.value !== true && unwrappedNode.value !== false && unwrappedNode.value !== "";
|
|
64132
65176
|
if (isNodeOfType(unwrappedNode, "TemplateLiteral")) return unwrappedNode.expressions.length > 0 || unwrappedNode.quasis[0]?.value.cooked !== "";
|
|
65177
|
+
if (isNodeOfType(unwrappedNode, "CallExpression")) return isProvenReactCreateElementCall(unwrappedNode, scopes);
|
|
64133
65178
|
return isNodeOfType(unwrappedNode, "JSXElement") || isNodeOfType(unwrappedNode, "JSXFragment");
|
|
64134
65179
|
};
|
|
64135
|
-
const findRenderedValueInAndBranch = (node) => {
|
|
65180
|
+
const findRenderedValueInAndBranch = (node, scopes) => {
|
|
64136
65181
|
const unwrappedNode = stripParenExpression(node);
|
|
64137
|
-
if (
|
|
65182
|
+
if (isPotentiallyRenderedValue(unwrappedNode, scopes)) return unwrappedNode;
|
|
64138
65183
|
if (!isNodeOfType(unwrappedNode, "LogicalExpression") || unwrappedNode.operator !== "&&") return null;
|
|
64139
|
-
return findRenderedValueInAndBranch(unwrappedNode.right);
|
|
65184
|
+
return findRenderedValueInAndBranch(unwrappedNode.right, scopes);
|
|
64140
65185
|
};
|
|
64141
65186
|
const findEnclosingJsxAttribute = (node) => {
|
|
64142
65187
|
let currentNode = node.parent;
|
|
@@ -64169,6 +65214,11 @@ const getReturnedValues = (statement) => {
|
|
|
64169
65214
|
if (!statement) return [];
|
|
64170
65215
|
if (isNodeOfType(statement, "ReturnStatement")) return statement.argument ? [statement.argument] : [];
|
|
64171
65216
|
if (isNodeOfType(statement, "IfStatement")) return [...getReturnedValues(statement.consequent), ...getReturnedValues(statement.alternate)];
|
|
65217
|
+
if (isNodeOfType(statement, "TryStatement")) return [
|
|
65218
|
+
...getReturnedValues(statement.block),
|
|
65219
|
+
...getReturnedValues(statement.handler?.body),
|
|
65220
|
+
...getReturnedValues(statement.finalizer)
|
|
65221
|
+
];
|
|
64172
65222
|
if (!isNodeOfType(statement, "BlockStatement")) return [];
|
|
64173
65223
|
const returnedValues = [];
|
|
64174
65224
|
for (const childStatement of statement.body) {
|
|
@@ -64177,6 +65227,127 @@ const getReturnedValues = (statement) => {
|
|
|
64177
65227
|
}
|
|
64178
65228
|
return returnedValues;
|
|
64179
65229
|
};
|
|
65230
|
+
const isPotentiallyRenderedValueInternal = (node, scopes, visitedFunctionNodes) => {
|
|
65231
|
+
const unwrappedNode = stripParenExpression(node);
|
|
65232
|
+
if (isRenderedValue(unwrappedNode, scopes)) return true;
|
|
65233
|
+
if (isNodeOfType(unwrappedNode, "ConditionalExpression")) return isPotentiallyRenderedValueInternal(unwrappedNode.consequent, scopes, visitedFunctionNodes) && isPotentiallyRenderedValueInternal(unwrappedNode.alternate, scopes, visitedFunctionNodes);
|
|
65234
|
+
if (isNodeOfType(unwrappedNode, "LogicalExpression")) return isPotentiallyRenderedValueInternal(unwrappedNode.right, scopes, visitedFunctionNodes);
|
|
65235
|
+
if (!isNodeOfType(unwrappedNode, "CallExpression")) return false;
|
|
65236
|
+
const calledFunction = resolveExactLocalFunction(unwrappedNode.callee, scopes);
|
|
65237
|
+
if (!isFunctionLike$1(calledFunction) || visitedFunctionNodes.has(calledFunction)) return false;
|
|
65238
|
+
visitedFunctionNodes.add(calledFunction);
|
|
65239
|
+
const returnedValues = isNodeOfType(calledFunction.body, "BlockStatement") ? getReturnedValues(calledFunction.body) : [calledFunction.body];
|
|
65240
|
+
const isPotentiallyRendered = returnedValues.length > 0 && returnedValues.every((returnedValue) => isPotentiallyRenderedValueInternal(returnedValue, scopes, visitedFunctionNodes));
|
|
65241
|
+
visitedFunctionNodes.delete(calledFunction);
|
|
65242
|
+
return isPotentiallyRendered;
|
|
65243
|
+
};
|
|
65244
|
+
const isPotentiallyRenderedValue = (node, scopes) => isPotentiallyRenderedValueInternal(node, scopes, /* @__PURE__ */ new Set());
|
|
65245
|
+
const findUseStateBindingSymbol = (node, componentOrHookNode, scopes) => {
|
|
65246
|
+
let currentNode = node.parent;
|
|
65247
|
+
while (currentNode && currentNode !== componentOrHookNode) {
|
|
65248
|
+
if (isNodeOfType(currentNode, "CallExpression") && isReactApiCall(currentNode, "useState", scopes, {
|
|
65249
|
+
allowGlobalReactNamespace: true,
|
|
65250
|
+
resolveNamedAliases: true
|
|
65251
|
+
}) && isNodeOfType(currentNode.parent, "VariableDeclarator") && isNodeOfType(currentNode.parent.id, "ArrayPattern")) {
|
|
65252
|
+
const stateBinding = currentNode.parent.id.elements?.[0];
|
|
65253
|
+
return isNodeOfType(stateBinding, "Identifier") ? scopes.symbolFor(stateBinding) : null;
|
|
65254
|
+
}
|
|
65255
|
+
if (isFunctionLike$1(currentNode)) return null;
|
|
65256
|
+
currentNode = currentNode.parent;
|
|
65257
|
+
}
|
|
65258
|
+
return null;
|
|
65259
|
+
};
|
|
65260
|
+
const doesReferenceControlStructuralRenderedValue = (referenceIdentifier) => {
|
|
65261
|
+
let currentNode = referenceIdentifier;
|
|
65262
|
+
let parentNode = currentNode.parent;
|
|
65263
|
+
while (parentNode) {
|
|
65264
|
+
if (isNodeOfType(parentNode, "ConditionalExpression") && parentNode.test === currentNode && (isStructuralRenderedValue(parentNode.consequent) || isStructuralRenderedValue(parentNode.alternate))) return true;
|
|
65265
|
+
if (isNodeOfType(parentNode, "LogicalExpression") && parentNode.left === currentNode && isStructuralRenderedValue(parentNode.right)) return true;
|
|
65266
|
+
if (isNodeOfType(parentNode, "JSXExpressionContainer") || isFunctionLike$1(parentNode)) return false;
|
|
65267
|
+
currentNode = parentNode;
|
|
65268
|
+
parentNode = currentNode.parent;
|
|
65269
|
+
}
|
|
65270
|
+
return false;
|
|
65271
|
+
};
|
|
65272
|
+
const isRenderedHydrationConsumer = (node, producerHookNode, scopes) => {
|
|
65273
|
+
const renderingComponent = findRenderPhaseComponentOrHook(node, scopes);
|
|
65274
|
+
return Boolean(renderingComponent && renderingComponent !== producerHookNode && isInRenderedOutput(node, renderingComponent, scopes) && !isGatedByFalsyInitialState(node, scopes) && !isAfterClientOnlyEarlyReturn(node, renderingComponent, scopes) && (!hasSuppressHydrationWarningAttribute(findEnclosingJsxOpeningElement(node)) || doesReferenceControlStructuralRenderedValue(node)));
|
|
65275
|
+
};
|
|
65276
|
+
const doesConsumerExpressionReachRenderedOutput = (node, producerHookNode, scopes, visitedSymbolIds) => {
|
|
65277
|
+
if (isRenderedHydrationConsumer(node, producerHookNode, scopes)) return true;
|
|
65278
|
+
const parentNode = node.parent;
|
|
65279
|
+
if (!isNodeOfType(parentNode, "VariableDeclarator") || parentNode.init !== node || !isNodeOfType(parentNode.id, "Identifier")) return false;
|
|
65280
|
+
const aliasSymbol = scopes.symbolFor(parentNode.id);
|
|
65281
|
+
if (!aliasSymbol || visitedSymbolIds.has(aliasSymbol.id)) return false;
|
|
65282
|
+
visitedSymbolIds.add(aliasSymbol.id);
|
|
65283
|
+
const doesReachRenderedOutput = aliasSymbol.references.some((reference) => doesConsumerExpressionReachRenderedOutput(reference.identifier, producerHookNode, scopes, visitedSymbolIds));
|
|
65284
|
+
visitedSymbolIds.delete(aliasSymbol.id);
|
|
65285
|
+
return doesReachRenderedOutput;
|
|
65286
|
+
};
|
|
65287
|
+
const doesConsumerBindingReachRenderedOutput = (bindingIdentifier, producerHookNode, scopes) => {
|
|
65288
|
+
if (!isNodeOfType(bindingIdentifier, "Identifier")) return false;
|
|
65289
|
+
const consumerSymbol = scopes.symbolFor(bindingIdentifier);
|
|
65290
|
+
if (!consumerSymbol) return false;
|
|
65291
|
+
return consumerSymbol.references.some((reference) => doesConsumerExpressionReachRenderedOutput(reference.identifier, producerHookNode, scopes, new Set([consumerSymbol.id])));
|
|
65292
|
+
};
|
|
65293
|
+
const getReturnedStatePaths = (returnedValue, stateSymbol, scopes) => {
|
|
65294
|
+
const unwrappedValue = stripParenExpression(returnedValue);
|
|
65295
|
+
if (isNodeOfType(unwrappedValue, "ObjectExpression")) return unwrappedValue.properties.flatMap((property) => {
|
|
65296
|
+
if (!isNodeOfType(property, "Property") || property.kind !== "init" || !doesNodeReadSymbol(property.value, stateSymbol)) return [];
|
|
65297
|
+
const propertyName = getResolvedStaticPropertyName(property, scopes);
|
|
65298
|
+
return propertyName === null ? [] : [{
|
|
65299
|
+
kind: "property",
|
|
65300
|
+
key: propertyName
|
|
65301
|
+
}];
|
|
65302
|
+
});
|
|
65303
|
+
if (isNodeOfType(unwrappedValue, "ArrayExpression")) return (unwrappedValue.elements ?? []).flatMap((element, index) => element && isAstNode(element) && doesNodeReadSymbol(element, stateSymbol) ? [{
|
|
65304
|
+
kind: "index",
|
|
65305
|
+
key: String(index)
|
|
65306
|
+
}] : []);
|
|
65307
|
+
return doesNodeReadSymbol(unwrappedValue, stateSymbol) ? [{
|
|
65308
|
+
kind: "direct",
|
|
65309
|
+
key: null
|
|
65310
|
+
}] : [];
|
|
65311
|
+
};
|
|
65312
|
+
const doesCallResultPathReachRenderedOutput = (callExpression, returnedStatePath, producerHookNode, scopes) => {
|
|
65313
|
+
const callParent = callExpression.parent;
|
|
65314
|
+
if (returnedStatePath.kind === "direct") return doesConsumerExpressionReachRenderedOutput(callExpression, producerHookNode, scopes, /* @__PURE__ */ new Set());
|
|
65315
|
+
if (isNodeOfType(callParent, "MemberExpression") && callParent.object === callExpression && getResolvedStaticPropertyName(callParent, scopes, {
|
|
65316
|
+
allowConstNumericLiteral: true,
|
|
65317
|
+
stringifyNonStringLiterals: true
|
|
65318
|
+
}) === returnedStatePath.key) return doesConsumerExpressionReachRenderedOutput(callParent, producerHookNode, scopes, /* @__PURE__ */ new Set());
|
|
65319
|
+
if (!isNodeOfType(callParent, "VariableDeclarator") || callParent.init !== callExpression) return false;
|
|
65320
|
+
if (returnedStatePath.kind === "property" && isNodeOfType(callParent.id, "ObjectPattern")) return callParent.id.properties.some((property) => isNodeOfType(property, "Property") && getResolvedStaticPropertyName(property, scopes) === returnedStatePath.key && doesConsumerBindingReachRenderedOutput(property.value, producerHookNode, scopes));
|
|
65321
|
+
if (returnedStatePath.kind === "index" && isNodeOfType(callParent.id, "ArrayPattern")) {
|
|
65322
|
+
const element = callParent.id.elements?.[Number(returnedStatePath.key)];
|
|
65323
|
+
return Boolean(element && doesConsumerBindingReachRenderedOutput(element, producerHookNode, scopes));
|
|
65324
|
+
}
|
|
65325
|
+
if (!isNodeOfType(callParent.id, "Identifier")) return false;
|
|
65326
|
+
const resultSymbol = scopes.symbolFor(callParent.id);
|
|
65327
|
+
if (!resultSymbol) return false;
|
|
65328
|
+
return resultSymbol.references.some((reference) => {
|
|
65329
|
+
const memberExpression = reference.identifier.parent;
|
|
65330
|
+
return Boolean(isNodeOfType(memberExpression, "MemberExpression") && memberExpression.object === reference.identifier && getResolvedStaticPropertyName(memberExpression, scopes, {
|
|
65331
|
+
allowConstNumericLiteral: true,
|
|
65332
|
+
stringifyNonStringLiterals: true
|
|
65333
|
+
}) === returnedStatePath.key && doesConsumerExpressionReachRenderedOutput(memberExpression, producerHookNode, scopes, new Set([resultSymbol.id])));
|
|
65334
|
+
});
|
|
65335
|
+
};
|
|
65336
|
+
const isReturnedUseStateInitializerRendered = (node, componentOrHookNode, scopes) => {
|
|
65337
|
+
if (!isFunctionLike$1(componentOrHookNode)) return false;
|
|
65338
|
+
const stateSymbol = findUseStateBindingSymbol(node, componentOrHookNode, scopes);
|
|
65339
|
+
if (!stateSymbol) return false;
|
|
65340
|
+
const returnedStatePaths = (isNodeOfType(componentOrHookNode.body, "BlockStatement") ? getReturnedValues(componentOrHookNode.body) : [componentOrHookNode.body]).flatMap((returnedValue) => getReturnedStatePaths(returnedValue, stateSymbol, scopes));
|
|
65341
|
+
if (returnedStatePaths.length === 0) return false;
|
|
65342
|
+
const functionBinding = getDirectFunctionBindingIdentifier(componentOrHookNode);
|
|
65343
|
+
if (!isNodeOfType(functionBinding, "Identifier")) return false;
|
|
65344
|
+
const functionSymbol = scopes.symbolFor(functionBinding);
|
|
65345
|
+
if (!functionSymbol) return false;
|
|
65346
|
+
return functionSymbol.references.some((functionReference) => {
|
|
65347
|
+
const callExpression = functionReference.identifier.parent;
|
|
65348
|
+
return Boolean(isNodeOfType(callExpression, "CallExpression") && callExpression.callee === functionReference.identifier && returnedStatePaths.some((returnedStatePath) => doesCallResultPathReachRenderedOutput(callExpression, returnedStatePath, componentOrHookNode, scopes)));
|
|
65349
|
+
});
|
|
65350
|
+
};
|
|
64180
65351
|
const findFollowingReturnedValues = (ifStatement) => {
|
|
64181
65352
|
const parentNode = ifStatement.parent;
|
|
64182
65353
|
if (!isNodeOfType(parentNode, "BlockStatement")) return [];
|
|
@@ -64189,24 +65360,24 @@ const findFollowingReturnedValues = (ifStatement) => {
|
|
|
64189
65360
|
}
|
|
64190
65361
|
return returnedValues;
|
|
64191
65362
|
};
|
|
64192
|
-
const areConditionExpressionsEquivalent = (leftExpression, rightExpression) => {
|
|
65363
|
+
const areConditionExpressionsEquivalent = (leftExpression, rightExpression, scopes) => {
|
|
64193
65364
|
const left = stripParenExpression(leftExpression);
|
|
64194
65365
|
const right = stripParenExpression(rightExpression);
|
|
64195
|
-
if (areExpressionsStructurallyEqual(left, right)) return
|
|
65366
|
+
if (areExpressionsStructurallyEqual(left, right)) return doEquivalentExpressionBindingsMatch(left, right, scopes);
|
|
64196
65367
|
if (left.type !== right.type) return false;
|
|
64197
|
-
if (isNodeOfType(left, "UnaryExpression") && isNodeOfType(right, "UnaryExpression")) return left.operator === right.operator && areConditionExpressionsEquivalent(left.argument, right.argument);
|
|
64198
|
-
if (isNodeOfType(left, "LogicalExpression") && isNodeOfType(right, "LogicalExpression")) return left.operator === right.operator && areConditionExpressionsEquivalent(left.left, right.left) && areConditionExpressionsEquivalent(left.right, right.right);
|
|
64199
|
-
if (isNodeOfType(left, "BinaryExpression") && isNodeOfType(right, "BinaryExpression")) return left.operator === right.operator && areConditionExpressionsEquivalent(left.left, right.left) && areConditionExpressionsEquivalent(left.right, right.right);
|
|
65368
|
+
if (isNodeOfType(left, "UnaryExpression") && isNodeOfType(right, "UnaryExpression")) return left.operator === right.operator && areConditionExpressionsEquivalent(left.argument, right.argument, scopes);
|
|
65369
|
+
if (isNodeOfType(left, "LogicalExpression") && isNodeOfType(right, "LogicalExpression")) return left.operator === right.operator && areConditionExpressionsEquivalent(left.left, right.left, scopes) && areConditionExpressionsEquivalent(left.right, right.right, scopes);
|
|
65370
|
+
if (isNodeOfType(left, "BinaryExpression") && isNodeOfType(right, "BinaryExpression")) return left.operator === right.operator && areConditionExpressionsEquivalent(left.left, right.left, scopes) && areConditionExpressionsEquivalent(left.right, right.right, scopes);
|
|
64200
65371
|
return false;
|
|
64201
65372
|
};
|
|
64202
|
-
const areReturnTreesEquivalent = (leftStatement, rightStatement) => {
|
|
65373
|
+
const areReturnTreesEquivalent = (leftStatement, rightStatement, scopes) => {
|
|
64203
65374
|
if (!leftStatement || !rightStatement) return leftStatement === rightStatement;
|
|
64204
|
-
if (isNodeOfType(leftStatement, "ReturnStatement") && isNodeOfType(rightStatement, "ReturnStatement")) return areRenderedBranchesEquivalent(leftStatement.argument, rightStatement.argument);
|
|
64205
|
-
if (isNodeOfType(leftStatement, "IfStatement") && isNodeOfType(rightStatement, "IfStatement")) return areConditionExpressionsEquivalent(leftStatement.test, rightStatement.test) && areReturnTreesEquivalent(leftStatement.consequent, rightStatement.consequent) && areReturnTreesEquivalent(leftStatement.alternate, rightStatement.alternate);
|
|
65375
|
+
if (isNodeOfType(leftStatement, "ReturnStatement") && isNodeOfType(rightStatement, "ReturnStatement")) return areRenderedBranchesEquivalent(leftStatement.argument, rightStatement.argument, scopes);
|
|
65376
|
+
if (isNodeOfType(leftStatement, "IfStatement") && isNodeOfType(rightStatement, "IfStatement")) return areConditionExpressionsEquivalent(leftStatement.test, rightStatement.test, scopes) && areReturnTreesEquivalent(leftStatement.consequent, rightStatement.consequent, scopes) && areReturnTreesEquivalent(leftStatement.alternate, rightStatement.alternate, scopes);
|
|
64206
65377
|
if (!isNodeOfType(leftStatement, "BlockStatement") || !isNodeOfType(rightStatement, "BlockStatement")) return false;
|
|
64207
65378
|
const leftReturningStatements = leftStatement.body.filter((statement) => getReturnedValues(statement).length > 0);
|
|
64208
65379
|
const rightReturningStatements = rightStatement.body.filter((statement) => getReturnedValues(statement).length > 0);
|
|
64209
|
-
return leftReturningStatements.length === rightReturningStatements.length && leftReturningStatements.every((statement, index) => areReturnTreesEquivalent(statement, rightReturningStatements[index]));
|
|
65380
|
+
return leftReturningStatements.length === rightReturningStatements.length && leftReturningStatements.every((statement, index) => areReturnTreesEquivalent(statement, rightReturningStatements[index], scopes));
|
|
64210
65381
|
};
|
|
64211
65382
|
const isStructuralRenderedValue = (node) => {
|
|
64212
65383
|
if (!node) return false;
|
|
@@ -64230,19 +65401,22 @@ const noHydrationBranchOnBrowserGlobal = defineRule({
|
|
|
64230
65401
|
if (isTestlikeFilename(context.filename)) return {};
|
|
64231
65402
|
if (classifyReactNativeFileTarget(context) === "react-native") return {};
|
|
64232
65403
|
let fileHasUseClientDirective = false;
|
|
65404
|
+
let fileHasExplicitReactRuntimeReference = false;
|
|
64233
65405
|
let fileIsEmailTemplate = false;
|
|
64234
65406
|
const reportedNodes = /* @__PURE__ */ new Set();
|
|
64235
|
-
const reportHydrationBranch = (conditionNode, leftBranch, rightBranch, requiresRenderedContext) => {
|
|
65407
|
+
const reportHydrationBranch = (conditionNode, leftBranch, rightBranch, requiresRenderedContext, hasProvenRenderedConsumer = false) => {
|
|
64236
65408
|
const conditionMatch = matchHydrationCondition(conditionNode, context);
|
|
64237
65409
|
if (!conditionMatch) return;
|
|
64238
65410
|
const { predicateMatch, predicateNode } = conditionMatch;
|
|
64239
65411
|
if (reportedNodes.has(predicateNode)) return;
|
|
64240
|
-
if (rightBranch && areRenderedBranchesEquivalent(leftBranch, rightBranch)) return;
|
|
64241
|
-
const
|
|
65412
|
+
if (rightBranch && areRenderedBranchesEquivalent(leftBranch, rightBranch, context.scopes)) return;
|
|
65413
|
+
const enclosingFunction = findEnclosingFunction$1(conditionNode);
|
|
65414
|
+
const componentOrHookNode = findRenderPhaseComponentOrHook(conditionNode, context.scopes) ?? (enclosingFunction ? findComponentRenderingLocalFunctionResult(enclosingFunction, context.scopes) : null);
|
|
64242
65415
|
if (!componentOrHookNode) return;
|
|
64243
|
-
|
|
64244
|
-
if (
|
|
64245
|
-
if (!
|
|
65416
|
+
const hasRenderedLocalFunctionConsumer = Boolean(enclosingFunction && enclosingFunction !== componentOrHookNode && findComponentRenderingLocalFunctionResult(enclosingFunction, context.scopes) === componentOrHookNode);
|
|
65417
|
+
if (!hasClientRenderEvidence(componentOrHookNode, fileHasUseClientDirective) && !fileHasExplicitReactRuntimeReference) return;
|
|
65418
|
+
if (requiresRenderedContext && !isInRenderedOutput(conditionNode, componentOrHookNode, context.scopes) && !hasRenderedLocalFunctionConsumer) return;
|
|
65419
|
+
if (!hasProvenRenderedConsumer && !(requiresRenderedContext ? isPotentiallyRenderedValue(leftBranch, context.scopes) : isRenderedValue(leftBranch, context.scopes)) && (!rightBranch || !(requiresRenderedContext ? isPotentiallyRenderedValue(rightBranch, context.scopes) : isRenderedValue(rightBranch, context.scopes)))) {
|
|
64246
65420
|
const attribute = findEnclosingJsxAttribute(conditionNode);
|
|
64247
65421
|
if (!attribute || isEventHandlerAttribute(attribute)) return;
|
|
64248
65422
|
}
|
|
@@ -64261,28 +65435,31 @@ const noHydrationBranchOnBrowserGlobal = defineRule({
|
|
|
64261
65435
|
return {
|
|
64262
65436
|
Program(node) {
|
|
64263
65437
|
fileHasUseClientDirective = hasDirective(node, "use client");
|
|
65438
|
+
fileHasExplicitReactRuntimeReference = containsExplicitReactRuntimeReference(node, context.scopes);
|
|
64264
65439
|
fileIsEmailTemplate = hasEmailTemplateImport(node);
|
|
64265
65440
|
},
|
|
64266
65441
|
ConditionalExpression(node) {
|
|
64267
65442
|
reportHydrationBranch(node.test, node.consequent, node.alternate, true);
|
|
65443
|
+
const componentOrHookNode = findRenderPhaseComponentOrHook(node, context.scopes);
|
|
65444
|
+
if (componentOrHookNode && isReturnedUseStateInitializerRendered(node, componentOrHookNode, context.scopes)) reportHydrationBranch(node.test, node.consequent, node.alternate, false, true);
|
|
64268
65445
|
},
|
|
64269
65446
|
LogicalExpression(node) {
|
|
64270
65447
|
if (node.operator !== "&&" && node.operator !== "||") return;
|
|
64271
|
-
const renderedValue = node.operator === "&&" ? findRenderedValueInAndBranch(node.right) :
|
|
65448
|
+
const renderedValue = node.operator === "&&" ? findRenderedValueInAndBranch(node.right, context.scopes) : isPotentiallyRenderedValue(node.right, context.scopes) ? node.right : null;
|
|
64272
65449
|
if (!renderedValue) return;
|
|
64273
65450
|
reportHydrationBranch(node, renderedValue, null, true);
|
|
64274
65451
|
},
|
|
64275
65452
|
IfStatement(node) {
|
|
64276
|
-
if (node.alternate && areReturnTreesEquivalent(node.consequent, node.alternate)) return;
|
|
65453
|
+
if (node.alternate && areReturnTreesEquivalent(node.consequent, node.alternate, context.scopes)) return;
|
|
64277
65454
|
const consequentValues = getReturnedValues(node.consequent);
|
|
64278
65455
|
const alternateValues = node.alternate ? getReturnedValues(node.alternate) : findFollowingReturnedValues(node);
|
|
64279
65456
|
if (consequentValues.length === 0 || alternateValues.length === 0) return;
|
|
64280
|
-
const componentOrHookNode = findRenderPhaseComponentOrHook(node.test, context.scopes);
|
|
64281
|
-
if (!componentOrHookNode) return;
|
|
64282
65457
|
const enclosingFunction = findEnclosingFunction$1(node);
|
|
64283
|
-
|
|
65458
|
+
const componentOrHookNode = findRenderPhaseComponentOrHook(node.test, context.scopes) ?? (enclosingFunction ? findComponentRenderingLocalFunctionResult(enclosingFunction, context.scopes) : null);
|
|
65459
|
+
if (!componentOrHookNode) return;
|
|
65460
|
+
if (enclosingFunction !== componentOrHookNode && (!enclosingFunction || !isInRenderedOutput(enclosingFunction, componentOrHookNode, context.scopes) && findComponentRenderingLocalFunctionResult(enclosingFunction, context.scopes) !== componentOrHookNode)) return;
|
|
64284
65461
|
for (const consequentValue of consequentValues) for (const alternateValue of alternateValues) {
|
|
64285
|
-
if (!isRenderedValue(consequentValue) && !isRenderedValue(alternateValue)) continue;
|
|
65462
|
+
if (!isRenderedValue(consequentValue, context.scopes) && !isRenderedValue(alternateValue, context.scopes)) continue;
|
|
64286
65463
|
reportHydrationBranch(node.test, consequentValue, alternateValue, false);
|
|
64287
65464
|
}
|
|
64288
65465
|
}
|
|
@@ -66016,6 +67193,124 @@ const isInsideSnapshotHelper = (node) => {
|
|
|
66016
67193
|
}
|
|
66017
67194
|
return false;
|
|
66018
67195
|
};
|
|
67196
|
+
const findEnclosingNextjsPageDataFunction = (node) => {
|
|
67197
|
+
let outermostFunction = null;
|
|
67198
|
+
let cursor = node.parent;
|
|
67199
|
+
while (cursor) {
|
|
67200
|
+
if (isFunctionLike$1(cursor)) outermostFunction = cursor;
|
|
67201
|
+
if (isNodeOfType(cursor, "Program")) {
|
|
67202
|
+
if (!outermostFunction) return null;
|
|
67203
|
+
for (const exportName of NEXTJS_PAGE_DATA_EXPORT_NAMES) {
|
|
67204
|
+
const exportedValue = findExportedValue(cursor, exportName);
|
|
67205
|
+
if (exportedValue && isAstDescendant(outermostFunction, exportedValue)) return outermostFunction;
|
|
67206
|
+
}
|
|
67207
|
+
return null;
|
|
67208
|
+
}
|
|
67209
|
+
cursor = cursor.parent ?? null;
|
|
67210
|
+
}
|
|
67211
|
+
return null;
|
|
67212
|
+
};
|
|
67213
|
+
const findConditionalReturnExpressionRoot = (node) => {
|
|
67214
|
+
let expressionRoot = findTransparentExpressionRoot(node);
|
|
67215
|
+
while (expressionRoot.parent && isNodeOfType(expressionRoot.parent, "ConditionalExpression") && (expressionRoot.parent.consequent === expressionRoot || expressionRoot.parent.alternate === expressionRoot)) expressionRoot = findTransparentExpressionRoot(expressionRoot.parent);
|
|
67216
|
+
return expressionRoot;
|
|
67217
|
+
};
|
|
67218
|
+
const isReturnedPageDataResultBinding = (returnExpression, pageDataFunction, context) => {
|
|
67219
|
+
const declarator = returnExpression.parent;
|
|
67220
|
+
if (!isNodeOfType(declarator, "VariableDeclarator") || declarator.init !== returnExpression || !isNodeOfType(declarator.id, "Identifier") || findEnclosingFunction$1(declarator) !== pageDataFunction) return false;
|
|
67221
|
+
const bindingSymbol = context.scopes.symbolFor(declarator.id);
|
|
67222
|
+
if (!bindingSymbol || bindingSymbol.references.length !== 1) return false;
|
|
67223
|
+
const referenceRoot = findTransparentExpressionRoot(bindingSymbol.references[0].identifier);
|
|
67224
|
+
const returnStatement = referenceRoot.parent;
|
|
67225
|
+
return isNodeOfType(returnStatement, "ReturnStatement") && returnStatement.argument === referenceRoot && findEnclosingFunction$1(returnStatement) === pageDataFunction;
|
|
67226
|
+
};
|
|
67227
|
+
const isSameShorthandPropertyValue = (node, property) => property.shorthand && (node === property.key || node === property.value);
|
|
67228
|
+
const isValueForwardedThroughLiteralStructure = (node, structure) => {
|
|
67229
|
+
const strippedNode = stripParenExpression(node);
|
|
67230
|
+
const strippedStructure = stripParenExpression(structure);
|
|
67231
|
+
if (strippedNode === strippedStructure) return true;
|
|
67232
|
+
if (isNodeOfType(strippedStructure, "ConditionalExpression")) return isValueForwardedThroughLiteralStructure(strippedNode, strippedStructure.consequent) || isValueForwardedThroughLiteralStructure(strippedNode, strippedStructure.alternate);
|
|
67233
|
+
if (isNodeOfType(strippedStructure, "ArrayExpression")) return strippedStructure.elements.some((element) => element && !isNodeOfType(element, "SpreadElement") && isValueForwardedThroughLiteralStructure(strippedNode, element));
|
|
67234
|
+
if (!isNodeOfType(strippedStructure, "ObjectExpression")) return false;
|
|
67235
|
+
return strippedStructure.properties.some((property) => {
|
|
67236
|
+
if (isNodeOfType(property, "SpreadElement")) return isValueForwardedThroughLiteralStructure(strippedNode, property.argument);
|
|
67237
|
+
if (!isNodeOfType(property, "Property")) return false;
|
|
67238
|
+
if (isValueForwardedThroughLiteralStructure(strippedNode, property.value)) return true;
|
|
67239
|
+
return isSameShorthandPropertyValue(strippedNode, property);
|
|
67240
|
+
});
|
|
67241
|
+
};
|
|
67242
|
+
const isValueForwardedToPropertyValue = (node, property) => {
|
|
67243
|
+
const directValue = findConditionalReturnExpressionRoot(node);
|
|
67244
|
+
if (isValueForwardedThroughLiteralStructure(directValue, property.value)) return true;
|
|
67245
|
+
return isSameShorthandPropertyValue(directValue, property);
|
|
67246
|
+
};
|
|
67247
|
+
const isInsideReturnedNextjsProps = (node, pageDataFunction, context) => {
|
|
67248
|
+
let cursor = node.parent;
|
|
67249
|
+
while (cursor && cursor !== pageDataFunction) {
|
|
67250
|
+
if (isNodeOfType(cursor, "Property") && getStaticPropertyKeyName(cursor, { allowComputedString: true }) === "props" && isValueForwardedToPropertyValue(node, cursor)) {
|
|
67251
|
+
const propertyContainer = cursor.parent;
|
|
67252
|
+
if (!propertyContainer) return false;
|
|
67253
|
+
const returnExpression = findConditionalReturnExpressionRoot(propertyContainer);
|
|
67254
|
+
const returnStatement = returnExpression.parent;
|
|
67255
|
+
if (isNodeOfType(returnStatement, "ReturnStatement") && findEnclosingFunction$1(returnStatement) === pageDataFunction) return true;
|
|
67256
|
+
if (isNodeOfType(pageDataFunction, "ArrowFunctionExpression") && !isNodeOfType(pageDataFunction.body, "BlockStatement") && stripParenExpression(pageDataFunction.body) === stripParenExpression(returnExpression)) return true;
|
|
67257
|
+
if (isReturnedPageDataResultBinding(returnExpression, pageDataFunction, context)) return true;
|
|
67258
|
+
}
|
|
67259
|
+
cursor = cursor.parent ?? null;
|
|
67260
|
+
}
|
|
67261
|
+
return false;
|
|
67262
|
+
};
|
|
67263
|
+
const isExpressionReturnedByFunction = (node, functionNode) => {
|
|
67264
|
+
const returnExpression = findConditionalReturnExpressionRoot(node);
|
|
67265
|
+
if (isNodeOfType(functionNode, "ArrowFunctionExpression") && !isNodeOfType(functionNode.body, "BlockStatement")) return stripParenExpression(functionNode.body) === stripParenExpression(returnExpression);
|
|
67266
|
+
const returnStatement = returnExpression.parent;
|
|
67267
|
+
return isNodeOfType(returnStatement, "ReturnStatement") && returnStatement.argument === returnExpression && findEnclosingFunction$1(returnStatement) === functionNode;
|
|
67268
|
+
};
|
|
67269
|
+
const isValueForwardedToBindingInitializer = (node, bindingInitializer) => {
|
|
67270
|
+
if (isValueForwardedThroughLiteralStructure(findConditionalReturnExpressionRoot(node), bindingInitializer)) return true;
|
|
67271
|
+
const initializer = stripParenExpression(bindingInitializer);
|
|
67272
|
+
if (!isNodeOfType(initializer, "CallExpression")) return false;
|
|
67273
|
+
const callee = stripParenExpression(initializer.callee);
|
|
67274
|
+
return isFunctionLike$1(callee) && isExpressionReturnedByFunction(node, callee);
|
|
67275
|
+
};
|
|
67276
|
+
const findPageDataResultBinding = (node) => {
|
|
67277
|
+
let cursor = node.parent;
|
|
67278
|
+
while (cursor) {
|
|
67279
|
+
if (isNodeOfType(cursor, "VariableDeclarator")) {
|
|
67280
|
+
if (cursor.init && isNodeOfType(cursor.id, "Identifier") && isValueForwardedToBindingInitializer(node, cursor.init)) return cursor.id;
|
|
67281
|
+
return null;
|
|
67282
|
+
}
|
|
67283
|
+
cursor = cursor.parent ?? null;
|
|
67284
|
+
}
|
|
67285
|
+
return null;
|
|
67286
|
+
};
|
|
67287
|
+
const isUsedToSerializeNextjsPageProps = (node, context) => {
|
|
67288
|
+
if (!isInProjectDirectory(context, "pages") || isInProjectDirectory(context, "pages/api")) return false;
|
|
67289
|
+
const pageDataFunction = findEnclosingNextjsPageDataFunction(node);
|
|
67290
|
+
if (!pageDataFunction) return false;
|
|
67291
|
+
if (isInsideReturnedNextjsProps(node, pageDataFunction, context)) return true;
|
|
67292
|
+
const bindingIdentifier = findPageDataResultBinding(node);
|
|
67293
|
+
const bindingSymbol = bindingIdentifier ? context.scopes.symbolFor(bindingIdentifier) : null;
|
|
67294
|
+
if (!bindingSymbol) return false;
|
|
67295
|
+
const aliasSymbols = collectConstAliasSymbols(bindingSymbol, context.scopes);
|
|
67296
|
+
const aliasSymbolIds = new Set(aliasSymbols.map((aliasSymbol) => aliasSymbol.id));
|
|
67297
|
+
let hasPagePropsReference = false;
|
|
67298
|
+
for (const aliasSymbol of aliasSymbols) for (const reference of aliasSymbol.references) {
|
|
67299
|
+
if (findEnclosingFunction$1(reference.identifier) !== pageDataFunction) return false;
|
|
67300
|
+
if (isInsideReturnedNextjsProps(reference.identifier, pageDataFunction, context)) {
|
|
67301
|
+
hasPagePropsReference = true;
|
|
67302
|
+
continue;
|
|
67303
|
+
}
|
|
67304
|
+
const referenceRoot = findTransparentExpressionRoot(reference.identifier);
|
|
67305
|
+
const declarator = referenceRoot.parent;
|
|
67306
|
+
if (isNodeOfType(declarator, "VariableDeclarator") && declarator.init === referenceRoot && isNodeOfType(declarator.id, "Identifier")) {
|
|
67307
|
+
const aliasSymbolForReference = context.scopes.symbolFor(declarator.id);
|
|
67308
|
+
if (aliasSymbolForReference && aliasSymbolIds.has(aliasSymbolForReference.id)) continue;
|
|
67309
|
+
}
|
|
67310
|
+
return false;
|
|
67311
|
+
}
|
|
67312
|
+
return hasPagePropsReference;
|
|
67313
|
+
};
|
|
66019
67314
|
const noJsonParseStringifyClone = defineRule({
|
|
66020
67315
|
id: "no-json-parse-stringify-clone",
|
|
66021
67316
|
title: "JSON parse/stringify deep clone",
|
|
@@ -66033,6 +67328,7 @@ const noJsonParseStringifyClone = defineRule({
|
|
|
66033
67328
|
if (isInsideSnapshotHelper(node)) return;
|
|
66034
67329
|
if (isAssignedToNormalizationBinding(node)) return;
|
|
66035
67330
|
if (isCatchParameterRoundTrip(firstArgument)) return;
|
|
67331
|
+
if (isUsedToSerializeNextjsPageProps(node, context)) return;
|
|
66036
67332
|
context.report({
|
|
66037
67333
|
node,
|
|
66038
67334
|
message: MESSAGE$35
|
|
@@ -67448,6 +68744,77 @@ const isCancellationGuardTest = (test) => {
|
|
|
67448
68744
|
});
|
|
67449
68745
|
return matches;
|
|
67450
68746
|
};
|
|
68747
|
+
const getReactRefCurrent = (expression, context) => {
|
|
68748
|
+
const stripped = stripParenExpression(expression);
|
|
68749
|
+
if (!isNodeOfType(stripped, "MemberExpression") || getStaticPropertyName(stripped) !== "current") return null;
|
|
68750
|
+
const receiver = stripParenExpression(stripped.object);
|
|
68751
|
+
if (!isNodeOfType(receiver, "Identifier")) return null;
|
|
68752
|
+
const binding = findVariableInitializer(receiver, receiver.name);
|
|
68753
|
+
const initializer = binding?.initializer ? stripParenExpression(binding.initializer) : null;
|
|
68754
|
+
return initializer && isNodeOfType(initializer, "CallExpression") && isReactApiCall(initializer, USE_REF_HOOK_NAMES$1, context.scopes, {
|
|
68755
|
+
allowGlobalReactNamespace: true,
|
|
68756
|
+
allowUnboundBareCalls: true
|
|
68757
|
+
}) ? stripped : null;
|
|
68758
|
+
};
|
|
68759
|
+
const getStableOwnershipToken = (expression, context) => {
|
|
68760
|
+
const stripped = stripParenExpression(expression);
|
|
68761
|
+
if (!isNodeOfType(stripped, "Identifier")) return null;
|
|
68762
|
+
const symbol = context.scopes.symbolFor(stripped);
|
|
68763
|
+
const initializer = symbol?.initializer ? stripParenExpression(symbol.initializer) : null;
|
|
68764
|
+
const isStableAsyncIdentity = Boolean(initializer && isNodeOfType(initializer, "ObjectExpression")) || Boolean(initializer && getReactRefCurrent(initializer, context)) || Boolean(initializer && isNodeOfType(initializer, "UpdateExpression") && initializer.operator === "++" && getReactRefCurrent(initializer.argument, context));
|
|
68765
|
+
return symbol && symbol.kind === "const" && symbol.references.every((reference) => reference.flag === "read") && isStableAsyncIdentity ? stripped : null;
|
|
68766
|
+
};
|
|
68767
|
+
const getAsyncOwnershipComparison = (test, context) => {
|
|
68768
|
+
const stripped = stripParenExpression(test);
|
|
68769
|
+
if (!isNodeOfType(stripped, "BinaryExpression")) return null;
|
|
68770
|
+
const leftRef = getReactRefCurrent(stripped.left, context);
|
|
68771
|
+
const rightRef = getReactRefCurrent(stripped.right, context);
|
|
68772
|
+
const leftToken = getStableOwnershipToken(stripped.left, context);
|
|
68773
|
+
const rightToken = getStableOwnershipToken(stripped.right, context);
|
|
68774
|
+
if (stripped.operator === "===" || stripped.operator === "==") {
|
|
68775
|
+
if (leftRef && rightToken) return {
|
|
68776
|
+
refCurrent: leftRef,
|
|
68777
|
+
token: rightToken,
|
|
68778
|
+
mode: "owns",
|
|
68779
|
+
isOrdered: false
|
|
68780
|
+
};
|
|
68781
|
+
if (rightRef && leftToken) return {
|
|
68782
|
+
refCurrent: rightRef,
|
|
68783
|
+
token: leftToken,
|
|
68784
|
+
mode: "owns",
|
|
68785
|
+
isOrdered: false
|
|
68786
|
+
};
|
|
68787
|
+
return null;
|
|
68788
|
+
}
|
|
68789
|
+
if (stripped.operator === "!==" || stripped.operator === "!=") {
|
|
68790
|
+
if (leftRef && rightToken) return {
|
|
68791
|
+
refCurrent: leftRef,
|
|
68792
|
+
token: rightToken,
|
|
68793
|
+
mode: "lost",
|
|
68794
|
+
isOrdered: false
|
|
68795
|
+
};
|
|
68796
|
+
if (rightRef && leftToken) return {
|
|
68797
|
+
refCurrent: rightRef,
|
|
68798
|
+
token: leftToken,
|
|
68799
|
+
mode: "lost",
|
|
68800
|
+
isOrdered: false
|
|
68801
|
+
};
|
|
68802
|
+
return null;
|
|
68803
|
+
}
|
|
68804
|
+
if (stripped.operator === "<=" && leftRef && rightToken) return {
|
|
68805
|
+
refCurrent: leftRef,
|
|
68806
|
+
token: rightToken,
|
|
68807
|
+
mode: "owns",
|
|
68808
|
+
isOrdered: true
|
|
68809
|
+
};
|
|
68810
|
+
if (stripped.operator === ">=" && rightRef && leftToken) return {
|
|
68811
|
+
refCurrent: rightRef,
|
|
68812
|
+
token: leftToken,
|
|
68813
|
+
mode: "owns",
|
|
68814
|
+
isOrdered: true
|
|
68815
|
+
};
|
|
68816
|
+
return null;
|
|
68817
|
+
};
|
|
67451
68818
|
const dedupeCatchPathStates = (states) => {
|
|
67452
68819
|
const statesByKey = /* @__PURE__ */ new Map();
|
|
67453
68820
|
for (const state of states) statesByKey.set(`${Number(state.isCleared)}:${Number(state.isCancellationPath)}`, state);
|
|
@@ -67780,7 +69147,221 @@ const isInsideTryFinalizer = (node, tryStatement) => {
|
|
|
67780
69147
|
}
|
|
67781
69148
|
return false;
|
|
67782
69149
|
};
|
|
67783
|
-
const
|
|
69150
|
+
const getDirectBlockEntry = (node, functionNode) => {
|
|
69151
|
+
let entry = node;
|
|
69152
|
+
let cursor = node.parent;
|
|
69153
|
+
while (cursor && cursor !== functionNode) {
|
|
69154
|
+
if (isNodeOfType(cursor, "BlockStatement")) return {
|
|
69155
|
+
block: cursor,
|
|
69156
|
+
entry
|
|
69157
|
+
};
|
|
69158
|
+
entry = cursor;
|
|
69159
|
+
cursor = cursor.parent ?? null;
|
|
69160
|
+
}
|
|
69161
|
+
return null;
|
|
69162
|
+
};
|
|
69163
|
+
const claimPrecedesTruthySet = (claimNode, truthySet, firstRiskyAwait, functionNode, context) => {
|
|
69164
|
+
const claimStart = getNodeStart$1(claimNode);
|
|
69165
|
+
if (claimStart === null || claimStart >= firstRiskyAwait.start || truthySet.start >= firstRiskyAwait.start) return false;
|
|
69166
|
+
const claimEntry = getDirectBlockEntry(claimNode, functionNode);
|
|
69167
|
+
const truthyEntry = getDirectBlockEntry(truthySet.node, functionNode);
|
|
69168
|
+
if (!claimEntry || !truthyEntry || claimEntry.block !== truthyEntry.block) return false;
|
|
69169
|
+
let claimCursor = claimNode.parent;
|
|
69170
|
+
while (claimCursor && claimCursor !== claimEntry.block) {
|
|
69171
|
+
if (isNodeOfType(claimCursor, "IfStatement") || isNodeOfType(claimCursor, "SwitchCase") || isNodeOfType(claimCursor, "ConditionalExpression") || isNodeOfType(claimCursor, "LogicalExpression") || isNodeOfType(claimCursor, "ForStatement") || isNodeOfType(claimCursor, "ForInStatement") || isNodeOfType(claimCursor, "ForOfStatement") || isNodeOfType(claimCursor, "WhileStatement") || isNodeOfType(claimCursor, "DoWhileStatement")) return false;
|
|
69172
|
+
claimCursor = claimCursor.parent ?? null;
|
|
69173
|
+
}
|
|
69174
|
+
const claimIndex = claimEntry.block.body.findIndex((statement) => statement === claimEntry.entry);
|
|
69175
|
+
const truthyIndex = claimEntry.block.body.findIndex((statement) => statement === truthyEntry.entry);
|
|
69176
|
+
if (claimIndex === -1 || truthyIndex === -1 || claimIndex >= truthyIndex) return false;
|
|
69177
|
+
return claimEntry.block.body.slice(claimIndex + 1, truthyIndex).every((statement) => !subtreeHasAbruptSynchronousOperation(statement, functionNode, context));
|
|
69178
|
+
};
|
|
69179
|
+
const getOwningFunction = (functionNode) => {
|
|
69180
|
+
let ownerFunction = functionNode;
|
|
69181
|
+
let cursor = functionNode.parent;
|
|
69182
|
+
while (cursor) {
|
|
69183
|
+
if (isFunctionLike$1(cursor)) ownerFunction = cursor;
|
|
69184
|
+
cursor = cursor.parent ?? null;
|
|
69185
|
+
}
|
|
69186
|
+
return ownerFunction;
|
|
69187
|
+
};
|
|
69188
|
+
const isEffectInvalidationPairedWithReset = (writeNode, truthySets, context) => {
|
|
69189
|
+
const truthyCall = truthySets[0]?.node;
|
|
69190
|
+
if (!truthyCall || !isNodeOfType(truthyCall, "CallExpression")) return false;
|
|
69191
|
+
const setter = getSetterBooleanValue(truthyCall, context);
|
|
69192
|
+
if (!setter) return false;
|
|
69193
|
+
let effectCallback = writeNode.parent;
|
|
69194
|
+
while (effectCallback && !isFunctionLike$1(effectCallback)) effectCallback = effectCallback.parent ?? null;
|
|
69195
|
+
if (!effectCallback || !isEffectCallback(effectCallback, context)) return false;
|
|
69196
|
+
if (!isUnconditionallyExecutedWithinFunction(writeNode, effectCallback, context)) return false;
|
|
69197
|
+
const writeEntry = getDirectBlockEntry(writeNode, effectCallback);
|
|
69198
|
+
if (!writeEntry) return false;
|
|
69199
|
+
let isPaired = false;
|
|
69200
|
+
walkOwnFunctionScope(effectCallback, (candidate) => {
|
|
69201
|
+
if (isPaired || !isNodeOfType(candidate, "CallExpression")) return;
|
|
69202
|
+
const candidateSetter = getSetterBooleanValue(candidate, context);
|
|
69203
|
+
if (candidateSetter?.setterKey !== setter.setterKey || candidateSetter.value || !isUnconditionallyExecutedWithinFunction(candidate, effectCallback, context)) return;
|
|
69204
|
+
const resetEntry = getDirectBlockEntry(candidate, effectCallback);
|
|
69205
|
+
if (!resetEntry || resetEntry.block !== writeEntry.block) return;
|
|
69206
|
+
const writeIndex = writeEntry.block.body.findIndex((statement) => statement === writeEntry.entry);
|
|
69207
|
+
const resetIndex = resetEntry.block.body.findIndex((statement) => statement === resetEntry.entry);
|
|
69208
|
+
if (writeIndex === -1 || resetIndex === -1) return;
|
|
69209
|
+
if (resetIndex <= writeIndex) {
|
|
69210
|
+
isPaired = true;
|
|
69211
|
+
return false;
|
|
69212
|
+
}
|
|
69213
|
+
isPaired = writeEntry.block.body.slice(writeIndex + 1, resetIndex).every((statement) => !subtreeHasAbruptSynchronousOperation(statement, effectCallback, context));
|
|
69214
|
+
return isPaired ? false : void 0;
|
|
69215
|
+
});
|
|
69216
|
+
return isPaired;
|
|
69217
|
+
};
|
|
69218
|
+
const isUnconditionalReturnBranch = (statement) => {
|
|
69219
|
+
if (isNodeOfType(statement, "ReturnStatement")) return true;
|
|
69220
|
+
return Boolean(isNodeOfType(statement, "BlockStatement") && statement.body.length === 1 && isNodeOfType(statement.body[0], "ReturnStatement"));
|
|
69221
|
+
};
|
|
69222
|
+
const findSingleFlightSnapshotClaim = (tokenInitializer, functionNode, truthySets, firstRiskyAwait, resetNode, context) => {
|
|
69223
|
+
const snapshotEntry = getDirectBlockEntry(tokenInitializer, functionNode);
|
|
69224
|
+
const resetEntry = getDirectBlockEntry(resetNode, functionNode);
|
|
69225
|
+
if (!snapshotEntry || !resetEntry) return null;
|
|
69226
|
+
const claimCandidates = [];
|
|
69227
|
+
const releaseCandidates = [];
|
|
69228
|
+
walkOwnFunctionScope(functionNode, (candidate) => {
|
|
69229
|
+
if (!isNodeOfType(candidate, "AssignmentExpression") || candidate.operator !== "=" || !getReactRefCurrent(candidate.left, context)) return;
|
|
69230
|
+
const assignedValue = stripParenExpression(candidate.right);
|
|
69231
|
+
if (!isNodeOfType(assignedValue, "Literal") || typeof assignedValue.value !== "boolean") return;
|
|
69232
|
+
const candidateKey = serializeReferenceKey({
|
|
69233
|
+
node: candidate.left,
|
|
69234
|
+
scopes: context.scopes
|
|
69235
|
+
});
|
|
69236
|
+
if (!candidateKey) return;
|
|
69237
|
+
if (!assignedValue.value) {
|
|
69238
|
+
if (getDirectBlockEntry(candidate, functionNode)?.block === resetEntry.block) releaseCandidates.push(candidate);
|
|
69239
|
+
return;
|
|
69240
|
+
}
|
|
69241
|
+
if (!truthySets.some((truthySet) => claimPrecedesTruthySet(candidate, truthySet, firstRiskyAwait, functionNode, context))) return;
|
|
69242
|
+
const candidateEntry = getDirectBlockEntry(candidate, functionNode);
|
|
69243
|
+
if (!candidateEntry || candidateEntry.block !== snapshotEntry.block) return;
|
|
69244
|
+
const candidateIndex = candidateEntry.block.body.findIndex((statement) => statement === candidateEntry.entry);
|
|
69245
|
+
const snapshotIndex = candidateEntry.block.body.findIndex((statement) => statement === snapshotEntry.entry);
|
|
69246
|
+
if (candidateIndex === -1 || snapshotIndex === -1 || candidateIndex >= snapshotIndex) return;
|
|
69247
|
+
const guardIndex = candidateEntry.block.body.findLastIndex((statement, statementIndex) => {
|
|
69248
|
+
if (statementIndex >= candidateIndex || !isNodeOfType(statement, "IfStatement") || statement.alternate !== null || !isUnconditionalReturnBranch(statement.consequent)) return false;
|
|
69249
|
+
return serializeReferenceKey({
|
|
69250
|
+
node: stripParenExpression(statement.test),
|
|
69251
|
+
scopes: context.scopes
|
|
69252
|
+
}) === candidateKey;
|
|
69253
|
+
});
|
|
69254
|
+
if (guardIndex === -1 || !candidateEntry.block.body.slice(guardIndex + 1, candidateIndex).every((statement) => !subtreeHasAbruptSynchronousOperation(statement, functionNode, context))) return;
|
|
69255
|
+
claimCandidates.push(candidate);
|
|
69256
|
+
});
|
|
69257
|
+
const claim = claimCandidates.find((claimCandidate) => {
|
|
69258
|
+
const candidateKey = serializeReferenceKey({
|
|
69259
|
+
node: claimCandidate.left,
|
|
69260
|
+
scopes: context.scopes
|
|
69261
|
+
});
|
|
69262
|
+
return releaseCandidates.some((releaseCandidate) => serializeReferenceKey({
|
|
69263
|
+
node: releaseCandidate.left,
|
|
69264
|
+
scopes: context.scopes
|
|
69265
|
+
}) === candidateKey);
|
|
69266
|
+
});
|
|
69267
|
+
if (!claim) return null;
|
|
69268
|
+
const claimKey = serializeReferenceKey({
|
|
69269
|
+
node: claim.left,
|
|
69270
|
+
scopes: context.scopes
|
|
69271
|
+
});
|
|
69272
|
+
const release = releaseCandidates.find((releaseCandidate) => serializeReferenceKey({
|
|
69273
|
+
node: releaseCandidate.left,
|
|
69274
|
+
scopes: context.scopes
|
|
69275
|
+
}) === claimKey);
|
|
69276
|
+
if (!claimKey || !release) return null;
|
|
69277
|
+
const releaseEntry = getDirectBlockEntry(release, functionNode);
|
|
69278
|
+
if (!releaseEntry || releaseEntry.block !== resetEntry.block) return null;
|
|
69279
|
+
const releaseIndex = resetEntry.block.body.findIndex((statement) => statement === releaseEntry.entry);
|
|
69280
|
+
const resetIndex = resetEntry.block.body.findIndex((statement) => statement === resetEntry.entry);
|
|
69281
|
+
if (releaseIndex === -1 || resetIndex === -1 || !resetEntry.block.body.slice(Math.min(releaseIndex, resetIndex) + 1, Math.max(releaseIndex, resetIndex)).every((statement) => !subtreeHasAbruptSynchronousOperation(statement, functionNode, context))) return null;
|
|
69282
|
+
let didFindUnsafeWrite = false;
|
|
69283
|
+
walkAst(getOwningFunction(functionNode), (candidate) => {
|
|
69284
|
+
if (didFindUnsafeWrite || candidate === claim || candidate === release) return;
|
|
69285
|
+
const writeTarget = isNodeOfType(candidate, "AssignmentExpression") ? candidate.left : isNodeOfType(candidate, "UpdateExpression") || isNodeOfType(candidate, "UnaryExpression") && candidate.operator === "delete" ? candidate.argument : null;
|
|
69286
|
+
if (writeTarget && serializeReferenceKey({
|
|
69287
|
+
node: writeTarget,
|
|
69288
|
+
scopes: context.scopes
|
|
69289
|
+
}) === claimKey && !isEffectInvalidationPairedWithReset(candidate, truthySets, context)) didFindUnsafeWrite = true;
|
|
69290
|
+
});
|
|
69291
|
+
return didFindUnsafeWrite ? null : claim;
|
|
69292
|
+
};
|
|
69293
|
+
const findOwnershipClaim = (comparison, functionNode, truthySets, firstRiskyAwait, resetNode, context) => {
|
|
69294
|
+
const refKey = serializeReferenceKey({
|
|
69295
|
+
node: comparison.refCurrent,
|
|
69296
|
+
scopes: context.scopes
|
|
69297
|
+
});
|
|
69298
|
+
const tokenKey = serializeReferenceKey({
|
|
69299
|
+
node: comparison.token,
|
|
69300
|
+
scopes: context.scopes
|
|
69301
|
+
});
|
|
69302
|
+
if (!refKey || !tokenKey) return null;
|
|
69303
|
+
const candidates = [];
|
|
69304
|
+
const tokenSymbol = context.scopes.symbolFor(comparison.token);
|
|
69305
|
+
const tokenInitializer = tokenSymbol?.initializer ? stripParenExpression(tokenSymbol.initializer) : null;
|
|
69306
|
+
if (comparison.isOrdered && !isNodeOfType(tokenInitializer, "UpdateExpression")) return null;
|
|
69307
|
+
if (tokenInitializer && isNodeOfType(tokenInitializer, "UpdateExpression") && tokenInitializer.operator === "++" && serializeReferenceKey({
|
|
69308
|
+
node: tokenInitializer.argument,
|
|
69309
|
+
scopes: context.scopes
|
|
69310
|
+
}) === refKey) candidates.push(tokenInitializer);
|
|
69311
|
+
if (tokenInitializer && getReactRefCurrent(tokenInitializer, context) && serializeReferenceKey({
|
|
69312
|
+
node: tokenInitializer,
|
|
69313
|
+
scopes: context.scopes
|
|
69314
|
+
}) === refKey) {
|
|
69315
|
+
const singleFlightClaim = findSingleFlightSnapshotClaim(tokenInitializer, functionNode, truthySets, firstRiskyAwait, resetNode, context);
|
|
69316
|
+
if (singleFlightClaim) candidates.push(singleFlightClaim);
|
|
69317
|
+
}
|
|
69318
|
+
if (tokenInitializer && isNodeOfType(tokenInitializer, "UpdateExpression")) {
|
|
69319
|
+
const generationKey = serializeReferenceKey({
|
|
69320
|
+
node: tokenInitializer.argument,
|
|
69321
|
+
scopes: context.scopes
|
|
69322
|
+
});
|
|
69323
|
+
if (generationKey && generationKey === refKey) {
|
|
69324
|
+
const ownerFunction = getOwningFunction(functionNode);
|
|
69325
|
+
let didFindOtherGenerationWrite = false;
|
|
69326
|
+
walkAst(ownerFunction, (candidate) => {
|
|
69327
|
+
if (didFindOtherGenerationWrite || candidate === tokenInitializer) return;
|
|
69328
|
+
const writeTarget = isNodeOfType(candidate, "AssignmentExpression") ? candidate.left : isNodeOfType(candidate, "UpdateExpression") || isNodeOfType(candidate, "UnaryExpression") && candidate.operator === "delete" ? candidate.argument : null;
|
|
69329
|
+
if (writeTarget && serializeReferenceKey({
|
|
69330
|
+
node: writeTarget,
|
|
69331
|
+
scopes: context.scopes
|
|
69332
|
+
}) === generationKey && !isEffectInvalidationPairedWithReset(candidate, truthySets, context)) didFindOtherGenerationWrite = true;
|
|
69333
|
+
});
|
|
69334
|
+
if (didFindOtherGenerationWrite) return null;
|
|
69335
|
+
}
|
|
69336
|
+
}
|
|
69337
|
+
walkOwnFunctionScope(functionNode, (candidate) => {
|
|
69338
|
+
if (!isNodeOfType(candidate, "AssignmentExpression") || candidate.operator !== "=") return;
|
|
69339
|
+
if (serializeReferenceKey({
|
|
69340
|
+
node: candidate.left,
|
|
69341
|
+
scopes: context.scopes
|
|
69342
|
+
}) === refKey && serializeReferenceKey({
|
|
69343
|
+
node: candidate.right,
|
|
69344
|
+
scopes: context.scopes
|
|
69345
|
+
}) === tokenKey) candidates.push(candidate);
|
|
69346
|
+
});
|
|
69347
|
+
const claim = candidates.find((candidate) => truthySets.some((truthySet) => claimPrecedesTruthySet(candidate, truthySet, firstRiskyAwait, functionNode, context)));
|
|
69348
|
+
if (!claim) return null;
|
|
69349
|
+
let didFindOtherWrite = false;
|
|
69350
|
+
walkAst(getOwningFunction(functionNode), (candidate) => {
|
|
69351
|
+
if (didFindOtherWrite || candidate === claim) return;
|
|
69352
|
+
const writeTarget = isNodeOfType(candidate, "AssignmentExpression") ? candidate.left : isNodeOfType(candidate, "UpdateExpression") || isNodeOfType(candidate, "UnaryExpression") && candidate.operator === "delete" ? candidate.argument : null;
|
|
69353
|
+
if (writeTarget && serializeReferenceKey({
|
|
69354
|
+
node: writeTarget,
|
|
69355
|
+
scopes: context.scopes
|
|
69356
|
+
}) === refKey && !isEffectInvalidationPairedWithReset(candidate, truthySets, context)) didFindOtherWrite = true;
|
|
69357
|
+
});
|
|
69358
|
+
return didFindOtherWrite ? null : claim;
|
|
69359
|
+
};
|
|
69360
|
+
const isClaimedOwnershipComparison = (test, expectedMode, functionNode, truthySets, firstRiskyAwait, resetNode, context) => {
|
|
69361
|
+
const comparison = getAsyncOwnershipComparison(test, context);
|
|
69362
|
+
return Boolean(comparison && comparison.mode === expectedMode && findOwnershipClaim(comparison, functionNode, truthySets, firstRiskyAwait, resetNode, context));
|
|
69363
|
+
};
|
|
69364
|
+
const hasLifecycleGuardWriteOutsideCleanup = (effectCallback, guardKey, acceptedAssignments, context) => {
|
|
67784
69365
|
let didFindOtherWrite = false;
|
|
67785
69366
|
walkAst(effectCallback, (candidate) => {
|
|
67786
69367
|
if (didFindOtherWrite) return false;
|
|
@@ -67788,7 +69369,7 @@ const hasLifecycleGuardWriteOutsideCleanup = (effectCallback, guardKey, accepted
|
|
|
67788
69369
|
if (serializeReferenceKey({
|
|
67789
69370
|
node: candidate.left,
|
|
67790
69371
|
scopes: context.scopes
|
|
67791
|
-
}) === guardKey && !
|
|
69372
|
+
}) === guardKey && !acceptedAssignments.has(candidate)) {
|
|
67792
69373
|
didFindOtherWrite = true;
|
|
67793
69374
|
return false;
|
|
67794
69375
|
}
|
|
@@ -67804,48 +69385,103 @@ const hasLifecycleGuardWriteOutsideCleanup = (effectCallback, guardKey, accepted
|
|
|
67804
69385
|
});
|
|
67805
69386
|
return didFindOtherWrite;
|
|
67806
69387
|
};
|
|
67807
|
-
const
|
|
69388
|
+
const collectCleanupBackedLifecycleAssignments = (effectCallback, guardKey, context) => {
|
|
69389
|
+
const acceptedAssignments = /* @__PURE__ */ new Set();
|
|
69390
|
+
for (const cleanupFunction of collectReturnedCleanupFunctions(effectCallback, context.scopes)) walkOwnFunctionScope(cleanupFunction, (cleanupNode) => {
|
|
69391
|
+
const assignedValue = isNodeOfType(cleanupNode, "AssignmentExpression") ? stripParenExpression(cleanupNode.right) : null;
|
|
69392
|
+
if (!isNodeOfType(cleanupNode, "AssignmentExpression") || cleanupNode.operator !== "=" || !isNodeOfType(assignedValue, "Literal") || assignedValue.value !== false || serializeReferenceKey({
|
|
69393
|
+
node: cleanupNode.left,
|
|
69394
|
+
scopes: context.scopes
|
|
69395
|
+
}) !== guardKey || !isUnconditionallyExecutedWithinFunction(cleanupNode, cleanupFunction, context)) return;
|
|
69396
|
+
acceptedAssignments.add(cleanupNode);
|
|
69397
|
+
});
|
|
69398
|
+
if (acceptedAssignments.size === 0) return null;
|
|
69399
|
+
walkOwnFunctionScope(effectCallback, (effectNode) => {
|
|
69400
|
+
const assignedValue = isNodeOfType(effectNode, "AssignmentExpression") ? stripParenExpression(effectNode.right) : null;
|
|
69401
|
+
if (isNodeOfType(effectNode, "AssignmentExpression") && effectNode.operator === "=" && isNodeOfType(assignedValue, "Literal") && assignedValue.value === true && serializeReferenceKey({
|
|
69402
|
+
node: effectNode.left,
|
|
69403
|
+
scopes: context.scopes
|
|
69404
|
+
}) === guardKey && isUnconditionallyExecutedWithinFunction(effectNode, effectCallback, context)) acceptedAssignments.add(effectNode);
|
|
69405
|
+
});
|
|
69406
|
+
return acceptedAssignments;
|
|
69407
|
+
};
|
|
69408
|
+
const isEffectCallback = (node, context) => {
|
|
69409
|
+
const callbackRoot = findTransparentExpressionRoot(node);
|
|
69410
|
+
const callbackCall = callbackRoot.parent;
|
|
69411
|
+
return Boolean(callbackCall && isNodeOfType(callbackCall, "CallExpression") && callbackCall.arguments[0] === callbackRoot && isReactApiCall(callbackCall, EFFECT_HOOK_NAMES$6, context.scopes, {
|
|
69412
|
+
allowGlobalReactNamespace: true,
|
|
69413
|
+
allowUnboundBareCalls: true
|
|
69414
|
+
}));
|
|
69415
|
+
};
|
|
69416
|
+
const isCleanupBackedLifecycleGuard = (guardExpression, functionNode, context) => {
|
|
69417
|
+
const guardKey = serializeReferenceKey({
|
|
69418
|
+
node: guardExpression,
|
|
69419
|
+
scopes: context.scopes
|
|
69420
|
+
});
|
|
69421
|
+
if (!guardKey || !isInitiallyActiveLifecycleGuard(guardExpression, context)) return false;
|
|
69422
|
+
let ownerFunction = functionNode.parent;
|
|
69423
|
+
while (ownerFunction && !isFunctionLike$1(ownerFunction)) ownerFunction = ownerFunction.parent ?? null;
|
|
69424
|
+
if (!ownerFunction) return false;
|
|
69425
|
+
const effectCallbacks = [];
|
|
69426
|
+
if (isEffectCallback(ownerFunction, context)) effectCallbacks.push(ownerFunction);
|
|
69427
|
+
walkOwnFunctionScope(ownerFunction, (candidate) => {
|
|
69428
|
+
if (!isNodeOfType(candidate, "CallExpression")) return;
|
|
69429
|
+
if (!isReactApiCall(candidate, EFFECT_HOOK_NAMES$6, context.scopes, {
|
|
69430
|
+
allowGlobalReactNamespace: true,
|
|
69431
|
+
allowUnboundBareCalls: true
|
|
69432
|
+
})) return;
|
|
69433
|
+
const effectCallback = candidate.arguments[0];
|
|
69434
|
+
if (effectCallback && isFunctionLike$1(effectCallback)) effectCallbacks.push(effectCallback);
|
|
69435
|
+
});
|
|
69436
|
+
const acceptedAssignments = /* @__PURE__ */ new Set();
|
|
69437
|
+
for (const effectCallback of effectCallbacks) {
|
|
69438
|
+
const effectAssignments = collectCleanupBackedLifecycleAssignments(effectCallback, guardKey, context);
|
|
69439
|
+
if (!effectAssignments) continue;
|
|
69440
|
+
for (const assignment of effectAssignments) acceptedAssignments.add(assignment);
|
|
69441
|
+
}
|
|
69442
|
+
return Boolean(acceptedAssignments.size > 0 && !hasLifecycleGuardWriteOutsideCleanup(ownerFunction, guardKey, acceptedAssignments, context));
|
|
69443
|
+
};
|
|
69444
|
+
const collectLogicalOperands = (expression, operator) => {
|
|
69445
|
+
const stripped = stripParenExpression(expression);
|
|
69446
|
+
if (isNodeOfType(stripped, "LogicalExpression") && stripped.operator === operator) return [...collectLogicalOperands(stripped.left, operator), ...collectLogicalOperands(stripped.right, operator)];
|
|
69447
|
+
return [stripped];
|
|
69448
|
+
};
|
|
69449
|
+
const collectFinalizerGuardExpressions = (resetNode, protectingTry) => {
|
|
69450
|
+
const positive = [];
|
|
69451
|
+
const negative = [];
|
|
67808
69452
|
let child = resetNode;
|
|
67809
69453
|
let cursor = resetNode.parent;
|
|
67810
|
-
|
|
67811
|
-
|
|
67812
|
-
|
|
67813
|
-
|
|
67814
|
-
|
|
67815
|
-
|
|
67816
|
-
|
|
67817
|
-
|
|
67818
|
-
|
|
67819
|
-
|
|
67820
|
-
|
|
69454
|
+
while (cursor && cursor !== protectingTry) {
|
|
69455
|
+
if (isNodeOfType(cursor, "IfStatement")) {
|
|
69456
|
+
if (cursor.consequent !== child || cursor.alternate !== null) return null;
|
|
69457
|
+
positive.push(...collectLogicalOperands(cursor.test, "&&"));
|
|
69458
|
+
} else if (isNodeOfType(cursor, "LogicalExpression")) {
|
|
69459
|
+
if (cursor.operator !== "&&" || cursor.right !== child) return null;
|
|
69460
|
+
positive.push(...collectLogicalOperands(cursor.left, "&&"));
|
|
69461
|
+
} else if (isNodeOfType(cursor, "BlockStatement")) {
|
|
69462
|
+
const childIndex = cursor.body.findIndex((statement) => statement === child);
|
|
69463
|
+
if (childIndex !== -1) for (const statement of cursor.body.slice(0, childIndex)) {
|
|
69464
|
+
if (!isNodeOfType(statement, "IfStatement") || statement.alternate !== null || !isUnconditionalReturnBranch(statement.consequent)) continue;
|
|
69465
|
+
negative.push(...collectLogicalOperands(statement.test, "||"));
|
|
69466
|
+
}
|
|
69467
|
+
} else if (isNodeOfType(cursor, "SwitchCase") || isNodeOfType(cursor, "ConditionalExpression") || isNodeOfType(cursor, "ForStatement") || isNodeOfType(cursor, "ForInStatement") || isNodeOfType(cursor, "ForOfStatement") || isNodeOfType(cursor, "WhileStatement") || isNodeOfType(cursor, "DoWhileStatement")) return null;
|
|
67821
69468
|
child = cursor;
|
|
67822
69469
|
cursor = cursor.parent ?? null;
|
|
67823
69470
|
}
|
|
67824
|
-
|
|
67825
|
-
|
|
67826
|
-
|
|
67827
|
-
|
|
67828
|
-
|
|
67829
|
-
|
|
67830
|
-
|
|
67831
|
-
|
|
67832
|
-
|
|
67833
|
-
|
|
67834
|
-
|
|
67835
|
-
|
|
67836
|
-
|
|
67837
|
-
|
|
67838
|
-
node: cleanupNode.left,
|
|
67839
|
-
scopes: context.scopes
|
|
67840
|
-
}) !== guardKey || !isUnconditionallyExecutedWithinFunction(cleanupNode, cleanupFunction, context)) return;
|
|
67841
|
-
acceptedCleanupAssignments.add(cleanupNode);
|
|
67842
|
-
});
|
|
67843
|
-
if (acceptedCleanupAssignments.size > 0 && !hasLifecycleGuardWriteOutsideCleanup(cursor, guardKey, acceptedCleanupAssignments, context)) return true;
|
|
67844
|
-
}
|
|
67845
|
-
}
|
|
67846
|
-
cursor = cursor.parent ?? null;
|
|
67847
|
-
}
|
|
67848
|
-
return false;
|
|
69471
|
+
return cursor === protectingTry && positive.length + negative.length > 0 ? {
|
|
69472
|
+
positive,
|
|
69473
|
+
negative
|
|
69474
|
+
} : null;
|
|
69475
|
+
};
|
|
69476
|
+
const isPositiveFinalizerGuard = (expression, resetNode, functionNode, truthySets, firstRiskyAwait, context) => isCleanupBackedLifecycleGuard(expression, functionNode, context) || isClaimedOwnershipComparison(expression, "owns", functionNode, truthySets, firstRiskyAwait, resetNode, context);
|
|
69477
|
+
const isNegativeFinalizerGuard = (expression, resetNode, functionNode, truthySets, firstRiskyAwait, context) => {
|
|
69478
|
+
const stripped = stripParenExpression(expression);
|
|
69479
|
+
if (isNodeOfType(stripped, "UnaryExpression") && stripped.operator === "!") return isPositiveFinalizerGuard(stripped.argument, resetNode, functionNode, truthySets, firstRiskyAwait, context);
|
|
69480
|
+
return isClaimedOwnershipComparison(stripped, "lost", functionNode, truthySets, firstRiskyAwait, resetNode, context);
|
|
69481
|
+
};
|
|
69482
|
+
const isFinalizerResetProvablyGuarded = (resetNode, protectingTry, functionNode, truthySets, firstRiskyAwait, context) => {
|
|
69483
|
+
const guards = collectFinalizerGuardExpressions(resetNode, protectingTry);
|
|
69484
|
+
return Boolean(guards && guards.positive.every((guard) => isPositiveFinalizerGuard(guard, resetNode, functionNode, truthySets, firstRiskyAwait, context)) && guards.negative.every((guard) => isNegativeFinalizerGuard(guard, resetNode, functionNode, truthySets, firstRiskyAwait, context)));
|
|
67849
69485
|
};
|
|
67850
69486
|
const isAwaitInsideProtectedTry = (awaitNode, tryStatement) => {
|
|
67851
69487
|
let child = awaitNode;
|
|
@@ -67951,7 +69587,13 @@ const analyzeFunction = (functionNode, context) => {
|
|
|
67951
69587
|
const exceptionallyProtectedAwaits = collectExceptionallyProtectedAwaits(awaitSites, calls);
|
|
67952
69588
|
const riskyAwaitsWithTruthySet = awaitSites.filter((awaitSite) => rejectingAwaitNodes.has(awaitSite.node) && !exceptionallyProtectedAwaits.has(awaitSite.node) && truthySets.some((truthySet) => truthySet.start < awaitSite.start && !areOnExclusiveBranches(truthySet.node, awaitSite.node, functionNode)));
|
|
67953
69589
|
if (riskyAwaitsWithTruthySet.length === 0) continue;
|
|
67954
|
-
const conditionalExceptionalResets = calls.filter((call) =>
|
|
69590
|
+
const conditionalExceptionalResets = calls.filter((call) => {
|
|
69591
|
+
if (call.value || call.context === "plain" || call.isUnconditional || call.protectingTry === null) return false;
|
|
69592
|
+
const protectingTry = call.protectingTry;
|
|
69593
|
+
if (!isInsideTryFinalizer(call.node, protectingTry)) return true;
|
|
69594
|
+
const firstRiskyAwait = riskyAwaitsWithTruthySet.find((awaitSite) => isAwaitInsideProtectedTry(awaitSite.node, protectingTry));
|
|
69595
|
+
return !(firstRiskyAwait && isFinalizerResetProvablyGuarded(call.node, protectingTry, functionNode, truthySets, firstRiskyAwait, context));
|
|
69596
|
+
});
|
|
67955
69597
|
for (const reset of conditionalExceptionalResets) {
|
|
67956
69598
|
const catchHandler = reset.protectingTry?.handler;
|
|
67957
69599
|
if (catchHandler && !catchHandlerCanBypassReset(catchHandler, functionNode, setterKey, context, false)) continue;
|
|
@@ -73823,6 +75465,29 @@ const doesPredicateTruthRequireMatch = (matchCall, predicateFunction) => {
|
|
|
73823
75465
|
}
|
|
73824
75466
|
return !isNegated && predicateFunction.body === child;
|
|
73825
75467
|
};
|
|
75468
|
+
const doesPredicateReturnNormalizedMatch = (matchCall, predicateFunction) => {
|
|
75469
|
+
if (!isFunctionLike$1(predicateFunction) || !isNodeOfType(predicateFunction.body, "BlockStatement") || predicateFunction.body.body.length !== 2 || !isNodeOfType(predicateFunction.body.body[0], "VariableDeclaration")) return false;
|
|
75470
|
+
const returnStatement = predicateFunction.body.body[1];
|
|
75471
|
+
if (!isNodeOfType(returnStatement, "ReturnStatement") || !returnStatement.argument) return false;
|
|
75472
|
+
let negationCount = 0;
|
|
75473
|
+
let expression = matchCall;
|
|
75474
|
+
let parent = expression.parent ?? null;
|
|
75475
|
+
while (parent && parent !== returnStatement) {
|
|
75476
|
+
if (isNodeOfType(parent, "UnaryExpression") && parent.operator === "!") {
|
|
75477
|
+
negationCount += 1;
|
|
75478
|
+
expression = parent;
|
|
75479
|
+
parent = parent.parent ?? null;
|
|
75480
|
+
continue;
|
|
75481
|
+
}
|
|
75482
|
+
if (TRANSPARENT_EXPRESSION_WRAPPER_TYPES.has(parent.type) || isNodeOfType(parent, "ChainExpression")) {
|
|
75483
|
+
expression = parent;
|
|
75484
|
+
parent = parent.parent ?? null;
|
|
75485
|
+
continue;
|
|
75486
|
+
}
|
|
75487
|
+
return false;
|
|
75488
|
+
}
|
|
75489
|
+
return parent === returnStatement && returnStatement.argument === expression && negationCount % 2 === 0;
|
|
75490
|
+
};
|
|
73826
75491
|
const isStringTypeofGuardForPath = (test, expectedPath) => {
|
|
73827
75492
|
const target = stripParenExpression(test);
|
|
73828
75493
|
if (!isNodeOfType(target, "BinaryExpression") || target.operator !== "===") return false;
|
|
@@ -73863,6 +75528,26 @@ const pathUsesOptionalAccess = (node) => {
|
|
|
73863
75528
|
current = current.object;
|
|
73864
75529
|
}
|
|
73865
75530
|
};
|
|
75531
|
+
const getNormalizedClassNameRoot = (expression) => {
|
|
75532
|
+
const conditional = stripParenExpression(expression);
|
|
75533
|
+
if (!isNodeOfType(conditional, "ConditionalExpression")) return null;
|
|
75534
|
+
const consequent = stripParenExpression(conditional.consequent);
|
|
75535
|
+
const rootIdentifier = getRootIdentifier(consequent);
|
|
75536
|
+
if (!rootIdentifier || receiverPathKey(consequent) !== `${rootIdentifier.name}.className`) return null;
|
|
75537
|
+
const test = stripParenExpression(conditional.test);
|
|
75538
|
+
if (!isNodeOfType(test, "BinaryExpression") || test.operator !== "===") return null;
|
|
75539
|
+
const testOperands = [test.left, test.right].map((operand) => stripParenExpression(operand));
|
|
75540
|
+
const typeofOperand = testOperands.find((operand) => isNodeOfType(operand, "UnaryExpression"));
|
|
75541
|
+
const stringOperand = testOperands.find((operand) => isNodeOfType(operand, "Literal"));
|
|
75542
|
+
if (!typeofOperand || !isNodeOfType(typeofOperand, "UnaryExpression") || typeofOperand.operator !== "typeof" || receiverPathKey(typeofOperand.argument) !== `${rootIdentifier.name}.className` || !stringOperand || !isNodeOfType(stringOperand, "Literal") || stringOperand.value !== "string") return null;
|
|
75543
|
+
const alternate = stripParenExpression(conditional.alternate);
|
|
75544
|
+
if (!isNodeOfType(alternate, "LogicalExpression") || alternate.operator !== "??") return null;
|
|
75545
|
+
const fallback = stripParenExpression(alternate.right);
|
|
75546
|
+
const attributeCall = stripParenExpression(alternate.left);
|
|
75547
|
+
if (!isNodeOfType(fallback, "Literal") || fallback.value !== "" || !isNodeOfType(attributeCall, "CallExpression") || !isNodeOfType(attributeCall.callee, "MemberExpression") || getStaticPropertyName(attributeCall.callee) !== "getAttribute" || receiverPathKey(attributeCall.callee.object) !== rootIdentifier.name) return null;
|
|
75548
|
+
const attributeName = attributeCall.arguments[0] ? stripParenExpression(attributeCall.arguments[0]) : null;
|
|
75549
|
+
return attributeName && isNodeOfType(attributeName, "Literal") && attributeName.value === "class" ? rootIdentifier : null;
|
|
75550
|
+
};
|
|
73866
75551
|
const isMatchProvenByFindUpUntilPredicate = (assertion, matchReceiver, assertedPattern, context) => {
|
|
73867
75552
|
const resultIdentifier = getRootIdentifier(matchReceiver);
|
|
73868
75553
|
const resultPath = receiverPathKey(matchReceiver);
|
|
@@ -73871,11 +75556,17 @@ const isMatchProvenByFindUpUntilPredicate = (assertion, matchReceiver, assertedP
|
|
|
73871
75556
|
if (!isDirectFinderMatchReturn(assertion) && !isOptionalResultPath) return false;
|
|
73872
75557
|
const resultSymbol = context.scopes.symbolFor(resultIdentifier);
|
|
73873
75558
|
const initializer = resultSymbol?.initializer ? stripParenExpression(resultSymbol.initializer) : null;
|
|
73874
|
-
if (resultSymbol?.kind !== "const" || !initializer
|
|
75559
|
+
if (resultSymbol?.kind !== "const" || !initializer) return false;
|
|
75560
|
+
const finderCall = isNodeOfType(initializer, "CallExpression") ? initializer : isNodeOfType(initializer, "ConditionalExpression") ? (() => {
|
|
75561
|
+
const alternate = stripParenExpression(initializer.alternate);
|
|
75562
|
+
const consequent = stripParenExpression(initializer.consequent);
|
|
75563
|
+
return (isNodeOfType(alternate, "Literal") && alternate.value === null || isNodeOfType(alternate, "Identifier") && alternate.name === "undefined" && context.scopes.isGlobalReference(alternate)) && isNodeOfType(consequent, "CallExpression") ? consequent : null;
|
|
75564
|
+
})() : null;
|
|
75565
|
+
if (!finderCall || !isNodeOfType(finderCall, "CallExpression")) return false;
|
|
73875
75566
|
if (!isOptionalResultPath && !isImmediatelyGuardedFinderResult(assertion, resultSymbol, resultPath, context)) return false;
|
|
73876
|
-
const finderCallee = stripParenExpression(
|
|
75567
|
+
const finderCallee = stripParenExpression(finderCall.callee);
|
|
73877
75568
|
if (!isNodeOfType(finderCallee, "Identifier") || !(context.scopes.symbolFor(finderCallee)?.kind === "import" && getImportedNameFromModule(assertion, finderCallee.name, CLOUDSCAPE_DOM_MODULE) === "findUpUntil" || finderCallee.name === "findUpUntil" && context.scopes.isGlobalReference(finderCallee))) return false;
|
|
73878
|
-
const predicateArgument =
|
|
75569
|
+
const predicateArgument = finderCall.arguments[1];
|
|
73879
75570
|
if (!predicateArgument) return false;
|
|
73880
75571
|
const predicateFunction = resolveExactLocalFunction(predicateArgument, context.scopes);
|
|
73881
75572
|
if (!predicateFunction || !isFunctionLike$1(predicateFunction)) return false;
|
|
@@ -73899,6 +75590,43 @@ const isMatchProvenByFindUpUntilPredicate = (assertion, matchReceiver, assertedP
|
|
|
73899
75590
|
});
|
|
73900
75591
|
return didProveMatch;
|
|
73901
75592
|
};
|
|
75593
|
+
const isMatchProvenByNormalizedFindUpUntilPredicate = (assertion, matchReceiver, assertedPattern, context) => {
|
|
75594
|
+
const normalizedReceiver = stripParenExpression(matchReceiver);
|
|
75595
|
+
if (!isNodeOfType(normalizedReceiver, "Identifier")) return false;
|
|
75596
|
+
const normalizedReceiverSymbol = context.scopes.symbolFor(normalizedReceiver);
|
|
75597
|
+
const normalizedReceiverInitializer = normalizedReceiverSymbol?.initializer ? stripParenExpression(normalizedReceiverSymbol.initializer) : null;
|
|
75598
|
+
const resultIdentifier = normalizedReceiverInitializer ? getNormalizedClassNameRoot(normalizedReceiverInitializer) : null;
|
|
75599
|
+
if (normalizedReceiverSymbol?.kind !== "const" || normalizedReceiverSymbol.references.some((reference) => reference.flag !== "read") || !resultIdentifier) return false;
|
|
75600
|
+
const resultSymbol = context.scopes.symbolFor(resultIdentifier);
|
|
75601
|
+
const finderCall = resultSymbol?.initializer ? stripParenExpression(resultSymbol.initializer) : null;
|
|
75602
|
+
if (resultSymbol?.kind !== "const" || resultSymbol.references.some((reference) => reference.flag !== "read") || !finderCall || !isNodeOfType(finderCall, "CallExpression")) return false;
|
|
75603
|
+
const finderCallee = stripParenExpression(finderCall.callee);
|
|
75604
|
+
if (!isNodeOfType(finderCallee, "Identifier") || context.scopes.symbolFor(finderCallee)?.kind !== "import" || getImportedNameFromModule(assertion, finderCallee.name, CLOUDSCAPE_DOM_MODULE) !== "findUpUntil") return false;
|
|
75605
|
+
if (!isPresenceProvenBeforeNode(assertion, (test) => {
|
|
75606
|
+
const expression = stripParenExpression(test);
|
|
75607
|
+
return isNodeOfType(expression, "Identifier") && context.scopes.symbolFor(expression)?.id === resultSymbol.id;
|
|
75608
|
+
})) return false;
|
|
75609
|
+
const predicateArgument = finderCall.arguments[1];
|
|
75610
|
+
const predicateFunction = predicateArgument ? resolveExactLocalFunction(predicateArgument, context.scopes) : null;
|
|
75611
|
+
if (!predicateFunction || !isFunctionLike$1(predicateFunction) || predicateFunction.async || predicateFunction.generator) return false;
|
|
75612
|
+
const predicateParameter = predicateFunction.params[0];
|
|
75613
|
+
if (!isNodeOfType(predicateParameter, "Identifier")) return false;
|
|
75614
|
+
let didProveNormalizedMatch = false;
|
|
75615
|
+
walkAst(predicateFunction.body, (child) => {
|
|
75616
|
+
if (didProveNormalizedMatch || isFunctionLike$1(child)) return false;
|
|
75617
|
+
if (!isNodeOfType(child, "CallExpression") || !isNodeOfType(child.callee, "MemberExpression") || getStaticPropertyName(child.callee) !== "match" || !child.arguments[0] || !areRegexPatternsEquivalent(child.arguments[0], assertedPattern, context) || !doesPredicateTruthRequireMatch(child, predicateFunction) && !doesPredicateReturnNormalizedMatch(child, predicateFunction)) return;
|
|
75618
|
+
const predicateReceiver = stripParenExpression(child.callee.object);
|
|
75619
|
+
if (!isNodeOfType(predicateReceiver, "Identifier")) return;
|
|
75620
|
+
const predicateReceiverSymbol = context.scopes.symbolFor(predicateReceiver);
|
|
75621
|
+
const predicateReceiverInitializer = predicateReceiverSymbol?.initializer ? stripParenExpression(predicateReceiverSymbol.initializer) : null;
|
|
75622
|
+
const predicateRoot = predicateReceiverInitializer ? getNormalizedClassNameRoot(predicateReceiverInitializer) : null;
|
|
75623
|
+
if (predicateReceiverSymbol?.kind === "const" && predicateReceiverSymbol.references.every((reference) => reference.flag === "read") && predicateRoot?.name === predicateParameter.name) {
|
|
75624
|
+
didProveNormalizedMatch = true;
|
|
75625
|
+
return false;
|
|
75626
|
+
}
|
|
75627
|
+
});
|
|
75628
|
+
return didProveNormalizedMatch;
|
|
75629
|
+
};
|
|
73902
75630
|
const scopeProvesFindMatch = (assertion, findReceiver, findPredicate, context) => {
|
|
73903
75631
|
if (!isStablePredicate(findPredicate, context)) return false;
|
|
73904
75632
|
return isPresenceProvenBeforeNode(assertion, (test) => testPositivelyContainsCall(test, (call) => {
|
|
@@ -73999,6 +75727,123 @@ const isEnsureThenFind = (assertion, findReceiver, findPredicate) => {
|
|
|
73999
75727
|
}
|
|
74000
75728
|
return false;
|
|
74001
75729
|
};
|
|
75730
|
+
const getReceiverRootIdentifier = (node) => {
|
|
75731
|
+
let target = stripParenExpression(node);
|
|
75732
|
+
while (isNodeOfType(target, "MemberExpression")) target = stripParenExpression(target.object);
|
|
75733
|
+
return isNodeOfType(target, "Identifier") ? target : null;
|
|
75734
|
+
};
|
|
75735
|
+
const getReceiverStatePath = (node) => {
|
|
75736
|
+
const target = stripParenExpression(node);
|
|
75737
|
+
if (isNodeOfType(target, "Identifier")) return target.name;
|
|
75738
|
+
if (!isNodeOfType(target, "MemberExpression")) return null;
|
|
75739
|
+
const objectPath = getReceiverStatePath(target.object);
|
|
75740
|
+
if (!objectPath) return null;
|
|
75741
|
+
return `${objectPath}.${getStaticPropertyName(target) ?? "*"}`;
|
|
75742
|
+
};
|
|
75743
|
+
const doesReceiverStateChangeBeforeAssertion = (ownerFunction, receiver, startOffset, assertion, context) => {
|
|
75744
|
+
const receiverRoot = getReceiverRootIdentifier(receiver);
|
|
75745
|
+
const receiverSymbol = receiverRoot ? context.scopes.symbolFor(receiverRoot) : null;
|
|
75746
|
+
const receiverPath = getReceiverStatePath(receiver);
|
|
75747
|
+
if (!receiverRoot || !receiverSymbol || !receiverPath) return true;
|
|
75748
|
+
const receiverAliasPaths = new Map([[receiverSymbol.id, receiverRoot.name]]);
|
|
75749
|
+
let didAddAlias = true;
|
|
75750
|
+
while (didAddAlias) {
|
|
75751
|
+
didAddAlias = false;
|
|
75752
|
+
walkAst(ownerFunction, (child) => {
|
|
75753
|
+
if (child !== ownerFunction && isFunctionLike$1(child)) return false;
|
|
75754
|
+
if (!isNodeOfType(child, "VariableDeclarator") || !isNodeOfType(child.id, "Identifier") || !child.init) return;
|
|
75755
|
+
const initializer = stripParenExpression(child.init);
|
|
75756
|
+
if (!isNodeOfType(initializer, "Identifier") && !isNodeOfType(initializer, "MemberExpression")) return;
|
|
75757
|
+
const initializerRoot = getReceiverRootIdentifier(initializer);
|
|
75758
|
+
const initializerSymbol = initializerRoot ? context.scopes.symbolFor(initializerRoot) : null;
|
|
75759
|
+
const initializerBasePath = initializerSymbol ? receiverAliasPaths.get(initializerSymbol.id) : null;
|
|
75760
|
+
const initializerPath = getReceiverStatePath(initializer);
|
|
75761
|
+
if (!initializerRoot || !initializerBasePath || !initializerPath) return;
|
|
75762
|
+
const aliasSymbol = context.scopes.symbolFor(child.id);
|
|
75763
|
+
if (aliasSymbol && !receiverAliasPaths.has(aliasSymbol.id)) {
|
|
75764
|
+
const initializerSuffix = initializerPath.slice(initializerRoot.name.length);
|
|
75765
|
+
receiverAliasPaths.set(aliasSymbol.id, `${initializerBasePath}${initializerSuffix}`);
|
|
75766
|
+
didAddAlias = true;
|
|
75767
|
+
}
|
|
75768
|
+
});
|
|
75769
|
+
}
|
|
75770
|
+
let didChangeReceiverState = false;
|
|
75771
|
+
walkAst(ownerFunction, (child) => {
|
|
75772
|
+
if (didChangeReceiverState) return false;
|
|
75773
|
+
if (child !== ownerFunction && isFunctionLike$1(child)) return false;
|
|
75774
|
+
if (child.range[0] <= startOffset || child.range[0] >= assertion.range[0]) return;
|
|
75775
|
+
if (isNodeOfType(child, "CallExpression")) {
|
|
75776
|
+
didChangeReceiverState = true;
|
|
75777
|
+
return false;
|
|
75778
|
+
}
|
|
75779
|
+
const mutationTarget = isNodeOfType(child, "AssignmentExpression") || isNodeOfType(child, "UpdateExpression") || isNodeOfType(child, "UnaryExpression") && child.operator === "delete" ? stripParenExpression(isNodeOfType(child, "AssignmentExpression") ? child.left : child.argument) : null;
|
|
75780
|
+
const mutationRoot = mutationTarget ? getReceiverRootIdentifier(mutationTarget) : null;
|
|
75781
|
+
const mutationSymbol = mutationRoot ? context.scopes.symbolFor(mutationRoot) : null;
|
|
75782
|
+
const mutationBasePath = mutationSymbol ? receiverAliasPaths.get(mutationSymbol.id) : null;
|
|
75783
|
+
const mutationPath = mutationTarget ? getReceiverStatePath(mutationTarget) : null;
|
|
75784
|
+
if (mutationRoot && mutationBasePath && mutationPath) {
|
|
75785
|
+
const canonicalMutationPath = `${mutationBasePath}${mutationPath.slice(mutationRoot.name.length)}`;
|
|
75786
|
+
if (canonicalMutationPath !== receiverPath && !canonicalMutationPath.startsWith(`${receiverPath}.`) && !receiverPath.startsWith(`${canonicalMutationPath}.`)) return;
|
|
75787
|
+
didChangeReceiverState = true;
|
|
75788
|
+
return false;
|
|
75789
|
+
}
|
|
75790
|
+
});
|
|
75791
|
+
return didChangeReceiverState;
|
|
75792
|
+
};
|
|
75793
|
+
const isFindProvenByGuardedMaximum = (assertion, findReceiver, findPredicate, context) => {
|
|
75794
|
+
const findLookup = findEqualityLookupParts(findPredicate);
|
|
75795
|
+
const maximumIdentifier = findLookup ? stripParenExpression(findLookup.comparedValue) : null;
|
|
75796
|
+
if (!findLookup || !maximumIdentifier || !isNodeOfType(maximumIdentifier, "Identifier")) return false;
|
|
75797
|
+
const maximumSymbol = context.scopes.symbolFor(maximumIdentifier);
|
|
75798
|
+
const maximumInitializer = maximumSymbol?.initializer ? stripParenExpression(maximumSymbol.initializer) : null;
|
|
75799
|
+
if (maximumSymbol?.kind !== "const" || maximumSymbol.references.some((reference) => reference.flag !== "read") || !maximumInitializer || !isNodeOfType(maximumInitializer, "CallExpression") || !isNodeOfType(maximumInitializer.callee, "MemberExpression") || getStaticPropertyName(maximumInitializer.callee) !== "reduce") return false;
|
|
75800
|
+
const filterCall = stripParenExpression(maximumInitializer.callee.object);
|
|
75801
|
+
if (!isNodeOfType(filterCall, "CallExpression") || !isNodeOfType(filterCall.callee, "MemberExpression") || getStaticPropertyName(filterCall.callee) !== "filter" || !areNodesLooselyEqual(filterCall.callee.object, findReceiver)) return false;
|
|
75802
|
+
const filterPredicate = filterCall.arguments[0] ? stripParenExpression(filterCall.arguments[0]) : null;
|
|
75803
|
+
if (!filterPredicate || !isStablePredicate(filterPredicate, context)) return false;
|
|
75804
|
+
const reducerArgument = maximumInitializer.arguments[0] ? stripParenExpression(maximumInitializer.arguments[0]) : null;
|
|
75805
|
+
const reducerFunction = reducerArgument ? resolveExactLocalFunction(reducerArgument, context.scopes) : null;
|
|
75806
|
+
const initialValue = maximumInitializer.arguments[1] ? stripParenExpression(maximumInitializer.arguments[1]) : null;
|
|
75807
|
+
if (!reducerFunction || !isFunctionLike$1(reducerFunction) || reducerFunction.async || reducerFunction.generator || !initialValue || !isNodeOfType(initialValue, "Literal") || typeof initialValue.value !== "number") return false;
|
|
75808
|
+
const accumulatorParameter = reducerFunction.params[0];
|
|
75809
|
+
const itemParameter = reducerFunction.params[1];
|
|
75810
|
+
const reducerBody = singleExpressionPredicateBody(reducerFunction);
|
|
75811
|
+
if (!isNodeOfType(accumulatorParameter, "Identifier") || !isNodeOfType(itemParameter, "Identifier") || !reducerBody || !isNodeOfType(reducerBody, "CallExpression") || !isNodeOfType(reducerBody.callee, "MemberExpression") || getStaticPropertyName(reducerBody.callee) !== "max") return false;
|
|
75812
|
+
const mathReceiver = stripParenExpression(reducerBody.callee.object);
|
|
75813
|
+
if (!isNodeOfType(mathReceiver, "Identifier") || mathReceiver.name !== "Math" || !context.scopes.isGlobalReference(mathReceiver) || reducerBody.arguments.length !== 2) return false;
|
|
75814
|
+
const accumulatorArgument = reducerBody.arguments.find((argument) => {
|
|
75815
|
+
const expression = stripParenExpression(argument);
|
|
75816
|
+
return isNodeOfType(expression, "Identifier") && expression.name === accumulatorParameter.name;
|
|
75817
|
+
});
|
|
75818
|
+
const itemMemberArgument = reducerBody.arguments.find((argument) => {
|
|
75819
|
+
const expression = stripParenExpression(argument);
|
|
75820
|
+
const rootIdentifier = getRootIdentifier(expression);
|
|
75821
|
+
return isNodeOfType(expression, "MemberExpression") && rootIdentifier?.name === itemParameter.name && receiverPathKey(expression)?.slice(itemParameter.name.length + 1) === findLookup.propertyName;
|
|
75822
|
+
});
|
|
75823
|
+
if (!accumulatorArgument || !itemMemberArgument) return false;
|
|
75824
|
+
if (!receiverPathKey(findReceiver)) return false;
|
|
75825
|
+
let ownerFunction = assertion.parent ?? null;
|
|
75826
|
+
while (ownerFunction && !isFunctionLike$1(ownerFunction)) ownerFunction = ownerFunction.parent ?? null;
|
|
75827
|
+
if (!ownerFunction || !isFunctionLike$1(ownerFunction)) return false;
|
|
75828
|
+
const maximumEnd = maximumInitializer.range[1];
|
|
75829
|
+
if (doesReceiverStateChangeBeforeAssertion(ownerFunction.body, findReceiver, maximumEnd, assertion, context)) return false;
|
|
75830
|
+
return isPresenceProvenBeforeNode(assertion, (test) => {
|
|
75831
|
+
const comparison = stripParenExpression(test);
|
|
75832
|
+
if (!isNodeOfType(comparison, "BinaryExpression")) return false;
|
|
75833
|
+
return [[
|
|
75834
|
+
comparison.left,
|
|
75835
|
+
comparison.right,
|
|
75836
|
+
comparison.operator
|
|
75837
|
+
], [
|
|
75838
|
+
comparison.right,
|
|
75839
|
+
comparison.left,
|
|
75840
|
+
comparison.operator === "<" ? ">" : comparison.operator === ">" ? "<" : comparison.operator
|
|
75841
|
+
]].some(([candidateMaximum, candidateInitial, operator]) => {
|
|
75842
|
+
const candidateMaximumIdentifier = stripParenExpression(candidateMaximum);
|
|
75843
|
+
return operator === ">" && isNodeOfType(candidateMaximumIdentifier, "Identifier") && context.scopes.symbolFor(candidateMaximumIdentifier)?.id === maximumSymbol.id && areNodesLooselyEqual(stripParenExpression(candidateInitial), initialValue);
|
|
75844
|
+
});
|
|
75845
|
+
});
|
|
75846
|
+
};
|
|
74002
75847
|
const isDefinitelyNonNullishMapValue = (value) => {
|
|
74003
75848
|
if (!value) return false;
|
|
74004
75849
|
const expression = stripParenExpression(value);
|
|
@@ -74022,15 +75867,15 @@ const unwrapFalseBooleanGuard = (test) => {
|
|
|
74022
75867
|
};
|
|
74023
75868
|
const isEnsureThenMapGet = (assertion, receiver, lookupKey, context) => {
|
|
74024
75869
|
const stableLookupKey = stripParenExpression(lookupKey);
|
|
74025
|
-
|
|
75870
|
+
const lookupKeyRoot = isNodeOfType(stableLookupKey, "MemberExpression") ? getRootIdentifier(stableLookupKey) : null;
|
|
75871
|
+
const lookupKeySymbol = isNodeOfType(stableLookupKey, "Identifier") ? context.scopes.symbolFor(stableLookupKey) : lookupKeyRoot ? context.scopes.symbolFor(lookupKeyRoot) : null;
|
|
75872
|
+
if (!isNodeOfType(stableLookupKey, "Identifier") && !isNodeOfType(stableLookupKey, "Literal") && (!isNodeOfType(stableLookupKey, "MemberExpression") || !lookupKeyRoot || lookupKeySymbol?.kind !== "const")) return false;
|
|
74026
75873
|
const receiverSymbol = context.scopes.symbolFor(receiver);
|
|
74027
75874
|
if (!receiverSymbol) return false;
|
|
74028
75875
|
const receiverMatches = (candidate) => {
|
|
74029
75876
|
const target = stripParenExpression(candidate);
|
|
74030
75877
|
return isNodeOfType(target, "Identifier") && context.scopes.symbolFor(target)?.id === receiverSymbol.id;
|
|
74031
75878
|
};
|
|
74032
|
-
const lookupKeyExpression = stripParenExpression(lookupKey);
|
|
74033
|
-
const lookupKeySymbol = isNodeOfType(lookupKeyExpression, "Identifier") ? context.scopes.symbolFor(lookupKeyExpression) : null;
|
|
74034
75879
|
let child = assertion;
|
|
74035
75880
|
let ancestor = assertion.parent ?? null;
|
|
74036
75881
|
while (ancestor && !isFunctionLike$1(ancestor)) {
|
|
@@ -74050,7 +75895,7 @@ const isEnsureThenMapGet = (assertion, receiver, lookupKey, context) => {
|
|
|
74050
75895
|
const populationCall = populationCalls[0];
|
|
74051
75896
|
if (!populationCall) continue;
|
|
74052
75897
|
const populationCallStart = populationCall.range[0];
|
|
74053
|
-
if (Boolean(lookupKeySymbol?.references.some((reference) => reference.flag !== "read" && reference.identifier.range[0] > populationCallStart && reference.identifier.range[0] < assertion.range[0]))) continue;
|
|
75898
|
+
if (Boolean(lookupKeySymbol?.references.some((reference) => reference.flag !== "read" && reference.identifier.range[0] > populationCallStart && reference.identifier.range[0] < assertion.range[0])) || Boolean(lookupKeySymbol && isNodeOfType(stableLookupKey, "MemberExpression") && subtreeWritesSymbol(ancestor, new Set([lookupKeySymbol.id]), context, void 0, assertion))) continue;
|
|
74054
75899
|
if (receiverSymbol.references.some((reference) => reference.flag !== "read" && reference.identifier.range[0] > populationCallStart && reference.identifier.range[0] < assertion.range[0])) continue;
|
|
74055
75900
|
if (!indexedRelevantCalls(ancestor).some((laterCall) => {
|
|
74056
75901
|
if (laterCall.range[0] <= populationCallStart || laterCall.range[0] >= assertion.range[0] || !isNodeOfType(laterCall.callee, "MemberExpression") || !receiverMatches(laterCall.callee.object)) return false;
|
|
@@ -74160,6 +76005,7 @@ const noNonNullAssertionOnMaybeUndefinedResult = defineRule({
|
|
|
74160
76005
|
const findReceiver = callee.object;
|
|
74161
76006
|
if (predicate && isExhaustiveLiteralTupleMapping(findReceiver, predicate, context)) return;
|
|
74162
76007
|
if (predicate && scopeProvesFindMatch(node, findReceiver, predicate, context)) return;
|
|
76008
|
+
if (predicate && isFindProvenByGuardedMaximum(node, findReceiver, predicate, context)) return;
|
|
74163
76009
|
if (predicate && isEnsureThenFind(node, findReceiver, predicate)) return;
|
|
74164
76010
|
}
|
|
74165
76011
|
if (methodName === "match") {
|
|
@@ -74169,6 +76015,7 @@ const noNonNullAssertionOnMaybeUndefinedResult = defineRule({
|
|
|
74169
76015
|
const regexKey = pattern ? regexComparableKey(pattern, context) : null;
|
|
74170
76016
|
if (pattern && isGuardedAnchoredCharacterMatch(node, matchReceiver, pattern)) return;
|
|
74171
76017
|
if (pattern && regexKey && isMatchProvenByFindUpUntilPredicate(node, matchReceiver, pattern, context)) return;
|
|
76018
|
+
if (pattern && regexKey && isMatchProvenByNormalizedFindUpUntilPredicate(node, matchReceiver, pattern, context)) return;
|
|
74172
76019
|
if (regexKey && scopeProvesMatchTested(node, regexKey, matchReceiver, context)) return;
|
|
74173
76020
|
}
|
|
74174
76021
|
if (methodName === "get") {
|
|
@@ -78107,16 +79954,23 @@ const MAX_INITIATOR_RESOLUTION_DEPTH = 3;
|
|
|
78107
79954
|
const STATE_DISPATCHER_HOOK_NAMES = new Set(["useState", "useReducer"]);
|
|
78108
79955
|
const REF_HOOK_NAMES = new Set(["useRef"]);
|
|
78109
79956
|
const MESSAGE$26 = "This promise chain runs in an effect, ends in a `.then` that sets state or mutates a ref, and has no `.catch` or enclosing try/catch, so a rejection leaves the state unset and surfaces as an unhandled rejection. Add a `.catch` handler on the chain (`.finally` does not count).";
|
|
78110
|
-
const
|
|
79957
|
+
const isKnownNonRejectingHandlerReturn = (expression, context, visitedBindingIdentifiers = /* @__PURE__ */ new Set()) => {
|
|
78111
79958
|
const strippedExpression = stripParenExpression(expression);
|
|
78112
79959
|
if (isDefinitelyNonThenableValue(strippedExpression)) return true;
|
|
79960
|
+
if (isNodeOfType(strippedExpression, "CallExpression") && isNodeOfType(strippedExpression.callee, "MemberExpression")) {
|
|
79961
|
+
const receiver = stripParenExpression(strippedExpression.callee.object);
|
|
79962
|
+
if (isNodeOfType(receiver, "Identifier") && receiver.name === "Promise" && context.scopes.isGlobalReference(receiver) && getStaticPropertyName(strippedExpression.callee) === "resolve") {
|
|
79963
|
+
const resolvedValue = strippedExpression.arguments[0];
|
|
79964
|
+
return !resolvedValue || !isNodeOfType(resolvedValue, "SpreadElement") && isKnownNonRejectingHandlerReturn(resolvedValue, context, visitedBindingIdentifiers);
|
|
79965
|
+
}
|
|
79966
|
+
}
|
|
78113
79967
|
if (!isNodeOfType(strippedExpression, "Identifier")) return false;
|
|
78114
79968
|
if (strippedExpression.name === "undefined" && context.scopes.isGlobalReference(strippedExpression)) return true;
|
|
78115
79969
|
const symbol = context.scopes.symbolFor(strippedExpression);
|
|
78116
79970
|
if (!symbol || visitedBindingIdentifiers.has(symbol.bindingIdentifier)) return false;
|
|
78117
79971
|
visitedBindingIdentifiers.add(symbol.bindingIdentifier);
|
|
78118
79972
|
const initializer = getDirectUnreassignedInitializer(symbol);
|
|
78119
|
-
return Boolean(initializer &&
|
|
79973
|
+
return Boolean(initializer && isKnownNonRejectingHandlerReturn(initializer, context, visitedBindingIdentifiers));
|
|
78120
79974
|
};
|
|
78121
79975
|
const isKnownNonRejectingHandler = (argument, context) => {
|
|
78122
79976
|
if (!argument) return false;
|
|
@@ -78131,7 +79985,7 @@ const isKnownNonRejectingHandler = (argument, context) => {
|
|
|
78131
79985
|
canReject = true;
|
|
78132
79986
|
return false;
|
|
78133
79987
|
}
|
|
78134
|
-
if (isNodeOfType(child, "ReturnStatement") && child.argument && !
|
|
79988
|
+
if (isNodeOfType(child, "ReturnStatement") && child.argument && !isKnownNonRejectingHandlerReturn(child.argument, context)) {
|
|
78135
79989
|
if (!isNodeOfType(stripParenExpression(child.argument), "CallExpression")) {
|
|
78136
79990
|
canReject = true;
|
|
78137
79991
|
return false;
|
|
@@ -78180,6 +80034,28 @@ const handlerHasPotentiallyThrowingMemberRead = (argument, context) => {
|
|
|
78180
80034
|
});
|
|
78181
80035
|
return hasPotentiallyThrowingMemberRead;
|
|
78182
80036
|
};
|
|
80037
|
+
const hasRejectionHandler = (chain, argument, context, allowTerminalCatchBlock) => {
|
|
80038
|
+
if (!argument) return false;
|
|
80039
|
+
if (!handlerHasPotentiallyThrowingMemberRead(argument, context) && (chainCarriesRejectionHandler(chain, context.scopes) || isKnownNonRejectingHandler(argument, context))) return true;
|
|
80040
|
+
if (!allowTerminalCatchBlock) return false;
|
|
80041
|
+
const candidate = stripParenExpression(argument);
|
|
80042
|
+
const handler = isNodeOfType(candidate, "Identifier") ? resolveExactLocalFunction(candidate, context.scopes) : candidate;
|
|
80043
|
+
if (!handler || !isFunctionLike$1(handler)) return isNodeOfType(candidate, "MemberExpression") || isNodeOfType(candidate, "Identifier") && candidate.name !== "undefined";
|
|
80044
|
+
if (!isNodeOfType(handler.body, "BlockStatement")) return false;
|
|
80045
|
+
let doesExplicitlyReject = false;
|
|
80046
|
+
walkOwnFunctionScope(handler, (child) => {
|
|
80047
|
+
if (doesExplicitlyReject) return false;
|
|
80048
|
+
if (isNodeOfType(child, "ThrowStatement") || isNodeOfType(child, "AwaitExpression")) {
|
|
80049
|
+
doesExplicitlyReject = true;
|
|
80050
|
+
return false;
|
|
80051
|
+
}
|
|
80052
|
+
if (isNodeOfType(child, "ReturnStatement") && child.argument && !isKnownNonRejectingHandlerReturn(child.argument, context)) {
|
|
80053
|
+
doesExplicitlyReject = true;
|
|
80054
|
+
return false;
|
|
80055
|
+
}
|
|
80056
|
+
});
|
|
80057
|
+
return !doesExplicitlyReject;
|
|
80058
|
+
};
|
|
78183
80059
|
const walkPromiseChain = (chainExpression, context) => {
|
|
78184
80060
|
let cursor = stripParenExpression(chainExpression);
|
|
78185
80061
|
let hasCatch = false;
|
|
@@ -78191,10 +80067,9 @@ const walkPromiseChain = (chainExpression, context) => {
|
|
|
78191
80067
|
while (isNodeOfType(cursor, "CallExpression") && isNodeOfType(cursor.callee, "MemberExpression") && PROMISE_METHOD_NAMES.has(getStaticPropertyName(cursor.callee) ?? "")) {
|
|
78192
80068
|
const methodName = getStaticPropertyName(cursor.callee);
|
|
78193
80069
|
const rejectionHandlerArgument = methodName === "catch" ? cursor.arguments[0] : cursor.arguments[1];
|
|
78194
|
-
|
|
78195
|
-
if (!didReachTerminalThen && methodName === "catch" && hasAbsorbingRejectionHandler) hasCatch = true;
|
|
80070
|
+
if (!didReachTerminalThen && methodName === "catch" && hasRejectionHandler(cursor, rejectionHandlerArgument, context, true)) hasCatch = true;
|
|
78196
80071
|
if (methodName === "then") {
|
|
78197
|
-
if (!didReachTerminalThen &&
|
|
80072
|
+
if (!didReachTerminalThen && hasRejectionHandler(cursor, rejectionHandlerArgument, context, false)) hasRejectionHandlerArgument = true;
|
|
78198
80073
|
didReachTerminalThen = true;
|
|
78199
80074
|
sawThen = true;
|
|
78200
80075
|
const callbackArgument = cursor.arguments[0];
|
|
@@ -80521,6 +82396,45 @@ const noRefCallbackCleanupBeforeReact19 = defineRule({
|
|
|
80521
82396
|
} })
|
|
80522
82397
|
});
|
|
80523
82398
|
//#endregion
|
|
82399
|
+
//#region src/plugin/utils/contains-non-deterministic-source.ts
|
|
82400
|
+
const NON_DETERMINISTIC_MEMBER_CALLS = new Set([
|
|
82401
|
+
"Math.random",
|
|
82402
|
+
"Date.now",
|
|
82403
|
+
"performance.now",
|
|
82404
|
+
"crypto.randomUUID",
|
|
82405
|
+
"crypto.getRandomValues"
|
|
82406
|
+
]);
|
|
82407
|
+
const NON_DETERMINISTIC_ID_GENERATOR_NAMES = new Set([
|
|
82408
|
+
"nanoid",
|
|
82409
|
+
"uuid",
|
|
82410
|
+
"cuid",
|
|
82411
|
+
"ulid",
|
|
82412
|
+
"createId"
|
|
82413
|
+
]);
|
|
82414
|
+
const isZeroArgDateConstruction = (node) => isNodeOfType(node, "NewExpression") && isNodeOfType(node.callee, "Identifier") && node.callee.name === "Date" && (node.arguments?.length ?? 0) === 0;
|
|
82415
|
+
const containsNonDeterministicSource = (root) => {
|
|
82416
|
+
let found = false;
|
|
82417
|
+
walkAst(root, (child) => {
|
|
82418
|
+
if (found) return false;
|
|
82419
|
+
if (isFunctionLike$1(child)) return false;
|
|
82420
|
+
if (isZeroArgDateConstruction(child)) {
|
|
82421
|
+
found = true;
|
|
82422
|
+
return false;
|
|
82423
|
+
}
|
|
82424
|
+
if (!isNodeOfType(child, "CallExpression")) return;
|
|
82425
|
+
const callee = child.callee;
|
|
82426
|
+
if (isNodeOfType(callee, "Identifier") && NON_DETERMINISTIC_ID_GENERATOR_NAMES.has(callee.name)) {
|
|
82427
|
+
found = true;
|
|
82428
|
+
return false;
|
|
82429
|
+
}
|
|
82430
|
+
if (isNodeOfType(callee, "MemberExpression") && isNodeOfType(callee.object, "Identifier") && isNodeOfType(callee.property, "Identifier") && NON_DETERMINISTIC_MEMBER_CALLS.has(`${callee.object.name}.${callee.property.name}`)) {
|
|
82431
|
+
found = true;
|
|
82432
|
+
return false;
|
|
82433
|
+
}
|
|
82434
|
+
});
|
|
82435
|
+
return found;
|
|
82436
|
+
};
|
|
82437
|
+
//#endregion
|
|
80524
82438
|
//#region src/plugin/rules/state-and-effects/no-ref-current-in-render.ts
|
|
80525
82439
|
const REPEATED_ANCESTOR_TYPES = new Set([
|
|
80526
82440
|
"DoWhileStatement",
|
|
@@ -80551,45 +82465,75 @@ const resolveImmutableInitializationValue = (node, scopes, visitedSymbolIds = /*
|
|
|
80551
82465
|
};
|
|
80552
82466
|
const isProvablyTruthyInitializationValue = (node, scopes) => {
|
|
80553
82467
|
const expression = resolveImmutableInitializationValue(node, scopes);
|
|
80554
|
-
|
|
82468
|
+
if (!expression) return false;
|
|
82469
|
+
if (isNodeOfType(expression, "CallExpression")) {
|
|
82470
|
+
const callee = stripParenExpression(expression.callee);
|
|
82471
|
+
return isNodeOfType(callee, "Identifier") && callee.name.startsWith("create");
|
|
82472
|
+
}
|
|
82473
|
+
return isNodeOfType(expression, "NewExpression") || isNodeOfType(expression, "ObjectExpression") || isNodeOfType(expression, "ArrayExpression") || isNodeOfType(expression, "ArrowFunctionExpression") || isNodeOfType(expression, "FunctionExpression") || isNodeOfType(expression, "ClassExpression");
|
|
80555
82474
|
};
|
|
80556
|
-
const
|
|
82475
|
+
const getInitializationValueName = (node, scopes) => {
|
|
80557
82476
|
const expression = resolveImmutableInitializationValue(node, scopes);
|
|
80558
82477
|
if (!expression) return null;
|
|
80559
|
-
if (isNodeOfType(expression, "NewExpression")) {
|
|
82478
|
+
if (isNodeOfType(expression, "NewExpression") || isNodeOfType(expression, "CallExpression")) {
|
|
80560
82479
|
const callee = stripParenExpression(expression.callee);
|
|
80561
|
-
|
|
82480
|
+
if (!isNodeOfType(callee, "Identifier")) return null;
|
|
82481
|
+
return callee.name.startsWith("create") && callee.name.length > 6 ? callee.name.slice(6) : callee.name;
|
|
80562
82482
|
}
|
|
80563
82483
|
return null;
|
|
80564
82484
|
};
|
|
82485
|
+
const isMatchingReturnType = (typeNode, initializationValue, scopes) => {
|
|
82486
|
+
if (!isNodeOfType(typeNode, "TSTypeReference")) return false;
|
|
82487
|
+
const typeName = typeNode.typeName;
|
|
82488
|
+
if (!isNodeOfType(typeName, "Identifier") || typeName.name !== "ReturnType") return false;
|
|
82489
|
+
const [returnTypeArgument] = typeNode.typeArguments?.params ?? [];
|
|
82490
|
+
if (!returnTypeArgument || !isNodeOfType(returnTypeArgument, "TSTypeQuery")) return false;
|
|
82491
|
+
const queriedName = returnTypeArgument.exprName;
|
|
82492
|
+
const expression = stripParenExpression(initializationValue);
|
|
82493
|
+
if (!isNodeOfType(queriedName, "Identifier") || !isNodeOfType(expression, "CallExpression")) return false;
|
|
82494
|
+
const callee = stripParenExpression(expression.callee);
|
|
82495
|
+
if (!isNodeOfType(callee, "Identifier")) return false;
|
|
82496
|
+
const queriedSymbol = scopes.symbolFor(queriedName);
|
|
82497
|
+
const calleeSymbol = scopes.symbolFor(callee);
|
|
82498
|
+
return queriedSymbol && calleeSymbol ? queriedSymbol.id === calleeSymbol.id : queriedName.name === callee.name;
|
|
82499
|
+
};
|
|
80565
82500
|
const isClosedTruthyTypeDomain = (typeNode, initializationValue, scopes) => {
|
|
80566
82501
|
const initializationExpression = stripParenExpression(initializationValue);
|
|
80567
82502
|
if (isNodeOfType(typeNode, "TSTypeLiteral")) return isNodeOfType(initializationExpression, "ObjectExpression");
|
|
80568
82503
|
if (isNodeOfType(typeNode, "TSArrayType") || isNodeOfType(typeNode, "TSTupleType")) return isNodeOfType(initializationExpression, "ArrayExpression");
|
|
80569
82504
|
if (isNodeOfType(typeNode, "TSFunctionType") || isNodeOfType(typeNode, "TSConstructorType")) return isNodeOfType(initializationExpression, "ArrowFunctionExpression") || isNodeOfType(initializationExpression, "FunctionExpression") || isNodeOfType(initializationExpression, "ClassExpression");
|
|
80570
82505
|
if (isNodeOfType(typeNode, "TSObjectKeyword")) return true;
|
|
82506
|
+
if (isNodeOfType(typeNode, "TSIndexedAccessType")) return isNodeOfType(initializationExpression, "ObjectExpression");
|
|
80571
82507
|
if (!isNodeOfType(typeNode, "TSTypeReference")) return false;
|
|
80572
82508
|
const typeName = typeNode.typeName;
|
|
80573
|
-
|
|
82509
|
+
if (isNodeOfType(initializationExpression, "ObjectExpression") || isMatchingReturnType(typeNode, initializationExpression, scopes)) return true;
|
|
82510
|
+
return isNodeOfType(typeName, "Identifier") && typeName.name === getInitializationValueName(initializationExpression, scopes);
|
|
80574
82511
|
};
|
|
80575
82512
|
const refHasClosedFalsySentinelDomain = (refSymbol, initializationValue, scopes) => {
|
|
80576
82513
|
const initializer = refSymbol.initializer ? stripParenExpression(refSymbol.initializer) : null;
|
|
80577
82514
|
if (!initializer || !isNodeOfType(initializer, "CallExpression")) return false;
|
|
80578
82515
|
const [initialValue] = initializer.arguments ?? [];
|
|
80579
|
-
if (
|
|
82516
|
+
if (initialValue && isNodeOfType(initialValue, "SpreadElement") || initialValue && !isEmptySentinel(initialValue, scopes)) return false;
|
|
80580
82517
|
const [declaredType] = initializer.typeArguments?.params ?? [];
|
|
80581
|
-
if (!declaredType
|
|
80582
|
-
|
|
82518
|
+
if (!declaredType) return false;
|
|
82519
|
+
const domainTypes = isNodeOfType(declaredType, "TSUnionType") ? declaredType.types : [declaredType];
|
|
80583
82520
|
let hasTruthyDomain = false;
|
|
80584
|
-
for (const memberType of
|
|
80585
|
-
if (isNodeOfType(memberType, "TSNullKeyword") || isNodeOfType(memberType, "TSUndefinedKeyword"))
|
|
80586
|
-
hasEmptySentinel = true;
|
|
80587
|
-
continue;
|
|
80588
|
-
}
|
|
82521
|
+
for (const memberType of domainTypes) {
|
|
82522
|
+
if (isNodeOfType(memberType, "TSNullKeyword") || isNodeOfType(memberType, "TSUndefinedKeyword")) continue;
|
|
80589
82523
|
if (!isClosedTruthyTypeDomain(memberType, initializationValue, scopes)) return false;
|
|
80590
82524
|
hasTruthyDomain = true;
|
|
80591
82525
|
}
|
|
80592
|
-
return
|
|
82526
|
+
return hasTruthyDomain;
|
|
82527
|
+
};
|
|
82528
|
+
const refHasEmptySentinelInitializer = (refSymbol, scopes) => {
|
|
82529
|
+
const initializer = refSymbol.initializer ? stripParenExpression(refSymbol.initializer) : null;
|
|
82530
|
+
if (!initializer || !isNodeOfType(initializer, "CallExpression")) return false;
|
|
82531
|
+
const [initialValue] = initializer.arguments ?? [];
|
|
82532
|
+
return Boolean(!initialValue || !isNodeOfType(initialValue, "SpreadElement") && isEmptySentinel(initialValue, scopes));
|
|
82533
|
+
};
|
|
82534
|
+
const refHasDeclaredType = (refSymbol) => {
|
|
82535
|
+
const initializer = refSymbol.initializer ? stripParenExpression(refSymbol.initializer) : null;
|
|
82536
|
+
return Boolean(initializer && isNodeOfType(initializer, "CallExpression") && (initializer.typeArguments?.params.length ?? 0) > 0);
|
|
80593
82537
|
};
|
|
80594
82538
|
const isSafeRefIdentifierUse = (identifier) => {
|
|
80595
82539
|
const expressionRoot = findTransparentExpressionRoot(identifier);
|
|
@@ -80621,25 +82565,40 @@ const expressionContainsRefCurrent = (expression, refSymbol, scopes) => {
|
|
|
80621
82565
|
});
|
|
80622
82566
|
return didFindRefCurrent;
|
|
80623
82567
|
};
|
|
80624
|
-
const
|
|
80625
|
-
|
|
80626
|
-
|
|
80627
|
-
|
|
80628
|
-
|
|
80629
|
-
|
|
80630
|
-
|
|
82568
|
+
const isEmptySentinel = (node, scopes) => {
|
|
82569
|
+
const expression = stripParenExpression(node);
|
|
82570
|
+
return isNodeOfType(expression, "Literal") && expression.value === null || isNodeOfType(expression, "Identifier") && expression.name === "undefined" && scopes.isGlobalReference(expression);
|
|
82571
|
+
};
|
|
82572
|
+
const isInitializationInputIndependent = (node, renderOwner, scopes, visitedSymbolIds = /* @__PURE__ */ new Set()) => {
|
|
82573
|
+
let isInputIndependent = true;
|
|
82574
|
+
walkAst(node, (child) => {
|
|
82575
|
+
if (!isInputIndependent) return false;
|
|
82576
|
+
if (resolveReactRefSymbol(child, scopes)) return false;
|
|
82577
|
+
if (!isNodeOfType(child, "Identifier")) return;
|
|
82578
|
+
const symbol = scopes.symbolFor(child);
|
|
82579
|
+
if (!symbol) return;
|
|
82580
|
+
if (symbol.kind === "import") return false;
|
|
82581
|
+
if (symbol.kind === "let" || symbol.kind === "var" || symbol.kind === "using") {
|
|
82582
|
+
isInputIndependent = false;
|
|
82583
|
+
return false;
|
|
80631
82584
|
}
|
|
80632
|
-
if (
|
|
80633
|
-
|
|
80634
|
-
|
|
82585
|
+
if (isOutsideAllFunctions(symbol)) return false;
|
|
82586
|
+
if (symbol.kind === "parameter") {
|
|
82587
|
+
if (symbol.scope.node === renderOwner) isInputIndependent = false;
|
|
82588
|
+
return false;
|
|
80635
82589
|
}
|
|
80636
|
-
if (
|
|
80637
|
-
|
|
82590
|
+
if (!symbol.initializer || symbol.references.some((reference) => reference.flag !== "read")) {
|
|
82591
|
+
isInputIndependent = false;
|
|
82592
|
+
return false;
|
|
80638
82593
|
}
|
|
82594
|
+
if (visitedSymbolIds.has(symbol.id)) return false;
|
|
82595
|
+
visitedSymbolIds.add(symbol.id);
|
|
82596
|
+
if (!isInitializationInputIndependent(symbol.initializer, renderOwner, scopes, visitedSymbolIds)) isInputIndependent = false;
|
|
82597
|
+
return false;
|
|
80639
82598
|
});
|
|
80640
|
-
return
|
|
82599
|
+
return isInputIndependent;
|
|
80641
82600
|
};
|
|
80642
|
-
const
|
|
82601
|
+
const isPredictableInitializationValue = (node, refSymbol, renderOwner, scopes, requiresClosedTruthyDomain) => isInitializationInputIndependent(node, renderOwner, scopes) && !containsNonDeterministicSource(node) && (isProvablyTruthyInitializationValue(node, scopes) && (!requiresClosedTruthyDomain || !refHasDeclaredType(refSymbol)) || refHasClosedFalsySentinelDomain(refSymbol, node, scopes));
|
|
80643
82602
|
const hasRepeatedExecutionAncestor = (node, stop) => {
|
|
80644
82603
|
let ancestor = node.parent;
|
|
80645
82604
|
while (ancestor && ancestor !== stop) {
|
|
@@ -80669,6 +82628,27 @@ const canExecuteTogether = (firstConstraints, secondConstraints) => {
|
|
|
80669
82628
|
}
|
|
80670
82629
|
return true;
|
|
80671
82630
|
};
|
|
82631
|
+
const hasNoCoExecutableCompetingWrite = (assignmentExpression, renderOwner, refSymbol, scopes) => {
|
|
82632
|
+
const assignmentConstraints = getBranchConstraints(assignmentExpression, renderOwner);
|
|
82633
|
+
const synchronouslyInvokedFunctions = collectSynchronouslyEffectInvokedFunctions(renderOwner, scopes);
|
|
82634
|
+
let hasCompetingWrite = false;
|
|
82635
|
+
walkAst(renderOwner, (child) => {
|
|
82636
|
+
if (hasCompetingWrite) return false;
|
|
82637
|
+
let writtenExpression = null;
|
|
82638
|
+
if (isNodeOfType(child, "AssignmentExpression")) {
|
|
82639
|
+
if (child === assignmentExpression) return;
|
|
82640
|
+
writtenExpression = child.left;
|
|
82641
|
+
} else if (isNodeOfType(child, "UpdateExpression") || isNodeOfType(child, "UnaryExpression") && child.operator === "delete") writtenExpression = child.argument;
|
|
82642
|
+
else if (isNodeOfType(child, "ForInStatement") || isNodeOfType(child, "ForOfStatement")) writtenExpression = child.left;
|
|
82643
|
+
const deferredExecutionBoundary = findDeferredExecutionBoundary(child);
|
|
82644
|
+
const deferredWriteValue = isNodeOfType(child, "AssignmentExpression") && child.operator === "=" ? resolveImmutableInitializationValue(child.right, scopes) : null;
|
|
82645
|
+
const isDeferredTruthyWrite = deferredExecutionBoundary !== null && deferredExecutionBoundary !== renderOwner && !synchronouslyInvokedFunctions.has(deferredExecutionBoundary) && !executesDuringRender(deferredExecutionBoundary, scopes) && deferredWriteValue !== null && !isNodeOfType(deferredWriteValue, "CallExpression") && isProvablyTruthyInitializationValue(deferredWriteValue, scopes);
|
|
82646
|
+
if (!writtenExpression || isDeferredTruthyWrite || !expressionContainsRefCurrent(writtenExpression, refSymbol, scopes) || !canExecuteTogether(assignmentConstraints, getBranchConstraints(child, renderOwner))) return;
|
|
82647
|
+
hasCompetingWrite = true;
|
|
82648
|
+
return false;
|
|
82649
|
+
});
|
|
82650
|
+
return !hasCompetingWrite;
|
|
82651
|
+
};
|
|
80672
82652
|
const hasNoPriorCoExecutableWrite = (assignmentExpression, branchRoot, refSymbol, scopes) => {
|
|
80673
82653
|
const assignmentConstraints = getBranchConstraints(assignmentExpression, branchRoot);
|
|
80674
82654
|
const assignmentStart = getRangeStart(assignmentExpression);
|
|
@@ -80684,16 +82664,17 @@ const hasNoPriorCoExecutableWrite = (assignmentExpression, branchRoot, refSymbol
|
|
|
80684
82664
|
});
|
|
80685
82665
|
return !hasCoExecutableWrite;
|
|
80686
82666
|
};
|
|
82667
|
+
const isPredictableGuardedInitialization = (assignmentExpression, guardedBranch, renderOwner, refSymbol, scopes, requiresClosedTruthyDomain) => refHasEmptySentinelInitializer(refSymbol, scopes) && isPredictableInitializationValue(assignmentExpression.right, refSymbol, renderOwner, scopes, requiresClosedTruthyDomain) && !hasRepeatedExecutionAncestor(assignmentExpression, guardedBranch) && (guardedBranch === renderOwner || !hasRepeatedExecutionAncestor(guardedBranch, renderOwner)) && hasNoPriorCoExecutableWrite(assignmentExpression, renderOwner, refSymbol, scopes) && hasNoCoExecutableCompetingWrite(assignmentExpression, renderOwner, refSymbol, scopes) && refDoesNotEscape(renderOwner, refSymbol, scopes);
|
|
80687
82668
|
const isDocumentedLazyInitialization = (assignmentExpression, refSymbol, scopes) => {
|
|
80688
|
-
if (assignmentExpression.operator === "??=" || assignmentExpression.operator === "||=") return true;
|
|
80689
|
-
if (assignmentExpression.operator !== "=") return false;
|
|
80690
82669
|
const renderOwner = findRenderPhaseComponentOrHook(assignmentExpression, scopes);
|
|
80691
82670
|
if (!renderOwner) return false;
|
|
82671
|
+
if (assignmentExpression.operator === "??=" || assignmentExpression.operator === "||=") return isPredictableGuardedInitialization(assignmentExpression, renderOwner, renderOwner, refSymbol, scopes, assignmentExpression.operator === "||=");
|
|
82672
|
+
if (assignmentExpression.operator !== "=") return false;
|
|
80692
82673
|
let descendant = assignmentExpression;
|
|
80693
82674
|
let ancestor = descendant.parent;
|
|
80694
82675
|
while (ancestor) {
|
|
80695
82676
|
const test = isNodeOfType(ancestor, "IfStatement") ? stripParenExpression(ancestor.test) : null;
|
|
80696
|
-
if (isNodeOfType(ancestor, "IfStatement") && test && isNodeOfType(test, "UnaryExpression") && test.operator === "!" && isSameRefCurrentAlias(test.argument, refSymbol, scopes) && ancestor.consequent === descendant &&
|
|
82677
|
+
if (isNodeOfType(ancestor, "IfStatement") && test && isNodeOfType(test, "UnaryExpression") && test.operator === "!" && isSameRefCurrentAlias(test.argument, refSymbol, scopes) && ancestor.consequent === descendant && isPredictableGuardedInitialization(assignmentExpression, ancestor.consequent, renderOwner, refSymbol, scopes, true)) return true;
|
|
80697
82678
|
if (isNodeOfType(ancestor, "IfStatement") && isNodeOfType(test, "BinaryExpression") && [
|
|
80698
82679
|
"===",
|
|
80699
82680
|
"==",
|
|
@@ -80703,7 +82684,7 @@ const isDocumentedLazyInitialization = (assignmentExpression, refSymbol, scopes)
|
|
|
80703
82684
|
const { left, right } = test;
|
|
80704
82685
|
const comparesEmptySentinel = isSameRefCurrentAlias(left, refSymbol, scopes) && isEmptySentinel(right, scopes) || isSameRefCurrentAlias(right, refSymbol, scopes) && isEmptySentinel(left, scopes);
|
|
80705
82686
|
const guardedBranch = test.operator === "===" || test.operator === "==" ? ancestor.consequent : ancestor.alternate;
|
|
80706
|
-
if (comparesEmptySentinel && guardedBranch === descendant && guardedBranch &&
|
|
82687
|
+
if (comparesEmptySentinel && guardedBranch === descendant && guardedBranch && isPredictableGuardedInitialization(assignmentExpression, guardedBranch, renderOwner, refSymbol, scopes, false)) return true;
|
|
80707
82688
|
}
|
|
80708
82689
|
descendant = ancestor;
|
|
80709
82690
|
ancestor = descendant.parent;
|
|
@@ -88308,6 +90289,11 @@ const noUndersizedIconButton = defineRule({
|
|
|
88308
90289
|
//#region src/plugin/rules/correctness/no-unescaped-dynamic-string-in-regexp.ts
|
|
88309
90290
|
const TEST_CONTEXT_FILE_PATTERN = /(\.test\.|\.spec\.|__tests__|(^|\/)(test|tests|e2e|cypress|playwright)\/)/;
|
|
88310
90291
|
const SEARCH_TERM_NAME_PATTERN = /search|query|highlight|filter|term(?!in)|keyword/i;
|
|
90292
|
+
const REGEX_SOURCE_WORDS = [
|
|
90293
|
+
"pattern",
|
|
90294
|
+
"regex",
|
|
90295
|
+
"regexp"
|
|
90296
|
+
];
|
|
88311
90297
|
const ESCAPE_HELPER_NAME_PATTERN = /escape.*reg|safe.*reg/i;
|
|
88312
90298
|
const SANITIZED_NAME_PATTERN = /escap|sanitiz/i;
|
|
88313
90299
|
const INITIALIZER_RESOLUTION_HOPS = 2;
|
|
@@ -88461,14 +90447,70 @@ const isTypePositionIdentifier = (identifier) => {
|
|
|
88461
90447
|
}
|
|
88462
90448
|
return false;
|
|
88463
90449
|
};
|
|
88464
|
-
const
|
|
88465
|
-
const
|
|
90450
|
+
const identifierNameHasPathSegmentSemantics = (identifierName) => {
|
|
90451
|
+
const identifierWords = identifierName.replaceAll(/([a-z0-9])([A-Z])/g, "$1 $2").split(/[\s_]+/).map((word) => word.toLowerCase());
|
|
90452
|
+
if (identifierWords.some((word) => REGEX_SOURCE_WORDS.includes(word))) return false;
|
|
90453
|
+
return identifierWords.some((word) => [
|
|
90454
|
+
"path",
|
|
90455
|
+
"folder",
|
|
90456
|
+
"directory",
|
|
90457
|
+
"root"
|
|
90458
|
+
].includes(word)) || identifierWords.includes("top") && identifierWords.includes("level");
|
|
90459
|
+
};
|
|
90460
|
+
const flattenPatternParts = (expression) => {
|
|
90461
|
+
const inner = stripParenExpression(expression);
|
|
90462
|
+
const staticValue = literalStringValue(inner);
|
|
90463
|
+
if (staticValue !== null) return [staticValue];
|
|
90464
|
+
if (isNodeOfType(inner, "Identifier")) return [inner];
|
|
90465
|
+
if (isNodeOfType(inner, "TemplateLiteral")) {
|
|
90466
|
+
const parts = [];
|
|
90467
|
+
for (let index = 0; index < inner.quasis.length; index += 1) {
|
|
90468
|
+
const quasi = inner.quasis[index];
|
|
90469
|
+
if (quasi) parts.push(quasi.value.cooked ?? quasi.value.raw);
|
|
90470
|
+
const templateExpression = inner.expressions[index];
|
|
90471
|
+
if (templateExpression) parts.push(stripParenExpression(templateExpression));
|
|
90472
|
+
}
|
|
90473
|
+
return parts;
|
|
90474
|
+
}
|
|
90475
|
+
if (isNodeOfType(inner, "BinaryExpression") && inner.operator === "+") {
|
|
90476
|
+
const leftParts = flattenPatternParts(inner.left);
|
|
90477
|
+
const rightParts = flattenPatternParts(inner.right);
|
|
90478
|
+
return leftParts && rightParts ? [...leftParts, ...rightParts] : null;
|
|
90479
|
+
}
|
|
90480
|
+
if (isNodeOfType(inner, "CallExpression") && isNodeOfType(inner.callee, "MemberExpression") && getStaticPropertyName(inner.callee) === "concat") {
|
|
90481
|
+
const receiverParts = flattenPatternParts(inner.callee.object);
|
|
90482
|
+
if (!receiverParts) return null;
|
|
90483
|
+
const parts = [...receiverParts];
|
|
90484
|
+
for (const argument of inner.arguments) {
|
|
90485
|
+
if (isNodeOfType(argument, "SpreadElement")) return null;
|
|
90486
|
+
const argumentParts = flattenPatternParts(argument);
|
|
90487
|
+
if (!argumentParts) return null;
|
|
90488
|
+
parts.push(...argumentParts);
|
|
90489
|
+
}
|
|
90490
|
+
return parts;
|
|
90491
|
+
}
|
|
90492
|
+
return null;
|
|
90493
|
+
};
|
|
90494
|
+
const isIdentifierAnAnchoredPathSegment = (argument, identifier) => {
|
|
90495
|
+
if (!identifierNameHasPathSegmentSemantics(identifier.name)) return false;
|
|
90496
|
+
const parts = flattenPatternParts(argument);
|
|
90497
|
+
if (!parts) return false;
|
|
90498
|
+
const identifierPartIndex = parts.findIndex((part) => part === identifier);
|
|
90499
|
+
if (identifierPartIndex < 0) return false;
|
|
90500
|
+
const precedingParts = parts.slice(0, identifierPartIndex);
|
|
90501
|
+
if (precedingParts.some((part) => typeof part !== "string")) return false;
|
|
90502
|
+
const staticPrefix = precedingParts.join("");
|
|
90503
|
+
const followingPart = parts[identifierPartIndex + 1];
|
|
90504
|
+
return staticPrefix === "^" && typeof followingPart === "string" && followingPart.startsWith("/");
|
|
90505
|
+
};
|
|
90506
|
+
const collectRawDynamicLiteralIdentifiers = (argument) => {
|
|
90507
|
+
const rawDynamicLiteralIdentifiers = [];
|
|
88466
90508
|
walkAst(argument, (child) => {
|
|
88467
90509
|
if (isEscapingCall(child) || isRegexSourceAccess(child)) return false;
|
|
88468
90510
|
if (isLiteralReturningGetterCall(child)) return false;
|
|
88469
|
-
if (isNodeOfType(child, "Identifier") && SEARCH_TERM_NAME_PATTERN.test(child.name) && !isPropertyNamePosition(child) && !isTypePositionIdentifier(child))
|
|
90511
|
+
if (isNodeOfType(child, "Identifier") && (SEARCH_TERM_NAME_PATTERN.test(child.name) || isIdentifierAnAnchoredPathSegment(argument, child)) && !isPropertyNamePosition(child) && !isTypePositionIdentifier(child)) rawDynamicLiteralIdentifiers.push(child);
|
|
88470
90512
|
});
|
|
88471
|
-
return
|
|
90513
|
+
return rawDynamicLiteralIdentifiers;
|
|
88472
90514
|
};
|
|
88473
90515
|
const collectLeafIdentifiers = (node) => {
|
|
88474
90516
|
const leafIdentifiers = [];
|
|
@@ -88479,8 +90521,11 @@ const collectLeafIdentifiers = (node) => {
|
|
|
88479
90521
|
return leafIdentifiers;
|
|
88480
90522
|
};
|
|
88481
90523
|
const compositeInitializerResolvesEscaped = (strippedInitializer, remainingHops, scopes, regexpObjectSymbolIds, globalRegExpObjectNames) => {
|
|
90524
|
+
if (isNodeOfType(strippedInitializer, "ConditionalExpression")) return [strippedInitializer.consequent, strippedInitializer.alternate].every((branch) => initializerLooksEscaped(branch, remainingHops, scopes, regexpObjectSymbolIds, globalRegExpObjectNames));
|
|
90525
|
+
if (isNodeOfType(strippedInitializer, "BinaryExpression") || isNodeOfType(strippedInitializer, "LogicalExpression")) return [strippedInitializer.left, strippedInitializer.right].every((operand) => initializerLooksEscaped(operand, remainingHops, scopes, regexpObjectSymbolIds, globalRegExpObjectNames));
|
|
90526
|
+
if (isNodeOfType(strippedInitializer, "TemplateLiteral")) return strippedInitializer.expressions.every((expression) => initializerLooksEscaped(expression, remainingHops, scopes, regexpObjectSymbolIds, globalRegExpObjectNames));
|
|
88482
90527
|
let didResolveAnyLeafEscaped = false;
|
|
88483
|
-
for (const leafIdentifier of collectLeafIdentifiers(strippedInitializer)) if (identifierResolvesToEscapedValue(leafIdentifier, remainingHops, scopes, regexpObjectSymbolIds, globalRegExpObjectNames)) didResolveAnyLeafEscaped = true;
|
|
90528
|
+
for (const leafIdentifier of collectLeafIdentifiers(strippedInitializer)) if (identifierResolvesToEscapedValue(leafIdentifier, remainingHops - 1, scopes, regexpObjectSymbolIds, globalRegExpObjectNames)) didResolveAnyLeafEscaped = true;
|
|
88484
90529
|
else if (SEARCH_TERM_NAME_PATTERN.test(leafIdentifier.name)) return false;
|
|
88485
90530
|
return didResolveAnyLeafEscaped;
|
|
88486
90531
|
};
|
|
@@ -88492,7 +90537,7 @@ const initializerLooksEscaped = (initializer, remainingHops, scopes, regexpObjec
|
|
|
88492
90537
|
if (isNodeOfType(strippedInitializer, "CallExpression") && (isEscapingCall(strippedInitializer) || calleeBindingBodyEscapes(strippedInitializer))) return true;
|
|
88493
90538
|
if (remainingHops > 0) {
|
|
88494
90539
|
if (isNodeOfType(strippedInitializer, "Identifier")) return identifierResolvesToEscapedValue(strippedInitializer, remainingHops - 1, scopes, regexpObjectSymbolIds, globalRegExpObjectNames);
|
|
88495
|
-
return compositeInitializerResolvesEscaped(strippedInitializer, remainingHops
|
|
90540
|
+
return compositeInitializerResolvesEscaped(strippedInitializer, remainingHops, scopes, regexpObjectSymbolIds, globalRegExpObjectNames);
|
|
88496
90541
|
}
|
|
88497
90542
|
return false;
|
|
88498
90543
|
};
|
|
@@ -88684,7 +90729,7 @@ const noUnescapedDynamicStringInRegexp = defineRule({
|
|
|
88684
90729
|
severity: "warn",
|
|
88685
90730
|
category: "Correctness",
|
|
88686
90731
|
tags: ["test-noise"],
|
|
88687
|
-
recommendation: "A search
|
|
90732
|
+
recommendation: "A dynamic literal string such as a search term or path segment dropped straight into `new RegExp(...)` lets its regex metacharacters act as operators, so values containing `.` or `(` over-match or throw. Escape the value with an `escapeRegExp` helper before constructing the pattern.",
|
|
88688
90733
|
create: (context) => {
|
|
88689
90734
|
if (TEST_CONTEXT_FILE_PATTERN.test(context.filename ?? "")) return {};
|
|
88690
90735
|
let regexpObjectIndex = null;
|
|
@@ -88701,10 +90746,10 @@ const noUnescapedDynamicStringInRegexp = defineRule({
|
|
|
88701
90746
|
regexpObjectIndex = buildRegExpObjectIndex(programRoot, context.scopes);
|
|
88702
90747
|
}
|
|
88703
90748
|
const currentRegExpObjectIndex = regexpObjectIndex;
|
|
88704
|
-
if (!
|
|
90749
|
+
if (!collectRawDynamicLiteralIdentifiers(firstArgument).some((identifier) => !identifierResolvesToEscapedValue(identifier, INITIALIZER_RESOLUTION_HOPS, context.scopes, currentRegExpObjectIndex.regexpObjectSymbolIds, currentRegExpObjectIndex.globalRegExpObjectNames) && !isShapeTestedByDominatingGuard(node, identifier, context.scopes) && !isParameterFedOnlyMetacharacterFreeLiterals(identifier, context.scopes))) return;
|
|
88705
90750
|
context.report({
|
|
88706
90751
|
node,
|
|
88707
|
-
message: "This builds a `RegExp` from a dynamic
|
|
90752
|
+
message: "This builds a `RegExp` from a dynamic literal string without escaping it, so regex metacharacters in the value act as operators and over-match or throw. Escape the value with an `escapeRegExp` helper first."
|
|
88708
90753
|
});
|
|
88709
90754
|
};
|
|
88710
90755
|
return {
|
|
@@ -108446,9 +110491,6 @@ const rerenderFunctionalSetstate = defineRule({
|
|
|
108446
110491
|
} })
|
|
108447
110492
|
});
|
|
108448
110493
|
//#endregion
|
|
108449
|
-
//#region src/plugin/utils/is-trivial-built-in-construction.ts
|
|
108450
|
-
const isTrivialBuiltInConstruction = (expression) => isNodeOfType(expression, "NewExpression") && isNodeOfType(expression.callee, "Identifier") && TRIVIAL_CONSTRUCTOR_NAMES.has(expression.callee.name) && (expression.arguments ?? []).length === 0;
|
|
108451
|
-
//#endregion
|
|
108452
110494
|
//#region src/plugin/rules/state-and-effects/rerender-lazy-ref-init.ts
|
|
108453
110495
|
const rerenderLazyRefInit = defineRule({
|
|
108454
110496
|
id: "rerender-lazy-ref-init",
|
|
@@ -108467,7 +110509,6 @@ const rerenderLazyRefInit = defineRule({
|
|
|
108467
110509
|
const memberPropertyName = isNodeOfType(callee, "MemberExpression") && (isNodeOfType(callee.property, "Identifier") || isNodeOfType(callee.property, "PrivateIdentifier")) ? callee.property.name : null;
|
|
108468
110510
|
const calleeName = isNodeOfType(callee, "Identifier") ? callee.name : memberPropertyName ?? "fn";
|
|
108469
110511
|
if (TRIVIAL_INITIALIZER_NAMES.has(calleeName)) return;
|
|
108470
|
-
if (isTrivialBuiltInConstruction(initializer)) return;
|
|
108471
110512
|
if (isPlainCall && isReactHookName(calleeName)) return;
|
|
108472
110513
|
const callShape = isNewCall ? `new ${calleeName}()` : `${calleeName}()`;
|
|
108473
110514
|
context.report({
|
|
@@ -140049,6 +142090,7 @@ const shouldReadSecurityScanContent = (relativePath, isGeneratedBundle) => isGen
|
|
|
140049
142090
|
//#region src/plugin/utils/capability.ts
|
|
140050
142091
|
const FRAMEWORK_TOKENS = [
|
|
140051
142092
|
"nextjs",
|
|
142093
|
+
"astro",
|
|
140052
142094
|
"vite",
|
|
140053
142095
|
"cra",
|
|
140054
142096
|
"remix",
|